Re: Review Request 39782: Add a comment for os::libraries::setPaths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/#review107146 --- Bad patch! Reviews applied: [39780, 39781] Failed command:

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review107154 --- Ship it! - Benjamin Bannier On Nov. 18, 2015, 11:09 a.m., Neil

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

> On Nov. 18, 2015, 10:57 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 233 > > > > > > You didn't start this, but any `struct` token here is unnecessary noise > >

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 19, 2015, 9:39 a.m.) Review request for mesos, Alexander

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- (Updated Nov. 19, 2015, 9:56 a.m.) Review request for mesos, Alexander

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

> On Nov. 18, 2015, 4:56 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 224 > > > > > > I'm a bit concerned whether it's a good solution to put this flag in > > the request body. I'd say

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107151 --- Patch looks great! Reviews applied: [40371] Passed command:

Re: Review Request 40339: Added a flag to master to enable optimistic offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review107206 --- Overall notes: * Looks like everything is in place (to my

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review106966 --- docs/persistent-volume.md (lines 255 - 280)

Re: Review Request 40398: Quota: Extended allocator interface with recovery method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40398/#review107208 --- Do we have this added to the design doc (or Jira ticket), it would

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- (Updated Nov. 19, 2015, 7:10 p.m.) Review request for mesos, Alexander

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

> On Nov. 18, 2015, 5:08 p.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 224 > > > > > > As discussed offline I would prefere a single json object per request > > which is discussed by MESOS-3914.

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107212 --- Ship it! src/tests/master_quota_tests.cpp (lines 458 - 460)

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40291/#review107223 --- Ship it! We might want to clarify that if you have a multi-line

Re: Review Request 40469: Update Allocator interface to support dynamic roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review107225 --- include/mesos/master/allocator.hpp (line 401)

Review Request 40497: Add hex number support to numify()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/ --- Review request for mesos, Ben Mahler and Ian Downes. Repository: mesos

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Nov. 19, 2015, 8:15 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 40268: [WIP] Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/#review107242 --- i'm discarding this review to unblock review bot -- @vinodkone -

Re: Review Request 40507: Cleanup leaked containerizer and potentially orphaned process in SlaveTest.LaunchTaskInfoWithContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40507/ --- (Updated Nov. 19, 2015, 3:38 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/#review107278 --- Ship it! src/master/master.cpp (line 2792)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review107281 --- src/master/master.cpp (lines 3016 - 3028)

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Nov. 20, 2015, 1:27 a.m.) Review request for mesos, Kapil Arya and

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- (Updated Nov. 20, 2015, 1:27 a.m.) Review request for mesos, Kapil Arya and

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- (Updated Nov. 20, 2015, 1:27 a.m.) Review request for mesos, Kapil Arya and

Re: Review Request 40511: Disabled docker bridge executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40511/#review107276 --- src/tests/containerizer/docker_containerizer_tests.cpp (lines 282

Re: Review Request 40511: Disabled docker bridge executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40511/#review107277 --- Ship it! Ship It! - Jie Yu On Nov. 20, 2015, midnight, Timothy

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review107279 --- Ship it! Ship It! - Jie Yu On Nov. 19, 2015, 11:41 p.m., Greg

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Nov. 13, 2015, 11:38 p.m., Jie Yu wrote: > > src/master/http.cpp, line 853 > > > > > > This looks problematic to me. 'this' will become invalid once this > > function returns. That means when `_reserve` is

Review Request 40511: Disabled docker bridge executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40511/ --- Review request for mesos, Bernd Mathiske, Jie Yu, and Marco Massenzio. Bugs:

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 20, 2015, 2:01 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40469: Update Allocator interface to support dynamic roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Nov. 20, 2015, 2:02 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 19, 2015, 11:41 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/#review107280 --- src/master/master.cpp (lines 3278 - 3288)

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39989/ --- (Updated Nov. 20, 2015, 12:20 a.m.) Review request for mesos, Adam B, Jie Yu,

Review Request 40498: Used factory method to create HDFS client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40498/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. Bugs:

Re: Review Request 39416: Document --egress_unique_flow_per_container in docs/configuration.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39416/ --- (Updated Nov. 19, 2015, 8:09 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

> On Nov. 19, 2015, 2:44 a.m., Guangya Liu wrote: > > docs/reservation.md, line 242 > > > > > > This will not work if end user did not enable autheration, a JIRA > > ticket is tracing this MESOS-3940, shall we

Re: Review Request 40285: Changed untar process to pipe STDERR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/ --- (Updated Nov. 19, 2015, 6:05 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39712: Serialize Docker Registry Responses as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/ --- (Updated Nov. 19, 2015, 11:37 a.m.) Review request for mesos, Jie Yu, Jojy

Re: Review Request 40459: Added 2 slave flags --advertise_ip and --advertise_port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40459/#review107234 --- Ship it! Ship It! - Vinod Kone On Nov. 19, 2015, 12:58 a.m.,

Re: Review Request 39712: Serialize Docker Registry Responses as Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/#review107240 --- Patch looks great! Reviews applied: [38901, 38919, 39712] Passed

Re: Review Request 39415: Error out when root qdisc already exists

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39415/ --- (Updated Nov. 19, 2015, 8:08 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107247 --- Bad patch! Reviews applied: [40497] Failed command:

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

> On Nov. 14, 2015, 12:07 a.m., Jie Yu wrote: > > src/master/master.cpp, lines 3037-3049 > > > > > > Hum, this looks problematic to me. The authorization results are stored > > in 'futures'. The ordering in

Re: Review Request 40497: Add hex number support to numify()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/ --- (Updated Nov. 19, 2015, 10:56 p.m.) Review request for mesos, Ben Mahler and

Review Request 40506: Add stdout/tests/numify_tests.cpp into Makefile.am

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40506/ --- Review request for mesos, Ben Mahler and Ian Downes. Repository: mesos

Re: Review Request 40464: Fixed a few style issues in HDFS wrapper code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40464/ --- (Updated Nov. 19, 2015, 10:16 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/#review107265 --- src/tests/master_quota_tests.cpp

Re: Review Request 40268: [WIP] Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.

> On Nov. 19, 2015, 1:33 p.m., Vinod Kone wrote: > > i'm discarding this review to unblock review bot -- @vinodkone Oops, I didn't know that reviewbot would get stuck on a (dangling?) review like this :) - Joseph --- This is an

Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40501/ --- Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Joris Van

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

> On Nov. 14, 2015, 12:07 a.m., Jie Yu wrote: > > src/master/master.cpp, lines 3037-3049 > > > > > > Hum, this looks problematic to me. The authorization results are stored > > in 'futures'. The ordering in

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Nov. 13, 2015, 11:38 p.m., Jie Yu wrote: > > src/master/http.cpp, line 853 > > > > > > This looks problematic to me. 'this' will become invalid once this > > function returns. That means when `_reserve` is

Re: Review Request 39415: Error out when root qdisc already exists

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39415/#review107270 --- Ship it! Ship It! - Jie Yu On Nov. 19, 2015, 8:08 p.m., Cong

Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.

> On Nov. 14, 2015, 12:07 a.m., Jie Yu wrote: > > src/master/master.cpp, lines 3037-3049 > > > > > > Hum, this looks problematic to me. The authorization results are stored > > in 'futures'. The ordering in

Review Request 40507: Cleanup leaked containerizer and potentially orphaned process in SlaveTest.LaunchTaskInfoWithContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40507/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

> On Nov. 16, 2015, 3:37 p.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 188 > > > > > > Should this be part of the validation below? > > Jan Schlicht wrote: > I'd rather put it into

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

> On Nov. 16, 2015, 2:37 p.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 188 > > > > > > Should this be part of the validation below? > > Jan Schlicht wrote: > I'd rather put it into

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Oct. 25, 2015, 3:51 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, line 705 > > > > > > I see that most of the test cases are not using xx_xx to name the test > > function, can we rename

Re: Review Request 40469: Update Allocator interface to support dynamic roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review107162 --- Patch looks great! Reviews applied: [40431, 40469] Passed

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Nov. 19, 2015, 10:39 a.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 195 > > > > > > Am I right that there is another way to achieve the same: > > ``` > >

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Nov. 19, 2015, 12:43 p.m.) Review request for mesos, Alexander

Re: Review Request 40459: Added 2 slave flags --advertise_ip and --advertise_port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40459/#review107158 --- Patch looks great! Reviews applied: [40459] Passed command:

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review107157 --- include/mesos/quota/quota.proto (line 56)

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- (Updated Nov. 19, 2015, 11:55 a.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Nov. 19, 2015, 1:55 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 724 > > > > > > I can't understand, why `quota` and not `guarantees`. What am I missing? The updated review :-).

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Nov. 6, 2015, 1:13 a.m., Joseph Wu wrote: > > src/tests/master_quota_tests.cpp, lines 732-734 > > > > > > Have you considered merging this test with > > `AvailableResourcesMultipleAgents`? > > Joerg Schad

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Nov. 19, 2015, 3:19 p.m.) Review request for mesos, Alexander

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review107298 --- src/Makefile.am (line 955)

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

> On Nov. 19, 2015, 6:16 p.m., Neil Conway wrote: > > Good find. I wonder: > > > > (a) is there some general advice we should give to people implementing > > Processes (e.g., "always provide a destructor that does terminate/wait" -- > > that is probably too broad though). Would be nice to add

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40392/ --- (Updated Nov. 20, 2015, 5:44 a.m.) Review request for mesos, Alexander

Re: Review Request 40524: WIP: Enabled std::string namespace for resources.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40524/ --- (Updated 十一月 20, 2015, 5:54 a.m.) Review request for mesos and Klaus Ma.

Re: Review Request 40339: WIP: Added a flag to master to enable optimistic offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十一月 20, 2015, 3:25 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40501/#review107301 --- Ship it! Great catach! - Bernd Mathiske On Nov. 19, 2015, 1:51

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

> On Nov. 19, 2015, 11:10 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 460 > > > > > > Could you please restore this blank line? Sure, but FYI this style is consistent with the the

Review Request 40524: Enabled std::string namespace for resources.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40524/ --- Review request for mesos and Klaus Ma. Bugs: MESOS-3955

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40501/#review107290 --- Ship it! Good find. I wonder: (a) is there some general advice

Re: Review Request 40244: Clarified comments in Master::Http::_operation.

> On Nov. 18, 2015, 4:05 p.m., Qian Zhang wrote: > > src/master/http.cpp, line 2097 > > > > > > This comment may not be related to this patch. I am just curious, for > > ```required```, we have called

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/#review107306 --- src/tests/master_quota_tests.cpp (line 222)

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107192 --- Bad patch! Reviews applied: [40284, 40285] Failed command:

Re: Review Request 40459: Added 2 slave flags --advertise_ip and --advertise_port.

> On 十一月 19, 2015, 2:57 a.m., Guangya Liu wrote: > > docs/configuration.md, lines 37-54 > > > > > > I think that the master/main.cpp should also be updated for those > > flages. > > Anindya Sinha wrote: > It is

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 18, 2015, 3:51 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Re: Review Request 40339: WIP: Added a flag to master to enable optimistic offers.

> On 十一月 19, 2015, 5:59 p.m., Joseph Wu wrote: > > Overall notes: > > * Looks like everything is in place (to my knowledge) for this change :) > > * (Mentioned in the last working group sync) We **may** want to rename the > > feature to something else, like "oversubscription for reservations".

Re: Review Request 40524: WIP: Enabled std::string namespace for resources.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40524/#review107311 --- include/mesos/resources.hpp (line 41)

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review107313 --- src/tests/master_quota_tests.cpp (line 482)

Re: Review Request 40396: Quota: Added a test for offer rescinding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/#review107310 --- src/tests/master_quota_tests.cpp (line 454)

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review107314 --- src/tests/master_quota_tests.cpp (line 332)

Re: Review Request 40524: WIP: Enabled std::string namespace for resources.hpp

> On Nov. 20, 2015, 2:03 p.m., Klaus Ma wrote: > > include/mesos/resources.hpp, line 41 > > > > > > Generally, we did not use `using` in header in C++; it may conflict > > with the `using` in cpp files. > > > >

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 20, 2015, 6:42 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/ --- (Updated Nov. 20, 2015, 7:45 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107322 --- Bad patch! Reviews applied: [39415, 39416, 40497, 40506, 39417]

Review Request 40529: WIP: Added helper function to get stateless resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- Review request for mesos and Klaus Ma. Bugs: MESOS-3955

Re: Review Request 40244: Clarified comments in Master::Http::_operation.

> On Nov. 18, 2015, 8:05 a.m., Qian Zhang wrote: > > src/master/http.cpp, line 2097 > > > > > > This comment may not be related to this patch. I am just curious, for > > ```required```, we have called

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/ --- (Updated Nov. 19, 2015, 3:37 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review107185 --- src/master/quota_handler.cpp (line 347)

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review107187 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913,

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Nov. 19, 2015, 4:05 p.m.) Review request for mesos, Alexander

Re: Review Request 39614: Quota: Added Status Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review107181 --- src/tests/master_quota_tests.cpp (line 435)

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Nov. 19, 2015, 2:53 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 338 > > > > > > s/Status/status > > Do you think it makes sense to add `request.body`. > > Joerg Schad wrote: >

Re: Review Request 39614: Quota: Added Status Validation Tests.

> On Nov. 19, 2015, 3:34 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 521 > > > > > > `protobuf::parse()` does not compile? No. - Joerg

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Nov. 19, 2015, 4:06 p.m.) Review request for mesos, Alexander

  1   2   >