Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/ --- (Updated April 13, 2016, 1:37 p.m.) Review request for mesos, Avinash

Re: Review Request 45956: Added the `_isolate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 13, 2016, 5:22 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45956: Added the `_isolate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/#review128609 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 45956: Added the `_isolate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 13, 2016, 4:40 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45265: Plugged in dvd isolator into agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45265/ --- (Updated 四月 13, 2016, 3:29 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45265: Plugged in dvd isolator into agent.

> On 四月 4, 2016, 11:04 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 73 > > > > > > One newline above. I was putting it into a new #ifdef. - Guangya

Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/ --- Review request for mesos, Adam B and Alexander Rukletsov. Bugs: MESOS-5146

Re: Review Request 45217: Implemented docker volume driver isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/ --- (Updated 四月 13, 2016, 3:18 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45214: Updated protobuf to support external storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/ --- (Updated 四月 13, 2016, 3:09 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

> On 四月 8, 2016, 12:40 a.m., Kevin Klues wrote: > > Thanks for the update! > > > > Doing a quick `git-grep` after applying the patch, I still see a few > > references to `mesos-slave` throughout the code base. Alot of these are in > > the documentation (which I think should be covered by

Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/ --- Review request for mesos. Repository: mesos Description ---

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 13, 2016, 2:57 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 13, 2016, 2:52 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated 四月 13, 2016, 2:47 a.m.) Review request for mesos, Alexander

Re: Review Request 46085: Added authentication to agent's /monitor/statistics endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46085/#review128604 --- Patch looks great! Reviews applied: [46083, 46084, 46085]

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44123/#review128602 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

> On April 12, 2016, 6:53 a.m., Jie Yu wrote: > > src/cli/execute.cpp, line 511 > > > > > > You should set DockerInfo network mode as well to 'USER'? Yes, thanks for catching this! - Qian

Re: Review Request 46102: Fixed logic error in execute.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46102/#review128599 --- Ship it! Ship It! - Zhiwei Chen On April 13, 2016, 7:34

Re: Review Request 46102: Fixed logic error in execute.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46102/#review128597 --- Ship it! Ship It! - Klaus Ma On April 13, 2016, 7:34 a.m.,

Re: Review Request 46121: Fixed an assumption of direct /tmp access in a slave test.

> On April 13, 2016, midnight, Gilbert Song wrote: > > src/tests/slave_tests.cpp, line 790 > > > > > > use `os::getcwd()` to make consensus with other tests launching > > containers. After thinking about this a

Re: Review Request 46121: Fixed an assumption of direct /tmp access in a slave test.

> On April 12, 2016, 11:32 p.m., Jie Yu wrote: > > Not yours, but this test should belong to mesos containerizer test (rather > > than slave test). Can you add a TODO? Will do. - Ben --- This is an automatically generated e-mail. To

Re: Review Request 46107: Add Appc runtime spec for command, working directory and environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46107/#review128585 --- Patch looks great! Reviews applied: [46107] Passed command:

Re: Review Request 46121: Fixed an assumption of direct /tmp access in a slave test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46121/#review128578 --- src/tests/slave_tests.cpp (line 790)

Re: Review Request 46102: Fixed logic error in execute.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46102/ --- (Updated 四月 12, 2016, 11:34 p.m.) Review request for mesos and Alexander

Re: Review Request 46121: Fixed an assumption of direct /tmp access in a slave test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46121/#review128580 --- Ship it! Not yours, but this test should belong to mesos

Review Request 46121: Fixed an assumption of direct /tmp access in a slave test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46121/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review128565 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line

Re: Review Request 45604: Updated the balloon framework and executor.

> On April 12, 2016, 3:46 p.m., Vinod Kone wrote: > > src/examples/balloon_executor.cpp, lines 143-153 > > > > > > Why the change here? I couple reasons: * I needed to put the "ballooning" logic into a separate

Re: Review Request 45932: Adds task information to container resource usage information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45932/#review128567 --- Fix it, then Ship it! Just some minor tweaks, I'll take care

Re: Review Request 46097: [WIP] Added tests for 'network/cni' isolator.

> On April 13, 2016, 12:07 a.m., Avinash sridharan wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 68 > > > > > > `hostname -i` might return multiple IP. For example on my Ubuntu 14.04, > > this is

Re: Review Request 45604: Updated the balloon framework and executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/#review128539 --- src/examples/balloon_executor.cpp (line 45)

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/#review128503 --- Fix it, then Ship it! Thanks for the tests, I only commented

Re: Review Request 45941: Add check in agent for incorrect oversubscribed resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45941/#review128502 --- Fix it, then Ship it! Thanks! Will get this committed shortly.

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/#review128564 --- Ship it! Ship It! - Alex Naparu On April 10, 2016, 10:34

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44123/#review128561 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp

Review Request 46114: Fixed per framework principal metrics for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46114/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3923

Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-3923

Review Request 46119: Added documentation around using AuthN for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46119/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3923

Review Request 46116: Added basic authentication scheme to the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46116/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4459

Review Request 46113: Simplified a conditional check while validating framework id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46113/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3923

Review Request 46117: Added `None()` for credentials when creating scheduler lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46117/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4459

Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46118/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4459

Re: Review Request 45614: Windows: Implemented os::close for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45614/#review128556 --- Ship it! Ship It! - Alex Naparu On April 2, 2016, 6:35

Re: Review Request 45614: Windows: Implemented os::close for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45614/#review128554 ---

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44131/#review128553 --- Ship it! Ship It! - Alex Naparu On April 11, 2016, 4:21

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

> On April 12, 2016, 2:37 p.m., Joris Van Remoortere wrote: > > There is no JIRA for this. > > Initializing the winsock system seems like functionality that belongs in a > > helper function rather than inside a test? > > How is libprocess going to initialize it? What about mesos? > > I'm

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

> On April 12, 2016, 2:37 p.m., Joris Van Remoortere wrote: > > There is no JIRA for this. > > Initializing the winsock system seems like functionality that belongs in a > > helper function rather than inside a test? > > How is libprocess going to initialize it? What about mesos? > > I'm

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/#review128543 --- Ship it! Ship It! - Alex Naparu On April 11, 2016, 8:28

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/#review128540 --- 3rdparty/libprocess/3rdparty/stout/tests/main.cpp (line 81)

Re: Review Request 46106: Update RemoveCapabilitiesOnSchedulerFailover to use await exactly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46106/#review128538 --- Patch looks great! Reviews applied: [46106] Passed command:

Re: Review Request 45670: Added tests for HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review128535 --- Are you also planning to update slave recovery tests? Those are

Re: Review Request 44427: Added --http_command_executor flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44427/#review128534 --- src/slave/slave.cpp (lines 5857 - 5870)

Re: Review Request 46104: Made use of random container IDs in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46104/#review128530 --- Patch looks great! Reviews applied: [46003, 46005, 46004, 45562,

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/#review128522 --- src/launcher/http_command_executor.cpp (lines 286 - 287)

Re: Review Request 46085: Added authentication to agent's /monitor/statistics endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46085/ --- (Updated April 12, 2016, 10:04 p.m.) Review request for mesos, Adam B,

Re: Review Request 46102: Fixed logic error in execute.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46102/#review128516 --- Patch looks great! Reviews applied: [46102] Passed command:

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

> On April 9, 2016, 1:34 a.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > > > > > See the ASF CI build error on the attached ticket. > > > > I think specifying configuration options this

Re: Review Request 45985: Fixed the commit message hook to use `echo -n` instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45985/#review128512 --- Ship it! Ship It! - Vinod Kone On April 10, 2016, 6:43

Re: Review Request 42342: Added a new test cases for revive offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review128511 --- Ship it! Ship It! - Vinod Kone On April 10, 2016, 1:18

Re: Review Request 45917: Disable http-parser strict mode to allow flexible http header fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45917/#review128510 --- Ship it! Ship It! - Vinod Kone On April 11, 2016, 2:49

Re: Review Request 46097: [WIP] Added tests for 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review128499 --- Bad patch! Reviews applied: [46097, 46096, 45983, 45956, 45955,

Re: Review Request 45954: Added `subcommand` to `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45954/#review128495 --- Ship it! Ship It! - Jie Yu On April 12, 2016, 2:09 a.m.,

Review Request 46107: Add Appc runtime spec for command, working directory and environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46107/ --- Review request for mesos. Repository: mesos Description --- Add Appc

Review Request 46106: Update RemoveCapabilitiesOnSchedulerFailover to use await exactly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46106/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4171

Re: Review Request 46094: Fixed memory leaks in Encoder/Decoder tests in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46094/#review128490 --- Patch looks great! Reviews applied: [45991, 45995, 45996, 45999,

Re: Review Request 45562: Edited `--work_dir` configuration docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated April 12, 2016, 5:52 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 46004: Updated master '--work_dir' help string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46004/ --- (Updated April 12, 2016, 5:50 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46104: Made use of random container IDs in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46104/ --- (Updated April 12, 2016, 5:52 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46003: Removed the default value for agent work_dir.

> On April 12, 2016, 12:44 a.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 178 > > > > > > Not yours, but can you follow up with a patch to use > > 'UUID::random().toString()'

Re: Review Request 46003: Removed the default value for agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/ --- (Updated April 12, 2016, 5:45 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46005: Updated references to agent work_dir to Option type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46005/ --- (Updated April 12, 2016, 5:50 p.m.) Review request for mesos and Jie Yu.

Review Request 46104: Made use of random container IDs in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46104/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 46085: Added authentication to agent's /monitor/statistics endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46085/#review128467 --- Bad patch! Reviews applied: [46085, 46084, 46083] Failed

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128460 --- 3rdparty/cmake/Mesos3rdpartyConfigure.cmake (lines 22 - 27)

Re: Review Request 45200: Duplicate flags with keyword 'slave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45200/ --- (Updated April 12, 2016, 4:50 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46093: Enhanced the error message for invalid duration unit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46093/#review128453 --- Patch looks great! Reviews applied: [46093] Passed command:

Review Request 46102: Fixed logic error in execute.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46102/ --- Review request for mesos. Repository: mesos Description --- Fixed logic

Re: Review Request 46097: [WIP] Added tests for 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review128446 --- src/tests/containerizer/cni_isolator_tests.cpp (line 68)

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review128441 --- src/slave/http.cpp (line 669)

Re: Review Request 45381: Migrate /monitor/statistics and /monitor/statistics.json to slave.

> On April 12, 2016, 1:38 p.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 748 > > > > > > I believe you should have moved the deprecation comment as well. I > > added it back with

Re: Review Request 46038: Added recommended production config to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46038/#review128428 --- docs/operational-guide.md (line 8)

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review128422 --- Ship it! Ship It! - Alexander Rukletsov On April 9, 2016,

Re: Review Request 46091: Added deprecation comment to .json endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46091/#review128426 --- Patch looks great! Reviews applied: [46091] Passed command:

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/Makefile.am, line 48 > > > > > > Are you missing an entry in `3rdparty/libprocess/3rdparty/Makefile.am`? I see it's

Re: Review Request 46010: Stout:[2/2] Added simple process environment tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46010/#review128424 --- Ship it! Ship It! - Joris Van Remoortere On April 11, 2016,

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46009/#review128420 --- 3rdparty/libprocess/3rdparty/stout/Makefile.am (line 48)

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review128423 --- Fix it, then Ship it! I'll fix the last nit and commit

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44131/#review128419 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 43522: Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43522/#review128418 --- src/tests/oversubscription_tests.cpp (line 1129)

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44123/#review128413 --- Fix it, then Ship it!

Review Request 46097: [WIP] Added tests for 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5167

Re: Review Request 46091: Added deprecation comment to .json endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46091/#review128415 --- Ship it! Ship It! - Jie Yu On April 12, 2016, 1:38 p.m.,

Re: Review Request 46096: Updated prepare() method of "network/cni" isolator for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46096/ --- (Updated April 12, 2016, 10:45 p.m.) Review request for mesos, Avinash

Review Request 46096: Updated prepare() method of "network/cni" isolator for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46096/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5167

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/#review128411 --- Fix it, then Ship it!

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/#review128410 --- There is no JIRA for this. Initializing the winsock system seems

Re: Review Request 46094: Fixed memory leaks in Encoder/Decoder tests in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46094/#review128404 --- 3rdparty/libprocess/src/tests/decoder_tests.cpp (line 202)

Re: Review Request 46084: Added needed forward-declaration for InternalServerError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46084/#review128401 --- Ship it! Ship It! - Joerg Schad On April 12, 2016, 1:06

Re: Review Request 46085: Added authentication to agent's /monitor/statistics endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46085/#review128402 --- Ship it! Ship It! - Alexander Rojas On April 12, 2016, 3:06

Re: Review Request 46083: Used already forward-declared process::http::OK.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46083/#review128400 --- Ship it! Ship It! - Joerg Schad On April 12, 2016, 1:48

  1   2   >