Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review152273 --- I think that for `NvidiaGpuAllocator`, we can add `#ifdef` as

Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/ --- (Updated Oct. 12, 2016, 5:49 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52741: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/#review152272 --- src/cli/execute.cpp (line 298)

Review Request 52774: Added a test for verifying nested container environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52774/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-6323

Review Request 52769: Removed ports ranges benchmark test from scalar benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52769/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5898

Re: Review Request 52703: Added test to test corner case with sorted 'MountInfoTable::read()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52703/#review152260 --- Patch looks great! Reviews applied: [52597, 52596, 52704, 52703]

Re: Review Request 50380: Added new benchmark test for port resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/ --- (Updated 十月 12, 2016, 3:13 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51033: Added validation benchmark test for resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51033/ --- (Updated 十月 12, 2016, 2:40 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50551/ --- (Updated 十月 12, 2016, 2:12 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52767: Used `CHECK(contains(name))` in `DRFSorter::activate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52767/#review152256 --- Ship it! Ship It! - Benjamin Mahler On Oct. 12, 2016, 1:58

Re: Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/#review152251 --- src/slave/containerizer/mesos/containerizer.cpp (lines 1331 -

Re: Review Request 52764: Updated upgrades.md for removing 'recover()' in container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52764/#review152254 --- Fix it, then Ship it! I can fix this before committing.

Review Request 52767: Used `CHECK(contains(name))` in `DRFSorter::activate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52767/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 52678: Fixed race in getting metrics for dominant share.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52678/#review152255 --- Ship it! Ship It! - Benjamin Mahler On Oct. 12, 2016, 1:50

Re: Review Request 52762: Removed 'recover()' interface in 'ContainerLogger'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52762/#review152250 --- Ship it! I'm going to take some liberties with your commit

Re: Review Request 52763: Added MESOS-6371 to Mesos 1.1.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52763/#review152253 --- Ship it! Ship It! - Joseph Wu On Oct. 11, 2016, 5:09 p.m.,

Re: Review Request 52678: Fixed race in getting metrics for dominant share.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52678/ --- (Updated 十月 12, 2016, 1:50 a.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 52741: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/#review152244 --- Patch looks great! Reviews applied: [52741] Passed command:

Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/#review152239 --- don't quite follow the second para in the description. you say

Re: Review Request 52765: Populated `recovered_slaves` in master `/state` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52765/ --- (Updated Oct. 12, 2016, 12:19 a.m.) Review request for mesos, Anand Mazumdar

Review Request 52765: Populated `recovered_slaves` in master `/state` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52765/ --- Review request for mesos. Repository: mesos Description --- Populated

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/ --- (Updated Oct. 12, 2016, 12:18 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52638: Populated `recovered_agents` field in `GetAgents` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52638/ --- (Updated Oct. 12, 2016, 12:18 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52637: Added `recovered_agents` in `GetAgents` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52637/ --- (Updated Oct. 12, 2016, 12:17 a.m.) Review request for mesos, Anand Mazumdar

Review Request 52755: Made default executor handle shutdown events while disconnected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52755/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6363

Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52756/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6370

Re: Review Request 52039: Avoided using SIGUSR1 in two test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52039/#review152234 --- Ship it! Ship It! - Vinod Kone On Sept. 19, 2016, 2:54

Review Request 52763: Added MESOS-6371 to Mesos 1.1.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52763/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, and

Re: Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/ --- (Updated Oct. 11, 2016, 5:09 p.m.) Review request for mesos, Artem

Review Request 52762: Removed 'recover()' interface in 'ContainerLogger'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52762/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, and

Review Request 52764: Updated upgrades.md for removing 'recover()' in container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52764/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152218 --- src/master/master.cpp (lines 3529 - 3555)

Re: Review Request 50674: Stout: Enabled tests that pass on Windows.

> On Aug. 2, 2016, 11:15 p.m., Joseph Wu wrote: > > 3rdparty/stout/tests/flags_tests.cpp, lines 231-235 > > > > > > This test will build on Windows, right? > > > > If so, you should prepend `DISABLED_`

Re: Review Request 50675: Libprocess: Enabled tests that pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50675/ --- (Updated Oct. 11, 2016, 11:49 p.m.) Review request for mesos, Daniel Pravat

Re: Review Request 50674: Stout: Enabled tests that pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50674/ --- (Updated Oct. 11, 2016, 11:49 p.m.) Review request for mesos, Daniel Pravat

Re: Review Request 52738: Used `inspectImage` to get pulled image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52738/#review152224 --- Patch looks great! Reviews applied: [52680, 52727, 52666, 52728,

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Oct. 11, 2016, 10:47 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Oct. 11, 2016, 10:47 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Oct. 11, 2016, 10:47 p.m.) Review request for mesos and Michael Park.

Review Request 52754: Remove unused code which now throws errors with the new hardening flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/ --- Review request for mesos and Michael Park. Bugs: MESOS-6239

Re: Review Request 52647: Fix new sign comparison errors produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- (Updated Oct. 11, 2016, 10:43 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52730: Added an abstraction for Envp pointer expected by exec routines.

> On Oct. 11, 2016, 8:13 p.m., Alex Clemmer wrote: > > Just a quick point here, there is a semantic mismatch between Windows and > > (all?) modern POSIX implementations in the C standard environment APIs. > > Much of this is captured in [1]; if I'm remembering right, I ended up > > concluding

Re: Review Request 52731: Added 'environment' flag to mesos-containerizer launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52731/#review152207 --- Ship it! Ship It! - Gilbert Song On Oct. 10, 2016, 10:39

Re: Review Request 52707: Updated CLI bootstrap to search for local virtualenv installations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52707/#review152205 --- Ship it! Ship It! - Vinod Kone On Oct. 10, 2016, 9:42 p.m.,

Re: Review Request 51258: Add documentation for the ExternalContainerLogger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51258/#review152202 --- Patch looks great! Reviews applied: [51257, 51258] Passed

Re: Review Request 52705: Added 'stout/wait.hpp' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/#review152196 --- 3rdparty/stout/include/stout/wait.hpp (line 17)

Re: Review Request 52730: Added an abstraction for Envp pointer expected by exec routines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52730/#review152195 --- Just a quick point here, there is a semantic mismatch between

Re: Review Request 52730: Added an abstraction for Envp pointer expected by exec routines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52730/#review152193 --- Ship it! Ship It! - Gilbert Song On Oct. 10, 2016, 10:38

Re: Review Request 52647: Fix new errors/warnings produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review152192 --- Need to break this up into one RR for the sign compare fixes and

Re: Review Request 52703: Added test to test corner case with sorted 'MountInfoTable::read()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52703/#review152190 --- Fix it, then Ship it! src/tests/containerizer/fs_tests.cpp

Re: Review Request 52706: Updated mesos containerizer to use new 'stout/wait.hpp' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52706/#review152186 --- Ship it! Ship It! - Jie Yu On Oct. 10, 2016, 9:22 p.m.,

Re: Review Request 52705: Added 'stout/wait.hpp' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/#review152185 --- 3rdparty/stout/include/stout/wait.hpp (line 14)

Re: Review Request 52705: Added 'stout/wait.hpp' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/#review152184 --- Can you update 3rdparty/stout/include/Makefile.am as well? - Jie

Re: Review Request 52705: Added 'stout/wait.hpp' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/#review152183 --- Ship it! Ship It! - Jie Yu On Oct. 10, 2016, 9:22 p.m.,

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

> On Oct. 11, 2016, 4:22 p.m., Jie Yu wrote: > > Can you explain why you want to replace `launcher_dir`? Looking at the > > attached ticket, seems like this is irrelevant? I just updated the patch to also add support for the new env variable to the "default executor". I'm adding this new env

Re: Review Request 52608: Reordered the list of executor env variables in code and documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52608/ --- (Updated Oct. 11, 2016, 6:54 p.m.) Review request for mesos, Alexander

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52556/ --- (Updated Oct. 11, 2016, 6:52 p.m.) Review request for mesos, Alexander

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 11, 2016, 6:51 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 11, 2016, 6:51 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 11, 2016, 6:50 p.m.) Review request for mesos and Joseph Wu.

Review Request 52746: Changed agent to send TASK_DROPPED for task launch failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52746/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332

Re: Review Request 51719: Permitted specifying custom test driver in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51719/#review152172 --- Patch looks great! Reviews applied: [51715, 51716, 51717, 51718,

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

> On Oct. 11, 2016, 12:23 a.m., Joseph Wu wrote: > > src/slave/slave.cpp, lines 4358-4365 > > > > > > It is now possible replace this block with: > > ``` > >

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review152146 --- Patch looks great! Reviews applied: [52250, 52251, 52560, 52561,

Review Request 52741: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5303

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

> On Oct. 10, 2016, 8:32 a.m., Jiang Yan Xu wrote: > > src/launcher/executor.cpp, lines 903-910 > > > > > > You didn't start this but I wonder why we can't consistently use the > > flags, which can be provided

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review152140 --- src/slave/containerizer/docker.cpp (lines 2147 - 2148)

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review152137 --- src/Makefile.am (line 100)

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review152136 --- configure.ac (line 455)

Review Request 52740: Refactored some code into a separate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52740/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332

Re: Review Request 52723: Changed agent to send TASK_DROPPED during reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52723/ --- (Updated Oct. 11, 2016, 2:48 p.m.) Review request for mesos and Vinod Kone.

Review Request 52738: Used `inspectImage` to get pulled image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52738/ --- Review request for mesos, Benjamin Mahler and Kevin Klues. Repository: mesos

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review152132 --- Did you build on mac os? I think that the test will continue to

Re: Review Request 51258: Add documentation for the ExternalContainerLogger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51258/ --- (Updated Oct. 11, 2016, 2:22 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 51257: Add external process container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51257/ --- (Updated Oct. 11, 2016, 2:21 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52727: Added `Labels` to docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52727/ --- (Updated 十月 11, 2016, 12:56 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 52723: Changed agent to send TASK_DROPPED during reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52723/ --- (Updated Oct. 11, 2016, 11:29 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52208: Fixed warnings in health_checker.cpp.

> On Oct. 10, 2016, 3:25 p.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, line 179 > > > > > > Why haven't you used `Duration::create()`? > > Joseph Wu wrote: > Didn't realize that

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

> On Oct. 10, 2016, 3:32 p.m., Jiang Yan Xu wrote: > > src/launcher/executor.cpp, lines 903-910 > > > > > > You didn't start this but I wonder why we can't consistently use the > > flags, which can be provided

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 十月 11, 2016, 8:30 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated 十月 11, 2016, 8:22 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51716: Added configure option for Mesos test runner.

> On Oct. 10, 2016, 5:28 p.m., Till Toenshoff wrote: > > configure.ac, lines 616-617 > > > > > > Not a biggy but maybe it is a good idea to make this better readable / > > parseable by creating a local temporary

Re: Review Request 51717: Enable Mesos test runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51717/ --- (Updated Oct. 11, 2016, 10:19 a.m.) Review request for mesos and Till

Re: Review Request 51718: Permitted specifying custom test driver in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51718/ --- (Updated Oct. 11, 2016, 10:19 a.m.) Review request for mesos and Till

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 十月 11, 2016, 8:19 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51719: Permitted specifying custom test driver in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51719/ --- (Updated Oct. 11, 2016, 10:19 a.m.) Review request for mesos and Till

Re: Review Request 51716: Added configure option for Mesos test runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51716/ --- (Updated Oct. 11, 2016, 10:19 a.m.) Review request for mesos and Till

Re: Review Request 51715: Added a parallel gtest runner.

> On Oct. 10, 2016, 5:22 p.m., Till Toenshoff wrote: > > Looks very good guys - thanks Kevin for reviewing and Benjamin for actually > > making it happen - we all will love this stuff! :) > > > > I specifically like the idea of not finishing right here but keeping an eye > > on the results /

Re: Review Request 51715: Added a parallel gtest runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Oct. 11, 2016, 10:18 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 十月 11, 2016, 8:18 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 十月 11, 2016, 8:16 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十月 11, 2016, 8:16 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 11, 2016, 8:16 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 125-136 > > > > > > 2 spaces > > Yubo Li wrote: > where? > > Guangya Liu wrote: > I mean it should be the following, keep 2

Review Request 52728: Renamed `inspect` to `inspectContainer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52728/ --- Review request for mesos, Benjamin Mahler and Kevin Klues. Bugs: MESOS-5967

Review Request 52666: Added support for `docker inspect image` in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52666/ --- Review request for mesos, Benjamin Mahler and Kevin Klues. Bugs: MESOS-5967

Review Request 52727: Added `Labels` to docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52727/ --- Review request for mesos, Benjamin Mahler and Kevin Klues. Bugs: MESOS-5967

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 125-136 > > > > > > 2 spaces > > Yubo Li wrote: > where? I mean it should be the following, keep 2 space at the start for the

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/ --- (Updated Oct. 11, 2016, 6:21 a.m.) Review request for mesos, Alexander

Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52561/ --- (Updated Oct. 11, 2016, 6:20 a.m.) Review request for mesos, Alexander

  1   2   >