Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Bugs: MESOS

Re: Review Request 36041: The "configure" phase breaks with the IBM JVM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36041/ --- (Updated July 22, 2015, 7:29 a.m.) Review request for mesos. Bugs: MESOS-2216

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/ --- (Updated July 22, 2015, 7:33 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/ --- (Updated July 22, 2015, 7:39 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36680: Added recordio_test.cpp to libprocess Makefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36680/#review92558 --- Patch looks great! Reviews applied: [36677, 36680] All tests passe

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/#review92560 --- Patch looks great! Reviews applied: [36683, 36684] All tests passe

Re: Review Request 36197: Documented "how to become a committer".

> On July 9, 2015, 3:32 p.m., Ben Mahler wrote: > > docs/committers.md, line 11 > > > > > > No unanimous requirement :) > > https://community.apache.org/newcommitter.html @bmahler Would you support shipping this?

Re: Review Request 36617: Improved task reconciliation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 22, 2015, 11:14 a.m.) Review request for mesos and Joerg Schad.

Re: Review Request 36617: Improved task reconciliation documentation.

> On July 21, 2015, 7:28 p.m., Vinod Kone wrote: > > docs/reconciliation.md, line 96 > > > > > > what about other terminal states? Of course! I had only the TASK_LOST send during explicit reconciliation in mind. Oth

Re: Review Request 36617: Improved task reconciliation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 22, 2015, 11:21 a.m.) Review request for mesos and Joerg Schad.

Re: Review Request 36041: The "configure" phase breaks with the IBM JVM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36041/#review92566 --- Patch looks great! Reviews applied: [36041] All tests passed. - M

Re: Review Request 36617: Improved task reconciliation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 22, 2015, 11:41 a.m.) Review request for mesos and Joerg Schad.

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 22, 2015, 10:04 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36425: Enabling IP Discovery script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review92572 --- Patch looks great! Reviews applied: [36424, 36425] All tests passe

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

> On July 14, 2015, 5:13 a.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 99 > > > > > > "/" -> "|" ? Turns out this is a review board display artifact. - Bernd

Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/#review92576 --- I had this reviewed by yet another front end expert (Philip Norman)

Re: Review Request 36617: Improved task reconciliation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92582 --- Patch looks great! Reviews applied: [36617] All tests passed. - M

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92585 --- Patch looks great! Reviews applied: [36612, 36620] All tests passe

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

> On July 20, 2015, 9:46 p.m., Ben Mahler wrote: > > src/tests/rate_limiting_tests.cpp, lines 134-136 > > > > > > Note that in these tests, we've lost the fact that some of these > > subscribe calls should not have

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36586/ --- (Updated July 22, 2015, 6:11 p.m.) Review request for mesos and Ben Mahler. C

Review Request 36698: Updated scheduler library to send REQUEST call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36698/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3089 https://issues.ap

Re: Review Request 36683: Added a persistent volume test for slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/#review92621 --- src/tests/persistent_volume_tests.cpp (lines 595 - 596)

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/#review92622 --- Ship it! src/slave/containerizer/isolators/filesystem/posix.cpp (l

Re: Review Request 36683: Added a persistent volume test for slave recovery.

> On July 22, 2015, 6:22 p.m., Vinod Kone wrote: > > src/tests/persistent_volume_tests.cpp, lines 641-648 > > > > > > This task doesn't look like it is writing a file but rather testing if > > the directory is prese

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92626 --- nice tests! 3rdparty/libprocess/3rdparty/stout/include/stout/recor

Re: Review Request 36680: Added recordio_test.cpp to libprocess Makefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36680/#review92629 --- Ship it! Ship It! - Vinod Kone On July 22, 2015, 6:33 a.m., Ben

Re: Review Request 36698: Updated scheduler library to send REQUEST call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36698/#review92631 --- Patch looks great! Reviews applied: [36698] All tests passed. - M

Re: Review Request 36629: stout: Added support for 'synchronized_wait'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36629/ --- (Updated July 22, 2015, 7:07 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36663: Added ip_address field to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92630 --- Can you write a test for this? include/mesos/mesos.proto (line 374

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

> On July 21, 2015, 10:59 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 676 > > > > > > s/protocol/protocols/ Now that we're only referring to SSL-V3, I think it should be: `s

Re: Review Request 36425: Enabling IP Discovery script

https://issues.apache.org/jira/browse/MESOS-2902 says this will be done in a module instead? Do we still need this review? On Wed, Jul 22, 2015 at 3:31 AM, Mesos ReviewBot wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/#review92638 --- Ship it! + Comments from Artem and BenH. 3rdparty/libprocess/src/

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/ --- (Updated July 22, 2015, 8:09 p.m.) Review request for mesos, Ben Mahler, Michae

Re: Review Request 36683: Added a persistent volume test for slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/ --- (Updated July 22, 2015, 8:09 p.m.) Review request for mesos, Ben Mahler, Michae

Review Request 36705: Libprocess: Replaced ThreadLocal use with thread_local.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36705/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36658: Updated SSL documentation. Added to home page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review92640 --- Sorry, most of the issues I raised in this review are unrelated to t

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/#review92648 --- Patch looks great! Reviews applied: [36683, 36684] All tests passe

Re: Review Request 36627: Fixed cgroups oom killer test on Ubuntu 14.04

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated July 22, 2015, 3:04 p.m.) Review request for mesos, Benjamin Hindman a

Review Request 36708: Added HEARTBEAT event to the scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36708/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler. Bug

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36708/#review92663 --- include/mesos/scheduler/scheduler.proto (lines 46 - 53)

Re: Review Request 36705: Libprocess: Replaced ThreadLocal use with thread_local.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36705/#review92666 --- Patch looks great! Reviews applied: [36629, 36672, 36673, 36674, 36

Re: Review Request 36683: Added a persistent volume test for slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/#review92665 --- src/tests/persistent_volume_tests.cpp (line 598)

Re: Review Request 36698: Updated scheduler library to send REQUEST call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36698/#review92667 --- Ship it! include/mesos/mesos.proto (line 784)

Re: Review Request 36683: Added a persistent volume test for slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/ --- (Updated July 22, 2015, 10:54 p.m.) Review request for mesos, Ben Mahler, Micha

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/ --- (Updated July 22, 2015, 10:55 p.m.) Review request for mesos, Ben Mahler, Micha

Re: Review Request 36683: Added a persistent volume test for slave recovery.

> On July 22, 2015, 10:30 p.m., Vinod Kone wrote: > > src/tests/persistent_volume_tests.cpp, line 700 > > > > > > Would it receive TASK_FAILED here or immediately after slave recovery > > finishes, irrespective of

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/#review92664 --- Ship it! src/slave/containerizer/isolators/filesystem/posix.cpp (l

Re: Review Request 36683: Added a persistent volume test for slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/#review92673 --- Ship it! Ship It! - Vinod Kone On July 22, 2015, 10:54 p.m., Jie

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

> On July 22, 2015, 6:46 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp, lines 54-61 > > > > > > Add comments! Added a javadoc at the top of encoder and decoder to capture t

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/ --- (Updated July 22, 2015, 11:24 p.m.) Review request for mesos, Anand Mazumdar, B

Re: Review Request 36627: Fixed cgroups oom killer test on Ubuntu 14.04

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/#review92682 --- Patch looks great! Reviews applied: [36618, 36627] All tests passe

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92683 --- src/linux/cgroups.cpp (line 1627)

Review Request 36712: Added ONCE guard for Eventloop::initialize

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36712/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Re: Review Request 36712: Added ONCE guard for Eventloop::initialize

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36712/ --- (Updated July 23, 2015, 12:17 a.m.) Review request for mesos and Joris Van Remo

Re: Review Request 36698: Updated scheduler library to send REQUEST call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36698/ --- (Updated July 23, 2015, 12:21 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36708/ --- (Updated July 23, 2015, 12:23 a.m.) Review request for mesos, Anand Mazumdar, B

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36708/#review92687 --- Patch looks great! Reviews applied: [36698, 36708] All tests passe

Review Request 36715: Used std::thread instead of pthread for Libprocess process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36715/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92690 --- I'll add a note about "completion" semantics (surface an error when

Re: Review Request 36712: Added ONCE guard for Eventloop::initialize

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36712/#review92701 --- Patch looks great! Reviews applied: [36712] All tests passed. - M

Review Request 36716: Add NotImplemented status code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36716/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2294 https

Re: Review Request 36716: Add NotImplemented status code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36716/#review92707 --- Ship it! Ship It! - Ben Mahler On July 23, 2015, 2:11 a.m., Anan

Review Request 36717: Add missing include in cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36717/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2294 https://issues.ap

Re: Review Request 36717: Add missing include in cpp file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36717/#review92710 --- Patch looks great! Reviews applied: [36717] All tests passed. - M

Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-3115 htt

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 23, 2015, 4:25 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2294 https://issues.ap

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

> On July 21, 2015, 12:58 a.m., Ben Mahler wrote: > > Thanks Anand! > > > > Couple of issues, per our chat on IRC: > > > > (1) There is no 'pid' for pure HTTP schedulers, so we'll need to ensure > > that the master / slave can handle not having a framework pid, which is a > > bit tricky to ge

Re: Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/#review92721 --- Patch looks great! Reviews applied: [36718] All tests passed. - M

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 23, 2015, 5:47 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review92728 --- Bad patch! Reviews applied: [36717, 36318] Failed command: ./suppo