Re: Review Request 39432: Add /master/frameworks to master endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39432/ --- (Updated 十月 19, 2015, 6:31 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/#review103106 --- Patch looks great! Reviews applied: [39428, 39429] All tests

Re: Review Request 39432: Add /master/frameworks to master endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39432/#review103112 --- Patch looks great! Reviews applied: [39432] All tests passed. -

Review Request 39432: Add /master/frameworks to master endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39432/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3735

Re: Review Request 39444: Fixed typo in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39444/#review103135 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 19, 2015,

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Oct. 19, 2015, 6:49 p.m.) Review request for mesos, Jie Yu, Paul

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39451/#review103149 --- docs/containerizer.md (line 37)

Review Request 39455: Added documentation for asynchronous pimpl pattern used in libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39455/ --- Review request for mesos, Benjamin Hindman, Greg Mann, and Neil Conway.

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- (Updated Oct. 19, 2015, 9:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/ --- (Updated Oct. 19, 2015, 9:35 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review103147 --- support/apply-reviews.py (line 12)

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39360/#review103150 --- This is great! Thanks! The current patch does not apply, can you

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Oct. 19, 2015, 8:11 p.m.) Review request for mesos, Alexander

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/ --- (Updated Oct. 19, 2015, 9:10 p.m.) Review request for mesos, Anand Mazumdar

Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3566

Review Request 39453: Added HTTP docs to libprocess README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/ --- (Updated Oct. 19, 2015, 8:39 p.m.) Review request for mesos and Benjamin

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/ --- (Updated Oct. 19, 2015, 8:58 p.m.) Review request for mesos and Benjamin

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

> On Oct. 19, 2015, 7:27 p.m., Kapil Arya wrote: > > src/slave/paths.cpp, lines 427-429 > > > > > > Why not use the same `LOG(WARNING)` statement? That way the entire > > message will appear together instead of

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/ --- (Updated Oct. 19, 2015, 9:14 p.m.) Review request for mesos, Anand Mazumdar

Review Request 39456: Documentation: added containerizer internals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Review Request 39457: [WIP] Document messages in messages.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Bugs:

Re: Review Request 39449: Documented order of includes.

> On Oct. 19, 2015, 9:13 p.m., Marco Massenzio wrote: > > docs/c++-style-guide.md, line 243 > > > > > > I would specify what .ccp file is this example related to. > > > > I think we have the 'related

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 19, 2015, 9:06 p.m.) Review request for mesos and Ian Downes.

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39360/#review103157 --- You probably want to move src/tests/containerizer too? - Cong

Re: Review Request 39449: Documented order of includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/ --- (Updated Oct. 19, 2015, 11:20 p.m.) Review request for mesos and Michael Park.

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- (Updated Oct. 19, 2015, 9:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39455: Added documentation for asynchronous pimpl pattern used in libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39455/#review103160 --- 3rdparty/libprocess/README.md (line 49)

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39451/ --- (Updated Oct. 19, 2015, 1:26 p.m.) Review request for mesos and Michael Park.

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/ --- (Updated Oct. 19, 2015, 8:48 p.m.) Review request for mesos and Benjamin

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39451/ --- (Updated Oct. 19, 2015, 1:48 p.m.) Review request for mesos and Michael Park.

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

> On Oct. 19, 2015, 7:35 p.m., Michael Park wrote: > > Thanks for doing this! It's definitely clearer (at least to me) as to what > > this flag is controlling. > > > > A few general comments here: > > (1) We should be using ``` in some of the cases instead of `'` right? It > > seems to be a

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103152 --- Ship it! docs/scheduler-http-api.md (line 59)

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Oct. 19, 2015, 9:07 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39453/ --- (Updated Oct. 19, 2015, 9:07 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/ --- (Updated Oct. 19, 2015, 9:19 p.m.) Review request for mesos, Artem

Re: Review Request 39375: Windows: Introduced socket flag interop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39375/ --- (Updated Oct. 19, 2015, 9:19 p.m.) Review request for mesos, Artem

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103163 --- Ship it! Ship It! - Guangya Liu On 十月 19, 2015, 9:27 p.m.,

Review Request 39446: Fixed typos in libprocess docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39446/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 38117: Export per container SNMP statistics

> On Oct. 16, 2015, 6 p.m., Ian Downes wrote: > > include/mesos/mesos.proto, lines 702-720 > > > > > > Are the statistics signed? If not, suggest using uint64 type. Yes, I used uint64 initially and then noticed

Review Request 39451: Fix double dashes typo, highlighting, bullet points

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39451/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 39444: Fixed typo in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39444/ --- (Updated Oct. 19, 2015, 5:53 p.m.) Review request for mesos and Joris Van

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- (Updated Oct. 19, 2015, 7:06 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39449: Documented order of includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review103145 --- docs/c++-style-guide.md (line 241)

Review Request 39444: Fixed typo in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39444/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 39423: Fixed `ExamplesTest.PersistentVolumeFramework` on OS X El Capitan.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39423/#review103143 --- Ship it! Ship It! - Jie Yu On Oct. 19, 2015, 2:39 a.m.,

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103142 --- Patch looks great! Reviews applied: [39447] All tests passed. -

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103148 --- Ship it! Gave it a go :) docs/configuration.md (line 1441)

Re: Review Request 39446: Fixed typos in libprocess docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39446/#review103137 --- Ship it! Ship It! - Till Toenshoff On Oct. 19, 2015, 6:12

Re: Review Request 39446: Fixed typos in libprocess docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39446/#review103138 --- Ship it! Ship It! - Benjamin Hindman On Oct. 19, 2015, 6:12

Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3692

Review Request 39449: Documented order of includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/ --- Review request for mesos and Michael Park. Bugs: MESOS-2275

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103146 --- Thanks for doing this! It's definitely clearer (at least to me) as

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39451/ --- (Updated Oct. 19, 2015, 12:49 p.m.) Review request for mesos and Michael Park.

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Oct. 18, 2015, 11:02 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, lines 182-189 > > > > > > Indent 2 spaces, not the strings themselves, but within the strings. >

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Oct. 18, 2015, 11:02 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 764-768 > > > > > > As mentioned before, let's remove the `default` case entirely. Refer

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- (Updated Oct. 19, 2015, 10:21 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39451/#review103176 --- docs/docker-containerizer.md (lines 22 - 23)

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

> On Oct. 19, 2015, 10:09 p.m., Michael Park wrote: > > docs/configuration.md, line 1445 > > > > > > `\Could not chown work directory\` -- is this intentional? If yes, what > > does it do...? good catch! copy &

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39451/#review103177 --- Patch looks great! Reviews applied: [39451] All tests passed. -

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/#review103180 --- Bad patch! Reviews applied: [39345] Failed command:

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review103182 --- Ship it! See comments below :)

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/ --- (Updated Oct. 19, 2015, 11:55 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 19, 2015, 11:22 p.m., Niklas Nielsen wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 504 > > > > > > Mind adding a comment about the test sequence? Why does the 'test > >

Re: Review Request 39378: Windows: Added support for `process/subprocess.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39378/ --- (Updated Oct. 19, 2015, 11:31 p.m.) Review request for mesos, Artem

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/ --- (Updated Oct. 19, 2015, 5:42 p.m.) Review request for mesos, Adam B and Dave

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/ --- (Updated Oct. 19, 2015, 5:15 p.m.) Review request for mesos and Adam B.

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103170 --- docs/configuration.md (line 1442)

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39451/ --- (Updated Oct. 19, 2015, 3:29 p.m.) Review request for mesos and Michael Park.

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review103186 --- support/site-docker/README.md (line 13)

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

> On Oct. 19, 2015, 10:58 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/README.md, line 378 > > > > > > Nit, How about: > > > > ```A process that initiates > > an asynchronous operation would like

Re: Review Request 39377: Windows: Add Windows support to `process/socket.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39377/ --- (Updated Oct. 19, 2015, 11:26 p.m.) Review request for mesos, Artem

Re: Review Request 39376: Windows: Prepared agent for Windows support of `process/socket.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39376/ --- (Updated Oct. 19, 2015, 11:25 p.m.) Review request for mesos, Artem

Re: Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39381/ --- (Updated Oct. 19, 2015, 11:27 p.m.) Review request for mesos, Artem

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- (Updated Oct. 19, 2015, 11:27 p.m.) Review request for mesos, Artem

Re: Review Request 39380: Windows: Added support for `stout/flags/flags.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39380/ --- (Updated Oct. 19, 2015, 11:27 p.m.) Review request for mesos, Artem

Re: Review Request 39375: Windows: Introduced socket flag interop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39375/ --- (Updated Oct. 19, 2015, 11:25 p.m.) Review request for mesos, Artem

Review Request 39463: Fixed typos in log messages and comments in replicated log code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39463/ --- Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Timothy

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/ --- (Updated Oct. 19, 2015, 11:37 p.m.) Review request for mesos, Artem

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review103191 --- Ship it! Ship It! - Guangya Liu On 十月 20, 2015, 12:42 a.m.,

Re: Review Request 39220: CMake: Added subset of agent target in Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/#review103206 --- Bad patch! Reviews applied: [39375, 39376, 39377, 39378, 39379,

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- (Updated Oct. 20, 2015, 5:37 a.m.) Review request for mesos, Alexander

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103194 --- docs/scheduler-http-api.md (lines 28 - 36)

Re: Review Request 39456: Documentation: added containerizer internals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review103197 --- Patch looks great! Reviews applied: [39456] All tests passed. -

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review103208 --- support/apply-reviews.py (line 23)

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 18, 2015, 12:41 a.m., Michael Park wrote: > > src/common/resources.cpp, line 377 > > > > > > I think you need to check for `resource.role() == "*"` instead, since > > `role` has `[default = "*"]`. Please

Re: Review Request 39223: WIP Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Oct. 20, 2015, 2:15 a.m.) Review request for mesos, Alexander

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39459/#review103199 --- Patch looks great! Reviews applied: [39459] All tests passed. -

Re: Review Request 39455: Added documentation for asynchronous pimpl pattern used in libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39455/#review103204 --- 3rdparty/libprocess/README.md (lines 76 - 77)

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 18, 2015, 6:18 p.m., Michael Park wrote: > > src/common/resources.cpp, lines 482-532 > > > > > > How about a structure like the following? > > > > ```cpp > > Resources result; > > > >

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 20, 2015, 1:03 a.m., Ben Whitehead wrote: > > docs/scheduler-http-api.md, lines 38-57 > > > > > > The rest of the HTTP API Documentation is language agnostic and I feel > > strongly that it should be kept

Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

> On Oct. 18, 2015, 4:18 p.m., Joris Van Remoortere wrote: > > We can use snake case in stout. What made you think that? We certainly haven't been doing that intentionally, and this is still called bootId(), not boot_id().. although I see some snake case slipped in :( - Ben

Re: Review Request 39459: Added docs for using delay() and clocks in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39459/#review103202 --- Ship it! Ship It! - Guangya Liu On 十月 19, 2015, 11:06 p.m.,

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review103214 --- The code diff of #38335 are alos upedted based on master. - Klaus

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

> On Sept. 29, 2015, 3:48 p.m., Alexander Rukletsov wrote: > > src/tests/mesos.hpp, line 1844 > > > > > > We tend not to use `typedef`s in the codebase. However, this looks like > > a good idea, but I would place

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/ --- (Updated Oct. 20, 2015, 2:39 a.m.) Review request for mesos, Alexander

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 20, 2015, 3:14 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39457: Document messages in messages.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/#review103210 --- Patch looks great! Reviews applied: [39457] All tests passed. -