Re: Review Request 39953: Renamed jenkins_build.sh to docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39953/#review105133 --- Ship it! Ship It! - Vinod Kone On Nov. 4, 2015, 8:43 p.m.,

Re: Review Request 39258: Add filesystem isolator with command executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39258/ --- (Updated Nov. 4, 2015, 9:04 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 236 > > > > > > Let's use consistent failure messaging here. > > If you like to

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105166 ---

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

> On Nov. 3, 2015, 5:02 p.m., Michael Hopcroft wrote: > > This is my initial set of comments. I still need to read from line 112 on > > in stat.hpp and I haven't started reading reparsepoint.hpp. Replied to a few project-specific (we might call it "tribal knowledge") points you raised. If

Re: Review Request 39805: Moved filesystems tests to their own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/#review105147 --- Ship it! Kudos for alphabetizing the tests by name.

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review105148 --- Bad patch! Reviews applied: [39838] Failed command:

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 373 > > > > > > Instead of doing this, how about just create a new Image::Name? > >

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 10:05 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 43 > > > > > > This was done in another patch by Ben M (currently in > >

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Nov. 2, 2015, 4:55 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 132 > > > > > > this is weird too. a 'remove patch' function which takes optional patch > > as an argument. Added a comment to

Re: Review Request 39869: Added provisioner TestStore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39869/ --- (Updated Nov. 4, 2015, 9:03 p.m.) Review request for mesos, Jie Yu and Jojy

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39317/#review105165 --- Ship it! include/mesos/master/quota.proto (lines 27 - 32)

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 10:54 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 373 > > > > > > Are you suggesting moving lines 373 and 374 into > >

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 4, 2015, 3:01 p.m.) Review request for mesos, Joris Van

Review Request 39953: Renamed jenkins_build.sh to docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39953/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 39954: Fixed spelling in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39954/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39866/#review105130 --- Ship it! Ship It! - Jie Yu On Nov. 4, 2015, 8:58 p.m., Timothy

Re: Review Request 38900: Update command executor to support rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review105142 --- Ship it! src/slave/slave.cpp (line 3343)

Re: Review Request 39954: Fixed spelling in comments.

> On Nov. 4, 2015, 9:10 p.m., Vinod Kone wrote: > > the diff is empty? hmm thats strange. If you "download" the diff, you will see the patch. - Jojy --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 39834: Made `path_tests.cpp` standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39834/#review105150 --- Ship it! 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review105169 --- Ship it! Thanks Joseph, just a minor comment about the upgrade

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 4, 2015, 3 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 4, 2015, 3 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/ --- (Updated Nov. 4, 2015, 8:47 p.m.) Review request for mesos, Cody Maloney and

Re: Review Request 39868: Moved ProvisionerProcess to header for testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39868/ --- (Updated Nov. 4, 2015, 9:03 p.m.) Review request for mesos, Jie Yu and Jojy

Re: Review Request 39954: Fixed spelling in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39954/#review105135 --- the diff is empty? - Vinod Kone On Nov. 4, 2015, 8:44 p.m.,

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105151 ---

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 4, 2015, 2:30 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 295 > > > > > > Are you trying to check for custom registry? > > > > The Name

Re: Review Request 39948: Remove some undocumented, commented-out code within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39948/#review105129 --- Ship it! Ship It! - Neil Conway On Nov. 4, 2015, 6:50 p.m.,

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39866/ --- (Updated Nov. 4, 2015, 8:58 p.m.) Review request for mesos, Jie Yu and Jojy

Re: Review Request 38900: Update command executor to support rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- (Updated Nov. 4, 2015, 8:59 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 51 > > > > > > Didn''t you pull these out? Not sure what you mean. > On Nov. 4, 2015,

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

> On Nov. 4, 2015, 11:25 a.m., Neil Conway wrote: > > Can we test that more thoroughly than just "make check"? e.g., if there's a > > unit test that tries to enter this logic with multiple threads at once, > > running that with gtest_repeat=1000 would be nice. > > Joseph Wu wrote: > There

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39719/ --- (Updated Nov. 4, 2015, 8:57 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

> On Nov. 4, 2015, 9:12 p.m., Vinod Kone wrote: > > support/verify_reviews.py, line 122 > > > > > > have you verified this change locally? > > > > the docker_build.sh script expects certain environment

Re: Review Request 39258: Add filesystem isolator with command executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39258/#review105143 --- Ship it! src/tests/containerizer/filesystem_isolator_tests.cpp

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 4, 2015, 2:45 p.m.) Review request for mesos, Joris Van

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105167 ---

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/#review105128 --- Ship it! Ship It! - Neil Conway On Nov. 4, 2015, 8:24 p.m.,

Re: Review Request 39954: Fixed spelling in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39954/ --- (Updated Nov. 4, 2015, 8:44 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39719/#review105131 --- Ship it! src/slave/containerizer/mesos/mount.cpp (line 72)

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39914/#review105136 --- support/verify_reviews.py (line 122)

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review105139 --- Ship it! Ship It! - Kapil Arya On Sept. 23, 2015, 9:55 p.m.,

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105134 --- src/Makefile.am (line 564)

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39804/#review105146 --- Ship it! Checked that code did not change in midst of the move.

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 129 > > > > > > Move the timeout after into the RemotePullerProcess. > > Jojy Varghese

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- (Updated Nov. 4, 2015, 11:27 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 4, 2015, 11:27 p.m.) Review request for mesos, Jie Yu, Timothy

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/#review105191 --- src/master/master.cpp (lines 6004 - 6008)

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

> On Nov. 4, 2015, 2:43 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 6039 > > > > > > Why not have the same logic here to be defensive? Or do you intend to > > guard against it? Just seems weird to

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105179 --- Bad patch! Reviews applied: [38705, 38883] Failed command:

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/ --- (Updated Nov. 4, 2015, 4:02 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review105182 --- Ship it! Ship It! - Guangya Liu On 十一月 5, 2015, 12:02 a.m.,

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/#review105181 --- src/tests/mesos.cpp (line 447)

Re: Review Request 39156: RegistryClient refactor: changed getManifest interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39156/#review105196 --- Bad patch! Reviews applied: [39013, 38443, 39184, 39155, 39156]

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39771/#review105173 --- Ship it! Thanks James! Will make the minor adjustment below and

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review105190 --- Ship it! src/master/http.cpp (line 833)

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

> On Nov. 5, 2015, 12:08 a.m., Ben Mahler wrote: > > src/tests/mesos.cpp, line 447 > > > > > > We tend to avoid abbreviations (like ctor, dtor): > > > > ``` > > ? mesos git:(master) ? grep -R

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/ --- (Updated Nov. 5, 2015, 12:56 a.m.) Review request for mesos and Joris Van

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/#review105200 --- Ship it! src/master/master.cpp (lines 4410 - 4418)

Re: Review Request 39703: [WIP] Exposed container-id via TaskStatus updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39703/#review105203 --- include/mesos/mesos.proto (lines 1475 - 1484)

Re: Review Request 39944: Add prefix option for os::environment.

> On Nov. 4, 2015, 6:28 p.m., Jojy Varghese wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp, line 25 > > > > > > Do you intend to copy the string each time? Or a const string& will do?

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

> On Nov. 3, 2015, 2:53 p.m., Kapil Arya wrote: > > src/common/http.cpp, lines 165-189 > > > > > > Actually, my previous comment wasn't quite clear. We can use > > `JSON::Protobuf` for NetworkInfo::IPAddress, but

Re: Review Request 39770: Write a newline in ABORT().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39770/#review105172 --- Ship it! Ship It! - Ben Mahler On Nov. 4, 2015, 12:26 a.m.,

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39016/ --- (Updated Nov. 4, 2015, 11:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

> On Nov. 2, 2015, 8:38 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp, line > > 16 > > > > > > ``? Just for my own education, what parts of `stdlib.h`

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105175 --- Ship it! include/mesos/master/allocator.hpp (lines 332 - 347)

Re: Review Request 39053: RegistryClient refactor: priv method const'ness

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39053/ --- (Updated Nov. 4, 2015, 11:24 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 4, 2015, 11:24 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39112: RegistryClient refactor: fixed variable names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39112/ --- (Updated Nov. 4, 2015, 11:24 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/ --- (Updated Nov. 4, 2015, 4:11 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39947: Refactored mock allocator into a separate header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39947/#review105202 --- Patch looks great! Reviews applied: [39946, 39947] All tests

Re: Review Request 39340: RegistryClient: Added streaming response read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/ --- (Updated Nov. 4, 2015, 11:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/ --- (Updated Nov. 4, 2015, 11:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39947: Refactored mock allocator into a separate header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39947/ --- (Updated Nov. 5, 2015, 12:56 a.m.) Review request for mesos and Joris Van

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39016/#review105212 ---

Re: Review Request 39944: Add prefix option for os::environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39944/ --- (Updated Nov. 5, 2015, 3:18 a.m.) Review request for mesos, Ben Mahler, Jojy

Re: Review Request 39945: Pass SSL related environment variables to executor.

> On Nov. 4, 2015, 6:25 p.m., Jojy Varghese wrote: > > src/slave/containerizer/containerizer.cpp, line 259 > > > > > > Wondering if we can pass in a prefix set to the os::environment. This > > way, we get

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review105208 --- Ship it! Ship It! - Guangya Liu On 十一月 4, 2015, 4:21 p.m.,

Re: Review Request 39966: Fix a typo in ssl.md: After -> Before

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39966/#review105216 --- Patch looks great! Reviews applied: [39966] All tests passed. -

Re: Review Request 39966: Fix a typo in ssl.md: After -> Before

> On Nov. 5, 2015, 11:58 a.m., Anand Mazumdar wrote: > > Can you add Joris (jvanremoortere) as a reviewer who can help you get this > > committed ? added, thanks. - Chengwei --- This is an automatically generated e-mail. To reply,

Re: Review Request 39018: Added JSON parsing for Resources.

> On 十一月 4, 2015, 2:54 a.m., Guangya Liu wrote: > > src/v1/resources.cpp, line 1190 > > > > > > remove this > > Greg Mann wrote: > Rather than removing it, I thought it might be nice to expand this > comment

Re: Review Request 39944: Add prefix option for os::environment.

> On Nov. 4, 2015, 6:58 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp, line 25 > > > > > > Why is this needed? > > And also we prefer Option rather than an

Re: Review Request 39948: Remove some undocumented, commented-out code within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39948/#review105210 --- Ship it! Ship It! - Guangya Liu On 十一月 4, 2015, 6:50 p.m.,

Re: Review Request 39947: Refactored mock allocator into a separate header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39947/#review105211 --- Ship it! Ship It! - Guangya Liu On 十一月 5, 2015, 12:56 a.m.,

Re: Review Request 39628: Clear the suppressed flag when deactive a framework

> On 十月 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this? > > Vinod Kone wrote: > the

Re: Review Request 39968: Enable endpoint include nested paths

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39968/#review105219 --- I'm not sure if this is a good solution or not, @Bmahler, please

Re: Review Request 39848: Validate revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39848/ --- (Updated 十一月 5, 2015, 7:36 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

> On Nov. 4, 2015, 11:25 a.m., Neil Conway wrote: > > Can we test that more thoroughly than just "make check"? e.g., if there's a > > unit test that tries to enter this logic with multiple threads at once, > > running that with gtest_repeat=1000 would be nice. There are tons of methods in

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

> On Nov. 4, 2015, 7:25 p.m., Neil Conway wrote: > > Can we test that more thoroughly than just "make check"? e.g., if there's a > > unit test that tries to enter this logic with multiple threads at once, > > running that with gtest_repeat=1000 would be nice. > > Joseph Wu wrote: > There

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/ --- (Updated Nov. 4, 2015, 12:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39944: Add prefix option for os::environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39944/#review105114 ---

Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere.

Re: Review Request 39949: Document and simplify libprocess initialization synchronization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39949/#review105115 --- Can we test that more thoroughly than just "make check"? e.g., if

Re: Review Request 39941: SIGPIPE is ignored in libprocess so stop handling it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39941/#review105119 --- Patch looks great! Reviews applied: [39938, 39940, 39941] All

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 4, 2015, 12:33 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review105058 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp

Re: Review Request 39860: Quota: Replaced "slave" with "agent" in allocator logs.

> On Nov. 2, 2015, 4:11 p.m., Vinod Kone wrote: > > What's the plan for slave to agent rename in the logs? Having just the > > allocator output agent when the rest of the code base outputs slave will be > > confusing IMO. > > Alexander Rukletsov wrote: > I think we change as we go. I was

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Nov. 4, 2015, 2:37 p.m.) Review request for mesos, Bernd Mathiske,

  1   2   >