Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

org/r/43616/#comment180749> s/Labels/One label? I think that here we should use `one label` but not `labels`, becauase this can only happen if one label include duplicate key-value pairs. - Guangya Liu On 二月 16, 2016, 7:15 p.m., Neil Conway

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

nd and same as following. src/tests/resources_tests.cpp (line 1622) <https://reviews.apache.org/r/43635/#comment180756> s/We // - Guangya Liu On 二月 17, 2016, 12:49 a.m., Neil Conway wrote: > > --- > This is an automa

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

tps://reviews.apache.org/r/43367/#comment180780> Can you please summary the discussion of you and bernd-mesos for why not using `Clock::settle()` so as to let everyone know the detail? - Guangya Liu On 二月 17, 2016, 2:11 a.m., haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

tps://reviews.apache.org/r/43367/#comment180810> // In some fetcher cache tests, we want to find out if concurrent execution of // launching taks works, settling the clock will serializes this, thus we prefer to // reduce `allocation_interval` to speed up test cases here. - Guangya Li

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

> On 二月 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > <https://reviews.apache.org/r/43616/diff/1/?file=1251896#file1251896line598> > > > > s/Labels/One label? > > > > I think that here we shou

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

> On 二月 17, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 598 > > <https://reviews.apache.org/r/43616/diff/1/?file=1251896#file1251896line598> > > > > s/Labels/One label? > > > > I think that here we shou

Re: Review Request 43639: Allowed dynamic reservation without a principal.

cation is disabled but reservation has principal. src/tests/master_validation_tests.cpp (line 385) <https://reviews.apache.org/r/43639/#comment180946> s/principal/`principal` - Guangya Liu On 二月 17, 2016, 8:45 p.m., Gre

Re: Review Request 43639: Allowed dynamic reservation without a principal.

> On 二月 18, 2016, 6:57 a.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 692-711 > > <https://reviews.apache.org/r/43639/diff/1/?file=1253091#file1253091line692> > > > > Can you please add some test cases to cover those scenarios? > > &

Re: Review Request 43569: Updated log message if container not found.

129406abdff715e321f683911e404c46676b6daf Diff: https://reviews.apache.org/r/43569/diff/ Testing --- make make check Thanks, Guangya Liu

Re: Review Request 43746: Fixed flaky AvailableResourcesAfterRescinding test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43746/#review119782 --- Ship it! Ship It! - Guangya Liu On 二月 19, 2016, 12:26 a.m

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network th

Re: Review Request 42516: Add support for user-defined networks.

.name, and if > > DOckerInfo.network is not set and NetworkInfo.name is set, the docker > > containerizer will do --net=. > > Guangya Liu wrote: > Does it make sense to use the `repeated string groups` field in > NetworkInfo? I think that we can treate the groups

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review119840 --- Ship it! Ship It! - Guangya Liu On 二月 19, 2016, 2:02 a.m

Re: Review Request 43718: Added fs::supported() function.

> On 二月 19, 2016, 9:28 a.m., haosdent huang wrote: > > src/tests/containerizer/fs_tests.cpp, line 49 > > > > > > I use CentOS 6. But seems don't have `ext2` and `ext3` in > > `/proc/filesystems` > > > > ```

Re: Review Request 43758: Made signal escalation timeout configurable in command executor.

tps://reviews.apache.org/r/43758/#comment181265> Add some checking here if the `escalationTimeout < Duration::zero()`? - Guangya Liu On 二月 19, 2016, 1:12 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generate

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

lt;< value.get() << "': " << parse.error(); } shutdownGracePeriod = parse.get(); } - Guangya Liu On 二月 19, 2016, 1:12 p.m., Alexander Rukletsov wrote: > > --- > This is an automa

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

> On 二月 19, 2016, 1:38 p.m., Guangya Liu wrote: > > src/exec/exec.cpp, lines 698-699 > > <https://reviews.apache.org/r/43760/diff/1/?file=1259192#file1259192line698> > > > > Since there is already a default value for `shutdownGracePeriod` here, > > w

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

> On 二月 19, 2016, 1:38 p.m., Guangya Liu wrote: > > src/exec/exec.cpp, lines 698-699 > > <https://reviews.apache.org/r/43760/diff/1/?file=1259192#file1259192line698> > > > > Since there is already a default value for `shutdownGracePeriod` here, > > w

Re: Review Request 43764: Extended the actual shutdown timeout for executors.

g/r/43764/#comment181279> I think here may also need guarantee that the task command signal_escalation_timeout > 0 - Guangya Liu On 二月 19, 2016, 1:12 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically ge

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

che.org/r/43796/#comment181389> one blank line? docs/mesos-containerizer.md (line 130) <https://reviews.apache.org/r/43796/#comment181390> s/state.json/state The state.json is already deprecated. - Guangya Liu On 二月 20, 2016, 3:31 a.m.,

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

tps://reviews.apache.org/r/43800/#comment181393> Some sentence has period while others not, can you please unify this? I think that we should add period for all of those sentence to the end. - Guangya Liu On 二月 20, 2016, 1:32 a.m., Greg Mann

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

: s/This princial/The `DEFAULT_CREDENTIAL` principal src/tests/reservation_tests.cpp (line 1343) <https://reviews.apache.org/r/43776/#comment181402> ditto - Guangya Liu On 二月 20, 2016, 1:11 a.m., Greg Mann wrote: > > --

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

line 567 to `Principal "bar" can only create volumes for the "panda" role.` Or else move this comment to line 567? - Guangya Liu On 二月 20, 2016, 1:08 a.m., Greg Mann wrote: > > --- > This is an autom

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

tps://reviews.apache.org/r/43779/#comment181408> s/ Reserve/Unreserve / `ReserveResources` src/tests/reservation_endpoints_tests.cpp (line 1036) <https://reviews.apache.org/r/43779/#comment181409> s/ reserve/unreserve / reserve - Guangya Liu On 二月 20, 2016, 1:10 a.m., Gre

Re: Review Request 43800: Updated authorization docs for '/reserve' and '/create-volumes'.

e" : "None"` and specified `roles`? - Guangya Liu On 二月 20, 2016, 1:32 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 42710: Moved docker containerizer to docker folder.

/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 Diff: https://reviews.apache.org/r/42710/diff/ Testing --- make make check Thanks, Guangya Liu

Review Request 43809: Moved composing containerizer to composing folder.

/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd src/tests/containerizer/composing_containerizer_tests.cpp e7e3b622b6606a812aef046c761bf92368d34af2 Diff: https://reviews.apache.org/r/43809/diff/ Testing --- make make check Thanks, Guangya Liu

Review Request 43814: Enabled volume propagation for docker volume.

, Guangya Liu

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

ocator, so the framework cannot leverage this if using built-in allocator. - Guangya Liu On 二月 22, 2016, 3 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 39939: Make docker_socket option support different protocols.

pp (line 441) <https://reviews.apache.org/r/39939/#comment181471> by default - Guangya Liu On 二月 22, 2016, 3:35 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 43814: Enabled volume propagation for docker volume.

.apache.org/r/43814/#review120098 --- On 二月 22, 2016, 1:54 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

//reviews.apache.org/r/43032/ > ----------- > > (Updated 二月 22, 2016, 6:37 a.m.) > > > Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy > Chen. > > > Bugs: MESOS-4446 > https://issues.apache.org/

Re: Review Request 43639: Allowed dynamic reservation without a principal.

> On 二月 18, 2016, 6:57 a.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 692-711 > > <https://reviews.apache.org/r/43639/diff/1/?file=1253091#file1253091line692> > > > > Can you please add some test cases to cover those scenarios? > > &

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2000) <https://reviews.apache.org/r/43639/#comment181660> one period - Guangya Liu On 二月 23, 2016, 12:16 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 43838: Added note about not implemented requestResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43838/#review120251 --- Seems you are losing python interface. - Guangya Liu On 二月 22

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

> On 二月 22, 2016, 3:20 a.m., Guangya Liu wrote: > > docs/app-framework-development-guide.md, line 135 > > <https://reviews.apache.org/r/43819/diff/1/?file=1263766#file1263766line135> > > > > Why not merge this and above `Scheduler API` into one section? >

Re: Review Request 43855: Added Appc fetcher support to store.

ilure here including both tmp and dest. src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 327) <https://reviews.apache.org/r/43855/#comment181692> s/Fetches/Fetch src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 346) <https://reviews.apache.org/r/43855/#c

Re: Review Request 43855: Added Appc fetcher support to store.

> On 二月 23, 2016, 5:21 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 288 > > <https://reviews.apache.org/r/43855/diff/1/?file=1264857#file1264857line288> > > > > What about using a uuid like dir here? There might

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

; Do we need to add layer.tar here? - Guangya Liu On 二月 20, 2016, 6:09 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 43860: Used uri::Fetcher to pull docker images in docker registry puller.

09> What about keep this log but update it to "Fetching layer " src/tests/containerizer/provisioner_docker_tests.cpp (line 325) <https://reviews.apache.org/r/43860/#comment181707> most of the test with docker images are now using `alpine` - Guangya Liu On

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

alidateVersion` but only left the compare part. - Guangya Liu On 二月 23, 2016, 8:44 a.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On 二月 23, 2016, 9:46 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 123-128 > > <https://reviews.apache.org/r/43032/diff/9/?file=1265109#file1265109line123> > > > > Can you use following logic to get docker version here? > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

g/r/43880/#comment181849> s/Course/Coarse-grained ? ditto for the following src/tests/hierarchical_allocator_tests.cpp (line 2384) <https://reviews.apache.org/r/43880/#comment181850> move this above `removeSlave` ditto for the following - Guangya Liu On 二月 23, 2016, 5

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

2400 - 2403) <https://reviews.apache.org/r/43881/#comment181858> 4 spaces src/tests/hierarchical_allocator_tests.cpp (lines 2416 - 2418) <https://reviews.apache.org/r/43881/#comment181860> 4 spaces - Guangya Liu On 二月 23, 2016, 5:09 p.m., Benjamin Bannier wrote: > > --

Re: Review Request 43879: Added allocator metrics for number of allocations made.

} return None(); - Guangya Liu On 二月 23, 2016, 5:09 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On 二月 24, 2016, 12:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > <https://reviews.apache.org/r/43880/diff/1/?file=1265547#file1265547line432> > > > > The allocatd may keeps changing due the resource offer an

Re: Review Request 43879: Added allocator metrics for number of allocations made.

t have resources allocated? or else keep this metric and add a new metric which record the succeed allocations. - Guangya Liu On 二月 24, 2016, 8:46 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On 二月 24, 2016, 12:53 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2369-2370 > > <https://reviews.apache.org/r/43881/diff/1/?file=1265551#file1265551line2369> > > > > What about following format? > > > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On 二月 24, 2016, 12:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > <https://reviews.apache.org/r/43880/diff/1/?file=1265547#file1265547line432> > > > > The allocatd may keeps changing due the resource offer an

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On 二月 24, 2016, 1:50 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 286 > > <https://reviews.apache.org/r/43879/diff/1/?file=1265543#file1265543line286> > > > > some comments here > > Benjamin Bannier wrote: >

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On 二月 24, 2016, 12:53 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1354 > > <https://reviews.apache.org/r/43881/diff/1/?file=1265550#file1265550line1354> > > > > The counter may count twice for some cases, one framework ma

Re: Review Request 43879: Added allocator metrics for number of allocations made.

ws.apache.org/r/43879/#comment181962> Days(365) src/tests/hierarchical_allocator_tests.cpp (line 2435) <https://reviews.apache.org/r/43879/#comment181963> Why using double here? Should not this be int? - Guangya Liu On 二月 24, 2016, 10:2

Re: Review Request 43884: Added allocator metrics for satisfied quotas.

ources, but I think that identifying the reserved resources here may be more clear.) `Quota is satisfied with non-revocable and reserved resources.` - Guangya Liu On 二月 24, 2016, 10:47 a.m., Benjamin Bannier wrote: > > ---

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On 二月 24, 2016, 1:06 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2398 > > <https://reviews.apache.org/r/43879/diff/3/?file=1267167#file1267167line2398> > > > > I saw that most are using `Seconds(15)` Can you please clarif

Re: Review Request 43884: Added allocator metrics for used quotas.

> On 二月 24, 2016, 1:26 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1077-1080 > > <https://reviews.apache.org/r/43884/diff/4/?file=1267201#file1267201line1077> > > > > I think that we cannot say that the quota here is s

Re: Review Request 43960: Added an end-to-end test for docker registry puller.

size());` or `ASSERT_EQ(1u, offers.get().size());` may be more accurate src/tests/containerizer/provisioner_docker_tests.cpp (line 359) <https://reviews.apache.org/r/43960/#comment182101> Why you are changing back to `busybox` but not `alpine`? - Guangya Liu On 二月 24, 2016, 6:51

Re: Review Request 42516: Add support for user-defined networks.

.name, and if > > DOckerInfo.network is not set and NetworkInfo.name is set, the docker > > containerizer will do --net=. > > Guangya Liu wrote: > Does it make sense to use the `repeated string groups` field in > NetworkInfo? I think that we can treate the groups

Re: Review Request 43932: Added overlayfs provisioning backend.

ws.apache.org/r/43932/#comment182113> return Failure( "Failed to create container rootfs at '" + rootfs + "': " + mkdir.error()); - Guangya Liu On 二月 24, 2016, 4:38 p.m., Shuai Lin wrote: > > -

Re: Review Request 43883: Added allocator metrics for number of filters per framework.

to the below line - Guangya Liu On 二月 25, 2016, 11:01 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

of Docker. Please upgrade to >=' " + stringify(minVersion) + "'"; return Error(msg); } return Nothing(); } - Guangya Liu On 二月 24, 2016, 2:10 p.m., Abhishek Dasgupta wrote: > >

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

); ` and update it to: // OfferFilter refuse1 will be expired after allocation_interval. ditto for the following - Guangya Liu On 二月 26, 2016, 5:01 p.m., Benjamin Bannier wrote: > > --- > This is an automatic

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

. - Guangya Liu On 二月 26, 2016, 7:19 a.m., fan du wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44058/ > --- &

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On 二月 25, 2016, 12:08 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 229-251 > > <https://reviews.apache.org/r/43032/diff/10/?file=1267526#file1267526line229> > > > > What about as this: > > > > Try Docker::val

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

<https://reviews.apache.org/r/44047/#comment182749> ditto src/master/http.cpp (line 1043) <https://reviews.apache.org/r/44047/#comment182750> s/offered resources/offered resources per agent - Guangya Liu On 二月 28, 2016, 12:17 a.m.,

Re: Review Request 43718: Added fs::supported() function.

718/#comment182796> I think that should `continue` here, if one line failed, other lines should still be tried to see if the fs is supportted. But it would be good to log some WARNINIG message here before continue. @Jie Yu, @Shuai Lin, what do you say? - Guangya Liu On

Review Request 44154: Fixed build error on Mac OS.

make check Thanks, Guangya Liu

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=100 --gtest_shuffle Thanks, Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

(updated) - src/tests/hierarchical_allocator_tests.cpp 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 Diff: https://reviews.apache.org/r/42386/diff/ Testing --- make make tests GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" --verbose Thanks, Guangya Liu

Re: Review Request 41772: Added helper function to flatten resources.

8de6672ba9b34947db81c74b8e03e8965e8af5fc Diff: https://reviews.apache.org/r/41772/diff/ Testing --- make make check GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="ResourcesOperationTest.*" --verbose Thanks, Guangya Liu

Re: Review Request 42590: Removed reserved() API.

/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc Diff: https://reviews.apache.org/r/42590/diff/ Testing --- make make check Thanks, Guangya Liu

Re: Review Request 42590: Removed reserved() API.

bca523159577994d5890f832e4f61101b5dbf3bc Diff: https://reviews.apache.org/r/42590/diff/ Testing (updated) --- make make check ./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*" Thanks, Guangya Liu

Review Request 44164: Improved debug ability for docker puller.

registery puller, all related logs can be logged. Thanks, Guangya Liu

Re: Review Request 44189: Document docker runtime isolator.

tps://reviews.apache.org/r/44189/#comment183060> s/we/the docker runtime isolator ditto for the following - Guangya Liu On 三月 1, 2016, 12:03 a.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

tor_tests.cpp (line 2499) <https://reviews.apache.org/r/43881/#comment183129> two spaces - Guangya Liu On 二月 29, 2016, 7:59 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

eck ./bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.*" --verbose Thanks, Guangya Liu

Re: Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

tps://reviews.apache.org/r/44250/#comment183351> s/stripped resource/stripped persistent volume resource src/tests/resources_tests.cpp (line 2240) <https://reviews.apache.org/r/44250/#comment183352> s/stripped resource/stripped dynamic reserved resource - Guangya Liu On 三月 2, 2016, 2:2

Re: Review Request 44221: Added runtime isolator check if docker is image provider.

er` is included in `image_providers`? - Guangya Liu On 三月 1, 2016, 8:24 p.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

tps://reviews.apache.org/r/44251/#comment183381> One suggestion is that does it make sense to update all variables including `scalar` to `strippedScalar` which might be more accurate. - Guangya Liu On 三月 2, 2016, 6:21 a.m., Neil Conway

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

lt; uri.path() << "' to '" << directory << "'"; - Guangya Liu On 三月 2, 2016, 12:13 a.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

258/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.*" --verbose Thanks, Guangya Liu

Review Request 44315: Do not traverse offer list if there is only one offer.

--gtest_filter="HierarchicalAllocatorTest.*" Thanks, Guangya Liu

Re: Review Request 44315: Do not traverse offer list if there is only one offer.

Diff: https://reviews.apache.org/r/44315/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" Thanks, Guangya Liu

Review Request 44337: Updated utils for URI constructor streaming.

/44337/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="UriTest.*" Thanks, Guangya Liu

Review Request 44338: Added URI test for HDFS.

--- Added URI test for HDFS. Diffs - src/tests/uri_tests.cpp 1d33ab110bed7c0b7ecfa5d608965da5a1729562 Diff: https://reviews.apache.org/r/44338/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="UriTest.*" Thanks, Guangya Liu

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

258/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.*" --verbose Thanks, Guangya Liu

Re: Review Request 44337: Updated utils for URI constructor streaming.

ecified. I was adding some check to see if the `uri.path()` is empty, then do not add the slash. - Guangya ----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44337/#review121909 --

Re: Review Request 44337: Updated utils for URI constructor streaming.

3940dc041c1783eec9e7c950402fd7c42e620d8e Diff: https://reviews.apache.org/r/44337/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="UriTest.*" Thanks, Guangya Liu

Re: Review Request 39939: Make docker_socket option support different protocols.

tps://reviews.apache.org/r/39939/#comment183856> Does the `docker_socket` support starting wit `unix:`? I think not, because the `Docker::create` will add `unix:` automatically. - Guangya Liu On 三月 4, 2016, 2:23 a.m., haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

> On 三月 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > <https://reviews.apache.org/r/39939/diff/3/?file=1280373#file1280373line134> > > > > Does the `docker_socket` support starting wit `unix:`? I think not, >

Re: Review Request 39939: Make docker_socket option support different protocols.

> On 三月 4, 2016, 3:03 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 134 > > <https://reviews.apache.org/r/39939/diff/3/?file=1280373#file1280373line134> > > > > Does the `docker_socket` support starting wit `unix:`? I think not, >

Re: Review Request 39939: Make docker_socket option support different protocols.

et + "' is not valid," " only unix domain socket is supported for `docker_socket` when" " `docker_mesos_image` is enabled"); - Guangya Liu On 三月 4, 2016, 3:41 a.m., haosdent huang wrote: > > -

Review Request 44390: No need to enable SSL when using registry puller.

--- No need to enable SSL when using registry puller. Diffs - docs/mesos-provisioner.md 1b19406cb93bbc3f5330eaf9d29b1be98a674136 Diff: https://reviews.apache.org/r/44390/diff/ Testing --- Thanks, Guangya Liu

Review Request 44391: Added document for overlayfs backend.

://issues.apache.org/jira/browse/MESOS-4866 Repository: mesos Description --- Added document for overlayfs backend. Diffs - docs/mesos-provisioner.md 1b19406cb93bbc3f5330eaf9d29b1be98a674136 Diff: https://reviews.apache.org/r/44391/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 43293: Ignored invalid env vars.

5621632 process.cpp:2499] Resuming help@192.168.1.102:54061 at 2016-02-16 04:13:00.506503168+00:00 [ OK ] DockerImageTest.ParseInspectonImage (6 ms) [--] 1 test from DockerImageTest (6 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (18 ms total) [ PASSED ] 1 test. Thanks, Guangya Liu

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

conditions. - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122146 --- On March 4, 2016, 2:10 a.m., G

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

g/r/44258/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.*" --verbose Thanks, Guangya Liu

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

g/r/44258/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.*" --verbose Thanks, Guangya Liu

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

> On 三月 5, 2016, 1:25 a.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, line 89 > > > > > > This entire helper is not needed anymore (due to implicit roles). @Jopseph, why also remove acls here? The i

Re: Review Request 44414: Added documentation about container image support.

/44414/#comment184096> I uploaded a patch here: https://reviews.apache.org/r/44391/ Will rebase this patch as mesos-provisioner.md is now deleted. - Guangya Liu On 三月 5, 2016, 2:20 a.m., Jie Yu wrote: > > --- > This

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

> On 三月 5, 2016, 1:25 a.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, line 89 > > <https://reviews.apache.org/r/44408/diff/1/?file=1281379#file1281379line89> > > > > This entire helper is not needed anymore (due to implicit roles). >

  1   2   3   4   5   6   7   8   9   10   >