are cleaned up?
src/slave/containerizer/mesos/containerizer.cpp
https://reviews.apache.org/r/33414/#comment131927
s/that//
src/slave/containerizer/mesos/containerizer.cpp
https://reviews.apache.org/r/33414/#comment131924
s/destory/destroy
- Ian Downes
On April 21, 2015, 2:46 p.m., Jie Yu
/#comment131914
static?
src/slave/containerizer/linux_launcher.cpp
https://reviews.apache.org/r/33415/#comment131915
CHECK_SOME on os::basename?
- Ian Downes
On April 21, 2015, 2:48 p.m., Jie Yu wrote
output:
I0501 05:13:25.414758 7838 linux_launcher.cpp:212] Cloning child process with
flags = CLONE_NEWNS | CLONE_NEWPID
Thanks,
Ian Downes
the scheduing latency
statistics of the aggregate container during the usage() sampling interval.
- Ian Downes
On May 1, 2015, 10:53 a.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33631/#review81848
---
Ship it!
Ship It!
- Ian Downes
On April 28, 2015, 10:55 a.m
---
Manual testing only so far. This is harder to automate because we need a
self-contained chroot to execute something in... Suggestions welcome.
Thanks,
Ian Downes
/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09
Diff: https://reviews.apache.org/r/32891/diff/
Testing
---
Thanks,
Ian Downes
://reviews.apache.org/r/34135/diff/
Testing
---
existing persistent volumes tests.
Thanks,
Ian Downes
/containerizer/provisioners/appc/store.cpp PRE-CREATION
src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
Diff: https://reviews.apache.org/r/34140/diff/
Testing
---
Thanks,
Ian Downes
/backend.cpp PRE-CREATION
src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
Diff: https://reviews.apache.org/r/34141/diff/
Testing
---
Thanks,
Ian Downes
://reviews.apache.org/r/34137/diff/
Testing
---
Thanks,
Ian Downes
24c71b7906a92bdc84a38e88d6084ab09e3cf2ab
Diff: https://reviews.apache.org/r/34134/diff/
Testing
---
Thanks,
Ian Downes
://reviews.apache.org/r/33746/diff/
Testing
---
Example output:
I0501 05:13:25.414758 7838 linux_launcher.cpp:212] Cloning child process with
flags = CLONE_NEWNS | CLONE_NEWPID
Thanks,
Ian Downes
---
make check
manually used 'mesos execute' and specified command executor, both directly as
the value and fetching from file:///. Tested enviroment variables too.
Thanks,
Ian Downes
/sched_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34309/diff/
Testing
---
Added test.
Thanks,
Ian Downes
/containerizer/isolators/cgroups/cpushare.cpp
6a5b2b5c6e2844fe1a10815956569194b6f56681
Diff: https://reviews.apache.org/r/34310/diff/
Testing
---
Thanks,
Ian Downes
---
Filter revocable resources.
Diffs
-
include/mesos/resources.hpp 1e98c13fe8075b14454f7899b98006fdaf88f484
src/common/resources.cpp 92b9e7f60323e0f7cf69c42e712468b631f3
Diff: https://reviews.apache.org/r/34308/diff/
Testing
---
Thanks,
Ian Downes
ff4a9dbdb1b655e71bf87dcee8fe62433d396f52
src/slave/containerizer/isolators/cgroups/cpushare.cpp
6a5b2b5c6e2844fe1a10815956569194b6f56681
Diff: https://reviews.apache.org/r/34310/diff/
Testing
---
Thanks,
Ian Downes
-CREATION
src/tests/sched_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34309/diff/
Testing
---
Added test.
Thanks,
Ian Downes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84038
---
On May 18, 2015, 10:33 a.m., Ian Downes wrote:
---
This is an automatically
:
https://reviews.apache.org/r/34310/#review84039
---
On May 18, 2015, 10:33 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
On May 18, 2015, 10:33 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34310
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34138/#review84195
---
On May 12, 2015, 5:47 p.m., Ian Downes wrote
34755cf795391c9b8051a5e4acc6caf844984496
src/linux/sched.hpp PRE-CREATION
src/tests/sched_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34309/diff/
Testing
---
Added test.
Thanks,
Ian Downes
/isolators/cgroups/cpushare.hpp
ff4a9dbdb1b655e71bf87dcee8fe62433d396f52
src/slave/containerizer/isolators/cgroups/cpushare.cpp
6a5b2b5c6e2844fe1a10815956569194b6f56681
Diff: https://reviews.apache.org/r/34310/diff/
Testing
---
Thanks,
Ian Downes
Diff: https://reviews.apache.org/r/34308/diff/
Testing
---
Thanks,
Ian Downes
99b2cfc0149fb1a0ea66655caf67e9d966dae0c9
Diff: https://reviews.apache.org/r/34308/diff/
Testing
---
Thanks,
Ian Downes
BH, VK, BM and JY repeatedly until I get timely feedback
about a Master/Slave related review?
docs/committers.md
https://reviews.apache.org/r/34295/#comment135571
I don't see a need to call out the Isolators specifically; is Mesos
Containerizer sufficient?
- Ian Downes
On May 15, 2015
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34309/#review84331
---
On May 18, 2015, 1:48 p.m., Ian Downes wrote
---
On May 19, 2015, 3:43 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34310
ff4a9dbdb1b655e71bf87dcee8fe62433d396f52
src/slave/containerizer/isolators/cgroups/cpushare.cpp
6a5b2b5c6e2844fe1a10815956569194b6f56681
Diff: https://reviews.apache.org/r/34310/diff/
Testing
---
Thanks,
Ian Downes
/sched.hpp PRE-CREATION
src/tests/sched_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34309/diff/
Testing
---
Added test.
Thanks,
Ian Downes
ff4a9dbdb1b655e71bf87dcee8fe62433d396f52
src/slave/containerizer/isolators/cgroups/cpushare.cpp
6a5b2b5c6e2844fe1a10815956569194b6f56681
Diff: https://reviews.apache.org/r/34310/diff/
Testing
---
Thanks,
Ian Downes
to parent_review_request_id here?
support/post-reviews.py
https://reviews.apache.org/r/34503/#comment135942
I presume this won't work if you choose to skip updating/creating some
reviews?
- Ian Downes
On May 20, 2015, 3:50 p.m., Vinod Kone wrote
Description
---
May be missing in sys/mount.h but supported by the kernel.
Diffs
-
src/linux/fs.hpp d7832a4b3761c48be6c1ccef58a30ee31c70dc1b
Diff: https://reviews.apache.org/r/35033/diff/
Testing
---
Thanks,
Ian Downes
---
Thanks,
Ian Downes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34894/#review87062
---
Ship it!
Ship It!
- Ian Downes
On June 3, 2015, 2:54 p.m., Paul
0cdb2d2a3f19a4835e85c6b040759019b03f051e
Diff: https://reviews.apache.org/r/34137/diff/
Testing
---
Thanks,
Ian Downes
://reviews.apache.org/r/34908/diff/
Testing
---
Thanks,
Ian Downes
/
Testing
---
Thanks,
Ian Downes
: https://reviews.apache.org/r/34140/diff/
Testing
---
Thanks,
Ian Downes
/r/35033/diff/
Testing
---
Thanks,
Ian Downes
/fs.cpp 568565f878b34708170a886dc4d62849aa01f263
Diff: https://reviews.apache.org/r/32891/diff/
Testing
---
Thanks,
Ian Downes
/provisioners/appc.cpp PRE-CREATION
src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b
src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2
Diff: https://reviews.apache.org/r/34142/diff/
Testing
---
Thanks,
Ian Downes
/containerizer/linux_launcher.cpp
8eae258d81229e19f8c587f5e023b1df7deed025
src/slave/containerizer/mesos/containerizer.cpp
8c102fb7d1f79ee768cb06de3a976ea12f958712
Diff: https://reviews.apache.org/r/34135/diff/
Testing
---
existing persistent volumes tests.
Thanks,
Ian Downes
/34139/diff/
Testing
---
Thanks,
Ian Downes
On June 23, 2015, 11:01 a.m., Ian Downes wrote:
Ship It!
For the test error, are we not cleaning out /var/run/mesos/netns (correctly)
between tests so we're trying to symlink container1 repeatedly? We should
probably be storing these symlinks in a directory the test controls?
- Ian
cut a release.
- Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review88016
---
On June 1, 2015, 2:48 p.m., Ian Downes wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review88581
---
On June 1, 2015, 2:50 p.m., Ian Downes wrote
---
On May 19, 2015, 11:46 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34427/
---
(Updated
generated e-mail. To reply, visit:
https://reviews.apache.org/r/34141/#review84774
---
On May 12, 2015, 5:48 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply
., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34142/
---
(Updated May 12, 2015, 5:48 p.m.)
Review request
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34139/#review83825
---
On May 12, 2015, 5:47 p.m., Ian Downes wrote
is only for constexpr functions?
- Ian Downes
On June 24, 2015, 2:14 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835
---
On June 1, 2015, 2:50 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444
https://reviews.apache.org/r/34737/#comment137182
To make this test general, please check the expected output in response,
i.e., the container will *not* be included.
- Ian Downes
On May 27, 2015, 4:14 p.m., Niklas Nielsen wrote
is *not*?
Are we discussing a switch to 'constexpr char foo[] = bar'?
- Ian Downes
On May 29, 2015, 4:23 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835
?
include/mesos/mesos.proto
https://reviews.apache.org/r/34894/#comment137908
This shouldn't be named including isolator. If the previously flatten is
possible then perhaps NetworkControlStatistics?
- Ian Downes
On June 1, 2015, 9:40 a.m., Paul Brett wrote
https://reviews.apache.org/r/34426/#comment137927
ditto
- Ian Downes
On May 31, 2015, 12:53 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426
://reviews.apache.org/r/34832/#comment137951
move this up to the fq_code::create(noSuchInterface)?
src/tests/routing_tests.cpp
https://reviews.apache.org/r/34832/#comment137950
ditto, duplicates of lines 492:494?
- Ian Downes
On May 29, 2015, 3:09 p.m., Paul Brett wrote
src/tests/routing_tests.cpp
https://reviews.apache.org/r/34863/#comment137957
ditto
- Ian Downes
On May 31, 2015, 1:02 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/34140/#review83840
---
On May 26, 2015, 11:25 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34140
with the rules around the isolators, but why can we
not adjust the policy within the update() call as opposed to in the
isolate() function?
Ian Downes wrote:
This is not a limitation of the isolator interface but a complexity of
setting the scheduling policy because it's task rather than
.
- Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34141/#review84237
---
On May 12, 2015, 5:48 p.m., Ian Downes wrote
/sched.hpp PRE-CREATION
src/tests/sched_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34309/diff/
Testing
---
Added test.
Thanks,
Ian Downes
://reviews.apache.org/r/31444/#review89425
---
On June 22, 2015, 9:38 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36014/#review89775
---
Ship it!
Ship It!
- Ian Downes
On June 29, 2015, 11:58 a.m
(line) and gets the right output.
- Ian Downes
On July 1, 2015, 3:44 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113
if (a x) {
//
} else if (a y) {
//
} else if (a z) {
//
} else {
//
}
```
src/linux/perf.cpp (line 549)
https://reviews.apache.org/r/36114/#comment143163
Where is the variable `version` defined?
- Ian Downes
On July 1, 2015, 3:44 p.m., Chi
fields and values.
src/tests/perf_tests.cpp (line 87)
https://reviews.apache.org/r/36115/#comment143172
```cpp
foreach (const tupleVersion, string input, input1) {}
```?
- Ian Downes
On July 1, 2015, 3:44 p.m., Chi Zhang wrote
/36112/#comment143162
See subsequent review, I don't think this needs to be pulled out into a
separate function.
- Ian Downes
On July 1, 2015, 3:43 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply
. What's the motivation to changing this
function?
- Ian Downes
On May 21, 2015, 4:31 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34436
://reviews.apache.org/r/34432/#comment136331
Please state why they are exposed.
src/slave/containerizer/isolators/network/port_mapping.cpp
https://reviews.apache.org/r/34432/#comment136332
Why not be consistent with the other const string inlines?
- Ian Downes
On May 21, 2015, 4:32
/ reads better, I think.
ditto elsewhere
- Ian Downes
On May 21, 2015, 4:31 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558
-mail. To reply, visit:
https://reviews.apache.org/r/34140/#review84233
---
On May 12, 2015, 5:48 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply
Description
---
Remove unnecessary ifdefs for missing CLONE_ flags.
Diffs
-
src/linux/ns.hpp b695f3acf2ab8f1ba3adaa7fffd4d920107821be
Diff: https://reviews.apache.org/r/34620/diff/
Testing
---
Thanks,
Ian Downes
Description
---
Define missing CLONE_ flags for old glibc.
Diffs
-
src/linux/ns.hpp b695f3acf2ab8f1ba3adaa7fffd4d920107821be
Diff: https://reviews.apache.org/r/34619/diff/
Testing
---
Thanks,
Ian Downes
://reviews.apache.org/r/34135/#review84644
---
On May 12, 2015, 5:47 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
://reviews.apache.org/r/34137/#review83824
---
On May 12, 2015, 5:47 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/34140/diff/
Testing
---
Thanks,
Ian Downes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30643/#review71122
---
On May 12, 2015, 5:22 p.m., Ian Downes wrote
/executor.cpp de6f1b104a765a8e53934154e78872b03695b24c
Diff: https://reviews.apache.org/r/30643/diff/
Testing
---
make check
manually used 'mesos execute' and specified command executor, both directly as
the value and fetching from file:///. Tested enviroment variables too.
Thanks,
Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review79948
---
On May 12, 2015, 5:22 p.m., Ian Downes wrote
0741616b656e947cb460dd6ee6a9a4852be001c2
src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5
src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec
src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e
Diff: https://reviews.apache.org/r/34137/diff/
Testing
---
Thanks,
Ian
---
Thanks,
Ian Downes
/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2
Diff: https://reviews.apache.org/r/34142/diff/
Testing
---
Thanks,
Ian Downes
---
Manual testing only so far. This is harder to automate because we need a
self-contained chroot to execute something in... Suggestions welcome.
Thanks,
Ian Downes
/diff/
Testing
---
Thanks,
Ian Downes
src/slave/containerizer/provisioners/appc/discovery.cpp PRE-CREATION
src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b
src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2
Diff: https://reviews.apache.org/r/34139/diff/
Testing
---
Thanks,
Ian Downes
://reviews.apache.org/r/34138/diff/
Testing
---
Thanks,
Ian Downes
're using this for setting quota.
src/tests/attributes_tests.cpp (line 40)
<https://reviews.apache.org/r/39345/#comment161517>
Did this cause a problem running the tests or are you cleaning things up?
- Ian Downes
On Oct. 20, 2015, 12:45 a.m., David Forsythe wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39345/#review103232
-------
On Oct. 20, 2015, 12:45 a.m., David Forsythe wrote:
>
> ---
> This is an automati
.cpp (lines 506 - 513)
<https://reviews.apache.org/r/39417/#comment162362>
Why is this description different from the docs?
- Ian Downes
On Oct. 17, 2015, 5:29 p.m., Cong Wang wrote:
>
> ---
> This is an automaticall
t;
> (Updated Oct. 17, 2015, 5:29 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> When --egress_unique_flow_per_container is enabled, we need to install a flow
> classifie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39415/#review104185
---
Ship it!
Ship It!
- Ian Downes
On Oct. 17, 2015, 5:22 p.m
2431)
<https://reviews.apache.org/r/39490/#comment162473>
Why is this no longer a failure?
src/slave/containerizer/isolators/network/port_mapping.cpp (line 2450)
<https://reviews.apache.org/r/39490/#comment162474>
ditto?
- Ian Downes
On Oct. 20, 2015, 11:57 a.m., Con
tps://reviews.apache.org/r/39416/#comment162355>
Does it actually create a flow per container or is it really based on the 5
tuple, which will be different for different containers?
- Ian Downes
On Oct. 17, 2015, 5:24 p.m., Cong Wang
lave/containerizer/isolators/network/port_mapping.cpp (line 1169)
<https://reviews.apache.org/r/38117/#comment160782>
Toggle line type here.
src/slave/containerizer/isolators/network/port_mapping.cpp (lines 1171 - 1174)
<https://reviews.apache.org/r/38117/#comment160781>
---
On June 22, 2015, 9:41 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34135
0741616b656e947cb460dd6ee6a9a4852be001c2
src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5
src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec
src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e
Diff: https://reviews.apache.org/r/34137/diff/
Testing
---
Thanks,
Ian
1 - 100 of 163 matches
Mail list logo
