---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67236/#review203518
---
Ship it!
Ship It!
- Joseph Wu
On May 21, 2018, 1:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/#review202239
---
Ship it!
Ship It!
- Joseph Wu
On May 1, 2018, 3:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66892/#review202236
---
Ship it!
Ship It!
- Joseph Wu
On May 1, 2018, 2:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66431/#review202232
---
Ship it!
Ship It!
- Joseph Wu
On April 9, 2018, 3:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66836/#review202230
---
Ship it!
Ship It!
- Joseph Wu
On April 26, 2018, 9:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66835/#review202227
---
Ship it!
Ship It!
- Joseph Wu
On April 26, 2018, 9:22 p.m
atched)
<https://reviews.apache.org/r/66834/#comment283975>
I must be missing something... Where are `parse` and
`parse` defined?
- Joseph Wu
On April 26, 2018, 9:22 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> Thi
/subprocess_tests.cpp
Lines 651-652 (original), 697-698 (patched)
<https://reviews.apache.org/r/66790/#comment283970>
What's wrong with this test? (You might want to expand the TODO a bit)
- Joseph Wu
On April 30, 2018, 2:11 p.m., Andrew Schwartz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66641/#review202216
---
Ship it!
Ship It!
- Joseph Wu
On April 16, 2018, 1:24 p.m
/permissions.hpp
Lines 64 (patched)
<https://reviews.apache.org/r/66773/#comment283951>
I have a feeling this will pollute the logs unless you demote it to
`VLOG(2)` or similar. It doesn't seem too useful of a warning at runtime.
- Joseph Wu
On April 30, 2018, 1:52 p.m., Andrew Sc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66437/#review202205
---
Ship it!
Ship It!
- Joseph Wu
On April 26, 2018, 9:17 p.m
As discussed offline, let's try to keep the set of implemented operators to
a minimum. We can add more as they are used.
- Joseph Wu
On April 11, 2018, 7:06 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatica
bit funny looking :) Better than
otherwise though.
- Joseph Wu
On April 11, 2018, 7:06 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66444/#review201861
---
Ship it!
Ship It!
- Joseph Wu
On April 24, 2018, 1:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66445/#review201796
---
Ship it!
Ship It!
- Joseph Wu
On April 6, 2018, 4:18 p.m
>
>
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu,
> and Michael Park.
>
>
> Bugs: MESOS-8682
> https://issues.apache.org/jira/browse/MESOS-8682
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Th
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66443/#review201786
---
Ship it!
Ship It!
- Joseph Wu
On April 3, 2018, 10:58 p.m
> On April 18, 2018, 11:55 a.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/os/windows/read.hpp
> > Lines 39-44 (patched)
> > <https://reviews.apache.org/r/66431/diff/4/?file=199#file199line41>
> >
> > So you're saying that `
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66439/#review201781
---
Ship it!
Ship It!
- Joseph Wu
On April 6, 2018, 4:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66442/#review201780
---
Ship it!
Ship It!
- Joseph Wu
On April 4, 2018, 7:06 p.m
), 451-457 (patched)
<https://reviews.apache.org/r/65640/#comment283353>
FYI: I'm going to commit the leak fixes immediately as these leaks are
causing ~200 extranous error log lines per build/test run.
- Joseph Wu
On April 11, 2018, 8:37 p.m., Chun-Hung
(patched)
<https://reviews.apache.org/r/66440/#comment282889>
We're unlikely to ever make this change, so you can probably remove this
TODO.
- Joseph Wu
On April 9, 2018, 3:09 p.m., Andrew Schwartzmeyer wrote:
>
> ---
s in the
same FD for multiple calls, the original FD will retain its offset (near the
beginning of the file) and should repeatedly overwrite the data each time
`protobuf::write` is called.
- Joseph Wu
On April 6, 2018, 4:16 p.m., Andre
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66438/#review201558
---
Ship it!
Ship It!
- Joseph Wu
On April 4, 2018, 12:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66433/#review201556
---
Ship it!
Ship It!
- Joseph Wu
On April 4, 2018, 12:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66709/#review201492
---
Ship it!
Ship It!
- Joseph Wu
On April 18, 2018, 6:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66436/#review201463
---
Ship it!
Ship It!
- Joseph Wu
On April 3, 2018, 10:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66435/#review201462
---
Ship it!
Ship It!
- Joseph Wu
On April 3, 2018, 10:52 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66434/#review201455
---
Ship it!
Ship It!
- Joseph Wu
On April 4, 2018, 12:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66432/#review201451
---
Ship it!
Ship It!
- Joseph Wu
On April 6, 2018, 4:14 p.m
(patched)
<https://reviews.apache.org/r/66431/#comment282680>
So you're saying that `ReadFile` reads all the existing data on the handle
prior to returning False?It would feel safer if we verify this with a unit
test.
- Joseph Wu
On April 9, 2018, 3:53 p.m., Andrew Schwartz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66430/#review201266
---
Ship it!
- Joseph Wu
On April 3, 2018, 10:50 p.m., Andrew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66426/#review201028
---
Ship it!
- Joseph Wu
On April 3, 2018, 10:48 p.m., Andrew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66429/#review201259
---
Ship it!
- Joseph Wu
On April 4, 2018, 12:17 p.m., Andrew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66428/#review201125
---
Ship it!
- Joseph Wu
On April 6, 2018, 3:53 p.m., Andrew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66455/#review201258
---
Ship it!
- Joseph Wu
On April 6, 2018, 4:09 p.m., Andrew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66425/#review201023
---
Ship it!
- Joseph Wu
On April 3, 2018, 10:47 p.m., Andrew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66427/#review201030
---
Ship it!
- Joseph Wu
On April 3, 2018, 10:48 p.m., Andrew
/open.hpp
Lines 29-32 (patched)
<https://reviews.apache.org/r/66423/#comment281885>
We won't need this note anymore (on the Windows header).
- Joseph Wu
On April 3, 2018, 10:47 p.m., Andrew Schwartzmeyer wrote:
>
> ---
che.org/r/66424/#comment281959>
Hm... This review ends up deleting the definitions in `fcntl.hpp`.
Seems like this comment change was intended for the previous review (
https://reviews.apache.org/r/66423 )?
- Joseph Wu
On April 6, 2018, 3:52 p.m., Andrew Schwart
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66046/#review199465
---
Ship it!
Ship It!
- Joseph Wu
On March 19, 2018, 12:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66014/#review199464
---
Ship it!
Ship It!
- Joseph Wu
On March 9, 2018, 2:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66013/#review199463
---
Ship it!
Ship It!
- Joseph Wu
On March 19, 2018, 12:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66012/#review199462
---
Ship it!
Ship It!
- Joseph Wu
On March 19, 2018, 12:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66011/#review199461
---
Ship it!
Ship It!
- Joseph Wu
On March 19, 2018, 12:13 p.m
326-330 (original), 326-330 (patched)
<https://reviews.apache.org/r/66010/#comment279664>
Looks like this variable can go away too.
- Joseph Wu
On March 13, 2018, 1:45 p.m., Andrew Schwartzmeyer wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66009/#review199352
---
Ship it!
Ship It!
- Joseph Wu
On March 14, 2018, 4:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66008/#review199348
---
Ship it!
Ship It!
- Joseph Wu
On March 14, 2018, 4:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66007/#review199343
---
Ship it!
Ship It!
- Joseph Wu
On March 9, 2018, 2:37 p.m
our existing tests to cover this
case... The DefaultExecutorTests already cover a couple of kill-cases, but
none where the `KILL` call itself fails.
- Joseph Wu
On Feb. 16, 2018, 4:27 p.m., Gaston Kleiman wrote:
>
> ---
> T
description.
- Joseph Wu
On Feb. 16, 2018, 4:30 p.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/default_executor.cpp
Lines 1172-1176 (original), 1174-1183 (patched)
<https://reviews.apache.org/r/65693/#comment278914>
If you start the lambda with:
```
[=](const Response& response) -> Future
```
Then you won't need to wrap the two return statements with
`Future(...)`.
r.cpp
Lines 1074-1076 (original), 1074-1076 (patched)
<https://reviews.apache.org/r/65692/#comment279075>
As an alternative, you could change this to take a `Owned&`
instead.
- Joseph Wu
On Feb. 16, 2018, 4:24 p.m., Gaston Kleiman wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65394/#review197831
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 16, 2018, 3:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65127/#review197830
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 12, 2018, 3:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65419/#review197820
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 16, 2018, 3:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65396/#review197818
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 8, 2018, 9:50 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65395/#review197817
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 8, 2018, 9:49 a.m
parate tests for health checks that can be enabled later (like `
HealthCheckTest.DefaultExecutorCommandHealthCheck`).
- Joseph Wu
On Feb. 8, 2018, 9:49 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically genera
(and specifying the socket is
usually better than not specifying it).
- Joseph Wu
On Jan. 29, 2018, 10:20 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
(original), 385 (patched)
<https://reviews.apache.org/r/65556/#comment277463>
s/taskk/task/
- Joseph Wu
On Feb. 7, 2018, 1:55 p.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
cted to fail/kill)
* Executor performs the launch/kill.
* Executor commits suicide because it is no longer running any tasks.
* The agent sends the second task group to the now-dead executor.
- Joseph Wu
On Feb. 7, 2018, 12:05 p.m., Gaston K
undant, as that is a
continuation of `launchGroup` where `launched = true;` is set); in `wait()`
(similarly redundant, but has more entrypoints); and in `shutdown()`.
You can consider removing the bool in a separate patch.
- Joseph Wu
On Feb. 9, 2018, 10:35 p.m.,
t in any other location
- Joseph Wu
On Feb. 7, 2018, 11 a.m., Gaston Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
aunch/launch group/` ?
src/launcher/default_executor.cpp
Line 509 (original), 509 (patched)
<https://reviews.apache.org/r/65549/#comment277351>
What about this one?
- Joseph Wu
On Feb. 7, 2018, 10:59 a.m., Gaston Kl
tps://reviews.apache.org/r/65548/#comment277350>
For debugging purposes, it may also help to include the `source` and
`reason` fields (if present). And maybe even `slave_id`.
- Joseph Wu
On Feb. 7, 2018, 10:57 a.m., Gaston Kleiman
itted alongside a test
which checks for fetcher output, along the same lines as these tests:
* `TEST_F(ContainerLoggerTest, DefaultToSandbox)` in
`tests/container_logger_tests.cpp`
* `TEST_F(DockerContainerizerTest, ROOT_DOCKER_Logs)` in
`tests/containerizer/docker_containerizer_tests.cpp`
- Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65467/#review197193
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 8, 2018, 2:35 p.m
(patched)
<https://reviews.apache.org/r/65465/#comment277306>
I wonder if we should `NOTE:` that this handle will not be destructed, even
though it is a SharedHandle, because it never goes out of scope (i.e. `exec`
will not trigger the destruction).
- Joseph Wu
On Feb. 8, 2018, 11:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65409/#review197185
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 8, 2018, 11:53 a.m
a962b397a2340694232ab13ea9eca7fff78d35e2
Diff: https://reviews.apache.org/r/65561/diff/1/
Testing
---
Thanks,
Joseph Wu
ommon/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2
Diff: https://reviews.apache.org/r/65541/diff/2/
Changes: https://reviews.apache.org/r/65541/diff/1-2/
Testing
---
Thanks,
Joseph Wu
-
include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075
src/common/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2
Diff: https://reviews.apache.org/r/65541/diff/1/
Testing
---
Thanks,
Joseph Wu
src/common/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2
Diff: https://reviews.apache.org/r/65540/diff/1/
Testing
---
make check
Thanks,
Joseph Wu
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65465/
> -----------
>
> (Updated Feb. 1, 2018, 11:57 a.m.)
>
>
> Review request for mesos, Akash Gupta, Jie Yu, a
9-4730 (patched)
<https://reviews.apache.org/r/65408/#comment276947>
s/default Windows memory/default Windows isolators/
- Joseph Wu
On Feb. 1, 2018, 4:14 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatic
(patched)
<https://reviews.apache.org/r/65409/#comment276948>
The reset should ideally go right below this line. I believe the test
should not be reliant on any data structures of the agent existing after
termination.
You can probably move the comment up here too.
- Joseph W
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65406/#review196957
---
Ship it!
Ship It!
- Joseph Wu
On Jan. 29, 2018, 12:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65407/#review196953
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 1, 2018, 4:03 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65407/#review196952
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 1, 2018, 4:03 p.m
> On Feb. 6, 2018, 1:55 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/internal/windows/inherit.hpp
> > Lines 31-43 (patched)
> > <https://reviews.apache.org/r/65467/diff/1/?file=1951450#file1951450line31>
> >
> > This is basically what the Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65405/#review196946
---
Ship it!
Ship It!
- Joseph Wu
On Feb. 1, 2018, 3:30 p.m
31-43 (patched)
<https://reviews.apache.org/r/65467/#comment276923>
This is basically what the ChildHook `UNSET_CLOEXEC`
(libprocess/src/subprocess.cpp) should be doing.
- Joseph Wu
On Feb. 2, 2018, 12:13 p.m., Andrew Schwartzmeyer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65403/#review196759
---
Ship it!
- Joseph Wu
On Feb. 1, 2018, 3:23 p.m., Andrew
49 (original), 43-44 (patched)
<https://reviews.apache.org/r/65402/#comment276599>
Extra newline here.
- Joseph Wu
On Jan. 29, 2018, 12:35 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65401/#review196743
---
Ship it!
- Joseph Wu
On Feb. 1, 2018, 3:22 p.m., Andrew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65400/#review196737
---
Ship it!
- Joseph Wu
On Jan. 29, 2018, 12:34 p.m., Andrew
2 (patched)
<https://reviews.apache.org/r/65399/#comment276557>
Newline ditto.
3rdparty/stout/include/stout/windows/os.hpp
Lines 784 (patched)
<https://reviews.apache.org/r/65399/#comment276559>
4 space indent
- Joseph Wu
On Jan. 29, 2018, 12:34 p.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65398/#review196731
---
Ship it!
- Joseph Wu
On Jan. 29, 2018, 12:32 p.m., Andrew
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65397/#review196730
---
Ship it!
LGTM.
- Joseph Wu
On Jan. 29, 2018, 12:32 p.m
d4c354ab596a6ea361f2fe45afa46089f8c1a543
Diff: https://reviews.apache.org/r/65367/diff/1/
Testing
---
See next review.
Thanks,
Joseph Wu
r.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7
Diff: https://reviews.apache.org/r/65368/diff/1/
Testing
---
make check
Thanks,
Joseph Wu
-
src/tests/master_maintenance_tests.cpp
2a0625873b4f9b6350c14e8304a8d6fbd6a45e6b
Diff: https://reviews.apache.org/r/65366/diff/1/
Testing
---
make check
This test should fail until the chain is fully applied.
Thanks,
Joseph Wu
.hpp` includes `mesos/mesos.hpp`, which
includes a generated protobuf.
- Joseph Wu
On Jan. 26, 2018, 3:41 a.m., Benno Evers wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
(!stopped) {
synchronized (socket_mutex) {
CHECK_NOTNULL(__s__);
future_accept = ...
}
}
```
- Joseph Wu
On Jan. 24, 2018, 12:47 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generat
lelize some of this code.
src/tests/health_check_tests.cpp
Lines 2278-2284 (patched)
<https://reviews.apache.org/r/64387/#comment275382>
Wow... we might not want to enable this test by default if the image is
that large.
- Joseph Wu
On Jan.
how is the quoting maintained?
- Joseph Wu
On Jan. 16, 2018, 4:09 p.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
view195894
---
On Jan. 17, 2018, 4:10 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64386/
&g
ply, visit:
> https://reviews.apache.org/r/63862/
> ---
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston
> Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
12-715 (patched)
<https://reviews.apache.org/r/63862/#comment275313>
Do you know if this will _never_ be supported?
In which case, we should get rid of the `_TEMP_DISABLED_ON_WINDOWS` and
make the disabling more permanent.
- Joseph Wu
On Jan. 5, 2018,
401 - 500 of 2923 matches
Mail list logo
