diff/
Testing
---
make check
Thanks,
Vinod Kone
ed to your patch.
- Vinod Kone
On Aug. 11, 2015, 10:10 p.m., Tim Anderegg wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37374/#review95022
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 11, 2015, 10:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37377/#review95051
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 11, 2015, 11:52 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/#review95052
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 11, 2015, 10:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37378/#review95053
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 12, 2015, 12:14 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37410/#review95169
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 12, 2015, 8:08 p.m
eason to avoid Owned?
fixed.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37277/#review94843
---
On Aug. 9, 2015, 8:
Diff: https://reviews.apache.org/r/37277/diff/
Testing (updated)
---
make check
Updated the tests.
Thanks,
Vinod Kone
this could happen during master failover too. so let's not send an error()
src/scheduler/scheduler.cpp (line 396)
<https://reviews.apache.org/r/37303/#comment150071>
indent by 2 spaces.
s/WARNING/ERROR/
this should call error().
(line 412)
<https://reviews.apache.org/r/37303/#comment150092>
indentation.
- Vinod Kone
On Aug. 13, 2015, 5:39 a.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/#review95284
---
Ship it!
Ship It!
- Vinod Kone
On July 30, 2015, 10:36 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34129/#review95287
---
Ship it!
Ship It!
- Vinod Kone
On July 30, 2015, 10:36 p.m
/
Testing
---
make check
Ran the scheduler tests in a loop.
Thanks,
Vinod Kone
: https://reviews.apache.org/r/37464/diff/
Testing
---
make check
Thanks,
Vinod Kone
3fbe3831cf93c29180bc7e433fd57c6108988316
Diff: https://reviews.apache.org/r/37465/diff/
Testing
---
make check
Thanks,
Vinod Kone
3fbe3831cf93c29180bc7e433fd57c6108988316
Diff: https://reviews.apache.org/r/37467/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37471/#review95392
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 14, 2015, 5:54 a.m
> On Aug. 14, 2015, 12:12 p.m., James DeFelice wrote:
> > failing unit test from mesos built bot seems completely unrelated (evil
> > agent!):
> > ```
> > ../../../3rdparty/libprocess/src/tests/http_tests.cpp:461: Failure
> > Value of: response.get().status
> > Actual: "202 Accepted"
> > Expec
er handlers.
Diffs
-
3rdparty/libprocess/src/tests/http_tests.cpp
7351fa44e69743ab82e9cada7ba7f797a6899bab
Diff: https://reviews.apache.org/r/37487/diff/
Testing
---
Ran the test in a loop 10K times.
Thanks,
Vinod Kone
dd692094e164e33ba0f13e2b994c14cbfd827cbf
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp
018ff51d10f4ba076609704d6e3b2c704c82b016
Diff: https://reviews.apache.org/r/37494/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37489/#review95505
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 15, 2015, 2:13 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37510/#review95551
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 16, 2015, 9:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37509/#review95556
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 16, 2015, 8:27 p.m
it's not clear how to simulate scheduler disconnection
on the master.
Thanks,
Vinod Kone
Description
---
Mostly copy pasted from the design doc with some formatting.
Diffs
-
docs/scheduler_http_api.md PRE-CREATION
Diff: https://reviews.apache.org/r/37512/diff/
Testing
---
gist: https://gist.github.com/vinodkone/5ae803ee35274ca46a3e
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37518/#review95597
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2015, 7:41 a.m
iff: https://reviews.apache.org/r/37512/diff/
Testing
---
gist: https://gist.github.com/vinodkone/5ae803ee35274ca46a3e
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37544/#review95639
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2015, 7:48 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37546/#review95641
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2015, 7:49 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37545/#review95640
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2015, 7:48 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37547/#review95642
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2015, 7:49 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37555/#review95643
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2015, 8:56 p.m., Jie
instead of making the current
jenkins_build.sh work? This is 90% duplicated code which makes me sad.
Also, we shouldn't really depend on non-ASF hosted code (mesosphere's
wrapdocker) here. Can that script be committed to this repo?
- Vinod Kone
On Aug. 17, 2015, 8:16 p.m., Timothy
t150758>
s/the// ?
- Vinod Kone
On Aug. 17, 2015, 10:49 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37557/#review95659
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2015, 10:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37558/#review95660
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2015, 10:51 p.m
in repetition. It doesn't block here anymore, but there is still
another deadlock issue that I described in the bug.
Thanks,
Vinod Kone
/scheduler_http_api.md PRE-CREATION
Diff: https://reviews.apache.org/r/37512/diff/
Testing
---
gist: https://gist.github.com/vinodkone/5ae803ee35274ca46a3e
Thanks,
Vinod Kone
ply, visit:
https://reviews.apache.org/r/37512/#review95591
---
On Aug. 18, 2015, 3:08 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37512/
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37562/#review95728
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 18, 2015, 5:11 a.m
---
make check
Thanks,
Vinod Kone
src/scheduler/scheduler.cpp 37f41debc394a773f33465dab1a89d7ef7264f64
Diff: https://reviews.apache.org/r/37588/diff/
Testing
---
make check
Thanks,
Vinod Kone
tps://reviews.apache.org/r/37584/#comment150866>
just do
return Error("Skipping fetch with Hadoop client: " +
(available.isError() ? availabe.error() : " client not
found"));
- Vinod Kone
On Aug. 18, 2015, 5:24 p
happens with PID frameworks.
Diffs (updated)
-
src/master/http.cpp d016b3c055a06e7aa0649a36fd4b095c2938ba56
src/scheduler/scheduler.cpp 37f41debc394a773f33465dab1a89d7ef7264f64
Diff: https://reviews.apache.org/r/37588/diff/
Testing
---
make check
Thanks,
Vinod Kone
--------
On Aug. 18, 2015, 7:10 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37588/
> -
> On Aug. 18, 2015, 6:34 p.m., Vinod Kone wrote:
> > src/launcher/fetcher.cpp, lines 100-106
> > <https://reviews.apache.org/r/37584/diff/1/?file=1043203#file1043203line100>
> >
> > just do
> >
> > re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37501/#review96232
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 15, 2015, 4:35 p.m
apache.org/r/37500/#comment151582>
s/FrameworkWebUIUrlCapabilitiesAndUser/FrameworkState/
- Vinod Kone
On Aug. 15, 2015, 8:03 a.m., Aditi Dixit wrote:
>
> ---
> This is an automatically generated e-mail.
) and http
library (scheduler.cpp) into separate patches? Note that the former needs
updates to the Java and Python bindings as well.
More importantly, are you planning to plumb this call through to the allocator
to actually do the quiescing/suppressing?
- Vinod Kone
On Aug. 22, 2015, 2:27 p.m
p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan,
> Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-3066
> https://issues.apache.org/jira/browse/MESOS-3066
>
>
> Repository: mesos
>
>
> Description
> -
> On Aug. 24, 2015, 11:56 p.m., Vinod Kone wrote:
> > This review is a bit hard to follow because it's doing multiple things. I
> > would recommend you to split this into multiple reviews
> >
> > #1) Expose framework user in state.json
> > #2) Update fra
validate this against?
- Vinod Kone
On Aug. 28, 2015, 9:54 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
sting
---
Tested locally
./support/verify_reviews.py vinod kone 10 "?from-user=neilc"
git rev-parse HEAD
Checking if review: 37445 needs verification
Latest diff timestamp: 2015-08-13 21:01:08
Verifying review 37445
Posting review: Bad patch!
Reviews applied: []
Error:
No reviewers sp
this dependency
explicitly specified!
https://github.com/apache/mesos/blob/master/support/jenkins_build.sh
Are you sure the CRAM-MD5 module is not automatically installed when you
install "libsasl2-dev"? cc @till
- Vinod Kone
On Aug. 22, 2015, 3:53 a.m., And
tps://reviews.apache.org/r/37785/#comment153001>
If resume the clock here, the slave can still retry registration right? You
probably want to just pause the clock at the beginning of the test and not
resume at all inside the test.
- Vinod Kone
On Aug. 26, 2015, 3:07 a.m., Anand Mazumdar
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37784/
> ---
>
> (Updated Aug. 31, 2015, 7:58 a.m.)
>
>
> Review request for meso
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37908/#review97351
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 31, 2015, 6:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37785/#review97353
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 26, 2015, 3:07 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38023/#review97356
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 1, 2015, 10:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38069/#review97534
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 2, 2015, 9:09 p.m., Ben
ting.
src/tests/containerizer/perf_tests.cpp (line 151)
<https://reviews.apache.org/r/37540/#comment153542>
ASSERT_SOME(event);
src/tests/containerizer/perf_tests.cpp (lines 156 - 157)
<https://reviews.apache.org/r/37540/#comment1535
ines 181 - 189)
<https://reviews.apache.org/r/38050/#comment153652>
any reason to not just call pong() here?
src/tests/partition_tests.cpp (line 79)
<https://reviews.apache.org/r/38050/#comment153654>
why the change to process::Message here and everywhere else?
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38050/#review97709
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 4, 2015, 1:18 a.m
s test?
I think you can simplify this test by not launching them.
- Vinod Kone
On Sept. 1, 2015, 2:44 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
> On Sept. 4, 2015, 7:35 p.m., Vinod Kone wrote:
> >
Also, please make the summary and description more meaningful than just the
ticket ID.
- Vinod
---
This is an automatically generated e-mail. To reply, vis
> On Sept. 4, 2015, 7:42 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 4118
> > <https://reviews.apache.org/r/38051/diff/1/?file=1062262#file1062262line4118>
> >
> > Instead of not calling updateTask() the logic should be inside
> > update
g/r/38051/#comment153805>
Instead of not calling updateTask() the logic should be inside updateTask()
to do the right thing. Note that updateTask() already has logic to deal with
duplicate terminal updates.
- Vinod Kone
On Sept. 2, 2015, 1:13 p.m., Yong Qiao Wang
<https://reviews.apache.org/r/37532/#comment153808>
period.
src/master/master.cpp (line 2541)
<https://reviews.apache.org/r/37532/#comment153809>
s/INFO/WARNING/
- Vinod Kone
On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
>
>
and an
unversioned executor.proto much like what we did with scheduler.proto.
- Vinod Kone
On Sept. 8, 2015, 10:30 p.m., Isabel Jimenez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
e had per
framework "messages_received" because it was used for rate limiting.
- Vinod Kone
On Sept. 9, 2015, 1:42 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
ment154713>
This should be required ExecutorID similar to what we did with scheduler.
Also means that we need a 'Subscribe' message. I would recommend renaming
Resubscribe to Subscribe and adding ExecutorInfo to it.
- Vinod Kone
On Sep
label values?
src/tests/master_tests.cpp (line 3320)
<https://reviews.apache.org/r/38367/#comment155679>
kill this?
src/tests/slave_tests.cpp (line 2223)
<https://reviews.apache.org/r/38367/#comment155681>
s/an is/is/ ?
f close() is called twice? is that safe?
src/linux/perf.cpp (lines 748 - 751)
<https://reviews.apache.org/r/37540/#comment155721>
can this be done by the process instead?
src/linux/perf.cpp (line 754)
<https://reviews.apache.org/r/37540/#comment155708
ws.apache.org/r/37532/#comment155893>
you also need to add a case statement to master/http.cpp.
src/master/master.cpp (line 2542)
<https://reviews.apache.org/r/37532/#comment155892>
s/just ignore/ignoring/
- Vinod Kone
On Sept. 5, 2015, 12:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review99069
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 6, 2015, 2:40 a.m
tps://reviews.apache.org/r/37873/#comment155899>
s/Allocator/allocator/
s/to the framework/for the framework./
src/master/allocator/mesos/hierarchical.hpp (line 398)
<https://reviews.apache.org/r/37873/#comment155901>
Remove this comment.
- Vinod Kone
On Sept. 6, 2015, 2:40 a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38119/#review99070
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 4, 2015, 12:06 p.m
(lines 254 - 255)
<https://reviews.apache.org/r/38120/#comment155903>
Just have the same comment that you had on scheduler.hpp in the first
review of this chain.
- Vinod Kone
On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
>
> --
> On Sept. 15, 2015, 7:12 p.m., Vinod Kone wrote:
> >
can you also update the java test framework to test this call?
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
/interface/src/mesos/interface/__init__.py (lines 235 - 236)
<https://reviews.apache.org/r/38121/#comment155905>
ditto. Use the same wording as you did in scheduler.hpp.
- Vinod Kone
On Sept. 4, 2015, 12:06 p.m., Guangya Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38124/#review99076
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 4, 2015, 12:06 p.m
tps://reviews.apache.org/r/37873/#comment155910>
s/quiescent/quiesced/ ?
src/master/allocator/mesos/hierarchical.hpp (line 989)
<https://reviews.apache.org/r/37873/#comment155909>
indent by 2 spaces.
- Vinod Kone
On Sept. 6, 2015, 2:40 a.m., Guang
On revival scheduler should get another offer with the same amount of
resources.
also, i'm a bit confused on how/why the scheduler gets another offer (for
the same resources) considering the framework is holding on to the original
offer?
- Vinod Kone
On Sept. 4, 2015, 12:06 p.m., G
que within a framework.
- Vinod Kone
On Sept. 15, 2015, 8:13 p.m., Isabel Jimenez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/#review99110
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 15, 2015, 9:32 p.m
add a CHECK_NE() check with both the slave ids?
src/tests/master_tests.cpp (line 3637)
<https://reviews.apache.org/r/38003/#comment155990>
Does this test reliably fail (i.e., every time) without the code change in
master.cpp?
- Vino
> On Sept. 16, 2015, 5:54 p.m., Jie Yu wrote:
> > Chatted with Viond about the flag naming. We prefer the following:
> >
> > ```
> > --image_providers=APPC,DOCKER
> > --image_provisioner=bind,copy,overlayfs
> > ```
one singular one plural? can we name the latter --image_provisioners?
- Vinod
> On Sept. 16, 2015, 5:54 p.m., Jie Yu wrote:
> > Chatted with Viond about the flag naming. We prefer the following:
> >
> > ```
> > --image_providers=APPC,DOCKER
> > --image_provisioner=bind,copy,overlayfs
> > ```
>
> Vinod Kone wrote:
>
> On Sept. 14, 2015, 10:19 p.m., Vinod Kone wrote:
> > src/common/http.cpp, lines 153-194
> > <https://reviews.apache.org/r/38367/diff/1/?file=1072964#file1072964line153>
> >
> > Why custom models? Can we not use the protobuf to json converters?
>
>
s.apache.org/r/38367/#comment156203>
s/not/no/
- Vinod Kone
On Sept. 16, 2015, 2:05 a.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
he.org/r/38468/#comment156321>
or asking on the JIRA ticket itself.
- Vinod Kone
On Sept. 17, 2015, 6:54 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
llow 80 char comments now?
- Vinod Kone
On Sept. 17, 2015, 3:07 p.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
tps://reviews.apache.org/r/37532/#comment156332>
s/, the/. The/
- Vinod Kone
On Sept. 16, 2015, 5:51 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
)
<https://reviews.apache.org/r/37873/#comment156334>
s/quiesce/quiesces/ ?
src/master/allocator/mesos/hierarchical.hpp (line 1123)
<https://reviews.apache.org/r/37873/#comment156335>
s/is/has/
- Vinod Kone
On Sept. 16, 2015, 5:50 a.m., Guang
> On Sept. 15, 2015, 7:12 p.m., Vinod Kone wrote:
> >
>
> Vinod Kone wrote:
> can you also update the java test framework to test this call?
>
> Guangya Liu wrote:
> I see that the reviveOffers also do not have a example, I want to handle
> those two
tps://reviews.apache.org/r/38124/#comment156338>
s/we enabled quiesce offer/the framework quiesced offers./
src/tests/scheduler_tests.cpp (lines 1030 - 1031)
<https://reviews.apache.org/r/38124/#comment156339>
// Framework should receive offers only after calling reviving offers.
even bigger.
- Vinod Kone
On Sept. 16, 2015, 5:50 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
ask's state has been transitioned to terminal state, no further
// terminal updates should result in a state change. These are the same
// semantics that are enforced by the slave.
- Vinod Kone
On Sept. 5, 2015, 11:41 p.m., Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38496/#review99589
---
Ship it!
Ship It!
- Vinod Kone
On Sept. 18, 2015, 5:18 p.m
701 - 800 of 3244 matches
Mail list logo
