Review Request 56282: AMBARI-19867. Grafana install fails if custom directory's parent does not exist

2017-02-03 Thread Attila Doroszlai
-DskipSurefireTests -Dcheckstyle.skip -Drat.skip clean test ... Total run:1182 Total errors:0 Total failures:0 OK ... [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-31 Thread Attila Doroszlai
/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/55989/#comment235128> Please don't move imports unnecessarily. - Attila Doroszlai On Jan. 31, 2017, 12:12 a.m., Vitalyi Brodetskyi

Re: Review Request 56133: AMBARI-19802. Debug: agent randomly losing heartbeat with the server

2017-02-01 Thread Attila Doroszlai
it: https://reviews.apache.org/r/56133/#review163789 --- On Jan. 31, 2017, 7:49 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Review Request 56173: AMBARI-19816. Agent heartbeat lost due to dead service check process

2017-02-01 Thread Attila Doroszlai
, Attila Doroszlai

Review Request 56133: AMBARI-19802. Debug: agent randomly losing heartbeat with the server

2017-01-31 Thread Attila Doroszlai
/python/ambari_agent/StatusCommandsExecutor.py fbb29f4fe59e34e33242f81b783d39a9921c777a Diff: https://reviews.apache.org/r/56133/diff/ Testing --- Checked agent log at both INFO and DEBUG log level. Thanks, Attila Doroszlai

Review Request 56390: AMBARI-19895. Firewall check during ambari-server setup fails on CentOS7

2017-02-07 Thread Attila Doroszlai
... Ran 455 tests in 24.288s OK ... [INFO] Ambari Server . SUCCESS [1:26.424s] [INFO] Ambari Agent .. SUCCESS [34.094s] ``` Thanks, Attila Doroszlai

Review Request 56225: AMBARI-19846. ambari-agent.out filled with KeyError

2017-02-02 Thread Attila Doroszlai
: ``` $ mvn -pl ambari-agent clean test ... Ran 455 tests in 15.152s OK ... [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 56225: AMBARI-19846. ambari-agent.out filled with KeyError

2017-02-02 Thread Attila Doroszlai
Diff: https://reviews.apache.org/r/56225/diff/ Testing --- Manually tested on local cluster. Unit tests: ``` $ mvn -pl ambari-agent clean test ... Ran 455 tests in 15.152s OK ... [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 56225: AMBARI-19846. ambari-agent.out filled with KeyError

2017-02-02 Thread Attila Doroszlai
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56225/#review163966 ------- On Feb. 2, 2017, 2:36 p.m., Attila Doroszlai wrote: > > --- >

Re: Review Request 56407: Upgrade: Package Install stuck in "Installing" state forever

2017-02-07 Thread Attila Doroszlai
/ambari/server/actionmanager/ActionDBAccessorImpl.java (line 229) <https://reviews.apache.org/r/56407/#comment236401> Shouldn't this be `commands = hostRoleCommandDAO.mergeAll(commands);` to reflect the managed entities? - Attila Doroszlai On Feb. 7, 2017, 11:15 p.m., Sebastian

Re: Review Request 56225: AMBARI-19846. ambari-agent.out filled with KeyError

2017-02-03 Thread Attila Doroszlai
3985c5a21ebcaa5c526b772e8ad13d1bf0427d99 Diff: https://reviews.apache.org/r/56225/diff/ Testing --- Manually tested on local cluster. Unit tests: ``` $ mvn -pl ambari-agent clean test ... Ran 455 tests in 15.152s OK ... [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 56225: AMBARI-19846. ambari-agent.out filled with KeyError

2017-02-02 Thread Attila Doroszlai
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56225/#review163971 ------- On Feb. 2, 2017, 2:36 p.m., Attila Doroszlai wrote: > > --

Re: Review Request 55818: Unknown attributes should not be allowed in quick link filter definitions

2017-01-22 Thread Attila Doroszlai
s.html#checkArgument-boolean-java.lang.String-java.lang.Object...- - Attila Doroszlai On Jan. 21, 2017, 6:04 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 55983: AMBARI-19712. Cluster creation fails due to database exception

2017-01-26 Thread Attila Doroszlai
-pl ambari-server -Dcheckstyle.skip clean test ... Tests run: 4882, Failures: 0, Errors: 0, Skipped: 38 ... Total run:1179 Total errors:0 Total failures:0 OK ... [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-26 Thread Attila Doroszlai
4> I think using `$3` would be better, unless this one will remain the last one if new parameters are introduced in the future. - Attila Doroszlai On Jan. 26, 2017, 6:03 p.m., Laszlo Puskas wrote: > > --- > This is an auto

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Attila Doroszlai
server --- [INFO] Starting audit... [ERROR] ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java:47: 'com.google.inject.AbstractModule' should be separated from previous imports. [ImportOrder] Audit done. ``` -

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Attila Doroszlai
> On Jan. 26, 2017, 9:17 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/resources/scripts/post-user-creation-hook.sh, line 34 > > <https://reviews.apache.org/r/55987/diff/2/?file=1616602#file1616602line34> > > > > I think using `$3` would be be

Review Request 56021: AMBARI-19743. Agent registration fails with non-root agent user

2017-01-27 Thread Attila Doroszlai
--- Manual test: installed cluster with non-root agent user via wizard. Thanks, Attila Doroszlai

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Attila Doroszlai
/ambari/server/serveraction/users/CsvFilePersisterService.java (line 27) <https://reviews.apache.org/r/55987/#comment234710> Unused import - java.nio.file.attribute.PosixFilePermissions. - Attila Doroszlai On Jan. 27, 2017, 5:02 p.m., Laszlo Puskas

Re: Review Request 53686: Stage and Request status should be persisted in the database

2017-02-15 Thread Attila Doroszlai
i-trunk-test-patch/ambari/ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java:39: Wrong order for 'javax.persistence.EntityManager' import. [ImportOrder] - Attila Doroszlai On Feb. 7, 2017, 12:09 a.m.,

Review Request 56798: AMBARI-20070. Agent heartbeat loop stuck in subprocess.Popen

2017-02-17 Thread Attila Doroszlai
6927b150636f352531e35c40cb0b04a50db8f0a5 Diff: https://reviews.apache.org/r/56798/diff/ Testing --- Manually tested on CentOS 7.3 with Python 2.7.5: installed via blueprint, added services manually, ran service checks. Thanks, Attila Doroszlai

Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB

2017-02-24 Thread Attila Doroszlai
) <https://reviews.apache.org/r/57035/#comment238719> `` is useful only if there are child POMs inheriting from this one. In other cases it's better to merge with `` below. - Attila Doroszlai On Feb. 24, 2017, 1:06 p.m., Nitiraj Rathore

Re: Review Request 57043: Zeppelin Notebook fails to start without HDFS via Ambari service

2017-02-24 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57043/#review166722 --- Ship it! Ship It! - Attila Doroszlai On Feb. 24, 2017, 5:11

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

2017-02-24 Thread Attila Doroszlai
S/1.10.3-10/package/scripts/kerberos_client.py", line 80, in KerberosClient().execute() ... resource_management.core.exceptions.Fail: User '${hadoop-env/hdfs_user}' doesn't exist ``` - Attila Doroszlai On Feb. 24, 2017, 3:19 p.m., Balázs

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

2017-02-24 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57039/#review166758 --- Ship it! Ship It! - Attila Doroszlai On Feb. 24, 2017, 10

Re: Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

2017-02-24 Thread Attila Doroszlai
<https://reviews.apache.org/r/56987/#comment238731> typo: "Registraion" - Attila Doroszlai On Feb. 23, 2017, 5:39 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 56783: Removing secure ACLs from Kafka znodes during dekerberization

2017-02-22 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56783/#review166378 --- Ship it! Ship It! - Attila Doroszlai On Feb. 22, 2017, 11

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-14 Thread Attila Doroszlai
est/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java:38:8: Unused import - java.util.Collection. [UnusedImports] - Attila Doroszlai On Feb. 14, 2017, 3:38 p.m., Attila Magyar wrote: > > --- > This is an automatic

Review Request 56545: AMBARI-19959. Allow skipping view extraction in ambari-server setup

2017-02-10 Thread Attila Doroszlai
. SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 56600: Default group permissions for the user home directories created by the post user creation script should be 'hdfs' instead of 'hadoop'

2017-02-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56600/#review165322 --- Ship it! Ship It! - Attila Doroszlai On Feb. 13, 2017, 2:24

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

2017-01-19 Thread Attila Doroszlai
/0.6.0.2.5/package/scripts/master.py (line 153) <https://reviews.apache.org/r/55717/#comment233614> Since the path is fixed (not a pattern), why is `glob.glob` needed? - Attila Doroszlai On Jan. 19, 2017, 1:41 p.m., Renjith Kamath

Re: Review Request 55569: Log Namenode formatting output into ambari-agent command logs

2017-01-16 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55569/#review161716 --- Ship it! Ship It! - Attila Doroszlai On Jan. 16, 2017, 12

Re: Review Request 55575: Ambari trunk build failing due to checkstyle

2017-01-16 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55575/#review161741 --- Ship it! Thanks! - Attila Doroszlai On Jan. 16, 2017, 3:14

Review Request 55617: AMBARI-19585. Client config tags may not be saved by agent

2017-01-17 Thread Attila Doroszlai
] [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-18 Thread Attila Doroszlai
ply, visit: > https://reviews.apache.org/r/55643/ > --- > > (Updated Jan. 17, 2017, 10:30 p.m.) > > > Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, > Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian

Re: Review Request 55617: AMBARI-19585. Client config tags may not be saved by agent

2017-01-18 Thread Attila Doroszlai
generated: 0 approved: 156 licence. [INFO] [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

2017-01-19 Thread Attila Doroszlai
(test_zeppelin_master.TestZeppelinMaster) ... AssertionError: 'File' != 'Execute' ``` The tests pass after manually creating `/etc/spark/conf/hive-site.xml`. It doesn't seem like the mocked `os.path.exists` check is working as expected. - Attila Doroszlai On Jan. 19, 2017, 4:58 p.m., Renjith

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

2017-01-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55717/#review162433 --- Ship it! Ship It! - Attila Doroszlai On Jan. 19, 2017, 4:58

Re: Review Request 55758: Intermittent Zeppelin Server start failure during service install and start from Ambari

2017-01-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55758/#review162434 --- Ship it! Ship It! - Attila Doroszlai On Jan. 20, 2017, 12

Re: Review Request 55762: Ambari db-cleanup tool fixed

2017-01-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55762/#review162444 --- Ship it! Ship It! - Attila Doroszlai On Jan. 20, 2017, 2:17

Review Request 55724: AMBARI-19629. Move schemaTool invocation out of configure() to hive_metastore start()

2017-01-19 Thread Attila Doroszlai
tests: ``` $ mvn -am -pl ambari-server -DskipSurefireTests clean test ... Total run:1159 Total errors:0 Total failures:0 OK ... [INFO] Ambari Server . SUCCESS ``` Thanks, Attila Doroszlai

Review Request 51575: Provide stack-advisor support for Microsoft-R service

2016-09-01 Thread Attila Doroszlai
service via web UI; verified that service advisor is invoked in both recommend-component-layout and validate-component-layout requests, and that it correctly recommends/validates service colocation). Thanks, Attila Doroszlai

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

2016-09-02 Thread Attila Doroszlai
ly, visit: https://reviews.apache.org/r/51575/#review147556 ------- On Sept. 1, 2016, 1:36 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-09 Thread Attila Doroszlai
/#comment215803> * Indent by 2 spaces, not 4 * Would be nice to extract `/user/RevoShare` to a variable in `params` - Attila Doroszlai On Sept. 9, 2016, 8:16 a.m., Balázs Bence Sári wrote: > > --- > This is an aut

Review Request 51801: Get LDAP tests to run in concurrent forked JVMs

2016-09-12 Thread Attila Doroszlai
tch are resolved Thanks, Attila Doroszlai

Re: Review Request 51801: Get LDAP tests to run in concurrent forked JVMs

2016-09-12 Thread Attila Doroszlai
ied test failures/errors that occur without the patch are resolved Thanks, Attila Doroszlai

Review Request 51811: All classes recompiled due to Maven bug, even if none changed

2016-09-12 Thread Attila Doroszlai
mpile find ambari-server/src/main/java -type f | head -3 | xargs touch mvn -pl ambari-server compile ``` 3. Verify Maven compiles all Java sources after removing class files. ``` mvn -pl ambari-server compile find ambari-server -name '*.class' | xargs rm mvn -pl ambari-server compile ``` Thank

Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

2016-09-15 Thread Attila Doroszlai
sts # -> verify only TestStackAdvisor was run mv -iv ambari-server/src/test/python/{_,}TestStackAdvisor.py mvn -pl ambari-server test -DskipSurefireTests -Drat.skip -Dpython.test.mask='TestS*py' # -> verify only TestServerClassPath...TestStackFeature were run (30 tests in 6 files as of now)

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

2016-09-15 Thread Attila Doroszlai
ttps://reviews.apache.org/r/51914/#review149069 --- On Sept. 15, 2016, 4:44 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

2016-09-15 Thread Attila Doroszlai
-Dpython.test.mask='TestS*py' # -> verify only TestServerClassPath...TestStackFeature were run (30 tests in 6 files as of now) ``` Thanks, Attila Doroszlai

Review Request 52264: AMBARI-18466 Component should be renamed to "Microsoft R Server Client"

2016-09-26 Thread Attila Doroszlai
/ Testing --- Manual testing: created cluster with wizard Thanks, Attila Doroszlai

Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

2016-09-30 Thread Attila Doroszlai
/ambari/ambari-server/target/findbugs/findbugsXml.xml [INFO] Transformed 1 file(s). [INFO] [INFO] BUILD SUCCESS ... ``` Thanks, Attila Doroszlai

Re: Review Request 52551: Update Mirosoft R version in mpack

2016-10-05 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52551/#review151497 --- Ship it! Ship It! - Attila Doroszlai On Oct. 5, 2016, 2:31

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-07 Thread Attila Doroszlai
enerated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review151833 ------- On Oct. 7, 2016, 6:25 p.m., Attila Doroszlai wrote: > > --- > This is an automati

Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-07 Thread Attila Doroszlai
ed: 0, Time elapsed: 0.279 sec - in org.apache.ambari.server.logging.LockFactoryTest Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.168 sec - in org.apache.ambari.server.logging.ProfiledReentrantReadWriteLockTest * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 5012 licence. Thanks, Attila Doroszlai

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-07 Thread Attila Doroszlai
ion.ConfigurationTest >Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec > - in org.apache.ambari.server.logging.DelegatingLockTest >Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.279 sec > - in org.apache.ambari.server.logging.LockFactoryTest >Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.168 sec > - in org.apache.ambari.server.logging.ProfiledReentrantReadWriteLockTest > * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 5012 licence. > > > Thanks, > > Attila Doroszlai > >

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-07 Thread Attila Doroszlai
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review151839 ------- On Oct. 7, 2016, 10:21 p.m., Attila Doroszlai wrote: > > --- > This is an au

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-07 Thread Attila Doroszlai
iledReentrantReadWriteLockTest * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 5012 licence. Thanks, Attila Doroszlai

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

2016-09-21 Thread Attila Doroszlai
' # -> verify only TestServerClassPath...TestStackFeature were run (30 tests in 6 files as of now) ``` Thanks, Attila Doroszlai

Re: Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

2016-09-21 Thread Attila Doroszlai
-server -Drat.skip -DskipTests -Del.log=OFF test-compile # -> verify output does not contain any lines starting with "[EL " ``` Thanks, Attila Doroszlai

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51906/#review149214 ------- On Sept. 16, 2016, 4:57 p.m., Attila Doroszlai wrote: > > --

Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-15 Thread Attila Doroszlai
order by request_id, stage_id, task_id; ``` B. RevoShare 1. Install Ambari (trunk), add Microsoft R mpack, start Ambari 2. Create cluster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R 3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/` Thanks, Attila Doroszlai

Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

2016-09-19 Thread Attila Doroszlai
-Drat.skip -DskipTests -Del.log=INFO test-compile # -> verify output does not contain lines starting with "[EL Config]" and "[EL Finest]", only "[EL Warning]" mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=OFF test-compile # -> verify output does not c

Review Request 52038: AMBARI-18418 StackServiceDirectory debug messages are logged with placeholders

2016-09-19 Thread Attila Doroszlai
/resources/stacks/HDP/2.4/services/ACCUMULO/package for service ACCUMULO for stack HDP-2.4 does not exist.` Thanks, Attila Doroszlai

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-16 Thread Attila Doroszlai
luster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R 3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/` Thanks, Attila Doroszlai

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-16 Thread Attila Doroszlai
_on_execute" is enough in itself if webhdfs is enabled, but the "execute" step is necessary if it is disabled. - Attila --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51906/#review149175 -

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-28 Thread Attila Doroszlai
/UpdateActiveRepoVersionOnStartupTest.java (line 147) <https://reviews.apache.org/r/52266/#comment218759> Two unnecessary blank lines. - Attila Doroszlai On Sept. 28, 2016, 11:57 a.m., Balázs Bence Sári

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-28 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52266/#review150709 --- Ship it! Ship It! - Attila Doroszlai On Sept. 28, 2016, 11

Re: Review Request 52123: Microsoft-R service should be supported on SLES11

2016-09-26 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52123/#review150379 --- Ship it! Ship It! - Attila Doroszlai On Sept. 22, 2016, 10

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-10 Thread Attila Doroszlai
is never used. I will remove it. - Attila --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review151841 ------- On Oct

Review Request 53189: AMBARI-18701 Add HDFS resources for HBase to AmbariPreupload script

2016-10-26 Thread Attila Doroszlai
--- Manual testing: * create sysprepped cluster * submit blueprint with HBASE service * submit `START_ONLY` cluster creation request Thanks, Attila Doroszlai

Review Request 53188: AMBARI-18700 Add HDFS resources for Spark2 to AmbariPreupload script

2016-10-26 Thread Attila Doroszlai
blueprint with SPARK2 service and `sysprep_skip_copy_tarballs_hdfs: true` * submit `START_ONLY` cluster creation request Thanks, Attila Doroszlai

Re: Review Request 53188: AMBARI-18700 Add HDFS resources for HBase, Spark, Spark2, Zeppelin to AmbariPreupload script

2016-10-29 Thread Attila Doroszlai
blueprint with HBASE, SPARK, SPARK2, ZEPPELIN services and `sysprep_skip_copy_tarballs_hdfs: true` * submit `START_ONLY` cluster creation request Thanks, Attila Doroszlai

Re: Review Request 53273: Not able to change the default port ambari server listens to

2016-10-29 Thread Attila Doroszlai
defined in `serverConfiguration` for default port and property names. Even nicer: extract the logic for getting the port (including check for SSL) into a function in `serverConfiguration`. Similar logic is implemented in `serverUtils.get_ambari_server_api_base()`. - Attila Doroszlai On Oct. 28

Re: Review Request 53188: AMBARI-18700 Add HDFS resources for HBase, Spark, Spark2, Zeppelin to AmbariPreupload script

2016-10-29 Thread Attila Doroszlai
, Attila Doroszlai

Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-08 Thread Attila Doroszlai
nodes) via blueprint Thanks, Attila Doroszlai

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Attila Doroszlai
/TopologyManager.java bba0325 ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java f90cf76 Diff: https://reviews.apache.org/r/53576/diff/ Testing --- Created several clusters (size = 8-64 nodes) via blueprint Thanks, Attila Doroszlai

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Attila Doroszlai
/configuration/ConfigurationTest.java f90cf76 Diff: https://reviews.apache.org/r/53576/diff/ Testing --- Created several clusters (size = 8-64 nodes) via blueprint Thanks, Attila Doroszlai

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Attila Doroszlai
w155436 --- On Nov. 9, 2016, 4:07 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Attila Doroszlai
enerated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155432 --- On Nov. 9, 2016, 11:27 a.m., Attila Doroszlai wrote: > > --- > This is an automati

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-10 Thread Attila Doroszlai
uot;Dangling Javadoc comment" warning. - Attila --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155560 ---------

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-10 Thread Attila Doroszlai
opologyManager.java > bba0325 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > f90cf76 > > Diff: https://reviews.apache.org/r/53576/diff/ > > > Testing > --- > > Created several clusters (size = 8-64 nodes) via blueprint > > > Thanks, > > Attila Doroszlai > >

Re: Review Request 53477: YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is configured.

2016-11-07 Thread Attila Doroszlai
/services/WEBHCAT/package/files/alert_webhcat_server.py` also contains `curl -L`. Can you please check if that one needs to be changed, too? - Attila Doroszlai On Nov. 7, 2016, 9:22 a.m., Attila Magyar wrote

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-19 Thread Attila Doroszlai
> On Oct. 18, 2016, 7:37 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 953-954 > > <https://reviews.apache.org/r/52839/diff/2/?file=1540039#file1540039line953> > > >

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-14 Thread Attila Doroszlai
/configuration/Configuration.java (line 2430) <https://reviews.apache.org/r/52839/#comment221749> How about using `TimeUnit.MINUTES.toMillis(5)` instead of `30L`? - Attila Doroszlai On Oct. 13, 2016, 8:01 p.m., Amarnath reddy pappu

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-14 Thread Attila Doroszlai
> On Oct. 14, 2016, 1:10 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 512 > > > > > > I'm curious - why use the configuration property

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-15 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52860/#review152780 --- Ship it! Also tested with blueprints. - Attila Doroszlai

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-17 Thread Attila Doroszlai
> On Oct. 14, 2016, 10:59 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2430 > > <https://reviews.apache.org/r/52839/diff/1/?file=1534965#file1534965line2430>

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-17 Thread Attila Doroszlai
a (line 958) <https://reviews.apache.org/r/52839/#comment87> Whitespace ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java (line 962) <https://reviews.apache.org/r/52839/#comment88> Whitespace - Attila Doroszlai On Oct. 18, 2016, 1

Review Request 53174: AMBARI-18693 get_sysprep_skip_copy_tarballs_hdfs() always returns False

2016-10-25 Thread Attila Doroszlai
/data $ grep -A6 'copy_to_hdfs.*mapreduce' *output*txt | grep mapreduce Called copy_to_hdfs tarball: mapreduce Skipping copying /usr/hdp/2.5.0.0-1245/hadoop/mapreduce.tar.gz to /hdp/apps/2.5.0.0-1245/mapreduce/mapreduce.tar.gz for mapreduce as it is a sys prepped host. ``` Thanks, Attila

Review Request 53089: AMBARI-18108 Allow spaces in templeton.hive.properties

2016-10-21 Thread Attila Doroszlai
--- Manual test: cluster install via blueprint. Unit test added. Thanks, Attila Doroszlai

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-20 Thread Attila Doroszlai
ed: 0, Time elapsed: 0.168 sec - in org.apache.ambari.server.logging.ProfiledReentrantReadWriteLockTest * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 5012 licence. Thanks, Attila Doroszlai

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-20 Thread Attila Doroszlai
> On Oct. 7, 2016, 8:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/logging/LockFactory.java, > > line 50 > > <https://reviews.apache.org/r/52636/diff/1/?file=1526480#file1526480line50> > > > > There should be

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-20 Thread Attila Doroszlai
ed: 0, Time elapsed: 0.168 sec - in org.apache.ambari.server.logging.ProfiledReentrantReadWriteLockTest * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 5012 licence. Thanks, Attila Doroszlai

Re: Review Request 54064: Optimize loading of views in cloud environments

2016-11-25 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54064/#review156928 --- Ship it! Ship It! - Attila Doroszlai On Nov. 25, 2016, 10

Re: Review Request 54006: Ambari Server Unit Test failure: org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs

2016-11-23 Thread Attila Doroszlai
, Time elapsed: 0.785 sec - in org.apache.ambari.server.state.ServicePropertiesTest ``` - Attila Doroszlai On Nov. 23, 2016, 1:43 a.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

2016-11-23 Thread Attila Doroszlai
:2787: @Transactional should not be used on private methods [AvoidTransactionalOnPrivateMethods] Audit done. ... [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

2016-11-22 Thread Attila Doroszlai
/ Testing --- * Added unit test * Tested on live cluster by triggering the downscale problem Thanks, Attila Doroszlai

Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

2016-11-22 Thread Attila Doroszlai
* Tested on live cluster by triggering the downscale problem Thanks, Attila Doroszlai

Re: Review Request 53984: AMBARI-18958 - License file issue with src/test/resources/stacks/HDP/2.2.0/services/GANGLIA/upgrades/HDP/rolling-upgrade.xml

2016-11-22 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53984/#review156574 --- Ship it! Ship It! - Attila Doroszlai On Nov. 22, 2016, 3

  1   2   3   4   5   >