Review Request 51575: Provide stack-advisor support for Microsoft-R service

service via web UI; verified that service advisor is invoked in both recommend-component-layout and validate-component-layout requests, and that it correctly recommends/validates service colocation). Thanks, Attila Doroszlai

Re: Review Request 51575: Provide stack-advisor support for Microsoft-R service

ly, visit: https://reviews.apache.org/r/51575/#review147556 ------- On Sept. 1, 2016, 1:36 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

/#comment215803> * Indent by 2 spaces, not 4 * Would be nice to extract `/user/RevoShare` to a variable in `params` - Attila Doroszlai On Sept. 9, 2016, 8:16 a.m., Balázs Bence Sári wrote: > > --- > This is an automat

Review Request 51801: Get LDAP tests to run in concurrent forked JVMs

the patch are resolved Thanks, Attila Doroszlai

Re: Review Request 51801: Get LDAP tests to run in concurrent forked JVMs

` * Verified test failures/errors that occur without the patch are resolved Thanks, Attila Doroszlai

Review Request 51811: All classes recompiled due to Maven bug, even if none changed

mpile find ambari-server/src/main/java -type f | head -3 | xargs touch mvn -pl ambari-server compile ``` 3. Verify Maven compiles all Java sources after removing class files. ``` mvn -pl ambari-server compile find ambari-server -name '*.class' | xargs rm mvn -pl ambari-server compile `

Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

order by request_id, stage_id, task_id; ``` B. RevoShare 1. Install Ambari (trunk), add Microsoft R mpack, start Ambari 2. Create cluster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R 3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/` Thanks, Attila Doroszlai

Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

sts # -> verify only TestStackAdvisor was run mv -iv ambari-server/src/test/python/{_,}TestStackAdvisor.py mvn -pl ambari-server test -DskipSurefireTests -Drat.skip -Dpython.test.mask='TestS*py' # -> verify only TestServerClassPath...TestStackFeature were run (30 tests in 6 files a

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

, visit: https://reviews.apache.org/r/51914/#review149069 ------- On Sept. 15, 2016, 4:44 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

kip -Dpython.test.mask='TestS*py' # -> verify only TestServerClassPath...TestStackFeature were run (30 tests in 6 files as of now) ``` Thanks, Attila Doroszlai

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

luster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R 3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/` Thanks, Attila Doroszlai

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

_on_execute" is enough in itself if webhdfs is enabled, but the "execute" step is necessary if it is disabled. - Attila --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51906/#revi

Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

othing captured yet at org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest.postScheduleTest(RequestEventCreatorTest.java:73) ``` - Attila Doroszlai On Sept. 16, 2016, 3:44 p.m., wang yaoxin wrote: > > --- > This is an automatically gen

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51906/#review149214 ------- On Sept. 16, 2016, 4:57 p.m., Attila Doroszlai wrote: > > --

Review Request 52038: AMBARI-18418 StackServiceDirectory debug messages are logged with placeholders

/resources/stacks/HDP/2.4/services/ACCUMULO/package for service ACCUMULO for stack HDP-2.4 does not exist.` Thanks, Attila Doroszlai

Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

-Drat.skip -DskipTests -Del.log=INFO test-compile # -> verify output does not contain lines starting with "[EL Config]" and "[EL Finest]", only "[EL Warning]" mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=OFF test-compile # -> verify output does not c

Re: Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

L Warning]" mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=OFF test-compile # -> verify output does not contain any lines starting with "[EL " ``` Thanks, Attila Doroszlai

Re: Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

-server -Drat.skip -DskipTests -Del.log=OFF test-compile # -> verify output does not contain any lines starting with "[EL " ``` Thanks, Attila Doroszlai

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

tS*py' # -> verify only TestServerClassPath...TestStackFeature were run (30 tests in 6 files as of now) ``` Thanks, Attila Doroszlai

Re: Review Request 52123: Microsoft-R service should be supported on SLES11

2.3. - Attila Doroszlai On Sept. 22, 2016, 10:59 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52123: Microsoft-R service should be supported on SLES11

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52123/#review150379 --- Ship it! Ship It! - Attila Doroszlai On Sept. 22, 2016, 10

Review Request 52264: AMBARI-18466 Component should be renamed to "Microsoft R Server Client"

/ Testing --- Manual testing: created cluster with wizard Thanks, Attila Doroszlai

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

/UpdateActiveRepoVersionOnStartupTest.java (line 147) <https://reviews.apache.org/r/52266/#comment218759> Two unnecessary blank lines. - Attila Doroszlai On Sept. 28, 2016, 11:57 a.m., Balázs Bence Sári wrote: > > ---

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52266/#review150709 --- Ship it! Ship It! - Attila Doroszlai On Sept. 28, 2016, 11

Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

/ambari/ambari-server/target/findbugs/findbugsXml.xml [INFO] Transformed 1 file(s). [INFO] [INFO] BUILD SUCCESS ... ``` Thanks, Attila Doroszlai

Re: Review Request 52551: Update Mirosoft R version in mpack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52551/#review151497 --- Ship it! Ship It! - Attila Doroszlai On Oct. 5, 2016, 2:31

Re: Review Request 52629: Microsoft R Server management pack should support for Redhat 7

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52629/#review151792 --- Ship it! Ship It! - Attila Doroszlai On Oct. 7, 2016, 3:18

Re: Review Request 52630: Improve package handling in Microsoft R Server Mpack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52630/#review151805 --- Ship it! Ship It! - Attila Doroszlai On Oct. 7, 2016, 3:29

Review Request 52636: Implement instrumented Lock for profiling/logging

Time elapsed: 0.279 sec - in org.apache.ambari.server.logging.LockFactoryTest Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.168 sec - in org.apache.ambari.server.logging.ProfiledReentrantReadWriteLockTest * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 5012 licence. Thanks, Attila Doroszlai

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

enerated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review151833 ------- On Oct. 7, 2016, 6:25 p.m., Attila Doroszlai wrote: > > --- > This is an automati

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

ion.ConfigurationTest >Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec > - in org.apache.ambari.server.logging.DelegatingLockTest >Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.279 sec > - in org.apache.ambari.server.logging.LockFactoryTest >Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.168 sec > - in org.apache.ambari.server.logging.ProfiledReentrantReadWriteLockTest > * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 5012 licence. > > > Thanks, > > Attila Doroszlai > >

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

iledReentrantReadWriteLockTest * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 5012 licence. Thanks, Attila Doroszlai

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review151839 ------- On Oct. 7, 2016, 10:21 p.m., Attila Doroszlai wrote: > > --

Re: Review Request 52681: Add more logging to track what condition resulted in skipping agent commands

/52681/#comment220649> Is the ?: logic necessary? I think it would append "null" for null object anyway. - Attila Doroszlai On Oct. 10, 2016, 1:14 p.m., Sebastian Toader wrote: > > --- > This is an automatically

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

f the lock is never used. I will remove it. - Attila --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review151841 ------

Review Request 52736: AMBARI-18567 Cannot start Oozie if WebHDFS is disabled

``` Manual test: * install cluster via wizard (tested with HDP 2.4) * select Oozie and dependencies * disable WebHDFS * verify Oozie start succeeds Thanks, Attila Doroszlai

Re: Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

] [INFO] BUILD SUCCESS ... ``` Thanks, Attila Doroszlai

Review Request 52792: AMBARI-18581 Oozie start script ignores sysprep_skip_copy_oozie_share_lib_to_hdfs flag

(see https://issues.apache.org/jira/browse/AMBARI-18567) * verify Oozie skipped steps: "Skipping creation of oozie sharelib as host is sys prepped" Thanks, Attila Doroszlai

Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

125) <https://reviews.apache.org/r/52785/#comment221493> The `-y` flag for `install` is an alias for `--non-interactive`, so this change is not strictly necessary. https://en.opensuse.org/SDB:Zypper_manual_(plain) - Attila Doroszlai On Oct. 12, 2016, 4:36 p.m., Zsombor Gegesy

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

/configuration/Configuration.java (line 2430) <https://reviews.apache.org/r/52839/#comment221749> How about using `TimeUnit.MINUTES.toMillis(5)` instead of `30L`? - Attila Doroszlai On Oct. 13, 2016, 8:01 p.m., Amarnath reddy pappu

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

> On Oct. 14, 2016, 1:10 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 512 > > > > > > I'm curious - why use the configuration property getDef

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52860/#review152780 --- Ship it! Also tested with blueprints. - Attila Doroszlai On

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

> On Oct. 14, 2016, 10:59 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2430 > > <https://reviews.apache.org/r/52839/diff/1/?file=1534965#file1534965line2430>

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

a (line 958) <https://reviews.apache.org/r/52839/#comment87> Whitespace ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java (line 962) <https://reviews.apache.org/r/52839/#comment88> Whitespace - Attila Doroszlai On Oct. 18, 2016, 1

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

> On Oct. 18, 2016, 7:37 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 953-954 > > <https://reviews.apache.org/r/52839/diff/2/?file=1540039#file1540039line953> > > > >

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

> On Oct. 7, 2016, 8:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/logging/LockFactory.java, > > line 50 > > <https://reviews.apache.org/r/52636/diff/1/?file=1526480#file1526480line50> > > > > There should be

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

Time elapsed: 0.168 sec - in org.apache.ambari.server.logging.ProfiledReentrantReadWriteLockTest * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 5012 licence. Thanks, Attila Doroszlai

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

Time elapsed: 0.168 sec - in org.apache.ambari.server.logging.ProfiledReentrantReadWriteLockTest * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 5012 licence. Thanks, Attila Doroszlai

Review Request 53089: AMBARI-18108 Allow spaces in templeton.hive.properties

--- Manual test: cluster install via blueprint. Unit test added. Thanks, Attila Doroszlai

Review Request 53174: AMBARI-18693 get_sysprep_skip_copy_tarballs_hdfs() always returns False

/data $ grep -A6 'copy_to_hdfs.*mapreduce' *output*txt | grep mapreduce Called copy_to_hdfs tarball: mapreduce Skipping copying /usr/hdp/2.5.0.0-1245/hadoop/mapreduce.tar.gz to /hdp/apps/2.5.0.0-1245/mapreduce/mapreduce.tar.gz for mapreduce as it is a sys prepped host. ``` Thank

Review Request 53188: AMBARI-18700 Add HDFS resources for Spark2 to AmbariPreupload script

blueprint with SPARK2 service and `sysprep_skip_copy_tarballs_hdfs: true` * submit `START_ONLY` cluster creation request Thanks, Attila Doroszlai

Review Request 53189: AMBARI-18701 Add HDFS resources for HBase to AmbariPreupload script

--- Manual testing: * create sysprepped cluster * submit blueprint with HBASE service * submit `START_ONLY` cluster creation request Thanks, Attila Doroszlai

Review Request 53228: AMBARI-18702 Fix typos

/diff/ Testing --- Manually tested the ambari-agent error message by tweaking ambari-agent.ini to reach the changed if branch. No test for the doc changes. Thanks, Attila Doroszlai

Re: Review Request 53188: AMBARI-18700 Add HDFS resources for HBase, Spark, Spark2, Zeppelin to AmbariPreupload script

blueprint with HBASE, SPARK, SPARK2, ZEPPELIN services and `sysprep_skip_copy_tarballs_hdfs: true` * submit `START_ONLY` cluster creation request Thanks, Attila Doroszlai

Re: Review Request 53188: AMBARI-18700 Add HDFS resources for HBase, Spark, Spark2, Zeppelin to AmbariPreupload script

, Attila Doroszlai

Re: Review Request 53273: Not able to change the default port ambari server listens to

defined in `serverConfiguration` for default port and property names. Even nicer: extract the logic for getting the port (including check for SSL) into a function in `serverConfiguration`. Similar logic is implemented in `serverUtils.get_ambari_server_api_base()`. - Attila Doroszlai On Oct. 28

Re: Review Request 53273: Not able to change the default port ambari server listens to

ion: 'Fatal exception: File ambari.properties not found in search path $AMBARI_CONF_DIR: /etc/ambari-server/conf, exit code 1' ``` - Attila Doroszlai On Nov. 1, 2016, 6:39 a.m., Anita Jebaraj wrote: > >

Re: Review Request 53477: YARN ResourceManager UI alert check fails when YARN RM HA + SPNEGO is configured.

/services/WEBHCAT/package/files/alert_webhcat_server.py` also contains `curl -L`. Can you please check if that one needs to be changed, too? - Attila Doroszlai On Nov. 7, 2016, 9:22 a.m., Attila Magyar wrote: > > --- > T

Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

nodes) via blueprint Thanks, Attila Doroszlai

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

/TopologyManager.java bba0325 ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java f90cf76 Diff: https://reviews.apache.org/r/53576/diff/ Testing --- Created several clusters (size = 8-64 nodes) via blueprint Thanks, Attila Doroszlai

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

enerated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155432 --- On Nov. 9, 2016, 11:27 a.m., Attila Doroszlai wrote: > > --- > This is an automati

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

/configuration/ConfigurationTest.java f90cf76 Diff: https://reviews.apache.org/r/53576/diff/ Testing --- Created several clusters (size = 8-64 nodes) via blueprint Thanks, Attila Doroszlai

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

e.org/r/53576/#review155436 --- On Nov. 9, 2016, 4:07 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155560 ------- On Nov. 9, 2016, 4:07 p.m., Attila Doroszlai wrote: > > --

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

java/org/apache/ambari/server/topology/TopologyManager.java > bba0325 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > f90cf76 > > Diff: https://reviews.apache.org/r/53576/diff/ > > > Testing > --- > > Created several clusters (size = 8-64 nodes) via blueprint > > > Thanks, > > Attila Doroszlai > >

Re: Review Request 53721: Zeppelin notebook execution fails due missing spark dependency

/scripts/Ambaripreupload.py` as well. Thanks. - Attila Doroszlai On Nov. 14, 2016, 8:35 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53778: Oozie config not shown as stale upon changing DefaultFS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53778/#review155902 --- Ship it! Ship It! - Attila Doroszlai On Nov. 15, 2016, 11

Re: Review Request 53721: Zeppelin notebook execution fails due missing spark dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53721/#review155986 --- Ship it! Ship It! - Attila Doroszlai On Nov. 15, 2016, 12

Re: Review Request 53798: AMBARI-18902 Minor typo fix in TimeliveMetricsStore class in AMS

, `TimeliveMetricsStore` is actually `TimelineMetricStore` in the code ;) - Attila Doroszlai On Nov. 15, 2016, 11:33 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53810: Oozie service check fails due to timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53810/#review156064 --- Ship it! Ship It! - Attila Doroszlai On Nov. 16, 2016, 3:12

Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

* Tested on live cluster by triggering the downscale problem Thanks, Attila Doroszlai

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

/ Testing --- * Added unit test * Tested on live cluster by triggering the downscale problem Thanks, Attila Doroszlai

Re: Review Request 53984: AMBARI-18958 - License file issue with src/test/resources/stacks/HDP/2.2.0/services/GANGLIA/upgrades/HDP/rolling-upgrade.xml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53984/#review156574 --- Ship it! Ship It! - Attila Doroszlai On Nov. 22, 2016, 3

Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

: @Transactional should not be used on private methods [AvoidTransactionalOnPrivateMethods] Audit done. ... [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 54006: Ambari Server Unit Test failure: org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs

, Time elapsed: 0.785 sec - in org.apache.ambari.server.state.ServicePropertiesTest ``` - Attila Doroszlai On Nov. 23, 2016, 1:43 a.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

:2787: @Transactional should not be used on private methods [AvoidTransactionalOnPrivateMethods] Audit done. ... [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

[AvoidTransactionalOnPrivateMethods] [WARN] ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java:2787: @Transactional should not be used on private methods [AvoidTransactionalOnPrivateMethods] Audit done. ... [INFO] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 54064: Optimize loading of views in cloud environments

rver/src/main/java/org/apache/ambari/server/view/ViewRegistry.java (line 1013) <https://reviews.apache.org/r/54064/#comment227161> Typo: "Start" -> "Finished" ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java (lines 1571 - 1610) <https://

Re: Review Request 54064: Optimize loading of views in cloud environments

/configuration/Configuration.java (line 1876) <https://reviews.apache.org/r/54064/#comment227265> ``` ConfigurationTest.testAllPropertiesHaveMarkdownDescriptions:1058 The configuration property view.extract-after-cluster-config is missing the Markdown annotation ``` - Attila Doroszlai

Re: Review Request 54064: Optimize loading of views in cloud environments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54064/#review156928 --- Ship it! Ship It! - Attila Doroszlai On Nov. 25, 2016, 10

Re: Review Request 53943: Improve remoteIp in audit log

typo: "Muti" -> "Multi" 2. Should begin with "is" by convention (although I think something like `containsMultipleRemoteAddresses` would be better) ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java (line 87) <https://reviews.a

Re: Review Request 53943: Improve remoteIp in audit log

> On Nov. 29, 2016, 12:55 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > line 87 > > <https://reviews.apache.org/r/53943/diff/2/?file=1571575#file1571575line87> > > > > unnecessary

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157239 --- Ship it! Ship It! - Attila Doroszlai On Nov. 29, 2016, 1:16

Re: Review Request 54159: Log Search external login credential let every user in

-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java (line 72) <https://reviews.apache.org/r/54159/#comment227774> Using `Response.Status.fromStatusCode(int)` would make the code more readable. - Attila Doroszlai On Nov. 29, 2016, 1:25 p.m., Oliver Szabo

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

ght prevent some surprises down the road. - Attila Doroszlai On Nov. 29, 2016, 6:04 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

] BUILD SUCCESS ``` Thanks, Attila Doroszlai

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

/AmbariJpaLocalTxnInterceptorTest.java PRE-CREATION Diff: https://reviews.apache.org/r/53977/diff/ Testing --- * Added unit test * Tested on live cluster by triggering the downscale problem Thanks, Attila Doroszlai

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53977/#review157468 ------- On Nov. 30, 2016, 10:42 p.m., Attila Doroszlai wrote: > > --- > This

Re: Review Request 54252: Data model and Json parser for quick link profiles.

/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java (line 21) <https://reviews.apache.org/r/54252/#comment228279> `import *` should be avoided. ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParse

Re: Review Request 54252: Data model and Json parser for quick link profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/#review157751 --- Ship it! Ship It! - Attila Doroszlai On Dec. 2, 2016, 3:10

Re: Review Request 54318: Escaped usernames passed to the post-user creation script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54318/#review157986 --- Ship it! - Attila Doroszlai On Dec. 5, 2016, 11:42 a.m

Review Request 54377: AMBARI-19086 LDAP sync creates group with local type

/server/security/ldap/AmbariLdapDataPopulatorTest.java 1866b12 Diff: https://reviews.apache.org/r/54377/diff/ Testing --- Manual test (install Ambari, replace ambari-server JAR, perform LDAP sync). Unit tests. Thanks, Attila Doroszlai

Re: Review Request 54399: Broken links in ambari-server/docs/api/v1/schemas.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54399/#review158128 --- Ship it! Ship It! - Attila Doroszlai On Dec. 6, 2016, 1:06

Review Request 54424: AMBARI-19107 False warning about NTP not running on SUSE12

search chrony No packages found. ``` ### Ubuntu 14.04 ``` # service ntp status * NTP server is running # service chrony status * chronyd is running # service ntpd status ntpd: unrecognized service # service chronyd status chronyd: unrecognized service ``` Thanks, Attila Doroszlai

Re: Review Request 54447: Add timeout for LogSearch and Infra Solr metainfo.xml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54447/#review158308 --- Ship it! Ship It! - Attila Doroszlai On Dec. 6, 2016, 9:51

Review Request 54612: AMBARI-19158. Plugin configuration ignored when directly running checkstyle goals

put the required modules in the local Maven repo. Thanks, Attila Doroszlai

Review Request 54614: AMBARI-19160. Add ReviewBoard config file

`rbt login` once before being able to post. Thanks, Attila Doroszlai

Re: Review Request 54614: AMBARI-19160. Add ReviewBoard config file

--testing-done-file ~/Documents/AMBARI-19160-test.txt Review request #54614 posted. ``` Note: need to `rbt login` once before being able to post. Thanks, Attila Doroszlai

Re: Review Request 54614: AMBARI-19160. Add ReviewBoard config file

> Diff: https://reviews.apache.org/r/54614/diff/ > > > Testing > --- > > ``` > $ mvn -N -DskipTests test > ... > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 2602 licence. > > $ rbt post --bugs-closed AMBARI-19160 --testing-done-file > ~/Documents/AMBARI-19160-test.txt > Review request #54614 posted. > ``` > > Note: need to `rbt login` once before being able to post. > > > Thanks, > > Attila Doroszlai > >

Re: Review Request 54614: AMBARI-19160. Add ReviewBoard config file

/AMBARI-19160-test.txt Review request #54614 posted. ``` Note: need to `rbt login` once before being able to post. Thanks, Attila Doroszlai

  1   2   3   4   5   6   >