[kudu-CR] KUDU-1890 Allow renaming of primary key column

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#5). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] Combine redaction flag for log and flags into one.

Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/11/src/kudu/util/flags.cc File

[kudu-CR] WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

David Ribeiro Alves has posted comments on this change. Change subject: WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 1: (1 comment)

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6168 to look at the new patch set (#3). Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Fix

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

Todd Lipcon has posted comments on this change. Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Patch Set 2: needed a rebase, so just did that on Sailesh's behalf -- To view, visit

[kudu-CR] Misc optimizations to BinaryPlainBlockDecoder

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6159 to look at the new patch set (#3). Change subject: Misc optimizations to BinaryPlainBlockDecoder .. Misc

[kudu-CR] Micro-optimizations to try to inline DeltaKey::DecodeFrom

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6160 to look at the new patch set (#2). Change subject: Micro-optimizations to try to inline DeltaKey::DecodeFrom ..

[kudu-CR] Combine redaction flag for log and flags into one.

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#12). Change subject: Combine redaction flag for log and flags into one.

[kudu-CR] [doxygen] fixed recent doxygen warnings

Adar Dembo has posted comments on this change. Change subject: [doxygen] fixed recent doxygen warnings .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6174 To unsubscribe, visit

[kudu-CR] [catalog manager] proper handling of catalog shutdown

Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-1899. Fix support for empty string keys

Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6163 to look at the new patch set (#2). Change subject: KUDU-1899. Fix support for empty string keys

[kudu-CR] KUDU-1899. Fix support for empty string keys

Todd Lipcon has posted comments on this change. Change subject: KUDU-1899. Fix support for empty string keys .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6163/1/src/kudu/client/client-test.cc File

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Mike Percy has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 8: Thanks, I'll let David wrap up the review on this -- To view, visit

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/6173 Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. KUDU-1898: /varz page doesn't HTML-escape flag values This fix the

[kudu-CR] [util] conventional signature for Status::operator=()

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6175 Change subject: [util] conventional signature for Status::operator=() .. [util] conventional signature for Status::operator=() Updated

[kudu-CR] [catalog manager] proper handling of catalog shutdown

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#4). Change subject: [catalog_manager] proper handling of catalog shutdown

[kudu-CR] KUDU-1896 (part 1). Add redaction to JSON protobuf output

Todd Lipcon has posted comments on this change. Change subject: KUDU-1896 (part 1). Add redaction to JSON protobuf output .. Patch Set 1: (1 comment)

[kudu-CR] Combine redaction flag for log and flags into one.

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#11). Change subject: Combine redaction flag for log and flags into one. .. Combine

[kudu-CR] Combine redaction flag for log and flags into one.

Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/10/src/kudu/util/flags.cc File

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Alexey Serbin has submitted this change and it was merged. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. [catalog manager] fixed deadlock on catalog shutdown Fixed deadlock on system catalog manager

[kudu-CR] [linked list test] use timeout for WaitAndVerify in all modes

Alexey Serbin has submitted this change and it was merged. Change subject: [linked list test] use timeout for WaitAndVerify in all modes .. [linked list test] use timeout for WaitAndVerify in all modes Constrain

[kudu-CR] [linked list test] use timeout for WaitAndVerify in all modes

Alexey Serbin has posted comments on this change. Change subject: [linked list test] use timeout for WaitAndVerify in all modes .. Patch Set 1: (1 comment) Thank you for the review!

[kudu-CR] KUDU-1898: /varz page doesn't HTML-escape flag values

Adar Dembo has posted comments on this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6173/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#5). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

Todd Lipcon has posted comments on this change. Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6168 To unsubscribe, visit

[kudu-CR] [util] conventional signature for Status::operator=()

Todd Lipcon has posted comments on this change. Change subject: [util] conventional signature for Status::operator=() .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6175/2/src/kudu/util/status.h File

[kudu-CR] [catalog manager] proper handling of catalog shutdown

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#2). Change subject: [catalog_manager] proper handling of catalog shutdown ..

[kudu-CR] [catalog manager] proper handling of catalog shutdown

Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 1: (5 comments) > (4 comments) > > As a general point, it sucks that Status isn't

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Mike Percy has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6134 To unsubscribe, visit

[kudu-CR] Combine redaction flag for log and flags into one.

Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6112 To unsubscribe, visit

[kudu-CR] [catalog manager] proper handling of catalog shutdown

Adar Dembo has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 2: Code-Review+1 Will defer to Mike and/or David; I bet they have stronger opinions on this than

[kudu-CR] Fix security tests on macOS

Alexey Serbin has posted comments on this change. Change subject: Fix security tests on macOS .. Patch Set 1: (2 comments) This looks much cleaner than the original approach with separate flags for squeasel and libcurl.

[kudu-CR] [catalog manager] proper handling of catalog shutdown

Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6170/2/src/kudu/master/catalog_manager.h

[kudu-CR] [catalog manager] proper handling of catalog shutdown

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#3). Change subject: [catalog_manager] proper handling of catalog shutdown

[kudu-CR] WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

Mike Percy has posted comments on this change. Change subject: WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#6). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] Micro-optimizations to try to inline DeltaKey::DecodeFrom

Todd Lipcon has posted comments on this change. Change subject: Micro-optimizations to try to inline DeltaKey::DecodeFrom .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6160/1/src/kudu/tablet/delta_key.h

[kudu-CR] [catalog manager] proper handling of catalog shutdown

Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 2: > Will defer to Mike and/or David; I bet they have stronger opinions > on this than I do.

[kudu-CR] [util] conventional signature for Status::operator=()

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6175 to look at the new patch set (#2). Change subject: [util] conventional signature for Status::operator=() .. [util]

[kudu-CR] Fix LTO support

Todd Lipcon has submitted this change and it was merged. Change subject: Fix LTO support .. Fix LTO support This fixes the CMake setup to be able to do LTO builds using lld and clang. I was able to successfully enable LTO with

[kudu-CR] Combine redaction flag for log and flags into one.

Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/11/src/kudu/util/flags.cc File

[kudu-CR] Combine redaction flag for log and flags into one.

Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 11: Code-Review+2 Looks good to me, maybe see if Todd wants to rereview? -- To view, visit

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

David Ribeiro Alves has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6134 To unsubscribe,

[kudu-CR] [linked list test] use timeout for WaitAndVerify in all modes

Mike Percy has posted comments on this change. Change subject: [linked list test] use timeout for WaitAndVerify in all modes .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [linked list test] use timeout for WaitAndVerify in all modes

Mike Percy has posted comments on this change. Change subject: [linked list test] use timeout for WaitAndVerify in all modes .. Patch Set 1: (1 comment)

[kudu-CR] Fix security tests on macOS

Hello Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6176 to review the following change. Change subject: Fix security tests on macOS .. Fix security tests on

[kudu-CR] [util] conventional signature for Status::operator=()

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6175 to look at the new patch set (#3). Change subject: [util] conventional signature for Status::operator=() .. [util]

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 5: (1 comment)

[kudu-CR] Fix LTO support

Adar Dembo has posted comments on this change. Change subject: Fix LTO support .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6162 To unsubscribe, visit

[kudu-CR] KUDU-1896 (part 1). Add redaction to JSON protobuf output

Hao Hao has posted comments on this change. Change subject: KUDU-1896 (part 1). Add redaction to JSON protobuf output .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] Misc optimizations to BinaryPlainBlockDecoder

David Ribeiro Alves has posted comments on this change. Change subject: Misc optimizations to BinaryPlainBlockDecoder .. Patch Set 2: (2 comments)

[kudu-CR] Micro-optimizations to try to inline DeltaKey::DecodeFrom

David Ribeiro Alves has posted comments on this change. Change subject: Micro-optimizations to try to inline DeltaKey::DecodeFrom .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1890 Allow renaming of primary key column

Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 5: (1 comment) Pretty much LGTM. One small docs nit, and it looks like a security-related

[kudu-CR] KUDU-1899. Fix support for empty string keys

Adar Dembo has posted comments on this change. Change subject: KUDU-1899. Fix support for empty string keys .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6163/1/src/kudu/client/client-test.cc File

[kudu-CR] Combine redaction flag for log and flags into one.

Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/6112/8/src/kudu/common/column_predicate-test.cc

[kudu-CR] Combine redaction flag for log and flags into one.

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#9). Change subject: Combine redaction flag for log and flags into one. .. Combine

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

Todd Lipcon has posted comments on this change. Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Patch Set 1: (1 comment)

[kudu-CR] Combine redaction flag for log and flags into one.

Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/6112/9/src/kudu/util/flags.cc File

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Alexey Serbin has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/6134/4//COMMIT_MSG Commit Message: PS4,

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6134 to look at the new patch set (#7). Change subject: [catalog manager] fixed deadlock on catalog shutdown

[kudu-CR] [catalog manager] proper handling of catalog shutdown

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6170 Change subject: [catalog_manager] proper handling of catalog shutdown .. [catalog_manager] proper handling of catalog shutdown

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

Todd Lipcon has posted comments on this change. Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Patch Set 1: Also the precommit failure here seems unrelated. I pointed Dan to it to see if he has any ideas. --

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/6168 Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Fix TestKerberosRenewal/Reacquire flakiness It has been observed that an

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Mike Percy has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/6134/6//COMMIT_MSG Commit Message: Line 16:

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Mike Percy has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6134/6/src/kudu/master/catalog_manager.cc

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Mike Percy has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6134/6/src/kudu/master/catalog_manager.cc

[kudu-CR] Combine redaction flag for log and flags into one.

Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/10/src/kudu/util/flags.cc File

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

Sailesh Mukil has posted comments on this change. Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Patch Set 2: (1 comment)

[kudu-CR] Fix TestKerberosRenewal/Reacquire flakiness

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6168 to look at the new patch set (#2). Change subject: Fix TestKerberosRenewal/Reacquire flakiness .. Fix

[kudu-CR] server negotiation: improve error handling

Alexey Serbin has posted comments on this change. Change subject: server_negotiation: improve error handling .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6154/1/src/kudu/rpc/server_negotiation.cc File

[kudu-CR] Combine redaction flag for log and flags into one.

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#10). Change subject: Combine redaction flag for log and flags into one. .. Combine

[kudu-CR] Combine redaction flag for log and flags into one.

Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/6112/9/src/kudu/util/flags.cc File

[kudu-CR] Combine redaction flag for log and flags into one.

Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/10/src/kudu/util/flags.cc File

[kudu-CR] [catalog manager] proper handling of catalog shutdown

Adar Dembo has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown .. Patch Set 1: (4 comments) As a general point, it sucks that Status isn't full-featured enough to include

[kudu-CR] Combine redaction flag for log and flags into one.

Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6112/10/src/kudu/util/flags.cc File

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Mike Percy has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 7: Code-Review+1 Spoke to Alexey offline about this, the approach seems reasonable to me now.

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Alexey Serbin has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/6134/6//COMMIT_MSG Commit Message: Line

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6134 to look at the new patch set (#8). Change subject: [catalog manager] fixed deadlock on catalog shutdown