[kudu-CR] KUDU-2069 pt 1: add a maintenance mode

2019-08-21 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14111 Change subject: KUDU-2069 pt 1: add a maintenance mode .. KUDU-2069 pt 1: add a maintenance mode When tablet server T is put in maintenan

[kudu-CR] Add ExtractFloat method to JsonReader and improve ExtractDouble method

2019-08-21 Thread Yifan Zhang (Code Review)
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14114 Change subject: Add ExtractFloat method to JsonReader and improve ExtractDouble method .. Add ExtractFloat method to JsonReader and impro

[kudu-CR] [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method

2019-08-21 Thread Yifan Zhang (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14114 to look at the new patch set (#2). Change subject: [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method ..

[kudu-CR] Move some rebalancing logic from tools to master

2019-08-21 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 ) Change subject: Move some rebalancing logic from tools to master .. Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/14

[kudu-CR] Move some rebalancing logic from tools to master

2019-08-21 Thread Hannah Nguyen (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14110 to look at the new patch set (#2). Change subject: Move some rebalancing logic from tools to master .. Mo

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14061 To unsubs

[kudu-CR] Move some rebalancing logic from tools to master

2019-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 ) Change subject: Move some rebalancing logic from tools to master .. Patch Set 2: (4 comments) I took a quick look and I think it's a

[kudu-CR] [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method

2019-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14114 ) Change subject: [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method .. Patch Set 2: The ASAN failure looks rea

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Patch Set 10: Verified+1 Code-Review+2 Overriding Jenkins, fa

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. [tablet] Fixed the bug of DeltaTracker::CountDeletedRo

[kudu-CR] Move some rebalancing logic from tools to master

2019-08-21 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 ) Change subject: Move some rebalancing logic from tools to master .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/141

[kudu-CR] Move some rebalancing logic from tools to master

2019-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 ) Change subject: Move some rebalancing logic from tools to master .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14110/2

[kudu-CR] KUDU-2069 pt 1: add a maintenance mode

2019-08-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14111 ) Change subject: KUDU-2069 pt 1: add a maintenance mode .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14111/1//COMMIT

[kudu-CR] Move some rebalancing logic from tools to master

2019-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 ) Change subject: Move some rebalancing logic from tools to master .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14110/2

[kudu-CR] Move some rebalancing logic from tools to master

2019-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 ) Change subject: Move some rebalancing logic from tools to master .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/141

[kudu-CR] Move some rebalancing logic from tools to master

2019-08-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 ) Change subject: Move some rebalancing logic from tools to master .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14110

[kudu-CR] [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method

2019-08-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14114 ) Change subject: [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method .. Patch Set 2: (1 comment) http://gerri

[kudu-CR] [thirdparty] introduce chrony

2019-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 2: > (1 comment) Whoops. Not it's fixed. -- To view, visit http://gerri

[kudu-CR] [thirdparty] introduce chrony

2019-08-21 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13915 to look at the new patch set (#3). Change subject: [thirdparty] introduce chrony .. [third

[kudu-CR] [thirdparty] introduce chrony

2019-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13915 To u

[kudu-CR] WIP: Create kudu/rebalance subdirectory

2019-08-21 Thread Hannah Nguyen (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14110 to look at the new patch set (#3). Change subject: WIP: Create kudu/rebalance subdirectory ...

[kudu-CR] WIP: Create kudu/rebalance subdirectory

2019-08-21 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 ) Change subject: WIP: Create kudu/rebalance subdirectory .. Patch Set 3: (12 comments) I've uploaded PS3 as a WIP patch to address eve

[kudu-CR] WIP: Create kudu/rebalance subdirectory

2019-08-21 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 ) Change subject: WIP: Create kudu/rebalance subdirectory .. Patch Set 3: > (12 comments) > > I've uploaded PS3 as a WIP patch to addr

[kudu-CR] [thirdparty] introduce chrony

2019-08-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13915 To

[kudu-CR] docs: correct invalid link about schema design

2019-08-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14028 ) Change subject: docs: correct invalid link about schema_design .. docs: correct invalid link about schema_design Change-Id: I41e

[kudu-CR] docs: correct invalid link about schema design

2019-08-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14028 ) Change subject: docs: correct invalid link about schema_design .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[kudu-CR] WIP: Create kudu/rebalance subdirectory

2019-08-21 Thread Hannah Nguyen (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14110 to look at the new patch set (#4). Change subject: WIP: Create kudu/rebalance subdirectory ...

[kudu-CR] [thirdparty] introduce chrony

2019-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. [thirdparty] introduce chrony Added chrony into the thirdparty: a set of foll

[kudu-CR] [test] handle ScanTableToStrings() result status

2019-08-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/11825 ) Change subject: [test] handle ScanTableToStrings() result status .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] [test] handle ScanTableToStrings() result status

2019-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11825 ) Change subject: [test] handle ScanTableToStrings() result status .. [test] handle ScanTableToStrings() result status Updated t

[kudu-CR] [clock] introduce mini chronyd

2019-08-21 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13916 to look at the new patch set (#4). Change subject: [clock] introduce mini_chronyd .. [clock] introduce

[kudu-CR] [clock] introduce mini chronyd

2019-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13916 ) Change subject: [clock] introduce mini_chronyd .. Patch Set 4: (12 comments) http://gerrit.cloudera.org:8080/#/c/13916/3/src/kudu/clo