Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/#review90018 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp

Re: Review Request 36078: Refactored Call message to include Subscribe message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36078/#review90011 --- include/mesos/scheduler/scheduler.proto (line 188)

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90019 --- I haven't looked at the patch itself, but looks like reviewbot is fa

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36061/#review90014 --- I'm sorry, but I don't understand how LOG(FATAL) was segfaulting bef

Re: Review Request 36036: Add `version` string to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/#review90021 --- Patch looks great! Reviews applied: [36036] All tests passed. - M

Re: Review Request 36036: Add `version` string to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/#review90024 --- Ship it! Looks good. Remove the unnecessary logging, and clean up t

Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36079/#review90031 --- Patch looks great! Reviews applied: [36077, 36078, 35855, 35856, 35

Re: Review Request 36068: MESOS-2966: Fix 'peer()' call for ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36068/#review90033 --- Ship it! Looks good to me, but I'll let BenH give the final approva

Re: Review Request 35799: Support mounting relative paths with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35799/#review90040 --- Ship it! Looks good - just a few minor const. suggestions :) src/

Re: Review Request 36048: Update authorizer to allow for modularize implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 1, 2015, 3:24 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

> On June 1, 2015, 8:34 a.m., Adam B wrote: > > src/master/http.cpp, line 1038 > > > > > > Could I ask you to write a quick unit test for this? > > haosdent huang wrote: > yes > > haosdent huang wrote: > @ad

Re: Review Request 36071: Add flow diagram for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36071/#review90052 --- When trying to apply locally, I get: ``` $ ./support/apply-review.sh

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

> On June 1, 2015, 1:34 a.m., Adam B wrote: > > src/master/http.cpp, line 1038 > > > > > > Could I ask you to write a quick unit test for this? > > haosdent huang wrote: > yes > > haosdent huang wrote: > @ad

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

> On June 1, 2015, 8:34 a.m., Adam B wrote: > > src/master/http.cpp, line 1038 > > > > > > Could I ask you to write a quick unit test for this? > > haosdent huang wrote: > yes > > haosdent huang wrote: > @ad

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

> On June 1, 2015, 1:34 a.m., Adam B wrote: > > src/master/http.cpp, line 1038 > > > > > > Could I ask you to write a quick unit test for this? > > haosdent huang wrote: > yes > > haosdent huang wrote: > @ad

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

> On July 1, 2015, 7:20 a.m., Adam B wrote: > > I'm sorry, but I don't understand how LOG(FATAL) was segfaulting before. > > Please explain. Hi Adam, This was reported as a segfault by a user in IRC. The specific segfault was fixed by MESOS-2636. The segfault _was_ happening under an error con

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

> On July 1, 2015, 12:20 a.m., Adam B wrote: > > I'm sorry, but I don't understand how LOG(FATAL) was segfaulting before. > > Please explain. > > Joris Van Remoortere wrote: > Hi Adam, > This was reported as a segfault by a user in IRC. The specific segfault > was fixed by MESOS-2636.

Re: Review Request 36077: Renamed low level scheduler libprocess test to event call framework test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36077/#review90075 --- Ship it! Alternatively, now that we're mostly calling this the HTTP

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review90076 --- support/post-reviews.py (lines 170 - 176)

Re: Review Request 36071: Add flow diagram for docker containerizer.

> On July 1, 2015, 11:45 a.m., Till Toenshoff wrote: > > When trying to apply locally, I get: > > ``` > > $ ./support/apply-review.sh 36071 > > 2015-07-01 17:43:28 URL:https://reviews.apache.org/r/36071/diff/raw/ > > [1338/1338] -> "36071.patch" [1] > > 36071.patch:15: new blank line at EOF. > >

Re: Review Request 36078: Refactored Call message to include Subscribe message.

> On July 1, 2015, 5:41 a.m., Kapil Arya wrote: > > include/mesos/scheduler/scheduler.proto, lines 298-305 > > > > > > May be I am missing something here, but shouldn't we avoid changing the > > numbered tags for the

Re: Review Request 36071: Add flow diagram for docker containerizer.

> On July 1, 2015, 3:45 p.m., Till Toenshoff wrote: > > When trying to apply locally, I get: > > ``` > > $ ./support/apply-review.sh 36071 > > 2015-07-01 17:43:28 URL:https://reviews.apache.org/r/36071/diff/raw/ > > [1338/1338] -> "36071.patch" [1] > > 36071.patch:15: new blank line at EOF. > >

Re: Review Request 36071: Add flow diagram for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36071/ --- (Updated July 1, 2015, 6:24 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36079/#review90095 --- src/master/master.cpp (line 2072)

Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36079/#review90098 --- Ship it! Looks good, just one minor comment. - Anand Mazumdar On

Re: Review Request 35934: New "Not Acceptable" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35934/ --- (Updated July 1, 2015, 6:48 p.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 1, 2015, 6:52 p.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36073: New "Method Not Allowed" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36073/ --- (Updated July 1, 2015, 6:51 p.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36079/#review90110 --- Ship it! Ship It! - Isabel Jimenez On July 1, 2015, 5:28 a.m., V

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90102 --- Adding some minor test-based comments. src/tests/call_tests.cpp (l

Re: Review Request 36078: Refactored Call message to include Subscribe message.

> On July 1, 2015, 7:06 a.m., Kapil Arya wrote: > > include/mesos/scheduler/scheduler.proto, line 188 > > > > > > Should there be a default behavior (say always override the older > > framework)? > > > > I al

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 1, 2015, 7:23 p.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 1, 2015, 7:30 p.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

> On July 1, 2015, 7:11 p.m., Anand Mazumdar wrote: > > src/tests/call_tests.cpp, line 85 > > > > > > From the design doc : > > https://docs.google.com/document/d/1pnIY_HckimKNvpqhKRhbc9eSItWNFT-priXh_urR-T0/edit# > >

Re: Review Request 36036: Add `version` string to MasterInfo

> On July 1, 2015, 1:54 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 369 > > > > > > s/Release/Version/ as per @adam comment, I'm removing this from the log - Marco -

Re: Review Request 36078: Refactored Call message to include Subscribe message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36078/#review90080 --- Looks good overall, mainly curious if 'force' should be optional, gi

Re: Review Request 36036: Add `version` string to MasterInfo

> On July 1, 2015, 7:48 a.m., Adam B wrote: > > src/common/protobuf_utils.cpp, lines 147-149 > > > > > > Could join these paragraphs. I think they're related enough, and the > > first one is short. Unless you feel st

Re: Review Request 36036: Add `version` string to MasterInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/ --- (Updated July 1, 2015, 7:56 p.m.) Review request for mesos, Anand Mazumdar, Isa

Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36079/#review90120 --- Ship it! +1 to Anand's comment since it is not a temporary. - Ben

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

> On July 1, 2015, 7:20 a.m., Adam B wrote: > > I'm sorry, but I don't understand how LOG(FATAL) was segfaulting before. > > Please explain. > > Joris Van Remoortere wrote: > Hi Adam, > This was reported as a segfault by a user in IRC. The specific segfault > was fixed by MESOS-2636. >

Re: Review Request 35934: New "Not Acceptable" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35934/#review90130 --- Ship it! Ship It! - Ben Mahler On July 1, 2015, 6:48 p.m., Isabe

Re: Review Request 35939: New "Conflict" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35939/#review90131 --- Ship it! Ship It! - Ben Mahler On June 26, 2015, 6:58 p.m., Isab

Re: Review Request 36072: New "Unsupported" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36072/#review90132 --- 3rdparty/libprocess/include/process/http.hpp (line 455)

Re: Review Request 36073: New "Method Not Allowed" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36073/#review90133 --- Ship it! Ship It! - Ben Mahler On July 1, 2015, 6:51 p.m., Isabe

Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/ --- Review request for mesos, Ian Downes, Joris Van Remoortere, and Timothy Chen. R

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/ --- (Updated July 1, 2015, 9:38 p.m.) Review request for mesos, Ian Downes, Joris V

Re: Review Request 36078: Refactored Call message to include Subscribe message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36078/ --- (Updated July 1, 2015, 9:43 p.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 36078: Refactored Call message to include Subscribe message.

> On July 1, 2015, 7:52 p.m., Ben Mahler wrote: > > include/mesos/scheduler/scheduler.proto, line 167 > > > > > > Hm.. first in which context? For HTTP, the scheduler has to keep a > > working Subscribe connection to

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90139 --- src/linux/cgroups.cpp (line 2002)

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/linux/cgroups.cpp, line 2014 > > > > > > I don't think we usually define a inline function like this anywhere > > else, so curious to see what others think. >

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/tests/cgroups_tests.cpp, line 1192 > > > > > > Add using to the top of the tests Since this is an alias (typedef) and scoped for the function. - Jojy

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90140 --- src/linux/cgroups.hpp (lines 438 - 440)

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/linux/cgroups.cpp, line 2014 > > > > > > I don't think we usually define a inline function like this anywhere > > else, so curious to see what others think. >

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/linux/cgroups.cpp, line 2060 > > > > > > Why add trailing underscore? > > Jojy Varghese wrote: > As a member variable(is accepted according to mesos codin

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

> On June 25, 2015, 8:25 a.m., Marco Massenzio wrote: > > src/master/master.cpp, line 2831 > > > > > > not sure this is allowed in our code style, but this could be a good > > place for `nullptr` > > > > Als

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

> On June 28, 2015, 11:56 p.m., Benjamin Hindman wrote: > > src/master/master.cpp, line 2247 > > > > > > How about a comment that captures the backwards compatible semantics > > you're accounting for here? Not sure

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/ --- (Updated July 1, 2015, 10:16 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 35856: Added Revive call support to the master and C++ scheduler library.

> On June 25, 2015, 10:17 p.m., Marco Massenzio wrote: > > src/tests/scheduler_tests.cpp, line 736 > > > > > > Same comment as the other review :) > > > > Great test, worth maybe factoring some of the common f

Re: Review Request 35856: Added Revive call support to the master and C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35856/ --- (Updated July 1, 2015, 10:17 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

> On June 25, 2015, 6:25 p.m., Isabel Jimenez wrote: > > src/master/master.hpp, line 1040 > > > > > > Is the purpose of moving this here to order Call handling methods? if > > yes, should we move revive too? the ord

Re: Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35857/ --- (Updated July 1, 2015, 10:18 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.

> On June 25, 2015, 4:12 p.m., Marco Massenzio wrote: > > src/tests/scheduler_tests.cpp, line 830 > > > > > > This is a great test (in fact, this looks to me like something we could > > extract as example of call sequ

Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.

> On June 25, 2015, 5:20 p.m., Isabel Jimenez wrote: > > src/scheduler/scheduler.cpp, line 306 > > > > > > Now that we're sending calls in every case (besides SUBSCRIBE) of this > > switch, I suppose it'll be better t

Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35858/ --- (Updated July 1, 2015, 10:19 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36079/ --- (Updated July 1, 2015, 10:20 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 36112: perf: extracted out a 'version' function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36112/ --- Review request for mesos, Ian Downes, Paul Brett, and Cong Wang. Bugs: MESOS-28

Review Request 36113: perf: refactored parse to allow determining an output parsing function based on the runtime version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36113/ --- Review request for mesos, Ian Downes, Paul Brett, and Cong Wang. Bugs: mesos-28

Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/ --- Review request for mesos, Ian Downes, Paul Brett, and Cong Wang. Bugs: mesos-28

Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/ --- Review request for mesos, Ian Downes, Paul Brett, and Cong Wang. Bugs: mesos-28

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:54 p.m., Marco Massenzio wrote: > > src/linux/cgroups.cpp, line 2002 > > > > > > and, in any event, the variables should have a meaningful name - should > > these be `userTime` or something? > >

Re: Review Request 36074: MESOS-2973: Allow SSL tests to run using gtest_repeat.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36074/#review90158 --- Ship it! Ship It! - Benjamin Hindman On July 1, 2015, 2:26 a.m.,

Re: Review Request 36112: perf: extracted out a 'version' function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36112/#review90159 --- src/linux/perf.cpp (line 454)

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/linux/cgroups.cpp, line 2014 > > > > > > I don't think we usually define a inline function like this anywhere > > else, so curious to see what others think. >

Re: Review Request 36113: perf: refactored parse to allow determining an output parsing function based on the runtime version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36113/#review90161 --- src/linux/perf.cpp (line 468)

Re: Review Request 36079: Added Subscribe call support to the master and the C++ scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36079/#review90163 --- Patch looks great! Reviews applied: [36077, 36078, 35855, 35856, 35

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/linux/cgroups.cpp, line 2060 > > > > > > Why add trailing underscore? > > Jojy Varghese wrote: > As a member variable(is accepted according to mesos codin

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/#review90164 --- src/tests/perf_tests.cpp (line 87)

Re: Review Request 34136: Add ContainerImage protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review90166 --- include/mesos/mesos.proto (line 1209)

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36061/#review90171 --- Ship it! Ship It! - Benjamin Hindman On July 1, 2015, 12:32 a.m.

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90174 --- Patch looks great! Reviews applied: [36106] All tests passed. - M

Re: Review Request 36078: Refactored Call message to include Subscribe message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36078/ --- (Updated July 1, 2015, 5:22 p.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 36112: perf: extracted out a 'version' function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36112/#review90168 --- src/linux/perf.cpp (lines 448 - 458)

Re: Review Request 36113: perf: refactored parse to allow determining an output parsing function based on the runtime version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36113/#review90167 --- src/linux/perf.cpp (lines 471 - 472)

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/#review90170 --- src/linux/perf.cpp (line 473)

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/#review90177 --- src/tests/perf_tests.cpp (lines 76 - 84)

Re: Review Request 36078: Refactored Call message to include Subscribe message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36078/#review90178 --- Ship it! Ship It! - Benjamin Hindman On July 2, 2015, 12:22 a.m.

Re: Review Request 34142: AppC provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34142/#review90173 --- src/slave/containerizer/provisioners/appc.cpp (lines 143 - 151)

Re: Review Request 36116: MESOS-2965: Add implicit conversion from Path to std::string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36116/ --- (Updated July 1, 2015, 5:44 p.m.) Review request for mesos, Artem Harutyunyan a

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/#review90180 --- src/linux/perf.cpp (line 473)

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/#review90182 --- Patch looks great! Reviews applied: [36112, 36113, 36114, 36115] A

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review90183 --- 3rdparty/libprocess/include/process/firewall.hpp (line 59)

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/linux/cgroups.cpp, line 2060 > > > > > > Why add trailing underscore? > > Jojy Varghese wrote: > As a member variable(is accepted according to mesos codin

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/tests/cgroups_tests.cpp, line 1192 > > > > > > Add using to the top of the tests > > Jojy Varghese wrote: > Since this is an alias (typedef) and scoped fo

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 1, 2015, 9:54 p.m., Marco Massenzio wrote: > > src/linux/cgroups.cpp, line 2002 > > > > > > and, in any event, the variables should have a meaningful name - should > > these be `userTime` or something? > >

Re: Review Request 36040: Change Server closing connections for every request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36040/#review90187 --- Ship it! 3rdparty/libprocess/src/http.cpp (lines 778 - 780)

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90188 --- Ship it! src/master/http.cpp (line 322)

Re: Review Request 36072: New "Unsupported" HTTP response type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36072/ --- (Updated July 2, 2015, 2:05 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 2, 2015, 2:05 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90190 --- src/master/validation.cpp (line 80)