Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/ --- (Updated 九月 14, 2015, 7:28 a.m.) Review request for mesos, Ian Downes, Jie Yu,

Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/ --- Review request for mesos and Michael Park. Bugs: MESOS-3419 https://issues.

Review Request 38348: Correct typo in http.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38348/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 31625: Fixed broken link in framework development guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31625/#review98825 --- Ship it! Ship It! - Guangya Liu On 三月 2, 2015, 3:36 p.m., Palak

Review Request 37867: Enable QUIESCE call in master and scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37867/ --- Review request for mesos. Repository: mesos Description --- Enable QUIES

Review Request 37866: Add QUIESCE call to Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37866/ --- Review request for mesos. Repository: mesos Description --- Add QUIESCE

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

> On Sept. 4, 2015, 12:49 p.m., Vinod Kone wrote: > > this review blocks a bunch of reviews? can you make the dependency linear? > > it would make my life easier to follow the chain of reviews. > > Guangya Liu wrote: > Thanks Vinod, both 37867 and 37866 are now discared but I do not know ho

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

> On Sept. 4, 2015, 7:49 p.m., Vinod Kone wrote: > > this review blocks a bunch of reviews? can you make the dependency linear? > > it would make my life easier to follow the chain of reviews. > > Guangya Liu wrote: > Thanks Vinod, both 37867 and 37866 are now discared but I do not know how

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

> On Sept. 10, 2015, 9:54 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, lines 191-192 > > > > > > The above test already performs the roundtrip of Protobuf -> JSON -> > >

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/ --- (Updated Sept. 14, 2015, 10:52 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/ --- (Updated Sept. 14, 2015, 12:11 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/ --- (Updated Sept. 14, 2015, 12:25 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Sept. 14, 2015, 12:40 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Sept. 14, 2015, 12:46 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

> On Sept. 14, 2015, 12:37 a.m., Qian Zhang wrote: > > src/master/master.cpp, lines 4131-4134 > > > > > > I think we have done this in Master::Http::maintenanceSchedule(), so > > why we do it again here? Maybe remo

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/ --- (Updated Sept. 14, 2015, 12:51 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/ --- (Updated Sept. 14, 2015, 12:54 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/ --- (Updated Sept. 14, 2015, 12:57 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37505: Fix broken health check in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ --- (Updated Sept. 14, 2015, 12:59 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

> On Aug. 31, 2015, 7:49 a.m., Jian Qiu wrote: > > src/master/master.cpp, line 4904 > > > > > > If the allocator calls inverse callback followed by an offer callback, > > will the two messages be handled in two sep

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/ --- (Updated Sept. 14, 2015, 1:03 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

> On Sept. 14, 2015, 1:53 a.m., Qian Zhang wrote: > > src/master/http.cpp, line 1606 > > > > > > s/machineInfos/machines Nice catch! Will be fixed in updated review. - Joris

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/ --- (Updated Sept. 14, 2015, 1:08 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review98840 --- Patch looks great! Reviews applied: [38287] All tests passed. - M

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/ --- (Updated Sept. 14, 2015, 1:26 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review98818 --- src/Makefile.am (line 1463)

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Sept. 14, 2015, 1:48 p.m.) Review request for mesos and Michael Park.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review98842 --- src/Makefile.am (line 1783)

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review98845 --- src/master/master.cpp (lines 4906 - 4907)

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/#review98852 --- Ship it! Looks good to me. Ship it! - Gilbert Song On Sept. 14,

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

> On Sept. 14, 2015, 3:36 a.m., Benjamin Hindman wrote: > > src/master/http.cpp, lines 1622-1624 > > > > > > Why don't we want to send lost slave messages? > > Benjamin Hindman wrote: > Sorry, I meant: why don'

Re: Review Request 38348: Correct typo in http.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38348/#review98870 --- That's not a typo; "iff" is short for "if and only if". - Joseph Wu

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98872 --- Ship it! Ship It! - Jojy Varghese On Sept. 11, 2015, 7:34 p.m.,

Re: Review Request 38279: [MESOS-3366] Allow resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/ --- (Updated Sept. 14, 2015, 10:38 a.m.) Review request for mesos, Connor Doyle and

Re: Review Request 38279: Enabled resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/ --- (Updated Sept. 14, 2015, 10:39 a.m.) Review request for mesos, Connor Doyle and

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review98875 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (line 112

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/ --- (Updated Sept. 14, 2015, 10:41 a.m.) Review request for mesos and Niklas Nielse

Re: Review Request 38343: mesos: Fixed punctuation in log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38343/#review98878 --- Ship it! Ship It! - Niklas Nielsen On Sept. 13, 2015, 10:09 p.m.

Re: Review Request 38333: Made container sandbox a shared mount to address MESOS-3349.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38333/#review98863 --- Ship it! src/slave/containerizer/isolators/filesystem/linux.cpp (l

Re: Review Request 38279: Enabled resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98884 --- src/examples/test_hook_module.cpp (line 208)

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review98880 --- include/mesos/mesos.proto (line 820)

Re: Review Request 38279: Enabled resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98886 --- src/hook/manager.cpp (line 261)

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98876 --- LGTM. Just a minor query around why do we want to parse the error re

Re: Review Request 37505: Fix broken health check in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/#review98892 --- Patch looks great! Reviews applied: [37505] All tests passed. - M

Re: Review Request 38306: Libprocess: Removed namespace pollution from ssl gtest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38306/#review98893 --- Ship it! 3rdparty/libprocess/include/process/ssl/gtest.hpp (lines

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 14, 2015, 6:11 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 266 > > > > > > Not yours , but can we just do OK().status ? never understood the reaso

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 14, 2015, 6:11 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 266 > > > > > > Not yours , but can we just do OK().status ? > > Jojy Varghese wrote: >

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98901 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp

Re: Review Request 38333: Made container sandbox a shared mount to address MESOS-3349.

> On Sept. 14, 2015, 6 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioners/appc/provisioner.cpp, lines 368-369 > > > > > > Oh... > > > > I thought `root` was being copied but I guess the compi

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

> On Sept. 11, 2015, 7:25 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 166 > > > > > > So, what's the rationale for using `${CMAKE_CXX_FLAGS}` here? It seems > > to me that we only

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

> On Sept. 11, 2015, 7:22 p.m., Alex Clemmer wrote: > > I think that `-DGTEST_USE_OWN_TR1_TUPLE` is actually unnecessary now that > > you've upgraded to GMock 1.7 (in commie > > a8970ce78f1abbee3dd4de282d54ced38d0e5fa1). Let me just double-check my > > understanding here just to make sure we'r

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98906 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 89

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

> On Sept. 11, 2015, 7:22 p.m., Alex Clemmer wrote: > > I think that `-DGTEST_USE_OWN_TR1_TUPLE` is actually unnecessary now that > > you've upgraded to GMock 1.7 (in commie > > a8970ce78f1abbee3dd4de282d54ced38d0e5fa1). Let me just double-check my > > understanding here just to make sure we'r

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review97421 --- For some reason this did not get posted when it should have. 3rdpa

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98910 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 57

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37502/ --- (Updated Sept. 14, 2015, 8:08 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 38279: Enabled resources/attributes discovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98879 --- Per Connors comment, we need a test to exercise the new code inclu

Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/ --- (Updated Sept. 14, 2015, 1:37 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 14, 2015, 6:11 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 277 > > > > > > Why are we parsing the error JSON to extract the error string from JSON

Review Request 38364: Minor refactor for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38364/ --- Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. Bugs: MESOS

Review Request 38363: Refactored container Launcher to accept namespaces dynamically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38363/ --- Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. Bugs: MESOS

Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/ --- Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.

Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/ --- Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Timothy Chen

Review Request 38365: Updated Isolator::prepare to return list of required namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38365/ --- Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. Bugs: MESOS

Review Request 38366: Added helper to model Labels message for state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38366/ --- Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. Repository:

Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38368/ --- Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen. Bugs: MESOS

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review98917 --- src/docker/executor.cpp (line 162)

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 14, 2015, 2:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 14, 2015, 2:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

> On Sept. 12, 2015, 6:59 p.m., Artem Harutyunyan wrote: > > docs/maintenance.md, lines 68-72 > > > > > > Did not we describe this already? True. The intention was to reword the documentation in the protobufs. But

Re: Review Request 38366: Added helper to model Labels message for state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38366/#review98922 --- High level comment; would it be worth change JSON::Protobuf() to sup

Re: Review Request 38364: Minor refactor for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38364/#review98921 --- Can you expand on the change (before and after) effect in the RR des

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review98923 --- +1 on Tim's comment. I think you can just generalize the text to '3r

Re: Review Request 38366: Added helper to model Labels message for state.json.

> On Sept. 14, 2015, 5:40 p.m., Niklas Nielsen wrote: > > High level comment; would it be worth change JSON::Protobuf() to support > > Labels instead? Probably not. We are trying a shortcut when modelling Labels for state.json. Thus, I wouldn't want to change JSON::Protobuf which is supposed t

Re: Review Request 38364: Minor refactor for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38364/ --- (Updated Sept. 14, 2015, 5:54 p.m.) Review request for mesos, Connor Doyle, Jie

Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38368/#review98928 --- src/examples/test_hook_module.cpp (line 197)

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review98932 --- include/mesos/mesos.proto (lines 1163 - 1164)

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review98926 --- include/mesos/mesos.proto (line 1163)

Re: Review Request 38333: Made container sandbox a shared mount to address MESOS-3349.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38333/ --- (Updated Sept. 14, 2015, 10:29 p.m.) Review request for mesos, haosdent huang,

Review Request 38374: Added logics in LinuxFilesystemIsolator to recover and cleanup orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38374/ --- Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang Ya

Re: Review Request 38363: Refactored container Launcher to accept namespaces dynamically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38363/#review98934 --- src/tests/containerizer/isolator_tests.cpp (line 202)

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review98936 --- src/slave/slave.cpp (line 2760)

Re: Review Request 38365: Updated Isolator::prepare to return list of required namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38365/#review98937 --- Ship it! include/mesos/slave/isolator.proto (line 75)

Review Request 38376: Fix 'operator=' spacing in the V1 Scheduler interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38376/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Review Request 38378: Minor cleanup in perf_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38378/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- S

Review Request 38382: Fixed the perf event isolator to continue sampling in the presence of failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38382/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3423 https://issues.apache

Review Request 38375: Fixed process::collect and process::await to do discard propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38375/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3426 https://issues.apache

Review Request 38380: Minor cleanups in the perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38380/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- T

Review Request 38377: Removed 'using namespace process' in perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38377/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- S

Review Request 38379: Handle empty set of cgroups as a no-op in perf::sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38379/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- H

Review Request 38381: Removed hard-coded reap interval from perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38381/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3423 https://issues.apache

Re: Review Request 38378: Minor cleanup in perf_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38378/#review98939 --- src/tests/containerizer/perf_tests.cpp (line 51)

Re: Review Request 38378: Minor cleanup in perf_tests.cpp.

> On Sept. 14, 2015, 11:02 p.m., Cong Wang wrote: > > src/tests/containerizer/perf_tests.cpp, line 53 > > > > > > You are changing the semantic, the original test case is to verify a > > list of events which contains

Re: Review Request 38364: Minor refactor for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38364/#review98938 --- Ship it! src/slave/containerizer/mesos/containerizer.cpp (lines 83

Re: Review Request 38378: Minor cleanup in perf_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38378/ --- (Updated Sept. 14, 2015, 11:08 p.m.) Review request for mesos and Jie Yu. Cha

Re: Review Request 38374: Added logics in LinuxFilesystemIsolator to recover and cleanup orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38374/#review98942 --- Ship it! We should probably have a test case (or some checks in exi

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review98943 --- Patch looks great! Reviews applied: [37168] All tests passed. - M

Re: Review Request 38375: Fixed process::collect and process::await to do discard propagation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38375/#review98944 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2015, 10:57 p.m., Ben Ma

Re: Review Request 38377: Removed 'using namespace process' in perf event isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38377/#review98946 --- Ship it! Ship It! - Jie Yu On Sept. 14, 2015, 10:57 p.m., Ben Ma

Re: Review Request 38379: Handle empty set of cgroups as a no-op in perf::sample.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38379/#review98945 --- Not sure how much value this patch has, because upper layer always c

  1   2   >