Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review124979 --- Patch looks great! Reviews applied: [44945, 44946, 44947, 44948,

Re: Review Request 45036: Added authentication information to agent endpoints.

> On March 21, 2016, 3:28 a.m., Adam B wrote: > > src/slave/http.cpp, lines 351-354 > > > > > > Looks like `Master::Http::FLAGS_HELP()` is incorrectly using > > AUTHENTICATION() as its DESCRIPTION parameter.. Amirit

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124982 --- Fix it, then Ship it! Looks good. Just a couple minor-but-funct

Review Request 45200: Duplicate flags with keywork 'slave' on master side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45200/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review124967 --- Thanks! I'll make the adjustments from the comments below, please

Re: Review Request 44515: Added agent flags for HTTP authentication.

> On March 23, 2016, 12:30 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 413-415 > > > > > > Who says custom authenticators can't use that flag? Make this a WARN > > instead Oh, because we don't pass Flags

Re: Review Request 45036: Added authentication information to agent endpoints.

> On March 21, 2016, 6:07 a.m., haosdent huang wrote: > > src/slave/http.cpp, line 212 > > > > > > Should we change `iff` to `if` here? https://en.wikipedia.org/w/index.php?title=Iff&redirect=no - Adam -

Re: Review Request 45168: Removed old comment from 'mesos.proto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45168/#review124987 --- Ship it! Ship It! - Adam B On March 22, 2016, 10:48 a.m., Gr

Re: Review Request 45036: Added authentication information to agent endpoints.

> On March 21, 2016, 1:07 p.m., haosdent huang wrote: > > src/slave/http.cpp, line 212 > > > > > > Should we change `iff` to `if` here? > > Adam B wrote: > https://en.wikipedia.org/w/index.php?title=Iff&redirect

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124992 --- can we ignore .md scan? the .md possible container non-ascii chara

Re: Review Request 45036: Added authentication information to agent endpoints.

> On March 21, 2016, 3:28 a.m., Adam B wrote: > > src/slave/http.cpp, lines 351-354 > > > > > > Looks like `Master::Http::FLAGS_HELP()` is incorrectly using > > AUTHENTICATION() as its DESCRIPTION parameter.. Amirit

Review Request 45202: Add test for rescinding offer trriggered by updating weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/ --- Review request for mesos and Adam B. Bugs: MESOS-4881 https://issues.apache

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

> On March 21, 2016, 8 a.m., Adam B wrote: > > Could you write a test where one framework hoards its share of the > > resources (doesn't accept/decline them), then weights are updated to > > increase another framework's share, and the other framework actually gets > > offers to cover its share

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 23, 2016, 8:51 a.m.) Review request for mesos, Adam B, Alexander

Review Request 45203: Add authentication test for /weights GET request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45203/ --- Review request for mesos and Adam B. Bugs: MESOS-4316 https://issues.apache

Re: Review Request 44512: Support to get weights info by /weights.

> On March 21, 2016, 9:03 a.m., Adam B wrote: > > Good start, but you're missing a few things. Are these coming in subsequent > > patches? > > - Authentication for GET requests > > - Tests for GETs > > - Documentation updates > > Yongqiao Wang wrote: > I will add a separated patch for GET r

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124996 --- Fix it, then Ship it! src/slave/slave.cpp (line 358)

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review124997 --- Patch looks great! Reviews applied: [44450] Passed command: expo

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 23, 2016, 9:38 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 45204: Fixed master flags endpoint help and regenerated endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45204/ --- (Updated March 23, 2016, 9:49 a.m.) Review request for mesos, Adam B and Till T

Re: Review Request 45036: Added authentication information to agent endpoints.

> On March 21, 2016, 10:28 a.m., Adam B wrote: > > src/slave/http.cpp, lines 351-354 > > > > > > Looks like `Master::Http::FLAGS_HELP()` is incorrectly using > > AUTHENTICATION() as its DESCRIPTION parameter.. Amiri

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 23, 2016, 11:23 a.m.) Review request for mesos, Adam B, Alexande

Review Request 45209: Made sure all Python modules are installed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45209/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-5010 https://issue

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 23, 2016, 11:39 a.m.) Review request for mesos, Adam B, Alexande

Review Request 45211: Adjusted include order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45211/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Descript

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124782 --- Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/inclu

Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44139/#review125013 --- Ship it! Ship It! - Joris Van Remoortere On March 21, 2016,

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/#review125009 --- Ship it! - Joris Van Remoortere On March 22, 2016, 5:20 p.m.,

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review125011 --- Ship it! - Joris Van Remoortere On March 22, 2016, 5:21 p.m.,

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/#review125012 --- 3rdparty/libprocess/src/io.cpp (line 76)

Review Request 45214: Updated protobuf to support external storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5012 https://issues.apache

Re: Review Request 45214: Updated protobuf to support external storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/ --- (Updated 三月 23, 2016, 1:30 p.m.) Review request for mesos and Jie Yu. Bugs: M

Re: Review Request 43569: Updated log message if container not found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/ --- (Updated 三月 23, 2016, 1:50 p.m.) Review request for mesos, Jie Yu and Timothy C

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 11:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 471 > > > > > > Again why the CHECK ? The result might not have an IPv4 or an IPv6 > >

Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45213/ --- Review request for mesos and Vinod Kone. Bugs: mesos-3780 https://issues.ap

Re: Review Request 45186: Implemented user specified system config files support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review125026 --- Patch looks great! Reviews applied: [45183, 45184, 45185, 45186]

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44706/ --- (Updated March 23, 2016, 10:22 p.m.) Review request for mesos, Avinash sridhara

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated March 23, 2016, 2:46 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review125032 --- Skipped the .md scan based on feedback from haosdent and Deshi. -

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 18, 2016, 10:44 p.m., Jie Yu wrote: > > include/mesos/v1/mesos.proto, lines 1543-1544 > > > > > > We're going to introduce a ContainerInfo.NetworkInfo.name to allow > > frameworks to specify the network

Re: Review Request 45166: Fixed flaky `MasterTest.SlavesEndpointTwoSlaves`.

> On March 23, 2016, 6:52 a.m., Adam B wrote: > > While I'm not afraid of your changes, I can't understand why this broke in > > the first place. Although "`FUTURE_PROTOBUF` > > just guarantees that the method has dispatched but does not ensure that it > > has completed", at the point in master

Re: Review Request 45166: Fixed flaky `MasterTest.SlavesEndpointTwoSlaves`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45166/ --- (Updated March 23, 2016, 3:14 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 45200: Duplicate flags with keywork 'slave' on master side.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45200/#review125042 --- Patch looks great! Reviews applied: [45200] Passed command: expo

Re: Review Request 45117: Cleaned up header includes in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45117/#review125045 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 6:42 p.m., Nei

Re: Review Request 45119: Added TODO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45119/#review125047 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 6:42 p.m., Nei

Re: Review Request 45118: Fixed various style issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45118/#review125046 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 6:42 p.m., Nei

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

> On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, lines > > 28-36 > > > > > > Let's namespace these with `socket` since both functio

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

> On March 23, 2016, 12:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, line > > 35 > > > > > > Should `EINPROGRESS` be in here? > > would a retry

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 23, 2016, 3:59 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/ --- (Updated March 23, 2016, 4:01 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

> On March 23, 2016, 12:42 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/io.cpp, lines 86-87 > > > > > > This behavior is not quite consistent: > > see my comment in https://reviews.apache.org/r/44

Review Request 45217: Implemented docker volume driver isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5013 https://issues.apache

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 23, 2016, 4:09 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

> On March 22, 2016, 5:39 a.m., Jie Yu wrote: > > Instead of handling /containers endpoint in Slave, I would suggest we > > dispatch the request to ResourceMonitor. I will rename ResourceMonitor to > > ContainerMonitor, and we will be deprecating the /monitor/statistics > > endpoints in the fu

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 23, 2016, 4:56 p.m.) Review request for mesos, Ben Mahler and Gi

Re: Review Request 45209: Made sure all Python modules are installed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45209/#review125058 --- Patch looks great! Reviews applied: [45209] Passed command: expo

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review125062 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 1:42 p.m., Jor

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review125066 --- Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/inclu

Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44252/#review125067 --- Ship it! Ship It! - Vinod Kone On March 22, 2016, 2:59 a.m.,

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124248 --- My thoughts about the discussions around: 1) Using `path` vs. `d

Re: Review Request 44091: Windows:[1/3] Implemented `os::pagesize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44091/ --- (Updated March 23, 2016, 5:39 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44091: Windows:[1/3] Implemented `os::pagesize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44091/ --- (Updated March 23, 2016, 5:42 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 23, 2016, 5:39 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp, lines 17-19 > > > > > > So this is bug of the xfs headers? > > > > I guess it's still not cl

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

> On March 22, 2016, 2:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > b/3rdparty/libproces

Re: Review Request 45151: Updated FrameworkInfo::Capability::Type enum for upgradability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45151/#review125076 --- Ship it! Ship It! - Vinod Kone On March 22, 2016, 7:32 a.m.,

Re: Review Request 45151: Updated FrameworkInfo::Capability::Type enum for upgradability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45151/ --- (Updated March 23, 2016, 5:58 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 45211: Adjusted include order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45211/#review125080 --- Patch looks great! Reviews applied: [45211] Passed command: expo

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

> On March 22, 2016, 2:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > b/3rdparty/libproces

Re: Review Request 44092: Windows:[2/3] Transitioned `os::recv` to use `os::pagesize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44092/ --- (Updated March 23, 2016, 6:23 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/#review125090 --- Fix it, then Ship it! Thanks for moving the test! src/tests/m

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

> On March 20, 2016, 2:33 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > This comment seems incorrect: > > > > (1) The relevant parameter

Re: Review Request 44994: Added a test for executor shutdown grace period.

> On March 18, 2016, 11:24 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 3264 > > > > > > You don't need a settle here, AWAIT_READY will settle if the clock is > > paused. > > Alexander Rukletsov wro

Re: Review Request 45093: Added mesos containerizer test DestroyWhileProvisioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45093/#review125094 --- Fix it, then Ship it! src/tests/containerizer/mesos_containeri

Re: Review Request 43569: Updated log message if container not found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/#review125098 --- Patch looks great! Reviews applied: [43015, 43569] Passed comman

Review Request 45240: Fixed typo in comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45240/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Review Request 45241: Fixed invalid HTML in monitoring documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45241/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Review Request 45242: Fixed invalid HTML in upgrades documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45242/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

> On March 20, 2016, 2:33 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > This comment seems incorrect: > > > > (1) The relevant parameter

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review125120 --- Ship it! Ship It! - Cong Wang On March 18, 2016, 12:16 a.m.,

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review125121 --- Not related to your patch, but it also makes sense to add FTS_NOST

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 23, 2016, 8:47 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44760: Windows: Fixed non-blocking connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 23, 2016, 8:49 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44854: Added validation for executor's shutdown grace period.

> On March 23, 2016, 6:49 p.m., Ben Mahler wrote: > > src/tests/master_validation_tests.cpp, lines 1175-1176 > > > > > > Why the explicit detector? After recent test harness refactoring, there is no `StartSlave()`

Re: Review Request 45240: Fixed typo in comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45240/#review125125 --- Ship it! Ship It! - Ben Mahler On March 23, 2016, 7:50 p.m.,

Re: Review Request 45241: Fixed invalid HTML in monitoring documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45241/#review125126 --- Ship it! Ship It! - Ben Mahler On March 23, 2016, 7:50 p.m.,

Re: Review Request 45242: Fixed invalid HTML in upgrades documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45242/#review125127 --- Ship it! Ship It! - Ben Mahler On March 23, 2016, 7:52 p.m.,

Re: Review Request 44994: Added a test for executor shutdown grace period.

> On March 18, 2016, 11:24 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 3264 > > > > > > You don't need a settle here, AWAIT_READY will settle if the clock is > > paused. > > Alexander Rukletsov wro

Re: Review Request 44709: Allowed unknown flags in command and docker executors.

> On March 18, 2016, 11:32 p.m., Jie Yu wrote: > > src/docker/executor.cpp, lines 588-590 > > > > > > This is more like a question: are you talking about the case where the > > agent binary is updated, while the exe

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 6:19 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 228 > > > > > > Can there be a use case where you want multiple NICs to be attached to > > t

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review125131 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Review Request 45243: WIP: Added a metric for querying the number offer filters for a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45243/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 45092: Fixed containerizer potential race destroy while provisioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45092/ --- (Updated March 23, 2016, 2:17 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 45093: Added mesos containerizer test DestroyWhileProvisioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45093/ --- (Updated March 23, 2016, 2:23 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 45186: Implemented user specified system config files support.

> On March 22, 2016, 11:51 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 231-233 > > > > > > Put this check to the block of > > if (flags.system_config_files.isSo

Re: Review Request 45186: Implemented user specified system config files support.

> On March 22, 2016, 11:46 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 204-205 > > > > > > what about: > > > > foreach ( > > const string& file, > >

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 23, 2016, 9:45 p.m.) Review request for mesos, Ben Mahler and Gi

Re: Review Request 45183: Implemented mounting host system config files to container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45183/ --- (Updated March 23, 2016, 2:49 p.m.) Review request for mesos, Guangya Liu, Arte

Re: Review Request 45184: Added test for mounting host system config files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45184/ --- (Updated March 23, 2016, 2:50 p.m.) Review request for mesos, Guangya Liu, Arte

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 23, 2016, 10:39 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp, line 119 > > > > > > I know I asked this previoiusly but what's the difference between this > > an

Review Request 45248: Added authentication to the '/files' endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45248/ --- Review request for mesos, Adam B, Ben Mahler, and Joerg Schad. Bugs: MESOS-4956

  1   2   >