Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/ --- Review request for mesos and Kapil Arya. Bugs: MESOS-5366 https://issues.ap

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-05-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated May 12, 2016, 4:11 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

2016-05-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46435/ --- (Updated May 12, 2016, 4:12 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

2016-05-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46436/ --- (Updated May 12, 2016, 4:13 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

2016-05-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/ --- (Updated May 12, 2016, 4:14 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/#review132851 --- docs/modules.md (line 227)

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/#review132852 --- docs/modules.md (line 225)

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/ --- (Updated May 12, 2016, 9:01 a.m.) Review request for mesos and Kapil Arya. Ch

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-12 Thread Alexander Rojas
> On May 10, 2016, 8:36 p.m., Greg Mann wrote: > > docs/authorization.md, line 66 > > > > > > I find it a bit confusing that we explain the `permissive` field first > > here, when the other fields are really the focu

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/ --- (Updated May 12, 2016, 11:22 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-05-12 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/ --- (Updated May 12, 2016, 11:25 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/#review132858 --- docs/modules.md (line 227)

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/#review132859 --- Bad patch! Reviews applied: [46670, 46815, 46818, 46863, 46669, 4

Re: Review Request 46242: Removed a check in Reserve operation validation.

2016-05-12 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46242/#review132861 --- Fix it, then Ship it! src/tests/reservation_endpoints_tests.cp

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/ --- (Updated May 12, 2016, 9:56 a.m.) Review request for mesos and Kapil Arya. Bu

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Jay Guo
> On May 12, 2016, 9:36 a.m., Abhishek Dasgupta wrote: > > Good catch! Thanks - Jay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/#review132858 ---

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/#review132867 --- docs/modules.md (line 235)

Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47281/#review132868 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Review Request 47303: Slave/Agent terminology replacement in documentations.

2016-05-12 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47303/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3783 https://issues.ap

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/ --- (Updated May 12, 2016, 11:19 a.m.) Review request for mesos and Kapil Arya. B

Re: Review Request 47303: Slave/Agent terminology replacement in documentations.

2016-05-12 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47303/ --- (Updated May 12, 2016, 11:29 a.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/#review132872 --- Ship it! Ship It! - Abhishek Dasgupta On May 12, 2016, 11:19

Re: Review Request 47200: Modified docker spec test for docker label support.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47200/#review132874 --- Patch looks great! Reviews applied: [47198, 47199, 47200] Passed

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/#review132879 --- include/mesos/docker/v1.proto (lines 56 - 57)

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132881 --- Patch looks great! Reviews applied: [47095] Passed command: expo

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/#review132880 --- src/docker/spec.cpp (line 171)

Review Request 46888: Documented that `slaveLost` is not reliably delivered.

2016-05-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46888/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

2016-05-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46866/#review132893 --- Ship it! Ship It! - Alexander Rojas On May 10, 2016, 10:30 p

Re: Review Request 46888: Documented that `slaveLost` and `executorLost` are unreliable.

2016-05-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46888/ --- (Updated May 12, 2016, 1:36 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/#review132894 --- Patch looks great! Reviews applied: [46958] Passed command: expo

Review Request 47314: Add authentication documentation to authenticated endpoints.

2016-05-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47314/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti

Review Request 47313: Add authentication documentation to authenticated libprocess endpoints.

2016-05-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47313/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

2016-05-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46867/#review132904 --- Ship it! Ship It! - Alexander Rojas On May 10, 2016, 10:30 p

Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/#review132906 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.

2016-05-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46883/#review132913 --- src/common/http.cpp (line 592)

Re: Review Request 47115: Fixed some issues in newbie-guide.md.

2016-05-12 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47115/#review132914 --- Ship it! Ship It! - Till Toenshoff On May 9, 2016, 9:56 a.m.

Re: Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.

2016-05-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46869/#review132919 --- Ship it! Ship It! - Alexander Rojas On May 10, 2016, 10:36 p

Re: Review Request 46888: Documented that `slaveLost` and `executorLost` are unreliable.

2016-05-12 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46888/#review132923 --- Ship it! Ship It! - Till Toenshoff On May 12, 2016, 1:36 p.m

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-05-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review132896 --- src/tests/master_authorization_tests.cpp (line 1030)

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/#review132927 --- Patch looks great! Reviews applied: [46096, 46097, 46435, 46436,

Re: Review Request 47260: Added 'ReviveAndSuppress' test for the allocator.

2016-05-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47260/ --- (Updated May 12, 2016, 4:01 p.m.) Review request for mesos and Dario Rexin. C

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

2016-05-12 Thread Jan Schlicht
> On May 12, 2016, 5:30 p.m., Alexander Rukletsov wrote: > > src/tests/master_authorization_tests.cpp, line 1030 > > > > > > Now this is not symmetrical to `SlaveAuthorizationTest`. Yes, `MasterAuthorizationTest`

Re: Review Request 47217: Deprecate 'slave' in CLI.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47217/#review132937 --- Ship it! Ship It! - Vinod Kone On May 11, 2016, 2:52 a.m., J

Re: Review Request 47222: Add authorization to /quota endpoint.

2016-05-12 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47222/ --- (Updated May 12, 2016, 4:21 p.m.) Review request for mesos, Adam B and Alexande

Re: Review Request 47313: Add authentication documentation to authenticated libprocess endpoints.

2016-05-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47313/#review132941 --- 3rdparty/libprocess/src/logging.cpp (line 97)

Re: Review Request 47303: Slave/Agent terminology replacement in documentations.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47303/#review132944 --- docs/architecture.md (line 12)

Re: Review Request 46621: Added alias support for flags.

2016-05-12 Thread Michael Park
> On May 5, 2016, 10:12 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 828-830 > > > > > > ```cpp > >auto iter = aliases.count(flag_name) ? > > fla

Re: Review Request 46622: Added tests for flag aliases.

2016-05-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46622/#review132947 --- Ship it! Ship It! - Michael Park On May 12, 2016, 1:36 a.m.,

Re: Review Request 46623: Updated libprocess to work with flag alias.

2016-05-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46623/#review132948 --- Ship it! Ship It! - Michael Park On April 30, 2016, 3:43 a.m

Re: Review Request 46624: Added support to mesos to work with flag alias.

2016-05-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46624/#review132949 --- Ship it! Ship It! - Michael Park On April 30, 2016, 3:43 a.m

Re: Review Request 47219: Used `collect` for waiting on establishing connection.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47219/#review132954 --- Ship it! Ship It! - Vinod Kone On May 11, 2016, 5 a.m., Anan

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review132958 --- Ship it! Ship It! - Vinod Kone On May 11, 2016, 3:47 a.m., J

Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

2016-05-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47259/ --- Review request for mesos and Dario Rexin. Bugs: MESOS-5279 https://issues.a

Re: Review Request 47209: Establish TCP connection after backing off.

2016-05-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47209/#review132956 --- src/slave/slave.cpp (line 966)

Re: Review Request 47209: Establish TCP connection after backing off.

2016-05-12 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47209/ --- (Updated May 12, 2016, 6:18 p.m.) Review request for mesos, Ben Mahler, Ian Dow

Re: Review Request 47168: Windows: Implemented `kill`.

2016-05-12 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/#review132957 --- Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/inclu

Re: Review Request 47169: Windows: Impemented `killtree` using NT job objects.

2016-05-12 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47169/#review132960 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/killt

Re: Review Request 46392: Windows: Added stub implementations of `fcntl.hpp` functions.

2016-05-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/ --- (Updated May 12, 2016, 6:54 p.m.) Review request for mesos. Summary (updated)

Re: Review Request 46392: Windows: Added stub implementations of `fcntl.hpp` functions.

2016-05-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/ --- (Updated May 12, 2016, 6:59 p.m.) Review request for mesos. Bugs: MESOS-5371

Re: Review Request 47292: Update docs to reflect contender and detector modules.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47292/#review132970 --- Patch looks great! Reviews applied: [47292] Passed command: expo

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46863/ --- (Updated May 12, 2016, 8:46 p.m.) Review request for mesos and Michael Park.

Re: Review Request 46669: Added deprecation support to Flag name.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/ --- (Updated May 12, 2016, 8:45 p.m.) Review request for mesos, Ben Mahler, Greg Ma

Review Request 47324: Update leveldb.

2016-05-12 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/ --- Review request for mesos, Bing Li, Ben Mahler, Zhiwei Chen, and haosdent huang.

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46818/ --- (Updated May 12, 2016, 8:46 p.m.) Review request for mesos, Ben Mahler, Greg Ma

Re: Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/#review132974 --- Could you please update `Slave::Http::CONTAINERS_HELP()` as well?

Re: Review Request 46669: Added deprecation support to Flag name.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/ --- (Updated May 12, 2016, 8:53 p.m.) Review request for mesos, Ben Mahler, Greg Ma

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46863/ --- (Updated May 12, 2016, 8:54 p.m.) Review request for mesos and Michael Park.

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46815/ --- (Updated May 12, 2016, 8:54 p.m.) Review request for mesos, Ben Mahler, Greg Ma

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46818/ --- (Updated May 12, 2016, 8:54 p.m.) Review request for mesos, Ben Mahler, Greg Ma

Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

2016-05-12 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/ --- Review request for mesos. Repository: mesos Description --- Add runtime

Re: Review Request 47314: Add authentication documentation to authenticated endpoints.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47314/#review132990 --- Patch looks great! Reviews applied: [47313, 47314] Passed comman

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

2016-05-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47266/#review132778 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 3

Re: Review Request 44837: Added force_pull_image to Image protobuf.

2016-05-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44837/#review132991 --- Ship it! Ship It! - Gilbert Song On April 18, 2016, 1:31 a.m

Re: Review Request 47052: Windows: [1/2] Added `os::random`.

2016-05-12 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47052/ --- (Updated May 12, 2016, 10:18 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 47053: Windows: [2/2] Used `os::random`.

2016-05-12 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47053/ --- (Updated May 12, 2016, 10:19 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 47221: Windows: Used `os::random` in libprocess.

2016-05-12 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47221/ --- (Updated May 12, 2016, 10:19 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 44837: Added force_pull_image to Image protobuf.

2016-05-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44837/#review132992 --- Fix it, then Ship it! include/mesos/mesos.proto (line 1575)

Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.

2016-05-12 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47054/ --- (Updated May 12, 2016, 10:22 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

2016-05-12 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated May 12, 2016, 10:31 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

2016-05-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/#review132994 --- Fix it, then Ship it! src/slave/containerizer/mesos/provisione

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/ --- (Updated May 12, 2016, 10:38 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 46669: Added deprecation support to Flag name.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/ --- (Updated May 12, 2016, 10:42 p.m.) Review request for mesos, Ben Mahler, Greg M

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46863/ --- (Updated May 12, 2016, 10:42 p.m.) Review request for mesos and Michael Park.

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46815/ --- (Updated May 12, 2016, 10:43 p.m.) Review request for mesos, Ben Mahler, Greg M

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46818/ --- (Updated May 12, 2016, 10:42 p.m.) Review request for mesos, Ben Mahler, Greg M

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

2016-05-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/#review132995 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 69

Re: Review Request 46669: Added deprecation support to Flag name.

2016-05-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/#review132997 --- Fix it, then Ship it! 3rdparty/stout/include/stout/flags/flag.

Re: Review Request 47168: Windows: Implemented `kill`.

2016-05-12 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/ --- (Updated May 12, 2016, 11:16 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review133000 --- Patch looks great! Reviews applied: [46923] Passed command: expo

Re: Review Request 46863: Refactored FlagsBase::load() to move duplicate checking logic.

2016-05-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46863/#review132999 --- Fix it, then Ship it! 3rdparty/stout/include/stout/flags/flags

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-05-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46818/#review133002 --- Ship it! 3rdparty/libprocess/src/tests/subprocess_tests.cpp (l

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

2016-05-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/#review133004 --- Srinivas, thanks for taking this on. It looks like you combined yo

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-05-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46815/#review133003 --- Fix it, then Ship it! src/cli/execute.cpp (line 644)

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

2016-05-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/#review133005 --- Fix it, then Ship it! src/master/flags.cpp (lines 18 - 23)

Re: Review Request 46242: Removed a check in Reserve operation validation.

2016-05-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46242/ --- (Updated May 13, 2016, 12:25 a.m.) Review request for mesos, Adam B and Joris V

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 13, 2016, 12:45 a.m.) Review request for mesos, Jie Yu and Kevin K

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

2016-05-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46798/ --- (Updated May 13, 2016, 12:50 a.m.) Review request for mesos and Jie Yu. Repos

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-05-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/ --- (Updated May 13, 2016, 12:50 a.m.) Review request for mesos and Jie Yu. Repos

Re: Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47259/#review133010 --- Patch looks great! Reviews applied: [47258, 47259] Passed comman

Review Request 47329: Added agent flag 'docker_volume_checkpoint_dir'.

2016-05-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47329/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, and Jie Yu. Repositor

  1   2   >