Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Dec. 4, 2017, 10:56 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 63498: Allowed relative path in `Resource.disk.source.{path, mount}.root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63498/#review192737 --- Fix it, then Ship it! include/mesos/mesos.proto Line 1367

Re: Review Request 63634: Changed dispatch to use callable once functors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63634/#review192745 --- Ship it! Ship It! - Michael Park On Nov. 7, 2017, 8:51

Re: Review Request 63914: Changed agent reregistration to work with message directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/#review192721 --- Fix it, then Ship it! src/master/master.cpp Line 6433

Re: Review Request 64032: Promoted log level to warning for disconnected events in exec.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64032/ --- (Updated Dec. 4, 2017, 6:03 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'.

> On Dec. 1, 2017, 11:51 p.m., Qian Zhang wrote: > > src/messages/flags.proto > > Lines 112-114 (patched) > > > > > > Can we add comments to describe each of the fields? will do. - Gilbert

Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'.

> On Dec. 2, 2017, 12:49 a.m., Qian Zhang wrote: > > src/messages/flags.proto > > Lines 113 (patched) > > > > > > DurationInfo seems a too small time unit (nanosecond) which may not > > convenient for operator to

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64104/ --- (Updated Dec. 4, 2017, 6:54 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 64093: Added operators for offer operation update protobuf classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64093/#review192755 --- Fix it, then Ship it! src/messages/messages.cpp Line 63

Re: Review Request 63914: Changed agent reregistration to work with message directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/#review192747 --- Ship it! Exciting to see this stuff come together! Looks good,

Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63341/#review192766 --- Ship it! Ship It! - Joseph Wu On Dec. 4, 2017, 1:19 p.m.,

Re: Review Request 64274: Added `lambda::partial` to .

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64274/#review192718 --- Fix it, then Ship it! Ship It!

Re: Review Request 64297: Updated modules documentation with some more details.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64297/#review192760 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64103: Changed dependency of curl to libcurl for stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64103/ --- (Updated Dec. 4, 2017, 6:54 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 64102: Renamed curl target to libcurl, and staging of curl.exe on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64102/ --- (Updated Dec. 4, 2017, 6:54 p.m.) Review request for mesos, Akash Gupta,

Review Request 64312: Added reservation refinement documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64312/ --- Review request for mesos, Benjamin Mahler and Joerg Schad. Bugs: MESOS-7663

Re: Review Request 64272: Improved Windows isolators with `struct Info` abstraction.

> On Dec. 3, 2017, 1:19 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos libprocess-tests failed. > > > > Reviews applied: `['64272']` > > > > Failed command: > > `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe` > > > > All the build artifacts available at:

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/ --- (Updated Dec. 4, 2017, 6:02 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64267: Supported basic auto image gc in the agent.

> On Dec. 2, 2017, 1:02 a.m., Qian Zhang wrote: > > src/slave/slave.cpp > > Lines 621 (patched) > > > > > > What if `image_providers` is specified by the operator but Mesos > > containerizer is not enabled? Do we

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/#review192746 --- Fix it, then Ship it! src/master/master.hpp Line 128

Review Request 64313: Removed the 'id' field from 'Offer::Operation'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64313/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64104/#review192730 --- src/tests/health_check_tests.cpp Lines 852-853 (original),

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192733 --- Mainly looked at the reason for the test changes. Will take

Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

> On Dec. 4, 2017, 1:26 p.m., Joseph Wu wrote: > > You should mention in the commit description the slight modifications you > > made in the code movement: All code source paths were updated to the new > > path (i.e. `java/src/org/apache/mesos/Executor.java` -> > >

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 1, 2017, 4:41 p.m., Megha Sharma wrote: > > src/tests/upgrade_tests.cpp > > Line 138 (original), 138 (patched) > > > > > > Sorry my bad looks like the fix for this test is still needed. I am not > > clear

Re: Review Request 63389: Added a mock resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63389/#review192761 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 63342: Fixed CMake binary dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63342/ --- (Updated Dec. 4, 2017, 1:19 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63341/ --- (Updated Dec. 4, 2017, 1:19 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63340/ --- (Updated Dec. 4, 2017, 1:19 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63340/#review192764 --- Ship it! You should mention in the commit description the

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/#review192763 --- Ship it! Very happy to see this! Looks good, modulo mpark's

Re: Review Request 64267: Supported basic auto image gc in the agent.

> On Dec. 3, 2017, 2:19 p.m., Zhitao Li wrote: > > src/slave/slave.cpp > > Lines 6171-6173 (patched) > > > > > > I think adding an early return is more readable can we return? for both cases (no matter trigger gc

Re: Review Request 64272: Improved Windows isolators with `struct Info` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64272/#review192753 --- Ship it! Ship It! - Jie Yu On Dec. 1, 2017, 11:37 p.m.,

Re: Review Request 63492: Synchronized agent resource versions via 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63492/#review192759 --- src/master/master.hpp Lines 270 (patched)

Re: Review Request 64307: Rename reconfiguration_compatibility to reconfiguration_policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64307/#review192762 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 64238: Updated the allocator to track allocations via a single code path.

> On Dec. 4, 2017, 3:20 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 676 (patched) > > > > > > We will only call `addResourceProvider` after `slaveId` has been added > >

Re: Review Request 64312: Added reservation refinement documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64312/ --- (Updated Dec. 4, 2017, 1:58 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192773 --- src/master/allocator/mesos/hierarchical.cpp Lines 612 (patched)

Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64143/ --- (Updated Dec. 4, 2017, 10:24 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 64146: Added offer operation update acknowledgement to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64146/ --- (Updated Dec. 4, 2017, 10:24 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 64010: Added `SlaveInfo` parameter to Allocator::updateSlave().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review192767 --- Fix it, then Ship it! include/mesos/allocator/allocator.hpp

Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

> On Dec. 4, 2017, 1:36 p.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 376 (patched) > > > > > > I cannot see where `BUILD_FLAGS_RAW` is actually set. Is the intention > > of the user

Re: Review Request 64312: Added reservation refinement documentation.

> On Dec. 4, 2017, 2:08 p.m., Benjamin Mahler wrote: > > docs/upgrades.md > > Lines 108 (patched) > > > > > > Hm.. I'm not sure we should mention this here, it's a bit confusing to > > metion an "internal Mesos c++

Re: Review Request 64010: Added `SlaveInfo` parameter to Allocator::updateSlave().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/ --- (Updated Dec. 4, 2017, 11:30 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192794 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64248: Added `cpp17::invoke` in .

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64248/#review192798 --- Fix it, then Ship it! 3rdparty/stout/include/stout/cpp17.hpp

Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

> On Dec. 4, 2017, 1:36 p.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 376 (patched) > > > > > > I cannot see where `BUILD_FLAGS_RAW` is actually set. Is the intention > > of the user

Re: Review Request 64238: Updated the allocator to track allocations via a single code path.

> On Dec. 4, 2017, 4:20 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 676 (patched) > > > > > > We will only call `addResourceProvider` after `slaveId` has been added > >

Re: Review Request 64142: Updated master ACCEPT handler to disallow offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64142/ --- (Updated Dec. 4, 2017, 10:08 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64144/ --- (Updated Dec. 4, 2017, 10:22 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 4, 2017, 11:43 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/#review192789 --- src/master/allocator/mesos/hierarchical.cpp Line 1492

Re: Review Request 64312: Added reservation refinement documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64312/#review192779 --- Fix it, then Ship it! docs/reservation.md Line 83 (original),

Re: Review Request 64303: Tracked resource reservations in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64303/ --- (Updated Dec. 4, 2017, 3:18 p.m.) Review request for mesos, Alexander

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/ --- (Updated Dec. 4, 2017, 3:18 p.m.) Review request for mesos, Alexander

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/ --- (Updated Dec. 4, 2017, 1:48 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

> On Nov. 30, 2017, 10:51 p.m., Jie Yu wrote: > > src/common/protobuf_utils.hpp > > Lines 156 (patched) > > > > > > We typically does not have helper to create internal message (between > > agent/master). > >

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

> On Dec. 4, 2017, 10:05 p.m., Vinod Kone wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 6338 (patched) > > > > > > I wonder what caused the allocation to happen given you didn't set > > `updated`

Re: Review Request 64238: Updated the allocator to track allocations via a single code path.

> On Dec. 4, 2017, 3:20 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 676 (patched) > > > > > > We will only call `addResourceProvider` after `slaveId` has been added > >

Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/#review192788 --- Fix it, then Ship it! src/tests/master_tests.cpp Line 2738

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64104/#review192799 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64146: Added offer operation update acknowledgement to the agent.

> On Nov. 30, 2017, 11:33 p.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 3851 (patched) > > > > > > Currently, for agent default resources, we call `removeOfferOperation` > > right after the operation is

Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'.

> On Dec. 2, 2017, 8:49 a.m., Qian Zhang wrote: > > src/messages/flags.proto > > Lines 113 (patched) > > > > > > DurationInfo seems a too small time unit (nanosecond) which may not > > convenient for operator to

Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63340/ --- (Updated Dec. 4, 2017, 4:13 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63498: Allowed relative path in `Resource.disk.source.{path, mount}.root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63498/ --- (Updated Dec. 5, 2017, 12:45 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63342: Fixed CMake binary dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63342/#review192774 --- Ship it! Ship It! - Joseph Wu On Dec. 4, 2017, 1:19 p.m.,

Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63341/#review192768 --- cmake/CompilationConfigure.cmake Lines 376 (patched)

Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64096/ --- (Updated Dec. 4, 2017, 3:08 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64101: Skip registry update when nothing changed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64101/#review192792 --- Fix it, then Ship it! src/master/master.cpp Lines 6586

Re: Review Request 64158: Used helper functions instead of switches for resource extraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64158/#review192801 --- src/master/master.hpp Lines 2821 (patched)

Re: Review Request 63498: Allowed relative path in `Resource.disk.source.{path, mount}.root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63498/#review192810 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2017, 12:45 a.m.,

Re: Review Request 63022: Imported and reconcile resources from CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/#review192806 --- src/resource_provider/storage/provider.cpp Lines 439 (patched)

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 2, 2017, 12:41 a.m., Megha Sharma wrote: > > src/tests/upgrade_tests.cpp > > Line 138 (original), 138 (patched) > > > > > > Sorry my bad looks like the fix for this test is still needed. I am not > >

Review Request 64322: Fixed resources tracking under roles when removing offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64322/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.

Re: Review Request 64321: Fixed an allocator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64321/#review192809 --- Ship it! Ship It! - Benjamin Mahler On Dec. 5, 2017, 2:27

Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review192804 --- src/exec/exec.cpp Lines 350-359 (patched)

Re: Review Request 63390: Create/destroy volume test for storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63390/ --- (Updated Dec. 5, 2017, 6 a.m.) Review request for mesos, Jie Yu, Joseph Wu,

Re: Review Request 63387: Added publish/unpublish in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63387/ --- (Updated Dec. 5, 2017, 5:59 a.m.) Review request for mesos, James DeFelice,

Review Request 64319: Clarified a comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64319/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/#review192815 --- FAIL: Failed to apply the dependent review: 63630. Failed

Re: Review Request 64319: Clarified a comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64319/#review192802 --- Ship it! Ship It! - Benjamin Mahler On Dec. 5, 2017, 1:35

Re: Review Request 64319: Clarified a comment.

> On Dec. 5, 2017, 1:49 a.m., Benjamin Mahler wrote: > > Ship It! I added a little to the description. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64319/#review192802

Re: Review Request 63023: Added a test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63023/#review192744 --- Fix it, then Ship it! src/csi/utils.hpp Lines 40 (patched)

Re: Review Request 63022: Imported and reconcile resources from CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/ --- (Updated Dec. 5, 2017, 2:18 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 64320: Fixed the code to track resources under roles for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64320/#review192805 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2017, 1:46 a.m.,

Re: Review Request 63387: Added publish/unpublish in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63387/ --- (Updated Dec. 5, 2017, 2:19 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 63388: Handling offer operations in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63388/ --- (Updated Dec. 5, 2017, 2:19 a.m.) Review request for mesos, James DeFelice,

Review Request 64321: Fixed an allocator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64321/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Re: Review Request 63022: Imported and reconcile resources from CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/ --- (Updated Dec. 5, 2017, 5:57 a.m.) Review request for mesos, James DeFelice,

Review Request 64320: Fixed the code to track resources under roles for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64320/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 4, 2017, 6:43 p.m., Jiang Yan Xu wrote: > > src/tests/master_allocator_tests.cpp > > Lines 1452-1454 (original), 1452-1459 (patched) > > > > > > So these tests had to be changed becauase the master is not

Re: Review Request 64146: Added offer operation update acknowledgement to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64146/ --- (Updated Dec. 5, 2017, 7:07 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64143/ --- (Updated Dec. 5, 2017, 7:33 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 63804: Added plumbing for master to reconcile offer operations with agent.

> On Nov. 30, 2017, 7:49 p.m., Jie Yu wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 39 (patched) > > > > > > For the sake of consistency. I think we should either rename this to > >

Re: Review Request 63804: Added plumbing for master to reconcile offer operations with agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63804/ --- (Updated Dec. 5, 2017, 7:39 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64144/ --- (Updated Dec. 5, 2017, 7:06 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64145: Added status update acknowledgement to resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64145/ --- (Updated Dec. 5, 2017, 7:37 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 63386: Added utility functions for resource provider API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63386/#review192715 --- Ship it! Ship It! - Jie Yu On Dec. 4, 2017, 10:23 a.m.,

Re: Review Request 63630: Added support for callable once functors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63630/#review192714 --- Fix it, then Ship it! 3rdparty/stout/include/stout/lambda.hpp

Review Request 64307: Rename reconfiguration_compatibility to reconfiguration_policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64307/ --- Review request for mesos. Repository: mesos Description --- Rename

  1   2   >