Re: [5.0] New mapper

2003-01-29 Thread Costin Manolache
Remy Maucherat wrote: > Costin Manolache wrote: >> Remy Maucherat wrote: >> >> >>>The mapper has a currently unused dependency on JNDI, and I plan to put >>>it in the org.apache.tomcat.util.http.mapper package. >> >> >> JNDI deps are f

Re: [5.0] Splitting authentication and authorization.

2003-01-29 Thread Costin Manolache
Jeanfrancois Arcand wrote: >>If we look at JSR115, it sugests creating several (3?) permission objects >>- each will be associated with the request. >> >>The creation of those objects will be part of the container ( probably in >>a valve or other module ). >> >>The point is that all _authorization

Re: [5.0] New mapper

2003-01-30 Thread Costin Manolache
Remy Maucherat wrote: > Costin Manolache wrote: >> Remy Maucherat wrote: > >> Cast the notification to MBeanServerNotification :-) > > Ok, it sort of works now. > > The remaining problems: > - some attributes need to send JMX notifications (welcome files, >

Re: [5.0] New mapper

2003-01-30 Thread Costin Manolache
Remy Maucherat wrote: > Remy Maucherat wrote: > >>> BTW - I assume you read the discussion on authorization - the problem >>> is the same ( mapping requests URIs to constraints ), it would be good >>> if we can reuse some code. >> >> >> The mapping code is generic. I was thinking about having t

Re: [5.0] New mapper

2003-01-30 Thread Costin Manolache
Remy Maucherat wrote: > Costin Manolache wrote: >> If the question is about using JMX1.2 - it was alredy proposed, and it >> seems nobody objected ( but nobody did it either ). If you want to do >> that - all you need is update the mbean descriptors, and change all the >

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Costin Manolache
Remy Maucherat wrote: > Tim Funk wrote: >> Tomcat5 does not compile with JDK1.3. It does with JDK1.4. >> >> There is only one line of code that prevents it from compiling with >> JDK1.3. org.apache.catalina.loader.WebappClassLoader depends on >> File.toURI() which does not exist on jdk1.3. >> >>

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Costin Manolache
Tim Funk wrote: > After looking at the older revisions, I agree my patch was stupendously > horrible :( > > The patch now uses reflection to keep the current code equivalent for > jdk14 and use the old way in case of a jdk1.3 jvm. > > That being said - I would assume that the RMI issue your patc

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Costin Manolache
Remy Maucherat wrote: > Costin Manolache wrote: >> Remy Maucherat wrote: >> >> >>>Tim Funk wrote: >>> >>>>Tomcat5 does not compile with JDK1.3. It does with JDK1.4. >>>> >>>>The

Re: [PATCH] allow tomcat5 to compile/run with JDK1.3

2003-02-03 Thread Costin Manolache
myself and should I be patient and wait for > someone with better insight to do this instead? You seem to have good insight, please do it. Costin > > -Tim > > > Remy Maucherat wrote: >> Costin Manolache wrote: >> >>> Tim Funk wrote: >>> >>

[PATCH] Root cause lost in Jsp and ServletException

2003-02-04 Thread Costin Manolache
this is for servetapi_4. Same applies to servletapi_5 ( I already sent a patch few weeks ago ). The problem is that JDK1.4 stack traces can't find the root cause. AFAIK nothing in the servlet or JSP specs requires breaking the normal contract for exceptions - which is to pass the root cause to t

Re: [PATCH] Root cause lost in Jsp and ServletException

2003-02-05 Thread Costin Manolache
Glenn Nielsen wrote: > BTW, this does not build with JDK's < 1.4 and if you use a servlet.jar > built with 1.4 in a JVM <1.4 you get a NoSuchMethodError. > > This change for jakarta-servletapi-4 need to reverted for now. > > Glenn > > > Costin Manolache wro

Re: [PATCH] Root cause lost in Jsp and ServletException

2003-02-05 Thread Costin Manolache
root cause ). Costin > > Thanks, > > -- Jeanfrancois > > Glenn Nielsen wrote: > >> BTW, this does not build with JDK's < 1.4 and if you use a servlet.jar >> built with 1.4 in a JVM <1.4 you get a NoSuchMethodError. >> >> This change for jakarta

Re: [TC5] Time to make a release?

2003-02-06 Thread Costin Manolache
Remy Maucherat wrote: > Kin-Man Chung wrote: >> There has been inquiries about a Tomcat 5 release, both in and out >> of the mailing list. I usually direct them to our nightly builds, >> but there is no links from the jakarta page, and they are not always >> available. I think it's time that we

RE: Shutdown.sh does not work when long lasting operations, such as SQL Queries, are still active!

2003-02-10 Thread Costin Manolache
Craig R. McClanahan wrote: > It is OK for web applications to start threads -- as long as the web > application cleans up after itself when the application is shut down (the > easiest way to detect that is to create a ServletContextListener and wait > for the contextDestroyed() method of your list

Re: [4.1.20] Tagging today

2003-02-11 Thread Costin Manolache
jean-frederic clere wrote: > Remy Maucherat wrote: >> jean-frederic clere wrote: >> >>> Remy Maucherat wrote: >>> Hi, I plan to tag 4.1.20 later today. Thanks to Glenn and Jan for getting some good fixes in. >>> >>> >>> >>> I would like to add some changes in Manager: >>> For

Re: [4.1.20] Tagging today

2003-02-11 Thread Costin Manolache
Amy Roh wrote: > I have investigated further and found out that > GlobalResourcesLifecycleListener is not creating mbeans for userdatabase > anymore, therefore, admin failure due to missing mbeans. > > Costin, > Do you have a better idea why Userdatabase MBeans are not getting > created anymore s

Re: [4.1.20] Tagging today

2003-02-11 Thread Costin Manolache
Thanks Amy. Costin Amy Roh wrote: >> Amy Roh wrote: >> >> > I have investigated further and found out that >> > GlobalResourcesLifecycleListener is not creating mbeans for >> > userdatabase anymore, therefore, admin failure due to missing mbeans. >> > >> > Costin, >> > Do you have a better id

Re: mod_jk and Apache timeouts?

2003-02-17 Thread Costin Manolache
I suspect it's a windows specific return code from recv(). The code in question calls socket_recvfull - which in turn calls recv() to fill a buffer. It handles EAGAIN - but knowing windows, it may be something else. If you can do a checkout from HEAD and built again - you should see the errno at

RE: mod_jk and Apache timeouts?

2003-02-17 Thread Costin Manolache
roblem. I have changed the >> Connector timeout to -1 in server.xml, and error 500's is no longer >> returned. >> Therefore on this box, mod_jk is too quick for Tomcat (I think). >> mod_jk tries to connect and fails 3 times (before TC has restarted its >> Connecto

Re: [5.0.1] Tagging today

2003-02-18 Thread Costin Manolache
Remy Maucherat wrote: > Jeanfrancois Arcand wrote: >> Are you able to build it? The nightly build failled with the following >> (see below). I will look at the failure latter this afternoon... > > It's a hint that there are urgent bugs to fix in either JspC or Jasper, > which make precompilation

Re: [5.0.1] Tagging today

2003-02-18 Thread Costin Manolache
Remy Maucherat wrote: > Costin Manolache wrote: >> Remy Maucherat wrote: >> >> >>>Jeanfrancois Arcand wrote: >>> >>>>Are you able to build it? The nightly build failled with the following >>>>(see below). I will look at the fai

Re: [5.0.1] Tagging today

2003-02-18 Thread Costin Manolache
Kin-Man Chung wrote: >> > It seems to be introduced by one of the recent changes - I had no >> > problem compiling the admin few weeks ago. We either roll back the >> > change or find another way. >> >> The bug happens in the jsp-examples precompilation (which is supposed to >> work also, right ?

Re: Startup question

2003-02-20 Thread Costin Manolache
Remy Maucherat wrote: > Filip Hanik wrote: >> yes, you are right, how do I subscribe to this event? >> I know that the server has a addLifeCycleListener, but how do I access >> the server from a cluster object for example? > > You can go up the tree, I think, but otherwise, you can just use > Ser

RE: Startup question

2003-02-20 Thread Costin Manolache
uot;server/service" object through JMX? > 2. I could check using reflection if the addLifecycleListener method is > available, but an interface would be nicer. > > Filip > > -Original Message- > From: Costin Manolache [mailto:[EMAIL PROTECTED]] > Sent: Thursday, February 20

Re: [5.0.1] Tagging today

2003-02-21 Thread Costin Manolache
Kin-Man Chung wrote: >> It seems the new spec revisions mean "more complex + more bloated" :-( >> This is quite disappointing ... >> > > Isn't that always true? :-) You need to add new features but cannot > remove old ones. You can allways side-step and create a new specification for the new

Re: commons-modeler in jtc and catalina

2003-02-26 Thread Costin Manolache
Henri Gomez wrote: > Remy Maucherat wrote: >> Henri Gomez wrote: >> >>> It seems that latest JTC / CATALINA require now a post 1.0 modeler. >>> >>> Did there is release plan for modeler 1.1 ? I think it'll be better called 2.0 - there are many big changes ( even if it should be backward compatib

Re: [5.0.1] Investigation on the precompilation failure + new tag

2003-02-26 Thread Costin Manolache
Remy Maucherat wrote: > Ok, I saw your commit. > Now that I think about it, I'd like to include a build script for the > new clustering features, and include them in the release (so it's > delayed for one additional day). Can we postpone it till Monday ? I want to get the embed/ working too, I j

Re: commons-modeler in jtc and catalina

2003-02-26 Thread Costin Manolache
Jeanfrancois Arcand wrote: > Costin, > > are you planning to tag the modeler workspace to reflect all you recent > changes (once they are completed of course)? Something like > MODELER_2_0_alpha (I'm not good for name) will be helpfull. Also, is > this module supposed to build by itself? Right no

Re: ant and jtc

2003-02-27 Thread Costin Manolache
Henri Gomez wrote: > From what I see, it seems we also need ant HEAD to compile > parts of JTC (JndiProperties). > > Did this stuff will be in ant 1.5.2 release ? JndiProperties is not required for anything - it's part of a refactoring of naming, but we don't use it in any way. It shouldn't be

Re: commons-modeler in jtc and catalina

2003-02-27 Thread Costin Manolache
Jeanfrancois Arcand wrote: >>BTW - in order to release modeler we need at least 3 +1 votes - so far I >>feel a bit alone :-) Is anyone else interested in this piece ? >> > > I am :-) If I can collaborate, guide me to what we need to do for > releasing it :-) I don't know :-) I'm just fixing it

Re: socket errors in catalina.out and mod_jk.log

2003-02-28 Thread Costin Manolache
Sven Köhler wrote: >> There is another problem with how mod_jk handles the ajp connetor >> sockets. That is the one to one mapping of apache child process to an ajp >> connector. On an apache server that serves normal http requests you can >> end up with many idle socket connections to Tomcat, and

Re: mod_jk 1.2 Apache 2.0 piped mod_jk logs

2003-02-28 Thread Costin Manolache
Glenn Nielsen wrote: > I have a patch which uses APR to implement logging for mod_jk 1.2 > for Apache 2.0. This update allows piped logs to be used. This > allows you to pipe the mod_jk logs to external programs such as > apache's rotatelogs or cronolog. > > I will commit this to CVS unless the

Re: socket errors in catalina.out and mod_jk.log

2003-02-28 Thread Costin Manolache
Henri Gomez wrote: > Another point is that adding new message to protocol make > it incompatible with olders java implementations or with alternate This is not entirely true. It is quite easy to configure what messages get sent by mod_jk - the admin is supposed to know what type of worker it co

Re: [4.1.21] Stability rating

2003-02-28 Thread Costin Manolache
Remy Maucherat wrote: > > [ ] Alpha > [ ] Beta > [X] Stable (GA) > > > Please vote (after testing the release, if possible ;). It works for me. It would be nice to fix the jspc bugs tough. I fixed a small regression in modeler(HEAD) so it can be used as drop-in replacement ( if you have non-su

Re: socket errors in catalina.out and mod_jk.log

2003-02-28 Thread Costin Manolache
Sven Köhler wrote: >>>I took a short look at the ajp13 protocol draft, and the design of the >>>protocol is really simple, too simple. >> >> There are few knwon problems with the protocol - both sides of jk2 are >> designed to support multiple protocols and extensions. > > yes, but how? how can

Re: socket errors in catalina.out and mod_jk.log

2003-02-28 Thread Costin Manolache
Sorry, my previous mail got a bit long ( and a bit unfriendly :-) The short version: There are 3 ways to extend jk2: 1. With a completely different protocol module - marshalling and all low level stuff. I'm +1 on such a thing if the new marshalling is a standard one - and I think XDR is the right

Jk MX proxy for mod_jk

2003-02-28 Thread Costin Manolache
I would really apreciate if someone could check how this works. The steps are: - compile - make sure /jkstatus is enabled and works - configure jk2.properties: class.modjkmx=org.apache.jk.common.ModJkMX modjkmx.webServerHost=localhost modjkmx.webServerPort=80 mx.port= - start apache - make

Re: socket errors in catalina.out and mod_jk.log

2003-03-01 Thread Costin Manolache
Sven Köhler wrote: >> 3. On top of regular request/response. Almost everything related with >> auth, pings, discovery, reconfiguration can be implemented by just using >> regular Ajp13 requests - with a special URL. That is by far my favorite >> mechanism. It also has the advantage that it can reu

Re: socket errors in catalina.out and mod_jk.log

2003-03-01 Thread Costin Manolache
Sven Köhler wrote: ... > special URLs are by far the best mechanism? > the next simpson-episode should start with bart writing "special urls > are by far the worst mechanism ever" to the board. > > it's working around a missing feature - nothing more, nothing less. > it's the worse method i could

Re: Jk MX proxy for mod_jk

2003-03-01 Thread Costin Manolache
Bill Barker wrote: > Once I have time to go through and patch the regression failures for Jk2, > maybe I'll test the new features. Until then, I'm strictly a Jk1 person. What failures do you have ? I've used jk2 on my machine for the last 3-4 months without any problem ( it is true, I don't get

Re: [4.1.21] Stability rating

2003-03-02 Thread Costin Manolache
Hans Bergsten wrote: >> Good. For JspC, I think there are more urgent problems than the tag >> related problem, such as the mangling issues which just got fixed in >> Tomcat 5. That's why I didn't bother trying to apply whatever patch was >> needed for tags, knowing it would still be broken. > >

Re: [4.1.21] Stability rating

2003-03-02 Thread Costin Manolache
Hans Bergsten wrote: >> You are a tomcat committer just like Remy or everyone else. Commit >> the fix - and if someone has a problem with it he can -1 and >> propose a better solution. > > Yes, I am, but it's been years since I committed anything and my > environment is not set up for it. I simpl

Re: [5.0] Monitor servlet

2003-03-05 Thread Costin Manolache
Remy Maucherat wrote: > Hi, > > I proposed that to Costin a few days ago, but got not so enthusiastic > comments. > The idea would be to add a new monitor servlet to the manager webapp. It > would generate data similar to http://www.apache.org/server-status. It > would mostly (exclusively ?) use

Re: [5.0] Monitor servlet

2003-03-05 Thread Costin Manolache
Remy Maucherat wrote: > Well, I indeed have a few things on my task list, including: > - new static resource cache (the current one is inefficient both in > terms of syncing and memory management) Any chance you'll make this a bit more independent of the internals - I tried to do a bit of refacto

Re: tomcat4 start script

2003-03-06 Thread Costin Manolache
Henri Gomez wrote: > Henri Gomez wrote: >> Hi to all, >> >> Some of my friends in the jpackage project have problems with the >> way tomcat4 start/stop. >> >> There is case where a catalina.sh stop didn't stop a running tomcat. >> In such case a restart (stop/start) failed. >> >> I proposed the

Re: tomcat4 start script

2003-03-06 Thread Costin Manolache
Remy Maucherat wrote: > Costin Manolache wrote: >> Henri Gomez wrote: >> >> >>>Henri Gomez wrote: >>> >>>>Hi to all, >>>> >>>>Some of my friends in the jpackage project have problems with the >>>>way to

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 MapperListener.java

2003-03-08 Thread Costin Manolache
Remy Maucherat wrote: > [EMAIL PROTECTED] wrote: >> costin 2003/03/07 22:52:36 >> >> Modified:coyote/src/java/org/apache/coyote/tomcat5 >> MapperListener.java >> Log: >> A Server is not required for non-standalone operation. In fact, Embeded >> doesn't def

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteConnector.java

2003-03-08 Thread Costin Manolache
Bill Barker wrote: >> Index: CoyoteConnector.java >> === >> @@ -1062,11 +1062,12 @@ >> * Initialize this connector (create ServerSocket here!) >> */ >>public void initialize() >> -throws Lifecyc

Re: [ANN] Tomcat 4.1.22 Alpha released

2003-03-10 Thread Costin Manolache
Henri Gomez wrote: > Henri Gomez wrote: >> Remy Maucherat wrote: >> >>> Tomcat 4.1.22 Alpha is now available for testing. >>> >>> Changes over 4.1.21 include: >>> - Fix for mangling with JSPC >>> - Fix precompilation with tag libraries packaged in JARs >>> - Fix JDBC store thread safety bug which

Re: JK2 for AOLserver 4.0

2003-03-11 Thread Costin Manolache
Alexander Leyke wrote: > I am a developer at AOL and have been recently working on a JK2 family > module for AOLserver. The module is ready now and I'd like to take steps > necessary to contribute the sources to Tomcat project. I read the Just send the patches and the new files. You can open an e

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java ServerLifecycleListener.java

2003-03-11 Thread Costin Manolache
[EMAIL PROTECTED] wrote: > amyroh 2003/03/10 19:25:52 > > Modified:catalina/src/share/org/apache/catalina/mbeans > MBeanFactory.java ServerLifecycleListener.java > Log: > Set to use JSR77 names as default. Please make sure tomcat 5 is also updated. I would

Re: Tomcat as it's own apache subproject ?

2003-03-11 Thread Costin Manolache
Henri Gomez wrote: > Did some of you ever think that Tomcat could became a > direct Apache subproject, like ant ? > > It seems Maven follow the same way. > > As such having Tomcat as a direct Apache projects will > allow a Tomcat PMC ? > > Costin, Remy, other commiters, what do you think ? I'm

Re: Tomcat as it's own apache subproject ?

2003-03-11 Thread Costin Manolache
Henri Gomez wrote: > I wanted to get opinions since being a Top Project seems to be > in 'the air du temp' (ant/maven...) Maven situation is a bit complicated :-) Ant is in a different space, and they voted to move out ( well, we voted... - I was -1 initially but on minority ). I still think we

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java ServerLifecycleListener.java

2003-03-11 Thread Costin Manolache
Amy Roh wrote: >> [EMAIL PROTECTED] wrote: >> >> > amyroh 2003/03/10 19:25:52 >> > >> > Modified:catalina/src/share/org/apache/catalina/mbeans >> > MBeanFactory.java ServerLifecycleListener.java >> > Log: >> > Set to use JSR77 names as default. >> >> Please m

JAAS Auth

2003-03-11 Thread Costin Manolache
Hi, I'm close to get JAAS realm and the memory LoginModule working - if I remember correctly we agreed to make JAAS the default for 5.0 ( I don't remember any objections ). I never tried it in 4.x - but from the code and code I strongly doubt it works. There is one change I would like to make.

RE: JAAS Auth

2003-03-11 Thread Costin Manolache
ext(directory), but returns the principal under the secured > subcontext. > > we don't want that to happen to us, do we :)) I don't think we'll be affected :-), but it may fix the jboss bug ( if they switch to using the built-in tomcat JAAS realm ) Costin > >

Re: 4.1 authentication bug / bug 14616

2003-03-11 Thread Costin Manolache
I think it is reasonable to fix it. This can be serious - if someone relies on application isolation ( like a hosting environment ), the consequences can be really bad, with one webapp guessing the credentials of another one. The fix seems reasonably simple and clean. Costin Keith Wannamaker wr

Re: 4.1 authentication bug / bug 14616

2003-03-11 Thread Costin Manolache
Bill Barker wrote: >> I think it is reasonable to fix it. >> >> This can be serious - if someone relies on application isolation ( like >> a hosting environment ), the consequences can be really bad, with >> one webapp guessing the credentials of another one. >> The fix seems reasonably simple a

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java ServerLifecycleListener.java

2003-03-12 Thread Costin Manolache
Amy Roh wrote: > It makes sense to use different domain names instead of using service > name. It'll take lots of code change in admin to change all the > objectnames to get rid of service name though. *sigh* I think a bit of grep can do the magic :-) It's not a big hurry. I'll start changing

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader WebappLoader.java

2003-03-12 Thread Costin Manolache
Remy Maucherat wrote: >> +for( int i=0; i> +sb.append( repositories[i]).append(":"); >> +} > > I think your should use the path separator here. You're right. I put it in mostly for debug. I'll fix it. Costin --

Re: JAAS Auth

2003-03-12 Thread Costin Manolache
Jeanfrancois Arcand wrote: >>Hi, >> >>I'm close to get JAAS realm and the memory LoginModule working - if I >>remember correctly we agreed to make JAAS the default for 5.0 ( I don't >>remember any objections ). >> > What about authorization :-) Righ now, the Realm implementation includes > the 3

Re: Please Help, Building JK2 failed

2003-03-12 Thread Costin Manolache
Al wrote: > jkant: > > BUILD FAILED > file:/usr/local/web/tmp/apache/JK2/jakarta-tomcat-connectors-jk2-2.0.2-s > rc/jk/build.xml:235: Warning: Could not find file > /usr/local/web/tmp/apache/JK2/jakarta-tomcat-connectors-jk2-2.0.2-src/jk > /jkant/ant.tasks to copy. Where did you got the sources

Re: JK2 not working with virtual hosts

2003-03-12 Thread Costin Manolache
Reinhard Moosauer wrote: > > Additional information: > Without virtual host I got the request mapped. But no answer but > a "segmentation fault .. child .. " in apache's error_log Can you send a stack trace ? I'm checking the hosts problem. Costin > > > > thanks, > > > Am Mittwoch, 12.

Reproductible (and working) builds

2003-03-12 Thread Costin Manolache
Remy - in the build process for 4.1 ( and 5.0 ), are you using anything but the download targets ? Can you make sure you do the builds on a clean workspace ? Right now 4.1 "clean" build fails - fileupload is not downloaded. I'm trying to do full builds of both on a clean machine. Costin -

Re: Reproductible (and working) builds

2003-03-12 Thread Costin Manolache
Remy Maucherat wrote: > Costin Manolache wrote: >> Remy - in the build process for 4.1 ( and 5.0 ), are you using anything >> but the download targets ? Can you make sure you do the builds on a clean >> workspace ? >> >> Right now 4.1 "clean" build fai

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2003-03-12 Thread Costin Manolache
[EMAIL PROTECTED] wrote: > remm2003/03/12 13:32:50 > > Modified:catalina/src/share/org/apache/catalina/core > StandardContext.java > Log: > - If init needs guards against being invoked twice, this also needs it. > - Any explanation why, BTW ? The gener

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java

2003-03-12 Thread Costin Manolache
[EMAIL PROTECTED] wrote: > billbarker2003/03/12 22:17:53 > > Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java > Log: > Initial support to do a redirect to a directory where the URL doesn't > end in '/'. > > This prevents browsers from becoming confused when t

Dependencies ( was: Re: [GUMP] Build Failure - jakarta-tomcat-5

2003-03-13 Thread Costin Manolache
When we add a new dependency to the code, we should: 1. Update gump 2. Make a small proposal and get a vote 3. Use conditionals if the dependency is not required and update download target Dependencies are very important and affect everyone. I don't remember when fileupload was added to HTMLMana

Re: mod_jk2 errors

2003-03-13 Thread Costin Manolache
What OS ? I added strerror - so if you update you may get better error number on "receiving message body". Regarding ajp_process_callback: that's most likely a user hiting "BREAK" on the browser. I downgraded the message to debug, it is a normal case. How loaded is tomcat ( number of requests

Re: cvs commit: jakarta-tomcat-catalina/catalina build.xml

2003-03-13 Thread Costin Manolache
Few questions ( and thanks for the help ). [EMAIL PROTECTED] wrote: > > - > > Ok - what is the base.path you use and where is it set ?? build.properties.default has the worst possible setting ( /usr/local ). +1 on removing shared/lib, we should move to a flatter layout. In

Re: cvs commit: jakarta-tomcat-5 build.xml

2003-03-13 Thread Costin Manolache
Logging: I double fixed it, there was an missmatch with the logging build.xml ( I fixed that ), and I also removed the build, logging is stable and released. We should only build the dependencies that are not stable and we may need to change - el, modeler, daemon. Regarding modeler: do an updat

Re: cvs commit: jakarta-tomcat-5 build.xml

2003-03-13 Thread Costin Manolache
Remy Maucherat wrote: > Well, the build is still broken for me. commons-logging inists on being > built in ${tomcat.build} instead of ${tomcat.build}/common/lib and > ${tomcat.build}/server/lib. > > What's the point of the updated build ? The point of the updated build is to get some consistenc

Re: Dependencies ( was: Re: [GUMP] Build Failure - jakarta-tomcat-5

2003-03-13 Thread Costin Manolache
Remy Maucherat wrote: > Costin Manolache wrote: >> When we add a new dependency to the code, we should: >> 1. Update gump >> 2. Make a small proposal and get a vote >> 3. Use conditionals if the dependency is not required and update download >> target >>

Re: Dependencies ( was: Re: [GUMP] Build Failure - jakarta-tomcat-5

2003-03-13 Thread Costin Manolache
Remy Maucherat wrote: > Costin Manolache wrote: >> Remy Maucherat wrote: >> >> Well - I tought the rule is that we can't release with dependencies on >> unreleased or beta code. >> >> And HTMLManagerServlet was supposed to be a simple servlet - it no

Re: cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2003-03-13 Thread Costin Manolache
Forgot to include: the patch was submited by Stefan Proels. Costin [EMAIL PROTECTED] wrote: > costin 2003/03/13 16:03:03 > > Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java > Log: > Extra fix - avoids the need for a change in Response > > PR: 14292 > > Revisi

Re: Catalina shutdown port as command line param?

2003-03-14 Thread Costin Manolache
Mladen Turk wrote: > Hi, > > I was wondering if we can add the '-shutdown portnumber' to the > catalina's command line parameters. > The usage would be to enable multiple TC instances using the same > server.xml file. > > If present the param would override the config's For 4.1.x or 5.0 ? In

Re: [GUMP] Build Failure - jakarta-tomcat-5

2003-03-14 Thread Costin Manolache
Remy Maucherat wrote: > Here's my own failure, trying to run "ant download": > jar: > [copy] Copying 1 file to > L:\home\tomcat-5\jakarta-servletapi-5\jsr154\build >[jar] Building jar: > L:\home\tomcat-5\repository\servlet-api-2.4\lib\servlet-api.jar > > BUILD FAILED > file:L:/home/

Re: cvs commit: jakarta-tomcat-5 build.xml

2003-03-14 Thread Costin Manolache
Remy Maucherat wrote: > [EMAIL PROTECTED] wrote: >> costin 2003/03/14 07:28:06 >> >> Modified:.build.xml >> Log: >> Trying to guess what's wrong on Remy's machine. >> >> The APIs are built in download as dependencies, no need to build >> them twice. > > I don't know

Re: [REPOST] [VOTE] [4.1.22] Stability rating

2003-03-14 Thread Costin Manolache
Remy Maucherat wrote: > Glenn Nielsen wrote: >> There was a bug fix to JDBCStore after 4.1.22 was built. >> >> I think we need a 4.1.23 build for stable. >> >> Sorry! > > No problem. > Since you're at it, could you remove the fileupload related > functionality from 4.1.x ? Big +1 ! Costin

Re: mod_jk 1.2.3 release

2003-03-14 Thread Costin Manolache
Glenn Nielsen wrote: > It has been a while since a mod_jk 1.2 release was done. > There have been a number of bug fixes and a few minor feature > enhancements. > > I just did some commits to fix some bugs I was seeing with mod_jk 1.2 and > Apache 2.0. Some of these will also improve the connecto

Re: [REPOST] [VOTE] [4.1.22] Stability rating

2003-03-14 Thread Costin Manolache
Glenn Nielsen wrote: > Remy Maucherat wrote: >> Glenn Nielsen wrote: >> >>> There was a bug fix to JDBCStore after 4.1.22 was built. >>> >>> I think we need a 4.1.23 build for stable. >>> >>> Sorry! >> >> >> No problem. >> Since you're at it, could you remove the fileupload related >> functiona

Re: [REPOST] [VOTE] [4.1.22] Stability rating

2003-03-14 Thread Costin Manolache
Glenn Nielsen wrote: >> Beta != release. >> >> And no, that's not the main reason. If you need the manager to include >> fileupload - than place it in WEB-INF/lib, don't bloat server/lib. >> The /admin doesn't place struts.jar in server/lib. >> > > That can be done. But I will also have to mov

RE: Tomcat 5 build failing,

2003-03-14 Thread Costin Manolache
Was jsr154 compiled correctly ? Do you have it in your repository ? Can you include the full build log - it's impossible to guess from a fragment. Costin Filip Hanik wrote: > "ant download" > > BUILD FAILED > file:C:/Development/jakarta-servletapi-5/jsr152/build.xml:72: Compile > failed; se

Re: cvs commit: jakarta-tomcat-5 build.xml

2003-03-15 Thread Costin Manolache
Remy Maucherat wrote: > [EMAIL PROTECTED] wrote: >> costin 2003/03/14 14:42:43 >> >> Modified:.build.xml >> Log: >> Fix Filip's build. >> >> It seems my "clean" workspace wasn't that clean after all. >> >> This whole thing is unbelievable. I have no idea how we en

Re: cvs commit: jakarta-tomcat-5 build.xml

2003-03-15 Thread Costin Manolache
Remy Maucherat wrote: >> Each component should support a "dist.dir" ( unlike servlet/jsp api build >> files), should support a "build" target that only builds the .jar - and >> should use the same patterns for finding the dependencies ( the other >> components ). > > No problem with me if you wan

[5] Few major changes in JMX naming

2003-03-15 Thread Costin Manolache
Not as major as the build breakage, I hope - but I think it is better to do it as soon as possible. Unless someone has good reasons not to do it, I'll start refactoring the JMX registration. There are few things I would like to do: - get rid of "service=XXX" in names. The JMX domain will correspo

Re: [5] Few major changes in JMX naming

2003-03-15 Thread Costin Manolache
I forgot one important thing: The main problem with supporting both registrations is the deregistration - who should unregister a component ? If the components are started by JMX - then JMX is supposed to unregister them. If they are created automatically - then whoever created them is respon

Re: [5] Few major changes in JMX naming

2003-03-15 Thread Costin Manolache
Remy Maucherat wrote: >> - get rid of "service=XXX" in names. The JMX domain will correspond to >> one tomcat instance - there is no reason to make things more complex. The >> admin can just list all mbeans, search for "*:type=Engine" and get the >> domain. > > Ok, so that goes along with having

Re: [4.1.23] Tag soon

2003-03-15 Thread Costin Manolache
Glenn Nielsen wrote: >> Personally, I'm willing to ignore the issue. >> Then I'll ignore the issue as well. > If the decision is made that we can not do a Tomcat release without > all dependent jar files being at a final stable release then I would > rather push to get commons to do a final st

Re: [5] Few major changes in JMX naming

2003-03-16 Thread Costin Manolache
Glenn Nielsen wrote: > I haven't looked at or played with the new JMX featuers. But I do have > some thoughts on names and scopes. We need to ensure that there is a > unique naming mechanism. That's the intention of the change. > A single monitoring tool may be used to monitor multiple insta

/admin

2003-03-16 Thread Costin Manolache
The admin app is now mostly broken - I did a small try to get it running, but it'll take more work. Amy - I would appreciate your help :-) There are still several components that need to be changed - the biggest problem at the moment is that some components are using the Engine name and some are

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java

2003-03-17 Thread Costin Manolache
Filip Hanik wrote: > Hi Costin, > haven't had time to review these changes, will they affect the clustering > implementation of the manager that extends StandardManager in there? Just make sure start() calls super.start(), or has: if( ! initialized ) super.init() You may want to add a fi

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina ServerFactory.java

2003-03-17 Thread Costin Manolache
Mladen Turk wrote: >> -Original Message- >> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] >> >> I'm trying a different path that will reduce the breakage >> and make /admin >> work with embeded as well. >> Basically I'm creating the Service and Server, even for >> embeded ( wh

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina ServerFactory.java

2003-03-17 Thread Costin Manolache
Mladen Turk wrote: > What I ment was a catalina.bat or catalina.sh embedded > calling o.a.c.s.Embedded I think Embedded class should be deprecated in 5.0, and all 'embedding' should be done via JMX. I haven't tested Embedded recently ( but it was working about a week ago ). You can create you

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina ServerFactory.java

2003-03-17 Thread Costin Manolache
Mladen Turk wrote: > > >> -Original Message- >> From: Remy Maucherat [mailto:[EMAIL PROTECTED] >> >> Just wanted to let you know that the new embedded in 5.0 is great. >> Costin (and I, to some extent) got it running with JBoss 3.2 >> without any >> problem. The big advantage is that it

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina ServerFactory.java

2003-03-17 Thread Costin Manolache
You may notice that the JNDI stuff is not yet finished, and I haven't tested the authentication ( JAAS realm works fine with our LoginModule, but it may still have some non-standard behaviors it relies on ). Well - I wrote the code that would support the more sane pattern used by jboss for Princip

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

2003-03-17 Thread Costin Manolache
I don't know if the official build for 4.1.22/23 is done - but it would be nice if we could include this fix for jspc. I don't know any other way to compile an app using struts. Remy - were you able to precompile /admin for 4.1.23 ? Do you plan to include it precompiled, or the old way ? Costin

/admin - what needs to be done

2003-03-17 Thread Costin Manolache
The biggest change will be getting rid of all direct references and casts to catalina classes - and use JMX consistently. The other problem is the hardcoded "Catalina:" domain. I started to fix Server and other classes to help the migration - it'll have a fixed name: "Catalina:type=Server". It'll

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina ServerFactory.java

2003-03-17 Thread Costin Manolache
Mladen Turk wrote: > > >> -Original Message- >> From: news [mailto:[EMAIL PROTECTED] On Behalf Of Costin Manolache >> >> > What I ment was a catalina.bat or catalina.sh embedded calling >> > o.a.c.s.Embedded >> >> I thi

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

2003-03-18 Thread Costin Manolache
Remy Maucherat wrote: > [EMAIL PROTECTED] wrote: >> costin 2003/03/17 12:53:40 >> >> Modified:jasper2/src/share/org/apache/jasper Tag: tomcat_4_branch >> JspC.java >> Log: >> I don't know if this can make it into the release - but I can't get >> jspc to wo

<    1   2   3   4   5   6   7   8   >