Re: [Zope-dev] Subversion externals versus mirroring
On Tue, Sep 15, 2009 at 07:56:42AM -0400, Gary Poster wrote: Generally, I'd be surprised to learn that Bzr/Launchpad were alone in supporting this, but they are the only ones I can vouch for. For instance, I'm almost positive that github also allows you to have multiple committers to a single branch, though I don't remember the mechanism. bitbucket and github both support this, yes. (And thus presumably any repository running mercurial or git, though I don't know how to admin them.) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org https://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - https://mail.zope.org/mailman/listinfo/zope-announce https://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] [Checkins] SVN: zope.app.http/trunk/ - Replacedthedependency on zope.deprecation with BBB imports
On Wed, May 27, 2009 at 02:06:03PM +0200, Roger Ineichen wrote: I think there is something else wrong if someone is using code with deprecation warnings in a production setup. Do you not use any third-party code? Often, the deprecation warnings are emitted by code not under your control. - PW -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Why does restrictedTraverse() in Zope 2 not respect IPublishTraverse adapters?
On Thu, May 14, 2009 at 10:55:40PM +0200, Laurence Rowe wrote: For maximum portability across Z2 / Z3 / BFG, you could just do the same thing and implement __getitem__ on any object you want to be traversable by either the publisher or APIs like (un)restrictedTraverse, and forego the over-complicated component-laden traversal dance. ;) Minimal example demonstrating this with a view in zope2: from zope.component import getSiteManager from Testing.makerequest import makerequest from zope.publisher.browser import IBrowserView from Acquisition import Explicit from zope.component import getSiteManager app = makerequest(app) smgr = getSiteManager() class Foo(Explicit): ... def __init__(self, context, request): ... self.context, self.request = context, request ... def __getitem__(self, key): ... return int(key) ... smgr.registerAdapter(Foo, (None, IRequest), IBrowserView, name='foo') app.unrestrictedTraverse('@@foo/12345') 12345 Thanks for reminding me of this. I keep forgetting that this works! I only add that if you want to use __getitem__ for publishing, the items you return should inherit from Acquisition.(Im|Ex)plicit to make the security machinery happy. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] ZTK futures: one big package?
On Tue, May 12, 2009 at 03:08:05AM -0400, Chris McDonough wrote: Once we deflate our current set of packages down to a reasonable number, the packages listed in PyPI will immediately start to reflect the state of reality right now. As a result, we'll hopefully be able to get some new blood in the form of new developers that use the smaller bits outside Zope to help us tease the truly independent pieces out of the larger pile. If we do this, at no time after the deflation will PyPI listings ever as badly advertise the state of reality as it is advertised right now, and the community will hopefully again start to grow. I agree with a lot of what you wrote, but I don't understand this last bit. All the currently released packages will continue to live on pypi more or less forever, no? To paraphrase a wise man, Releasing a package means always having to say you're sorry ;-) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] ZTK futures: one big package?
On Tue, May 12, 2009 at 12:36:06PM -0400, Chris McDonough wrote: On 5/12/09 12:27 PM, Paul Winkler wrote: I agree with a lot of what you wrote, but I don't understand this last bit. All the currently released packages will continue to live on pypi more or less forever, no? To paraphrase a wise man, Releasing a package means always having to say you're sorry ;-) I don't think so. People would need to change their code to depend on the big package, and the smaller packages would cease to have a life of their own. Having both the smaller packages and some bigger package that also contains it and needing to maintain both truly would be the worst of all possible worlds. I must be dense today because I still don't understand what cease to have a life means. Remove them from pypi? How would you avoid breaking all the current software in the world that currently depends on all those distributions? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] trying out the buildout-based Zope 2.12...
On Sun, Mar 29, 2009 at 11:47:14AM -0400, Jim Fulton wrote: I think an implementation of a better dependency resolution strategy in buildout would be a good place to start. I think some limited backtracking could go a long way. Anyone interested in working on this? Ian's Pip tool tries to download everything and work out the complete graph before doing any installation; I've no idea if any of that work could be ported to buildout, but it might be worth a look? https://svn.openplans.org/svn/pip/ (If you guys are both still at Pycon, might be worth a face-to-face chat...) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] trying out the buildout-based Zope 2.12...
On Mon, Mar 30, 2009 at 12:29:16PM -0400, Jim Fulton wrote: On Mar 30, 2009, at 12:08 PM, Paul Winkler wrote: Ian's Pip tool tries to download everything and work out the complete graph before doing any installation; I've no idea if any of that work could be ported to buildout, but it might be worth a look? https://svn.openplans.org/svn/pip/ But this is about determining the complete graph. I don't understand. What did I say that wasn't relevant to that? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] trying out the buildout-based Zope 2.12...
On Fri, Mar 27, 2009 at 04:27:31PM -0500, Chris Withers wrote: Andreas Jung wrote: One last hint: you might try using 'pip' (instead of 'easy_install'). 'pip -v' gives you better information about the dependencies pulled in and where (but it does not tell you why - at least not obviously). Engage brain ;-) I'm not using easy_install, I'm using buildout... (yeah, I know buildout uses easy_install, but...) One possibility: try using http://pypi.python.org/pypi/gp.recipe.pip ? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] trying out the buildout-based Zope 2.12...
On Fri, Mar 27, 2009 at 04:34:43PM -0500, Chris Withers wrote: Paul Winkler wrote: I'm not using easy_install, I'm using buildout... (yeah, I know buildout uses easy_install, but...) One possibility: try using http://pypi.python.org/pypi/gp.recipe.pip ? I need to be totally upfront about this: I'm interested in finding out why something that *should* work is broken. I worry that there's something not quite right in buildout that's causing that, and that's something I'd like to fix... I'm NOT interested in working around the problem, specifically by trying out weird'n'whacky recipes... Well, yeah. The point of the suggestion was specifically to help you get more info about the dependency chain, since pip is more verbose about that than easy_install is. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Translations for zope packages.
On Tue, Feb 10, 2009 at 01:54:54PM +0100, Martijn Faassen wrote: In my mind, the Zope framework should offer facilities to support translating applications. These applications can be composed out of more than a single package, and we want to support the translation memory usecase for that. If the Zope framework defines messages itself itself, it should offer a way for an application that exposes them to have translations as well. IMO it must also be possible for an application integrator to install a package that selectively overrides the default translations. How can that be done? At TOPP, when we used Plone 2 and PTS, we had a hack that allowed us to do this, see eg. https://svn.openplans.org/svn/sputnik/branches/0.9.8/sputnik/zinit.py This allowed us to provide some different (english) translations for the same message ids on two websites (openplans.org and livablestreets.com), just by having the sputnik package installed on one site. So far, I've been unable to find a way to accomplish the same thing with the zope 3 i18n infrastructure, which is blocking us from moving to plone 3 on the site that needs the overrides. Is this even possible? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] transaction.doom() and ZPublisher
Hi, I noticed that Zope 2.11 includes a recent version of the transaction module including the transaction.doom() method. But I don't see any check for it in ZPublisher. So, if any code calls transaction.doom(), the publisher will raise a user-visible exception when it tries to call commit(). This seems less than useful :-) In the discussion I've seen of this method, eg. https://bugs.launchpad.net/zope3/+bug/98382 and http://markmail.org/message/3yshpmltvhevnrff it sounds like other people share my expectation... namely, that the developer should not have to do anything special after calling transaction.doom(); the transaction is not committed, and the user won't see an exception. Is that the concensus? If so, there's an easy solution - apply something like the attached patch. Anybody disagree? -- Paul Winkler http://www.slinkp.com --- Zope2/App/startup.py~ 2008-06-14 02:50:23.0 -0400 +++ Zope2/App/startup.py2008-07-10 00:08:02.0 -0400 @@ -267,7 +267,8 @@ transaction.begin() def commit(self): -transaction.commit() +if not transaction.isDoomed(): +transaction.commit() def abort(self): transaction.abort() --- ZPublisher/Publish.py~ 2008-06-14 02:50:48.0 -0400 +++ ZPublisher/Publish.py 2008-07-10 00:08:08.0 -0400 @@ -314,7 +314,8 @@ def begin(self): transaction.begin() def commit(self): -transaction.commit() +if not transaction.get().isDoomed(): +transaction.commit() def abort(self): transaction.abort() def recordMetaData(self, object, request): --- ZPublisher/WSGIPublisher.py~2008-06-14 02:50:48.0 -0400 +++ ZPublisher/WSGIPublisher.py 2008-07-09 23:59:57.0 -0400 @@ -401,7 +401,8 @@ def begin(self): transaction.begin() def commit(self): -transaction.commit() +if not transaction.get().isDoomed(): +transaction.commit() def abort(self): transaction.abort() def recordMetaData(self, object, request): ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Status of Better XML support for Page Templates?
Was any action ever taken on this? http://wiki.zope.org/zope3/BetterXMLSupportForPageTemplates I never even realized until today that all my browser:page templates are apparently loaded in HTML mode. (Tested in Zope 2.9.9 / Five 1.4.2 ) -- http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Five registerPackage results in unresolved ConflictError
On Wed, May 21, 2008 at 12:47:58PM +0200, Sasha Vincic wrote: So you run ./zopectl run do_nothing.py before you started each instance? We do it just once, right after building a new instance; the instance starts up fine forever after that. Is that better then my doInstall() check? Well, no, it's just a workaround, so it's certainly not better than a fix to the underlying problem. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] svn.zope.org down?
It's been pretty flaky from here in the US too (at least from NY). But I was eventually able to commit some things yesterday. On Tue, Apr 29, 2008 at 06:07:00PM +0100, Chris Withers wrote: Hey All, Can't contact svn.zope.org, it dead? cheers, Chris -- Simplistix - Content Management, Zope Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope ) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Test failure in zope.component on 2.10 branch
Does anybody else see this on a fresh checkout of the zope 2.10 branch? I think it's pretty new; I had a checkout last week where I didn't get any test failures. [EMAIL PROTECTED] ~/tmp/z2branches/2.10 $ python test.py -s zope.component Running tests at level 1 Running unit tests: Running: Failure in test testStandalone (zope.component.tests.StandaloneTests) Traceback (most recent call last): File /usr/lib/python2.4/unittest.py, line 260, in run testMethod() File /home/pw/tmp/z2branches/2.10/lib/python/zope/component/tests.py, line 975, in testStandalone self.fail(''.join(lines)) File /usr/lib/python2.4/unittest.py, line 301, in fail raise self.failureException, msg AssertionError: . -- Ran 1 test in 0.011s OK -- http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Test failure in zope.component on 2.10 branch
False alarm. It turned out to be spew that I've seen before only under certain circumstances: if you're on a gentoo box and your $TERM env. var. is set to xterm, then importing readline causes some non-printable characters to be written to stdout. The test was failing on those, because it expects OK to be the last thing printed by the subprocess. I can make it pass by setting TERM=linux or TERM=xterm-color. I can't reproduce on any other *nix I've tried (ubuntu, OSX). *Shrug* FWIW here's a demo of the garbage output from importing readline: [EMAIL PROTECTED] ~ $ TERM=xterm python -c import readline | od -c 000 033 [ ? 1 0 3 4 h 010 [EMAIL PROTECTED] ~ $ TERM=linux python -c import readline | od -c 000 On Mon, Apr 28, 2008 at 4:50 PM, Tres Seaver [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Winkler wrote: Does anybody else see this on a fresh checkout of the zope 2.10 branch? I think it's pretty new; I had a checkout last week where I didn't get any test failures. [EMAIL PROTECTED] ~/tmp/z2branches/2.10 $ python test.py -s zope.component Running tests at level 1 Running unit tests: Running: Failure in test testStandalone (zope.component.tests.StandaloneTests) Traceback (most recent call last): File /usr/lib/python2.4/unittest.py, line 260, in run testMethod() File /home/pw/tmp/z2branches/2.10/lib/python/zope/component/tests.py, line 975, in testStandalone self.fail(''.join(lines)) File /usr/lib/python2.4/unittest.py, line 301, in fail raise self.failureException, msg AssertionError: . -- Ran 1 test in 0.011s I don't see that issue. What is the content of the 'lines' local variable there? (Run with '-D' to get a postmortem). Tres. - -- === Tres Seaver +1 540-429-0999 [EMAIL PROTECTED] Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIFjiO+gerLs4ltQ4RAi0LAJ0Z8w7cExs/I3ujQKm9Y+CR97WFKgCeKUo7 6aEQeB/Iv2evxOkQnD8O7yk= =oRhO -END PGP SIGNATURE- -- http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Test failure in zope.component on 2.10 branch
On Mon, Apr 28, 2008 at 05:26:36PM -0400, Benji York wrote: On Mon, Apr 28, 2008 at 5:09 PM, Paul Winkler [EMAIL PROTECTED] wrote: The test was failing on those, because it expects OK to be the last thing printed by the subprocess. I don't have any idea what you're talking about, so ignore me if I'm totally off-base... but: shouldn't the thing that is running the tests be looking for exit code instead of sniffing for particular output on stdout? Good question. The subprocess that's run is lib/python/zope/component/standalonetests.py which runs a typical unittest.main(). Does that not exit 1 on failures, on all platforms? (What happens on windows?) btw, the calling code (zope/component/tests.py) was made somewhat more robust between 2.10 and 2.11, but it's still sniffing stdout. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] buildbot.zope.org?
This one looks great, thanks Christian. Any idea what's wrong with Zope2.buildout? Looks like Acquisition is not built properly: http://zopebuildbot.whq.gocept.com/builders/Zope2.buildout/builds/75/steps/test/logs/stdio On Sat, Apr 26, 2008 at 08:22:40AM +0200, Christian Theune wrote: Hello Paul, Theuni built a new one: http://zopebuildbot.whq.gocept.com/ But it's down again... It's still what I call experimental. The availability is pretty good in general though, unfortunately it didn't restart when the machine cycled (Thursday?) and I was too lazy/busy to fix it yesterday. The restarts should go normal by now and I don't know any other condition that currently would wrack it. Christian -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot.zope.org?
What's the story with http://buildbot.zope.org ? It looks like most of the slaves are either disconnected, or failing to build at all, with errors like this: e.g. http://buildbot.zope.org/Zope3%20trunk%202.4%20Windows%202000%20zc-bbwin3/builds/704/svn/0 ... File c:\python24\lib\site-packages\buildbot\slave\commands.py, line 275, in kill self.commandFailed(CommandInterrupted(no process to interrupt)) exceptions.AttributeError: ShellCommand instance has no attribute 'commandFailed' -- http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] comments on DateTime(DateTime()) preserving timezone? (launchpad 200007)
I've got a fix, with tests, for https://bugs.launchpad.net/zope2/+bug/27 checked in at Zope/branches/slinkp-datetime-27 If nobody objects in the next few days, I'd like to merge this to trunk, and the 2.11, 2.10, and 2.9 branches. -- http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Checkins] SVN: z3c.formjs/branches/pcardune-extjs/ creating a branch to see what I can do about extjs integration.
Regarding Ext's licensing, I'm told that they are planning to switch to an OSI-approved license in the near future; we're still waiting for more details, but my source is here: http://www.openplans.org/projects/opencore/lists/opencore-dev/archive/2008/04/1208546123405 - PW -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Non-ASCII characters in URLs
On Sun, Apr 06, 2008 at 04:37:22PM -0700, Alexander Limi wrote: Hi, Is there a good technical explanation for why Zope doesn't allow non-ASCII characters in URLs? I suspect it's only for hysterical raisins. The code in question is in OFS/ObjectManager.py, in the checkValidId() function. Non-ASCII characters trigger a match on the bad_id regular expression search. As I recall, if you look at the revision history, that code is very old. There might even be an existing bug filed about this; I don't remember. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: zope.sendmail Retry fixes and new state machine.
On Tue, Mar 11, 2008 at 09:25:59AM -0400, Jim Fulton wrote: It is certainly straightforward enough to create isolated doctests. For edge cases, I do typically create separate isolated short doctests that deal just with that case. The assertion that doctests don't allow isolation is simply not correct. Can you think of a package offhand that I might look at to see a good example of this? I've got a lot of overgrown, brittle doctests at work that need gradual reorganization, and I'd love to see some good role models. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Hivurt code hosting
On Mon, Nov 12, 2007 at 12:19:20PM -0500, Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul Winkler wrote: On Sun, Nov 11, 2007 at 06:37:22PM -0500, Stephan Richter wrote: Yes, everyone has to sign a contributor agreement, but you do not have to become a Zope Foundation member. I had the impression, from the recent ZF IRC chat, that the process of adding new contributors is currently blocked - but perhaps I misunderstood? We can't move the code ownership yet (from ZC to ZF) because once we *do*, becoming a contributor will be governed by ZF rules, which are currently self-contradictory: at that point, we would be unable to add new committers at all. I see, thanks. What I just can't figure out is: what is the current process of becoming a comitter. http://www.zope.org/DevHome/Subversion/FrontPage still links to http://www.zope.org/DevHome/Subversion/Contributor.pdf which is very old. Is it still used? I probably still have commit access from the pre-ZF days, but the employer information I submitted has changed several times since then. Now that I've started working for a more enlightened employer, I would like to start checking in bugfixes again but I don't know whether I should just use my old keys, or submit a new form, or what. - PW ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Hivurt code hosting
On Sun, Nov 11, 2007 at 06:37:22PM -0500, Stephan Richter wrote: Yes, everyone has to sign a contributor agreement, but you do not have to become a Zope Foundation member. I had the impression, from the recent ZF IRC chat, that the process of adding new contributors is currently blocked - but perhaps I misunderstood? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: ZClasses Maintenance and Upgrade
On Wed, Apr 18, 2007 at 11:52:03AM +0200, Max M wrote: I wrote this 5 message years ago: http://mail.zope.org/pipermail/zope/2002-May/115427.html I've just added a link to that message on this wiki page: http://wiki.zope.org/zope2/ZClassesAreEvil Max (or anybody), feel free to merge the text of Max's message into the wiki page. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Proposal for optimized Blob handling
On Wed, Mar 07, 2007 at 06:31:25PM +0100, Christian Theune wrote: Am Mittwoch, den 07.03.2007, 14:01 -0300 schrieb Sidnei da Silva: What exactly do you mean by 'link'? As in 'soft links'? The uploaded file usually is a temporary file, so you are saying you would create a soft link on the 'blobs' directory to a file in the $TMP directory? Or maybe the other way around? No, I'd create a new hard link into the blob directory so the link to the temporary file can go away without making the inode go away. For the purposes of storing blobs the TMP directory should be on the same partition as the blobs directory anyway. I like the idea, but what will you do if this fails? (eg. the admin has put TMP on a different mount, or we're running on Windows). -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Interest in AdvancedQuery and/or ManagableIndex?
On Fri, Feb 02, 2007 at 10:36:37PM +0100, Dieter Maurer wrote: I have no problems to donate AdvancedQuery and/or Managable Index +1 from me. I haven't used Managable Index, but AdvancedQuery is great and more people should be aware of it. to the Zope Foundation *BUT* I will not modify the code to bring it in line with the different style requirements usually applied to Zope components: e.g. * my code uses 2 blank indentation rather than the usual 4 blank (to make it more readable and easier to maintain for me) are you saying you would refuse the donation if somebody else wanted to change it to 4 spaces? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: ZCML and 'zopectl test'?
On Sun, Jan 07, 2007 at 12:14:32PM +0100, Philipp von Weitershausen wrote: So, there are two options: - modify the setUp() of the tests in question to provideUtility(your_utility) - make the respective tests run in a layer that loads the ZCML. I don't think layer support is on the trunk yet. Whit Morriss has a branch where he added that to Zope 2, but it still hasn't been merged :( The testrunner in zope 2 has supported layers for quite a while. I currently use layers in my tests with zope 2.9.1. TestLayersHowTo on zopewiki.org gives a working example. Or do you mean something else by layer support? -- Paul Winkler ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Testing in the Zope project open space at PyCon07
On Thu, Nov 30, 2006 at 10:22:10AM -0800, Grig Gheorghiu wrote: According to Ian, Zope2 had a lot of tests retrofitted, which made things painful -- as opposed to Zope3, which had testing as an integral part of the project. Not sure if this is true or not, but if people are interested, I'd be happy to propose such an Open Space session. Things to talk about would include doctest, buildbot, coverage, etc. +1. I'd add layers to the etc list. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] PYTHONPATH
On Wed, Sep 27, 2006 at 06:26:49PM -0500, whit wrote: It seems like if you've set your PYTHONPATH and start zope, you would expect that path to be available. Indeed. Anyone object to this going forward? Anyone think this is a bug that should be fixed(on older versions)? I think it's a bug, but then, I don't recall ever stumbling on it in practice. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Zope3-dev] Re: Stable / Development branches?
On Sun, Jun 18, 2006 at 08:30:58PM +0200, Lennart Regebro wrote: On 6/18/06, Paul Winkler [EMAIL PROTECTED] wrote: +1, I'd like some way to easily know when a release is no longer maintained. i.e., what's the X in the above formula. Well, it's 2 versions, so far. I.e, current release and last release. Unless we decide to change that now. OK, but just to clarify: Will we stop having to backport bugfixes to 2.8 when 2.10 final is released? But we need to backport bugfixes during the 2.10 beta cycle? Is this policy written down somewhere? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] How do I get involved in volunteering?
On Tue, Jun 13, 2006 at 11:15:12AM -0700, Christopher Lozinski wrote: Maybe there is a trade show where all the key players show up once a year. A lot of people come to pycon and the europython conference. I think in the Plone world, at least there are the two key players, and then the board, so there is some visible structure. In the Zope world it is not so clear. google for zope foundation. So here are my questions. How does one get involved? http://www.z3lab.org/sections/blogs/philipp-weitershausen/2006_06_07_join-zope-foundation-now Who is in charge? Jim is still the Zope Pope. Who approves cvs submissions? Nobody / everybody. i.e. there's no formal process, but people often complain about checkins they disagree with. It's generally resolved informally and amicably. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Zope 3 ZPTs in Zope 2: Nearly done
On Mon, May 22, 2006 at 03:41:21AM +0200, Philipp von Weitershausen wrote: Philipp von Weitershausen wrote: http://svn.zope.org/Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testDTMLTests.py?rev=68229view=auto http://svn.zope.org/Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testHTMLTests.py?rev=68230view=log I meant http://svn.zope.org/Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testHTMLTests.py?rev=68230view=log http://svn.zope.org/Zope/branches/ajung-zpt-end-game/lib/python/Products/PageTemplates/tests/testExpressions.py?rev=68229view=auto instead. Re. one of your questions: #there are ways to make code compatible with 2.9 and 2.10: #Add a nocall: before the python: expression (if that's #possible?!?). Yes, it's possible. This works fine in 2.9: p tal:define=blah nocall:python:int tal:content=python:blah('1')+2 /p -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Better ZDOM examples?
On Tue, May 02, 2006 at 12:00:07PM -0700, Benjamin Isaac wrote: I'm using Zope version 2.5 Wow. You do know that's over four years old, right? Are you stuck with that version for some reason? My problem: I need to access the DOM. I need to pass a value from a form field to a python script. Unfortunately I can't make sense of the above... it was a non-sequitor. Let's split those up, or you can explain how you think they're related: I need to access the DOM. Why? I need to pass a value from a form field to a python script. That normally has nothing to do with DOM. Typically, the form would just submit to a url that resolves to a script, and that script will get the value from the request. See the chapters Basic Zope Scripting and Advanced Zope Scripting in the online Zope Book, at http://www.plope.com/Books/2_7Edition Sorry if you've read all that before, I may be totally missing your point. I'm not sure if 2.5 implements ZDOM. If so, has anyone used it yet? If someone has used it, then perhaps that someone could send me a code snippet as an example? Personally I've never seen ZDOM before. AFAICT from a very brief look, it's nothing but a different way of traversing the zope object tree. Possibly convenient at times but I don't see anything there that can't be done with the normal zope APIs. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Is there a function to get the object type?
On Mon, Apr 10, 2006 at 03:46:41PM -0700, Takahashi, Michael wrote: Hi guys, I'm trying to write a function that checks to see if the current object is a 'Folder'. I am using this tutorial as a reference: http://plone.org/documentation/how-to/pre-populated-folder To create a new content object, the following command is used: parent.invokeFactory(id=id, type_name='Folder') Is there a function that can check what type this newly created object is? Obviously its 'Folder' in this example, but I'd like to be able to get the type_name of an object returned anywhere in my site to see if it is a 'Folder'. This is really a CMF question and belongs on the zope-cmf mailing list; invokeFactory() is a method of CMFCore.PortalFolder. But to answer your question: someobject.portal_type -PW -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Zope Test Summaries 2006-04-05
On Thu, Apr 06, 2006 at 06:04:11PM -0400, Tres Seaver wrote: +1 for getting rid of *anything* in Testing which does something as Utterly Evil (tm) as scribbling on 'os.environ'. Any tests which break on that account should be fixed, not covered over. You don't risk breaking production code, only tests, and those *need* to be fixed, even when running against the stable tree (I would even think backporting to 2.8 was worthwhile, just for the testing bugs it would expose). I agree with the sentiment, but thinking of it from a user's p.o.v. I would be mighty annoyed if I upgraded from 2.9.2 and 2.9.3 and found that tests in package foo were broken by tests in package bar only because of changes in package qux. Test pollution bugs can be real maddening time-wasters. Upgrading to 2.10 is another story ;-) I may try eradicating os.environ usage from Testing on my trunk sandbox and see what else breaks... -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Zope Test Summaries 2006-04-05
On Fri, Apr 07, 2006 at 10:04:36AM -0400, Paul Winkler wrote: I may try eradicating os.environ usage from Testing on my trunk sandbox and see what else breaks... Answer: nothing. Committed on the trunk. I did a bit of grepping around too. There are a few tests that twiddle os.environ, but these are all things that really rely on environ. For example, the tests for zdaemon/tests/testzdoptions.py, which uses a little monkeypatching in setUp() and unpatching in tearDown() so the environ should be restored after every test. However, there are some tests around that scribble on the REQUEST.environ as created by Testing.makerequest. So these would have inadvertently twiddled the real os.environ before my latest commit. The test authors might not even know they were doing that. Blech. Fixed :) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Zope Test Summaries 2006-04-05
On Fri, Apr 07, 2006 at 12:52:29PM -0400, Paul Winkler wrote: On Fri, Apr 07, 2006 at 10:04:36AM -0400, Paul Winkler wrote: I may try eradicating os.environ usage from Testing on my trunk sandbox and see what else breaks... Answer: nothing. Committed on the trunk. To clarify, I just removed os.environ from Testing.makerequest. I didn't touch anything in Testing.ZopeTestCase. There's a bunch of os.environ usage in there and I'm not up for looking through that right now. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Checkins] SVN: Zope/trunk/ Fixed collector 2057: Testing.makequest broke getPhysicalPath()
On Fri, Apr 07, 2006 at 02:35:57PM +0200, Florent Guillaume wrote: Paul Winkler wrote: Using an Item or Folder as your root object for tests works fine except for this one issue, so why not allow that? My feeling is that setting up an app is unnecessary work when you don't need one; for one thing, your test module needs to call Zope2.startup() first; for another, afaict creating a Zope2.app is a couple orders of magnitude slower than creating a SimpleItem. So maybe more people *should* use makerequest(NotAnApp) ;-) FWIW usually in my tests I rarely use makerequest. On the other hand, when testing things that use traversal, it's very common that I have to define a fake root object whose getPhysicalPath returns ('',). It's only a few line, and makes my tests self-contained and much easier to understand than relying on the magic of a testing framework library (which I tend to hate). I'm of two minds here. Those only a few lines add up very quickly. I hate wading through 50 lines of setup for every two lines of actually testing something. On the other hand, it's annoying when the test framework magic does something unexpected. You just can't win. :-( Whipping up my own request-wrapped root object for reuse internally seems like a good solution. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Checkins] SVN: Zope/trunk/ Fixed collector 2057: Testing.makequest broke getPhysicalPath()
On Thu, Apr 06, 2006 at 06:01:30PM -0400, Tres Seaver wrote: Paul Winkler wrote: I know who originally added those tests, That would be me. I was hoping you'd pop in :-) I don't see anything wrong with using a non-Zope2-app object for unit testing: in fact, I think it is *superior* practice. Most tests don't need to have the whole shooting match of the Zope startup dance done, and in fact will be better unit tests if they are tested *outside* of that environment. (snip) I think you will see lots of usage of the pattern in CMF and related products: the RequestTest and SecurityRequestTest base classes from CMFCore are used *everywhere*. The only caveat is that, if your tests *needs* to call 'getPhysicalPath' and get a realistic value, you need to ensure that the object used as the root does the Right Thing (TM). Interesting. I'd forgotten that RequestTest et al. used this stuff; I had another look and what gets wrapped in makerequest there is whatever you get when you do Zope2.DB.open().root()['Application']. Is that not a Zope2.app? tangent: I really wish I'd looked at tests/base/testcase.py sooner, because I wasted time rewriting our LogInterceptor to work with the logging package - I didn't realize that a) it was a copy-paste from CMFCore, and b) the logging update was already done for CMF 2 if not sooner. Doh! Copy-paste is evil. Oh well, I learned some things about the logging package. I don't beleive that must be a Zope2.app() is a real part of the contract of 'makerequest': must be able to emulate one well enough for the rest of the test to succeed is. That's a good thing to note in the docstrings. I'll go do that. Also I'll remove the getPhysicalPath() hackery. I don't really agree with Stefan that it's dangerous, but certainly it smells bad :-) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] bug in trunk ZopePageTemplate.py?
Running CMF 2.0-beta tests against the zope 2 trunk, I noticed a test failure that's not happening under zope 2.9: Error in test testHTML (Products.CMFDefault.tests.test_Document.DocumentFTPGetTests) Traceback (most recent call last): File /usr/lib/python2.4/unittest.py, line 260, in run testMethod() File /home/pw/Downloads/Apps/Net/z2-trunk/Products/CMFDefault/tests/test_Document.py, line 391, in testHTML ZopePageTemplate('source_html') ) File /home/pw/Downloads/Apps/Net/z2-trunk/lib/python/Products/PageTemplates/ZopePageTemplate.py, line 135, in __init__ self.pt_edit(text, content_type, encoding) File /home/pw/Downloads/Apps/Net/z2-trunk/lib/python/Products/PageTemplates/ZopePageTemplate.py, line 143, in pt_edit text = text.strip() AttributeError: 'NoneType' object has no attribute 'strip' This is because the semantics of ZopePageTemplate(id, text=None) have changed. It used to be that if text was None, the contents of www/default.html would be used. That no longer happends, and pt_edit can't accept None for the text. Was this intentional or is it a bug? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] bug in trunk ZopePageTemplate.py?
On Fri, Apr 07, 2006 at 09:50:06PM +0200, Andreas Jung wrote: --On 7. April 2006 15:37:38 -0400 Paul Winkler [EMAIL PROTECTED] wrote: This is because the semantics of ZopePageTemplate(id, text=None) have changed. It used to be that if text was None, the contents of www/default.html would be used. That no longer happends, and pt_edit can't accept None for the text. Was this intentional or is it a bug? Unlikely and it is likely a bug. Please put it into the collector. Since I have to complete my work on the Zope 3 ZPT integration for Zope 2.10 I'll try to fix that as soon as I can find some time. Done and assigned to you - both of you ;-) http://www.zope.org/Collectors/Zope/2064 -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Zope Test Summaries 2006-04-05
On Thu, Apr 06, 2006 at 10:45:11AM +0200, Stefan H. Holek wrote: The VHM tests in Zope 2.9 and trunk broke last night: http://mail.zope.org/pipermail/zope-tests/2006-April/004648.html http://mail.zope.org/pipermail/zope-tests/2006-April/004649.html I'm assuming this was me, but I ran test.py -q -all before checking in so I'm not sure how that happened. Investigating. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: What from zope.app are you using
On Wed, Apr 05, 2006 at 10:30:05PM +0200, Philipp von Weitershausen wrote: Paul Winkler wrote: Aside from stuff mentioned on your proposal, we are using macros from zope.app.rotterdam.standardmacros. Aha. Why? Are you actually using parts of the Rotterdam skin? Heh. Actually, a closer look reveals that we're not at all. In fact we're doing: from zope.app.rotterdam.standardmacros import StandardMacros as BaseMacros class StandardMacros(BaseMacros): macro_pages = ('common_macros', 'mydnanews_macros', 'main_template',) ... which means we get exactly nothing from using rotterdam, since rotterdam.standardmacros looks just like the above, it merely defines a different macro_pages tuple and imports the macros from basicskin. So in fact we're not using rotterdam at all, we're just using a single class that we could get from zope.app.basicskin rather than rotterdam. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Zope Test Summaries 2006-04-05
On Thu, Apr 06, 2006 at 12:06:25PM -0400, Paul Winkler wrote: On Thu, Apr 06, 2006 at 10:45:11AM +0200, Stefan H. Holek wrote: The VHM tests in Zope 2.9 and trunk broke last night: http://mail.zope.org/pipermail/zope-tests/2006-April/004648.html http://mail.zope.org/pipermail/zope-tests/2006-April/004649.html I'm assuming this was me, but I ran test.py -q -all before checking in so I'm not sure how that happened. Investigating. Must've run the tests in the wrong sandbox :-\ This failure was a side-effect of the changes I made: - The unit tests in Products/Session were polluting os.environ with SERVER_NAME and SERVER_PORT keys. - The unit tests in Products/SiteAccess were relying on the old behavior of Testing.makerequest to unconditionally set those keys in the request. - My change allowed the values from the Sessions tests to show up in the SiteAccess tests. I've fixed the Sessions tests to use a dict instead of os.environ. But I'm also concerned that similarly indirect breakage might happen in other projects if they use os.environ carelessly. This part of my change was an effort to remove redundancy, not a bugfix; so on second thought, given the demonstrated potential for breakage in other test suites, it doesn't belong on the stable 2.9 branch and I'll revert that change there. But I'll leave it on the trunk. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] makerequest issues
On Wed, Apr 05, 2006 at 11:48:31AM +0200, Stefan H. Holek wrote: Regarding your patch, why do you use lambda: () and not lambda: ('',)? Because that would change the path of the wrapped object, which is not a desirable side effect. Here's the behavior with my patch: from Testing.makerequest import makerequest from OFS.SimpleItem import SimpleItem item = SimpleItem(id='blah') # Wrapping an object with makerequest should not change its path. makerequest(app).getPhysicalPath() == app.getPhysicalPath() True makerequest(item).getPhysicalPath() == item.getPhysicalPath() True makerequest(item).getPhysicalPath() ('',) Now here's the behavior with your suggestion: from Testing.makerequest import makerequest from OFS.SimpleItem import SimpleItem item = SimpleItem(id='blah') makerequest(app).getPhysicalPath() == app.getPhysicalPath() True makerequest(item).getPhysicalPath() == item.getPhysicalPath() False item.getPhysicalPath() ('',) makerequest(item).getPhysicalPath() # uh-oh ('', '') -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] What from zope.app are you using
On Wed, Apr 05, 2006 at 05:29:41PM +0200, Philipp von Weitershausen wrote: I would like to know what other zope.app packages your 3rd party software is using. If thereare any other used than the ones mentioned in the proposal, we'll have to move them out of zope.app. I'd like to ask for your help on that, otherwise future Zope 2 versions might not anymore include the package you're using. Aside from stuff mentioned on your proposal, we are using macros from zope.app.rotterdam.standardmacros. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] makerequest issues
On Wed, Apr 05, 2006 at 11:23:40PM +0200, Stefan H. Holek wrote: Out of curiosity, you know that SimpleItem does not have a constructor? You just inherit the one from ExtensionClass.Base, which accepts everything and subsequently ignores it. So your item will have an empty id. This *may* be what you want so your physical path starts with '' instead of 'blah', but I'm not sure... I didn't know that. Thanks. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] makerequest issues
On Sat, Apr 01, 2006 at 01:07:35PM +0200, Stefan H. Holek wrote: I don't think makerequest is intended for wrapping anything but the root application object. Putting the RequestContainer on arbitrary objects doesn't feel right and certainly isn't how Zope does it, i.e. you get a test fixture that doesn't reflect reality. NotABug/WontFix ;-) Hmmm, but unit tests very often don't reflect reality - deliberately! Because reality is Too Much Stuff. Any other opinions on this? Do we really need to require an App at the root any time we want to acquire REQUEST? That seems kind of arbitrary to me when any acquisition-enabled object would do. I've inherited a test suite that has a lot of stuff like: parent = makerequest(Folder()) ... and I don't see anything wrong with that in principle, but if the concensus is that Stefan's right, I'll bow to that. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] makerequest issues
Stefan, do you have any insight into my first question? I wrote: 1) there is a makerequest function in both Testing/makerequest.py and Testing/ZopeTestCase/utils.py. They are subtly different. Is there a deliberate reason for this? I notice that ... (snip) the one in makerequest.py lacks an ACTUAL_URL. If there's no reason for the implementations to differ, I can delete one definition and just import the other in its place. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] makerequest issues
On Tue, Apr 04, 2006 at 08:09:05PM +0200, Stefan H. Holek wrote: This looks fine to me because the world ends at parent. Your earlier example wrapped an object that was in the middle of an acquisition chain (IIRC), no, I think you invented that :) which I am not sure I like. You are safe to wrap the top-most object, be it a true app or not. OK. In that case, 2057 really *is* a bug. http://www.zope.org/Collectors/Zope/2057 -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] makerequest issues
Several things: 1) there is a makerequest function in both Testing/makerequest.py and Testing/ZopeTestCase/utils.py. They are subtly different. Is there a deliberate reason for this? I notice that the one in utils.py lacks the recent fix for zope 3 views, and the one in makerequest.py lacks an ACTUAL_URL. 2) re. the bug which I just posted at http://www.zope.org/Collectors/Zope/2057 the issue is that if you have something that inherits Traversable, and wrap it with makerequest(), its getPhysicalPath() method is broken, because getPhysicalPath() tries to call getPhysicalPath() on all non-None aq_parents, and an HTTPRequest isn't Traversable. There are two possible fixes to that bug: I could hack around it in makerequest() by adding a fake getPhysicalPath(). I've uploaded a patch to the collector that does this. - or - I could change the conditional in Traversable.getPhysicalPath to look like so: def getPhysicalPath(self): ... p = aq_parent(aq_inner(self)) if p is not None and getattr(p, 'getPhysicalPath', None) is not None: path = p.getPhysicalPath() + path ... I was reluctant to do the latter because of two worries: a) I figured it's called all over the place and even slightly adding to its workload might negatively impact performance; the attached timeit script shows about a 15% slowdown in the method, however, I've not been able to measure any difference when hitting a default plone front page with ab. b) I don't know if there is code that relies on the current behavior of getPhysicalPath(), i.e. raise an AttributeError if p is something other than None but still lacks getPhysicalPath. I can't imagine a use case, but who knows... Opinions? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] makerequest issues
One small correction: On Fri, Mar 31, 2006 at 12:31:55PM -0500, Paul Winkler wrote: ... I notice that the makerequest in ZopeTestCase/utils.py lacks the recent fix for zope 3 views No, it has that fix; I accidentally looked at it on a 2.9.1 tarball rather than the trunk or 2.9 branch. The rest of the questions still stand. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] TCP CLOSE_WAIT leaks
On Thu, Mar 30, 2006 at 02:32:58AM +1000, Alan Milligan wrote: I managed to get a DeadlockDebugger trace on this thing, it made very interesting reading: (snip) File /opt/zope2.8/lib/python/ZEO/ClientStorage.py, line 781, in loadEx return data, tid, ver *every* thread was block-waiting on zeo (from a wide range of different Zope/Plone types)! It looks to me like Apache has timed out, clearing down it's end, Zope however is still having to wait for zeo which is completely borked. I've consequently ditched zeo and everything is again well-behaved. Is your zeo server on a separate box? Is there a firewall between them? The *only* time I've ever had problems like that was in the following scenario: * firewall between zope and zeo * minimal traffic at times (it was a secondary system, most of its usage was when our primary data center was down for maintenance) * firewall was of an evil type that tears down unused connections without either end being able to know it happened In this scenario, after suitably long period of no traffic between Zope and Zeo, the firewall would disconnect them but they would still think they were connected, and we would get a problem like yours. Dieter Maurer observed the same thing and gave me the hint that this might be the problem. Implementing his suggested keepalive product was less trouble than arguing with the firewall administrators. http://aspn.activestate.com/ASPN/Mail/Message/zope-list/2918584 I used something very close to that, I believe I just saved it as Products/ZeoKeepalive/__init__.py. (I've changed jobs so I'm going by memory.) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] TCP CLOSE_WAIT leaks
On Tue, Mar 28, 2006 at 10:44:09AM +1000, Alan Milligan wrote: Unfortunately, the server is out of threads and I can't use DeadlockDebugger to see what exactly Z2 thinks each thread is doing. Have you tried the gdb instructions that come up if you google debug spinning zope? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: PDBDebugMode 0.1 Release
On Tue, Mar 14, 2006 at 12:56:33PM -0500, Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ross Patterson wrote: http://www.zope.org/Members/rossp/PDBDebugMode PDBDebugMode - PDB post-mortem debugging on exceptions when debug-mode=on (snip) Way cool! What would you think about incorporating a version of this into the Zope2 core for version 2.10? I think we would need to add some additional ZConfig schema to support it, as the mere presence of the product would not be sufficient as an enabling knob (in fact, there mightn't be any product at all). If you're willing, I'd be glad to help land it (I think Z3 already has a similar feature, wired in as a separate server). I've only just tried PDBDebugMode, very handy since you don't have to put set_trace() in your code (and remember to remove it). I have also sometimes used Chris Withers' zdb product, http://www.simplistix.co.uk/software/zope/zdb, which has some overlap in that it allows you to do this in restricted code, e.g. cmf scripts: from Products.zdb import set_trace set_trace() ... and, very usefully, once in the debugger you can use the l command to see the script source and it gets line numbers right. So Ross, maybe you can borrow some of Chris' code :-) Unfortunately zdb doesn't appear to work with zope 2.9 / python 2.4. I'll file a bug report with Chris. It works great with zope 2.8 / python 2.3. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope3-dev] Principles
On Sun, Mar 05, 2006 at 10:09:14AM -0500, Geoff Davis wrote: One of the things that GTY recommends is to establish a set of agreed upon principles for evaluating proposals. I think that having such a set of principles would help us better focus our current discussion. Good idea. Let's take a step back from the particulars of the various proposals floating around and see if we can nail down some principles. Here is a very rough, very incomplete start: 1. Zope should have a clear message about where we are going. I'm sure we all agree on this, but this is so broad that it is not very useful. Here's a stab at refining it: 1.1 We should have a clear message about where Zope 2 is going. The message should give existing and prospective Zope 2 users an idea of how long their code will continue to work on releases in the Zope 2 path and what kind of upgrade process they will face as the Zope 2 line evolves. +1 1.2 Ditto for Zope 3. +1 2. Zope should try to expand its developer base. Again, I am sure we all agree, but this is too broad to be useful. 2.1 Zope should leverage the work of others by moving toward an architecture that allows one to easily use code from outside Zope. This effectively increases the developer base by letting us leverage the work of others outside the immediate Zope community. I assume that this (and integration) are the primary motivations driving the CA. 2.2 Zope should be useful for developers not using the full application server stack. Again, this serves to increase our developer base by drawing in people outside our traditional core audience. +1 We probably need some principles about the Zope brand, and so on, That seems like the most contentious part, and a lot of Jim's suggestions and the ensuing discussion have focused on this. There are several possible principles here, which may pull in different directions because they target different audiences. I started writing some suggested principles but I don't want to start another cycle of repetitious debate on that topic; I'd first rather see some more feedback on the principles you suggested so far. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Two visions
On Tue, Feb 28, 2006 at 12:31:33AM +0100, Philipp von Weitershausen wrote: I will also note that just because Zope 2 won't die, it doesn't mean we shouldn't clean it up. Eventually, Zope should mostly be reusing things from Zed. +sys.maxint I think this will be the way we get a real forward migration path for an awful lot of us who are still using Zope 2 today, and expect to continue doing so. We may or may not ever port to zope 3, whatever that will mean in the future. More likely we will just incrementally improve and clean up our applications, just as Zope 2 itself will be getting incrementally better and cleaner. We'll have to address deprecation warnings at each upgrade, but at no point will we be forced to do a complete rewrite. And along the way, we'll be gradually getting access to more and more nifty features. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Zope3-dev] Re: merge zope-dev and zope3-dev?
if we're voting, I'm +0. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Zope3-Users] Re: Nine new ZC Zope 3 packages on zope.org
On Fri, Feb 03, 2006 at 02:42:42PM -0500, Chris McDonough wrote: Kudos for releasing these packages -- they all look interesting and potentially useful. Agreed, bravo!! And there was much rejoicing. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: ZSyncer
On Wed, Feb 01, 2006 at 05:09:58PM -0800, Dennis Allison wrote: Just moved all our systems to ZSyncer 0.7.0 and have encountered a problem related to authentication. In our past setup, using ZSyncer 0.5.1, we use the ability to specify a user:password to provide a single authorization mechanism that could be used by all of our developers. Now we've stumbled onto the fact that ZSyncer 0.7.0 has eliminated the optin al user:password specification. Some of our users can use ZSyncer and others cannot. It's not clear what authorization is being used -- I suspect it is ownership, but I have not investigated. By default, it's the currently logged in user. This requires that the same user/password exist on the destination Zope as well. If you don't want to do that, you can specify it in the destination URLs. This is described in a couple places in README.txt. Advantage of this compared to the old way: You can use different user/passwd on each of several destination servers. (This was a use case for the guy that made the change). Disadvantage: The password is in cleartext in the ZSyncer configuration page in the ZMI. If that's a problem, be careful who is allowed access to that page :-) I'm not crazy about the latter, but it gives the needed flexibility and I haven't had time to create a UI that doesn't show it in cleartext. If somebody comes up with patches I'll happily apply them. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] traversable methods / docstrings.
On Mon, Jan 30, 2006 at 11:34:17AM +0100, Jean-Marc Orliaguet wrote: Hi! I didn't know that methods needed to have docstrings to be traversable (it took me some time to find out why I was getting Not found errors on some of a tool's methods). Is there any reason to still have such a feature in Zope2.9? or at least maybe there could be a hint in the trace log. I thought the docstring requirement only applied to publishing, not traversal per se? Do you get Not found when doing e.g. restrictedTraverse(some_path)? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope-2.9 r40780 make install doesn't finish, files missing from bin
On Thu, Dec 22, 2005 at 08:37:22AM +0100, Dario Lopez-K?sten wrote: +1 on this. It is important for us in the forced to be both developer and deployer by evil sysadmins camp. I'm one of those guys too. I'm sure I can learn to live with the 2.9 release layout but right now it's just confusing. I think one reason people are just now starting to complain is that we had no idea this change was coming. Checkouts don't look any different, so it was a bit of a surprise to see such a big change in the tarball. I'm sure this was discussed in some thread somewhere but it evidently didn't register for me. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Zope Book 2.7 edition
On Thu, Dec 22, 2005 at 09:59:54AM -0500, Chris McDonough wrote: Zope.org will need the latest version of BackTalk and CMFBackTalk installed (and by latest I wouldn't worry that they're too new to run on Zope.org, both are at least two years old). I would like to point out to whoever undertakes this task: You will want to cache the heck out of the backtalk pages. The index of sections is likely to be rather expensive. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] zope-2.9 r40780 make install doesn't finish, files missing from bin
On Thu, Dec 22, 2005 at 01:51:40PM -0500, Jim Fulton wrote: The tar ball looks the same (wrt configure/make/make install). It's the checkout that has changed. Ah, sorry, I was talking about directory layout, and that's a different question (and not really a big deal). Didn't mean to go off on a tangent. As you were -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] [RfC] Removal of old stuff in Zope 2.10
On Tue, Dec 20, 2005 at 07:52:02AM +0100, Andreas Jung wrote: Hi, for next release we plan to replace several parts with the corresponding components from Zope 3 (e.g. ZPT??). Philipp is working on a proposal on that issue. In addition I would like to get rid of some old stuff that is no longer maintained and buggy: - ZopeTutorial (could be ripped off without implications and made available for download on zope.org) +1 - HelpSys - from a programmers view pretty much useless and not very helpful. I consider to replace it with something more useful (not sure we can re-use apidoc from Zope 3 in some way, perhaps the inclusion of Dieter's Docfinder might be more useful for programmers) -0 Whenever this topic comes up, people speak of HelpSys as if it's all API documentation for programmers. In fact the lion's share of it is user-oriented online structured text documentation which is IMNSHO very good to have. And many third-party products provide such documentation of their own. Especially when I was new to Zope, I read them constantly. +1 that the API docs should be extracted from interfaces and should leverage zope3 technology. See my old proposal here: http://www.zope.org/DevHome/Wikis/DevSite/Proposals/SanitizeHelpSysAndAPIReference ... and the ensuing discussion: http://mail.zope.org/pipermail/zope-dev/2004-April/06.html Status of that proposal: I did a large portion of step 1 and step 5 in the 2.7 version of the Zope Book, but - as Dieter predicted - I ran out of steam long before finishing it. It's a tedious job, and I only got small amounts of help from a couple of volunteers. -1 on removing the structured text docs. I don't know if anybody actually was proposing to remove it, but since nobody mentions it, it's easy to conclude that :-) All this stuff will take work... Maybe we could have a doc sprint at pycon? - Gadfly(DA) - do we really need this? We discussed this already. In my opinion the purpose of Gadfly is only educational but nothing that one really needs or uses for production. It could be removed and made available for download on zope.org. +1 And my favourite enemy in Zope: ZClasses :-) I would like to mark them _clearly_ as an obsolete feature (DeprecationWarning, Warnings in the ZMI and the Zope Book). I _don't_ propose to remove them at some point but ppl should be aware that they are using one of the most-scary components in Zope (please no further discussion about the pros and cons of ZClasses..this discussion took already place already a bunch of times on the list). +1 -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] [RfC] Removal of old stuff in Zope 2.10
On Tue, Dec 20, 2005 at 12:27:41PM -0500, Chris McDonough wrote: I agree it would be helpful to have the info that's currently in the helpsystem for builtin Zope products be available somewhere else, though. I'm OK in principle with moving this stuff somewhere else, and with properly deprecating context.registerHelp(), but we do need a replacement strategy, and I don't agree that we can simply drop support for help in third-party products. It's not just builtin products that are affected. I also think that keeping it online is a good thing. It's very convenient and you don't have to worry about e.g. linux distributions getting funny with where they decide to place things like bundled documentation files, or free/budget zope hosting plans where you may not even have ready access to the filesystem. Maybe if we don't want to bundle them, we could host them in a versioned hierarchy on zope.org, like the way old versions of Python docs are always available on python.org. Of course, that puts some pressure on zope.org to be up and responsive all the time... that's another topic ;-P btw, I don't think we should keep shoe-horning the API docs and online user docs into the same UI. It doesn't feel like a good fit in the current system. Maybe the current Help! link should point only to user docs, and there should be a separate link to the new Interface docs? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] [RfC] Removal of old stuff in Zope 2.10
On Tue, Dec 20, 2005 at 01:24:32PM -0500, Paul Winkler wrote: Maybe if we don't want to bundle them, we could host them in a versioned hierarchy on zope.org, like the way old versions of Python docs are always available on python.org. ... which, duh, doesn't handle help for third-party products. So this is a non-solution. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] [RfC] Removal of old stuff in Zope 2.10
On Tue, Dec 20, 2005 at 08:13:18PM +0100, Andreas Jung wrote: --On 20. Dezember 2005 13:32:02 -0500 Paul Winkler [EMAIL PROTECTED] wrote: On Tue, Dec 20, 2005 at 01:24:32PM -0500, Paul Winkler wrote: Maybe if we don't want to bundle them, we could host them in a versioned hierarchy on zope.org, like the way old versions of Python docs are always available on python.org. ... which, duh, doesn't handle help for third-party products. So this is a non-solution. I mentioned already Apidoc from Z3. OK, but as I keep saying, that only covers half of the problem. One way would be to move the API descriptions of the Zope code into interface files (I don't know how much code in Zope has no interfaces so far... I have no idea, but there are already quite a lot of z3 interfaces in zope 2.9. As far as I can see Apidoc in Z3 gets its information from the registered components and their interfaces. Possibly we could replace the registration of a product with the HelpSys with *some* registry which might be used by Apidoc (Apidoc looks very generic). *Possibly* we could register the STX file with this registry as well ok... but as I said, I'm also wondering if help stx files should go in some parallel tree and not be mixed up with API docs at all. But maybe we could still leverage Apidoc for this tree somehow? I'm totally hand-waving here... just to be clear, the stuff I'm talking about is ZMI user interface docs, not programmer docs. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] [RfC] Removal of old stuff in Zope 2.10
On Tue, Dec 20, 2005 at 08:47:34PM +0100, Andreas Jung wrote: --On 20. Dezember 2005 14:27:18 -0500 Paul Winkler [EMAIL PROTECTED] wrote: just to be clear, the stuff I'm talking about is ZMI user interface docs, not programmer docs. I'll raise the question again: what are the benefits of the HelpSys for a Zope user? I just clicked through the HelpSys (I've never used and missed it throughout my Zope career) and all the unorganized information in the HelpSys are more or less in the same way available in the Zope Book (ZPT, DTML references etc.). The big difference is that in many places in the ZMI, clicking help takes you to instructions *for the management page you are actually looking at*. Just because you and I have internalized all this information long ago does not mean it isn't useful to new users. I haven't looked at any of it recently because I don't need to anymore. But I remember when I *did* need to. The users affected most by this change are not going to be on zope-dev. Maybe I was a rare case and nobody else ever reads the help pages. I don't think we will find out by arguing about it here. Maybe a straw poll on the main zope list would teach us something? Something like Did you, at some point while learning Zope, get anything useful from the help system?. - additional information and story telling should be done through doc tests For general what is this / what does it do / how does it work docs, I like that idea. But it doesn't help with filling out forms in the ZMI. Arguably, forms should be self-documenting, but the nice thing about a help link is that it doesn't distract you when you don't need it any more. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] [RfC] Removal of old stuff in Zope 2.10
On Tue, Dec 20, 2005 at 08:18:18PM +, Jens Vagelpohl wrote: I would say the only benefit was the unification of docs for Zope and installed third party products in one place, Good point! and its context- sensitivity for documenting screens in the ZMI when you're on them by clicking the link. I've always tried to be good about it, and most of my software has relatively up-to-date HelpSys documentation. Me too. On the other hand I believe most product authors don't use HelpSys documentation, and the Zope-provided pieces are way less current and informative than the Zope book (2.7 version). Yes. I think we as a community have a general documentation maintenance problem. It is something that neither ZC nor the community at large has placed sufficient value on - understandably! Free docs don't pay anybody's bills. There needs to be a driving force here stronger than it would be nice to have better docs, or there never will be. Maybe once the Zope Foundation is up and running, I will propose that the Foundation play a role. Maybe fundraising and earmarking funds for doc work would help. (... oh crap, I forgot about the foundation chat today. Probably would have been OT at this stage anyway.) IMHO it would be nice if the HelpSys could be changed so that it still provides those Help! links, but the product author can simply assign a URL to them to point to a place where they copied and pasted their docs into a website. That's not too much of an imposition on product authors I think. I think that would work. If so, the question then becomes: timetable and plan for deprecating HelpSys. I don't think we can simply rip out registerHelp() in 2.10 unless we have deprecation warnings in 2.9; and a useful deprecation warning requires something in place we can advise people to do instead. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] [RfC] Removal of old stuff in Zope 2.10
On Tue, Dec 20, 2005 at 03:58:05PM -0500, Chris McDonough wrote: FWIW, I have zero plans to support a registerHelp that does anything but pass or warn for Egg products. If people think that isn't a reasonable thing to do, I may need to take my committment to integrating eggs off the table for 2.10 personally; of course others would be free to take the existing code and integrate. IOW, I intend to spend exactly zero brain cycles thinking about help system issues except to make it inoperable. ;-) Hmm... Since eggs are a relatively new distribution mechanism, it doesn't make sense for basket (or whatever it evolves into) to waste effort on supporting old crap that's going away sooner or later. But I'm not sure I understand you. Are you saying that in order to use Basket, my product can't call registerHelp()? Or are you saying that when installed via Basket, registerHelp() does nothing? That's fine. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] make test fails on 2.9.0-b1?
On Mon, Dec 12, 2005 at 05:40:27AM +0100, Andreas Jung wrote: The build process changed in 2.9. Perhaps make inplace; make test should work. -aj Good thought, but there is no inplace target anymore. What is now the canonical way of running tests in a release tarball? Is there one? -PW -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Imports broken on 2.9.0-b1?
On Mon, Dec 12, 2005 at 07:57:43AM +0100, Tino Wildenhain wrote: I suspect its the feature which got introduced in 2.8? or so which has a browser for packets to import so you dont have to guess and type the name correctly. And to not have to copy the exaples to every instance home, it looks in Software-home too. Yes, apparently so. 2 questions araise, though: 1) why is Softwarehome/import not there? I suspect that it's supposed to be created by make install by copying the one in skel; I don't yet know why it's not, will investigate. make install under 2.7.x and 2.8.x used to do this. Incidentally, this raises the point that some included docs are out of date. I'll file a separate collector issue about that, since I can't figure out what they're supposed to say now so I can't fix them ;-) 2) why is the test not skipping the non existant directory. #2 is trivial, I will check in a fix as soon as I figure out a test to demonstrate the issue. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: make test fails on 2.9.0-b1?
On Mon, Dec 12, 2005 at 04:54:24PM +0100, Philipp von Weitershausen wrote: Andreas Jung wrote: The build process changed in 2.9. Perhaps make inplace; make test should work. He explicity said in a tarball. make inplace only exists in SVN. As a reminder: SVN repo != release tarball I know it's always been '==' for every other Zope 2 version, but 2.9 is different because it's packaged by zpkgutils. Aha, that explains a lot of things. Thanks. This complicates docs somewhat. Not sure how we can handle this. We may need to change doc/INSTALL.txt to include separate instructions for SVN checkouts vs. tarball releases. Filed here: http://www.zope.org/Collectors/Zope/1967 -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: make test fails on 2.9.0-b1?
On Mon, Dec 12, 2005 at 05:01:35PM +0100, Philipp von Weitershausen wrote: I guess it should use zope.testing.testrunner instead of zope.app.testing.test, though I'm not sure how the parameters and options convert. I don't think that's the problem: [EMAIL PROTECTED] Zope-2.9-branch $ svn up test.py At revision 40739. [EMAIL PROTECTED] Zope-2.9-branch $ grep import test.py import os.path, sys from zope.testing import testrunner import Zope2 [EMAIL PROTECTED] Zope-2.9-branch $ make test /usr/bin/python /home/pw/Downloads/Apps/Net/Zope-2.9-branch/setup.py \ build_ext -i running build_ext running build_headers /usr/bin/python /home/pw/Downloads/Apps/Net/Zope-2.9-branch/test.py -v Traceback (most recent call last): File /home/pw/Downloads/Apps/Net/Zope-2.9-branch/test.py, line 83, in ? from zope.testing import testrunner ImportError: No module named zope.testing make: *** [test] Error 1 Looks to me like it's a simple PYTHONPATH problem: [EMAIL PROTECTED] Zope-2.9-branch $ export PYTHONPATH=$PYTHONPATH:/home/pw/Downloads/Apps/Net/Zope-2.9-branch/lib/python/ [EMAIL PROTECTED] Zope-2.9-branch $ make test /usr/bin/python /home/pw/Downloads/Apps/Net/Zope-2.9-branch/setup.py \ build_ext -i running build_ext running build_headers /usr/bin/python /home/pw/Downloads/Apps/Net/Zope-2.9-branch/test.py -v Running tests at level 1 /usr/lib/python2.4/whrandom.py:38: DeprecationWarning: the whrandom module is deprecated; please use the random module DeprecationWarning) /home/pw/ZopeSoftwareHome/lib/python/SearchIndex/__init__.py:19: DeprecationWarning: The usage of the SearchIndex package is deprecated since Zope 2.4. This package is only kept for backwards compatibility for a while and will go away in a future release. Please use instead the re-factored modules in Products/PluginIndexes. warnings.warn(The usage of the SearchIndex package is deprecated since \ Test-module import failures: Module: BDBStorage.tests.testall TypeError: Invalid test_suite, None, in BDBStorage.tests.testall Running unit tests: Running: .. .. (snip etc.) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: make test fails on 2.9.0-b1?
On Mon, Dec 12, 2005 at 12:43:35PM -0500, Paul Winkler wrote: Looks to me like it's a simple PYTHONPATH problem: (snip) OK, is Makefile.in the right place to fix that? This patch seems to work: [EMAIL PROTECTED] Zope-2.9-branch $ svn diff inst/Makefile.in Index: inst/Makefile.in === --- inst/Makefile.in(revision 40735) +++ inst/Makefile.in(working copy) @@ -80,7 +80,7 @@ # test:Do an inplace build and run the Zope test suite. test: inplace - ${PYTHON} ${BASE_DIR}/test.py ${TESTOPTS} + PYTHONPATH=${PYTHONPATH}:${BASE_DIR}/lib/python ${PYTHON} ${BASE_DIR}/test.py ${TESTOPTS} # clean: Delete the build files and any binaries/bytecode files # in # the source directory for good measure. But I do get some odd output - what's this about BDBStorage at the end? [EMAIL PROTECTED] Zope-2.9-branch $ make test /usr/bin/python /home/pw/Downloads/Apps/Net/Zope-2.9-branch/setup.py \ build_ext -i running build_ext running build_headers PYTHONPATH=/usr/lib/portage/pym:/usr/local/lib/python:/usr/local/lib/python/piddle:/home/pw/bin/python:/home/pw/Downloads/Apps/Net/Zope-2.9-branch/lib/python /usr/bin/python /home/pw/Downloads/Apps/Net/Zope-2.9-branch/test.py -v Running tests at level 1 (snip) Ran 1432 tests with 0 failures and 0 errors in 283.344 seconds. Test-modules with import problems: BDBStorage.tests.testall make: *** [test] Error 1 -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: make test fails on 2.9.0-b1?
Just to clarify - sorry for confusing the issue (and myself): There are two separate problems here. make test doesn't work in a sandbox *or* a release tarball. The patch below addresses only the former. Phillip is right about the latter, it's got a broken import. -PW On Mon, Dec 12, 2005 at 12:52:24PM -0500, Paul Winkler wrote: On Mon, Dec 12, 2005 at 12:43:35PM -0500, Paul Winkler wrote: Looks to me like it's a simple PYTHONPATH problem: (snip) OK, is Makefile.in the right place to fix that? This patch seems to work: [EMAIL PROTECTED] Zope-2.9-branch $ svn diff inst/Makefile.in Index: inst/Makefile.in === --- inst/Makefile.in(revision 40735) +++ inst/Makefile.in(working copy) @@ -80,7 +80,7 @@ # test:Do an inplace build and run the Zope test suite. test: inplace - ${PYTHON} ${BASE_DIR}/test.py ${TESTOPTS} + PYTHONPATH=${PYTHONPATH}:${BASE_DIR}/lib/python ${PYTHON} ${BASE_DIR}/test.py ${TESTOPTS} # clean: Delete the build files and any binaries/bytecode files # in # the source directory for good measure. But I do get some odd output - what's this about BDBStorage at the end? [EMAIL PROTECTED] Zope-2.9-branch $ make test /usr/bin/python /home/pw/Downloads/Apps/Net/Zope-2.9-branch/setup.py \ build_ext -i running build_ext running build_headers PYTHONPATH=/usr/lib/portage/pym:/usr/local/lib/python:/usr/local/lib/python/piddle:/home/pw/bin/python:/home/pw/Downloads/Apps/Net/Zope-2.9-branch/lib/python /usr/bin/python /home/pw/Downloads/Apps/Net/Zope-2.9-branch/test.py -v Running tests at level 1 (snip) Ran 1432 tests with 0 failures and 0 errors in 283.344 seconds. Test-modules with import problems: BDBStorage.tests.testall make: *** [test] Error 1 -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope ) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: make test fails on 2.9.0-b1?
On Mon, Dec 12, 2005 at 01:08:16PM -0500, Paul Winkler wrote: Phillip is right about the latter, it's got a broken import. OK, I have a patch for make test that allows it to at least run, but with lots of test errors. I think I will have to pass on this one and leave it to somebody who's more familiar with the new test runner. Collector issue is here: http://www.zope.org/Collectors/Zope/1968 -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] New testrunner is confusing the heck out of me
I'm assuming this is operator error, but I can't make head nor tail of the following (in a zope 2 trunk sandbox). Note the number of tests run by each command: [EMAIL PROTECTED] Zope-Trunk $ python lib/python/OFS/tests/testObjectManager.py .No handlers could be found for logger Zope . -- Ran 22 tests in 7.545s OK [EMAIL PROTECTED] Zope-Trunk $ python test.py --all -m testObjectManager Running tests at all levels /usr/lib/python2.4/whrandom.py:38: DeprecationWarning: the whrandom module is deprecated; please use the random module DeprecationWarning) Running unit tests: Running: Ran 12 tests with 0 failures and 0 errors in 0.010 seconds. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] New testrunner is confusing the heck out of me
On Mon, Dec 12, 2005 at 03:31:08PM -0500, Paul Winkler wrote: I'm assuming this is operator error And so it was. I had SOFTWARE_HOME set pointing to a 2.7 installation! remembering-to-check-what-crap-is-in-my-environment-next-time-ly-y'rs, -PW -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Imports broken on 2.9.0-b1?
On Mon, Dec 12, 2005 at 06:05:48PM +0100, Philipp von Weitershausen wrote: I think supporting $SOFTWARE_HOME/import is yagni and just complicates things. Let's rip it out. I'm gonna punt on that: I can imagine hosting providers might be using that feature already, and I do'nt feel like doing the research to find out. Feel free to write a proposal :-) Meanwhile, I've fixed the trivial error with list_imports() and I'm checking it in on trunk and 2.9 in a moment. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] make test fails on 2.9.0-b1?
Sorry for redundancy if this is a known problem, but I just now grabbed the 2.9.0-b1 tarball and noticed this: [EMAIL PROTECTED] Zope-2.9.0b1 $ ./configure --prefix=/home/pw/Zope-2.9.0b1-SoftwareHome Configuring Zope installation Testing for an acceptable Python interpreter... Python version 2.4.2 found at /usr/bin/python The optimum Python version (2.4.2) was found at /usr/bin/python. [EMAIL PROTECTED] Zope-2.9.0b1 $ less Makefile [EMAIL PROTECTED] Zope-2.9.0b1 $ make make test make install /usr/bin/python install.py -q build /usr/bin/python install.py -q build /usr/bin/python test.py -v Traceback (most recent call last): File test.py, line 32, in ? import zope.app.testing.test ImportError: No module named test make: *** [test] Error 1 Is make test expected to work currently? -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Please vote about conflict errors logging
On Fri, Dec 09, 2005 at 03:45:18PM +0100, Florent Guillaume wrote: So I propose another little change: have the error_log copy to event.log be the default behaviour. Today the default is off. +100 -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] New testrunner on the Zope 2 trunk.
On Tue, Oct 25, 2005 at 03:13:11PM -0400, Jim Fulton wrote: I just checked in a new test runner on the trunk. It is mostly backward compatible with the old test runner. You can get help on the test runner by running it with -h. There is more extensive documentation in lib/python/zope/testing/testrunner.txt. Somewhere I believe you said that the new testrunner is backward-compatible with the old testrunner's positional arguments used as regexes for matching modules. Not a big deal to me, but AFAICT this is not true with a current Zope2 trunk sandbox: [EMAIL PROTECTED] Zope-Trunk $ ./bin/zopectl test -m AcceleratedHTTP.* Running tests via: /usr/bin/python /home/pw/Downloads/Apps/Net/Zope-Trunk/test.py -v --config-file /home/pw/Downloads/Apps/Net/Zope-Trunk/etc/zope.conf -m AcceleratedHTTP.* Parsing /home/pw/Downloads/Apps/Net/Zope-Trunk/etc/zope.conf Running tests at level 1 Running unit tests: Running: . Ran 1 tests with 0 failures and 0 errors in 0.246 seconds. [EMAIL PROTECTED] Zope-Trunk $ ./bin/zopectl test AcceleratedHTTP.* Running tests via: /usr/bin/python /home/pw/Downloads/Apps/Net/Zope-Trunk/test.py -v --config-file /home/pw/Downloads/Apps/Net/Zope-Trunk/etc/zope.conf AcceleratedHTTP.* Parsing /home/pw/Downloads/Apps/Net/Zope-Trunk/etc/zope.conf Running tests at level 1 Running unit tests: Running: .. (snip) Ran 4336 tests with 0 failures and 0 errors in 399.069 seconds. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: AcceleratedHTTPCache and virtual hosting (collector 1447)
On Sat, Dec 03, 2005 at 11:29:48AM -0500, Tres Seaver wrote: Paul Winkler wrote: (snip) ... AcceleratedHTTPCacheManager has no test suite at all. Erm. Actually it does; Tres added it on the TRUNK many months ago. I was looking at a 2.7 checkout! Mea culpa. However, the test suite currently *does* fire up an HTTP server (on a hardwired port, 1888). As I said, I'm not crazy about this, it seems needlessly fragile and makes the test code harder to read than I'd like. So I'm inclined to follow Tres' adapter suggestion, it seems like The Right Thing to me. I'll modify the existing suite accordingly on a branch. To the other respondents: Thanks for the suggestions, but I do not consider making AcceleratedHTTPCacheManager more flexible to be a test turd. Tres outlined a real use case for changing the code (see below). I don't understand why you guys consider this more invasive than monkeypatching, which is capable of causing obscure breakage in far-flung tests. But thanks anyway. You could modify the testing code do an adapter lookup for a component used to do the HTTP client stuff, and then arrange to register your dummy object in a test. I imagine that this would be useful for more than just testing; for instance, if I want to purge a whole tier of Squids, right now the only way to do that is to write a proxy-proxy (one version I wrote once was called PageAssassin) which distributes the PURGE request to them. An adapter-based scheme would allow me to replace the stock version with one which distributed the PURGE directly. Tres. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] AcceleratedHTTPCache and virtual hosting (collector 1447)
Hi folks, need some advice here. http://www.zope.org/Collectors/Zope/1447 (AcceleratedHTTPCacheManager doesn't PURGE correctly for virtual hosts) has been assigned to me like forever, and I've determined to not let another year go by with this one unfixed ;-) I'd like to apply the patch and commit, once I'm sure it works correctly, but - drumroll - AcceleratedHTTPCacheManager has no test suite at all. Which means, as frequently happens with Zope 2, I have to go through the pain of setting up a test suite for the current behavior before I go changing anything. The fun thing about this is that AcceleratedHTTPCache uses httplib to send purge notifications. I don't fancy launching a dummy server of some sort. So, I'm asking for advice: How in general does one go about setting up a unit test for network client code? One thought that occurs to me is to replace httplib.HTTPConnection with a mock object of some sort that allows easy verification of its input. So we assume that httplib works, as a proper unit test should I think. How to do this? One idea is to monkeypatch httplib during the course of the test case, and replace and then when the test finishes, restore the old httplib.HTTPConnection. But this idea smells pretty bad to me. Another thought: Maybe before doing anything else, I should make the client class used by AcceleratedHTTPCache configurable, so I can more easily get a mock in there. Something like: class AcceleratedHTTPCache (Cache): client_class = httplib.HTTPConnection ... def ZCache_invalidate(self, ob): ... h = self.client_class(host) ... Then I can just do something like this during afterSetUp(): cache = AcceleratedHTTPCache() cache.client_class = MockHTTPConnection Any better ideas? testing-network-stuff-hurts-my-head-ly-yrs, -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Logging of ConflictError
On Fri, Dec 02, 2005 at 02:09:56PM +0100, Florent Guillaume wrote: On 2 Dec 2005, at 11:09, Chris Withers wrote: I was planning on rolling my changes out to 2.8, 2.9 and the trunk. Unless anyone strenuously objects, I still intend to do that. I cleaned up a lot of the code and made a few other changes that generally improve logging. I strenuously object to you overwriting without consultation code I just checked in and that was approved by at least 3 people. I'm +1 on having failed retries show up at level ERROR. I'm neutral on having successful retries show up at level INFO, BLATHER, or in some other log handler entirely. Conflict errors are a pretty small part of my world and I don't really have a strong opinion on this part of the debate, and I don't have time to review either of your patches. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Logging of ConflictError
On Thu, Dec 01, 2005 at 02:03:51PM -0500, Tres Seaver wrote: Do people want this also for 2.8? Note that it changes the log format, so may break third party tools that parse logs. +1. +1 from me too, the added information is worth potential tool breakage IMO. Just put an obvious note in CHANGES.txt as usual. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Zope3-dev] RFC: Reunite Zope 2 and Zope 3 in the source code repository
On Thu, Nov 24, 2005 at 11:03:35PM +0800, Philipp von Weitershausen wrote: I'd love to participate in some sprints on these. Me too. PyCon Dallas 2006 is only 3 months away and would be a great opportunity for such sprints. There's nothing about Zope here yet: http://wiki.python.org/moin/PyCon2006/Sprints I plan to attend and I would really love to sprint on further fivification of zope 2. p.s. No, I can't volunteer to do any coordination work for this. I'll already have plenty to do preparing for my two (Five-related) talks. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: [Zope3-dev] RFC: Reunite Zope 2 and Zope 3 in the source code repository
On Thu, Nov 24, 2005 at 06:59:46PM +0100, Martijn Faassen wrote: Cool to hear you're giving Five related talks. Is there any description of these available online? (not that it's likely I'll be able to attend PyCon, but I'm very curious) http://wiki.python.org/moin/PyCon2006/Talks They're just basic How to develop with Zope and ...CMF talks, with as much Five as I can squeeze in since it's 2006 and it would be criminal to ignore it :-) I will not even remotely attempt to be comprehensive or deep. It will be very challenging to work in the short time slots alotted! I was a bit surprised that both talks were accepted, I figured I'd be trumped by presentations from better-known people, but maybe there weren't any! -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Bad security declarations
On Mon, Nov 21, 2005 at 01:24:52AM +0100, Florent Guillaume wrote: I've added a long-needed warning if you attempt to make a security declaration for a nonexistent method, usually because of typos. Checked in for 2.8, 2.9 and trunk. You are my hero :-) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: Running all unittests in $INSTANCE_HOME
On Fri, Nov 18, 2005 at 08:43:24AM -0500, Tres Seaver wrote: Chris Withers wrote: Paul Winkler wrote: ./bin/zopectl test is supposed to do the job. But in practice, so many third-party product tests either have broken dependencies or pollute the test environment somehow that something always breaks. bin/zopectl test Products/MyProduct ...has worked fine for me for many months now... Hmm, that should be a dotted name, rather than a path: $ bin/zopectl test Products.MyProduct Because the first argument is interpreted as a regex, using search, you can leave the 'Product.' bit off, as well as supplying more complicated specifications, e.g.: $ bin/zopectl test OneProduct|AnotherProduct Thanks for the hints, guys. The latter form seems to need quoting, at least under bash, to avoid the shell treating it as a pipe. So it would be $ bin/zopectl test OneProduct|AnotherProduct Anyway, my point is, you often can't just run everything because stuff breaks. And even with the Foo|Bar pattern, stuff still sometimes breaks, due to test environment pollution or other nastiness. The current worst offender I have installed is ZWiki 0.47 which kills the entire test run if it's installed, no matter what you give for the regex. I have no idea how it does that and yet manages to run just fine when you start Zope. Minor annoyances come from products like AdvancedQuery 0.6 whose tests depend on other packages that the product itself does not depend on, but at least it doesn't affect the rest of the test run. Example: [EMAIL PROTECTED] NavCodeInstanceHome $ ./bin/zopectl test Products.BTreeFolder2 /usr/lib/python2.4/whrandom.py:38: DeprecationWarning: the whrandom module is deprecated; please use the random module DeprecationWarning) Running tests via: /usr/bin/python /home/pw/Zope-2.7.7-final/bin/test.py -v --config-file /home/pw/NavCodeInstanceHome/etc/zope.conf --libdir Products Products.BTreeFolder2 Running unit tests at level 1 Running unit tests from /home/pw/NavCodeInstanceHome/Products Parsing /home/pw/NavCodeInstanceHome/etc/zope.conf /usr/lib/python2.4/whrandom.py:38: DeprecationWarning: the whrandom module is deprecated; please use the random module DeprecationWarning) Traceback (most recent call last): File /home/pw/Zope-2.7.7-final/bin/test.py, line 918, in ? process_args() File /home/pw/Zope-2.7.7-final/bin/test.py, line 908, in process_args bad = main(module_filter, test_filter, libdir) File /home/pw/Zope-2.7.7-final/bin/test.py, line 677, in main files = find_tests(module_filter) File /home/pw/Zope-2.7.7-final/bin/test.py, line 478, in find_tests walk_with_symlinks(pathinit.testdir, finder.visit, rx) File /home/pw/Zope-2.7.7-final/bin/test.py, line 628, in walk_with_symlinks walk_with_symlinks(name, visit, arg) File /home/pw/Zope-2.7.7-final/bin/test.py, line 628, in walk_with_symlinks walk_with_symlinks(name, visit, arg) File /home/pw/Zope-2.7.7-final/bin/test.py, line 622, in walk_with_symlinks visit(arg, path, names) File /home/pw/Zope-2.7.7-final/bin/test.py, line 458, in visit __import__(pkg) File /home/pw/NavCodeInstanceHome/Products/ZWiki/__init__.py, line 12, in ? import ZWikiPage, ZWikiWeb, Permissions, Defaults, OutlineSupport File /home/pw/NavCodeInstanceHome/Products/ZWiki/ZWikiPage.py, line 87, in ? DEFAULT_PAGETYPE = PAGETYPES[0] IndexError: list index out of range -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Running all unittests in $INSTANCE_HOME
On Thu, Nov 17, 2005 at 02:33:10PM -0200, Sidnei da Silva wrote: I might have asked this before, but can't seem to find it. I'm looking for a way to run all tests in $INSTANCE_HOME using the test.py script, but can't seem to get the majik combination of parameters together. Would anyone hint me? You mean your product unit tests? I've never been able to do this in practice. ./bin/zopectl test is supposed to do the job. But in practice, so many third-party product tests either have broken dependencies or pollute the test environment somehow that something always breaks. The --dir option helps, but unfortunately you can only give it once (or rather, only the last one given matters). -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Reminder: feature freeze November 1.
On Sun, Nov 13, 2005 at 02:55:22PM -0500, Chris McDonough wrote: Of course the release manager should have the last say and as the release manager it's totally valid for Andreas to delete the branch. Apologies for taking initiative. I was really just trying to unstick Paul and get things rolling again. Thanks Chris, I didn't mean for you to get you in hot water. And thanks Jim for directly answering my question, which is really all I needed :) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Reminder: feature freeze November 1.
On Tue, Oct 18, 2005 at 07:21:08AM -0400, Jim Fulton wrote: This is a reminder that there will be a feature freeze for the December Zope releases on November 1. OK. I thought there was going to be a 2.9 branch by now, but I don't see one. Is the trunk totally frozen now or what? Is it too late to land my long-forgotten configure changes as discussed at http://mail.zope.org/pipermail/zope/2004-July/151839.html ? This would allow multiple preferred versions of Python when a bugfix release of python comes out - so we don't do something silly like advise people to downgrade from a perfectly good 2.4.x to 2.4.(x-1). I negligently never merged my branch, forgot about it, and only remembered it when Florent nudged us to clean up old branches. I have a local zope 2 trunk sandbox with my changes hand-merged into configure, but my branch is so ancient that I think I should delete it and start over. -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Can't fetch externals???
I'm trying to fix a bug assigned to me, and for some reason I can use svn to make and check out my branch but it fails when fetching externals. Anybody else seen this? [EMAIL PROTECTED] tmp]$ svn co svn+ssh://[EMAIL PROTECTED]/repos/main/Zope/branches/slinkp-collector_1895 A slinkp-collector_1895/Extensions A slinkp-collector_1895/Extensions/README.txt A slinkp-collector_1895/log.ini A slinkp-collector_1895/configure A slinkp-collector_1895/doc (SNIP) A slinkp-collector_1895/skel/README.txt U slinkp-collector_1895 Checked out revision 38707. Fetching external item into slinkp-collector_1895/doc/ZEO svn: Connection refused svn: Can't connect to host 'svn.zope.org' And then I get the same thing if I do svn up: [EMAIL PROTECTED] tmp]$ cd slinkp-collector_1895/ [EMAIL PROTECTED] slinkp-collector_1895]$ svn up At revision 38707. Fetching external item into doc/ZEO svn: Connection refused svn: Can't connect to host 'svn.zope.org' -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Can't fetch externals???
btw, I'm in #zope-dev right now if anybody wants to chat about this. -PW Paul Winkler said: I'm trying to fix a bug assigned to me, and for some reason I can use svn to make and check out my branch but it fails when fetching externals. Anybody else seen this? (snip) -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Can't fetch externals???
Update: I *can* fetch the externals from a different box (my windows laptop, on which i can't successfully build zope because cygwin's python is known-broken and I don't have a C compiler other than cygwin's.) But when I ssh to a linux box (on which building works fine), I get the problem described in my first post. REALLY weird and annoying. Tino W. hopped into #zope-dev and helped for a bit but we didn't find a solution. One thing Tino suggested: it might be a firewall issue. Does svn's externals-fetching look somehow different to a firewall than does a regular (non-external) checkout? When I tried checking out on my laptop, I noticed that ZoneAlarm asked 'me if I wanted to allow svn.exe to use the internet at exactly the moment that it was time to fetch the externals. Weird - doesn't it still use ssh? What's different? -PW Paul Winkler said: btw, I'm in #zope-dev right now if anybody wants to chat about this. -PW Paul Winkler said: I'm trying to fix a bug assigned to me, and for some reason I can use svn to make and check out my branch but it fails when fetching externals. Anybody else seen this? (snip) -- Paul Winkler http://www.slinkp.com -- Paul Winkler http://www.slinkp.com ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )