The proposal to merge lp:~zorba-coders/zorba/jsound-validator into lp:zorba has
been updated.
Status: Approved => Work in progress
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/jsound-validator/+merge/186908
--
https://code.launchpad.net/~zorba-coders/zorba/jsound-va
The proposal to merge lp:~zorba-coders/zorba/jsound-validator into lp:zorba has
been updated.
Status: Approved => Work in progress
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/jsound-validator/+merge/186908
--
https://code.launchpad.net/~zorba-coders/zorba/jsound-va
The proposal to merge lp:~zorba-coders/zorba/jsound-validator into lp:zorba has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/jsound-validator/+merge/186908
--
https://code.launchpad.net/~zorba-coders/zorba/jsound-valida
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/jsound-validator/+merge/186908
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zor
This looks obsolete, as this is now in the Zorba trunk.
--
https://code.launchpad.net/~zorba-coders/zorba/array-unboxing/+merge/168099
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsu
The proposal to merge lp:~zorba-coders/zorba/array-unboxing into lp:zorba has
been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/array-unboxing/+merge/168099
--
https://code.launchpad.net/~zorba-coders/zorba/array-unboxing/+m
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq-update into lp:zorba
has been updated.
Commit Message changed to:
Introducing new update syntax in the JSONiq parser.
- Made json keyword mandatory to avoid conflicts.
- Turned "replace json value of" into "replace value of json" to make
c
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zo
After looking more in depth, I realized that there is an inconsistency across
parsenodes. Some of them have const exprnode* pointers on their children (like
JSONObjectLookup had), some others regular exprnode* pointers (like
JSONObjectLookup has now). The latter seem to correspond to places that
Hi Matthias,
I am not sure I understand what you are suggesting.
The reason for non-const is that temporary parse nodes (in that case a lookup
expression node) use regular pointers that they own to child parse nodes, i.e.,
the destructor deletes the object pointed to at the end. However, these
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Commit Message changed to:
Regenerating pregenerated parser and scanner files (last bug fix was not
reflected).
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your t
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Commit Message changed to:
Copying pregenerated parser and scanner files over.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
--
https://code.launchpad.net/~z
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Commit Message changed to:
A fix for a bug discovered with the 28msec merge.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
--
https://code.launchpad.net/~zor
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your t
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your t
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your t
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Review: Approve
LGTM
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba
This is still work in progress, but you can already begin to take a look :-)
--
https://code.launchpad.net/~zorba-coders/zorba/new-update-syntax/+merge/184308
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders
Thanks Nicolae!
The following does not seem to work:
jsoniq version "1.0";
variable $a := [];
insert (1, 2) into $a at position 1;
$a
It might be because insert(1, 2) is parsed as a function call. Would it be
possible to resolve the conflict using the lookahead (whether "into" is here or
no
The proposal to merge lp:~zorba-coders/zorba/new-update-syntax into lp:zorba
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-update-syntax/+merge/184308
--
https://code.launchpad.net/~zorba-coders/zorba/new
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1189804/+merge/182529
Your team Zorba Coders is subscribed to branch lp:zorba/html-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https:/
Review: Needs Fixing
Hi Nicolae,
Looks good, thanks ;-) It's getting closer and closer to the git EBNFs!
Here are some comments:
1. Parser.y, line 2259: is "|| (block != NULL && block->isEmpty())" really
needed? Will block not always be null if a BlockExpr is {} (see
StatementsAndOptionalExpr
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189804/+merge/181973
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-co
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/disable_assert-invariant/+merge/182971
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.
Review: Needs Fixing
Looks good! Here are some comments:
- Did you check that the invalid option type error does not exist already? Will
it be consistent also in all other modules?
- Should JSONiq modules not be suffixed as .jq (but it's only cosmetics of
course).
- empty-sequence() -> ()
- arr
One of the tests uses ext:nomaterialization without dash. Is this intented?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.l
Review: Approve
It works like a charm!
--
https://code.launchpad.net/~zorba-coders/zorba/jdbc-mariadb-driver/+merge/177036
Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Uns
My remark would correspond to your first choice: offset/limit is just a
syntactic sugar, and count$i-where$i is optimized separately.
--
https://code.launchpad.net/~zorba-coders/zorba/skiplimit/+merge/173126
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://laun
Hi William,
I think that count$i-where$i aka offset/limit can be optimized, but in most
cases not in terms of subsequence: it sets an offset or a limit on the number
of tuples, not on the number of items (a tuple may well produce zero, or more
than one item in the end). I think that an early ex
Review: Needs Fixing
--
https://code.launchpad.net/~zorba-coders/zorba/skiplimit/+merge/173126
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba
I have the feeling that this could and should be made more general, i.e.,
introduce "limit" ExprSingle and "offset" ExprSingle as regular FLWOR clauses,
like any other clauses, that you can put everywhere (as intermediate clauses),
and that are syntactic sugars for "count $i where $i le ExprSing
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824
Your team Zorba Coders is subscribed to branch lp:zorba/process-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix_ace/+merge/170855
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169270
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169270
Your team Zo
Review: Approve
It works, thanks!
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169270
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.n
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169221
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169221
Your team Zo
Review: Approve
Perfect, thanks Paul!
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/169221
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launch
The parser must be regenerated I think.
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://la
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Rejected => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Approved => Rejected
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/null-type-fix/+merge/163902
Your team Zorba Coders is subscribed to branch
lp:~zorba-coders/zorba/new-jsoniq.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : htt
Pending approval and merge of null-type-fix before sending to the trunk.
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.laun
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/null-type-fix into
lp:~zorba-coders/zorba/new-jsoniq.
Commit message:
Fixing null type parsing.
Requested reviews:
Chris Hillery (ceejatec)
Nicolae Brinza (nbrinza)
For more details, see:
https://code.launchpad.net/~zorba-coders
The proposal to merge lp:~zorba-coders/zorba/null-type-fix into lp:zorba has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/null-type-fix/+merge/163883
--
https://code.launchpad.net/~zorba-coders/zorba/null-type-fix/+merg
Thanks Nicolae, this is perfect now.
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launc
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/null-type-fix into
lp:zorba with lp:~zorba-coders/zorba/new-jsoniq as a prerequisite.
Commit message:
Fixing null type syntax.
Requested reviews:
Chris Hillery (ceejatec)
Nicolae Brinza (nbrinza)
For more details, see:
https
Your comment makes a lot of sense too, thanks!
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : ht
Review: Approve
Approving because the last open issue is not release-critical.
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@list
Review: Needs Fixing
I can not see any warning if a version declaration is present. Was it fixed? Am
I doing something wrong?
jsoniq version "1.0";
declare namespace op = "http://www.zorba-xquery.com/options/features";;
declare option op:enable "common-language";
{ "foo" : "bar" }
-> no warning
> > > Why would you need a qualified value if the option itself is already
> > qualified?
> >
> > I guess because the option name and the option value may not live in the
> same
> > namespace.
>
> Why not? It's not as if you do schema validation on the options and their
> values. The option needs
Review: Needs Fixing
Thanks for fixing the warnings. I successfully checked, except for two things:
1.
"\" (XQuery parser) or "&" (JSONiq parser) leads to a warning about disallowed
character entity references/JSON character escape sequence. I think the warning
could be made more general and s
> Why would you need a qualified value if the option itself is already
> qualified?
I guess because the option name and the option value may not live in the same
namespace.
--
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch
Review: Needs Fixing
It looks good on the whole. For convenience, I am pasting the list of the
findings I sent to the zorba-dev mailing list, as of revision 11342 of this
branch, here:
- The dot context item should be a syntax error in the JSONiq parser, but {
"foo" : "bar" } ! . seems to pars
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/1598
This is one of the cases that we will have to live with. It's a conflict between
JSONiq and HOF. We were trying to push the W3C to make the dynamic function
invocation
a map (i.e. $f could be () or a sequence of function items). However, the w3c
didn't
want to go this way.
-> In this case, $f is
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-co
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/1598
Review: Disapprove
Disapproving to allow running tests without merging.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.laun
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/1598
The proposal to merge lp:~zorba-coders/zorba/bug-1123165 into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/1598
EXPECTED_FOTS_FAILURE (prod-RequireProhibitFeature
require-all-optional-features-5-s 0)
-> I removed it because the test suite got updated in the trunk.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Maili
I opened the bug for the first two expected failures here: bug 1171860.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launc
I think I addressed all comments.
There are three expected failures left:
EXPECTED_FOTS_FAILURE (prod-RequireProhibitFeature
require-higher-order-function-5-s 0)
EXPECTED_FOTS_FAILURE (prod-RequireProhibitFeature
require-higher-order-function-10-s 0)
-> This is the for $f in () return $f(1, ?)
- The style of the error messages is not consistent with the other error
messages. They should be changed as follows:
XQST0120 "$1": feature not supported
XQST0128 "$1": unable to disable a supported feature
XQST0126 impossible to activate all extension features
DONE
--
https://code.launch
- It feels like most of the implementation should go into the translator and
not into the static context.
DONE
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-code
- The function check_xquery_feature_options is too long. Could this be
simplified and/or split into multiple functions?
DONE
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123165/+merge/159822
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.n
The proposal to merge lp:~zorba-coders/zorba/bump_FOTS_snapshot_Apr_23 into
lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot_Apr_23/+merge/160232
--
https://code.launchpad.net/~zorba-coders/z
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot_Apr_23/+merge/160232
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad
- The fix for dynamic_function_invocation seems to be orthogonal. Why is this
fixed in this merge proposal? I couldn't find a test to cover this behavior.
It does fix some of the W3C tests:
for $f in () return $f(1, ?)
Raised an error in zorba because it was considered an object lookup. B
Review: Approve
Perfect!
I wondered why the .res was not modified for a wee bit of a second :-)
--
https://code.launchpad.net/~zorba-coders/zorba/feature-compare_null/+merge/159871
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
P
The proposal to merge lp:~zorba-coders/zorba/feature-compare_null into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-compare_null/+merge/159871
--
https://code.launchpad.net/~zorba-coders/zorba/featu
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/bug-1123165 into
lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #1123165 in Zorba: "failures in require-feature and prohibit-feature (at
least 27)"
https://bugs.launchpad.net/
It looks good!
- Could we add a test that checks that $object.$$ parses?
- Why was type promotion changed to a treat-as in FO normalization? Is it for
performance? The only promotion I can think to happen is a URI being promoted
to a string in an object lookup. We have not discussed this yet I t
I updated the ChangeLog.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-487/+merge/145868
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~z
Review: Approve
Hi Matthias,
It looks good!
Are you aware that in orderby01.jq, () is converted to a null in the object
constructor, so that it is not actually testing how () compares to null with a
sort?
Perhaps you can add tests that check that "() eq null" and "null eq ()" return
()?
(It
Hi Paul,
I formerly assessed the risk of reaching the limits of the int/long range for a
position as highly unlikely, but I do have doubts about whether a negative
number might go through. So I changed assert(false) to a proper processor
exception. I also changed to const&.
--
https://code.lau
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
I just noticed you are in a Need Fixing state, so I am pushing to the patch
queue.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorb
Good catch Paul. Do the changes fulfil your expectations provided all tests
pass? I am not pushing yet to the patch queue because it might get through
without your approval.
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed t
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The proposal to merge lp:~zorba-coders/zorba/bug-487 into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-487/+merge/145868
--
https://code.launchpad.net/~zorba-coders/zorba/bug-487/+merge/1458
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/bug-487 into
lp:zorba.
Commit message:
Fixing bug 487 (db:edit swaps).
Requested reviews:
Dennis Knochenwefel (dennis-knochenwefel)
Till Westmann (tillw)
Related bugs:
Bug #487 in Zorba: "When editing a node
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
--
https://code.launchpad.net/~zorba-coders/zorba/xml-in-
Review: Approve
Thanks! It looks good now.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubs
Perhaps we can move this if clause out of the store and into the old module
code?
--
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Hi Matthias,
For ref:dereference's not throwing any error, I am not sure I understand your
comment - looking at the code, it seems to not differentiate between nodes,
objects and arrays. I have the feeling it is only about removing the if
statement that throws the error in SimpleStore::getNodeB
I am not sure about switching back to xs:string instead of xs:anyURI - somehow,
I find it semantically weird. Perhaps this deserves an offline discussion?
--
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
Your team Zorba Coders is subscribed to branch lp:zo
Review: Needs Fixing
Hi Matthias,
It looks good! I have the following comments:
- 104 : JSON reference -> did you mean JSON array?
- Why return an error if ref:dereference is called with an unrecognized URI,
while returning the empty sequence if it is recognized but unbound? Can we
unify and
The proposal to merge lp:~zorba-coders/zorba/bug-1092842 into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1092842/+merge/141049
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1092842/+merge/1410
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/bug-1092842 into
lp:zorba.
Commit message:
"Fixing bug 1092842 (tree pointers of nested items in an object or array do not
get swapped correctly upon dml:edit.)"
Requested reviews:
Chris Hillery (ceejatec)
Matthia
The proposal to merge lp:~zorba-coders/zorba/bug-1092842 into lp:zorba has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1092842/+merge/141049
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1092842/+merge/1410
The proposal to merge lp:~zorba-coders/zorba/replace-node-cleanup into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/replace-node-cleanup/+merge/140161
--
https://code.launchpad.net/~zorba-coders/zorba/repla
1 - 100 of 533 matches
Mail list logo
