Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
The intro is great! There are examples missing for each function description. Also I would like to understand the best practice for documenting XML parameters. Currently it's pretty confusing. Matthias what's your take on it? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
As far as I can tell, I've already given examples. Since you're so picky and only you seem to know what you want, why don't you just add the documentation you want yourself? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
If you give/write a good overview of the possible options for parse/serialize I can definitely do that. Right know I have no clue of what's possible or not which is gonna the case of our users too. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Why can't you just look at the json-options schema? There are only two options. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Approve The reported bugs were fixed, the documentation also looks good. As far as William's last remark, IMO building the XQDoc documentation and looking at the 'json-options' schema solves the problem. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/feature-json_parser into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/feature-json_parser into lp:zorba has been updated. Commit Message changed to: I think I've finally got it. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/feature-json_parser into lp:zorba has been updated. Commit Message changed to: New JSON parser and module. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-json_parser-2012-02-15T17-27-26.321Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/feature-json_parser into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job feature-json_parser-2012-02-15T17-27-26.321Z is finished. The final status was: 41 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/feature-json_parser into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/feature-json_parser into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-json_parser-2012-02-16T00-25-35.097Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Validation queue job feature-json_parser-2012-02-16T00-25-35.097Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/feature-json_parser into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
I approve the fix for bug #930573 and opened #932186 which depends on this merge proposal. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing Still pending on bug #930573 -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/92900 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Zorba implements that proposed by John Snelson. - is that correct english? I'm not sure. For John Snelson representation example, please add the corresponding JSON and XQuery function call above. For the JSONML example, please add the corresponding JSON and XQuery function call above. I think that this fix will dramatically improve the time needed for someone to get started with the module. In parse#1, add a small example. Returns: said XDM instance. is that correct? In parse#2, add a small example. Add a description of how to build element(json-options:options) In serialize#1, add a small example. In serialize#2, add a small example. Add a description of how to build element(json-options:options) -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/91959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
I have reopened bug #920717. This merge is still pending on the resolution of this bug. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/91959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Zorba implements that proposed by John Snelson. - is that correct english? I'm not sure. Yes. In parse#1, add a small example. Returns: said XDM instance. is that correct? Yes. In parse#2, add a small example. Add a description of how to build element(json-options:options) I would except XQDoc is broken and renders it very badly. In serialize#1, add a small example. In serialize#2, add a small example. It's just the reverse of what's above! -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/91959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
If the documentation is correct in the source, I will fix everything else. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/91959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing This merge request is pending on bug #920717 Also there are some documentation issues that have not been addressed yet. How do you we do this? Do you make another shot at it first or we should have call with Matthias to discuss how to review it? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/91959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Do you take another shot at it first or should we have a call with Matthias to discuss how to improve the module documentation?* -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/91959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
If you want the documentation fixed, you need to specify exactly what needs fixing -- I'm not a mind-reader. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/91959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing I believe that bug #920717 isn't fixed. The intro has two examples of XML. For each of the XML, you should add the associated JSON. Would it be possible to get all the bug reports that Sorin created associated to this merge request? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/91360 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/91959 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/91360 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing The module works great. There is room for improvement regarding its documentation. There are many ways to represent JSON data in XML - There are two ways to represent JSON data in XML: - bullet 1 (John Snelson's format) - bullet 2 (JSON) Then add two examples, you can take some inspiration at http://docs.basex.org/wiki/JSON_Module For parse#1, add a small example. For parse#2, add two small examples and some description of what is excepted for the option element (which namespace, example of schema instance instance) For serialize#1, please elaborate on what the following means: Serializes an XDM into JSON using one of the representations described above. and add two small examples. For serialize#2, same comment than for serialize#1 + add some explanation of what is excepted for the option element. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
No, the statement There are many ways to represent JSON data in XML is correct as it is. There *are* *many* ways: Zorba only implements *two* of those *many* ways. Adding *two* examples is too much. API documentation isn't supposed to be the primary documentation. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing I think William is right. We should have a couple of examples which help the user to get started with this module. Those could either be inline in the text or links generated using the @example xqdoc tag. The serialize functions should be annotated %ann:streamable because they return a streamable string (see modules/com/zorba-xquery/www/modules/fetch.xq). Some error codes lack a prefix (e.g. ZJPE0001). If I understood correctly, it should be zerr:ZJPE0001. Otherwise, the user doesn't know how to catch the error. Under which circumstances does json:parse return the empty sequence? What does json:serialize return if the input is the empty sequence? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing 1) Should be possible to call json:serialize(json:parse(VALID_JSON)) where VALID_JSON is any valid JSON string see failing test test/rbkt/zorba/json/json-snelson-serialize-parse added bug lp:920717 2) array and object closed prematurely in json:parse see failing tests test/rbkt/zorba/json/json-snelson-parse-array-06 and test/rbkt/zorba/json/json-snelson-parse-array-07 added bug lp:920719 3) When trying to parsing a valid JSON string with invalid JSON option parameter the error raised is: http://www.w3.org/2005/xqt-errors:XPST0003 Please add a more useful error message: see failing test test/rbkt/zorba/json/json-invalid-option-parameter added bug lp:920720 4) Parsing an empty value has wrong behavior for both JSON mappings (Snelson and JSON-ML). Please see failing tests: - test/rbkt/zorba/json/json-snelson-empty-value - test/rbkt/zorba/json/json-jsonml-empty-value added bug lp:920721 5) Comment nodes should be ignored by json:serialize Please see failing tests: - test/rbkt/zorba/json/json-snelson-serialize-object-03 - test/rbkt/zorba/json/json-snelson-serialize-array-12 added bug lp:920722 6) XQDoc issues: - there is no @project tag for the new json.xq module: as a result, in the XQDoc documentation is generated in the www.zorba-xquery.com/modules/converters instead of data processing/data converters Please add a @project data processing/data converters in the module description in order to fix this. - first parse function does not state zerr:ZJPE0006 as a possible error condition if the passes JSON string is invalid See added test json-snelson-invalid-json.xq Added bug lp:920724 -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
r10618 contains all the tests mentioned above. The tests are passing because they are marked as EXPECTED_FAILURES. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Why did you mark them as EXPECTED_FAILURE if they're not expected to fail? Presumably, you *want* them fixed, right? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
EXPECTED_FAILURE does *not* mean negative test. It means this is broken, we know it's broken, and we're working on it. That's why you have to supply a bug number to the macro. It probably should be renamed KNOWN_BUG. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
It means known bug for things that are in the trunk. If it's on a branch (as this is), then either (1) it will be fixed before it's merged into the trunk (at which point the EXPECTED_FAILURE will have to be removed since it will no longer be failing -- which begs my question of, Why put it in in the first place?) or (2) the test will be deemed invalid and removed. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Hmm... valid points. I think there's some value in using EXPECTED_FAILURE() anyway, since it documents the relationship to new bugs that are filed. It does introduce the possibility of unintentionally merging a new bug onto the trunk, but the diff will clearly show a new EXPECTED_FAILURE() marker and I would hope that any reviewer would raise a serious question about that. I guess I would say that it's probably unnecessary to add EXPECTED_FAILURE()s (and associated bugs) for small review comments. However, for anything which might reasonably take more than a few hours to fix, IMHO it's probably good practice just to help ensure that no issues get forgotten. In general I would leave that decision up to the team working on the branch in question, though. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
It means known bug for things that are in the trunk. If it's on a branch (as this is), then either (1) it will be fixed before it's merged into the trunk (at which point the EXPECTED_FAILURE will have to be removed since it will no longer be failing -- which begs my question of, Why put it in in the first place?) or (2) the test will be deemed invalid and removed. Paul, IMO: - adding some bugs on Launchpad - adding tests that fail and marking them as KNOWN_ISSUE (a.k.a. EXPECTED_FAILURES) was far better than adding a comment in your merge proposal. Keep in mind that I have spent my time in order to give you a hand in pointing out the issues I found. Adding separate bugs allows us to: - discussed the raised issues separately - make commits to fix them separately into the branch And to prove my point: you already wrote 2 comments *without* even looking over *any* of the issues I have raised. Anyway, I already committed a fix in the branch for bug lp:920724. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Chris Hillery wrote: I think there's some value in using EXPECTED_FAILURE() anyway, since it documents the relationship to new bugs that are filed. The relationship to new bugs *from* ___? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Documents the relationship of the newly-added failing tests to the bugs tracking those issues. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
IMO, you didn't *need* to add any comment to the merge proposal other than Bugs filed -- I can read the bugs myself. Sorin wrote: Keep in mind that I have spent my time in order to give you a hand in pointing out the issues I found. It's all of our job to review each others' code under the New Order so please don't act like it was a personal favor. I never questioned your adding separate bugs. For the record, I *like* separate bugs. I *only* questioned why you added EXPECTED_FAILURE for those bugs that, as I've pointed out, is unnecessary and not only creates more work for you (because you put them in) but more work for me (because I have to take them out). Sorin wrote: And to prove my point: you already wrote 2 comments *without* even looking over *any* of the issues I have raised. *My* point has *nothing* to do with any bugs in particular. Chris understands my point. Do you? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
@Chris: Hmmm... again, because this is a branch and no Zorba user will ever see this stuff, it's at best only marginally useful. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Paul, let me ask you something: are you sure you are not missing the point? IMHO the point is to fix the issues that were raised ASAP. I have spent my time in order to give as many details as possible in order to fix them ASAP. Also I have committed a fix in the branch for one of the opened bugs. Please look over the bugs and let's try to fix them in order to commit the new improved JSON 2.0 module to the trunk. If you think that the decision I took while reviewing your merge deserves further discussion let's put it on the next weekly conference agenda. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
IMO, you didn't *need* to add any comment to the merge proposal other than Bugs filed -- I can read the bugs myself. FYI: Matthias asked me (in a separate email discussion) to add a small review of the issues I fount in the merge proposal: please take this issue with him. Sorin wrote: Keep in mind that I have spent my time in order to give you a hand in pointing out the issues I found. It's all of our job to review each others' code under the New Order so please don't act like it was a personal favor. OK, next time I will review your code I will simply add a one sentence in the merge proposal and keep adding comments because you clearly think this is better. I never questioned your adding separate bugs. For the record, I *like* separate bugs. I *only* questioned why you added EXPECTED_FAILURE for those bugs that, as I've pointed out, is unnecessary and not only creates more work for you (because you put them in) but more work for me (because I have to take them out). I will never do this again. Sorin wrote: And to prove my point: you already wrote 2 comments *without* even looking over *any* of the issues I have raised. *My* point has *nothing* to do with any bugs in particular. Chris understands my point. Do you? No, I do not. IMHO you are missing the point, that is: let's try to fix the *bugs* and discuss the procedures later. Do you understand my point? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
No, the point is *not* to fix this issues ASAP. The feature is not a high-priority feature, so there's no reason to do this ASAP. My *only* point was why you added EXPECTED_FAILURE lines to the CMakeLists.txt file -- that's it. But it's moot now since I've removed all the new EXPECTED_FAILURES that you've added. They're of no use to me. Now when I run the test suite and it reports 100% tests passed, I can be confident that I've fixed all the bugs and not have an errant EXPECTED_FAILURE in there. In the future, please don't add EXPECTED_FAILURE lines to code on a *branch* -- thanks. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
No, the point is *not* to fix this issues ASAP. The feature is not a high- priority feature, so there's no reason to do this ASAP. My *only* point was why you added EXPECTED_FAILURE lines to the CMakeLists.txt file -- that's it. But it's moot now since I've removed all the new EXPECTED_FAILURES that you've added. They're of no use to me. Now when I run the test suite and it reports 100% tests passed, I can be confident that I've fixed all the bugs and not have an errant EXPECTED_FAILURE in there. In the future, please don't add EXPECTED_FAILURE lines to code on a *branch* -- thanks. My 2 cents: no matter what the brief description of the ctest -R SOME_TEST shows, one should *always* check out the details inside the ctest logs. http://en.wikipedia.org/wiki/The_Devil_is_in_the_details -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/feature-json_parser into lp:zorba has been updated. Commit Message changed to: New JSON parser and module. Fixed the missing quote in the documentation. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89008 -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89008 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
I have resubmitted the merge proposal after committing the fix for the JSON tests. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89008 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing The documentation is missing some examples. The example section at http://docs.basex.org/wiki/JSON_Module is a good place to get inspired. Why A chars have a backslash in error code descriptions: ZJSE0001 if \a $xml is not a document or element node. ZJSE0002 if \a $xml contains an element that is missing a required attribute. ZJSE0003 if \a $xml contains an attribute having an illegal value. ZJSE0004 if \a $xml contains an illegal element. ZJSE0005 if \a $xml contains an illegal child element for a JSON type. ZJSE0006 if \a $xml contains an illegal child element. ZJSE0007 if \a $xml contains an illegal text node. ZJSE0008 if \a $xml contains an illegal value for a JSON type. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89008 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Doesn't seem to work for xqdoc -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89008 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Review: Needs Fixing I get the following error when running the make doc target: Zorba error [zerr:ZXQD0002]: Using this module, you can parse JSON data into XML, manipulate it like any other XML data using XQuery, and serialize the result back as JSON. There are many ways to represent JSON data in XML, some loss-less (round tripable) and some lossy (one way). Loss-less representations preserve the JSON data types iboolean/i, inumber/i, and inull/i; lossy representations convert all data to strings. For a loss-less representation, Zorba implements that proposed by a href=http://john.snelson.org.uk/parsing-json-into-xqueryJohn Snelson/a; for a lossy representation, Zorba implements a href=http://jsonml.org/;JsonML/a (the array form). : can not parse as XML for xqdoc: loader parsing error: Unescaped '' not allowed in attributes values -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/88419 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Those are the old jansson tests. I have to ask Matthias what to do about them. -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/88721 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-json_parser into lp:zorba
Also the make doc target returns the following error: The make xqdoc fails because there are 3 modules in the ZorbaManifest.xml all linked to the same URI, 'http://www.zorba-xquery.com/modules/converters/json'. IMO, the fix would be to: - make a separate branch where the deprecated external JSON 1.0 is removed; make this merge proposal dependent of this branch. - make sure that during the Zorba compilation there is only one module linked to any given URI -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/88721 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
