On Fri, Jun 8, 2018 at 12:56 PM, Nischay Nahata <[email protected]> wrote:
> Also, its strange that someone can just remove someone else's code review > just like that on gerrit, add their own review and merge a patch. > This ability is very useful in some cases - for example, imagine a VisualEditor patch marked as "-2 Do not merge until Parsoid patch XXXX is deployed"; after said deployment, it is normal for someone else to remove the -2 review and approve the patch (imagine further that the original reviewer is on vacation). Note that only people with the right to give -2/+2 reviews can remove others' reviews. The fact that the review was removed is recorded in a comment, so the potential for abuse seems low. _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
