Re: [PATCH] Add "FreeListen" to support IP_FREEBIND

2016-03-28 Thread Jan Kaluža
On 03/28/2016 05:52 PM, Stefan Fritsch wrote: On Monday 07 March 2016 12:41:25, Jan Kaluža wrote: This is needed for httpd startup with systemd when one wants to use particular IP address to bind. There is no way how to start httpd after the IP address has been configured in systemd

Re: [PATCH] Add "FreeListen" to support IP_FREEBIND

2016-03-19 Thread Jan Kaluža
On 03/08/2016 11:43 AM, Jan Kaluža wrote: On 03/08/2016 10:25 AM, Yann Ylavic wrote: On Tue, Mar 8, 2016 at 9:46 AM, Yann Ylavic <ylavic@gmail.com> wrote: On Tue, Mar 8, 2016 at 9:28 AM, Jan Kaluža <jkal...@redhat.com> wrote: I have chosen FreeListen over the flags FWIW, sh

Re: [PATCH] Add "FreeListen" to support IP_FREEBIND

2016-03-08 Thread Jan Kaluža
On 03/08/2016 10:25 AM, Yann Ylavic wrote: On Tue, Mar 8, 2016 at 9:46 AM, Yann Ylavic <ylavic@gmail.com> wrote: On Tue, Mar 8, 2016 at 9:28 AM, Jan Kaluža <jkal...@redhat.com> wrote: I have chosen FreeListen over the flags FWIW, should be take the YAD path, I'd prefer List

Re: [PATCH] Add "FreeListen" to support IP_FREEBIND

2016-03-08 Thread Jan Kaluža
On 03/08/2016 06:32 AM, William A Rowe Jr wrote: On Mar 7, 2016 21:59, "Yehuda Katz" <yeh...@ymkatz.net <mailto:yeh...@ymkatz.net>> wrote: > > On Mon, Mar 7, 2016 at 9:06 PM, William A Rowe Jr <wr...@rowe-clan.net <mailto:wr...@rowe-clan.net>> wrote:

Re: [PATCH] Add "FreeListen" to support IP_FREEBIND

2016-03-07 Thread Jan Kaluža
. If you think adding flag to Listen is better way, I can rework my patch. Regards, Jan Kaluza On Mar 7, 2016, at 6:41 AM, Jan Kaluža <jkal...@redhat.com> wrote: Hi, attached patch adds new "FreeListen" directive. The difference between "Listen" and "FreeLi

[PATCH] Add "FreeListen" to support IP_FREEBIND

2016-03-07 Thread Jan Kaluža
Hi, attached patch adds new "FreeListen" directive. The difference between "Listen" and "FreeListen" is that "FreeListen" sets the IP_FREEBIND socket option on platforms where this is available. It is therefore possible to start the server even when particular IP address set in the

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-19 Thread Jan Kaluža
On 01/18/2016 09:22 PM, William A Rowe Jr wrote: On Mon, Jan 18, 2016 at 5:13 AM, Jan Kaluža <jkal...@redhat.com <mailto:jkal...@redhat.com>> wrote: On 01/08/2016 07:44 PM, William A Rowe Jr wrote: Do we have to repeat the softmagic call if checkzmagic resolves to

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-18 Thread Jan Kaluža
On 01/08/2016 07:44 PM, William A Rowe Jr wrote: Do we have to repeat the softmagic call if checkzmagic resolves to x-gzip/x-deflate and the internal content type needs to be deciphered? That's true. I think that Yann's patch moving the zmagic call after the softmagic call would just mean

Re: mod_mime_magic, gzipped tarballs and Docker

2016-01-08 Thread Jan Kaluža
On 01/08/2016 08:49 AM, Jan Kaluža wrote: Hi, it seems Docker client has a problem handling httpd responses [1] when you run Docker server behind httpd working as a reverse proxy. It is caused by "mod_mime_magic" adding following Content-Type and Content-Encoding to gzipped tar

mod_mime_magic, gzipped tarballs and Docker

2016-01-07 Thread Jan Kaluža
Hi, it seems Docker client has a problem handling httpd responses [1] when you run Docker server behind httpd working as a reverse proxy. It is caused by "mod_mime_magic" adding following Content-Type and Content-Encoding to gzipped tarballs sent as a response by Docker server:

Re: Shouldn't ap_get_remote_host use req->useragent_addr?

2016-01-07 Thread Jan Kaluža
On 01/07/2016 04:06 PM, Eric Covener wrote: On Thu, Jan 7, 2016 at 9:25 AM, Jan Kaluža <jkal...@redhat.com> wrote: When httpd is running behind a reverse proxy and mod_remoteip is configured, the correct client IP is logged (using %a in the LogFormat), but the proxy IP is used by 'Requir

Re: Weird behaviour with mod_ssl and SSLCryptoDevice

2015-12-15 Thread Jan Kaluža
On 12/14/2015 02:12 PM, jean-frederic clere wrote: Hi, I am sure I am doing something wrong, but when using a dummy crypto device to recreate a customer issue I am getting a similar issue in httpd-trunk but I am nearly sure someone would have complained here if that would be the case. Hi, I

Re: Weird behaviour with mod_ssl and SSLCryptoDevice

2015-12-15 Thread Jan Kaluža
On 12/15/2015 02:16 PM, Yann Ylavic wrote: Hi Jan, On Tue, Dec 15, 2015 at 12:51 PM, Jan Kaluža <jkal...@redhat.com> wrote: I think I've just fixed that in <http://svn.apache.org/r1720129>. I will also propose that for 2.4.x and 2.2.x. Shouldn't we do the same for ecparams below

"httpd -X" segfaults with 2.4.17

2015-10-16 Thread Jan Kaluža
Hi, httpd 2.4.17 segfaults when used with prefork MPM (and probably also with other MPMs) and -X option since r1705492. The crash happens in the following call in prefork.c (and probably also worker.c and so on): ap_mpm_pod_check(my_bucket->pod) pod is NULL and later dereferenced.

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Jan Kaluža
On 08/24/2015 11:12 PM, Yann Ylavic wrote: On Mon, Aug 24, 2015 at 5:51 PM, Yann Ylavic ylavic@gmail.com wrote: On Mon, Aug 24, 2015 at 4:47 PM, Jan Kaluža jkal...@redhat.com wrote: 2) Increment proxy_lb_workers according to number of workers in balancer when using ProxyPass /foobar

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Jan Kaluža
need to store with each worker in which server_rec context it was created. e.g. adding a const char * field to the worker that would be filled with server-server_hostname. Then we could use this value for creating the md5. Regards Rüdiger -Original Message- From: Jan Kaluža [mailto:jkal

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-25 Thread Jan Kaluža
for 2.2.x. As far as I can tell this change only applies to 2.2.x. So it would be fine to propose it directly in STATUS without any trunk commit. I agree. Jan Kaluza Regards Rüdiger -Original Message- From: Jan Kaluža [mailto:jkal...@redhat.com] Sent: Dienstag, 25. August 2015 14:15

PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-24 Thread Jan Kaluža
Hi, unfortunately, the r1680920 brought undesired behavior described in PR 58267 to 2.2.x. The bug is well described in the PR, so I won't describe it in this email. I have tried to debug it and I think the problem is that we use also server-server_hostname to compute the hash in the

Re: PR 58267: Regression in 2.2.31 caused by r1680920

2015-08-24 Thread Jan Kaluža
On 08/24/2015 04:47 PM, Jan Kaluža wrote: Hi, unfortunately, the r1680920 brought undesired behavior described in PR 58267 to 2.2.x. The bug is well described in the PR, so I won't describe it in this email. I have tried to debug it and I think the problem is that we use also server

Re: mod_ssl: How to react on default OpenSSL SSL_CTX_set_options?

2015-07-22 Thread Jan Kaluža
On 07/21/2015 04:07 PM, Yann Ylavic wrote: On Tue, Jul 21, 2015 at 2:50 PM, Plüm, Rüdiger, Vodafone Group ruediger.pl...@vodafone.com wrote: I would go for 2. +1 Done in http://svn.apache.org/r1692258. Regards, Jan Kaluza

mod_ssl: How to react on default OpenSSL SSL_CTX_set_options?

2015-07-21 Thread Jan Kaluža
Hi, in Fedora, OpenSSL maintainers are setting SSL_OP_NO_SSLv2 and SSL_OP_NO_SSLv3 options by default [1]. This disables both SSLv2 and SSLv3 by default in the SSLv23_method(), which is what mod_ssl uses when more than one version is requested. The side effect of this change in OpenSSL is

Re: Using UPN from subjectAltName with SSLUserName

2015-07-10 Thread Jan Kaluža
On 06/29/2015 03:14 PM, Jan Pazdziora wrote: On Mon, Jun 29, 2015 at 01:47:45PM +0200, Jan Pazdziora wrote: On Sun, Jun 28, 2015 at 05:11:57PM +0200, Kaspar Brand wrote: On 22.06.2015 10:37, Jan Pazdziora wrote: Please find a new patch attached which I hope covers all the parts you've

Re: Using UPN from subjectAltName with SSLUserName

2015-06-19 Thread Jan Kaluža
On 06/18/2015 12:22 PM, Yann Ylavic wrote: On Thu, Jun 18, 2015 at 11:49 AM, Jan Pazdziora jpazdzi...@redhat.com wrote: I'd appreciate any comments about suitability of such change, as well as the implementation. Specifically, I'm not sure if people will prefer the generic and currently

Re: mod_deflate was Re: [VOTE] Release Apache httpd 2.4.13 as GA

2015-06-04 Thread Jan Kaluža
On 06/05/2015 07:01 AM, William A Rowe Jr wrote: On Thu, Jun 4, 2015 at 10:47 PM, Gregg Smith g...@gknw.net mailto:g...@gknw.net wrote: This is new, not quite sure how I didn't see it a few weeks ago as it's 9 weeks old. Who forgot to fill in the number? mod_deflate.c(1283) :

Re: ALPN patch comments

2015-06-03 Thread Jan Kaluža
On 06/03/2015 03:43 PM, Stefan Eissing wrote: Hmm, personally, I do not like redundant configurations. If someone configures a module, like mod_h2, to be enabled (H2Engine on), she could expect the module to take all the necessary steps. So I am no fan of a „SSLAlpnEnable“. If a client sends

mod_proxy_fcgi default port

2015-05-26 Thread Jan Kaluža
Hi, currently the port for fcgi:// protocol defaults to 8000. Is there any reason why we use this port number as a default? Also, I think this default port number is not documented anywhere. I'm asking, because php-fpm uses port 9000 by default. I know that these ports are not standardized

Re: SSLDisableCRLCaching, is it even possible in 2.4.x?

2015-04-22 Thread Jan Kaluža
On 04/22/2015 09:50 AM, Kaspar Brand wrote: On 21.04.2015 12:20, Jan Kaluža wrote: we used to have a patch against httpd-2.2.15 to add SSLDisableCRLCaching option to not cache CRLs. I was trying to adapt this patch for httpd-trunk and eventually include it upstream but now I'm in dead end

SSLDisableCRLCaching, is it even possible in 2.4.x?

2015-04-21 Thread Jan Kaluža
Hi, we used to have a patch against httpd-2.2.15 to add SSLDisableCRLCaching option to not cache CRLs. I was trying to adapt this patch for httpd-trunk and eventually include it upstream but now I'm in dead end. The patch removes all the CRLs from the per-server_rec OpenSSL cache created in

Re: [PATCH] mod_log_config: Allow logging using errorlog provider

2015-04-17 Thread Jan Kaluža
On 04/07/2015 11:47 AM, Jan Kaluža wrote: Hi, we have ap_errorlog_provider in the trunk for some time. I was thinking about extending it to mod_log_config, so CustomLog/TransferLog would work with any module providing error_log logging ability like mod_syslog or mod_journald. Attached patch

Re: [RELEASE CANDIDATE] Apache-Test-1.39 RC1

2015-04-14 Thread Jan Kaluža
On 04/13/2015 09:23 AM, Steve Hay wrote: On 8 April 2015 at 18:04, Steve Hay steve.m@googlemail.com wrote: On 8 April 2015 at 14:24, Steve Hay steve.m@googlemail.com wrote: Please download, test, and report back on this Apache-Test 1.39 release candidate.

[PATCH] mod_log_config: Allow logging using errorlog provider

2015-04-07 Thread Jan Kaluža
Hi, we have ap_errorlog_provider in the trunk for some time. I was thinking about extending it to mod_log_config, so CustomLog/TransferLog would work with any module providing error_log logging ability like mod_syslog or mod_journald. Attached patch does that by introducing CustomLog

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2015-03-19 Thread Jan Kaluža
On 12/12/2014 02:23 PM, Jan Kaluža wrote: On 12/12/2014 02:17 PM, Yann Ylavic wrote: On Fri, Dec 12, 2014 at 2:09 PM, Plüm, Rüdiger, Vodafone Group ruediger.pl...@vodafone.com wrote: -Ursprüngliche Nachricht- Von: Jan Kaluža [mailto:jkal...@redhat.com] Gesendet: Freitag, 12. Dezember

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Jan Kaluža
On 03/18/2015 10:01 AM, Yann Ylavic wrote: On Wed, Mar 18, 2015 at 9:48 AM, Jan Kaluža jkal...@redhat.com wrote: On 03/18/2015 09:23 AM, Yann Ylavic wrote: On Wed, Mar 18, 2015 at 8:07 AM, Jan Kaluža jkal...@redhat.com wrote: I have no big knowledge of WebSockets, but it should be possible

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Jan Kaluža
On 03/18/2015 11:07 AM, Yann Ylavic wrote: Corresponding patch attached... On Wed, Mar 18, 2015 at 10:57 AM, Yann Ylavic ylavic@gmail.com wrote: On Wed, Mar 18, 2015 at 10:44 AM, Yann Ylavic ylavic@gmail.com wrote: [] Index: modules/proxy/mod_proxy_wstunnel.c

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Jan Kaluža
On 03/18/2015 09:23 AM, Yann Ylavic wrote: On Wed, Mar 18, 2015 at 8:07 AM, Jan Kaluža jkal...@redhat.com wrote: I have no big knowledge of WebSockets, but it should be possible to detect Switching Protocol header and return HTTP error if some error happens before we switch to WebSocket

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Jan Kaluža
On 03/17/2015 02:10 PM, Eric Covener wrote: On Tue, Mar 17, 2015 at 9:06 AM, Yann Ylavic ylavic@gmail.com wrote: GET /test/ HTTP/1.1 User-Agent: curl/7.29.0 Host: 127.0.0.1 Accept: */* No Upgrade header in this test? Right, no Upgrade header. That's the particular situation where one

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-18 Thread Jan Kaluža
On 03/17/2015 02:06 PM, Yann Ylavic wrote: On Tue, Mar 17, 2015 at 1:47 PM, Jan Kaluža jkal...@redhat.com wrote: On 03/17/2015 01:23 PM, Yann Ylavic wrote: On Tue, Mar 17, 2015 at 12:38 PM, Jan Kaluža jkal...@redhat.com wrote: Hi, I have found out that when WSS is used and SSL handshake

mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-17 Thread Jan Kaluža
Hi, I have found out that when WSS is used and SSL handshake fails, httpd closes client connection without any response to the client. In the log, one can see following: mod_proxy_wstunnel.c(131): (103)Software caused connection abort: [client 127.0.0.1:49915] AH02442: error on sock -

Re: mod_proxy_wstunnel ignores proxy_wstunnel_transfer errors

2015-03-17 Thread Jan Kaluža
On 03/17/2015 01:23 PM, Yann Ylavic wrote: On Tue, Mar 17, 2015 at 12:38 PM, Jan Kaluža jkal...@redhat.com wrote: Hi, I have found out that when WSS is used and SSL handshake fails, httpd closes client connection without any response to the client. If the SSL handshake fails, there is no SSL

Re: PR 53435, r101624, mod_ssl: error strings can't be loaded again once?

2015-03-11 Thread Jan Kaluža
On 11/11/2014 02:32 PM, Jan Kaluža wrote: Hi, latest comment in PR 53435 shows that memory leak in mod_ssl which happens during graceful restarts can be caused by r101624. Since this commit is 11 years old, I wanted to ask people here, if following is still true with current OpenSSL: Hi

Re: AW: Run external RewriteMap program as non-root

2015-03-06 Thread Jan Kaluža
On 03/05/2015 02:51 PM, Plüm, Rüdiger, Vodafone Group wrote: -Ursprüngliche Nachricht- Von: Jan Kaluža [mailto:jkal...@redhat.com] Gesendet: Donnerstag, 5. März 2015 14:08 An: dev@httpd.apache.org Betreff: Re: Run external RewriteMap program as non-root On 03/05/2015 12:53 PM, Yann

Re: Run external RewriteMap program as non-root

2015-03-05 Thread Jan Kaluža
On 03/05/2015 07:55 AM, Jan Kaluža wrote: Hi, currently, the External Rewriting Program (RewriteMap prg:) is run as root. I would like to change it but I see three ways how to do it: 1. Execute it right after drop_privileges hook. This looks like best way, but I haven't found any hook which

Re: Run external RewriteMap program as non-root

2015-03-05 Thread Jan Kaluža
On 03/05/2015 09:54 AM, Jan Kaluža wrote: On 03/05/2015 09:03 AM, Ruediger Pluem wrote: On 03/05/2015 07:55 AM, Jan Kaluža wrote: Hi, currently, the External Rewriting Program (RewriteMap prg:) is run as root. I would like to change it but I see three ways how to do it: 1. Execute it right

Re: Run external RewriteMap program as non-root

2015-03-05 Thread Jan Kaluža
On 03/05/2015 12:53 PM, Yann Ylavic wrote: On Thu, Mar 5, 2015 at 12:08 PM, Jan Kaluža jkal...@redhat.com wrote: On 03/05/2015 07:55 AM, Jan Kaluža wrote: 3. Execute it where it is now (post_config), but set user/group using apr_procattr_t. So far I think this would duplicate the code

Run external RewriteMap program as non-root

2015-03-04 Thread Jan Kaluža
Hi, currently, the External Rewriting Program (RewriteMap prg:) is run as root. I would like to change it but I see three ways how to do it: 1. Execute it right after drop_privileges hook. This looks like best way, but I haven't found any hook which could be used for that (except

Re: What is the lifetime of apr_dbd_get_entry(...); result?

2015-03-03 Thread Jan Kaluža
On 03/02/2015 11:24 AM, Yann Ylavic wrote: I meant to reply to all... On Mon, Mar 2, 2015 at 11:23 AM, Yann Ylavic ylavic@gmail.com wrote: On Mon, Mar 2, 2015 at 8:22 AM, Jan Kaluža jkal...@redhat.com wrote: On 02/04/2015 02:53 PM, Jan Kaluža wrote: httpd's mod_authn_dbd module

Re: mod_proxy's aside connections proposal

2015-03-03 Thread Jan Kaluža
On 09/30/2014 04:47 PM, Yann Ylavic wrote: Hello, I have proposed a patch for PR39673 but I'm not sure it would be accepted for mainline httpd, so here I am. Hi, I would like to get more opinions on the patch Yann proposed in this email. I fully understand that NTLM is not HTTP/1.1

Re: What is the lifetime of apr_dbd_get_entry(...); result?

2015-03-01 Thread Jan Kaluža
On 02/04/2015 02:53 PM, Jan Kaluža wrote: Hi, I'm CCing httpd-dev list too, because this question has not been answered on APR list yet and since it causes mod_authn_dbd to stop working randomly with pgsql, I think it could be interesting even for httpd developers. I'm also attaching

Re: svn commit: r1635428 - in /httpd/httpd/trunk: include/http_core.h server/core.c server/request.c

2015-01-22 Thread Jan Kaluža
On 01/22/2015 12:22 AM, William A. Rowe Jr. wrote: On Mon, 19 Jan 2015 16:28:46 -0600 William A. Rowe Jr. wr...@rowe-clan.net wrote: On Sun, 18 Jan 2015 23:00:10 -0500 Eric Covener cove...@gmail.com wrote: On Thu, Oct 30, 2014 at 4:34 AM, jkal...@apache.org wrote: +/*

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-16 Thread Jan Kaluža
, we should disable that and show warning that httpd doesn't support this configuration. Otherwise we need to add balancer merging as I did in the patch. Regards, Jan Kaluza On Dec 10, 2014, at 7:25 AM, Jan Kaluža jkal...@redhat.com wrote: Hi, I've found out that following configuration does

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Jan Kaluža
On 12/11/2014 03:05 PM, Plüm, Rüdiger, Vodafone Group wrote: -Original Message- From: Jan Kaluža [mailto:jkal...@redhat.com] Sent: Donnerstag, 11. Dezember 2014 14:40 To: dev@httpd.apache.org Subject: Re: [PATCH] Balancers, VirtualHost and ProxyPass On 12/11/2014 08:47 AM, Jan Kaluža

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Jan Kaluža
On 12/12/2014 12:08 PM, Yann Ylavic wrote: Hi Jan, On Fri, Dec 12, 2014 at 9:44 AM, Jan Kaluža jkal...@redhat.com wrote: On 12/11/2014 03:05 PM, Plüm, Rüdiger, Vodafone Group wrote: Looks fine in general. Details: I hope I've finally fixed everything now :), see the attached patch please

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Jan Kaluža
On 12/12/2014 11:56 AM, Ruediger Pluem wrote: On 12/12/2014 09:44 AM, Jan Kaluža wrote: On 12/11/2014 03:05 PM, Plüm, Rüdiger, Vodafone Group wrote: -Original Message- From: Jan Kaluža [mailto:jkal...@redhat.com] Sent: Donnerstag, 11. Dezember 2014 14:40 To: dev@httpd.apache.org

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-12 Thread Jan Kaluža
On 12/12/2014 02:17 PM, Yann Ylavic wrote: On Fri, Dec 12, 2014 at 2:09 PM, Plüm, Rüdiger, Vodafone Group ruediger.pl...@vodafone.com wrote: -Ursprüngliche Nachricht- Von: Jan Kaluža [mailto:jkal...@redhat.com] Gesendet: Freitag, 12. Dezember 2014 14:00 An: dev@httpd.apache.org

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-11 Thread Jan Kaluža
On 12/10/2014 08:21 PM, Ruediger Pluem wrote: On 12/10/2014 02:21 PM, Jan Kaluža wrote: On 12/10/2014 01:49 PM, Plüm, Rüdiger, Vodafone Group wrote: But this way we lose the base ones that are not touched in the virtual host and e.g. are only used by rewriterules. So we should transfer

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-11 Thread Jan Kaluža
On 12/11/2014 08:47 AM, Jan Kaluža wrote: On 12/10/2014 08:21 PM, Ruediger Pluem wrote: On 12/10/2014 02:21 PM, Jan Kaluža wrote: On 12/10/2014 01:49 PM, Plüm, Rüdiger, Vodafone Group wrote: But this way we lose the base ones that are not touched in the virtual host and e.g. are only used

[PATCH] Balancers, VirtualHost and ProxyPass

2014-12-10 Thread Jan Kaluža
Hi, I've found out that following configuration does not work as expected: Proxy balancer://a ... /Proxy VirtualHost *:80 ProxyPass / balancer://a stickysession=JSESSIONID|jsessionid /VirtualHost In this case, two proxy_balancers are created. The first one in Proxy section in the main

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-10 Thread Jan Kaluža
. From this point of view, double for loop should be OK. Regards, Jan Kaluza Regards Rüdiger -Original Message- From: Jan Kaluža [mailto:jkal...@redhat.com] Sent: Mittwoch, 10. Dezember 2014 13:26 To: httpd Subject: [PATCH] Balancers, VirtualHost and ProxyPass Hi, I've found out

Re: [PATCH] Balancers, VirtualHost and ProxyPass

2014-12-10 Thread Jan Kaluža
On 12/10/2014 02:50 PM, Yann Ylavic wrote: On Wed, Dec 10, 2014 at 2:21 PM, Jan Kaluža jkal...@redhat.com wrote: On 12/10/2014 01:49 PM, Plüm, Rüdiger, Vodafone Group wrote: Isn't the config merge on a critical path with every request? So double for loops always worry me a little bit from

Re: server/util_expr_(parse|scan) generated sources files

2014-12-08 Thread Jan Kaluža
On 12/08/2014 10:29 PM, Yann Ylavic wrote: Finally committed in r1643929, generated by bison-2.7.1. Thanks Yann! Regards, Jan Kaluza On Mon, Dec 8, 2014 at 9:12 PM, Yann Ylavic ylavic@gmail.com wrote: Reverted in r1643901. Someone with a bison version above 2.7.12-4996 should do this

Re: Systemd support in 2.4

2014-12-07 Thread Jan Kaluža
On 12/06/2014 01:40 PM, Jeff Trawick wrote: On Fri, Dec 5, 2014 at 6:59 AM, Jan Kaluža jkal...@redhat.com mailto:jkal...@redhat.com wrote: On 12/02/2014 02:08 PM, Jeff Trawick wrote: On Wed, Sep 17, 2014 at 9:22 AM, Jeff Trawick traw...@gmail.com mailto:traw...@gmail.com

Re: Systemd support in 2.4

2014-12-05 Thread Jan Kaluža
On 12/02/2014 02:08 PM, Jeff Trawick wrote: On Wed, Sep 17, 2014 at 9:22 AM, Jeff Trawick traw...@gmail.com mailto:traw...@gmail.com wrote: On Mon, Sep 15, 2014 at 2:00 AM, Jan Kaluža jkal...@redhat.com mailto:jkal...@redhat.com wrote: On 09/14/2014 01:21 PM, Martynas Bendorius

Re: svn commit: r1642154 - in /httpd/httpd/trunk: docs/manual/expr.xml include/ap_expr.h server/util_expr_eval.c server/util_expr_parse.y

2014-12-05 Thread Jan Kaluža
On 12/05/2014 02:26 PM, Eric Covener wrote: On Thu, Nov 27, 2014 at 8:46 AM, jkal...@apache.org wrote: * ap_exr: Add replace(string, from, to) function. Is it possible to evaluate this from ap_expr_str_exec()? Hm, it worked for me like this: Require expr replace(%{REQUEST_METHOD}, E, O)

Re: svn commit: r1642154 - in /httpd/httpd/trunk: docs/manual/expr.xml include/ap_expr.h server/util_expr_eval.c server/util_expr_parse.y

2014-12-05 Thread Jan Kaluža
On 12/05/2014 05:09 PM, Eric Covener wrote: On Fri, Dec 5, 2014 at 11:01 AM, Jan Kaluža jkal...@redhat.com wrote: On 12/05/2014 02:26 PM, Eric Covener wrote: On Thu, Nov 27, 2014 at 8:46 AM, jkal...@apache.org wrote: * ap_exr: Add replace(string, from, to) function. Is it possible

Re: svn commit: r1642154 - in /httpd/httpd/trunk: docs/manual/expr.xml include/ap_expr.h server/util_expr_eval.c server/util_expr_parse.y

2014-12-03 Thread Jan Kaluža
Thanks for reviewing that commit. I've fixed both issues in r1643094. Regards, Jan Kaluza On 12/02/2014 09:55 PM, Ruediger Pluem wrote: On 11/27/2014 02:46 PM, jkal...@apache.org wrote: Author: jkaluza Date: Thu Nov 27 13:46:11 2014 New Revision: 1642154 URL: http://svn.apache.org/r1642154

Re: svn commit: r1640495 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

2014-12-03 Thread Jan Kaluža
On 12/01/2014 02:15 PM, Yann Ylavic wrote: On Wed, Nov 19, 2014 at 8:19 AM, jkal...@apache.org wrote: Author: jkaluza Date: Wed Nov 19 07:19:13 2014 New Revision: 1640495 URL: http://svn.apache.org/r1640495 Log: * mod_proxy_fcgi: Ignore body data from backend for 304 responses. PR 57198.

Re: svn commit: r1609680 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h proxy_util.c

2014-11-27 Thread Jan Kaluža
On 11/24/2014 01:37 PM, Eric Covener wrote: please check r1641381 Anyone against proposing r1609680 (commit from the subject) + r1641381 for 2.4.x? Regards, Jan Kaluza On Sun, Nov 23, 2014 at 9:59 PM, Eric Covener cove...@gmail.com wrote: On Sun, Nov 23, 2014 at 9:57 PM, Eric Covener

Re: mod_ssl FakeBasicAuth, the colon problem (PR 52644)

2014-11-24 Thread Jan Kaluža
On 06/26/2014 09:22 AM, Ruediger Pluem wrote: Joe Orton wrote: I've had a user hit this: with FakeBasicAuth the client DN gets translated into a Basic auth blob of base64(username:password), which then fails when the username part contains a : colon character. At minimum mod_ssl could/should

Re: svn commit: r1609680 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h proxy_util.c

2014-11-24 Thread Jan Kaluža
On 11/24/2014 03:59 AM, Eric Covener wrote: On Sun, Nov 23, 2014 at 9:57 PM, Eric Covener cove...@gmail.com wrote: On Fri, Jul 11, 2014 at 6:36 AM, jkal...@apache.org wrote: static int ap_proxy_strcmp_ematch(const char *str, const char *expected) +{ +apr_size_t x, y; + +for (x = 0, y

PR 53435, r101624, mod_ssl: error strings can't be loaded again once?

2014-11-11 Thread Jan Kaluža
Hi, latest comment in PR 53435 shows that memory leak in mod_ssl which happens during graceful restarts can be caused by r101624. Since this commit is 11 years old, I wanted to ask people here, if following is still true with current OpenSSL: @@ -255,7 +255,11 @@ static apr_status_t

Re: PR 53435, r101624, mod_ssl: error strings can't be loaded again once?

2014-11-11 Thread Jan Kaluža
On 11/12/2014 07:16 AM, Kaspar Brand wrote: On 12.11.2014 03:28, Dr Stephen Henson wrote: I just checked the sources and this was fixed in OpenSSL 0.9.7m just over 7 years ago... For 0.9.8, it was fixed with 0.9.8e:

Re: svn commit: r1622450 - /httpd/httpd/trunk/support/ab.c

2014-11-03 Thread Jan Kaluža
On 11/02/2014 05:09 PM, Yann Ylavic wrote: Hi, On Thu, Sep 4, 2014 at 12:52 PM, jkal...@apache.org wrote: Author: jkaluza Date: Thu Sep 4 10:52:24 2014 New Revision: 1622450 URL: http://svn.apache.org/r1622450 Log: ab: increase request and response header size to 8192 bytes, fix potential

Fix DirectoryMatch to not match regular files?

2014-10-29 Thread Jan Kaluža
Hi, I was trying to fix PR41867 using attached patch. While the patch seems to work, I'm thinking if the behaviour change introduced by the patch can bring some problems. Currently, DirectoryMatch ^/var/www/html/private matches also /var/www/html/private.txt even it is a regular file and

Re: Systemd support in 2.4

2014-09-17 Thread Jan Kaluža
On 09/15/2014 08:00 AM, Jan Kaluža wrote: On 09/14/2014 01:21 PM, Martynas Bendorius wrote: Hello, Is there any special reason why mod_systemd and mod_journald (available in trunk) are not backported to 2.4 yet? Hi, I think mod_systemd could be proposed for 2.4 branch (maybe even

Re: Systemd support in 2.4

2014-09-15 Thread Jan Kaluža
On 09/14/2014 01:21 PM, Martynas Bendorius wrote: Hello, Is there any special reason why mod_systemd and mod_journald (available in trunk) are not backported to 2.4 yet? Hi, I think mod_systemd could be proposed for 2.4 branch (maybe even with the changes adding socket activation), but for

Re: Systemd support in 2.4

2014-09-14 Thread Jan Kaluža
On 09/14/2014 01:35 PM, Reindl Harald wrote: Am 14.09.2014 um 13:21 schrieb Martynas Bendorius: Is there any special reason why mod_systemd and mod_journald (available in trunk) are not backported to 2.4 yet? As we have a lot of distributions already using systemd by default (CentOS/RHEL 7,

Re: mod_proxy: PHP SCRIPT_FILENAME (PHP-FPM using UDS) and Apache documentation

2014-09-11 Thread Jan Kaluža
On 09/10/2014 07:17 PM, Jim Jagielski wrote: I know that PHP is current doing a LOT of fixes on hPHP-FPM... I've recently come to https://bugs.php.net/bug.php?id=65641 and was thinking if we can do anything about it. Jan Kaluza On Sep 10, 2014, at 12:00 PM, Martynas Bendorius

Re: svn commit: r1599531 - in /httpd/httpd/trunk: CHANGES include/ap_listen.h server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c server/mpm_unix.c

2014-08-26 Thread Jan Kaluža
On 08/19/2014 12:39 PM, Jan Kaluža wrote: @@ -3206,6 +3277,10 @@ static int event_pre_config(apr_pool_t * atomics not working as expected - add32 of negative number); return HTTP_INTERNAL_SERVER_ERROR; } +retained-idle_spawn_rate

Re: svn commit: r1618555 - /httpd/httpd/trunk/server/mpm/prefork/prefork.c

2014-08-21 Thread Jan Kaluža
On 08/18/2014 04:31 PM, Jan Kaluža wrote: On 08/18/2014 02:20 PM, Ruediger Pluem wrote: jkal...@apache.org wrote: Author: jkaluza Date: Mon Aug 18 07:43:43 2014 New Revision: 1618555 URL: http://svn.apache.org/r1618555 Log: prefork: Ignore SIGINT in child. This fixes race-condition

Re: svn commit: r1599531 - in /httpd/httpd/trunk: CHANGES include/ap_listen.h server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c server/mpm_unix.c

2014-08-19 Thread Jan Kaluža
@@ -3206,6 +3277,10 @@ static int event_pre_config(apr_pool_t * atomics not working as expected - add32 of negative number); return HTTP_INTERNAL_SERVER_ERROR; } +retained-idle_spawn_rate = apr_palloc(pconf, sizeof(int) * num_buckets); +

Re: prefork mpm crashes on SIGINT [possible patch?]

2014-08-18 Thread Jan Kaluža
On 08/14/2014 04:22 PM, Jan Kaluža wrote: Hi, I'm resurrecting this old thread, because I hesitate to do changes in signal handling without any ack of someone else. Committed in r1618555. Jan Kaluza This bug is more problematic in the context of docker [1] where people tend to run httpd

Re: svn commit: r1618579 - in /httpd/httpd/trunk: docs/log-message-tags/next-number docs/manual/mod/mod_systemd.xml modules/arch/unix/mod_systemd.c

2014-08-18 Thread Jan Kaluža
On 08/18/2014 02:23 PM, Ruediger Pluem wrote: jkal...@apache.org wrote: Author: jkaluza Date: Mon Aug 18 10:48:41 2014 New Revision: 1618579 URL: http://svn.apache.org/r1618579 Log: mod_systemd: Add IdleShutdown - number of seconds in idle-state after which httpd is shutdown. This is useful

Re: svn commit: r1618555 - /httpd/httpd/trunk/server/mpm/prefork/prefork.c

2014-08-18 Thread Jan Kaluža
On 08/18/2014 02:20 PM, Ruediger Pluem wrote: jkal...@apache.org wrote: Author: jkaluza Date: Mon Aug 18 07:43:43 2014 New Revision: 1618555 URL: http://svn.apache.org/r1618555 Log: prefork: Ignore SIGINT in child. This fixes race-condition in signals handling when httpd is runnning on

Re: prefork mpm crashes on SIGINT [possible patch?]

2014-08-14 Thread Jan Kaluža
in this thread below? Regards, Jan Kaluza On 05/09/2013 09:03 AM, Jan Kaluža wrote: I think I have proper solution for the crashes mentioned in previous mail (see the attached patch): 1. Ignore SIGINT and SIGTERM in clean_child_exit. Handlers of these two signals would call clean_child_exit again

Re: [VOTE] Release Apache httpd 2.4.10 as GA

2014-07-17 Thread Jan Kaluža
On 07/15/2014 07:20 PM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.10 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.10 GA. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will

Re: svn commit: r1610339 - in /httpd/httpd/trunk: docs/manual/mod/mod_journald.xml modules/loggers/config.m4 modules/loggers/mod_journald.c

2014-07-14 Thread Jan Kaluža
On 07/14/2014 09:52 AM, Ruediger Pluem wrote: jkal...@apache.org wrote: Author: jkaluza Date: Mon Jul 14 05:52:45 2014 New Revision: 1610339 URL: http://svn.apache.org/r1610339 Log: mod_journald: New module implementing error_log provider for systemd-journald. Added:

Re: [PATCH] Make error logging modular

2014-07-11 Thread Jan Kaluža
On 09/18/2013 02:12 PM, Jim Jagielski wrote: +1! On Sep 18, 2013, at 8:09 AM, Eric Covener cove...@gmail.com wrote: On Wed, Sep 18, 2013 at 8:01 AM, Jan Kaluža jkal...@redhat.com wrote: On 07/22/2013 08:02 AM, Jan Kaluza wrote: - Original Message - Hello Jan, Is there any reason

Re: [PATCH] Fix settings options with ProxyPassMatch

2014-07-11 Thread Jan Kaluža
On 07/10/2014 03:57 PM, Yann Ylavic wrote: On Thu, Jul 10, 2014 at 9:12 AM, Jan Kaluža jkal...@redhat.com wrote: On 07/09/2014 04:26 PM, Yann Ylavic wrote: I forgot proxysection(), why not handle the ap_proxy_define_match_worker() case there too? I'm not sure I see what you mean. There's

Re: [PATCH] Make error logging modular

2014-07-11 Thread Jan Kaluža
On 07/11/2014 12:53 PM, Yann Ylavic wrote: Hi Jan, On Fri, Jul 11, 2014 at 11:17 AM, Jan Kaluža jkal...@redhat.com wrote: I've updated mod_journald to latest trunk and added documentation. You can check the patch against trunk at http://people.apache.org/~jkaluza/patches/mod_journald/0001

Re: svn commit: r1609680 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h proxy_util.c

2014-07-11 Thread Jan Kaluža
On 07/11/2014 12:59 PM, Yann Ylavic wrote: On Fri, Jul 11, 2014 at 12:36 PM, jkal...@apache.org wrote: Author: jkaluza Date: Fri Jul 11 10:36:15 2014 New Revision: 1609680 URL: http://svn.apache.org/r1609680 Log: mod_proxy: add ap_proxy_define_match_worker() and use it for ProxyPassMatch and

Re: svn commit: r1609680 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h proxy_util.c

2014-07-11 Thread Jan Kaluža
On 07/11/2014 01:38 PM, Jim Jagielski wrote: On Jul 11, 2014, at 6:36 AM, jkal...@apache.org wrote: Author: jkaluza Date: Fri Jul 11 10:36:15 2014 New Revision: 1609680 URL: http://svn.apache.org/r1609680 Log: mod_proxy: add ap_proxy_define_match_worker() and use it for ProxyPassMatch and

Re: [PATCH] Make error logging modular

2014-07-11 Thread Jan Kaluža
On 07/11/2014 01:23 PM, Yann Ylavic wrote: On Fri, Jul 11, 2014 at 1:07 PM, Jan Kaluža jkal...@redhat.com wrote: On 07/11/2014 12:53 PM, Yann Ylavic wrote: Hi Jan, On Fri, Jul 11, 2014 at 11:17 AM, Jan Kaluža jkal...@redhat.com wrote: I've updated mod_journald to latest trunk and added

Re: svn commit: r1609709 - /httpd/httpd/trunk/include/ap_mmn.h

2014-07-11 Thread Jan Kaluža
On 07/11/2014 03:54 PM, Jim Jagielski wrote: On Jul 11, 2014, at 9:02 AM, Ruediger Pluem rpl...@apache.org wrote: jkal...@apache.org wrote: Author: jkaluza Date: Fri Jul 11 12:49:54 2014 New Revision: 1609709 URL: http://svn.apache.org/r1609709 Log: bump mmn because of r1609680 Modified:

Re: [PATCH] Fix settings options with ProxyPassMatch

2014-07-10 Thread Jan Kaluža
On 07/09/2014 04:26 PM, Yann Ylavic wrote: On Wed, Jul 9, 2014 at 4:14 PM, Yann Ylavic ylavic@gmail.com wrote: On Wed, Jul 9, 2014 at 3:03 PM, Jan Kaluža jkal...@redhat.com wrote: Hi, could you please check the patch I've attached to this email? Looks good to me. It changes following

Re: [PATCH] Fix settings options with ProxyPassMatch

2014-07-09 Thread Jan Kaluža
On 04/29/2014 03:51 PM, Jim Jagielski wrote: On Apr 29, 2014, at 8:41 AM, Jan Kaluža jkal...@redhat.com wrote: Because later we have to match the URL of request with some proxy_worker. If you configure ProxyPassMatch like this: ProxyPassMatch ^/test/(\d+)/foo.jpg http://x/$1/foo.jpg

Re: svn commit: r1608703 - /httpd/httpd/trunk/server/listen.c

2014-07-08 Thread Jan Kaluža
On 07/08/2014 02:00 PM, Yann Ylavic wrote: On Tue, Jul 8, 2014 at 11:42 AM, jkal...@apache.org wrote: @@ -279,8 +279,35 @@ static apr_status_t close_listeners_on_e #ifdef HAVE_SYSTEMD +static int find_systemd_socket(process_rec * process, apr_port_t port) { +int fdcount, fd; +int

Re: [PATCH] Fix settings options with ProxyPassMatch

2014-04-29 Thread Jan Kaluža
On 04/29/2014 01:04 PM, Jim Jagielski wrote: On Apr 24, 2014, at 8:57 PM, Yann Ylavic ylavic@gmail.com wrote: Hi Jan, sorry for the late. On Tue, Apr 22, 2014 at 3:39 PM, Jan Kaluža jkal...@redhat.com wrote: Hi again, the patch has been here for some time already. I hesitate to commit

Re: [PATCH] Fix settings options with ProxyPassMatch

2014-04-29 Thread Jan Kaluža
On 04/29/2014 02:22 PM, Jim Jagielski wrote: On Apr 29, 2014, at 7:41 AM, Jan Kaluža jkal...@redhat.com wrote: That's what we do with current patch I think, don't we? In the patch, we create char *match_name which is NULL when the worker_name is not regex and contains the escaped name

Re: [PATCH] Fix settings options with ProxyPassMatch

2014-04-29 Thread Jan Kaluža
On 04/29/2014 03:29 PM, Jim Jagielski wrote: On Apr 29, 2014, at 8:41 AM, Jan Kaluža jkal...@redhat.com wrote: Because later we have to match the URL of request with some proxy_worker. If you configure ProxyPassMatch like this: ProxyPassMatch ^/test/(\d+)/foo.jpg http://x/$1/foo.jpg

Re: [PATCH] Fix settings options with ProxyPassMatch

2014-04-28 Thread Jan Kaluža
On 04/25/2014 02:57 AM, Yann Ylavic wrote: Hi Jan, sorry for the late. No problem :). On Tue, Apr 22, 2014 at 3:39 PM, Jan Kaluža jkal...@redhat.com wrote: Hi again, the patch has been here for some time already. I hesitate to commit it to trunk without any review, because it changes

  1   2   >