Re: Proposal: remove commit_timestamp.json

Mon, 17 Oct 2016 07:05:29 -0700 


 From: Edward K. Ream <[email protected]>
 To: leo-editor <[email protected]> 
 Sent: Monday, October 17, 2016 3:51 AM
 Subject: Re: Proposal: remove commit_timestamp.json
   
​​On Sun, Oct 16, 2016 at 8:20 PM, Mike Hodson <[email protected]> wrote:


On Sun, Oct 16, 2016 at 7:12 PM, Edward K. Ream <[email protected]> wrote:
> Here's an example.  I downloaded
> leo-editor- 281522323a89c27b7c58338b1eaa62 4cbd383078.zip
> from two days ago.

How?


​From the two days ago link on the download leo page.​ 

​When I awoke early this morning, I saw the way forward.  It should satisfy 
everybody:

1. Add​ commit_timestamp.json to .gitignore.  No more merge conflicts and no 
more pollution of the git record.

2. Create leo/core/commit_timestamp.json in @button make-leo in leoDist.leo. 
This will ensure that a valid commit_timestamp.json appears in all official 
distributions, without the need for git hooks.

3. Add commit_timestamp.json back to the manifest in  launchLeo-unified.spec, 
so that pyinstaller will include it.

4. Change leoVersion.py so that it gets the commit hash and date from 
commit_timestamp.json if it can not get it from git.

Summary
The correct commit hash and date will appear at signon in all official distros, 
without devs having to install git hooks or worry about merge commits on 
commit_timestamp.json. I'll do this today, and test it, as part of releasing 
5.4b1.
I'm not really sure this has any utility :-/
We know the commit hash of official releases.  That was never the problem. The 
problem in some ways is that a git repo. can't contain its own hash. But more 
usefully, the issue is with interacting with users when addressing bugs.  You 
need to know the exact commit, it matters whether they're testing the version 
with an attempted fix, or the version before.  So, will we entertain this kind 
of interaction with non-git users? If Leo was a code editor, maybe we could 
justify excluding non-git users from that kind of interaction.  But 
unfortunately ;-) Leo is a multi-purpose tool used by authors, designers, 
hobbiests in various realms, etc. etc.
So, UserA reports an issue.  A dev. pushes an attempted fix and asks that they 
grab the latest version, 
https://github.com/leo-editor/leo-editor/archive/master.zip. Iterate a couple 
of times.  Are we on the same page version wise?  The most robust and *user* 
friendly way to be sure is useful info. in the log window.  I think only the 
original use of commit_timestamp.json achieved that.  The best compromise I've 
seen so far is to have them download 
https://github.com/leo-editor/leo-editor/archive/master@%7B0%20day%20ago%7D.zip 
and tell us that they're running Leo from a folder called 
leo-editor-f94ab524d406a5431d94523d4bc49b47c380e5c7.
Cheers -Terry


Edward
-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.


   
 

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.


























					Reply via email to