[kudu-CR](branch-1.15.x) [java] bump log4j up to 2.16.0 version

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18096 )

Change subject: [java] bump log4j up to 2.16.0 version
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/18096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Gerrit-Change-Number: 18096
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Dec 2021 06:49:43 +
Gerrit-HasComments: No

[kudu-CR](branch-1.14.x) [java] bump log4j up to 2.16.0 version

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18097 )

Change subject: [java] bump log4j up to 2.16.0 version
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/18097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Gerrit-Change-Number: 18097
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Dec 2021 06:49:31 +
Gerrit-HasComments: No

[kudu-CR](branch-1.13.x) [java] bump log4j up to 2.15.0 version

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18089 )

Change subject: [java] bump log4j up to 2.15.0 version
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/18089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7317447f24916795d8f00e3f6c418707c7fd4ff
Gerrit-Change-Number: 18089
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Dec 2021 17:45:27 +
Gerrit-HasComments: No

[kudu-CR](branch-1.15.x) [java] bump log4j up to 2.15.0 version

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18085 )

Change subject: [java] bump log4j up to 2.15.0 version
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/18085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7317447f24916795d8f00e3f6c418707c7fd4ff
Gerrit-Change-Number: 18085
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 10 Dec 2021 20:22:31 +
Gerrit-HasComments: No

[kudu-CR] [java] bump log4j up to 2.15.0 version

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18084 )

Change subject: [java] bump log4j up to 2.15.0 version
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/18084
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7317447f24916795d8f00e3f6c418707c7fd4ff
Gerrit-Change-Number: 18084
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 10 Dec 2021 20:15:20 +
Gerrit-HasComments: No

[kudu-CR] [LBM] Speed up server bootstrap by using multi-thread to compact containers

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17942 )

Change subject: [LBM] Speed up server bootstrap by using multi-thread to 
compact containers
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/17942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie48211d9e8c1d74e520fcb04df25c1d681261bb5
Gerrit-Change-Number: 17942
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai 
Gerrit-Comment-Date: Mon, 25 Oct 2021 22:19:41 +
Gerrit-HasComments: No

[kudu-CR] [LBM] Speed up server bootstrap by using multi-thread to compact containers

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17942 )

Change subject: [LBM] Speed up server bootstrap by using multi-thread to 
compact containers
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc@2106
PS2, Line 2106: .set_max_threads(dd_manager_->dirs().size())
how large can dd_manager_->dirs().size() get in production and shouldn't we 
have some sort of a safety limit here to avoid opening too many threads?


http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc@2977
PS2, Line 2977:   first_fatal_error = s.CloneAndPrepend(
Is first_fatal_error always guaranteed to contain the first encountered error? 
Can it be overwritten by subsequent errors in other threads?


http://gerrit.cloudera.org:8080/#/c/17942/2/src/kudu/fs/log_block_manager.cc@2992
PS2, Line 2992: LOG_AND_RETURN(WARNING, first_fatal_error);
perhaps, it would be beneficial to aggregate errors and log all errors, if 
there were multiple.



--
To view, visit http://gerrit.cloudera.org:8080/17942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie48211d9e8c1d74e520fcb04df25c1d681261bb5
Gerrit-Change-Number: 17942
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai 
Gerrit-Reviewer: Abhishek Chennaka 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 Oct 2021 21:18:26 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3297 fix RPC negotiations with cyrus-sasl-gssapi-2.1.27-5 and newer

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17619 )

Change subject: KUDU-3297 fix RPC negotiations with cyrus-sasl-gssapi-2.1.27-5 
and newer
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/17619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia655356798c753d5a223933cc09a0731018e10af
Gerrit-Change-Number: 17619
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler 
Gerrit-Comment-Date: Tue, 22 Jun 2021 20:20:11 +
Gerrit-HasComments: No

[kudu-CR] [hms] allow hive.metastore.disallow.incompatible.col.type.changes to be false

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17296 )

Change subject: [hms] allow 
hive.metastore.disallow.incompatible.col.type.changes to be false
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/17296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9777e134e243abfe768d631592541720e101a8
Gerrit-Change-Number: 17296
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Apr 2021 19:33:50 +
Gerrit-HasComments: No

[kudu-CR] [docs] Add the 1.14.0 release notes to the prior release notes

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16997 )

Change subject: [docs] Add the 1.14.0 release notes to the prior release notes
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16997
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If757e53b6c014f2c9f13988b746a758fa2b23cfa
Gerrit-Change-Number: 16997
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 28 Jan 2021 19:18:13 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Add post announcing Kudu 1.14.0

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16998 )

Change subject: [blog] Add post announcing Kudu 1.14.0
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16998
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc1f6bc0c98151ffb250436d6c26701f8a0319e4
Gerrit-Change-Number: 16998
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Comment-Date: Thu, 28 Jan 2021 19:05:27 +
Gerrit-HasComments: No

[kudu-CR](branch-1.14.x) Add release notes for 1.14.0

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16980 )

Change subject: Add release notes for 1.14.0
..


Patch Set 5: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy 
Gerrit-Comment-Date: Tue, 26 Jan 2021 18:46:37 +
Gerrit-HasComments: No

[kudu-CR](branch-1.14.x) Add release notes for 1.14.0

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16980 )

Change subject: Add release notes for 1.14.0
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/16980/2/docs/release_notes.adoc@174
PS2, Line 174: * Fixed a heap-use-after-free bug in Kudu C++ client that might 
manifest itself when altering a
is there a Jira for this or any information on how this bug might manifest 
itself?



--
To view, visit http://gerrit.cloudera.org:8080/16980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8da030ce0f8797f8c366c56298fcda1020b00b6
Gerrit-Change-Number: 16980
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy 
Gerrit-Comment-Date: Mon, 25 Jan 2021 22:41:40 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Add more options to the compatibility checker script

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16943 )

Change subject: [build] Add more options to the compatibility checker script
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516
Gerrit-Change-Number: 16943
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Jan 2021 18:24:32 +
Gerrit-HasComments: No

[kudu-CR] [build] Fix the java compatibility checker script

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13004 )

Change subject: [build] Fix the java compatibility checker script
..


Patch Set 4: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py
File build-support/check_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@121
PS3, Line 121: def find_client_jars(path):
> I exclude jars because they are know to be non-public or application jars w
Done


http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@175
PS3, Line 175:   if src_name == dst_name:
> Currently the script uses super rudimentary arguments. I will enhance the a
Done



--
To view, visit http://gerrit.cloudera.org:8080/13004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id482da0b3aa5ea35fcfb2b674f0d7ae413045ca3
Gerrit-Change-Number: 13004
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Jan 2021 18:28:37 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Fix the java compatibility checker script

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13004 )

Change subject: [build] Fix the java compatibility checker script
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py
File build-support/check_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@175
PS3, Line 175:   # TODO(ghenke): Add support for 
--error-on-binary-incompatibility and --error-on-source-incompatibility.
Currently, the script produces a lot of output for modified and added methods, 
which do not break compatibility. In order to see if anything is broken, I had 
to edit the script and add --only-incompatible. Perhaps, a simpler way is to 
pass CLI options through to the japi?



--
To view, visit http://gerrit.cloudera.org:8080/13004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id482da0b3aa5ea35fcfb2b674f0d7ae413045ca3
Gerrit-Change-Number: 13004
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 08 Jan 2021 22:55:47 +
Gerrit-HasComments: Yes

[kudu-CR] [build] Fix the java compatibility checker script

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13004 )

Change subject: [build] Fix the java compatibility checker script
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py
File build-support/check_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/13004/3/build-support/check_compatibility.py@121
PS3, Line 121:   return [j for j in all_jars if (
Nit: if I am reading this correctly, this code is excluding 9 patterns in order 
to find 6 files. Wouldn't it be easier include instead of exclude?



--
To view, visit http://gerrit.cloudera.org:8080/13004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id482da0b3aa5ea35fcfb2b674f0d7ae413045ca3
Gerrit-Change-Number: 13004
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 08 Jan 2021 22:44:22 +
Gerrit-HasComments: Yes

[kudu-CR] [benchmarks] Add single node YCSB testing scripts

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15851 )

Change subject: [benchmarks] Add single node YCSB testing scripts
..


Patch Set 3: Code-Review+1

+1 as long as you plan to add info to README on how to use this.


--
To view, visit http://gerrit.cloudera.org:8080/15851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib022e654e6c9367fff8fd38197d7e31abaa0e874
Gerrit-Change-Number: 15851
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Dec 2020 22:26:47 +
Gerrit-HasComments: No

[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16854 )

Change subject: [build] Add the option to use the protoc from thirdparty in the 
java build
..


Patch Set 1: Code-Review+1

> osx arm64 for the time being

Thanks.


--
To view, visit http://gerrit.cloudera.org:8080/16854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f
Gerrit-Change-Number: 16854
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Dec 2020 20:33:36 +
Gerrit-HasComments: No

[kudu-CR] [build] Add the option to use the protoc from thirdparty in the java build

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16854 )

Change subject: [build] Add the option to use the protoc from thirdparty in the 
java build
..


Patch Set 1:

What's an example of a specific OS or arch missing from Maven that applies to 
Kudu?


--
To view, visit http://gerrit.cloudera.org:8080/16854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f
Gerrit-Change-Number: 16854
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Dec 2020 18:53:56 +
Gerrit-HasComments: No

[kudu-CR] [thirpdarty] Improve LLVM build for macOS

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16853 )

Change subject: [thirpdarty] Improve LLVM build for macOS
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66
Gerrit-Change-Number: 16853
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Dec 2020 18:52:32 +
Gerrit-HasComments: No

[kudu-CR] [doc] note on having at least 3 locations for better HA

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16514 )

Change subject: [doc] note on having at least 3 locations for better HA
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0d8d2e7d917205c62aca567eb2b2db540f7857e
Gerrit-Change-Number: 16514
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 20:49:17 +
Gerrit-HasComments: No

[kudu-CR] [doc] note on having at least 3 locations for better HA

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16514 )

Change subject: [doc] note on having at least 3 locations for better HA
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16514/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/16514/1/docs/administration.adoc@256
PS1, Line 256: inevitable
inevitably



--
To view, visit http://gerrit.cloudera.org:8080/16514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0d8d2e7d917205c62aca567eb2b2db540f7857e
Gerrit-Change-Number: 16514
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 18:44:45 +
Gerrit-HasComments: Yes

[kudu-CR] [test] Fix Unix socket tests on macOS

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16458 )

Change subject: [test] Fix Unix socket tests on macOS
..


Patch Set 2: Code-Review+1

client-test, master_authz-itest, location_cache-test, rpc-test, and socket-test 
pass on my Mac (10.14.4) with this change.


--
To view, visit http://gerrit.cloudera.org:8080/16458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I434e92e86fb87d1085c35b5d707d1238295192fb
Gerrit-Change-Number: 16458
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Sep 2020 17:38:22 +
Gerrit-HasComments: No

[kudu-CR] KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16388 )

Change subject: KUDU-3187: Enhance the HMS plugin to check if synchronization 
is enabled
..


Patch Set 7: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3588d72af1bb499202b47fca50a08876e13ea37
Gerrit-Change-Number: 16388
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 11 Sep 2020 20:09:16 +
Gerrit-HasComments: No

[kudu-CR](branch-1.13.x) Add release notes for 1.13.0

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16410 )

Change subject: Add release notes for 1.13.0
..


Patch Set 3: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac2a0ae740c3dabc5e7d8b7ef53312924c6e3532
Gerrit-Change-Number: 16410
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Lieber-Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 03 Sep 2020 20:18:18 +
Gerrit-HasComments: No

[kudu-CR] WIP - KUDU-3187: Enhance the HMS plugin to check if synchronization is enabled

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16388 )

Change subject: WIP - KUDU-3187: Enhance the HMS plugin to check if 
synchronization is enabled
..


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
File 
java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:

http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@201
PS1, Line 201: checkNoKuduProperties
another comment on this is that checkNoKuduProperties will also call 
isKuduTable, which at this point is redundant.


http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@201
PS1, Line 201:   checkNoKuduProperties(newTable);
checkNoKuduProperties does not check for KUDU_MASTER_ADDRS_KEY - is that 
intentional?


http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@206
PS1, Line 206: kuduSyncEnabled
Thinking about the execution path for non-Kudu tables, it will return faster if 
this check is performed before the previous one.


http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File 
java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:

http://gerrit.cloudera.org:8080/#/c/16388/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@57
PS1, Line 57: import org.apache.kudu.test.junit.RetryRule;
Remove this import since you've removed the annotation below?



--
To view, visit http://gerrit.cloudera.org:8080/16388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3588d72af1bb499202b47fca50a08876e13ea37
Gerrit-Change-Number: 16388
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Sep 2020 17:13:12 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3185 Add table owner to web UI and tools

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16394 )

Change subject: KUDU-3185 Add table owner to web UI and tools
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0791847b58925ec9818943c62fe4a1bc00359749
Gerrit-Change-Number: 16394
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Sep 2020 16:51:01 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [WIP] Add Ranger blog post

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16268 )

Change subject: [WIP] Add Ranger blog post
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16268/3/_posts/2020-07-31-fine-grained-authz-ranger.md
File _posts/2020-07-31-fine-grained-authz-ranger.md:

http://gerrit.cloudera.org:8080/#/c/16268/3/_posts/2020-07-31-fine-grained-authz-ranger.md@12
PS3, Line 12: workarounds
I would rephrase this as. "The only exception was that access to Kudu tables 
via Apache Impala could be controlled by fine grained policies in Apache 
Sentry. However, as Kudu became more integrated with the Apache Hadoop 
ecosystem, we saw a need to implement fine grained access control in a way that 
would apply to all tools accessing data in Kudu."



--
To view, visit http://gerrit.cloudera.org:8080/16268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae9a4df40dba8eff7327b76b6d6661e759945e9a
Gerrit-Change-Number: 16268
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Comment-Date: Fri, 31 Jul 2020 16:40:41 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16117 )

Change subject: [blog] Cross post from Boris Tyukin
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16117/3/_posts/2020-05-20-building-near-real-time-big-data-lake.md
File _posts/2020-05-20-building-near-real-time-big-data-lake.md:

http://gerrit.cloudera.org:8080/#/c/16117/3/_posts/2020-05-20-building-near-real-time-big-data-lake.md@186
PS3, Line 186: replicats
> Ah, OK.  Nice to know.  Maybe, it makes sense to add a that link into the p
well, yes, but then I'd be modifying the original post, so I am not sure that's 
appropriate.



--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Comment-Date: Wed, 29 Jul 2020 21:48:13 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16117 )

Change subject: [blog] Cross post from Boris Tyukin
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16117/3/_posts/2020-05-20-building-near-real-time-big-data-lake.md
File _posts/2020-05-20-building-near-real-time-big-data-lake.md:

http://gerrit.cloudera.org:8080/#/c/16117/3/_posts/2020-05-20-building-near-real-time-big-data-lake.md@186
PS3, Line 186: replicats
> so, what's the typo?
https://docs.oracle.com/goldengate/c1230/gg-winux/GGCON/processes-and-terminology.htm#GGCON-GUID-5EF0326C-9058-4C40-8925-98A223388C95



--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Comment-Date: Wed, 29 Jul 2020 20:43:00 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16117 )

Change subject: [blog] Cross post from Boris Tyukin
..


Patch Set 5:

> Yea, should probably update the date. This looks good to go
 > otherwise.

done


--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 5
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Comment-Date: Wed, 29 Jul 2020 20:40:12 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16117 )

Change subject: [blog] Cross post from Boris Tyukin
..


Patch Set 3:

(1 comment)

> (1 comment)
 >
 > Can't find how to comment on a filename so I'm writing this here:
 > can you update the date in the filename to today or tomorrow so
 > that it doesn't look like an old post? Not sure but I think it also
 > has some SEO implications.

done

http://gerrit.cloudera.org:8080/#/c/16117/3/_posts/2020-05-20-building-near-real-time-big-data-lake.md
File _posts/2020-05-20-building-near-real-time-big-data-lake.md:

http://gerrit.cloudera.org:8080/#/c/16117/3/_posts/2020-05-20-building-near-real-time-big-data-lake.md@186
PS3, Line 186: replicats
> the actual term is "replicat".
so, what's the typo?



--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Comment-Date: Wed, 29 Jul 2020 20:39:45 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Hello Alexey Serbin, Attila Bukor, Andrew Wong, Bankim Bhavsar,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16117

to look at the new patch set (#5).

Change subject: [blog] Cross post from Boris Tyukin
..

[blog] Cross post from Boris Tyukin

Original post: 
https://boristyukin.com/building-near-real-time-big-data-lake-part-2/

Rendered version on my fork: https://grishick.github.io/kudu/blog/

I had to use  tags for the larger images
instead of regular markdown in order to make the
larger images fit on page.

Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
---
A _posts/2020-07-30-building-near-real-time-big-data-lake.md
1 file changed, 257 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/16117/5
--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 5
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Hello Alexey Serbin, Attila Bukor, Andrew Wong, Bankim Bhavsar,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16117

to look at the new patch set (#4).

Change subject: [blog] Cross post from Boris Tyukin
..

[blog] Cross post from Boris Tyukin

Original post: 
https://boristyukin.com/building-near-real-time-big-data-lake-part-2/

Rendered version on my fork: https://grishick.github.io/kudu/blog/

I had to use  tags for the larger images
instead of regular markdown in order to make the
larger images fit on page.

Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
---
A _posts/2020-05-20-building-near-real-time-big-data-lake.md
1 file changed, 257 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/16117/4
--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 4
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 

[kudu-CR] KUDU-1802: Add KuduScanner.GetKuduTable

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16251 )

Change subject: KUDU-1802: Add KuduScanner.GetKuduTable
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09a80c6d499987553aef1338db93397a1de2491e
Gerrit-Change-Number: 16251
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 29 Jul 2020 19:00:22 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1422 resize ErrorCollector

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16201 )

Change subject: KUDU-1422 resize ErrorCollector
..


Patch Set 5: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I53731f6367aa84d6435b3bf2143e86164c8eaa1e
Gerrit-Change-Number: 16201
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 Jul 2020 19:08:53 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1422 resize ErrorCollector

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16201 )

Change subject: KUDU-1422 resize ErrorCollector
..


Patch Set 3: Code-Review+1

> (1 comment)

I see your point. Given the current code, the only way this can happen is if 
the instance of ErrorCollector is shared between several threads and is not 
initialized in a thread-safe way. If thread A instantiates ErrorCollector and 
then passes it on to another thread - all is good. If thread A assigns 
ErrorCollector to a non-volatile variable that can be accessed by another 
thread - we have a problem. So, either we have to declare maxCapacity as 
volatile or beware of thread safety when using ErrorCollector instances. I am 
OK with either approach.

 > (1 comment)


--
To view, visit http://gerrit.cloudera.org:8080/16201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I53731f6367aa84d6435b3bf2143e86164c8eaa1e
Gerrit-Change-Number: 16201
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 16 Jul 2020 17:25:11 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1422 resize ErrorCollector

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16201 )

Change subject: KUDU-1422 resize ErrorCollector
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16201/2/java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java:

http://gerrit.cloudera.org:8080/#/c/16201/2/java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java@108
PS2, Line 108: maxCapacity = size;
> I don't this this actually resizes anything. The error queue is already ini
I don't think ArrayDequeue needs to be resized. Per JDK docs "Array deques have 
no capacity restrictions; they grow as necessary to support usage. "



--
To view, visit http://gerrit.cloudera.org:8080/16201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I53731f6367aa84d6435b3bf2143e86164c8eaa1e
Gerrit-Change-Number: 16201
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jul 2020 23:09:45 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1422 resize ErrorCollector

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16201 )

Change subject: KUDU-1422 resize ErrorCollector
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16201/2/java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java:

http://gerrit.cloudera.org:8080/#/c/16201/2/java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java@34
PS2, Line 34:   private volatile int maxCapacity;
I don't see a reason for declaring maxCapacity as volatile, could you explain, 
please?


http://gerrit.cloudera.org:8080/#/c/16201/2/java/kudu-client/src/main/java/org/apache/kudu/client/ErrorCollector.java@86
PS2, Line 86:* Resize ErrorCollector. If size < maxCapacity && size < 
errorQueue.size(), the oldest errors will be discarded
nit: this line seems a bit too long


http://gerrit.cloudera.org:8080/#/c/16201/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestErrorCollector.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestErrorCollector.java:

http://gerrit.cloudera.org:8080/#/c/16201/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestErrorCollector.java@129
PS2, Line 129: // the oldes error is poped
nit: s/oldes/oldest and s/poped/popped



--
To view, visit http://gerrit.cloudera.org:8080/16201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I53731f6367aa84d6435b3bf2143e86164c8eaa1e
Gerrit-Change-Number: 16201
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jul 2020 18:13:07 +
Gerrit-HasComments: Yes

[kudu-CR] [docker] Use ccache and Gradle cache across builds

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16181 )

Change subject: [docker] Use ccache and Gradle cache across builds
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie21ed47983b990e9d2aac419454b9a37a0600334
Gerrit-Change-Number: 16181
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Jul 2020 23:00:45 +
Gerrit-HasComments: No

[kudu-CR] [Web-UI] Upgrade JQuery to 3.5.1

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16153 )

Change subject: [Web-UI] Upgrade JQuery to 3.5.1
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5210d4d23b9b995e2011d32f245ed996c11db3
Gerrit-Change-Number: 16153
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Jul 2020 19:23:55 +
Gerrit-HasComments: No

[kudu-CR] KUDU-3090 Ownership support in Java client

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16125 )

Change subject: KUDU-3090 Ownership support in Java client
..


Patch Set 7: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Jul 2020 20:23:14 +
Gerrit-HasComments: No

[kudu-CR] KUDU-3090 Ownership support in Java client

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16125 )

Change subject: KUDU-3090 Ownership support in Java client
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
File 
java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java:

http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262
PS3, Line 262:
> makes sense, there's a check on the server side now anyway, so I removed it
Done



--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Jul 2020 20:22:49 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3090 Ownership support in Java client

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16125 )

Change subject: KUDU-3090 Ownership support in Java client
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
File 
java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java:

http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262
PS3, Line 262:
why delete this check?


http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java:

http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java@a32
PS3, Line 32:
I am not sure why you are deleting this test. Are we still planning to 
synchronize owner information between HMS and Kudu metadata?



--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Jun 2020 23:27:21 +
Gerrit-HasComments: Yes

[kudu-CR] [master] cache for table locations

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15971 )

Change subject: [master] cache for table locations
..


Patch Set 7: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15971/7/src/kudu/integration-tests/table_locations-itest.cc
File src/kudu/integration-tests/table_locations-itest.cc:

http://gerrit.cloudera.org:8080/#/c/15971/7/src/kudu/integration-tests/table_locations-itest.cc@805
PS7, Line 805: // different entries in the table locations cache.
nit: this test also verifies that multiple requests with the same essential 
parameters do not produce multiple different entries - add this to the comment?



--
To view, visit http://gerrit.cloudera.org:8080/15971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d2a4771ddc455d92a1da00db91c555a21151a23
Gerrit-Change-Number: 15971
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 30 Jun 2020 18:28:40 +
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16117 )

Change subject: [blog] Cross post from Boris Tyukin
..


Patch Set 3:

> > Patch Set 2:
 > >
 > > Link to the Part 1 of the blog is missing. It'd be good link that
 > as well as it sets context.
 >
 > it's actually linked in the introduction

I initially skipped that part of the intro and after Bankim's comment I added 
it back.


--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Comment-Date: Tue, 30 Jun 2020 17:20:09 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16117 )

Change subject: [blog] Cross post from Boris Tyukin
..


Patch Set 3:

> > Patch Set 3:
 > >
 > > > (1 comment)
 > >  >
 > >  > I don't see Boris listed as a possible reviewer, but would be
 > good
 > >  > to send this to him as a heads up.
 > >
 > > I don't see Boris in Gerrit and I cannot add
 > >
 > >  > (1 comment)
 > >  >
 > >  > I don't see Boris listed as a possible reviewer, but would be
 > good
 > >  > to send this to him as a heads up.
 > >
 > > I've PMed Boris on Slack just now. I don't see him in Gerrit
 > though.
 >
 > Yeah that's fine. Only folks who sign up for gerrit can be added :)
 > Even if not added as a formal reviewer, a heads up is the least we
 > can do.

I got an OK from Boris on Slack.


-- 
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Comment-Date: Mon, 29 Jun 2020 22:28:42 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16117 )

Change subject: [blog] Cross post from Boris Tyukin
..


Patch Set 3:

> (1 comment)
 >
 > I don't see Boris listed as a possible reviewer, but would be good
 > to send this to him as a heads up.

I don't see Boris in Gerrit and I cannot add

 > (1 comment)
 >
 > I don't see Boris listed as a possible reviewer, but would be good
 > to send this to him as a heads up.

I've PMed Boris on Slack just now. I don't see him in Gerrit though.


--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Comment-Date: Mon, 29 Jun 2020 19:51:33 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16117 )

Change subject: [blog] Cross post from Boris Tyukin
..


Patch Set 3:

> Link to the Part 1 of the blog is missing. It'd be good link that
 > as well as it sets context.

Done


--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Comment-Date: Sat, 27 Jun 2020 20:02:26 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Hello Bankim Bhavsar,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16117

to look at the new patch set (#3).

Change subject: [blog] Cross post from Boris Tyukin
..

[blog] Cross post from Boris Tyukin

Original post: 
https://boristyukin.com/building-near-real-time-big-data-lake-part-2/

Rendered version on my fork: https://grishick.github.io/kudu/blog/

I had to use  tags for the larger images
instead of regular markdown in order to make the
larger images fit on page.

Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
---
A _posts/2020-05-20-building-near-real-time-big-data-lake.md
1 file changed, 256 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/16117/3
--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Bankim Bhavsar 

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Greg Solovyev has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/16117 )

Change subject: [blog] Cross post from Boris Tyukin
..

[blog] Cross post from Boris Tyukin

Original post: 
https://boristyukin.com/building-near-real-time-big-data-lake-part-2/

Rendered version on my fork: https://grishick.github.io/kudu/blog/

I had to use  tags for the larger images
instead of regular markdown in order to make the
larger images fit on page.

Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
---
A _posts/2020-05-20-building-near-real-time-big-data-lake.md
1 file changed, 253 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/16117/2
--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 2
Gerrit-Owner: Greg Solovyev 

[kudu-CR](gh-pages) [blog] Cross post from Boris Tyukin

[Greg Solovyev (Code Review)]

Greg Solovyev has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16117


Change subject: [blog] Cross post from Boris Tyukin
..

[blog] Cross post from Boris Tyukin

Original post: 
https://boristyukin.com/building-near-real-time-big-data-lake-part-2/

Rendered version on my fork: https://grishick.github.io/kudu/blog/

I had to use  tags for the larger images
instead of regular markdown in order to make the
larger images fit on page.

Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
---
A _posts/2020-05-20-building-near-real-time-big-data-lake.md
1 file changed, 252 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/16117/1
--
To view, visit http://gerrit.cloudera.org:8080/16117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4113e68797653628cdb5b2f92a1105024589d83c
Gerrit-Change-Number: 16117
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev 

[kudu-CR] KUDU-1802: Avoid calls to master when using scan tokens

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16031 )

Change subject: KUDU-1802: Avoid calls to master when using scan tokens
..


Patch Set 14: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/16031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88c1b8392de37dd5e8b7bd8b78a21603ff8b1d1b
Gerrit-Change-Number: 16031
Gerrit-PatchSet: 14
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 24 Jun 2020 19:14:44 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1802: Avoid calls to master when using scan tokens

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16031 )

Change subject: KUDU-1802: Avoid calls to master when using scan tokens
..


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16031/12/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala:

http://gerrit.cloudera.org:8080/#/c/16031/12/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala@83
PS12, Line 83: builder.includeTableMetadata(options.useDriverMetadata)
Just curious, why we have 2 separate flags in Java client, but only one flag to 
rule them all in Scala?



--
To view, visit http://gerrit.cloudera.org:8080/16031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88c1b8392de37dd5e8b7bd8b78a21603ff8b1d1b
Gerrit-Change-Number: 16031
Gerrit-PatchSet: 12
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 24 Jun 2020 16:53:36 +
Gerrit-HasComments: Yes

[kudu-CR] [docs] Add a section about using Gradle checkstyle

[Greg Solovyev (Code Review)]

Greg Solovyev has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16105


Change subject: [docs] Add a section about using Gradle checkstyle
..

[docs] Add a section about using Gradle checkstyle

Coming from Ant/Maven world, I was not aware of Gradle
checkStyle plugin and didn't use it before submitting
a patch to Gerrit. Knowing about checkStyle would have
saved one Gerrit iteration.

To save time for future first time Java committers, I added
a section about using Gradle checkstyle task to check
Java code style.

Pre-rendered on my fork: 
https://github.com/grishick/kudu/blob/master/docs/contributing.adoc#java-code-style

Change-Id: Ica45e5fce418fe40fbdcd354bb0c98dc0a653a65
---
M docs/contributing.adoc
1 file changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/16105/1
--
To view, visit http://gerrit.cloudera.org:8080/16105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica45e5fce418fe40fbdcd354bb0c98dc0a653a65
Gerrit-Change-Number: 16105
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev 

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16101 )

Change subject: [client] KUDU-3152 fix predicates on DATE column
..


Patch Set 3:

> > Patch Set 3:
 > >
 > > Looking at the C++ client for comparison and in list predicate it
 > uses a data type 'KuduValue'. I don't see a mechanism to convert
 > DATE datatype and perhaps VARCHAR too to KuduValue. So that needs
 > fixing as well.
 >
 > My bad, DATE is just a special case of int32.
 > Lack of KuduValue::FromDate() does seem like it's missing.
 I am guessing you are referring to C++ client. What argument type will 
KuduValue::FromDate() take?


--
To view, visit http://gerrit.cloudera.org:8080/16101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2759f1228852b78075bd5278f8f1efd19d0d029e
Gerrit-Change-Number: 16101
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Jun 2020 20:55:17 +
Gerrit-HasComments: No

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16101 )

Change subject: [client] KUDU-3152 fix predicates on DATE column
..


Patch Set 1:

(1 comment)

> (1 comment)
 >
 > It seems the failures in DenseNodeTest.RunTest and
 > MultiMasterIdleConnectionsITest are not relevant.  However, LINT
 > build points to a style issue.

Done. Thanks for pointing this out.

http://gerrit.cloudera.org:8080/#/c/16101/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java:

http://gerrit.cloudera.org:8080/#/c/16101/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java@1288
PS1, Line 1288: Assert.assertEquals("`date` IS NULL", 
KuduPredicate.newIsNullPredicate(dateCol).toString());
> Does it make sense to add a case to verify how 'NOT NULL' predicate convert
Done



--
To view, visit http://gerrit.cloudera.org:8080/16101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2759f1228852b78075bd5278f8f1efd19d0d029e
Gerrit-Change-Number: 16101
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Jun 2020 18:12:25 +
Gerrit-HasComments: Yes

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

[Greg Solovyev (Code Review)]

Hello Alexey Serbin, Kudu Jenkins, Grant Henke,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16101

to look at the new patch set (#3).

Change subject: [client] KUDU-3152 fix predicates on DATE column
..

[client] KUDU-3152 fix predicates on DATE column

Add a missing 'if' statement to route calls
to correct variant of newComparisonPredicate
when value is Object.

Add checks for min/max boundaries of integer
representation of java.sql.Date to match
MIN_DATE_VALUE and MAX_DATE_VALUE in DateUtil.

Add Predicate tests for DATE column.

Change-Id: I2759f1228852b78075bd5278f8f1efd19d0d029e
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
2 files changed, 63 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/16101/3
--
To view, visit http://gerrit.cloudera.org:8080/16101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2759f1228852b78075bd5278f8f1efd19d0d029e
Gerrit-Change-Number: 16101
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

[Greg Solovyev (Code Review)]

Hello Alexey Serbin, Kudu Jenkins, Grant Henke,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16101

to look at the new patch set (#2).

Change subject: [client] KUDU-3152 fix predicates on DATE column
..

[client] KUDU-3152 fix predicates on DATE column

Add a missing 'if' statement to route calls
to correct variant of newComparisonPredicate
when value is Object.

Add checks for min/max boundaries of integer
representation of java.sql.Date to match
MIN_DATE_VALUE and MAX_DATE_VALUE in DateUtil.

Add Predicate tests for DATE column.

Change-Id: I2759f1228852b78075bd5278f8f1efd19d0d029e
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
2 files changed, 56 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/16101/2
--
To view, visit http://gerrit.cloudera.org:8080/16101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2759f1228852b78075bd5278f8f1efd19d0d029e
Gerrit-Change-Number: 16101
Gerrit-PatchSet: 2
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [client] KUDU-3152 fix predicates on DATE column

[Greg Solovyev (Code Review)]

Greg Solovyev has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16101


Change subject: [client] KUDU-3152 fix predicates on DATE column
..

[client] KUDU-3152 fix predicates on DATE column

Add a missing 'if' statement to route calls
to correct variant of newComparisonPredicate
when value is Object.

Add checks for min/max boundaries of integer
representation of java.sql.Date to match
MIN_DATE_VALUE and MAX_DATE_VALUE in DateUtil.

Add Predicate tests for DATE column.

Change-Id: I2759f1228852b78075bd5278f8f1efd19d0d029e
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
2 files changed, 54 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/16101/1
--
To view, visit http://gerrit.cloudera.org:8080/16101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2759f1228852b78075bd5278f8f1efd19d0d029e
Gerrit-Change-Number: 16101
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev 

[kudu-CR] KUDU-3148: [test] Add Java client metrics

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16067 )

Change subject: KUDU-3148: [test] Add Java client metrics
..


Patch Set 7: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16067/5/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java:

http://gerrit.cloudera.org:8080/#/c/16067/5/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java@122
PS5, Line 122: counter(RPC_REQUESTS_METRIC, rpcTags(client, connection, 
rpc)).increment();
> Given we would like to have metrics on by default at some point I think it'
Done



--
To view, visit http://gerrit.cloudera.org:8080/16067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c63835dd717c2c1e1dca06ed5dea3c2cadcd018
Gerrit-Change-Number: 16067
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Jun 2020 03:40:18 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3148: [test] Add Java client metrics

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16067 )

Change subject: KUDU-3148: [test] Add Java client metrics
..


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16067/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduMetrics.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduMetrics.java:

http://gerrit.cloudera.org:8080/#/c/16067/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduMetrics.java@39
PS5, Line 39: consider
nit: considered


http://gerrit.cloudera.org:8080/#/c/16067/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduMetrics.java@97
PS5, Line 97: createdDisabledRegistry
nit: is there an extra "d" in the method name, i.e. should it be 
"createDisabledRegistry" not "createdDisabledRegistry"?


http://gerrit.cloudera.org:8080/#/c/16067/5/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java:

http://gerrit.cloudera.org:8080/#/c/16067/5/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java@122
PS5, Line 122: if (rpc.attempt == 1) {
Shouldn't we have a code path here that avoids any overhead of metrics? Even 
though, by default, the registry will be disabled, this code path, still adds 
some overhead of calling several getters, setters and a constructor.



--
To view, visit http://gerrit.cloudera.org:8080/16067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c63835dd717c2c1e1dca06ed5dea3c2cadcd018
Gerrit-Change-Number: 16067
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 12 Jun 2020 17:00:41 +
Gerrit-HasComments: Yes

[kudu-CR](branch-1.12.x) WIP [docs] Kudu 1.12 release notes draft

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15685 )

Change subject: WIP [docs] Kudu 1.12 release notes draft
..


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@75
PS5, Line 75: If setting
:   `--time_source=auto`, Kudu masters and tablet servers use the 
built-in NTP
:   client synchronized with dedicated NTP servers available via 
host-only
:   network in AWS and GCE cloud environments, otherwise Kudu 
masters and tablet
:   servers rely on local machine's clock synchronized by NTP
I think this sentence needs to be broken up. E.g.:

When the option is set to `--time_source=auto`, Kudu masters and tablet servers 
use the built-in NTP client. Built-in NTP client is synchronized with dedicated 
NTP servers available via host-only networks in AWS and GCE cloud environments. 
When dedicated NTP servers are not available, Kudu masters and tablet servers 
rely on local machine's clock synchronized by NTP.


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@105
PS5, Line 105: * Kudu tablet servers and masters now expose a metric for the 
number of tablet
should we mention the name of the metric here?
Also, I suggest moving this section to be right before or right after the 
section about metric severity levels.


http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@118
PS5, Line 118: * The built-in NTP client is now fully supported as the time 
source for Kudu's
I think this section and section about chronyd should be moved up right above 
the section about --time_source



--
To view, visit http://gerrit.cloudera.org:8080/15685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a
Gerrit-Change-Number: 15685
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Lieber-Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Comment-Date: Wed, 15 Apr 2020 18:56:40 +
Gerrit-HasComments: Yes

[kudu-CR] [docs] add guide to symbolize stack addresses

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15728 )

Change subject: [docs] add guide to symbolize stack addresses
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/15728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I299768a49cc52324482c410064bb590393499689
Gerrit-Change-Number: 15728
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Apr 2020 20:22:58 +
Gerrit-HasComments: No

[kudu-CR] Update version to 1.13.0-SNAPSHOT

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15684 )

Change subject: Update version to 1.13.0-SNAPSHOT
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15684/1/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/15684/1/docs/release_notes.adoc@88
PS1, Line 88: 11
is this the latest compatible version or do we always say that it is compatible 
with previous version?



--
To view, visit http://gerrit.cloudera.org:8080/15684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I109a3f36feb7fc8cc5d8137aa41b576f3a30954e
Gerrit-Change-Number: 15684
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Apr 2020 01:43:53 +
Gerrit-HasComments: Yes

[kudu-CR] WIP [util] utilities to get info on cloud instance

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14866 )

Change subject: WIP [util] utilities to get info on cloud instance
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc
File src/kudu/util/cloud/instance_metadata.cc:

http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc@86
PS1, Line 86: "169.254.169.123"
> We could place some configuration properties into a configuration file, but
I agree with Vlad here. IMHO, IPs and URLs that are not in our control should 
not be hardcoded. A run-time flag with default value seems reasonable. We 
wouldn't want to be making an emergency release when any of these IPs or URLs 
change.



--
To view, visit http://gerrit.cloudera.org:8080/14866
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083f4803decaef5d6e7d44184bbd98b074d2578b
Gerrit-Change-Number: 14866
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Comment-Date: Fri, 17 Jan 2020 20:31:48 +
Gerrit-HasComments: Yes

[kudu-CR] [RELEASING.adoc] add memo on 3rd-party license policy

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14615 )

Change subject: [RELEASING.adoc] add memo on 3rd-party license policy
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie264b320e03d06b83c32f78304f4cb55854207f7
Gerrit-Change-Number: 14615
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Nov 2019 18:56:49 +
Gerrit-HasComments: No

[kudu-CR] CapturingLogAppender: synchronize access to captured log text

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14431 )

Change subject: CapturingLogAppender: synchronize access to captured log text
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a5d0775cba5aa1d9df5484b5e9e621c908d42d
Gerrit-Change-Number: 14431
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Oct 2019 20:47:52 +
Gerrit-HasComments: No

[kudu-CR](branch-1.11.x) www: ensure all href values are enclosed in single or double quotes

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14430 )

Change subject: www: ensure all href values are enclosed in single or double 
quotes
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1b9cc8f97390617d6b0a6e183081483ca7ad6a0
Gerrit-Change-Number: 14430
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Oct 2019 20:49:00 +
Gerrit-HasComments: No

[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14404/6/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/6/docs/release_notes.adoc@157
PS6, Line 157: * A quick-start example of using Apache Spark to load, query, 
and modify
nit: I'd change these two bullet points to active voice


http://gerrit.cloudera.org:8080/#/c/14404/6/docs/release_notes.adoc@188
PS6, Line 188: * Decoding of deltas' timestamps has been optimized
"Optimized decoding of deltas' timestamps" - I'd use active voice instead of 
passive, because it is shorter and because we use it in most other items.



--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 
Gerrit-Comment-Date: Thu, 10 Oct 2019 22:42:04 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2800

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14295 )

Change subject: KUDU-2800
..


Patch Set 1:

(2 comments)

This commit needs a description

http://gerrit.cloudera.org:8080/#/c/14295/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

http://gerrit.cloudera.org:8080/#/c/14295/1/src/kudu/consensus/consensus_queue.cc@604
PS1, Line 604: // LOG(INFO) << " HealthReportPB::HEALTHY " << 
peer.ToString();
Why leave this commented line here?


http://gerrit.cloudera.org:8080/#/c/14295/1/src/kudu/integration-tests/raft_config_change-itest.cc
File src/kudu/integration-tests/raft_config_change-itest.cc:

http://gerrit.cloudera.org:8080/#/c/14295/1/src/kudu/integration-tests/raft_config_change-itest.cc@496
PS1, Line 496:   
follower->mutable_flags()->emplace_back("--tablet_open_bootstrap_inject_latency_ms=25000");
does bootstrap need to be 5x follower_unavailable_considered_failed_sec, or can 
it be just a bit longer than follower_unavailable_considered_failed_sec?



--
To view, visit http://gerrit.cloudera.org:8080/14295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ae309bb10ebe40e89c74d132623c89448d0a8f1
Gerrit-Change-Number: 14295
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Comment-Date: Tue, 24 Sep 2019 21:49:53 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2949: fix tablet stats race while ProcessTabletReport

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14245 )

Change subject: KUDU-2949: fix tablet stats race while ProcessTabletReport
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14245/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/14245/1/src/kudu/master/catalog_manager.cc@4235
PS1, Line 4235:   // Right now the tserver only reports the LEADER replicas 
its own.
I know, this comment was here already, but something is not right with how it 
is phrased. Does it mean "LEADER replicas that it owns" ?


http://gerrit.cloudera.org:8080/#/c/14245/1/src/kudu/master/catalog_manager.cc@4239
PS1, Line 4239:   // We use the tablet lock to prevent concurrent update 
the table metrics.
This last line of comment seems to belong inside UpdateStats method


http://gerrit.cloudera.org:8080/#/c/14245/1/src/kudu/master/catalog_manager.cc@5370
PS1, Line 5370: void TabletInfo::UpdateStats(ReportedTabletStatsPB stats) {
Perhaps, this method should be renamed now that it updates both stats and 
metrics?



--
To view, visit http://gerrit.cloudera.org:8080/14245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic89070bcdb201e2a620efd8fc50041cebd8a7e26
Gerrit-Change-Number: 14245
Gerrit-PatchSet: 1
Gerrit-Owner: helifu 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Sep 2019 21:35:27 +
Gerrit-HasComments: Yes

[kudu-CR] [thirdparty] add SO REUSEPORT for chronyd NTP socket

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14228 )

Change subject: [thirdparty] add SO_REUSEPORT for chronyd NTP socket
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee26fcf93976dd7affe77254751016bcbf398620
Gerrit-Change-Number: 14228
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Sep 2019 16:26:01 +
Gerrit-HasComments: No

[kudu-CR] [mini cluster] introduce 'builtin' clock source

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14227 )

Change subject: [mini_cluster] introduce 'builtin' clock source
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14227/2/src/kudu/integration-tests/master_migration-itest.cc
File src/kudu/integration-tests/master_migration-itest.cc:

http://gerrit.cloudera.org:8080/#/c/14227/2/src/kudu/integration-tests/master_migration-itest.cc@202
PS2, Line 202:   cluster.reset();
What is the reason for this change?



--
To view, visit http://gerrit.cloudera.org:8080/14227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c334ae6fa1fb12b033de7f8e8584b8dd3aa2d32
Gerrit-Change-Number: 14227
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Sep 2019 16:22:29 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2069 p1: add persistent tserver maintenance mode

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14217 )

Change subject: KUDU-2069 p1: add persistent tserver maintenance mode
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14217/4/src/kudu/master/ts_state-test.cc
File src/kudu/master/ts_state-test.cc:

http://gerrit.cloudera.org:8080/#/c/14217/4/src/kudu/master/ts_state-test.cc@189
PS4, Line 189:   ASSERT_EQ(kNone, ts_manager_->GetTServerState(kTServer));
Worth checking ASSERT_EQ(1, ts_manager_->GetCount()); after sending heartbeat?



--
To view, visit http://gerrit.cloudera.org:8080/14217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib669b43b3cee171c4c7dbd54041e29c30cb9f767
Gerrit-Change-Number: 14217
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 12 Sep 2019 20:05:30 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2069 p2: stop placement on servers in maintenance mode

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14220 )

Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3ca41a3b3c8625bec0470e9604df86e91b4952
Gerrit-Change-Number: 14220
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 12 Sep 2019 17:56:46 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14221 )

Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/ts_state-test.cc
File src/kudu/master/ts_state-test.cc:

http://gerrit.cloudera.org:8080/#/c/14221/2/src/kudu/master/ts_state-test.cc@328
PS2, Line 328:   NO_FATALS(send_req_check_failed("must contain tserver state 
change"));
IMHO, these error messages should be defined as string constants somewhere, 
because they are used twice in the code base.



--
To view, visit http://gerrit.cloudera.org:8080/14221
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d565bd745507f2511b91a96d2d446240c5406b5
Gerrit-Change-Number: 14221
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Sep 2019 17:49:35 +
Gerrit-HasComments: Yes

[kudu-CR] [docs] Kudu source code indexing in Eclipse

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14193 )

Change subject: [docs] Kudu source code indexing in Eclipse
..


Patch Set 4: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia214e536ff3a7ddafb3ab969b50ed5f97f4c725a
Gerrit-Change-Number: 14193
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Sep 2019 00:58:19 +
Gerrit-HasComments: No

[kudu-CR] [examples] Added example shell scripts to start and stop Kudu cluster

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14192 )

Change subject: [examples] Added example shell scripts to start and stop Kudu 
cluster
..


Patch Set 1:

is there a related Apache jira ticket?


--
To view, visit http://gerrit.cloudera.org:8080/14192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e7bb66d4cce84d00d346bf50154f449d48e7a54
Gerrit-Change-Number: 14192
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Sep 2019 22:59:14 +
Gerrit-HasComments: No

[kudu-CR] [documentation] Adde alternative recommendation to deal with Kudu source code indexing in Eclipse

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14193 )

Change subject: [documentation] Adde alternative recommendation to deal with 
Kudu source code indexing in Eclipse
..


Patch Set 1:

(1 comment)

nit: in commit message "Add", not "Adde"

http://gerrit.cloudera.org:8080/#/c/14193/1/README.adoc
File README.adoc:

http://gerrit.cloudera.org:8080/#/c/14193/1/README.adoc@435
PS1, Line 435: hadoop, hive and sentry directories.
nit: trailing spaces



--
To view, visit http://gerrit.cloudera.org:8080/14193
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia214e536ff3a7ddafb3ab969b50ed5f97f4c725a
Gerrit-Change-Number: 14193
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Sep 2019 22:58:39 +
Gerrit-HasComments: Yes

[kudu-CR] [master] update tags for --master client location assignment enabled

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14190 )

Change subject: [master] update tags for 
--master_client_location_assignment_enabled
..


Patch Set 1: Code-Review+1

LGTM


--
To view, visit http://gerrit.cloudera.org:8080/14190
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb7391174a37f1a774f83b964bee854922cadcd
Gerrit-Change-Number: 14190
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Sep 2019 18:29:42 +
Gerrit-HasComments: No

[kudu-CR] [hms] Sync external HMS tables with purge property

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14179 )

Change subject: [hms] Sync external HMS tables with purge property
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14179/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File 
java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:

http://gerrit.cloudera.org:8080/#/c/14179/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@265
PS2, Line 265:
nit: why 3 lines of space here?


http://gerrit.cloudera.org:8080/#/c/14179/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@319
PS2, Line 319:   {
what's the point of {} here and above where there is no try-catch?



--
To view, visit http://gerrit.cloudera.org:8080/14179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I942515c015b1a4a63cf08383c331c4e19350c312
Gerrit-Change-Number: 14179
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 05 Sep 2019 20:59:01 +
Gerrit-HasComments: Yes

[kudu-CR] Remove experimental tags from NVM block cache gflags

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13830 )

Change subject: Remove experimental tags from NVM block cache gflags
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/13830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b58118116ecc11b2eaa5cec4a9e72c29ac27f8
Gerrit-Change-Number: 13830
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang 
Gerrit-Comment-Date: Tue, 09 Jul 2019 23:05:45 +
Gerrit-HasComments: No

[kudu-CR] [docs] Make the quickstart link more obvious

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13828 )

Change subject: [docs] Make the quickstart link more obvious
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/13828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica5831dd0871be4e146777fdc1a178cc397d9593
Gerrit-Change-Number: 13828
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Jul 2019 21:10:35 +
Gerrit-HasComments: No

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13669 )

Change subject: [docs] Add 1.10.0 release notes
..


Patch Set 5: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/13669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I040df9debdf78f1bd932915164a1b6ba490be135
Gerrit-Change-Number: 13669
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 21 Jun 2019 17:26:03 +
Gerrit-HasComments: No

[kudu-CR] [java] Add “default” database to ITBLL

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13588 )

Change subject: [java] Add “default” database to ITBLL
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/13588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d9da9b6d3616b3fc7713d18f1aae202ffca23e4
Gerrit-Change-Number: 13588
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Tue, 11 Jun 2019 23:32:34 +
Gerrit-HasComments: No

[kudu-CR] [java] Add “default” database to ITBLL

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13588 )

Change subject: [java] Add “default” database to ITBLL
..


Patch Set 1:

Will these tests pass with this change when HMS sync is disabled?


--
To view, visit http://gerrit.cloudera.org:8080/13588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d9da9b6d3616b3fc7713d18f1aae202ffca23e4
Gerrit-Change-Number: 13588
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:46:26 +
Gerrit-HasComments: No

[kudu-CR] WIP: [KUDU-442] Add Kudu support for Hive

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13483 )

Change subject: WIP: [KUDU-442] Add Kudu support for Hive
..


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/13483/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java:

http://gerrit.cloudera.org:8080/#/c/13483/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@249
PS1, Line 249: //Preconditions.checkArgument(row.getSchema() == 
table.getSchema(),
Why is this being commented out and what are the effects of this on Kudu java 
client?


http://gerrit.cloudera.org:8080/#/c/13483/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/KuduHiveUtils.java
File java/kudu-hive/src/main/java/org/apache/kudu/hive/KuduHiveUtils.java:

http://gerrit.cloudera.org:8080/#/c/13483/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/KuduHiveUtils.java@88
PS1, Line 88:   LOG.debug("Not importing credentials for service " + 
service +
perhaps this would be slightly more elegant and more informative:

LOG.debug("Not importing credentials for service {} (expecting service {})", 
tok.getService(), service)


http://gerrit.cloudera.org:8080/#/c/13483/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/KuduHiveUtils.java@92
PS1, Line 92: LOG.debug("Importing credentials for service " + service);
Use format instead of string concatenation?


http://gerrit.cloudera.org:8080/#/c/13483/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/KuduInputFormat.java
File java/kudu-hive/src/main/java/org/apache/kudu/hive/KuduInputFormat.java:

http://gerrit.cloudera.org:8080/#/c/13483/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/KuduInputFormat.java@94
PS1, Line 94: List locations = new 
ArrayList<>(token.getTablet().getReplicas().size());
nit: I am not sure that using ArrayList instead of simple String[] is 
reasonable here. Looks like the only advantage is using List.add method without 
having to keep a counter, while 'locations' has to be converted to String[] 
anyway when passed to KuduInputSplit



--
To view, visit http://gerrit.cloudera.org:8080/13483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdcc72c4099dc40a7a2efa59c0c62f63902733d4
Gerrit-Change-Number: 13483
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 31 May 2019 20:04:58 +
Gerrit-HasComments: Yes

[kudu-CR](branch-1.8.x) Change all dependency sources to https

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13486 )

Change subject: Change all dependency sources to https
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/13486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb8b549cacdd1c94fcd0b214433a0827ce23de8
Gerrit-Change-Number: 13486
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 31 May 2019 18:19:40 +
Gerrit-HasComments: No

[kudu-CR] [www] highlight primary key in tserver Web UI

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13187 )

Change subject: [www] highlight primary key in tserver Web UI
..


Patch Set 3: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/13187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57dbcea938f9c6b436c7c4f98e7e9a89f2995784
Gerrit-Change-Number: 13187
Gerrit-PatchSet: 3
Gerrit-Owner: helifu 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 May 2019 00:28:00 +
Gerrit-HasComments: No

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

[Greg Solovyev (Code Review)]

Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12847

to look at the new patch set (#6).

Change subject: [KUDU-1344] Part 1: cmake install for executables
..

[KUDU-1344] Part 1: cmake install for executables

This change adds cmake install commands for
kudu, kudu-tserver and kudu-master executables.

Running 'sudo make install' installs the following:
 - kudu-tserver and kudu-master executables in /usr/local/sbin
 - Kudu client executable in /usr/local/bin
 - Kudu client library in /usr/local/lib64
 - Kudu client headers in /usr/local/include/kudu

This change also adds 3 cmake flags (ON by default):
 - KUDU_CLIENT_INSTALL
 - KUDU_TSERVER_INSTALL
 - KUDU_MASTER_INSTALL

setting these flags to OFF directs cmake to skip
corresponding install commands.

Update documentation to reflect these changes.

Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
---
M docs/installation.adoc
M src/kudu/master/CMakeLists.txt
M src/kudu/tools/CMakeLists.txt
M src/kudu/tserver/CMakeLists.txt
4 files changed, 133 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/6
--
To view, visit http://gerrit.cloudera.org:8080/12847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 6
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12847 )

Change subject: [KUDU-1344] Part 1: cmake install for executables
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12847/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12847/5//COMMIT_MSG@23
PS5, Line 23: setting these flags to OFF directs cmake to skip
> Nit: They aren't skip flags anymore. Should be OFF.
Done



--
To view, visit http://gerrit.cloudera.org:8080/12847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 6
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 27 Mar 2019 19:49:58 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

[Greg Solovyev (Code Review)]

Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12847

to look at the new patch set (#5).

Change subject: [KUDU-1344] Part 1: cmake install for executables
..

[KUDU-1344] Part 1: cmake install for executables

This change adds cmake install commands for
kudu, kudu-tserver and kudu-master executables.

Running 'sudo make install' installs the following:
 - kudu-tserver and kudu-master executables in /usr/local/sbin
 - Kudu client executable in /usr/local/bin
 - Kudu client library in /usr/local/lib64
 - Kudu client headers in /usr/local/include/kudu

This change also adds 3 cmake flags (ON by default):
 - KUDU_CLIENT_INSTALL
 - KUDU_TSERVER_INSTALL
 - KUDU_MASTER_INSTALL

setting these flags to ON directs cmake to skip
corresponding install commands.

Update documentation to reflect these changes.

Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
---
M docs/installation.adoc
M src/kudu/master/CMakeLists.txt
M src/kudu/tools/CMakeLists.txt
M src/kudu/tserver/CMakeLists.txt
4 files changed, 133 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/5
--
To view, visit http://gerrit.cloudera.org:8080/12847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 5
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

[Greg Solovyev (Code Review)]

Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12847

to look at the new patch set (#4).

Change subject: [KUDU-1344] Part 1: cmake install for executables
..

[KUDU-1344] Part 1: cmake install for executables

This change adds cmake install commands for
kudu, kudu-tserver and kudu-master executables.

Running 'sudo make install' installs the following:
 - kudu-tserver and kudu-master executables in /usr/local/sbin
 - Kudu client executable in /usr/local/bin
 - Kudu client library in /usr/local/lib64/
 - Kudu client headers in /usr/local/include/kudu

This change also adds 3 cmake flags (ON by default):
 - KUDU_CLIENT_INSTALL
 - KUDU_TSERVER_INSTALL
 - KUDU_MASTER_INSTALL

setting these flags to ON directs cmake to skip
corresponding install commands.

Update documentation to reflect these changes.

Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
---
M docs/installation.adoc
M src/kudu/master/CMakeLists.txt
M src/kudu/tools/CMakeLists.txt
M src/kudu/tserver/CMakeLists.txt
4 files changed, 133 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/4
--
To view, visit http://gerrit.cloudera.org:8080/12847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 4
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

[Greg Solovyev (Code Review)]

Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12847

to look at the new patch set (#3).

Change subject: [KUDU-1344] Part 1: cmake install for executables
..

[KUDU-1344] Part 1: cmake install for executables

This change adds cmake install commands for
kudu, kudu-tserver and kudu-master executables.

Running 'sudo make install' installs the following:
 - kudu-tserver and kudu-master executables in /usr/local/sbin
 - Kudu client executable in /usr/local/bin
 - Kudu client library in /usr/local/lib/
 - Kudu client headers in /usr/local/include/kudu

This change also adds 3 cmake flags (ON by default):
 - KUDU_CLIENT_INSTALL
 - KUDU_TSERVER_INSTALL
 - KUDU_MASTER_INSTALL

setting these flags to ON directs cmake to skip
corresponding install commands.

Update documentation to reflect these changes.

Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
---
M docs/installation.adoc
M src/kudu/master/CMakeLists.txt
M src/kudu/tools/CMakeLists.txt
M src/kudu/tserver/CMakeLists.txt
4 files changed, 133 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/3
--
To view, visit http://gerrit.cloudera.org:8080/12847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12847 )

Change subject: [KUDU-1344] Part 1: cmake install for executables
..


Patch Set 2:

(11 comments)

http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc
File docs/installation.adoc:

PS2:
> Some of the new lines are too long; can you wrap?
Should I wrap to 100 characters? I had my editor set up to 120 and noticed that 
some text here was already over 100.


http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc@172
PS2, Line 172: * Kudu client library in `/usr/local/lib/`
> You sure this lands in lib and not lib64?
Thanks for catching this. This lands in lib64.


http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc@295
PS2, Line 295: * Kudu client library in `/usr/local/lib/`
> You sure this lands in lib and not something with x86_64 in it?
it lands in /usr/local/lib64


http://gerrit.cloudera.org:8080/#/c/12847/2/docs/installation.adoc@406
PS2, Line 406: * Kudu client library in `/usr/local/lib/`
> Likewise I thought this might end up in lib64.
Done


http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/master/CMakeLists.txt
File src/kudu/master/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/master/CMakeLists.txt@101
PS2, Line 101: kudu-master
> Nit: "the Kudu Master executable"
Done


http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/master/CMakeLists.txt@104
PS2, Line 104: else(KUDU_MASTER_INSTALL)
> You can omit KUDU_MASTER_INSTALL from the body of the else() and endif().
Done


http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tools/CMakeLists.txt
File src/kudu/tools/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tools/CMakeLists.txt@143
PS2, Line 143: option(KUDU_CLIENT_INSTALL "Whether to install the Kudu client 
executable" ON)
> It's not really the "client executable" as the "CLI" or "command line tool"
Indeed. I will also change to "command line tool" in the documentation.


http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tools/CMakeLists.txt@148
PS2, Line 148: endif(KUDU_CLIENT_INSTALL)
> Nit: separate from the next line with an empty line.
Done


http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt
File src/kudu/tserver/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt@a142
PS2, Line 142:
> Could you restore this? I think it's nice to see these "headers" separate t
Done


http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt@149
PS2, Line 149: kudu-tserver
> "the Kudu Tablet Server executable"
Done


http://gerrit.cloudera.org:8080/#/c/12847/2/src/kudu/tserver/CMakeLists.txt@154
PS2, Line 154: endif(KUDU_TSERVER_INSTALL)
> Nit: separate with a blank line.
Done



--
To view, visit http://gerrit.cloudera.org:8080/12847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 2
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 27 Mar 2019 19:05:46 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

[Greg Solovyev (Code Review)]

Hello Kudu Jenkins, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12847

to look at the new patch set (#2).

Change subject: [KUDU-1344] Part 1: cmake install for executables
..

[KUDU-1344] Part 1: cmake install for executables

This change adds cmake install commands for
kudu, kudu-tserver and kudu-master executables.

Running 'sudo make install' installs the following:
 - kudu-tserver and kudu-master executables in /usr/local/sbin
 - Kudu client executable in /usr/local/bin
 - Kudu client library in /usr/local/lib/
 - Kudu client headers in /usr/local/include/kudu

This change also adds 3 cmake flags (ON by default):
 - KUDU_CLIENT_INSTALL
 - KUDU_TSERVER_INSTALL
 - KUDU_MASTER_INSTALL

setting these flags to ON directs cmake to skip
corresponding install commands.

Update documentation to reflect these changes.

Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
---
M docs/installation.adoc
M src/kudu/master/CMakeLists.txt
M src/kudu/tools/CMakeLists.txt
M src/kudu/tserver/CMakeLists.txt
4 files changed, 123 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/2
--
To view, visit http://gerrit.cloudera.org:8080/12847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 2
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

[Greg Solovyev (Code Review)]

Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12847 )

Change subject: [KUDU-1344] Part 1: cmake install for executables
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12847/1//COMMIT_MSG@18
PS1, Line 18: This change also adds 3 cmake flags (off by default):
> instead of the "double negative" flags, can we add on-by-default flags whic
Good point about double negative flags.



--
To view, visit http://gerrit.cloudera.org:8080/12847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 25 Mar 2019 22:46:13 +
Gerrit-HasComments: Yes

[kudu-CR] [KUDU-1344] Part 1: cmake install for executables

[Greg Solovyev (Code Review)]

Greg Solovyev has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12847


Change subject: [KUDU-1344] Part 1: cmake install for executables
..

[KUDU-1344] Part 1: cmake install for executables

This change adds cmake install commands for
kudu, kudu-tserver and kudu-master executables.

Running 'sudo make install' installs the following:
 - kudu-tserver and kudu-master executables in /usr/local/sbin
 - Kudu client executable in /usr/local/bin
 - Kudu client library in /usr/local/lib/
 - Kudu client headers in /usr/local/include/kudu

This change also adds 3 cmake flags (off by default):
 - KUDU_SKIP_CLIENT_INSTALL
 - KUDU_SKIP_TSERVER_INSTALL
 - KUDU_SKIP_MASTER_INSTALL

setting these flags to ON directs cmake to skip
corresponding install commands.

Update documentation to reflect these changes.

Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
---
M docs/installation.adoc
M src/kudu/master/CMakeLists.txt
M src/kudu/tools/CMakeLists.txt
M src/kudu/tserver/CMakeLists.txt
4 files changed, 123 insertions(+), 47 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12847/1
--
To view, visit http://gerrit.cloudera.org:8080/12847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic020941343efc9192bf615c0c8a30b3d9eee91d7
Gerrit-Change-Number: 12847
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev