Re: [OpenJDK 2D-Dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow

Fix sounds good. The test has a bug 47 static final Font fnt = new Font("Time New Roamn", Font.PLAIN, 1).deriveFont(12.0f); "Roamn" should be "Roman". But since Linux is very unlikely to have that font, I think you should use Font.SERIF instead. Actually I am unclear why you need to

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

There's a lot to think about here but I have some requests to first clean up the proposed code to conform to coding standards. I see lots of lines > 80 chars. Please fix I see if(foo){ and else{ which should be "if (foo) {" and "else {" Basically always have a space before { and after ) and

Re: [OpenJDK 2D-Dev] RFR: 8191522: Remove references to Lucida fonts from OpenJDK sources

http://cr.openjdk.java.net/~prr/8191522.1 uploaded. Adding .. the removal of .. a couple of uses of lucida - sanity check of lucida in font config files is no longer needed. - J2DBench demo opts change from lucida to dialog. Not sure why it had lucida anyway .. -phil. On 5/16/18, 4:08 PM,

Re: [OpenJDK 2D-Dev] RFR: 8198412 : MonospacedGlyphWidthTest.java may fail on Solaris

On 5/11/18, 2:58 PM, Sergey Bylokhov wrote: Looks fine, Note that the problem list should be updated. Yes, I remembered that after sending out the webrev. Fixed in the push. -phil. On 11/05/2018 14:46, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8198412 webrev:

[OpenJDK 2D-Dev] RFR: 8198991: Move Java2D demo to the open repository

Bug: https://bugs.openjdk.java.net/browse/JDK-8198991 Webrev: http://cr.openjdk.java.net/~prr/8198991/ This moves the Java 2D demo from "closed" to "open". It is now called "J2Ddemo" to avoid any trademark questions. This has already been reviewed internally and the images here are OK to keep.

Re: [OpenJDK 2D-Dev] RFR [11] JDK-8202580: Dashed BasicStroke randomly painted incorrectly, may freeze application

On 5/7/18, 9:27 AM, Laurent Bourgès wrote: Phil, Le dim. 6 mai 2018 à 01:11, Philip Race <philip.r...@oracle.com <mailto:philip.r...@oracle.com>> a écrit : Looks fine to me. Did you run the rendering related regression tests ? I ran all tests in sun/java2d/marlin. What

Re: [OpenJDK 2D-Dev] RFR [11] JDK-8202580: Dashed BasicStroke randomly painted incorrectly, may freeze application

Looks fine to me. Did you run the rendering related regression tests ? I am not sure if a backport to 10 will be approved under the new guidelines : http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2018-April/000102.html -phil. On 5/4/18, 5:30 AM, Laurent Bourgès wrote: Sergey,

Re: [OpenJDK 2D-Dev] RFR: JDK-8202052: Disable warnings when building libawt with VS2017

+1 -phil. On 4/19/18, 3:41 PM, Mikael Vidstedt wrote: Please review the following change which disables some warnings in libawt which show up when building with VS2017: bug: https://bugs.openjdk.java.net/browse/JDK-8202052 webrev:

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

On 3/23/18, 11:56 AM, Sergey Bylokhov wrote: Hi, Prahalad. A few small comments about the test: - Is it possible to test all installed ImageWriterSpi? It seems that the test itself is not a JPEG plugin specific? None of the other plugins support thumbnails so they will all return 0

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

On 3/23/18, 2:21 AM, Jayathirth D V wrote: Hi Prahalad, Change looks fine. Test case works properly before and after the code change. ? You mean it does not fail before the fix ? It definitely fails for me before the fix. Since we are touching getNumThumbnailsSupported() function and it is

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi Laurent, It took me I at least 5 tries to get all the way through this. I don't have any substantial comments, just a few clean up questions. What is this in Curve.java + DCurve.java ? +if (false) { +dax = 0.0d; +day = 0.0d; +dbx = 0.0d; +

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

This is a tricky one. Since Oracle no longer ships 32 bit JDKs for any platform for the new releases, then there aren't resources or effort being put into making sure it still builds. Our build systems might still support it, but for how long? It might effectively have to become a "port" that

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

he license and provide the text only for one or for both. On 09/03/2018 15:28, Philip Race wrote: Just to be clear, I mean we don't import it to each of the source files. But it is there in the file legal/freetype.md in this webrev. On 3/9/18, 3:26 PM, Philip Race wrote: No. -phil. On 3/9/1

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

Just to be clear, I mean we don't import it to each of the source files. But it is there in the file legal/freetype.md in this webrev. On 3/9/18, 3:26 PM, Philip Race wrote: No. -phil. On 3/9/18, 3:23 PM, Sergey Bylokhov wrote: Hi, Phil Headers of the new files refer to LICENSE.TXT. Should

Re: [OpenJDK 2D-Dev] RFR: 8193017: Import freetype sources into OpenJDK source tree

No. -phil. On 3/9/18, 3:23 PM, Sergey Bylokhov wrote: Hi, Phil Headers of the new files refer to LICENSE.TXT. Should we import it as well? On 09/03/2018 14:10, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8193017 Webrev: http://cr.openjdk.java.net/~prr/8193017/index.html

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198333 ProblemList should be updated for headless mode

That is fine. -phil. On 2/21/18, 9:34 AM, Sergey Bylokhov wrote: On 21/02/2018 08:49, Philip Race wrote: I am not sure it has mac specific code, I'll reevaluate this test in JDK-8198406. This is mac-specific. It looks for specific fonts by name that exist only on MacOS. And moreover

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198333 ProblemList should be updated for headless mode

On 2/21/18, 7:45 AM, Sergey Bylokhov wrote: Hi, Prasanta. I have updated the tests mentioned in your previous email: http://cr.openjdk.java.net/~serb/8198333/webrev.10 /java/awt/font/TextLayout/TestAATMorxFont.java should be for mac only if (!osName.startsWith("mac")) { 42

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8195131: Dead code removal for changes present in JDK-8176795

Looks fine. If anyone needs this in the future they can add back this or an overload that does the pre-multiplication. -phil. On 1/18/18, 12:44 PM, Prahalad Kumar Narayanan wrote: Hello Jay I understand that the last argument to XRColor.setColorValues (int pixel, boolean pre) is set to

[OpenJDK 2D-Dev] RFR: 8193483: Update client-libs ProblemList.txt

bug: https://bugs.openjdk.java.net/browse/JDK-8193483 webrev; http://cr.openjdk.java.net/~prr/8193483/ An update to the ProblemList to exclude most of the tests that fail on Windows. There are still a number of tests that have "errors" like timeouts that need to be added. Also I need to do

Re: [OpenJDK 2D-Dev] bug 8146238 - Java Queue Flusher on MacOS

There was a reply to the proposal when it was submitted : http://mail.openjdk.java.net/pipermail/2d-dev/2015-December/006130.html suggesting a different approach, but there was no follow-up. So I don't really know what the current status is .. and that was a long time ago. -phil. On 1/25/18,

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

The discussion about SLE seems to have taken over. This was originally about zLinux. If it actually makes sense for zLinux for JDK 11 then I have no objections to the proposed toolchain specific patch ... If it does not make sense for 11 then I think you should look only at 8u and prepare a

Re: [OpenJDK 2D-Dev] jdk-hs ppc64le build error, probably related to libpng update

This all sounds fine to me. Definitely we should report this upstream to see what they say but clearly we aren't bound to wait for an answer from there since this is a build breakage for PPC. If someone upstream comes back with a better answer we can update the fix. I think this png update will

Re: [OpenJDK 2D-Dev] RFR : 8193515 : AIX : new Harfbuzz 1.7.1 version fails to compile

+1 from me .. yes push to jdk/jdk10. -phil. On 12/18/17, 1:51 AM, Volker Simonis wrote: Hi Matthias, the change looks good and I can sponsor it. I'd just propose to slightly change the comment to "..by the overloaded versions of 'cmp' in IntType" if you don't mind. There's no need for a new

Re: [OpenJDK 2D-Dev] Problems logging in to http://bugs.openjdk.java.net

Perhaps o...@openjdk.java.net for things like this but I'll forward this onto some folks who may be able to help. -phil. On 12/14/17, 12:21 AM, Dmitry Batrak wrote: Hello, I'm sorry to bother you with this, but I regularly have problems logging in to OpenJDK issue tracker

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

-November/008741.html I will push tomorrow to jdk forrest as phil & sergey? approved 2D changes. This RFR thread remains open for the JavaFX patch that Kevin started to test & review. Cheers, Laurent 2017-12-10 18:36 GMT+01:00 Philip Race <philip.r...@oracle.com <mailto:philip.r

Re: [OpenJDK 2D-Dev] RFR JDK-8184429: Path clipper added in Marlin2D & MarlinFX 0.8.0

I'm giving this an OK. I've looked at the code, if not the maths, and run our regression test suite. I had a bit of trouble with my full baseline run against which to compare so I've re-run just the test failures that seem like they might go anywhere need this code. and they were

[OpenJDK 2D-Dev] RFR: 8190280 [macos] Font2DTest demo started failing for Arabic range from JDK 8 u162 b01 on Mac

Bug: https://bugs.openjdk.java.net/browse/JDK-8190280 Webrev: http://cr.openjdk.java.net/~prr/8190280/ This is a JDK8 version of the bug https://bugs.openjdk.java.net/browse/JDK-8172967 which affected harfbuzz in JDK 9 It is triggered by a couple of things but mainly that the Mac font code

Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in java.awt.image.FilteredImageSource.startProduction

The screenshot shows you directly calling this method in your test which the documentation says you are not supposed to do. So I am not able to be 100% sure that the test you have re-creates what the submitter saw .. in his stack trace you have below it seems to be valid. But to have a NPE at

[OpenJDK 2D-Dev] RFR: 8170681 : Remove fontconfig header files from JDK source tree

Bug: https://bugs.openjdk.java.net/browse/JDK-8170681 Webrev: http://cr.openjdk.java.net/~prr/8170681/ This fix removes the copy of fontconfig.h from the JDK sources. The file was originally included in the JDK sources because the build platforms of the day were too old to include it. It will

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

I think for JDK 8 you can pass down a flag to decide whether to include or exclude CFF. This flag would be the value of FontUtilities.isOpenJDK() and that should tell us what we need. That would preserve the status quo for Oracle JDK and it would be our problem if the same bug were then

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8186987:NullPointerException in RasterPrinterJob without PrinterResolution

es printers may not be supporting low 300 DPI resolution going forward. I may be wrong in my understanding. You could wait for other's review & follow up. Thank you Have a good day Prahalad N. -Original Message- From: Prasanta Sadhukhan Sent: Thursday, August 31, 2017 3:39 PM To:

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

I have filed https://bugs.openjdk.java.net/browse/JDK-8186364 and created and submitted the CSR for it : https://bugs.openjdk.java.net/browse/JDK-8186365 -phil. On 8/17/17, 8:05 AM, Philip Race wrote: OK I'll handle the bureaucracy. -phil. On 8/17/17, 7:31 AM, Laurent Bourgès wrote: Phil

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

size. An application can use this operation to minimize the * storage of a path. * * @since 10 */ +public abstract void trimToSize(); It will match the proposed patch. Thanks, Laurent

Re: [OpenJDK 2D-Dev] [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

to be different .. -phil. -- Jon On 05/12/2017 04:54 PM, Philip Race wrote: Does this in any way match the rest of the docs ? Or is everyone left to style things how they want. I thought (?) maybe there is to be some javadoc tool support for CSS styles. Also why are all the table summaries

Re: [OpenJDK 2D-Dev] [9] Review Request: 8180326 Update the tables in java.desktop to be HTML-5 friendly

Adding 2d-dev because a number of the files are 2D. What is the general reason for changing the appearance of the tables? -phil. On 5/12/17, 4:25 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9-dev. This fix is a part of the effort to make all javadoc in jdk9 be compatible

Re: [OpenJDK 2D-Dev] JDK-8178091 : Bug I will workin on

phil. so with this each time we call repaint() ; it call our new repaint() method with the sync(); and then it works well 2017-04-17 16:24 GMT+02:00 Philip Race <philip.r...@oracle.com <mailto:philip.r...@oracle.com>>:

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

aurent 2017-04-21 0:04 GMT+02:00 Laurent Bourgès <bourges.laur...@gmail.com <mailto:bourges.laur...@gmail.com>>: Sorry for the typo, I added also a newline before @since: 2017-04-20 23:04 GMT+02:00 Philip Race <philip.r...@oracle.com <mailto:philip.r...@oracle.c

Re: [OpenJDK 2D-Dev] [10] RFR 8078192: Path2D storage trimming

You have a capital letter here and I think it must be lower case .. 2499 * @Since 10 -phil. On 4/20/17, 1:58 PM, Laurent Bourgès wrote: Hi Phil & Jim, Here is the updated webrev: http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.2/

Re: [OpenJDK 2D-Dev] JDK-8178091 : Bug I will workin on

Per openjdk rules, we cannot review or accept webrevs hosted anywhere other than cr.openjdk.java.net [1] Generally you ask someone who has a login there to do it for you Or you may try submitting the patch in-line to this email if it is short. Not an attachment. It will get stripped. -phil.

Re: [OpenJDK 2D-Dev] RFR: 8178457: Remove link to 2D guide from Line2D javadoc

The boilerplate for all the other classes would be to completely remove the entire sentence being modified. No mention of coordinate system at all. I can do that ... if it is what you meant. -phil. On 4/11/17, 3:01 PM, Jim Graham wrote: It's silly to include this statement in Line2D when no

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

This would be a reasonable thing to try to fix before 9 GA I think. Can't affect many tests since the code is new .. -phil. On 3/29/17, 1:22 PM, Sergey Bylokhov wrote: Hi, Jim, Phil. I have started to use MRI and a new Robot in some of the tests and wonder why the MultiResolutionImage does

Re: [OpenJDK 2D-Dev] [9] Review request for 8167102: [macosx] PrintRequestAttributeSet breaks page size set using PageFormat

If the test is manual anyway, why does it not display a dialog so it is easier to run. On mac you can always then save as PDF so the "virtual printer" isn't needed. Note: this assumes you are using the native dialog not the Swing one. Does this in some way change the test so that it passed

Re: [OpenJDK 2D-Dev] RFR: JDK-8177135: OpenJDK 9 freetype needs msvcr100.dll

+1 -phil. On 3/29/17, 6:16 AM, Magnus Ihse Bursie wrote: On 2017-03-29 15:00, Erik Joelsson wrote: Hello, The build of freetype used internally at Oracle when building OpenJDK builds (for the reference implementation) is very old. It was also built using Visual Studio 2010, which makes it

Re: [OpenJDK 2D-Dev] [9] JDK-8176287 :[macosx] The print test crashed with Nimbus L

The problem seems to have been that you were allocating zero bytes in the old code : 950 CGFloat* colors= (CGFloat*)calloc(0, sizeof(CGFloat)*length); 960 qsdo->gradientInfo->colordata = (CGFloat*)calloc(0, sizeof(CGFloat)*4*length); Regarding the new code, whilst it seems

Re: [OpenJDK 2D-Dev] RFR: 8170552: [macosx] Wrong rendering of diacritics on macOS

You are right ! I missed that. OpenJDK rules rquire it be contributed under GPL v2 (not classpath) The test needs to be updated or deleted ASAP (today would be good). -phil. On 2/15/17, 4:47 AM, Sergey Bylokhov wrote: I am not sure, but Is the apache license in the test can be accepted in

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

Jay -Original Message- From: Jayathirth D V Sent: Wednesday, February 08, 2017 3:41 PM To: Jim Graham; Philip Race; 2d-dev@openjdk.java.net <mailto:2d-dev@openjdk.java.net> Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8147002:[macosx] Arabic character cannot be rendered on MacOS X

I am OK with this if you can confirm that removing Lucida Sans Regular from the JDK does not cause any nasty exceptions. Apple use the PostScript name but our lookup code should work for the TrueType name. So overall I think this should be fine - from visual inspection - and assuming it has

[OpenJDK 2D-Dev] RFR: 8172967: [macosx] Exception while working with layout for text containing unmappable character

http://cr.openjdk.java.net/~prr/8172967/ https://bugs.openjdk.java.net/browse/JDK-8172967 Full evaluation in the bug report. Short summary: avoid AIOB and NPE when Mac glyph mapper returns a negated unicode which is misinterpreted as having composite font slot 255 -phil.

Re: [OpenJDK 2D-Dev] [8u] RFR: 8170578: CUPS Printing is broken with Ubuntu 16.10 (CUPS 2.2)

Looks fine. Please send email to 8u-dev asking for approval to push. -phil. On 2/2/17, 9:38 PM, Prasanta Sadhukhan wrote: Hi All, This is a backport review request to jdk8u for an issue fixed in jdk9 for CUPS printing issue in ubuntu16.10 (mail-thread:

Re: [OpenJDK 2D-Dev] RFR: 8170950: Text is displayed in bold when fonts are installed into symlinked folder

The point being the fonts end up being registered by the canonical path and that then is the basis for comparison used when we come back here ? I think this will be OK. May I assume you tested this thoroughly. I don't mean a new regression test - which is not easy. I mean to make sure it didn't

Re: [OpenJDK 2D-Dev] [9] RFR: [JDK-6852563] ArrayOutOfBoundException when reading RLE8 compressed bitmap

That was deja vu all over again. I wonder if there is some additional sharing that can be done here between RLE4 and RLE8. But not right now .. just something to think about. +1 -phil. On 2/6/17, 7:46 PM, Prahalad Kumar Narayanan wrote: Hello Everyone Good day to you. Request your time in

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170578: The Pages Range From in print dialog is disabled

ain and if necessary update this in 10. -phil. On 1/18/17, 3:11 AM, Prasanta Sadhukhan wrote: Ok. Updated webrev just in case we are not reading the protocol wrongly. http://cr.openjdk.java.net/~psadhukhan/8170578/webrev.02/ Regards Prasanta On 1/12/2017 8:04 AM, Philip Race wrote: I am loo

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8152561: Is it allowed to have zero value for count in TIFFField.createArrayForType() for the rationals

} else if((dataType == TIFFTag.TIFF_RATIONAL I know that someone (ahem Brian ;-)) has a lot of "if(" code in here but please make any new ones "if (" Other than that, +1 -phil. On 1/24/17, 1:08 PM, Brian Burkhalter wrote: Hi Jay, I think line 910 of TIFFField needs to state “and count !=

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8167278: ArrayIndexOutOfBoundsException when calling ImageIO.read(InputStream) with RLE4 BMP

Thank you once again Have a good day Prahalad N. --- Original message --- From: Brian Burkhalter Sent: Saturday, January 21, 2017 6:05 AM To: Philip Race Cc: 2d-dev@openjdk.java.net; Prahalad Kumar Narayanan Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8167278: ArrayIndexOutOfBoundsException when

Re: [OpenJDK 2D-Dev] [9] Review request for 8163889: [macosx] Can't print from browser on Mac OS X

/ <http://cr.openjdk.java.net/%7Edmarkov/8163889/webrev.02/> Thanks, Dmitry On 21 Jan 2017, at 00:24, Philip Race <philip.r...@oracle.com <mailto:philip.r...@oracle.com>> wrote: Hi Dmitry, > 29 * @run main/othervm PrintCrashTest why othervm ? I don't think that is st

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8167278: ArrayIndexOutOfBoundsException when calling ImageIO.read(InputStream) with RLE4 BMP

ii. Handling of Delta encoding (0x00 0x02 xOffset yOffset) . The scanline of decoded image should be copied to destination if yOff shifts next pixel's location to other line . Secondly, the scanline index should be limited by boundary value after x and y

Re: [OpenJDK 2D-Dev] Review Request JDK-8172559 [PIT][TEST_BUG] Move @test to be 1st annotation in java/awt/image/Raster/TestChildRasterOp.java

. And I'm sorry about that. There will be merge :-(. We cannot push this buggy test to master: jtreg may stop the whole run. -yan Regards, Prem *From:*Philip Race *Sent:* Thursday, January 12, 2017 12:09 PM *To:* Prem Balakrishnan; Jonathan Gibbons *Cc:* Ajit Ghaisas; Prasanta Sadhukhan; 2d

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170578: The Pages Range From in print dialog is disabled

I am looking at this and the hold up is I can't remember the protocol readIPPResponse() is trying to follow. Without that understanding it is hard to say much .. so I need to go read up and remember .. Two comments : There is an extra space in if (responseMap.length> 1) { The test update

[OpenJDK 2D-Dev] RFR: 6232267: TrueType Fonts which have only Apple platform names cannot be loaded

Bug : https://bugs.openjdk.java.net/browse/JDK-6232267 Webrev : http://cr.openjdk.java.net/~prr/6232267/ Fonts such as "Menlo" on OS X have no Microsoft names (see https://www.microsoft.com/typography/otspec/name.htm) so historically we rejected these. Now that we support OS X, this is more of

Re: [OpenJDK 2D-Dev] [9] Review Request: 8140266 Performance loss between jdk8 and jdk9 on Maskfill

lib/Awt2dLibraries.gmk.sdiff.html> Build change looks ok, but I too think a comment explaining why is a good idea. /Erik On 2016-12-23 15:49, Philip Race wrote: Looks OK to me although it is a very cryptic option so maybe include a comment that it is for performance with some versions of gcc ... -phil. On 12

Re: [OpenJDK 2D-Dev] [9] Review Request: 8140266 Performance loss between jdk8 and jdk9 on Maskfill

Looks OK to me although it is a very cryptic option so maybe include a comment that it is for performance with some versions of gcc ... -phil. On 12/23/16, 3:15 AM, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk9. The change add an additional gcc option to the libawt lib to

[OpenJDK 2D-Dev] RFR: 8130737: AffineTransformOp can't handle child raster with non-zero x-offset

Bug: https://bugs.openjdk.java.net/browse/JDK-8130737 Webrev : http://cr.openjdk.java.net/~prr/8130737/ If a child raster is created with a non-zero x-offset then subsequently in the code that validates the raster for imaging operations we may incorrectly calculate that the image exceeds the

Re: [OpenJDK 2D-Dev] RFR(XXS): 8170954: non-ASCII characters in lcms and harfbuzz break Windows builds on some locales

This is fine by me. These are imported libraries so we just disable the warnings rather than fix them. The only question I had is that US English is the only supported build environment and RE builds will always use that .. everything else is "good luck", Unless something changed to affect

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169725: cannot use TIFFField(TIFFTag tag, int value) for TIFF_LONG values greater than Integer.MAX_VALUE

hal...@oracle.com> wrote: I was expecting that; will update. Thanks, Brian On Dec 7, 2016, at 5:03 PM, Philip Race<philip.r...@oracle.com> wrote: Looks OK except for the same question about using 0x. -phil. On 12/6/16, 12:31 PM, Brian Burkhalter wrote: Continuing from thread [1

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169725: cannot use TIFFField(TIFFTag tag, int value) for TIFF_LONG values greater than Integer.MAX_VALUE

nks, Brian [1] http://mail.openjdk.java.net/pipermail/2d-dev/2016-November/007963.html [2] http://cr.openjdk.java.net/~bpb/8169725/webrev.01/ [3] http://cr.openjdk.java.net/~bpb/8169725/webrev.00/ On Nov 23, 2016, at 8:03 AM, Philip Race<philip.r...@oracle.com> wrote: +1 -phil

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169728: Missing sign checks in TIFFField(TIFFTag tag, int type, int count, Object data) for TIFFTag.TIFF_LONG

One "PS" why say 4294967295 in the spec where 0x is probably more immediately to most programmers that it is not a random choice of number ? -phil On 12/7/16, 4:56 PM, Philip Race wrote: +1 Yes, it needs a CCC update. A quick "bug fix" one. -phil. On 12/

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169728: Missing sign checks in TIFFField(TIFFTag tag, int type, int count, Object data) for TIFFTag.TIFF_LONG

+1 Yes, it needs a CCC update. A quick "bug fix" one. -phil. On 12/6/16, 2:03 PM, Brian Burkhalter wrote: Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8169728 Patch: http://cr.openjdk.java.net/~bpb/8169728/webrev.00/ To the primary constructor

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

I didn't eyeball what you changed but JPRT is now happy. The build passes on all platforms... -phil. On 12/5/16, 2:47 PM, Lindenmaier, Goetz wrote: Hi Phil, sorry for that! I fixed it, there is an other occurrence, too. I double checked all the casts, there was also a mp_flags<-> mp_sign

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105

in jtreg @bug tag before pushing. Regards, Ajit *From:*Prasanta Sadhukhan *Sent:* Wednesday, November 16, 2016 11:55 AM *To:* Ajit Ghaisas; Philip Race; 2d-dev *Subject:* Re: [OpenJDK 2D-Dev] [9] RFR JDK-8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since

Re: [OpenJDK 2D-Dev] RFR: 8167103: Intermittent font loading failure on macOS with JFXPanel application

opyDescription(_ err: CFError!)]||, so that we can know the reason for failure better. Regards Prasanta | On 11/22/2016 8:15 AM, Philip Race wrote: On 11/21/16, 4:17 PM, Sergey Bylokhov wrote: Looks fine, but are you sure that we need such mix of logging in the debug build? Do you mean &quo

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8169725: cannot use TIFFField(TIFFTag tag, int value) for TIFF_LONG values greater than Integer.MAX_VALUE

+1 -phil On 11/16/16, 12:22 PM, Brian Burkhalter wrote: Here’s an updated version of the proposed changes. Thanks, Brian --- a/src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFImageMetadata.java +++

Re: [OpenJDK 2D-Dev] RFR: 8167103: Intermittent font loading failure on macOS with JFXPanel application

tsfontactivatefromfilereference?language=objc Not sure exactly what you mean there but if you mean that the Apple docs seem to have "deleted" the specification, yes, and that was one reason to upgrade .. I didn't even know what the limitations were on the old method. -phil.

[OpenJDK 2D-Dev] RFR: 8167103: Intermittent font loading failure on macOS with JFXPanel application

Bug: https://bugs.openjdk.java.net/browse/JDK-8167103 Webrev: http://cr.openjdk.java.net/~prr/8167103/ This bug is a deadlock in MacOS platform font code when JavaFX and Java2D are both calling platform font APIs. This can happen in the context of Swing inter-op for FX. It was previously seen

Re: [OpenJDK 2D-Dev] [9] RFR 8160888: [PIT] What to expect of updated java/awt/print/PrinterJob/Margins.java

+1 although ... * ie ix=72 iy=72 iw=451 ih=697 and paper wid=595 that's an "eg" not an "ie" -phil. On 11/7/16, 2:28 AM, Prasanta Sadhukhan wrote: Please find the modified webrev taking care of the suggested changes http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.02/ Regards

Re: [OpenJDK 2D-Dev] [PATCH] Make automatic font substitution on macOS work for surrogate pairs

Hi, I can file a bug on this if I can't find one. If you can email me the test it will help even if it is not checked in. -phil. On 10/26/16, 6:28 AM, Dmitry Batrak wrote: Hello, I'd like to propose a patch to make automatic font substitution on macOS work for surrogate pairs. I have a

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

+1 -phil. On 10/25/16, 11:01 PM, Prasanta Sadhukhan wrote: Please find the webrev with modified testcase http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.03/ Regards Prasanta On 10/26/2016 2:45 AM, Philip Race wrote: Hi, This looks to work properly although I have a couple of nits

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

anta Sadhukhan wrote: On 10/22/2016 4:50 AM, Philip Race wrote: Well it is confusing since in particular this exact change is in both webrevs :- http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.01/src/java.desktop/macosx/native/libawt_lwawt/awt/QuartzSurfaceData.m.sdiff.html Yes. Th

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

On Oct 24, 2016, at 9:34 AM, Philip Race <philip.r...@oracle.com <mailto:philip.r...@oracle.com>> wrote: I think I saw that one but the weird final part of the name put me off. For comparison here's how they reference the OpenType (font) spec :- https://www.microsoft.com/en-u

Re: [OpenJDK 2D-Dev] RFR: 8168364: [macosx] Delete unused class NSPrintinfo

Can I get a 2nd reviewer on this one ? -phil. On 10/20/16, 3:52 AM, Sergey Bylokhov wrote: Looks fine. On 20.10.16 2:35, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8168364 webrev : http://cr.openjdk.java.net/~prr/8168364/ NSPrintInfo is an Attribute so it can

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

is https://msdn.microsoft.com/en-us/library/dd183391(v=vs.85).aspx which is where we point from JavaFX docs. Vadim On 24.10.2016 18:57, Philip Race wrote: I've poked around the Microsoft website and didn't turn up a location I am sure we could rely on. A top-level link to microsoft.com and some

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

as much. Could be that for BMP we are out of luck as there is no “real” specification AFAIK. Brian On Oct 24, 2016, at 8:30 AM, Philip Race <philip.r...@oracle.com <mailto:philip.r...@oracle.com>> wrote: Do not point to wikipedia. If we must point to external links we w

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168367: Table in javax.imageio package description does not mention TIFF

Do not point to wikipedia. If we must point to external links we want to point to a specification in the most "official" place that exists .. one maintained by the owner of that spec. Strictly that even becomes a part of the SE spec. Wikipedia is not a place we'd ever want to say Java SE

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

handle REPEAT/REFLECT. http://cr.openjdk.java.net/~psadhukhan/8162796/webrev.01/ Have tested with different fractions, stops, color. Regards Prasanta On 9/28/2016 2:06 AM, Philip Race wrote: Hi, LinearGradientPaint has three options as to how it is extended beyond the end point https

[OpenJDK 2D-Dev] RFR: 8168364: [macosx] Delete unused class NSPrintinfo

bug: https://bugs.openjdk.java.net/browse/JDK-8168364 webrev : http://cr.openjdk.java.net/~prr/8168364/ NSPrintInfo is an Attribute so it can presumably be stuffed in an AttributeSet. Apart from being inaccessible to apps and unused it is not a good idea. It was perhaps once used to

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

te: I guess you could reorder the calls for CFRelease(font); and CFRelease(desc); so the desc gets released first in two locations under family == NULL and name == NULL. Just for the sake of consistency. Other than that, +1. Vadim On 16.10.2016 19:09, Philip Race wrote: Anyone ? I'd like to get t

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

for the sake of consistency. Other than that, +1. Vadim On 16.10.2016 19:09, Philip Race wrote: Anyone ? I'd like to get this backported to 8u this week so it can the 8u122 release which will enter RDP2 soon http://openjdk.java.net/projects/jdk8u/releases/8u122.html Although I have failed to find any

Re: [OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

so it could be as early as a week from now .. -phil. On 10/12/16, 1:06 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8089573 Webrev : http://cr.openjdk.java.net/~prr/8089573/ See the bug for some images showing the problem of scrambled text when printing. Although only

[OpenJDK 2D-Dev] RFR: 8089573: [macosx] Incorrect char to glyph mapping printing on OSX 10.10

Bug: https://bugs.openjdk.java.net/browse/JDK-8089573 Webrev : http://cr.openjdk.java.net/~prr/8089573/ See the bug for some images showing the problem of scrambled text when printing. Although only JavaFX is affected the solution is entirely on the JDK side. JavaFX looks up some UI "system"

[OpenJDK 2D-Dev] RFR: 8166034: [macosx] Non-AA Serif font always displays as regular - no bold or oblique.

https://bugs.openjdk.java.net/browse/JDK-8166034 Non-AA fonts aren't always being bolded on OS X. FWIW I believe this is in part a platform (OS) bug since it is terribly inconsistent across fonts and in some cases even sizes. So we need to look into why but it definitely isn't something that

Re: [OpenJDK 2D-Dev] [8u] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock.

I have verified JCK, jtreg and JPRT for updated changes in JDK8u. Thanks, Jay *From:*Philip Race *Sent:* Friday, September 23, 2016 10:10 PM *To:* Jayathirth D V *Cc:* 2d-dev *Subject:* Re: [OpenJDK 2D-Dev] [8u] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock. You ca

Re: [OpenJDK 2D-Dev] [9] Review Request: 8146042 Offscreen rendering is different from onscreen one

that means this is bad hardware .. seems Dmitri added this from the beginning. I overlooked this in the past because I was focused on the system property settings. -phil. On 9/9/16, 8:14 AM, Philip Race wrote: No .. that would be an incompatible change that might surprise a lot of peopl

Re: [OpenJDK 2D-Dev] [8u Backport] Fix for JDK-8158356 : SIGSEGV when attempting to rotate BufferedImage using AffineTransform by NaN degrees

webrev is still the same. http://cr.openjdk.java.net/~aghaisas/8158356/8u_backport/webrev.00/ Request you to approve this 8u backport. Regards, Ajit -Original Message- From: Jim Graham Sent: Friday, September 02, 2016 1:16 AM To: Ajit Ghaisas; Philip Race; 2d-dev Subject: Re

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8166685: We should unpin stream and pixel buffer in case of setjmp during writeImage in JPEG.

+1 -phil. On 9/26/16, 12:35 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8166685 Webrev : http://cr.openjdk.java.net/~jdv/8166685/webrev.00/

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8162796: [macosx] LinearGradientPaint and RadialGradientPaint are not printed on OS X.

Hi, LinearGradientPaint has three options as to how it is extended beyond the end point https://docs.oracle.com/javase/8/docs/api/java/awt/MultipleGradientPaint.CycleMethod.html So far as I can see this code (and perhaps quartz) can only handle NO_CYCLE .. If REFLECT or REPEAT are

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8164931 : Verify if writer.abort() works properly for all writers in IIOWriteProgressListener.

11:00 AM To: Jayathirth D V; Sergey Bylokhov; Philip Race; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8164931 : Verify if writer.abort() works properly for all writers in IIOWriteProgressListener. Is it not required to call abortRequested() after 1340

Re: [OpenJDK 2D-Dev] Request for Review: JDK-8162591 All existing gradient paint implementations have issues with coordinates/sizes larger than Short.MAX_VALUE (exactly) on any Linux systems

On 9/26/16, 12:50 PM, Clemens Eisserer wrote: Thanks a lot for the feedback. The fix seems fine .. is there a possibility to have a regression test? Perhaps based on the code in the bug ? Please find an automated regression test at: http://93.83.133.214/8162591/HugeGradientTest.java OK ..

Re: [OpenJDK 2D-Dev] Request for Review: JDK-8162591 All existing gradient paint implementations have issues with coordinates/sizes larger than Short.MAX_VALUE (exactly) on any Linux systems

Clemens, The fix seems fine .. is there a possibility to have a regression test? Perhaps based on the code in the bug ? -phil. On 9/26/16, 8:48 AM, Clemens Eisserer wrote: Hello, The cause of JDK-8162591 is Java2D's gradient implementation allowing for coordinates to be specified using

Re: [OpenJDK 2D-Dev] RFR: 8162531solaris.fontconfig.properties needs updating

, 8:17 AM, Sergey Bylokhov wrote: The changes looks fine, should we increment version=1 to other version or it is not used? Unrelated question is how we validate all these paths if some of them are absent? On 23.09.16 8:08, Philip Race wrote: PING .. any takers on this two week old RFR ? -phil

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8165947: One more page printed before the test page with OpenJDK.

16 9:47 PM, Philip Race wrote: The JDK changes are fine but I don't think the test is. It assumes that the system default is no banner page. You need to update the test to check what the system default is (banner or no banner) and have the tester "expect" whatever that happens to be.

Re: [OpenJDK 2D-Dev] [8u] RFR JDK-8162461: Hang due to JNI up-call made whilst holding JNI critical lock.

a new Bug and add the RELEASE_ARRAY() call in writeImage() or I have to check-in this change under JDK-8162461 only? After check-in of this modification I will raise new webrev for 8u backport. Thanks, Jay *From:*Philip Race *Sent:* Thursday, September 22, 2016 9:51 PM *To:* Jayathirth D V

<    1   2   3   4   5   6   7   >