[GitHub] [samza] Zhangyx39 opened a new pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-04 Thread GitBox
Zhangyx39 opened a new pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986 Implemented CouchbaseTableReadFunction Implemented CouchbaseTableWriteFunction Tested with unit tests and integration test ---

[GitHub] [samza] Zhangyx39 commented on issue #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-04 Thread GitBox
Zhangyx39 commented on issue #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#issuecomment-480089720 @weisong44 @dengpanyin I created a new merge request against the real master instead of my forked master. -

[GitHub] [samza] shanthoosh opened a new pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-04 Thread GitBox
shanthoosh opened a new pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987 **Changes:** Currently the input topic partitions assigned to a container of a samza job is stored

[GitHub] [samza] shanthoosh commented on issue #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-04 Thread GitBox
shanthoosh commented on issue #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#issuecomment-480138826 @prateekm You have the most context about this, would you please review this when

[GitHub] [samza] shanthoosh edited a comment on issue #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-04 Thread GitBox
shanthoosh edited a comment on issue #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#issuecomment-480138826 @prateekm You have the most context about this, would you please review thi

[GitHub] [samza] dnishimura commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
dnishimura commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272647386 ## File path: samza-core/src/main/java/org/apache/samza/coo

[GitHub] [samza] dnishimura commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
dnishimura commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272645814 ## File path: samza-core/src/main/java/org/apache/samza/sta

[GitHub] [samza] prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272661714 ## File path: samza-core/src/main/java/org/apache/samza/coord

[GitHub] [samza] prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272663864 ## File path: samza-core/src/main/java/org/apache/samza/start

[GitHub] [samza] prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272661854 ## File path: samza-core/src/main/java/org/apache/samza/coord

[GitHub] [samza] prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272664116 ## File path: samza-core/src/main/java/org/apache/samza/start

[GitHub] [samza] prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272663362 ## File path: samza-core/src/main/java/org/apache/samza/runti

[GitHub] [samza] prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272664590 ## File path: samza-core/src/main/java/org/apache/samza/coord

[GitHub] [samza] Sanil15 commented on a change in pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test URL: https://github.com/apache/samza/pull/985#discussion_r272688728 ## File path: build.gradle ## @@ -819,8 +819,6 @@ project(":samza-test_$scalaSuffix") { c

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272680715 ## File path: samza-core/src/main/java/org/apache/samza/run

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272677523 ## File path: samza-core/src/main/java/org/apache/samza/coo

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272680171 ## File path: samza-core/src/main/java/org/apache/samza/sta

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272677610 ## File path: samza-core/src/main/java/org/apache/samza/coo

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272677802 ## File path: samza-core/src/main/java/org/apache/samza/sta

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272677565 ## File path: samza-core/src/main/java/org/apache/samza/coo

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272680128 ## File path: samza-core/src/main/java/org/apache/samza/sta

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271986739 ## File path: samza-api/src/main/java/org/apache/samza/operators/MessageStream.java ## @@

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272272257 ## File path: samza-core/src/main/java/org/apache/samza/operators/MessageStreamImpl.java ##

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272272594 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/OutputOperatorImpl.java

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272265928 ## File path: samza-api/src/main/java/org/apache/samza/operators/functions/SinkFunction.java ##

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272267806 ## File path: samza-api/src/main/java/org/apache/samza/operators/MessageStream.java ## @@

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271986718 ## File path: samza-api/src/main/java/org/apache/samza/operators/MessageStream.java ## @@

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272272521 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/OutputOperatorImpl.java

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272277109 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationT

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272272292 ## File path: samza-core/src/main/java/org/apache/samza/operators/MessageStreamImpl.java ##

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272700251 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationT

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272276618 ## File path: samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationT

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r271987520 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/SendToTableOperatorImpl.java

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272272058 ## File path: samza-core/src/main/java/org/apache/samza/operators/MessageStreamImpl.java ##

[GitHub] [samza] Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal

2019-04-05 Thread GitBox
Sanil15 commented on a change in pull request #984: Samza 2116: Making sendTo(table), sendTo(stream) non-terminal URL: https://github.com/apache/samza/pull/984#discussion_r272276265 ## File path: samza-core/src/test/java/org/apache/samza/execution/TestJobGraphJsonGenerator.java ##

[GitHub] [samza] dnishimura commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
dnishimura commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272765084 ## File path: samza-core/src/main/java/org/apache/samza/run

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-05 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r272768540 ## File path: samza-core/src/main/java/org/apache/samza/run

[GitHub] [samza] prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-08 Thread GitBox
prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r273150796 ## File path: samza-core/src/main/java/org/apache/samza/conta

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-08 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r273160957 ## File path: samza-core/src/main/java/org/apache/samza/con

[GitHub] [samza] shanthoosh commented on issue #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-08 Thread GitBox
shanthoosh commented on issue #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#issuecomment-480930676 @prateekm I have attached the application master logs before and after the fix:

[GitHub] [samza] shanthoosh edited a comment on issue #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-08 Thread GitBox
shanthoosh edited a comment on issue #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#issuecomment-480930676 @prateekm I have attached the application master logs before and after the

[GitHub] [samza] rmatharu commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-08 Thread GitBox
rmatharu commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r273175100 ## File path: samza-core/src/main/java/org/apache/samza/coord

[GitHub] [samza] prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-08 Thread GitBox
prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r273175885 ## File path: samza-core/src/main/java/org/apache/samza/conta

[GitHub] [samza] prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-08 Thread GitBox
prateekm commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r273175885 ## File path: samza-core/src/main/java/org/apache/samza/conta

[GitHub] [samza] rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-08 Thread GitBox
rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273180179 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/BaseCouchbaseTableFunction.

[GitHub] [samza] rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-08 Thread GitBox
rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273180831 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/BaseCouchbaseTableFunction.

[GitHub] [samza] rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-08 Thread GitBox
rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273181670 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/CouchbaseTableReadFunction.

[GitHub] [samza] rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-08 Thread GitBox
rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273182043 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/CouchbaseTableWriteFunction

[GitHub] [samza] rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-08 Thread GitBox
rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273184049 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/BaseCouchbaseTableFunction.

[GitHub] [samza] Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-08 Thread GitBox
Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273199213 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/BaseCouchbaseTableFunction

[GitHub] [samza] Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-08 Thread GitBox
Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273200466 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/BaseCouchbaseTableFunction

[GitHub] [samza] Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-08 Thread GitBox
Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273200535 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/CouchbaseTableReadFunction

[GitHub] [samza] rmatharu commented on a change in pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test

2019-04-08 Thread GitBox
rmatharu commented on a change in pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test URL: https://github.com/apache/samza/pull/985#discussion_r273200756 ## File path: samza-test/src/main/resources/hello-stateful-world.samza ## @@ -18,7 +18,7 @@

[GitHub] [samza] Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-08 Thread GitBox
Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273203113 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/BaseCouchbaseTableFunction

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-08 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r273225617 ## File path: samza-core/src/main/java/org/apache/samza/coo

[GitHub] [samza] shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-08 Thread GitBox
shanthoosh commented on a change in pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987#discussion_r273237564 ## File path: samza-core/src/main/java/org/apache/samza/con

[GitHub] [samza] abhishekshivanna opened a new pull request #988: Ability to configure application type on YARN deploys

2019-04-08 Thread GitBox
abhishekshivanna opened a new pull request #988: Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988 We can use this config to distinguish between different job types/APIs Eg: - SamzaApplication (HighLevel, LowLevel) - SamzaSQL - S

[GitHub] [samza] vjagadish1989 commented on a change in pull request #988: Ability to configure application type on YARN deploys

2019-04-08 Thread GitBox
vjagadish1989 commented on a change in pull request #988: Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273247505 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ## @@ -31,6 +3

[GitHub] [samza] vjagadish1989 commented on a change in pull request #988: Ability to configure application type on YARN deploys

2019-04-08 Thread GitBox
vjagadish1989 commented on a change in pull request #988: Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273248013 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ## @@ -31,6 +3

[GitHub] [samza] shanthoosh merged pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence.

2019-04-08 Thread GitBox
shanthoosh merged pull request #987: SAMZA-2158: Remove the redunant coordinator stream reads in the ApplicationMaster startup sequence. URL: https://github.com/apache/samza/pull/987 This is an automated message from the Apa

[GitHub] [samza] abhishekshivanna commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys

2019-04-08 Thread GitBox
abhishekshivanna commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273254443 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ###

[GitHub] [samza] shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys

2019-04-08 Thread GitBox
shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273251393 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ## @

[GitHub] [samza] shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys

2019-04-08 Thread GitBox
shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273251393 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ## @

[GitHub] [samza] abhishekshivanna commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys

2019-04-08 Thread GitBox
abhishekshivanna commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273279805 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ###

[GitHub] [samza] rmatharu commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys

2019-04-08 Thread GitBox
rmatharu commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273308010 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ## @@

[GitHub] [samza] prateekm commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys

2019-04-09 Thread GitBox
prateekm commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273610486 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ## @@

[GitHub] [samza] Sanil15 commented on a change in pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test

2019-04-09 Thread GitBox
Sanil15 commented on a change in pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test URL: https://github.com/apache/samza/pull/985#discussion_r273626449 ## File path: samza-test/src/main/resources/hello-stateful-world.samza ## @@ -18,7 +18,7 @@

[GitHub] [samza] asfgit closed pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test

2019-04-09 Thread GitBox
asfgit closed pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test URL: https://github.com/apache/samza/pull/985 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [samza] shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys

2019-04-09 Thread GitBox
shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273666301 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ## @

[GitHub] [samza] shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys

2019-04-09 Thread GitBox
shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273666301 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ## @

[GitHub] [samza] shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys

2019-04-09 Thread GitBox
shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to configure application type on YARN deploys URL: https://github.com/apache/samza/pull/988#discussion_r273666301 ## File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java ## @

[GitHub] [samza] prateekm opened a new pull request #989: Added an AM metric for configured container cpu and memory.

2019-04-09 Thread GitBox
prateekm opened a new pull request #989: Added an AM metric for configured container cpu and memory. URL: https://github.com/apache/samza/pull/989 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [samza] prateekm commented on issue #989: Added an AM metric for configured container cpu and memory.

2019-04-09 Thread GitBox
prateekm commented on issue #989: Added an AM metric for configured container cpu and memory. URL: https://github.com/apache/samza/pull/989#issuecomment-481422813 @rmatharu can you take a look. This is an automated message fr

[GitHub] [samza] rmatharu commented on a change in pull request #989: Added an AM metric for configured container cpu and memory.

2019-04-09 Thread GitBox
rmatharu commented on a change in pull request #989: Added an AM metric for configured container cpu and memory. URL: https://github.com/apache/samza/pull/989#discussion_r273710424 ## File path: samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala

[GitHub] [samza] asfgit closed pull request #989: Added an AM metric for configured container cpu and memory.

2019-04-09 Thread GitBox
asfgit closed pull request #989: Added an AM metric for configured container cpu and memory. URL: https://github.com/apache/samza/pull/989 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [samza] rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-09 Thread GitBox
rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273713538 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/BaseCouchbaseTableFunction.

[GitHub] [samza] rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-09 Thread GitBox
rmatharu commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273714347 ## File path: samza-kv-remote/src/test/java/org/apache/samza/table/remote/couchbase/TestCouchbaseBucketRegistry

[GitHub] [samza] shanthoosh opened a new pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-09 Thread GitBox
shanthoosh opened a new pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990 Currently the metadata of a samza job is stored into a kafka topic named coordinator stream. In sa

[GitHub] [samza] shanthoosh commented on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-09 Thread GitBox
shanthoosh commented on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#issuecomment-481475909 @prateekm Please take a look when you have a chance. --

[GitHub] [samza] shanthoosh commented on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-09 Thread GitBox
shanthoosh commented on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#issuecomment-481476576 @prateekm Apart from adding new unit-tests and fixing the existing unit-tests, I did

[GitHub] [samza] shanthoosh edited a comment on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-09 Thread GitBox
shanthoosh edited a comment on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#issuecomment-481475909 @prateekm Since you have most context about this change, please take a loo

[GitHub] [samza] shanthoosh edited a comment on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-09 Thread GitBox
shanthoosh edited a comment on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#issuecomment-481476576 @prateekm Apart from adding new unit-tests and fixing the existing unit-tests,

[GitHub] [samza] shanthoosh edited a comment on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-09 Thread GitBox
shanthoosh edited a comment on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#issuecomment-481476576 @prateekm Apart from adding new unit-tests and fixing the existing unit-tests,

[GitHub] [samza] prateekm commented on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-09 Thread GitBox
prateekm commented on issue #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#issuecomment-481479054 @dnishimura Can you take a look at this? --

[GitHub] [samza] Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-09 Thread GitBox
Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273753645 ## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/BaseCouchbaseTableFunction

[GitHub] [samza] Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-09 Thread GitBox
Zhangyx39 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r273753743 ## File path: samza-kv-remote/src/test/java/org/apache/samza/table/remote/couchbase/TestCouchbaseBucketRegistr

[GitHub] [samza] Zhangyx39 commented on issue #986: SAMZA-2156: Couchbase support for Samza Table API

2019-04-09 Thread GitBox
Zhangyx39 commented on issue #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#issuecomment-481489835 > Minor comments, feel free to fix and checkin. Thanks for the review @rmatharu But I don't have permission to checkin the cod

[GitHub] [samza] dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274033756 ## File path: samza-core/src/main/java/org/apache/samza/cluster

[GitHub] [samza] dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274039404 ## File path: samza-core/src/main/java/org/apache/samza/coordin

[GitHub] [samza] dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274045955 ## File path: samza-core/src/main/scala/org/apache/samza/checkp

[GitHub] [samza] dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274037712 ## File path: samza-core/src/main/java/org/apache/samza/cluster

[GitHub] [samza] dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274040815 ## File path: samza-core/src/main/java/org/apache/samza/storage

[GitHub] [samza] dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274027085 ## File path: samza-core/src/main/java/org/apache/samza/cluster

[GitHub] [samza] dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274029086 ## File path: samza-core/src/main/java/org/apache/samza/cluster

[GitHub] [samza] dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274037294 ## File path: samza-core/src/main/java/org/apache/samza/cluster

[GitHub] [samza] dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274028868 ## File path: samza-core/src/main/java/org/apache/samza/cluster

[GitHub] [samza] dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
dnishimura commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274029181 ## File path: samza-core/src/main/java/org/apache/samza/cluster

[GitHub] [samza] shanthoosh commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
shanthoosh commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274054251 ## File path: samza-core/src/main/java/org/apache/samza/cluster

[GitHub] [samza] shanthoosh commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
shanthoosh commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274054862 ## File path: samza-core/src/main/java/org/apache/samza/cluster

[GitHub] [samza] shanthoosh commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.

2019-04-10 Thread GitBox
shanthoosh commented on a change in pull request #990: SAMZA-2161: Move ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore. URL: https://github.com/apache/samza/pull/990#discussion_r274054453 ## File path: samza-core/src/main/java/org/apache/samza/cluster

  1   2   3   4   5   6   7   8   9   10   >