Re: RFR: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java

On Mon, 25 Apr 2022 04:35:13 GMT, Sergey Bylokhov wrote: > The new test added as part of the > [JDK-8285445](https://bugs.openjdk.java.net/browse/JDK-8285445) cannot > trigger that bug and pass w/ and w/o fix. > > An updated test validates the "default" case when the `jdk.io.File.enableADS`

Re: RFR: 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked

On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote: > I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to > the state previous to JDK-8160768, where an authentication failure stops from > trying other LDAP servers with the same credentials [1]. After JDK-8160768 we >

Re: RFR: JDK-8276572: Fake libsyslookup.so library causes tooling issues

On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes wrote: > The lack of anything to compile in `syslookup.c` is leading to a number of > issues in our tooling, on some architectures more than others (s390x seems to > be the most problematic). They expect to be able to retrieve

Integrated: JDK-8276572: Fake libsyslookup.so library causes tooling issues

On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes wrote: > The lack of anything to compile in `syslookup.c` is leading to a number of > issues in our tooling, on some architectures more than others (s390x seems to > be the most problematic). They expect to be able to retrieve

Re: RFR: JDK-8276572: Fake libsyslookup.so library causes tooling issues

On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes wrote: > The lack of anything to compile in `syslookup.c` is leading to a number of > issues in our tooling, on some architectures more than others (s390x seems to > be the most problematic). They expect to be able to retrieve

Re: RFR: JDK-8276572: Fake libsyslookup.so library causes tooling issues

On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes wrote: > The lack of anything to compile in `syslookup.c` is leading to a number of > issues in our tooling, on some architectures more than others (s390x seems to > be the most problematic). They expect to be able to retrieve

Re: RFR: JDK-8276572: Fake libsyslookup.so library causes tooling issues

On Thu, 4 Nov 2021 12:40:15 GMT, Maurizio Cimadamore wrote: > Looks ok. As long as we don't introduce more dependencies. > > One question: would introducing a static function (so, not visible in the > resulting DLL) be good enough? I did wonder about this too. I'll have to check it still

RFR: JDK-8276572: Fake libsyslookup.so library causes tooling issues

The lack of anything to compile in `syslookup.c` is leading to a number of issues in our tooling, on some architectures more than others (s390x seems to be the most problematic). They expect to be able to retrieve debuginfo and compiler flags from generated .so files and fail with

Re: RFR: 8273494: Zero: Put libjvm.so into "zero" folder, not "server"

On Thu, 9 Sep 2021 14:31:19 GMT, Magnus Ihse Bursie wrote: >> Currently, the build system defaults the libjvm.so location to "server". >> This makes looking for `libjvm.so` awkward, see JDK-8273487 for example. We >> need to see if moving the libjvm.so to a proper location breaks anything.

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v5]

On Fri, 12 Feb 2021 12:49:01 GMT, Severin Gehwolf wrote: >> This is an enhancement which solves two issues: >> >> 1. Multiple reads of relevant cgroup interface files. Now interface files >> are only read once per file (just like Hotspot). >> 2. Proxies creation of the impl specific subsystem

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v4]

On Fri, 12 Feb 2021 12:49:19 GMT, Severin Gehwolf wrote: >> Setting reviewers to 2 since I want @gnu-andrew to be OK with it too. > > Hi Harold, > >> Thanks for doing this! Sorry for taking so long to review this change. The >> change looks good. > > Thanks for the review! > >> Before

Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection

On Tue, 12 Jan 2021 14:29:28 GMT, Severin Gehwolf wrote: > Anybody willing to review this? I can have a go. I have two main concerns: 1. There seems to be little documentation on the new additions. I'm particularly concerned about things like CgroupV1Subsystem.java where a big chunk of

Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b

On Tue, 13 Oct 2020 11:32:54 GMT, Kiran Sidhartha Ravikumar wrote: >> Looks good. I think we should release-note the removal of the >> "US/Pacific-New" Link on the off chance that some >> production/testing system is looking for such a zone. > > Thanks for the review everyone, I have added a

Re: RFR [15] 8243541: (tz) Upgrade time-zone data to tzdata2020a

On 27/04/2020 19:19, Kiran Ravikumar wrote: > Hi Martin and Andrew, > > > Thanks for the review and providing a direction towards updating the > translations. > > > Here is an updated webrev with the changes: > > http://cr.openjdk.java.net/~kravikumar/8243541/webrev/ > > > All associated

Re: RFR [15] 8243541: (tz) Upgrade time-zone data to tzdata2020a

On 27/04/2020 12:13, Kiran Ravikumar wrote: > Hello All, > > > Please review the patch for tzdata2020a integration into jdk. > > Release details can be found here: > > http://mm.icann.org/pipermail/tz-announce/2020-April/58.html > > > Webrev:

Re: RFR: 8224560: (tz) Upgrade time-zone data to tzdata2019a and 8225580: tzdata2018i integration causes test failures on jdk-13

On 05/07/2019 15:16, Ramanand Patil wrote: > Hi all, > Please review the patch for tzdata2019a integration into jdk project. > Webrev: http://cr.openjdk.java.net/~rpatil/8224560/webrev.00/ > Bugs: https://bugs.openjdk.java.net/browse/JDK-8224560 >

Re: [8u] 8226392: Launcher should not enable legacy stdio streams on GNU/Linux (glibc)

On 24/06/2019 15:52, Florian Weimer wrote: > * Andrew John Hughes: > >> On 24/06/2019 14:54, Florian Weimer wrote: >>> * Severin Gehwolf: >>> >>>> Could I please get reviews for this 8u only change? The JDK 8u build >>>> logic for laun

Re: [8u] 8226392: Launcher should not enable legacy stdio streams on GNU/Linux (glibc)

On 24/06/2019 14:48, Severin Gehwolf wrote: > Hi, > > Could I please get reviews for this 8u only change? The JDK 8u build > logic for launcher files includes linker version script files (a.k.a > mapfiles). The script file for x86 (32bit) marks symbol _IO_stdin_used > as local. When the symbol

Re: [8u] 8226392: Launcher should not enable legacy stdio streams on GNU/Linux (glibc)

On 24/06/2019 14:54, Florian Weimer wrote: > * Severin Gehwolf: > >> Could I please get reviews for this 8u only change? The JDK 8u build >> logic for launcher files includes linker version script files (a.k.a >> mapfiles). The script file for x86 (32bit) marks symbol _IO_stdin_used >> as

Re: RFR: JDK-8225213: Backport jsr166 tck tests to jdk8u

On 05/06/2019 02:35, Martin Buchholz wrote: > > > On Tue, Jun 4, 2019 at 6:07 PM Andrew John Hughes <mailto:gnu.and...@redhat.com>> wrote: > > > I don't think this is the best approach. JDK-8146467 looks like a pretty > clean snapshot of the t

Re: RFR: JDK-8225213: Backport jsr166 tck tests to jdk8u

On 05/06/2019 01:15, Martin Buchholz wrote: > (Trying to correct my mistake of not having cc'ed jdk8u-dev) > > On Mon, Jun 3, 2019 at 5:15 PM Martin Buchholz > wrote: > > > > -- Forwarded message - > From: *Martin Buchholz (JBS)*

Re: [8u] 8205432: Replace the placeholder Japanese era name

On 09/04/2019 18:18, Hohensee, Paul wrote: > I meant the current webrev > > https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.02/ > > is fine. Just backport what's in tip and fix whatever's wrong later as > another backport or backports. > > Paul Thanks. I've pushed based on the

Re: RFR: [8u] 8205432: Replace the placeholder Japanese era name

On 08/04/2019 09:25, Deepak Kejriwal wrote: > Hi Andrew, > > Thanks for working on this. Please find below few minor comments:- > > 1>. For "src/share/classes/java/util/JapaneseImperialCalendar.java" and > "src/share/classes/sun/util/calendar/Era.java" please changes the date time > format to

RFR: [8u] 8205432: Replace the placeholder Japanese era name

Bug: https://bugs.openjdk.java.net/browse/JDK-8205432 Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.01/ This is a relatively clean backport, with a few exceptions, mostly due to unneeded copyright changes or moved files: * 8u has FormatData_ja.java and

Re: Swing Dev Add LookFeel support for AIX platform

On 14:45 Tue 13 Dec , Neil Richards wrote: On Tue, 2011-12-13 at 14:42 +, Neil Richards wrote: On Tue, 2011-12-13 at 10:36 +0800, Sean Chou wrote: On Mon, Dec 12, 2011 at 7:33 PM, Neil Richards neil.richa...@ngmr.net wrote: On Tue, 2011-12-06 at 11:14 +0800, Sean Chou

Re: Request for review: More cause-chaining for InternalError

On 14:16 Tue 23 Aug , Sebastian Sickelmann wrote: Am 22.08.2011 21:19, schrieb Joe Darcy: Sebastian Sickelmann wrote: Am 17.08.2011 03:11, schrieb joe.da...@oracle.com: Hello. On 8/14/2011 11:17 PM, Sebastian Sickelmann wrote: Hi, some time ago, i wrote[5] with Joe and David

Re: hg: jdk8/tl/jdk: 7082727: VirtualMachineError should declare its serialVersionUID

On 16:43 Thu 25 Aug , joe.da...@oracle.com wrote: Changeset: 624cc18a6cf9 Author:darcy Date: 2011-08-25 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/624cc18a6cf9 7082727: VirtualMachineError should declare its serialVersionUID Reviewed-by: alanb !

Re: Enhance toString() to return structured info, for certificate and probably more

On 10:41 Thu 25 Aug , Weijun Wang wrote: Hi All I was talking with Xuelei on how to better display certificate info. There are 3 cases we can currently think of: 1. debug output 2. keytool/jarsigner output 3. Java plugin display The 1st one is the most primitive one and can be a

Re: Request for Review: Chain more Exceptions (RuntimeException)

On 07:01 Thu 18 Aug , Sebastian Sickelmann wrote: Hi, i have created a fix for fixing Exception-Chains in case of an rethrown RuntimeException. I am not quite sure if this is inside the scope of what i discussed[0][1] with Joe. But it is fixed in the same manner as the patches

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

On 17:11 Tue 02 Aug , Alan Bateman wrote: Xuelei Fan wrote: : 1. I noticed the copyright date of a few files are unchanged, please update them before you push the changes. This has come up a few times but I don't think it is strictly required. Kelly or one of the release

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

On 09:24 Wed 03 Aug , Joe Darcy wrote: On 8/3/2011 12:42 AM, David Holmes wrote: Alexandre Boulgakov said the following on 08/03/11 04:44: On 8/2/2011 2:19 AM, Xuelei Fan wrote: 3017 VectorObject temp = (Vector)extractURLs(res.errorMessage); You may not need the conversion any

Re: hg: jdk8/tl/jdk: 7068616: NIO libraries do not build with javac -Xlint:all, -deprecation -Werror

On 21:44 Thu 28 Jul , jonathan.gibb...@oracle.com wrote: Changeset: 7525866a4046 Author:jjg Date: 2011-07-28 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7525866a4046 7068616: NIO libraries do not build with javac -Xlint:all,-deprecation -Werror

Re: hg: jdk8/tl/jdk: 7068616: NIO libraries do not build with javac -Xlint:all, -deprecation -Werror

On 16:47 Thu 28 Jul , Alexandre Boulgakov wrote: On 7/28/2011 4:43 PM, Dr Andrew John Hughes wrote: On 21:44 Thu 28 Jul , jonathan.gibb...@oracle.com wrote: Changeset: 7525866a4046 Author:jjg Date: 2011-07-28 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl

Re: Regression in OpenJDK8 Makefiles

On 17:12 Wed 27 Jul , Kelly O'Hair wrote: On Jul 27, 2011, at 4:28 PM, Dr Andrew John Hughes wrote: On 11:58 Wed 27 Jul , Kelly O'Hair wrote: On Jul 27, 2011, at 11:04 AM, Dr Andrew John Hughes wrote: Hi, Can someone please tell me why: http://hg.openjdk.java.net

Re: JDK 8 code review request for 7007535: (reflect) Please generalize Constructor and Method

On 12:49 Tue 19 Jul , Joe Darcy wrote: Agreed; I've posted a BlenderRev corresponding to the current patch at: http://cr.openjdk.java.net/~darcy/7007535.4/BR-7007535.html What is BlenderRev? Google finds others posted by Oracle employees but not how to generate them. Thanks,

Re: JDK 8 code review request for 7007535: (reflect) Please generalize Constructor and Method

On 19:21 Wed 13 Jul , joe.da...@oracle.com wrote: Hello. Please code review my JDK 8 changes for 7007535: (reflect) Please generalize Constructor and Method http://cr.openjdk.java.net/~darcy/7007535.3 To summarize the changes, a new superclass is defined to capture the

Re: Heads up, new jaxp source drop

On 07:26 Fri 20 May , Kelly O'Hair wrote: As soon as we figure out how to restrict changes to particular source files and protect them from intentional or accidental edits. I just have not had the time to deal with this kind of change. I thought that's what our existing review

Re: Heads up, new jaxp source drop

On 17:53 Thu 19 May , Kelly O'Hair wrote: Heads up. The jdk7/tl forest has a new jaxp source drop dependency. 7044493: Incorrectly formated GPL headers in JDK7 JAXP source drop http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/bdf77cbd9958 The new source drop bundle is called:

Re: Reviewer needed - fix for regression test LastErrorString

On 5 May 2011 20:45, Alan Bateman alan.bate...@oracle.com wrote: Pavel Tisnovsky wrote: Hi all, I'd like to push fix for regression test java/io/IOException/LastErrorString.java to OpenJDK7 and OpenJDK6. This fix ensures that no system-important files can be erased and/or rewritten by this

Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

On 07/04/2011, Dalibor Topic dalibor.to...@oracle.com wrote: On 3/3/11 3:01 AM, Dr Andrew John Hughes wrote: How do we know what the actual changes are between these tarballs? Is there some JAXP repository somewhere these are derived from, with appropriate tagging? Afaik, the JAXP API

Re: Trivial review: 7032364 Add jvm.cfg file for ARM and PPC architectures

On 30 March 2011 08:09, David Holmes david.hol...@oracle.com wrote: http://cr.openjdk.java.net/~dholmes/7032364/webrev/ More pieces to support SE Embedded. David When are these files installed? Will they interfere with Zero/Shark installs on ARM PPC? Thanks, -- Andrew :-) Free Java

Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

On 2 March 2011 19:48, Alan Bateman alan.bate...@oracle.com wrote: Kelly O'Hair wrote: Need reviewer for change in jaxp source drop bundle 7023289: jaxp 1.4.5 development jdk7 2nd integration http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxp-145dev1/webrev/ Joe or someone from the

Re: Zlib level in JDK7

On 22 February 2011 17:26, Phil Race philip.r...@oracle.com wrote: On 2/20/2011 9:39 AM, Dr Andrew John Hughes wrote: On 15 February 2011 20:23, Phil Racephilip.r...@oracle.com  wrote: On 2/15/2011 6:07 AM, Dr Andrew John Hughes wrote: Yes, IcedTea uses system libraries for everything bar

Re: sun.cpu.isalist

2011/2/14 Dmytro Sheyko dmytro_she...@hotmail.com: Hi, I can see that such system property as sun.cpu.isalist is not set on Linux, but it is set on Solaris and Windows. What is the purpose of this property and shouldn't it be set on Linux as well? Thanks, Dmytro On Solaris, it includes

Re: Fix for JDK Double.parseDouble infinite loop

On 7 February 2011 21:48, Mark Wielaard m...@klomp.org wrote: On Wed, February 2, 2011 17:16, Andrew Haley wrote: The post on http://www.exploringbinary.com/java-hangs-when-converting-2-2250738585072012e-308/ This is hitting more and more media. e.g.

Re: Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

On 16 December 2010 16:39, Neil Richards neil.richa...@ngmr.net wrote: On 13 December 2010 20:04, Neil Richards neil.richa...@ngmr.net wrote: On 13 December 2010 18:46, Alan Bateman alan.bate...@oracle.com wrote: I haven't looked at your patch in detail yet but I suspect there may be similar

Re: Improved Java Collection APIs

On 19 November 2010 15:49, John Platts john_pla...@hotmail.com wrote: Here are improvements that I really want to see to Java Collection APIs: - Addition of an equality comparator interface. - An wrapper that wraps a java.util.Comparator as a equality comparator. - Map and set classes that

Re: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

On 6 October 2010 21:56, Dr Andrew John Hughes gnu_and...@member.fsf.org wrote: On 6 October 2010 21:37, Alan Bateman alan.bate...@oracle.com wrote: This batch eliminates a bunch of compiler warnings from the native code:  http://cr.openjdk.java.net/~alanb/6989466/webrev/ It also fixes

Re: jvm load too many classes

On 31 July 2010 21:31, Rémi Forax fo...@univ-mlv.fr wrote: Le 30/07/2010 21:59, Mandy Chung a écrit : Osvaldo Doederlein wrote: I wonder if these numbers have some variation per platform? Yes, there are some platform-dependent classes and so some loaded classes are different on different

Re: PING: Re: Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

On 9 June 2010 18:22, Xueming Shen xueming.s...@oracle.com wrote: Andrew John Hughes wrote: On 9 June 2010 07:55, Florian Weimer fwei...@bfk.de wrote: * Andrew John Hughes: On 7 June 2010 23:04, Xueming Shen xueming.s...@oracle.com wrote: Hi Andrew, 6959197: When building

Re: PING: Re: Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

John Hughes wrote: On 9 June 2010 18:22, Xueming Shen xueming.s...@oracle.com wrote: Andrew John Hughes wrote: On 9 June 2010 07:55, Florian Weimer fwei...@bfk.de wrote: * Andrew John Hughes: On 7 June 2010 23:04, Xueming Shen xueming.s...@oracle.com wrote: Hi Andrew, 6959197

Re: PING: Re: Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

On 9 June 2010 07:55, Florian Weimer fwei...@bfk.de wrote: * Andrew John Hughes: On 7 June 2010 23:04, Xueming Shen xueming.s...@oracle.com wrote: Hi Andrew, 6959197: When building with JAVAC_MAX_WARNINGS=true, the build fails in sun/nio/cs due to the use of -Werror (1)sun/io

Re: PING: Re: Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

make them a little cleaner. -sherman Andrew John Hughes wrote: On 7 June 2010 19:06, Xueming Shen xueming.s...@oracle.com wrote: Andrew, I'm going through the webrev now.  Need a little more time. -sherman Andrew John Hughes wrote: On 2 June 2010 18:57, Andrew John Hughes ahug

PING: Re: Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

On 2 June 2010 18:57, Andrew John Hughes ahug...@redhat.com wrote: When building with JAVAC_MAX_WARNINGS=true, the build fails in sun/nio/cs due to the use of -Werror. The following webrev: http://cr.openjdk.java.net/~andrew/warnings/webrev.03/ fixes the remaining warnings exposed

Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

When building with JAVAC_MAX_WARNINGS=true, the build fails in sun/nio/cs due to the use of -Werror. The following webrev: http://cr.openjdk.java.net/~andrew/warnings/webrev.03/ fixes the remaining warnings exposed by JAVAC_MAX_WARNINGS by: * Removing redundant casts * Adding generic types to

Re: Math.log(17197) produces inconsistent results between javac, jit, Math and StrictMath on various architectures.

On 24 May 2010 13:55, Xerxes Rånby xer...@zafena.se wrote: Hi Im hoping to find someone who can enlighten me how to resolve a bug where some hotspot JITs fails the hotspot/test/compiler/6539464 jtreg regression test. The testcase looks like: public class Test {    static double log_value

Re: Need reviewer for forward port of 6815768 (File.getXXXSpace) and 6815768 (String.hashCode)

On 25 February 2010 18:19, Kelly O'Hair kelly.oh...@sun.com wrote: Looks fine to me. -kto On 2/25/10 9:51 AM, Alan Bateman wrote: There are two fixes in Sun's proprietary jdk6 updates that should also be fixed in OpenJDK. The first one is that the File.getXXXSpace methods use statvfs

Re: Please review changes in regression test test/java/security/Provider/Turkish.java

2010/1/18 Alan Bateman alan.bate...@sun.com: Pavel Tisnovsky wrote: Hi, please review changes in regression test jtest/java/security/Provider/Turkish.java. Webrev is available at http://cr.openjdk.java.net/~ptisnovs/Turkish/ We already discussed similar issue on jdk6-dev mailing list,

Re: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files

2010/1/8 Kelly O'Hair kelly.oh...@sun.com: Andrew Haley wrote: On 12/09/2009 03:36 PM, Andrew Haley wrote: This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 The symptom is that jmap doesn't work because target libraries are stripped. The fix is to allow the symtab reader to use

Re: Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files

2010/1/8 Kelly O'Hair kelly.oh...@sun.com: Andrew John Hughes wrote: 2010/1/8 Kelly O'Hair kelly.oh...@sun.com: Andrew Haley wrote: On 12/09/2009 03:36 PM, Andrew Haley wrote: This is https://bugzilla.redhat.com/show_bug.cgi?id=541548 The symptom is that jmap doesn't work because

Re: Code review request for 4891262 API spec, javax/accessibility: few invalid javadoc tags

2009/12/10 Joseph D. Darcy joe.da...@sun.com: Andrew John Hughes wrote: 2009/12/10 Joe Darcy joe.da...@sun.com: Hello. While doing a coredocs build, I noticed once again some javadoc warnings coming out of the javax.accessibility package and I decided to fix them; the patch is below

Re: hg: jdk7/tl/jdk: 6907177: Update jdk tests to remove unncessary -source and -target options

2009/12/4 joe.da...@sun.com: Changeset: 1755493c5774 Author:    darcy Date:      2009-12-03 18:19 -0800 URL:       http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1755493c5774 6907177: Update jdk tests to remove unncessary -source and -target options Reviewed-by: ohair !

Re: Gap Buffer based AbstractStringBuilder implementation

2009/11/20 Osvaldo Doederlein opin...@gmail.com: Hi Goktug, Looks like good stuff. And it remembers me from another old issue: patterns of code that demand data copying that could often be avoided. Every StringBuffer/StringBuilder is ultimately consumed by a toString() invocation to produce

Re: Code review request for 6897550 BigInteger constructor should use local cached String length

2009/11/3 Joseph D. Darcy joe.da...@sun.com: Hello. Please review this simple change to replace several calls to val.length() with an already cached copy of val.length(); patch below. 6897550 BigInteger constructor should use local cached String length

Re: Are the faster versions of HashMap and BigInteger going into jdk7?

2009/10/27 Alan Eliasen elia...@mindspring.com: On 10/23/2009 11:01 AM, Andrew John Hughes wrote: 6622432 is the one of the ones I just pointed to i.e. it's in JDK7. If Alan has a further patch and hasn't even submitted it for inclusion, it's obviously not in.   I had just queried Joe Darcy

Re: Are the faster versions of HashMap and BigInteger going into jdk7?

2009/10/23 Paulo Levi i30...@gmail.com: Just a question. The only relevant changes I see are: changeset: 1246:8d2efec31d78 user:xlu date:Sun May 24 16:29:57 2009 -0700 summary: 6622432: RFE: Performance improvements to java.math.BigDecimal

Re: Are the faster versions of HashMap and BigInteger going into jdk7?

2009/10/23 Paulo Levi i30...@gmail.com: Yes. Different implementations with better performance. http://gcc.gnu.org/ml/java/2009-06/msg00019.html 6622432 is the one of the ones I just pointed to i.e. it's in JDK7. If Alan has a further patch and hasn't even submitted it for inclusion, it's

Re: Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

2009/10/15 Michael McMahon michael.mcma...@sun.com: It doesn't seem right to filter out arbitrary environment variables like that (inside ProcessEnvironment). Sorry, I haven't been following this issue closely, but is it not possible to unset this variable somewhere else? I concur. That's a

Re: Fix for 5015163, and my first webrev

2009/10/14 Ulf Zibis ulf.zi...@gmx.de: Am 14.10.2009 17:01, Rémi Forax schrieb: Le 14/10/2009 16:47, Ulf Zibis a écrit : Rémi, can you tell me how you got the cr.openjdk.java.net account ? Is there any registration link? Thanks, Ulf I've got it because I've the right to push codes on

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009/9/23 Andrew Haley a...@redhat.com: Andrew John Hughes wrote: 2009/9/23 Andrew Haley a...@redhat.com: Christopher Hegarty -Sun Microsystems Ireland wrote: [cc'ing net-dev] I see you have push access, so if you make the appropriate changes (mentioned above) I can review the webrev

Re: PATCH: Tired of waiting for rt.jar to build?

2009/4/29 Martin Buchholz marti...@google.com: Since writing this, I have learned, to my horror, that the behavior of the -C flag differs from the behavior in tar in that - -C is not sticky - it applies only to the one following argument - the path is relative to the JDK's current directory,

Re: What methods should go into a java.util.Objects class in JDK 7?

2009/9/10 Ulf Zibis ulf.zi...@gmx.de: Am 10.09.2009 02:04, Rémi Forax schrieb: Le 10/09/2009 01:43, Andrew John Hughes a écrit :  I agree about the debugging purpose, that why I don't agree with Kevin when he said that java.util.Objects should not use reflection. Perhaps the method can

Re: What methods should go into a java.util.Objects class in JDK 7?

2009/9/10 Ulf Zibis ulf.zi...@gmx.de: Am 10.09.2009 01:54, Stephen Colebourne schrieb: There is also a case for methods to convert arrays of wrappers to arrays of primitives. +1 - I guess, you mean also vice versa - Maybe would become superfluous, if HotSpot internally would compile to

Re: What methods should go into a java.util.Objects class in JDK 7?

2009/9/9 Joe Darcy joe.da...@sun.com: Hello. For JDK 7, I think it is high-time the platform included a class like java.util.Objects to hold commonly-written utility methods.  For example, a two-argument static equals method that returned true if both arguments are null, returns false is one

Re: What methods should go into a java.util.Objects class in JDK 7?

2009/9/10 Rémi Forax fo...@univ-mlv.fr: Le 09/09/2009 23:22, Andrew John Hughes a écrit : Given you've listed utility methods for two Object methods, equals and hashCode, toString seems an obvious one to handle as well: public static String toString(Object o)   throws IllegalAccessException

Re: Review Request for 6878481: Add performance counters in the JDK

2009/9/3 Rémi Forax fo...@univ-mlv.fr: Le 03/09/2009 10:54, Alan Bateman a écrit : Mandy Chung wrote: This is related to 6857194: Add hotspot new perf counters to aid class loading performance measurement. It's useful to add performance counters in the library code so that perf data from

Re: Review Request for 6878481: Add performance counters in the JDK

2009/9/3 Mandy Chung mandy.ch...@sun.com: Alan Bateman wrote: Andrew John Hughes wrote: : The use of synchronized at present seems flawed as only the set methods are protected and not the get.  So lb.get could be called while in an lb.put call.  I don't see the reason for using

Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.

2009/8/22 Mark Wielaard m...@klomp.org: Hi Andrew, On Fri, 2009-08-21 at 20:35 +0100, Andrew John Hughes wrote: 2009/8/21 Mark Wielaard m...@klomp.org: On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote: This change was integrated prematurely.  I've rolled it back in the jdk7/tl/jdk

Re: Core review request for 6378701 (enum) Unclear purpose of EnumConstantNotPresentException

2009/8/21 Lance J. Andersen lance.ander...@sun.com: Hi Joe, The changes are fine and make things clearer. Regards Lance Joseph D. Darcy wrote: Hello. Please review the patch below is clarify the use of certain exception types to address bug 6378701 (enum) Unclear purpose of

Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.

2009/8/21 Mark Wielaard m...@klomp.org: Hi Mark, On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote: This change was integrated prematurely.  I've rolled it back in the jdk7/tl/jdk repository. If at all possible, please don't do this. It plays havoc with already checked out repos

Re: [PATCH FOR APPROVAL]: ReflectiveOperationException missing from FILES_java.gmk

2009/8/7 Kelly O'Hair kelly.oh...@sun.com: Joseph D. Darcy wrote: Andrew John Hughes wrote: When java.lang.ReflectiveOperationException was added in: http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/aaf0cb20646e it wasn't added to make/java/java/FILES_java.gmk.  Although it still seems

Re: execvpe and glibc 2.10

2009/7/28 Martin Buchholz marti...@google.com: On Tue, Jul 28, 2009 at 06:08, Michael McMahonmichael.mcma...@sun.com wrote: Andrew John Hughes wrote: 2009/7/28 Michael McMahon michael.mcma...@sun.com: Andrew John Hughes wrote: 2009/7/9 Martin Buchholz marti...@google.com: rename

Re: execvpe and glibc 2.10

2009/7/9 Martin Buchholz marti...@google.com: Sorry, I should never have named a function (not even a static one) 'execvpe'.  It's amusing that I broke myself by requesting that glibc implement 'execvpe'. Here's the webrev: http://cr.openjdk.java.net/~martin/webrevs/openjdk7/rename-execvpe/

Re: My first webrev review request: 6850337 Hasher.java interprets given option value badly

2009/7/19 Ulf Zibis ulf.zi...@gmx.de: Martin, Sherman, Neal, do you like to sponsor and review my CR ? Don't worry, it's very simple and small, best for getting familiar with the workflow. See: https://bugs.openjdk.java.net/show_bug.cgi?id=100090 Thanks, Ulf As this bug is about

Re: How to contribute - webrev question

2009/7/16 Ulf Zibis ulf.zi...@gmx.de: Now I have installed the Microsoft Windows Services for UNIX and can run a Korn Shell: Running the script, I get following output: == $ dir Datenträger in Laufwerk C: ist STANDARD Volumeseriennummer:

Fwd: Reg : How to contribute

2009/7/15 Ulf Zibis ulf.zi...@gmx.de: Am 15.07.2009 16:26, Neal Gafter schrieb: On Wed, Jul 15, 2009 at 4:01 AM, Dalibor Topic dalibor.to...@sun.com mailto:dalibor.to...@sun.com wrote:    A good start is the OpenJDK developer guide - see    http://openjdk.java.net/guide/ to learn how the

Re: Reg : How to contribute

2009/7/15 Neal Gafter n...@gafter.com: 2009/7/15 Dalibor Topic dalibor.to...@sun.com Neal, Are you interested in improving the developer guide? Unfortunately, I have no special access to what Sun is putting in place, so I'm not the right person to be documenting things.  I still haven't

Re: Reg : How to contribute

2009/7/15 Ulf Zibis ulf.zi...@gmx.de: Am 15.07.2009 16:55, Dalibor Topic schrieb: Ulf Zibis wrote: but what to do with this script to make it work for me? I'm not sure I understand the question correctly - webrev is a shell script that uses ksh, so you could mark it as executable and

Re: patch to address sun bug 6562614

2009/7/9 Andrew John Hughes gnu_and...@member.fsf.org: 2009/7/9 Jon VanAlten jon.vanal...@redhat.com: Hi, I've put up a webrev at http://icedtea.classpath.org/~vanaltj/webrevs/tl/patch1/index.html to address http://bugs.sun.com/view_bug.do?bug_id=6562614, also referenced on Icedtea

Re: patch to address sun bug 6562614

2009/7/9 Jon VanAlten jon.vanal...@redhat.com: Hi, I've put up a webrev at http://icedtea.classpath.org/~vanaltj/webrevs/tl/patch1/index.html to address http://bugs.sun.com/view_bug.do?bug_id=6562614, also referenced on Icedtea bugzilla as

Re: timsort

2009/7/7 Christopher Hegarty -Sun Microsystems Ireland christopher.hega...@sun.com: Hi Martin, Sorry for joining the party late... I think adding the system property should take care of the compatibility issues, at least giving the user the ability to revert to the old behavior if they so

Re: timsort

2009/7/7 Christopher Hegarty -Sun Microsystems Ireland christopher.hega...@sun.com: Andrew John Hughes wrote: [snip] Forgive the naivety, but what is a 'CCC request'?  Is this process of requesting and approving specification changes public?  I'm sure I'm not alone among those

Re: timsort

2009/6/30 Martin Buchholz marti...@google.com: Thanks, Alan.  You're a good reviewer. As you suggested, I added the Classpath exception wording to TimSort.java and ComparableTimSort.java. I excised the old mergesort code from Arrays.java. webrev regenerated. Adding all-or-nothing wording

Re: timsort

2009/6/30 Andrew Haley a...@redhat.com: Martin Buchholz wrote: Thanks, Alan.  You're a good reviewer. As you suggested, I added the Classpath exception wording to TimSort.java and ComparableTimSort.java. I excised the old mergesort code from Arrays.java. webrev regenerated. Adding

Re: timsort

2009/6/30 Martin Buchholz marti...@google.com: On Tue, Jun 30, 2009 at 09:24, Andrew John Hughes gnu_and...@member.fsf.org wrote: 2009/6/30 Martin Buchholz marti...@google.com: (There is the deeper governance issue of who gets to make such decisions.  I would like most of such decisions

Re: Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

2009/5/28 Andrew Haley a...@redhat.com: Joseph D. Darcy wrote: Andrew Haley wrote: Joseph D. Darcy wrote: Alan Bateman wrote: Andrew Haley wrote: : OK, here it is.  I put the test in java/lang/Double/ToString.java rather than sun/misc/FloatingDecimal because the bug manifested itself

Re: OpenJDK Forum: Core Libraries Round Table

2009/4/14 Max (Weijun) Wang weijun.w...@sun.com: On Apr 14, 2009, at 7:44 PM, Dalibor Topic wrote: Kevin Bourrillion wrote: Curious if anyone is transcribing the call into text yet?  Word-for-word not necessary, but understandable?  If no one says they've already done that or at least

Re: OpenJDK Forum: Core Libraries Round Table

2009/4/9 Dalibor Topic dalibor.to...@sun.com: Dalibor Topic wrote: Hi core libraries developers, I'd like to carry on doing these, as the last one we did for contributing into OpenJDK 6 was fun and productive, so per Alan Bateman's suggestion, it's time again tomorrow, on Thursday, for the

Re: OpenJDK Forum: Core Libraries Round Table

2009/4/9 Tom Hawtin thomas.haw...@sun.com: Dalibor Topic wrote: A recording of the call is available on http://mediacast.sun.com/users/robilad/media/openjdk6-core-libs.ogg Any chance of getting that in a mainstream format? Windows doesn't understand it. Rhythmbox under VirtualBox freezes.

Re: OpenJDK Forum: Core Libraries Round Table

2009/4/9 Jeff Dinkins jeff.dink...@sun.com: VLC plays ogg. What? You don't have VLC? Well time to grab a copy!  http://www.videolan.org/vlc jeff p.s. I vote to keep it ogg only to promote more people to use it :-) +1 :) Personally, I think there was already a compromise by going with

  1   2   >