with atlas deployment
Thanks,
Shwetha GS
4/#review156163
---
On Nov. 16, 2016, 9:33 a.m., Shwetha GS wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
/GraphHelper.java
(line 529)
<https://reviews.apache.org/r/52257/#comment226310>
why can't the default be null, if not set? Same for other properties
- Shwetha GS
On Nov. 16, 2016, 1:33 p.m., Vimal Sharma
added and tested with atlas deployment
Thanks,
Shwetha GS
che.org/r/52257/#comment226125>
Should return Date object to avoid the confusion of the date format used in
string
- Shwetha GS
On Nov. 15, 2016, 4:33 p.m., Vimal Sharma wrote:
>
> ---
> This is an automatically gener
done at runtime vs aspectj compile time
injection
- Shwetha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53724/#review155932
---------
b9e
Diff: https://reviews.apache.org/r/53525/diff/
Testing
---
UTs and end to end test external hbase and solr
Thanks,
Shwetha GS
?
- Shwetha GS
On Nov. 11, 2016, 2:34 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
which is not a good
user experience).
Instead of hardcoding these attributes on server side, we should make this
part of model(type definition), just like attributes marked for search results
display
- Shwetha GS
On Nov. 15, 2016, 1:44 a.m., Sarath Subramanian
/atlas/web/resources/MetadataDiscoveryResource.java
64344da
webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java
ace0d14
Diff: https://reviews.apache.org/r/53724/diff/
Testing
---
UT added and tested with atlas deployment
Thanks,
Shwetha GS
shaded/hbase-client-shaded/pom.xml PRE-CREATION
shaded/hbase-server-shaded/pom.xml PRE-CREATION
typesystem/pom.xml 28c077d
webapp/pom.xml b9e
Diff: https://reviews.apache.org/r/53525/diff/
Testing
---
UTs and end to end test external hbase and solr
Thanks,
Shwetha GS
test external hbase and solr
Thanks,
Shwetha GS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52914/#review152824
---
Ship it!
Ship It!
- Shwetha GS
On Oct. 15, 2016, 9:11 p.m
a/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java
(line 33)
<https://reviews.apache.org/r/52585/#comment220269>
These are defined in Constants as well
- Shwetha GS
On Oct. 7, 2016, 7:01 a.m.,
resolved bug. Can
you create a new jira and link this request there?
- Shwetha GS
On Oct. 6, 2016, 12:45 a.m., Apoorv Naik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/HiveDataModelGenerator.java
(line 232)
<https://reviews.apache.org/r/52533/#comment220072>
This is a minor backward compatible change. We should set it to 1.1
- Shwetha GS
On Oct. 4, 2016, 11:17 p.m., Sarath Kumar Subramanian
/titan0/Titan0Graph.java
(line 65)
<https://reviews.apache.org/r/47810/#comment219901>
This has to be synchronized
- Shwetha GS
On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review151128
---
Ship it!
Ship It!
- Shwetha GS
On Oct. 2, 2016, 5:55 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52077/#review150990
---
Ship it!
Ship It!
- Shwetha GS
On Sept. 29, 2016, 8:15 a.m
> On Sept. 30, 2016, 5:21 a.m., Shwetha GS wrote:
> > Previously, the common module contained some common code required for atlas
> > server. Since the new classes that are added are client side classes, can
> > you move them to new module clientv2 so that we ha
for atlas
server. Since the new classes that are added are client side classes, can you
move them to new module clientv2 so that we have clear dependencies for atlas
clients.
Also, move the server side rest API to webappv2 and webapp can depend on
webappv2
- Shwetha GS
On Sept. 30, 2016, 12
ces contains a_guid and b_guid
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java
(line 1169)
<https://reviews.apache.org/r/52077/#comment218893>
Add assert that vertices contains sourceTableGUID
- Shwetha GS
On Sept. 26,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52336/#review150818
---
Ship it!
Ship It!
- Shwetha GS
On Sept. 28, 2016, 9:10 a.m
)
<https://reviews.apache.org/r/47810/#comment218730>
Modifying this json because of changes in model,
serialisation/deserialisation is tough. Can we just generate the entities from
test code?
- Shwetha GS
On Sept. 23, 2016, 3:29 a.m., Jeff Hagelberg
/ReservedTypesRegistrar.java
(line 150)
<https://reviews.apache.org/r/52336/#comment218729>
We shouldn't do any updates as part of this, as it might override any type
updates from user. Let the patch framework take care of updates. Lets just
create new types as part of this
- Shwetha GS
On Se
> On Sept. 23, 2016, 6:19 a.m., Shwetha GS wrote:
> > In case the attribute is added again, the data will be wrong. We can't
> > discount that as an edge case, as it causes data inconsistency. Follow up
> > jiras will hardly be taken up. Its fine even if we decide tha
org/r/52077/#comment218361>
rename to query/command as this class type is also process
- Shwetha GS
On Sept. 22, 2016, 11:53 a.m., Vimal Sharma wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
ira
> 2. this is only for upgrade scenarios
> 3. lets address this in a separate jiira.
> 4. we dont want to maintain multiple versions of the same type in the
> typesystem, will confuse users on which version to use to create entities.
>
> Shwetha GS wrote:
> What b
to end test for this patch now will
not ensure that this functionality won't be broken in further commits
- Shwetha GS
On Sept. 22, 2016, 6:22 p.m., Sarath Kumar Subramanian wrote:
>
> ---
> This is an automatically generat
ng, then we shouldn't expose the conf
atlas.graphdb.backend?
- Shwetha GS
On Sept. 21, 2016, 1:49 p.m., Jeff Hagelberg wrote:
>
> ---
> This is an automatically ge
ntains the version of the
latest type definition which I think is useful for debugging, to know the
version of type that the server knows. Can we maintain this info in
HiveDataModelGenerator itself, and hence will be part of hive_model.json
- Shwetha GS
On Sept. 21, 2016, 7:51 a.m., Sarath Kumar
---------
>
> (Updated Sept. 21, 2016, 7:51 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1174
> https://issues.apache.org/jira/browse/ATLAS-1174
>
>
> Repository: atlas
>
>
g/r/52077/#comment217523>
rename to testColumnLevelLineage
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java
(line 1143)
<https://reviews.apache.org/r/52077/#comment217524>
Also assert on lineage API response on columns
- Shwetha GS
On
NArray();
for (String traitName : entity.getTraits()) {
IStruct trait = entity.getTrait(traitName);
traits.put(new
JSONObject(InstanceSerialization.toJson(trait, true)));
}
- Shwetha GS
On Sept. 16, 2016, 8:49 a.m., Vimal Sharma
ition
You can also change metadataService.getTraitDefinition() to return
org.apache.atlas.typesystem.Struct
- Shwetha GS
On Sept. 15, 2016, 6:53 a.m., Vimal Sharma wrote:
>
> ---
> This is an automatically genera
> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> > line 309
> > <https://reviews.apache.org/r/51660/diff/3/?file=1492519#file1492519line309>
> >
> > This is equal
> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
> > line 309
> > <https://reviews.apache.org/r/51660/diff/3/?file=1492519#file1492519line309>
> >
> > This is equal
/HiveMetaStoreBridge.java
(line 588)
<https://reviews.apache.org/r/51515/#comment216225>
Can you add tests that column position is set correctly in create table and
alter table column reorder? You can add extra validations in existing tests as
well
- Shwetha GS
On Aug. 30, 2016, 6:
/DefaultMetadataService.java
(line 309)
<https://reviews.apache.org/r/51660/#comment216152>
This is equals check - typename equals keyword. Does it work if typename
contains keyword e.g., if typename is 'isa PII'?
Not sure if keywords in DSL is case sensitive. You may want to verify
- Shwe
.verifyTypes() has all the validations. Please move this logic
there.
- Shwetha GS
On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/NotificationHookConsumerTest.java
d22c5f1
Diff: https://reviews.apache.org/r/51035/diff/
Testing
---
UTs and end to end test
Thanks,
Shwetha GS
6fd1939
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
d22c5f1
Diff: https://reviews.apache.org/r/51035/diff/
Testing
---
UTs and end to end test
Thanks,
Shwetha GS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50824/#review144880
---
Ship it!
Ship It!
- Shwetha GS
On Aug. 4, 2016, 11:13 p.m
bridge/HiveMetaStoreBridgeTest.java
(line 100)
<https://reviews.apache.org/r/50823/#comment211008>
Add an IT in HiveMetastoreBridgeIT which tests de-duping
- Shwetha GS
On Aug. 5, 2016, 4:29 a.m., Suma Shiva
che.org/r/49869/#comment210787>
should be mapEdgeLabel
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
(line 886)
<https://reviews.apache.org/r/49869/#comment210794>
Add tests with lower bounds on map as well
- Shwetha G
/HiveHookIT.java
573f7f5
docs/pom.xml 9b8440d
pom.xml 4855d3d
webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java
1aee467
Diff: https://reviews.apache.org/r/50712/diff/
Testing
---
ITs and end to end testing
Thanks,
Shwetha GS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50559/#review143916
---
Ship it!
Ship It!
- Shwetha GS
On July 28, 2016, 10:27 a.m
e fixed the query
parser as well
- Shwetha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49625/#review142827
-----------
On July 19, 2016, 4:45 p.m., Shwetha GS wrote:
>
> -
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49625/#review142775
-------
On July 19, 2016, 4:45 p.m., Shwetha GS wrote:
>
> ---
Diff: https://reviews.apache.org/r/49625/diff/
Testing
---
Thanks,
Shwetha GS
.java
443dd4a
Diff: https://reviews.apache.org/r/50146/diff/
Testing
---
Verified create type, create entity and search using DSL
Thanks,
Shwetha GS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50111/#review142582
---
Ship it!
Ship It!
- Shwetha GS
On July 17, 2016, 11:03 p.m
> On July 12, 2016, 5:52 a.m., Shwetha GS wrote:
> > common/src/main/java/org/apache/atlas/ha/HAConfiguration.java, line 65
> > <https://reviews.apache.org/r/49941/diff/1/?file=1441953#file1441953line65>
> >
> > To make it backward compatible, as
ain/java/org/apache/atlas/typesystem/types/TypeSystem.java
(line 19)
<https://reviews.apache.org/r/49570/#comment207461>
revert, no changes?
- Shwetha GS
On July 3, 2016, 7:21 a.m., Madhan Neethiraj wrote:
>
> ---
&g
ha.enabled or ids > 1?
- Shwetha GS
On July 12, 2016, 1:29 a.m., Madhan Neethiraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49585/#review141243
---
Ship it!
Ship It!
- Shwetha GS
On July 7, 2016, 9:32 p.m
sLoader.java
(line 97)
<https://reviews.apache.org/r/49585/#comment206592>
is synchronised required here?
plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java
(line 44)
<https://reviews.apache.org/r/49585/#comment206594>
getInst
> On July 4, 2016, 10:13 a.m., Shwetha GS wrote:
> > addons/falcon-bridge-shim/src/main/java/org/apache/atlas/falcon/hook/AtlasService.java,
> > line 31
> > <https://reviews.apache.org/r/49585/diff/2/?file=1436099#file1436099line31>
> >
> > D
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49717/#review141129
---
Ship it!
Ship It!
- Shwetha GS
On July 6, 2016, 7:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49350/#review140119
---
Ship it!
Ship It!
- Shwetha GS
On June 29, 2016, 10:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49357/#review140004
---
Ship it!
Ship It!
- Shwetha GS
On June 29, 2016, 2:58 p.m
adding hdfs paths in qualified name for partitioned tables, but
we add it to inputs for lineage. With process update, lineage will get updated,
right?
- Shwetha GS
On June 29, 2016, 4:41 a.m., Suma Shivaprasad wrote:
>
> ---
&g
in this format:
This product bundles Font Awesome which is available under a
SIL Open Font License (OFL). For details, see 3party-licenses/SILOFL-LICENSE
(replace version)
3. Add apache headers in all .scss files in dashboardv2/public/css/scss. Its in
style.scss, but not others
- Shwetha GS
On June 29
://reviews.apache.org/r/49191/diff/
Testing
---
UTs
Thanks,
Shwetha GS
Thanks,
Shwetha GS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48565/#review139016
---
Ship it!
Ship It!
- Shwetha GS
On June 22, 2016, 2:28 a.m
/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java
477e4bf
Diff: https://reviews.apache.org/r/49022/diff/
Testing
---
UTs
Thanks,
Shwetha GS
/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java
859ec72
typesystem/src/test/java/org/apache/atlas/typesystem/types/HierarchicalTypeTest.java
81da0be
webapp/pom.xml ce812c6
Diff: https://reviews.apache.org/r/49022/diff/
Testing
---
UTs
Thanks,
Shwetha GS
t we can enable
debug logs whenever required
- Shwetha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48945/#review138663
-----------
generated e-mail. To reply, visit:
https://reviews.apache.org/r/48945/#review138569
-----------
On June 20, 2016, 9:01 a.m., Shwetha GS wrote:
>
> ---
> Thi
/EntityResource.java
0713d30
webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java
74d89ce
Diff: https://reviews.apache.org/r/48945/diff/
Testing
---
UTs
Thanks,
Shwetha GS
/
Testing
---
UTs
Thanks,
Shwetha GS
/StoreBackedTypeCacheProvider.java
(line 205)
<https://reviews.apache.org/r/48565/#comment203457>
this should have handled NOT_FOUND. So, throwing exception from
getTypeFromCacheOrStore() will work in all cases
- Shwetha GS
On June 15, 2016, 3:05 p.m., David Kantor
/apache/atlas/repository/typestore/StoreBackedTypeCacheProvider.java
(line 166)
<https://reviews.apache.org/r/48565/#comment203456>
The only return type valid here is NOT_FOUND. Lets throw exception in this
case and make the function return void instead
- Shwetha GS
On June 15, 2016
-log4j.xml 2bb49d3
webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java eeaddd6
Diff: https://reviews.apache.org/r/48845/diff/
Testing
---
UTs and end to end test
Thanks,
Shwetha GS
/src/main/resources/atlas-log4j.xml 2bb49d3
webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java eeaddd6
Diff: https://reviews.apache.org/r/48845/diff/
Testing
---
UTs and end to end test
Thanks,
Shwetha GS
t:
https://reviews.apache.org/r/48845/#review138203
-------
On June 17, 2016, 10:47 a.m., Shwetha GS wrote:
>
> ---
> This is an automatically generated e
webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java eeaddd6
Diff: https://reviews.apache.org/r/48845/diff/
Testing
---
UTs and end to end test
Thanks,
Shwetha GS
: https://reviews.apache.org/r/48845/diff/
Testing
---
UTs and end to end test
Thanks,
Shwetha GS
/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
449e066
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
2d1c33a
Diff: https://reviews.apache.org/r/48837/diff/
Testing
---
UTs
Thanks,
Shwetha GS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48349/#review136971
---
Ship it!
Ship It!
- Shwetha GS
On June 9, 2016, 3:45 p.m
gistered:271->assertColumnIsRegistered:276->assertEntityIsRegistered:1498->waitFor:1591
Assertions failed. Failing after waiting for timeout 8 msecs
Tests run: 43, Failures: 2, Errors: 0, Skipped: 0
- Shwetha GS
On June 6, 2016, 10:53 p.m
;
> (Updated June 6, 2016, 10:53 p.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-499
> https://issues.apache.org/jira/browse/ATLAS-499
>
>
> Repository: atlas
>
>
> Description
> ---
>
> ATLAS-499: Automa
atch in. Can you re-open your review and add
atlas group in the review request
- Shwetha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48408/#review136641
--------
/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java
08bb125
webapp/src/test/java/org/apache/atlas/web/listeners/TestModule.java 9cb76d3
Diff: https://reviews.apache.org/r/48408/diff/
Testing
---
Existing tests passed, tested end to end
Thanks,
Shwetha GS
https://issues.apache.org/jira/browse/ATLAS-832 to track starting hbase and
solr with atlas_start with 'embedded-services' profile
- Shwetha GS
On May 26, 2016, 7:14 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically
On May 26, 2016, 6:04 p.m., Tom Beerbower wrote:
> > In the package built using '-Pdist,embedded_services', atlas_start doesn't
> > start embedded hbase and solr. is that expected?
>
> Tom Beerbower wrote:
> You have to run atlas-env.sh first.
>
> Sh
On May 26, 2016, 6:04 p.m., Tom Beerbower wrote:
> > In the package built using '-Pdist,embedded_services', atlas_start doesn't
> > start embedded hbase and solr. is that expected?
>
> Tom Beerbower wrote:
> You have to run atlas-env.sh first.
>
> Sh
On May 26, 2016, 6:04 p.m., Tom Beerbower wrote:
> > In the package built using '-Pdist,embedded_services', atlas_start doesn't
> > start embedded hbase and solr. is that expected?
>
> Tom Beerbower wrote:
> You have to run atlas-env.sh first.
Can't atlas_start.py and atlas_stop.py in
ackage built using '-Pdist,embedded_services', atlas_start doesn't
start embedded hbase and solr. is that expected?
- Shwetha GS
On May 26, 2016, 2:17 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail.
> On May 25, 2016, 10:28 a.m., Shwetha GS wrote:
> > 1. Change distro/atlas-application.properties to use berkleydb and
> > elasticsearch
> > 2. Remove packaging of hbase and solr
>
> Tom Beerbower wrote:
> So we want to completely revert the embedded HBase
and elasticsearch
2. Remove packaging of hbase and solr
- Shwetha GS
On May 24, 2016, 5:42 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
check for isComposite removed? Can you pls explain?
>
> Shwetha GS wrote:
> For example, in case of soft delete, if the column is deleted, we don't
> update the table's columns attribute. So, table definition returns the list
> of columns that includes deleted columns as well.
/resources/EntityJerseyResourceIT.java
aa92bc0
webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java
2d510a0
Diff: https://reviews.apache.org/r/46731/diff/
Testing
---
UTs
Thanks,
Shwetha GS
eviews.apache.org/r/46731/#review134304
-------
On May 19, 2016, 5:41 a.m., Shwetha GS wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47571/#review134312
---
Ship it!
Ship It!
- Shwetha GS
On May 21, 2016, 12:18 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47591/#review134150
---
Ship it!
Ship It!
- Shwetha GS
On May 19, 2016, 2:05 p.m
/HiveHook.java (line
326)
<https://reviews.apache.org/r/47638/#comment198811>
Instead of double loop twice, create maps for each and use maps
- Shwetha GS
On May 20, 2016, 6:42 a.m., Vimal Sharma wrote:
>
> ---
> This is a
user? This conf is the default conf used in package
and shouldn't have random users
- Shwetha GS
On May 20, 2016, 2:02 p.m., Nixon Rodrigues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
rizationFilter getAtlasAction HTTP Method {}
mapped to AtlasAction : {}", method, action);
pom.xml (line 466)
<https://reviews.apache.org/r/47612/#comment198783>
rename module to authorization
Please avoid un-ncessary log statements. Log only when needed
- Shwetha GS
On May 1
1 - 100 of 207 matches
Mail list logo
