On March 26, 2015, 4:32 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/src/process.cpp, line 6
https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line6
One thing captures my attention is how we include C headers. AFAIK, the
standard requires to include them
On Feb. 18, 2015, 11:38 a.m., Niklas Nielsen wrote:
Let's get tests wired up before committing this :)
Adam B wrote:
Sure thing. Adding tests in my subsequent patch where we will pass the
master's timeout values on to the slave. Will post that very soon.
Ben Mahler wrote:
We do accept Pull-Requests https://github.com/apache/mesos/pulls for
small patches, especially (markdown) documentation patches; but for larger
code changes we prefer the issue tracking, multi-line comments, and
incremental diffs provided by ReviewBoard.
On Tue, Mar 31, 2015 at 10:55 AM, haosdent
On March 26, 2015, 4:32 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/src/process.cpp, line 6
https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line6
One thing captures my attention is how we include C headers. AFAIK, the
standard requires to include them
On March 26, 2015, 5:32 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/src/process.cpp, line 6
https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line6
One thing captures my attention is how we include C headers. AFAIK, the
standard requires to include them
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/
---
(Updated April 1, 2015, 11:47 a.m.)
Review request for mesos, Joerg Schad,
On March 26, 2015, 5:32 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/src/process.cpp, line 6
https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line6
One thing captures my attention is how we include C headers. AFAIK, the
standard requires to include them
In Mesos sources we use c-style C headers (stdlib.h), as opposed to
c++-style (cstdlib). C++11 Standard 17.6.1.2 p4, p8, and reference 177
hint that cname is a preferred form for C++ programs. However this may
require adding std prefix everywhere, since according to the Standard cname
headers may
Reminder: We're having another Mesos Developer Community Sync this
Thursday, April 2nd from 3-5pm Pacific.
Agenda:
https://docs.google.com/document/d/153CUCj5LOJCFAVpdDZC7COJDwKh9RDjxaTA0S7lzwDA/edit?usp=sharing
To Join: follow the BlueJeans instructions from the recurring meeting
invite at the
On March 27, 2015, 9:17 a.m., Adam B wrote:
docs/slave-recovery.md, line 71
https://reviews.apache.org/r/32543/diff/2/?file=907123#file907123line71
(If the slave does not come back, each executorDriver shuts itself down
after $MESOS_RECOVERY_TIMEOUT.)
Important
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32583/#review78494
---
Should mention in the Description (commit message) that the new
On March 27, 2015, 9:17 a.m., Adam B wrote:
docs/slave-recovery.md, line 71
https://reviews.apache.org/r/32543/diff/2/?file=907123#file907123line71
(If the slave does not come back, each executorDriver shuts itself down
after $MESOS_RECOVERY_TIMEOUT.)
Important
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/#review78502
---
Patch looks great!
Reviews applied: [31228, 31676]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32585/#review78496
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31228/
---
(Updated April 1, 2015, 11:50 a.m.)
Review request for mesos, Joerg Schad,
On March 27, 2015, 2:17 a.m., Adam B wrote:
docs/upgrades.md, line 15
https://reviews.apache.org/r/32543/diff/2/?file=907124#file907124line15
Is there some new behavior in Mesos 0.22 that just caused this issue to
start occurring? Or could this have happened with Mesos 0.21 or
I think is important mention the implications. The change doesn’t only imply to
change the include headers, but every function, struct and class used from the
c++ style headers will need to be prefixed with the std which in turn will
messed with the git blame.
Not to mention that, while most
On March 27, 2015, 2:17 a.m., Adam B wrote:
docs/slave-recovery.md, line 71
https://reviews.apache.org/r/32543/diff/2/?file=907123#file907123line71
(If the slave does not come back, each executorDriver shuts itself down
after $MESOS_RECOVERY_TIMEOUT.)
Important
On March 27, 2015, 4:36 p.m., Alexander Rojas wrote:
src/tests/module.cpp, line 137
https://reviews.apache.org/r/31267/diff/4-5/?file=903021#file903021line137
You may need a `CHECK(modules != NULL)` or a log and return in the NULL
case?
Alexander Rukletsov wrote:
If you
On March 27, 2015, 4:36 p.m., Alexander Rojas wrote:
src/tests/module.cpp, line 137
https://reviews.apache.org/r/31267/diff/4-5/?file=903021#file903021line137
You may need a `CHECK(modules != NULL)` or a log and return in the NULL
case?
If you follow the invokation path, you'll
On March 27, 2015, 4:36 p.m., Alexander Rojas wrote:
src/tests/module.cpp, line 137
https://reviews.apache.org/r/31267/diff/4-5/?file=903021#file903021line137
You may need a `CHECK(modules != NULL)` or a log and return in the NULL
case?
Alexander Rukletsov wrote:
If you
On March 24, 2015, 2:49 p.m., Michael Park wrote:
src/tests/master_allocator_tests.cpp, lines 123-126
https://reviews.apache.org/r/31268/diff/4/?file=903030#file903030line123
Could we indent this similar to this example from
`src/tests/isolator_tests.cpp`:
```
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review78509
---
Ship it!
src/tests/module.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31268/#review78512
---
Ship it!
Ship It!
- Till Toenshoff
On March 27, 2015, 4:27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/
---
(Updated April 1, 2015, 2:24 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31266/
---
(Updated April 1, 2015, 2:26 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31776/
---
(Updated April 1, 2015, 2:25 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated April 1, 2015, 2:26 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31265/
---
(Updated April 1, 2015, 2:28 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31263/
---
(Updated April 1, 2015, 2:27 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31268/
---
(Updated April 1, 2015, 2:29 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31268/#review78525
---
Patch looks great!
Reviews applied: [31775, 31776, 31266, 31267,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32657/
---
(Updated April 1, 2015, 3:39 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/
---
(Updated April 1, 2015, 3:44 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32653/
---
(Updated April 1, 2015, 3:43 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---
(Updated April 1, 2015, 3:44 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32660/
---
(Updated April 1, 2015, 3:45 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32659/
---
(Updated April 1, 2015, 3:44 p.m.)
Review request for mesos, Chi Zhang, Ian
Hm,
so after replaying some of my logs, I am not entirely sure. This may
be a design decision in the mesos core. Maybe you can help me out
here: If an event is not acked, it gets repeated. This is what happens
right now. If an event never gets acked (e.g. the first TASK_RUNNING),
what will happen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32664/
---
(Updated April 1, 2015, 3:45 p.m.)
Review request for mesos, Chi Zhang, Ian
Yes, I am using the jesos code here. I am not planning to use it, this
is just observing. :-)
I guess the comment at
https://github.com/apache/mesos/blob/master/src/messages/messages.proto#L85-L90
pretty much illustrates my problem. I am still stuck at the queue head
(without acks) and the bottom
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32694/#review78526
---
src/slave/containerizer/isolators/posix/disk.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32657/#review78532
---
Bad patch!
Reviews applied: [32654]
Failed command:
On March 31, 2015, 11:38 p.m., Chi Zhang wrote:
src/tests/port_mapping_tests.cpp, lines 188-192
https://reviews.apache.org/r/32656/diff/1/?file=910499#file910499line188
having no output here isn't expected; why delay reporting it?
Having no output here is currently an expected
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32664/#review78534
---
Bad patch!
Reviews applied: [32658, 32659]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32744/#review78631
---
Patch looks great!
Reviews applied: [32744]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31012/
---
(Updated April 1, 2015, 11:11 p.m.)
Review request for mesos, Dominic Hamon,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32756/
---
Review request for mesos, Ian Downes and Jie Yu.
Bugs: mesos-2572
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31012/
---
(Updated April 1, 2015, 11:13 p.m.)
Review request for mesos, Dominic Hamon,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32754/
---
Review request for mesos.
Repository: mesos
Description
---
Added a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32754/
---
(Updated April 1, 2015, 11:14 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32750/#review78625
---
Patch looks great!
Reviews applied: [32750]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742/#review78635
---
Patch looks great!
Reviews applied: [32742]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32654/#review78639
---
Patch looks great!
Reviews applied: [32654]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32757/
---
Review request for mesos, Ian Downes and Jie Yu.
Bugs: mesos-2572
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32653/#review78637
---
Patch looks great!
Reviews applied: [32653]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32750/#review78648
---
Patch looks great!
Reviews applied: [32750]
All tests passed.
-
On March 24, 2015, 11:34 p.m., Ian Downes wrote:
src/tests/cgroups_tests.cpp, line 1340
https://reviews.apache.org/r/31012/diff/1/?file=863527#file863527line1340
where is allocateRSSMemory and deallocateRSSMemory, I can't see them in
this review or r30545
now in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31012/
---
(Updated April 1, 2015, 11:09 p.m.)
Review request for mesos, Dominic Hamon,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32755/
---
Review request for mesos, Ian Downes and Jie Yu.
Bugs: mesos-2572
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32750/
---
(Updated April 1, 2015, 5:05 p.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31915/#review78626
---
Patch looks great!
Reviews applied: [31914, 31915]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32757/#review78642
---
Patch looks great!
Reviews applied: [31012, 32754, 32755, 32756,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32728/
---
Review request for mesos and Jie Yu.
Repository: mesos
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32698/#review78545
---
Ship it!
src/linux/perf.cpp
On April 1, 2015, 6:03 p.m., Ian Downes wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, lines 640-644
https://reviews.apache.org/r/32660/diff/2/?file=911855#file911855line640
Are these statistics not available through a netlink interface, i.e.,
using libnl? I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32728/#review78543
---
Ship it!
Thanks!
- Jie Yu
On April 1, 2015, 5:16 p.m., Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32586/
---
(Updated April 1, 2015, 3:35 p.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/
---
(Updated April 1, 2015, 3:35 p.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32585/
---
(Updated April 1, 2015, 3:34 p.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32694/
---
(Updated April 1, 2015, 7:40 p.m.)
Review request for mesos, Ben Mahler, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32698/
---
(Updated April 1, 2015, 7:40 p.m.)
Review request for mesos, Ben Mahler, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32660/#review78564
---
I feel if we use the native libnl api, we could shift a lot of the
On April 1, 2015, 3:32 p.m., James Peach wrote:
src/slave/containerizer/isolators/posix/disk.cpp, line 21
https://reviews.apache.org/r/32694/diff/2/?file=911373#file911373line21
Rather than depending on ``__linux__``, consider adding ``sys/prctl.h``
to ``AC_CHECK_HEADERS`` and
On April 1, 2015, 5:28 a.m., Adam B wrote:
src/slave/slave.cpp, line 1043
https://reviews.apache.org/r/32585/diff/1-2/?file=908253#file908253line1043
Hmm... I was actually thinking that this line of code can be removed
now that you're always filling in the id in the FrameworkInfo
On March 31, 2015, 10:42 p.m., Chi Zhang wrote:
src/tests/port_mapping_tests.cpp, line 396
https://reviews.apache.org/r/32653/diff/2/?file=910398#file910398line396
how about at least have this function return a future and change call
sites to use AWAIT_READY?
When
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32583/
---
(Updated April 1, 2015, 3:34 p.m.)
Review request for mesos, Adam B and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32584/
---
(Updated April 1, 2015, 3:34 p.m.)
Review request for mesos, Adam B and Niklas
On April 1, 2015, 12:55 a.m., Ben Mahler wrote:
src/slave/containerizer/isolators/posix/disk.cpp, lines 416-419
https://reviews.apache.org/r/32694/diff/2/?file=911373#file911373line416
Can't you just bind directly into `prctl`?
E.g.
```
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32660/#review78546
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32694/#review78596
---
Patch looks great!
Reviews applied: [32694]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32744/#review78601
---
At least the comments above getContainerIdFromSymlink() definition
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32744/
---
Review request for mesos, Jie Yu and Cong Wang.
Bugs: mesos-2574
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742/#review78591
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32744/
---
(Updated April 1, 2015, 9:19 p.m.)
Review request for mesos, Jie Yu and Cong
On April 1, 2015, 8:48 p.m., Jie Yu wrote:
The diff does seem to be correct.
Needs one more rev.
- Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32654/#review78585
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32654/
---
(Updated April 1, 2015, 9:30 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32654/#review78585
---
The diff does seem to be correct.
- Jie Yu
On April 1, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32653/
---
(Updated April 1, 2015, 8:54 p.m.)
Review request for mesos, Chi Zhang, Ian
On April 1, 2015, 2:28 a.m., Adam B wrote:
src/slave/slave.cpp, line 1043
https://reviews.apache.org/r/32585/diff/1-2/?file=908253#file908253line1043
Hmm... I was actually thinking that this line of code can be removed
now that you're always filling in the id in the FrameworkInfo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31228/#review78574
---
LGTM!
- Isabel Jimenez
On April 1, 2015, 9:50 a.m., Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742/
---
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32654/
---
(Updated April 1, 2015, 8:42 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/#review78579
---
Patch looks great!
Reviews applied: [32583, 32584, 32585, 32586,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31228/#review78577
---
3rdparty/libprocess/include/process/process.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32750/
---
Review request for mesos.
Bugs: MESOS-2585
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32653/#review78605
---
src/tests/port_mapping_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31914/
---
(Updated April 1, 2015, 10:27 p.m.)
Review request for mesos and Ian Downes.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31915/
---
(Updated April 1, 2015, 10:28 p.m.)
Review request for mesos, Ian Downes and
On March 17, 2015, 6:53 p.m., Ian Downes wrote:
src/slave/containerizer/isolators/cgroups/mem.cpp, line 441
https://reviews.apache.org/r/31915/diff/1/?file=890842#file890842line441
if this conditional on limitSwap?
Do you want it more explicit? If swap is not used, option will be
1 - 100 of 115 matches
Mail list logo
