Re: Services with no definition and usage

I'm in favor of keeping them and adding the service definitions. As Taher mentions, these are CRUD services and IMO if we have the table, we should have the set of services allowing management of the data. These implementations are quite synonymous with the FacilityContactMech services, they're o

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

Since this is such a complex problem perhaps we better come up with a best practice since we have so many Helper/Worker/Reader classes in OFBiz and a bit of API consistency goes a long way. If a GenericEntityException is thrown within a Helper/Worker/Reader class method, how should we handle it?

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java

Definitely changes the behavior, but the behavior wasn't good before (and still isn't good now). If we can't return an accurate order item sub-total then we should be throwing an exception IMO. This is often why we can't just bulk fix the issues reported by static analysis tools, because the fix

Re: Remove Order data model dependency for POS sales

It's also used for pricing rule and promotion capabilities. Laybys/layaways, rainchecks and purchases on account also would benefit from the order model. If POS were extended to hospitality that would also rely on an order model. Regards Scott On 29/08/2017 23:29, "Arun Patidar" wrote: > Hello

Re: Quantity UOM in Supplier Product

Hi Vaibhav, Comments inline. Regards Scott On 11 August 2017 at 02:55, Vaibhav Jain wrote: > Thank you so much Scott for sharing these details, indeed they are really > helpful. > Kindly see my comments inline. > > > On Thu, Aug 10, 2017 at 3:22 PM, Scott Gray > wr

Re: Rule to deprecated a service

; the first release of the last freezed branch > > Opinions? > > Jacques > > > Le 07/08/2017 à 00:02, Scott Gray a écrit : > >> Some additional nice to haves: >> - Add a "since" attribute to the "deprecated" element that would contain >> ei

Re: Quantity UOM in Supplier Product

Hi Vaibhav, It's a good question and mailing list archives (that are available) don't really answer the question clearly. At the moment as far as I can tell, the quantityUomId and unitsIncluded field do nothing, they're display only. I think SupplierProduct.unitsIncluded is the same as Product.q

Re: Rule to deprecated a service

+1 for logging a warning instead of an error +1 for using an element to deprecate. Although I'd prefer "deprecated" for the element name and I'd prefer "use-instead" for the attribute name. Would keep us consistent with java conventions, @deprecated and the text is often "use X instead". I think

Re: [Discussion] Failing the build if data loading fails

I don't mind if the behavior changes, but it's never bothered me since the information is only a few lines above the build's success/fail message. Or at least, it was with the ant build system, I haven't tried with gradle recently enough to recall. Regards Scott On 10 July 2017 at 07:18, Taher A

Re: svn commit: r1800245 - in /ofbiz/ofbiz-framework/trunk/applications/accounting: groovyScripts/rate/RateServices.groovy minilang/rate/ servicedef/services_rate.xml

Hi Nicolas, My first code review in a while so I apologize if I'm wrong on any points, or if they've been discussed already. 1. It would be good if the services were converted one per commit, with the empty minilang file removed at the end with a separate commit. That would allow reviewers to co

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

Hi Taher, I can understand your frustration, but this: > This commit is wrong and bad on multiple levels. Please revert is an unproductive and unreasonable request. Whether you want to or not, you have to justify the request. Obviously the developer doesn't know what is wrong or they wouldn't

Re: Help in reviewing my refactoring of CatalinaContainer

;> > >>> On Tue, Jun 13, 2017 at 9:17 AM, Taher Alkhateeb < > >>> slidingfilame...@gmail.com > >>> > >>>> wrote: > >>>> So the good thing is that the refactoring exercise surfaced this > issue. > >>>> Based on feedback from Sc

Re: Help in reviewing my refactoring of CatalinaContainer

The project I'm currently on is actively using clustering (session replication) and I know for certain this isn't the only project nor are we the only vendor to use it. I'm using an older version of OFBiz though so I can't confirm if the latest codebase has it working. It can be tricky to set up

Re: svn commit: r1798104 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbi z/entity/util/EntityListIterator.java

Isn't a stacktrace pointless given that this would happen during finalize? It wouldn't say anything about where the problem is. Regards Scott On 10/06/2017 07:21, "Jacques Le Roux" wrote: > Actually I just added "\n Please report by creating an OFBIZ-9297 subtask > with the stack trace, thanks"

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.02

+1 Regards Scott On 16 May 2017 at 20:11, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > This is the vote thread to release a new bug fix release for the > release16.11 branch. This new release, "Apache OFBiz 16.11.02" will > supersede the 16.11.01 release. > > The release fi

Re: Broken pipe (write failed) [BUG]

I've seen that error before when one of two things happened: 1. Apache timed out waiting for a response from OFBiz 2. The client (browser) cancelled the request before OFBiz was able to respond. e.g. the user closed the browser or refreshed or navigated away. So it isn't a bug as such, it's more a

Re: [jira] [Assigned] (OFBIZ-8232) Improve Dutch labels for commonext component

ut if you feel that strong about it, I suggest you > find out. > > Best regards, > > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ > > On Wed, Ma

Re: [jira] [Assigned] (OFBIZ-8232) Improve Dutch labels for commonext component

). > > Best regards, > > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ > > On Tue, May 2, 2017 at 10:15 AM, Scott Gray > wrote: > > &

Re: [jira] [Assigned] (OFBIZ-8232) Improve Dutch labels for commonext component

based solutions & services >> >> OFBiz Extensions Marketplace >> http://oem.ofbizci.net/oci-2/ >> >> On Sun, Apr 30, 2017 at 10:18 AM, Michael Brohl > > >> wrote: >> >> Hi Scott, >>> >>> thanks for trying to clarify and gi

Re: [jira] [Assigned] (OFBIZ-8232) Improve Dutch labels for commonext component

I would prefer they were left assigned to the committer since the onus tends to fall on them if there are any post closure issues. My guess if that Pierre wants to track what tickets he contributed to beyond being the reporter. Could you confirm Pierre? Beyond what I've mentioned is there any ot

Re: svn commit: r1792866 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/ accounting/data/ marketing/data/ order/ order/data/ party/testdef/data/ product/data/ workeffort/minilang/tes

Could you expand on that please Taher? The tests are run once all demo data is loaded are they not? Regardless, I appreciate this effort as it's long overdue. Regards Scott On 28/04/2017 00:13, "Taher Alkhateeb" wrote: > Does not work, it will fail tests if you put them in that order. Feel fre

Re: svn commit: r1792270 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/quote/QuoteServices.xml servicedef/services_quote.xml

Having tests setup and teardown the data they need would possibly allow us to run test suites in parallel which would dramatically decrease the processing time. I like having the tests depend on the database though, in the past it's been helpful for spotting deadlocks. Regards Scott On 24 April

Re: Validating telecom numbers

I think Google has a phone number library that could be put to use to take the heavy lifting off our shoulders. Regards Scott On 15/04/2017 00:53, "Pierre Smits" wrote: > For (to be) OFBiz definitions, I suggest to review ITU and country policies > regarding the various kinds of telephone defin

Re: Date filtered queries shouldn't be cached

> it seems to be quite a specific workaround as opposed to a generic > solution. Shouldn't we instead have something that works for all dates > instead of just specific dates with the name "fromDate" when compared with > current date / time? > > On Thu, Apr 6, 2017

Date filtered queries shouldn't be cached

In the current project I'm working on I see a lot of developers making the mistake of caching date filtered queries. Why shouldn't you cache date filtered queries? 1. If you're filtering by the current moment in time then the results are irrelevant within a few moments of them being retrieved. So

Re: svn commit: r1789863 - /ofbiz/ofbiz-framework/trunk/applications/content/widget/content/DataResour ceForms.xml

I agree with Jacques and Deepak. The code is an improvement on what was there, end of story. A contributor is a volunteer who is free to do as much or as little as they please so long as each contribution is a full step forward. Regards Scott On 3/04/2017 17:13, "Deepak Dixit" wrote: > I agree

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

I agree with Jacopo, these are very functional changes that shouldn't be made without understanding the workflow. It's good to clean up the code but it shouldn't be done blindly. On 25 March 2017 at 02:13, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > On Fri, Mar 24, 2017 at

Re: Drop plugins/birt/webapp/birt/webcontent ?

I'm curious as to how it was ever added, when the birt component was first introduced I'm pretty sure we agreed to not include this part of it because of licensing concerns. On 25 March 2017 at 02:34, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > On Thu, Mar 23, 2017 at 10:01

Re: svn commit: r1786919 - in /ofbiz/ofbiz-framework/trunk/applications/accounting/widget: FieldLookupForms.xml LookupScreens.xml

I'm not familiar with the work Adrian did any subsequent work but I do believe the basis of the idea has merit. While there are some similarities between a form and a table, I think there are enough differences that it would be easier to move forward with new features specific to one or the other

Default theme (WAS: [proposal] actions to take with plugins)

We seemingly couldn't agree on the best logo either, yet we have only one. I think an instant run-off vote ( https://en.wikipedia.org/wiki/Instant-runoff_voting) would probably be the most appropriate way to come to a conclusion, given the large number of themes and relatively small number of votes

Re: [discussion] With plugins, is hot-deploy necessary?

I imagine it would be fairly simple to add another top level folder with the same functionality as plugins if desired. Easy enough that we don't have to include it out of the box. On 5/03/2017 03:42, "Wai" wrote: > Either way is fine for me. I'll name my components directories in 'plugins' > wit

Re: Git for commiters

setup who put it in place more recently? Regards Scott On 19 February 2017 at 22:22, Jacques Le Roux wrote: > OK thanks, so would you say that the steps in the document are too much > and you could change them or it's OK and up to date as is? > > Jacques > > > > Le 1

Re: Git for commiters

Well it's been a while since I worked on the trunk but yes, I would still use git svn for the work. Regards Scott On 19/02/2017 21:18, "Jacques Le Roux" wrote: Thanks Scott, Do you mean you are still using it, or? Jacques Le 18/02/2017 à 23:03, Scott Gray a écrit : > I

Re: Git for commiters

I've been using git-svn for years, I don't think my setup involved as many steps as that document shows though. I think I just started from git svn init. The main advantages for me was to be able to stash works in progress and to make multiple local commits before pushing to svn. Regards Scott

Re: buildbot failure in on ofbiz-trunk

Try and be patient Jacques, I'm also having trouble understanding what you are saying. Here's what I've been able to understand so far: - Pre-gradle OFBiz tests run fine on buildbot - Gradle OFBiz fails on buildbot with a complaint that the default ports are in use - The test framework in OFBiz ha

Re: svn commit: r1780790 - in /ofbiz/trunk: common.gradle plugins/component-load.xml plugins/ebaystore/ofbiz-component.xml

Scott On 30 January 2017 at 09:54, Pierre Smits wrote: > Maybe removing code that doesn't work from the code base? > > Best regard, > > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace

Re: svn commit: r1780790 - in /ofbiz/trunk: common.gradle plugins/component-load.xml plugins/ebaystore/ofbiz-component.xml

Hi Pierre, It was disabled and it is still disabled, the only change relevant to ebaystore is the means of disablement. I'm not sure what needs to be re-thought? Eventually someone will decide that addressing the 3rd party library issues in ebaystore is an itch they want to scratch, but until th

Re: Does the deleteWorkEffort really always works?

What comments are you looking for? It either works or it doesn't. A couple of things to consider: - Is there really a good reason to delete a WorkEffort record when changing its status should be sufficient? - Maybe it doesn't work now because the data model has changed since it was introduced? -

Re: Use ecomseo on demo rather than ecommerce

wrote: > OK, I'll answer your questions step by step. I just need time... > > Jacques > > > Le 22/01/2017 à 22:01, Scott Gray a écrit : > >> 1. Ask for input >> 2. Get no responses except a -1 >> 3. Wait for a few months >> 4. Proceed anyway without fu

Re: Use ecomseo on demo rather than ecommerce

gt;> >> Le 22/09/2016 à 14:07, Jacques Le Roux a écrit : >> >>> Le 22/09/2016 à 13:22, Scott Gray a écrit : >>> >>>> This mostly to somehow battle test it, even if I know it works well >>>>> >>>> So does it need battle testing

Re: MODERATE for dev@ofbiz.apache.org

Did you check if the email in the body was subscribed? ad...@officefans.net Regards Scott On 16 January 2017 at 20:52, Jacques Le Roux wrote: > Hi, > > We receive a lot of the forwarded email (attachment) in the OFBiz dev ML. > Since ad...@fcc-foshan.com is not registered they are moderated and

Re: What is the "Apache OFBiz" product?

I prefer "Business" to "ERP" or "Enterprise" but I'm not sure about the repeating syllables involved in saying "Apache OFBiz Business {thing}". The biz biz doesn't flow well so I'm inclined to fall back to "Enterprise". Another adjective to consider over "framework" might be "platform". The frame

Re: Proposal to rename specialpurpose to plugins

e a massive amount of lib dependencies and some entanglements with > core. > > On Jan 2, 2017 11:42 PM, "Scott Gray" > wrote: > > > Ok thanks, it just wasn't clear to me. > > > > My only concern with renaming it just for the sake of renaming it is t

Re: Proposal to rename specialpurpose to plugins

nd prepare > a mechanism for handling plugins. Perhaps we can start aanother thread to > discuss the next steps moving forward. > > Cheers, > > Taher Alkhateeb > > On Jan 2, 2017 11:02 PM, "Scott Gray" > wrote: > > > What's the plan for the hot-

Re: Proposal to rename specialpurpose to plugins

What's the plan for the hot-deploy folder? Remove it? Regards Scott On 3 January 2017 at 08:26, gil portenseigne wrote: > +1 > > Gil > > > > On 02/01/2017 17:45, Taher Alkhateeb wrote: > >> Hello Everyone, >> >> In reference to earlier discussions and threads on the above subject, I am >> here

Re: svn commit: r1776243 - /ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/Model Service.java

cause it's used >>>> before running the service. >>>> I guess it's how it should be used (why running isValid() before >>>> running?). So I guess we can simply use that >>>> >>>> public boolean isValid(Map context, String mode, >>>> L

Re: svn commit: r1776243 - /ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/ModelService.java

I guess it depends on how this will be used but I think there is a big difference between " // do not validate results with errors" and returning false from an isValid method. IMO an error output response is perfectly valid. Regards Scott On 28 December 2016 at 21:47, wrote: > Author: jleroux

Re: Serialized Inventory issue with backorder item

+1 on binding status to InventoryItemDetail. Regards Scott On 22 December 2016 at 21:50, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Very interesting thread, thanks to you all for the valuable exchange of > information. > > My two cents: > * it would be great to refactor Se

Re: Replace password encryption SHA-1 by SHA-512

Maybe ask LinkedIn, Zappos, Evernote, Living Social or Adobe if it's prudent to assume that no one will ever get hold of your password hashes. One researcher was able to recover 80% (~140 million) of passwords from the LinkedIn breach in a single day, they were using unsalted SHA1. Regards Scott

Re: [DISCUSSION] Defining an OFBiz Project Strategy

I don't think it's really our UI that inhibits adoption. With any reasonably sized project there is going to be a large amount of UI customization where the front-end will be almost completely written from scratch and the back-end at least partially so. This has been my experience at least over t

Re: [CONF] OFBiz Project Open Wiki > Apachecon EU 2016

What's the purpose of the pop-quiz? Regards Scott p.s. please don't cross post without a good reason On 28 November 2016 at 12:19, Pierre Smits wrote: > Sharan, > > Thank you for sharing this. Also thanks to all the participants of the > event who added their slides to the page. > > Pop-quiz q

Re: OFBiz Premier League – Reviewers Choice Award

What's your point? On 27/11/2016 03:00, "Paul Piper" wrote: > Scott, your image is on that website, too, you know... > > OFBiz_Premier_League_%E2%80%93_The_League_of_Like_Minded_Professionals.png > > > > > > -- > View this message in context: h

Re: OFBiz Premier League – Reviewers Choice Award

I guess it all depends on how cynical you want to be. I wasn't very involved with the effort but my understanding was that it was an attempt to get HotWax devs more involved in the open source project and interacting with the community more. The community days have been occurring a lot longer tha

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.01

+1 On 22 November 2016 at 09:44, Nicolas Malin wrote: > md5sum ok, shasum ok and the ./gradle loadDefault testIntegration return > SUCCESSFUL > > So +1 for me > > Nicolas > > > Le 21/11/2016 à 19:51, Jacopo Cappellato a écrit : > >> This is the vote thread to issue the first release from the bra

Re: OFBiz Premier League – Reviewers Choice Award

Hi Sharan, If you could extend the deadline a few days it would be appreciated, I haven't yet been able to read through all of the submissions. Thanks Scott On 13 November 2016 at 09:22, Bilgin Ibryam wrote: > Any effort to help make OFBiz better is worth an applause. Well done > HWM and Shara

Re: Integration tests take a very long time

FYI latest trunk takes almost exactly 5 minutes on my machine. Regards Scott On 16 November 2016 at 06:34, Taher Alkhateeb wrote: > Hi Folks, > > As you may recall, we introduced unit-tests to OFBiz in addition to the > existing integration tests to try and balance the long development cycle >

Re: svn commit: r1763686 - /ofbiz/trunk/specialpurpose/ecommerce/template/shoppinglist/EditShoppingList.ftl

Any indication as to why $('selectShoppingList') wasn't working? I'm not up to date with our latest javascript framework but changing to document. getElementById('selectShoppingList') seems like a workaround rather than a fix. I'm also curious why the diff seems so large when the changes were muc

Re: Themes votes results

Before taking any action I'd prefer to see a proper tally of binding and non-binding votes sent to each vote thread. Regards Scott On 4/10/2016 9:55 PM, "Taher Alkhateeb" wrote: > Wow! You start 9 votes in 9 threads; you engage the entire community and > now that the votes are out and finished

Re: OFBiz specific rules on lazy consensus [was Re: [VOTE] Put the Flatgrey theme in Attic]

ed to scratch. > > Best regards, > > Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ > > On Sun, Sep 25, 2016 at 11:07 AM, Scott Gray > > wrote: > >

Re: OFBiz specific rules on lazy consensus [was Re: [VOTE] Put the Flatgrey theme in Attic]

Is it a complicated thing to ask our most prolific contributor to slow down so that we can all be effectively involved? Personally I don't think it is complicated. On 25/09/2016 22:03, "Pierre Smits" wrote: > Everyone participating can be blamed for complaints, or needlessly > prolonging discuss

Re: OFBiz specific rules on lazy consensus [was Re: [VOTE] Put the Flatgrey theme in Attic]

Hi Paul, In the thread you linked to, Jacques made some strong statements of what he thought about the fact he hadn't received a response. I felt it was a good opportunity to point out just how many responses he asks the community to provide. It wasn't intended as an an attack, simply a request to

Re: OFBiz specific rules on lazy consensus [was Re: [VOTE] Put the Flatgrey theme in Attic]

.org/foundation/voting.html#LazyConsensus but you might > already use the proposition above... > > Jacques > > Le 24/09/2016 à 23:39, Scott Gray a écrit : > >> - I think you rely on lazy consensus too much. Not many contributors have >> as much time as you to give to

Re: Wiki page for the "monthly Jira issues list" creation in the blog

feedback? Regards Scott On 25 September 2016 at 11:00, Scott Gray wrote: > Calm down Jacques, I'm sure Michael will respond when he has a chance. > This isn't a big deal and I don't see why there would be any rush to fill > your request. > > Regards > Scott >

Re: Wiki page for the "monthly Jira issues list" creation in the blog

Calm down Jacques, I'm sure Michael will respond when he has a chance. This isn't a big deal and I don't see why there would be any rush to fill your request. Regards Scott On 23 September 2016 at 21:38, Jacques Le Roux wrote: > After 4 days clearly nobody cares. I guess Michael does not want t

Re: [VOTE] Put the Flatgrey theme in Attic

A couple of things: - Starting 9 x 72 hour votes at the start of a weekend doesn't give people much time if they aren't familiar with the themes and had plans for the weekend. If there's no rush then give it a week IMO. - I think you rely on lazy consensus too much. Not many contributors have as

Re: Use ecomseo on demo rather than ecommerce

review it and/or >> use >> it and provide feedback. >> >> Regards >> Scott >> >> On 23 September 2016 at 00:07, Jacques Le Roux < >> jacques.le.r...@les7arts.com >> >>> wrote: >>> https://issues.apache.org/jira/browse/OF

Re: Use ecomseo on demo rather than ecommerce

22seo%22 > > Jacques > > > > Le 22/09/2016 à 13:25, Scott Gray a écrit : > >> By the way, is there any technical or user documentation for it? I >> haven't >> looked at it and don't have time to review the actual implementation right >> now.

Re: Commit template, more flexibility [was Re: Put "Reverts" in the commit template?]

I can't believe you're being so stubborn about something so minor Jacques, it seems like very strange behavior to me. For what it's worth as a native English speaker, reading a commit message written in present-tense feels very strange to me. I'm looking at a history and reading something as thou

Re: Use ecomseo on demo rather than ecommerce

By the way, is there any technical or user documentation for it? I haven't looked at it and don't have time to review the actual implementation right now. The link you provided doesn't offer much more than a sales pitch. Regards Scott On 22 September 2016 at 23:22, Scott Gray

Re: Use ecomseo on demo rather than ecommerce

> > This mostly to somehow battle test it, even if I know it works well So does it need battle testing or does it work well? Have you deployed it to any production instances? Has anyone else? Regards Scott On 19 September 2016 at 01:27, Jacques Le Roux wrote: > Hi, > > Maybe you don't know

Re: Groovy and semicolon at EOL

I don't particularly care one way or another if groovy files have a semi-colon at the end. I don't even care about consistency because it is such a minor thing. I say remove them if they're on a line you happen to be editing, otherwise just leave them be. Regarding the annotations, there's plent

Re: Groovy and semicolon at EOL

> > I don't want to remove existing ones (easy done in one shoot with a S/R > regexp) because it would remove the precious svn annotations (when you want > to look for reasons in the past) Hi Jacques, What are these precious svn annotations used for? Maybe I'm out of the loop since I use git-sv

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

We should probably just have a vote on the contentious points and be done with it. The general consensus doesn't seem to be good enough for Jacques. Regards Scott On 13 September 2016 at 03:41, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > I am rather interested in knowing i

Re: svn commit: r1759945 - /ofbiz/trunk/

> > to lessen (my) mouse and keyboard activity After you typed such a large response that says so little, I found this comment pretty hilarious. Seriously though, I'm going to assume that Michael is looking for a standard format and phrasing so that the text can be processed in some automatic ma

Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name

A single commit is fine IMO if the changes are all focused on something specific. The only style of commit I would object to are ones that incorporate a non-trivial number of unrelated changes, otherwise whatever works best for the committer is fine by me. Regards Scott On 5 September 2016 at 21

Re: How to deploy OFBiz without Gradle

e dependency headache directly in many > newer systems. > > If you have a preference for one of the above solutions then we can start > exploring it in more depth and enhancing it, or if you have other > suggestions and ideas please fire away. > > Regards, > > Taher Alkhateeb > >

Re: svn commit: r1758461 - /ofbiz/trunk/framework/start/src/main/java/org/apache/ofbiz/base/start/StartupCommandUtil.java

"Offsets all default ports for OFBiz" Regards Scott On 31 August 2016 at 08:12, wrote: > Author: jleroux > Date: Tue Aug 30 20:12:57 2016 > New Revision: 1758461 > > URL: http://svn.apache.org/viewvc?rev=1758461&view=rev > Log: > The portoffset option does not only offset the default network po

Re: How to deploy OFBiz without Gradle

I just want to add that I don't think it is an uncommon scenario to desire a self-contained ofbiz build. The project I'm currently working on uses build servers to compile and deploy to test instances and to production. A production deployment for us means deploying to 10+ nodes and we do this by

Re: How to deploy OFBiz without Gradle

I haven't looked at the gradle implementation much, do the jars not end up somewhere within ofbiz after building? Thanks Scott On 30 August 2016 at 18:21, Jacques Le Roux wrote: > Hi, > > I just tried something which seemed very simple after reading Taher's > suggestion > > in OFBIZ-7783 > "For

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

ues.apache.org/jira > /browse/OFBIZ-7966?focusedCommentId=15431090 > > Jacques > > > Le 29/08/2016 à 23:38, Scott Gray a écrit : > >> Hi Jacques, >> >> None whatsoever. I was just trying to offer a design that would truly >> decouple the tracking code fu

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

Keep in mind though that dealing with silent exceptions wasn't in the scope of the commit. Code reviews are great but we shouldn't expect committers to fix issues they didn't introduce. On 29 August 2016 at 21:04, Jacques Le Roux wrote: > Hi Harsh, > > Please refer to what is usually done for t

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

: > HI Scott, > > This sounds like an actionable plan, any plan to action it? > > Jacques > > > > Le 25/08/2016 à 07:38, Scott Gray a écrit : > >> I was thinking that: >> 1. We need a means for the tracking code logic to be able to access the >> cooki

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

gt; Pierre Smits > > ORRTIZ.COM <http://www.orrtiz.com> > OFBiz based solutions & services > > OFBiz Extensions Marketplace > http://oem.ofbizci.net/oci-2/ > > On Wed, Aug 24, 2016 at 9:59 AM, Scott Gray > wrote: > > > Hi Pierre, Jacopo, Jacques, >

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Pierre, Jacopo, Jacques, Sticking specifically to the commit being discussed, the beauty of the tracking code logic is that it effectively does nothing if you aren't using it. Granted TrackingCodeEvents.makeTrackingCodeOrders() could do with being improved so that it exits earlier if no cookie

Re: Feedback on Committer Mentoring and HipChat

I'm in two minds about it. On one hand it's nice to be able to chat in real time with other community members and increasing our sense of community is important for the project. But on the other hand, I fear it would too often be used to have discussions that should really be had on the user/dev

Re: Refactoring our Wiki spaces

Easy solution (if possible) would be to disable comments altogether. If there's a discussion to be had about a page it can go to the dev list or JIRA without risk of being deleted or creating any conspiracy theories about censorship. Being able to comment directly on a page is handy, but if we're

Re: buildbot success in on ofbiz-trunk

Surely there's some solution for the jars not being cached? I wonder how the other projects deal with this Regards Scott On 7/08/2016 03:56, "Taher Alkhateeb" wrote: > Okay cool. I am trying to eliminate all causes. The crash is happening > exactly when trying to construct the classpath for the

Re: Taking a decision on remaining Jars in OFBiz

t; >>> >>> Taher Alkhateeb >>>> >>>> On Sat, Aug 6, 2016 at 11:44 AM, Jacques Le Roux < >>>> jacques.le.r...@les7arts.com> wrote: >>>> >>>> The idea is that by default the task does not do much. You have to

Re: Taking a decision on remaining Jars in OFBiz

Why isn't whatever functionality 'ofbizSecure' provides, just included as part of the regular 'ofbiz' task? On 5 August 2016 at 21:35, Jacques Le Roux wrote: > Le 05/08/2016 à 11:21, Taher Alkhateeb a écrit : > >> +1 makes sense >> >> Should we also remove the tasks ofbizSecure and ofbizBackgrou

Re: Security : seed-initial

It's demo data, what's wrong with it using the demo reader? Any number of issues can arise when you modify demo data in the database and then reload it. e.g. shipping a demo order and then reloading the XML would leave the shipment and issuances in place but revert the order to approved. Perhaps

Re: Apache OFBiz Service Providers page

> > Further more the columns 'number of committers/contributors' and > 'Contributors' provide an unfair advantage to those with committers and > more than 1 contributor. > An advantage? Perhaps. Unfair? I'm not so sure about that. Pros: If it does convey an advantage then perhaps that might enc

[jira] [Commented] (OFBIZ-235) POS Z report

[ https://issues.apache.org/jira/browse/OFBIZ-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398534#comment-15398534 ] Scott Gray commented on OFBIZ-235: -- Do a lot of these tickets you're closing

[jira] [Commented] (OFBIZ-7808) Add Gradle Interactive tasks

[ https://issues.apache.org/jira/browse/OFBIZ-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396605#comment-15396605 ] Scott Gray commented on OFBIZ-7808: --- Thirded by me. If the history of this project

Re: svn commit: r1752920 - in /ofbiz/trunk: ./ applications/accounting/entitydef/ applications/accounting/groovyScripts/admin/ applications/accounting/groovyScripts/ap/invoices/ applications/accountin

Never mind, must be an issue with my local repo Regards Scott On 27 July 2016 at 23:18, Scott Gray wrote: > Were these files moved, or deleted and re-added? I ask because I'm now > not getting any file history when I use git log > > Regards > Scott > > On 16

Re: svn commit: r1752920 - in /ofbiz/trunk: ./ applications/accounting/entitydef/ applications/accounting/groovyScripts/admin/ applications/accounting/groovyScripts/ap/invoices/ applications/accountin

Were these files moved, or deleted and re-added? I ask because I'm now not getting any file history when I use git log Regards Scott On 16 July 2016 at 22:31, wrote: > Author: deepak > Date: Sat Jul 16 10:30:49 2016 > New Revision: 1752920 > > URL: http://svn.apache.org/viewvc?rev=1752920&view

Re: [DISCUSSION] Simplification of the create component process

I'm confused Pierre, didn't you start this thread with a simple and straightforward solution to the createComponent task? Where did it diverge so that you now appear to be arguing against your original proposal? I'm sorry if I missed the divergence but I haven't been able to spot it. Regards Sco

[jira] [Commented] (OFBIZ-7808) Add Gradle Interactive tasks

[ https://issues.apache.org/jira/browse/OFBIZ-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393546#comment-15393546 ] Scott Gray commented on OFBIZ-7808: --- It's a sad state of affairs really, there

[jira] [Commented] (OFBIZ-7808) Add Gradle Interactive tasks

[ https://issues.apache.org/jira/browse/OFBIZ-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393426#comment-15393426 ] Scott Gray commented on OFBIZ-7808: --- I tend to agree with Taher on this, I don

Re: svn commit: r1754051 - in /ofbiz/trunk/specialpurpose/scrum: groovyScripts/FindProductBacklogItem.groovy widget/scrumForms.xml

ian to fix these minor details >> > Oh, cool you did already :) > > >> Jacques >> >> >> Le 26/07/2016 à 03:26, Scott Gray a écrit : >> >>> A couple of minor points: >>> 1. It isn't necessary to use UtilValidate.isEmpty() in groovy for St

[jira] [Commented] (OFBIZ-7929) Scrum find Total Backlog Item is not working in non-English language

[ https://issues.apache.org/jira/browse/OFBIZ-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392989#comment-15392989 ] Scott Gray commented on OFBIZ-7929: --- A couple of minor points: 1. It isn't nec

<    1   2   3   4   5   6   7   8   9   10   >