Re: Review Request: CAS-CL move to trunk

2011-11-01 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2638/ --- (Updated 2011-10-31 22:26:03) Review request for oodt and Chris Mattmann. Summary --- CAS-CL

Re: Review Request: CAS-CLI CmdLineAction modification to take a printer which CmdLineActions should print output messages to

2011-11-17 Thread Chris Mattmann
wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2873/ --- (Updated 2011-11-17 09:21:33) Review request for oodt and Chris

Re: Review Request: getXmlRpcProduct and getProductFromXmlRpc should allow null values for product member variables since Product is just a carrier object

2011-11-20 Thread Chris Mattmann
for oodt, Chris Mattmann and Paul Ramirez. Summary --- issue is tracked here: https://issues.apache.org/jira/browse/OODT-353 Diffs - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/util/XmlRpcStructFactory.java 1203939 trunk/filemgr/src/test/org/apache/oodt/cas

Review Request: Tool to clean Workflow Instance repositories

2011-11-30 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2980/ --- Review request for oodt, brian Foster and Paul Ramirez. Summary --- Issue

Re: Review Request: XMLPS should be able to stream large results

2012-01-21 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/#review4520 ---

Re: Review Request: XMLPS should be able to stream large results

2012-01-21 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/#review4521 --- Ship it! Ricky great job. Some minor nits, nothing that is a

Re: Review Request: XMLPS should be able to stream large results

2012-02-20 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/#review5230 --- Ship it! Looks good! Ship it! - Chris On 2012-01-19 02:54:44,

Re: Review Request: Integrate CAS-Catalog with CAS-CLI

2012-02-27 Thread Chris Mattmann
, Chris Mattmann and Paul Ramirez. Summary --- Issue tracked here: https://issues.apache.org/jira/browse/OODT-391 Diffs - trunk/catalog/pom.xml 1294375 trunk/catalog/src/main/bin/catserv-client 1294375 trunk/catalog/src/main/bin/catserv-server 1294375 trunk

Re: Review Request: Remove old command line option code from commons

2012-02-27 Thread Chris Mattmann
Foster wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4071/ --- (Updated 2012-02-27 23:07:29) Review request for oodt, Chris

Re: Review Request: OODT-361: Workflow test event fails with NPE

2012-02-28 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4089/#review5437 ---

Re: Review Request: Ability for File Manager to stage an ingested Product to one of its clients

2012-03-06 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4195/ --- (Updated 2012-03-06 07:57:51) Review request for oodt, Chris Mattmann and Paul Ramirez. Summary --- $ ./filemgr-client -h

Re: Review Request: Updates from branch cas-pge

2012-03-10 Thread Chris Mattmann
-mail. To reply, visit: https://reviews.apache.org/r/4196/ --- (Updated 2012-03-09 08:17:12) Review request for oodt, Chris Mattmann and Paul Ramirez. Summary --- This includes the changes from wengine-branch cas-pge... still

Re: Review Request: Port wengine ControlMetadata to cas-pge's PgeMetadata

2012-03-10 Thread Chris Mattmann
. To reply, visit: https://reviews.apache.org/r/4269/ --- (Updated 2012-03-10 01:32:07) Review request for oodt, Chris Mattmann and Paul Ramirez. Summary --- Updates CAS-PGE's PgeMetadata to work similar to WEngine's

Re: Review Request: Port wengine ControlMetadata to cas-pge's PgeMetadata

2012-03-10 Thread Chris Mattmann
01:32:07) Review request for oodt, Chris Mattmann and Paul Ramirez. Summary --- Updates CAS-PGE's PgeMetadata to work similar to WEngine's ControlMetadata This addresses bug OODT-403. https://issues.apache.org/jira/browse/OODT-403 Diffs - trunk/pge/pom.xml

Re: Review Request: Add CAS-PGE support for multiple Property Adders

2012-03-12 Thread Chris Mattmann
/ --- (Updated 2012-03-13 01:31:24) Review request for oodt, Chris Mattmann and Paul Ramirez. Summary --- Will introduce the reserved metadata field: PGETask_PropertyAdders and deprecate: PGETask_PropertyAdderClasspath This addresses bug OODT-406. https

Re: Review Request: Drop Spring logging levels from WARNING to SEVERE

2012-03-14 Thread Chris Mattmann
On 2012-03-14 15:57:26, Paul Ramirez wrote: Looks good to me. Next time you can link this to the Jira issue if you want by putting the OODT-408 in the bugs field in the review request. +1! Also feel free to add me, or pramirez and rickdn as we all seem to be using RB too. It rox! -

Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

2012-03-14 Thread Chris Mattmann
://reviews.apache.org/r/4326/ --- (Updated 2012-03-14 05:18:33) Review request for oodt, Chris Mattmann and Paul Ramirez. Summary --- The enum for met keys will allow for backwards compatibility to be toggled on/off easily

Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

2012-03-14 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4326/ --- (Updated 2012-03-14 05:18:33) Review request for oodt, Chris Mattmann

Re: Review Request: OODT-410: DataSourceCatalog compatible with HypersonicSQL

2012-03-15 Thread Chris Mattmann
, visit: https://reviews.apache.org/r/4358/#review5978 --- On 2012-03-14 23:40:55, Chris Mattmann wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request: Port CAS-PGE's PcsMetadataKeys to PgeTaskMetKeys

2012-03-15 Thread Chris Mattmann
://reviews.apache.org/r/4359/ --- (Updated 2012-03-15 08:25:38) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- Will allow for specification of new keys while still supported legacy

Re: Review Request: OODT-413: filemgr query throws NPE when some products have undefined metadata values

2012-03-15 Thread Chris Mattmann
2012-03-16 01:51:02) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Thomas Bennett. Summary --- filemgr query throws NPE when some products have undefined metadata values This addresses bug OODT-413. https://issues.apache.org/jira/browse/OODT

Re: Review Request: OODT-413: filemgr query throws NPE when some products have undefined metadata values

2012-03-15 Thread Chris Mattmann
for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Summary --- filemgr query throws NPE when some products have undefined metadata values This addresses bug OODT-413. https://issues.apache.org/jira/browse/OODT-413 Diffs - trunk

Re: Review Request: Add support to ExecUtils callProgram to take OutputStreams for forwarding stdout and stderr

2012-03-15 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4377/ --- (Updated 2012-03-16 03:00:01) Review request for oodt, Chris Mattmann

Re: Review Request: OODT-410: DataSourceCatalog compatible with HypersonicSQL

2012-03-15 Thread Chris Mattmann
On 2012-03-15 00:35:26, brian Foster wrote: Why can't DataSourceCatalog be extended and just modified per hypersonic needs?... what are the differences exactly between DataSource and Hyersonic versions of the Catalogs? Chris Mattmann wrote: Hey Brian, great question. The reality

Re: Review Request: OODT-410: DataSourceCatalog compatible with HypersonicSQL

2012-03-16 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4358/ --- (Updated 2012-03-16 14:14:17.061621) Review request for oodt, brian Foster,

Re: Review Request: OODT-410: DataSourceCatalog compatible with HypersonicSQL

2012-03-16 Thread Chris Mattmann
On 2012-03-15 00:35:26, brian Foster wrote: Why can't DataSourceCatalog be extended and just modified per hypersonic needs?... what are the differences exactly between DataSource and Hyersonic versions of the Catalogs? Chris Mattmann wrote: Hey Brian, great question. The reality

Re: Review Request: OODT-413: filemgr query throws NPE when some products have undefined metadata values

2012-03-16 Thread Chris Mattmann
request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Summary --- filemgr query throws NPE when some products have undefined metadata values This addresses bug OODT-413. https://issues.apache.org/jira/browse/OODT-413 Diffs

Re: Review Request: OODT-410: DataSourceCatalog compatible with HypersonicSQL

2012-03-16 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4358/ --- (Updated 2012-03-17 01:40:37.106062) Review request for oodt, brian Foster,

Re: Review Request: Improved CAS-PGE logging, product ingest fail CAS-PGE will fail, and PgeConfigBuilder configurable via PgeTaskMetKeys

2012-03-16 Thread Chris Mattmann
/ --- (Updated 2012-03-16 23:32:12) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- The 2 main issues here (and they are small changes) are: - CAS-PGE now fails when products fail to ingest * this was the changes

Re: Review Request: Improved CAS-PGE logging, product ingest fail CAS-PGE will fail, and PgeConfigBuilder configurable via PgeTaskMetKeys

2012-03-17 Thread Chris Mattmann
Foster wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4393/ --- (Updated 2012-03-17 20:19:38) Review request for oodt, Chris

Re: Review Request: Allow for CAS-PGE PgeMetadata to be dumped to an xml file after initialization

2012-03-19 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4397/#review6071 --- Ship it! LGTM!

Re: Review Request: Port LoggerOutputStream in CAS-PGE to existing LoggerOutputStream in oodt-commons io package (CAS-PGE changes)

2012-03-19 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4398/ --- (Updated 2012-03-18 21:25:45) Review request for oodt, Chris Mattmann

Re: Review Request: Port LoggerOutputStream in CAS-PGE to existing LoggerOutputStream in oodt-commons io package (OODT-Commons changes)

2012-03-19 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4399/ --- (Updated 2012-03-18 21:26:02) Review request for oodt, Chris Mattmann

Re: Review Request: OODT-424: clean build env doesn't work

2012-03-19 Thread Chris Mattmann
wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4406/ --- (Updated 2012-03-19 22:33:53) Review request for oodt, Chris

Re: Review Request: CAS-PGE logger unit-test fails because it sometimes finds logger lock file

2012-03-20 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4410/ --- (Updated 2012-03-20 01:41:27) Review request for oodt, Chris Mattmann

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Metadata changes)

2012-03-21 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4412/ --- (Updated 2012-03-20 08:06:42) Review request for oodt, Chris Mattmann, Ricky

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Metadata changes)

2012-03-21 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4412/ --- (Updated 2012-03-20 08:06:42) Review request for oodt, Chris Mattmann

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

2012-03-22 Thread Chris Mattmann
) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- - Introduced NamingConvention support, which for MetExtractorProductCrawler now takes an ID for the NamingConvention to use and AutoDetectProductCrawler has a new element

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

2012-03-22 Thread Chris Mattmann
2012-03-22 06:09:52) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- - Introduced NamingConvention support, which for MetExtractorProductCrawler now takes an ID for the NamingConvention to use and AutoDetectProductCrawler

Re: Review Request: filemgr query throws String index out of range: -1 when some products have undefined metadata values

2012-03-25 Thread Chris Mattmann
://reviews.apache.org/r/4451/ --- (Updated 2012-03-23 21:02:03) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Summary --- Cleaned up metadata to string methods of QueryResult

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

2012-03-26 Thread Chris Mattmann
, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- It currently was setting lists keys to: value1,value2,value3,... This patch will instead change it to: key[0] = value1 key[1] = value2 This addresses bug OODT-428. https://issues.apache.org/jira

Re: Review Request: Get product references before calling retrieveProduct(). Update unit tests testRetrieveFilesById() and testRetrieveFilesByName()

2012-03-30 Thread Chris Mattmann
wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4553/ --- (Updated 2012-03-30 08:45:40) Review request for oodt, Chris

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-04 Thread Chris Mattmann
, visit: https://reviews.apache.org/r/4628/ --- (Updated 2012-04-03 21:56:17) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- CAS-PGE Changes to this issue

Re: Review Request: Make CAS-Crawlers MimeExtractorConfigReader relative file paths be relative to its XML file

2012-04-06 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4665/ --- (Updated 2012-04-06 02:26:01) Review request for oodt, Chris Mattmann

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-06 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/ --- (Updated 2012-04-06 02:16:10) Review request for oodt, Chris Mattmann, Ricky

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-06 Thread Chris Mattmann
, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- CAS-PGE Changes to this issue... - Renaming and Metadata extraction removed from CAS-PGE and instead CAS-PGE now uses AutoDetectProductCrawler instead of StdProductCrawler This addresses bug OODT-426

Re: Review Request: String search and replace getMetadata(UUID with getMetadata(CAS.ProductId

2012-04-12 Thread Chris Mattmann
wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ --- (Updated 2012-04-12 13:33:57) Review request for oodt, Chris

Re: Review Request: Add file staging support to CAS-PGE

2012-04-16 Thread Chris Mattmann
/ --- (Updated 2012-04-16 22:27:39) Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- Will introduce a FileStaging abstract class with currently 1 implementation using the FileManager

Re: Review Request: Rollback capability for workflows

2012-04-19 Thread Chris Mattmann
/ --- (Updated 2012-04-18 17:15:08) Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- First draft of the 'least dramatic' option suggested by Chris to support OODT-212 feature. Not sure

Re: Review Request: Add file staging support to CAS-PGE

2012-04-30 Thread Chris Mattmann
, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- Will introduce a FileStaging abstract class with currently 1 implementation using the FileManager. There will also be a new Config object which allow for file paths or product ids which would you like

Re: Review Request: Wengine Task Querier Thread: OODT-310

2012-05-04 Thread Chris Mattmann
since it has a sub-processor in Queued/waiting Chris Mattmann wrote: Thoughts on how to fix? Sheryl John wrote: If 'anydoneStates'/done is passed, then don't add taskProcessor and return the 'done' processor? Good idea, Sheryl, I will try that. - Chris

Re: Review Request: Crawler command line bugs

2012-05-04 Thread Chris Mattmann
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4989/ --- (Updated 2012-05-03 12:03:13) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary --- 1

Re: Review Request: Crawler command line bugs

2012-05-04 Thread Chris Mattmann
wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4989/ --- (Updated 2012-05-03 12:03:13) Review request for oodt, Chris

Re: Review Request: Wengine Task Querier Thread: OODT-310

2012-05-26 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4961/ --- (Updated 2012-05-27 05:35:54.936237) Review request for oodt, brian Foster,

Re: Review Request: Wengine Task Querier Thread: OODT-310

2012-05-27 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4961/ --- (Updated 2012-05-27 21:58:01.392196) Review request for oodt, brian Foster,

Re: Review Request: Change SciPgeConfigFileWriter to DynamicConfigFileWriter

2012-06-24 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5428/#review8514 --- Ship it! Ship It! - Chris Mattmann On June 20, 2012, 1 a.m

Re: Review Request: Added file staging support to CAS-PGE's XmlFilePgeConfigBuilder

2012-06-24 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5382/#review8515 --- Ship it! Ship It! - Chris Mattmann On June 20, 2012, 12:38 a.m

Re: Review Request: RemoteSiteFile doesn't always set RemoteSite

2012-07-26 Thread Chris Mattmann
Preconditions code. LGTM after that. - Chris Mattmann On July 27, 2012, 12:15 a.m., brian Foster wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166

Re: Review Request: RemoteSiteFile doesn't always set RemoteSite

2012-07-26 Thread Chris Mattmann
/#comment20372 I don't see a Maven update here, do we need to add the google.common.base dep? trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java https://reviews.apache.org/r/6166/#comment20371 orthogonal again with finals, but OK :) - Chris Mattmann

Re: Review Request: CAS-Pushpull uniqueMetadataElement is being loaded as empty String instead of null

2012-08-01 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6301/#review9720 --- Ship it! LGTM - Chris Mattmann On Aug. 1, 2012, 9:15 p.m., brian

Re: Review Request: EngineRunnerFactory introduction and Java property cleanup

2012-08-03 Thread Chris Mattmann
/workflow/system/XmlRpcWorkflowManager.java https://reviews.apache.org/r/6357/#comment20879 we should change this to 9001 - Chris Mattmann On Aug. 3, 2012, 10:47 p.m., brian Foster wrote: --- This is an automatically generated e-mail

Re: Review Request: Factory out EngineRunner and WorkflowProcessor classes into their own packages

2012-08-07 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6407/#review9948 --- Ship it! Ship It! - Chris Mattmann On Aug. 6, 2012, 8:41 p.m

Re: Review Request: Factory out EngineRunner and WorkflowProcessor classes into their own packages

2012-08-07 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6407/#review9949 --- Ship it! LGTM! - Chris Mattmann On Aug. 6, 2012, 8:41 p.m., brian

Re: Review Request: NumberFormatException when using RSS service to view transfers for large files

2012-08-07 Thread Chris Mattmann
/XmlRpcStructFactory.java https://reviews.apache.org/r/6409/#comment21145 +1, I'm for option #1. - Chris Mattmann On Aug. 7, 2012, 12:38 a.m., Ross Laidlaw wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request: NumberFormatException when using RSS service to view transfers for large files

2012-08-07 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6409/#review9946 --- Ship it! Ship It! - Chris Mattmann On Aug. 7, 2012, 12:38 a.m

Re: Review Request: Synchronous and Asynchronous LocalEngineRunnerFactory

2012-08-07 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6416/#review9962 --- Ship it! LGTM. - Chris Mattmann On Aug. 7, 2012, 3:36 a.m

Re: Review Request: Set page size when query is done. Remove sort when trying to just get total number hits.

2012-08-29 Thread Chris Mattmann
, 2012, 4:26 p.m.) Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Andrew Hart, Sheryl John, and Thomas Bennett. Description --- Refactoring so that paged queries will not be submitted twice. This addresses bug OODT-489. https://issues.apache.org

Review Request: OODT-516: Add WorkflowLifecycle tests that check pctComplete for wengine and w1 style lifecycles

2012-10-04 Thread Chris Mattmann
- ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/lifecycle/TestWorkflowLifecycleManager.java 1390815 Diff: https://reviews.apache.org/r/7438/diff/ Testing --- The attached tests are failing in trunk. Thanks, Chris Mattmann

Re: Review Request: OODT-516: Add WorkflowLifecycle tests that check pctComplete for wengine and w1 style lifecycles

2012-10-06 Thread Chris Mattmann
/workflow/lifecycle/WorkflowLifecycleManager.java 1391158 ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/lifecycle/TestWorkflowLifecycleManager.java 1390815 Diff: https://reviews.apache.org/r/7438/diff/ Testing --- The attached tests are failing in trunk. Thanks, Chris

Review Request: Support for product_id of type string in FM DataSourceCatalog

2012-12-15 Thread Chris Mattmann
/apache/oodt/cas/filemgr/util/DbStructFactory.java 1422312 Diff: https://reviews.apache.org/r/8616/diff/ Testing --- We have tested this on my transient detection project for V-FASTR. Thanks, Chris Mattmann

Re: Review Request: Ordering of products if DataSourceCatalog if product_id is of type string.

2012-12-17 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8648/#review14607 --- Ship it! Ship It! - Chris Mattmann On Dec. 17, 2012, 7:11 p.m

Review Request: DataSourceCatalog implementation does not preserve order of metadata values

2013-01-16 Thread Chris Mattmann
/8989/diff/ Testing --- Per https://builds.apache.org/job/oodt-trunk/org.apache.oodt$cas-filemgr/801/changes this broke File Manager tests, so I'm reverting for now while we can discuss here. Thanks, Chris Mattmann

Re: Review Request: Suggested Fix for JIRA Issue OODT-553

2013-01-29 Thread Chris Mattmann
/EnvUtilities.java https://reviews.apache.org/r/9142/#comment34072 Hey Mike, here we are no longer calling preProcessInputStream -- doesn't that do envVarReplace? - Chris Mattmann On Jan. 29, 2013, 9:25 p.m., Michael Starch wrote

Re: Review Request: Suggested Fix for JIRA Issue OODT-553

2013-02-02 Thread Chris Mattmann
On Jan. 30, 2013, 2:09 a.m., Chris Mattmann wrote: Michael Starch wrote: The line line = line.replaceAll(, ); is used to allow the call Properties.load(InputStream). The reason for this is the load command expects '\' to escape something, and will drop invalid escapes

Re: Review Request: Suggested Fix for JIRA Issue OODT-553

2013-02-02 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9142/#review16042 --- Ship it! Ship It! - Chris Mattmann On Jan. 29, 2013, 9:25 p.m

Review Request: XMLPS should provided ordered results based on requested fields

2013-02-13 Thread Chris Mattmann
/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1444629 ./trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1444629 Diff: https://reviews.apache.org/r/9438/diff/ Testing --- none yet. Thanks, Chris Mattmann

Re: Review Request: XMLPS should provided ordered results based on requested fields

2013-02-14 Thread Chris Mattmann
://reviews.apache.org/r/9438/diff/ Testing --- none yet. Thanks, Chris Mattmann

Re: Review Request: XMLPS should provided ordered results based on requested fields

2013-02-14 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9438/#review16586 --- Ship it! Ship It! - Chris Mattmann On Feb. 14, 2013, 3:50 p.m

Re: Review Request: Suggested refactoring for return statement in getTopNProducts method in LuceneCatalog class

2013-03-18 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9844/#review17785 --- Ship it! Ship It! - Chris Mattmann On March 11, 2013, 2:47 a.m

Re: Review Request: New test class for RSSConfigReader

2013-03-24 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10097/#review18318 --- Ship it! Ship It! - Chris Mattmann On March 23, 2013, 2:56 p.m

Re: Review Request: OODT-597: Improve theme/styling of OPSUI

2013-04-19 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10535/#review19440 --- Ship it! Ship It! - Chris Mattmann On April 19, 2013, 12:30 a.m

Re: Review Request: Native Solr implementation of CAS File Manager

2013-04-21 Thread Chris Mattmann
/QUICK_START_GUIDE.TXT https://reviews.apache.org/r/10288/#comment40259 I see why it's in etc, +1 then - Chris Mattmann On April 4, 2013, 8:03 p.m., Luca Cinquini wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request: Native Solr implementation of CAS File Manager

2013-04-21 Thread Chris Mattmann
On April 21, 2013, 5:54 a.m., Chris Mattmann wrote: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/assembly/assembly.xml, line 65 https://reviews.apache.org/r/10288/diff/1/?file=277932#file277932line65 do we really need solr schema as a resource? This would suggest

Re: Review Request: Apache Airvata extension to integrate Apache OODT File manager using CAS-PGE

2013-06-04 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11565/ --- (Updated June 5, 2013, 2:35 a.m.) Review request for oodt, Chris Mattmann

Re: Review Request: OODT-627 Review

2013-06-13 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11810/ --- (Updated June 13, 2013, 5:45 a.m.) Review request for oodt, Chris Mattmann

Re: Review Request: OODT-627 Review

2013-06-13 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11810/#review21841 --- Ship it! Ship It! - Chris Mattmann On June 11, 2013, 8:38 p.m

Re: [Ganglia plugin] Next steps

2013-06-28 Thread Chris Mattmann
, Rajith Chris Mattmann chris.mattm...@gmail.com On Fri, Jun 21, 2013 at 7:22 PM, Rajith Siriwardana rajithsiriward...@gmail.com wrote: moving the conversation to dev. Cheers, Rajith On Thu, Jun 20, 2013 at 11:10 AM, Chris Mattmann chris.mattm...@gmail.com wrote

Re: Review Request 12308: OODT-619 [sub task of OODT-219] Implement the capability to pull status of resource nodes from ganglia and provide loadvalues to AssignmentMonitor

2013-07-08 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12308/#review22815 --- Ship it! Ship It! - Chris Mattmann On July 7, 2013, 8:44 p.m

Re: Review Request 12308: OODT-619 [sub task of OODT-219] Implement the capability to pull status of resource nodes from ganglia and provide loadvalues to AssignmentMonitor

2013-07-08 Thread Chris Mattmann
/GenericResourceManagerObjectFactory.java https://reviews.apache.org/r/12308/#comment46530 Weird formatting changes? - Chris Mattmann On July 7, 2013, 8:44 p.m., Rajith Siriwardana wrote: --- This is an automatically generated e-mail

[RESULT] [VOTE] Apache OODT 0.6 Release Candidate #1

2013-07-17 Thread Chris Mattmann
Hi Folks, OK, this VOTE below has passed with the following tallies: +1 Chris Mattmann Sean Kelly Andrew Hart Lewis John McGibbney I'll go ahead and push the release to the mirrors, and update the website and send the ANNOUNCE. Thanks for VOTE'ing! Cheers, Chris -Original Message

[ANNOUNCE] Apache OODT 0.6 release

2013-07-17 Thread Chris Mattmann
/confluence/display/OODT/Home Thanks! Chris Mattmann (on behalf of the Apache OODT PMC)

Re: Review Request 13000: OODT-651: Improve parameter initialization, validation and logging for the CAS-Product JAXRS service

2013-08-21 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13000/#review25396 --- Ship it! Ship It! - Chris Mattmann On Aug. 14, 2013, 5:32 p.m

Re: Povenance Aware Workflow Processing

2013-08-23 Thread Chris Mattmann
Hey Sanjaya, You may want to check out the Traceable Product product type policy [1] as well as OODT-139 [2] which includes the PCS services that serve up the information and provenance. Cheers, Chris [1] http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examp les/trace/

Re: SolrCatalog should be in package o.a.oodt.cas.filemgr.catalog

2013-09-02 Thread Chris Mattmann
++ Chris Mattmann, Ph.D. Senior Computer Scientist NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 171-266B, Mailstop: 171-246 Email: chris.a.mattm...@nasa.gov WWW: http://sunset.usc.edu/~mattmann

Re: Review Request 14626: OODT 562 - Exposing parent-child element addition/deletion functionality for product types using cas-curator

2013-10-14 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14626/#review26979 --- Ship it! Ship It! - Chris Mattmann On Oct. 13, 2013, 10:45 p.m

Re: Question regarding OODT patch 563 (Workflow API additions)

2013-10-14 Thread Chris Mattmann
, The point about the PackagedWorkflowRepository is that it adds dynamic tasks to the workflow repo -- thoughts? Cheers, Chris ++ Chris Mattmann, Ph.D. Senior Computer Scientist NASA Jet Propulsion Laboratory Pasadena, CA 91109

Re: Question regarding OODT patch 563 (Workflow API additions)

2013-10-15 Thread Chris Mattmann
: Tuesday, October 15, 2013 2:24 AM To: Chris Mattmann chris.a.mattm...@nasa.gov Cc: dev@oodt.apache.org Subject: Re: Question regarding OODT patch 563 (Workflow API additions) Thanks Chris ! I'll get to work on creating the webapp/wm-services JAX-RS module. Question: Is it possible to run

Re: Review Request 14513: OODT-612 OODT-613 - Content writers and configurations for the CAS Product Server Web Application (JAX-RS part)

2013-10-15 Thread Chris Mattmann
/#comment52682 may want to upgrade this to 1.4 but not a blocker - Chris Mattmann On Oct. 6, 2013, 10:37 a.m., Ross Laidlaw wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14513

Re: Review Request 14513: OODT-612 OODT-613 - Content writers and configurations for the CAS Product Server Web Application (JAX-RS part)

2013-10-15 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14513/#review27056 --- Ship it! Ship It! - Chris Mattmann On Oct. 6, 2013, 10:37 a.m

Re: How to process files in a sorted order

2013-11-19 Thread Chris Mattmann
// override crawl methods @Override public void crawl(){ // use your filter} @Override public void crawl(File dirRoot) {//use your filter} } Hope that helps! Cheers, Chris Chris Mattmann chris.mattm...@gmail.com -Original Message- From: Konstantinos

  1   2   3   4   5   >