Re: [edk2] [PATCH] IntelFsp2Pkg: Add PACKAGES_PATH support

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Thomaiyar, Richard Marian > Sent: Friday, November 25, 2016 1:21 AM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice <maurice...@intel.com>; Yao, Jiewen > <jiewen

Re: [edk2] [PATCH v3] MdePkg IndustryStandard: Add DDR3, DDR4 and LPDDR definition per SPD spec

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Tuesday, November 22, 2016 11:03 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com> > Subject: [PATCH v3] MdePkg In

Re: [edk2] [PATCH 2/2] IntelFsp2Pkg: Use FspSiliconInitDone2 API for the Notify Phase Use FspSiliconInitDone2 API (with error status handling) for the Notify Phase

Correcting the edk2 mailing list. > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, November 17, 2016 11:33 AM > To: Thomaiyar, Richard Marian <richard.marian.thomai...@intel.com>; ed2- > de...@lists.01.org > Cc: Ma, Maurice <maurice...@intel.

Re: [edk2] [PATCH] IntelFsp2Pkg: Use FspSiliconInitDone2 API

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Thomaiyar, Richard Marian > Sent: Wednesday, November 16, 2016 1:47 AM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice <maurice...@intel.com>; Yao, Jiewen > <jiewen

Re: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def

Thank you for fixing it. Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, November 17, 2016 2:37 AM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Mud

Re: [edk2] [Patch] MdePkg IndustryStandard: Add DDR3, DDR4 and LPDDR definition per SPD spec

ateLe1866 to DramOdtRttParkForDataRateLe1866 Thanks, -Giri -Original Message- From: Gao, Liming Sent: Friday, November 11, 2016 1:11 AM To: edk2-devel@lists.01.org Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com> Subject: [Patch] MdePkg IndustryStandard: Add DDR3, DDR4 and LPDDR definition per

Re: [edk2] [PATCH] IntelFsp2Pkg: Support to return error status from FSP API done

Thanks Richard. Can you please add comments in the code to describe it? Other than that it looks good to me. Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Mudusuru

Re: [edk2] [PATCH] IntelFsp2Pkg: Support to return error status from FSP API done

during previous API and cannot proceed further\n", Status)); > +} > + } while (Status != EFI_SUCCESS); Thanks, -Giri > -Original Message- > From: Thomaiyar, Richard Marian > Sent: Tuesday, November 8, 2016 1:45 AM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice <

Re: [edk2] [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID

5:48 PM To: Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [edk2] [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID HI Giri I believe we also need .h file to l

Re: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Add a PCD to control if signaling PciEnumerationComplete.

iewen > Sent: Monday, October 24, 2016 4:18 PM > To: Dong, Guo <guo.d...@intel.com>; edk2-devel@lists.01.org > Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Ma, Maurice > <maurice...@intel.com> > Subject: RE: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Add a PCD to

Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

A combination of Jordon's and Andrews proposal would be better so we have one flag and also scalable. Level of deprecated interfaces can be controlled by each platform. EDK2 master platforms should not define this flag to eliminate the usage of deprecated interfaces while UDK2015 can define and

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling first event.

Agree with Jiewen's solution. Default should be 0 in IntelFsp2WrapperPkg and CorebootPayloadPkg can set BIT16 to skip the API. Thanks, -Giri From: Yao, Jiewen Sent: Friday, October 21, 2016 10:15 PM To: Dong, Guo <guo.d...@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>

Re: [edk2] [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB and VBT data

> -Original Message- > From: Yao, Jiewen > Sent: Friday, October 21, 2016 4:43 PM > To: Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Zeng, Star > <star.z...@intel.com>; Yao, Jie

Re: [edk2] [PATCH] IntelFsp2Pkg: Added changes to enable FPDT performance measurements

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Yarlagadda, Satya P > Sent: Thursday, October 20, 2016 10:49 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice <maurice...@intel.com>; Yao, Jiewen > <jiewen

Re: [edk2] [PATCH] IntelFsp2Pkg: Removing FSP Data Table

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Yarlagadda, Satya P > Sent: Thursday, October 20, 2016 5:46 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice <maurice...@intel.com>; Yao, Jiewen > <jiewen

Re: [edk2] [PATCH 14/33] IntelFsp2Pkg: Fix typos in comments

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, October 19, 2016 12:01 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Mudusuru, Giri P &

Re: [edk2] [PATCH 15/33] IntelFsp2WrapperPkg: Fix a typo in the comment

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, October 19, 2016 12:01 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Mudusuru, Giri P &

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling first event.

2016 3:53 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Mudusuru, Giri P > <giri.p.mudus...@intel.com>; Dong, Guo <guo.d...@intel.com> > Subject: [edk2] [PATCH] IntelFsp2WrapperPkg: Add a PCD to control if signaling > first event. >

Re: [edk2] [PATCH] IntelSiliconPkg: Add Intel Firmware Version Info (FVI) definitions

Yes Star thanks for catching the merge issue. Will fix it before check-in. Thanks, -Giri > -Original Message- > From: Zeng, Star > Sent: Thursday, October 13, 2016 9:25 PM > To: Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Mic

Re: [edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons position independent

> Cc: Ma, Maurice <maurice...@intel.com>; Yao, Jiewen > <jiewen@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com> > Subject: [edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons position > independent > > The current AsmGetFspInfoHeader functio

Re: [edk2] [patch 2/3] MdeModulePkg:TcpDriver need to use EFI_D_NET for DEBUG maessage.

Please use DEBUG_NET instead of EFI_D_NET. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang > Lubo > Sent: Thursday, September 22, 2016 10:42 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan

Re: [edk2] [PATCH] Maintainers.txt: Add Giri as 2nd maintainer

Agee with Jiewen to keep the doc and tool consistent. Also the patch prefix "[edk2][PATCH]" should be excluded as it is not part of the commit message title. Thanks, -Giri > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, > Jiewen >

Re: [edk2] [PATCH] Maintainers.txt: Add Giri as 2nd maintainer

Thanks Jiewen. Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, September 6, 2016 6:21 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Chan, Amy >

Re: [edk2] [Patch 20/20] UefiCpuPkg/XeonPhiMsr.h: add MSR reference from SDM in comment

Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com> > Subject: [Patch 20/20] UefiCpuPkg/XeonPhiMsr.h: add MSR reference from SDM > in comment > > Cc: Michael Kinney <michael.d.kin...@inte

Re: [edk2] [Patch 4/4] BaseTools VfrCompile Pccts: Update GCC Flags to the specific one with BUILD_ prefix

Reviewed the series of 4 patches Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Monday, September 5, 2016 9:00 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>

Re: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop

Thanks Mike, sent updated patch v2 removing the push, pop change. Thanks, -Giri > -Original Message- > From: Kinney, Michael D > Sent: Monday, August 29, 2016 11:45 AM > To: Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org; > Kinney, Mic

Re: [edk2] [Patch] BaseTools GNU Makefile: Add the missing rules for cpp source file

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Sunday, August 21, 2016 11:29 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Zhu, Yonghong > <yonghong

Re: [edk2] [Patch] BaseTools GnuMakefile: Update GCC Flags to the specific one with BUILD_ prefix

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Sunday, August 21, 2016 11:32 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Zhu, Yonghong > <yonghong

Re: [edk2] [PATCH] Update ReadMe.MD file.

Hi Mang, Please fix non ASCII characters "Run the Intel� FSP installer " to "Run the Intel(R) FSP installer" Reviewed-by: Giri P Mudusuru Thanks, -Giri > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Guo, >

Re: [edk2] [PATCH] IntelFsp2Pkg: Only include required header files in FspEas.h

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Ma, Maurice > Sent: Thursday, August 4, 2016 9:20 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice <maurice...@intel.com>; Yao, Jiewen > <jiewen@intel.com

Re: [edk2] [Patch v5 02/48] UefiCpuPkg/MpInitLib: Add microcode definitions defined in IA32 SDM

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Tuesday, August 2, 2016 1:59 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com

Re: [edk2] [PATCH] IntelFsp2Pkg: Locate FSP Info Header dynamically

tya P > Sent: Monday, August 1, 2016 4:42 AM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice <maurice...@intel.com>; Yao, Jiewen > <jiewen@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com> > Subject: [PATCH] IntelFsp2Pkg: Locate FSP Info Header dynamical

Re: [edk2] [PATCH] MdePkg: Add DmaRemappingReportingTable.h

organization in future. For now we can close this thread to include in MdePkg. Any objections? Thanks, -Giri > -Original Message- > From: Rothman, Michael A > Sent: Thursday, July 28, 2016 11:53 AM > To: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Tim Lewis > <tim.l

Re: [edk2] [PATCH] MdePkg: Add DmaRemappingReportingTable.h

> Sent: Thursday, July 28, 2016 9:55 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; Laszlo Ersek > <ler...@redhat.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2- > de...@lists.01.org <edk2-de...@ml01.01.org> > Cc: Yao, Jiewen <jiewen..

Re: [edk2] [PATCH] MdePkg: Add DmaRemappingReportingTable.h

Sure Jiewen. Will add these two defines and send v2 patch. Thanks, -Giri > -Original Message- > From: Yao, Jiewen > Sent: Thursday, July 28, 2016 12:28 AM > To: Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.

Re: [edk2] [PATCH 3/3] MdeModulePkg SmbiosDxe: Use definition in IndustryStandard/Smbios.h

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Wednesday, July 27, 2016 8:04 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Chan, Amy

Re: [edk2] [PATCH 1/3] IntelFrameworkModulePkg BdsDxe: Use definition in IndustryStandard/Smbios.h

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Wednesday, July 27, 2016 8:04 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Chan, Amy

Re: [edk2] [PATCH 2/3] MdeModulePkg UiApp: Use definition in IndustryStandard/Smbios.h

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, > Ruiyu > Sent: Wednesday, July 27, 2016 10:11 PM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Tian, Feng

Re: [edk2] [PATCH] IntelSiliconPkg: Add DmaRemappingTable.h

Thanks Jiewen for the feedback. Will send patch v2 including the feedback. Thanks, -Giri > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, July 26, 2016 3:42 PM > To: Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Mic

Re: [edk2] [patch] MdeModulePkg: add generic SataController driver.

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Chan, Amy > Sent: Monday, July 25, 2016 8:14 PM > To: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Mudusuru, Giri P <giri.p.

Re: [edk2] [PATCH] IntelFsp2Pkg: Skip loading Microcode if MicrocodeCodeSize is zero

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Yarlagadda, Satya P > Sent: Monday, July 25, 2016 6:14 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Yao, Jiewen > <jiewen

Re: [edk2] [Patch v2 16/40] UefiCpuPkg/MpInitLib: Register one period event to check APs status

Sent: Thursday, July 21, 2016 8:14 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>; Laszlo > Ersek <ler...@redhat.com> > Subject: [Patch v2

Re: [edk2] [PATCH 4/4] IntelFspWrapperPkg: Add missing License.txt.

Reviewed the Series. The copyright year should be updated. Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Yao, Jiewen > Sent: Friday, July 22, 2016 6:27 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P <giri.p.mudus

Re: [edk2] [Patch v2 07/40] UefiCpuPkg/MpInitLib: Add AsmRellocateApLoop() assembly code

m>; Tian, Feng > <feng.t...@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>; Laszlo > Ersek <ler...@redhat.com> > Subject: [Patch v2 07/40] UefiCpuPkg/MpInitLib: Add AsmRellocateApLoop() > assembly code > > AsmRellocateApLoop() is used to place APs int

Re: [edk2] [Patch v2 06/40] UefiCpuPkg/MpInitLib: Add AP assembly code and MP_CPU_EXCHANGE_INFO

ly 21, 2016 8:14 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>; Laszlo > Ersek <ler...@redhat.com> > Subject: [Patch v2 06/40] UefiCpuPkg/

Re: [edk2] [Patch v2 05/40] UefiCpuPkg/MpInitLib: Add two instances PeiMpInitLib and DxeMpInitLib

gt; To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>; Laszlo > Ersek <ler...@redhat.com> > Subject: [Patch v2 05/40] UefiCpuPkg/MpInitLib: Add two ins

Re: [edk2] [Patch v2 04/40] UefiCpuPkg/MpInitLib: Add MP Initialize library class definition

m: Fan, Jeff > Sent: Thursday, July 21, 2016 8:14 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>; Laszlo > Ersek <ler...@redhat.com> >

Re: [edk2] [Patch v2 03/40] UefiCpuPkg/CpuS3DataDxe: Move StartupVector allocation to EndOfDxe()

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Thursday, July 21, 2016 8:14 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com

Re: [edk2] [Patch v2 02/40] UefiCpuPkg/MpInitLib: Add microcode definitions defined in IA32 SDM

with SDM Thanks, -Giri > -Original Message- > From: Fan, Jeff > Sent: Thursday, July 21, 2016 8:14 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com>; Mudusuru, Giri P <giri.p.mudus..

Re: [edk2] [Patch v2 01/40] UefiCpuPkg/LocalApic.h: Remove duplicated/conflicted definitions

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Thursday, July 21, 2016 8:14 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com

Re: [edk2] [PATCH v2 3/5] BaseTools/tools_def: enable Os optimization for GCC X64 builds

Here is the summary of discussion I understand from this thread -RELEASE - Debug logs are OFF, Optimization ON, Symbolic debug OFF -DEBUG - Debug logs are ON, Optimization ON, Symbolic debug ON -NOOPT - Debug logs are ON, Optimization OFF, Symbolic debug ON Use case for enabling symbolic debug

Re: [edk2] [Patch 2/3] IntelFsp2WrapperPkg: Add missing modules in Package DSC

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Thursday, July 14, 2016 10:05 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Mudusuru, Giri P > <giri.p.mudus...

Re: [edk2] [Patch 3/3] IntelFsp2Pkg: Add missing modules in Package DSC

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Thursday, July 14, 2016 10:05 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Mudusuru, Giri P > <giri.p.mudus...

Re: [edk2] [Patch 1/3] IntelFsp2WrapperPkg SecFspWrapperPlatformSecLibSample:Update code to pass build

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Thursday, July 14, 2016 10:05 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Mudusuru, Giri P > <giri.p.mudus...

Re: [edk2] [Patch] IntelFsp2WrapperPkg: Remove unused header files from Fspm and Fsps WrapperPeim

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Wednesday, July 13, 2016 7:16 PM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Yao, Jiewen > <jiewen

Re: [edk2] [Patch v3 7/7] UefiCpuPkg/CpuMpPei: Remove PmodeOffset and LmodeOffset

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:45 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com&g

Re: [edk2] [Patch v3 6/7] UefiCpuPkg/CpuMpPei: Remove un-used variables and functions

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:45 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com&g

Re: [edk2] [Patch v3 5/7] UefiCpuPkg/CpuMpPei: Do not load new GDT table

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:44 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com&g

Re: [edk2] [Patch v3 4/7] UefiCpuPkg/CpuMpPei/X64: Use CodeSegment and DataSegment fields

g <feng.t...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Mudusuru, Giri P > <giri.p.mudus...@intel.com> > Subject: [Patch v3 4/7] UefiCpuPkg/CpuMpPei/X64: Use CodeSegment and > DataSegment fields > > Using CodeSegment and DataSegment fields in Exch

Re: [edk2] [Patch v3 3/7] UefiCpuPkg/CpuMpPei/X64: Remove hard code CPU BIST value

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:44 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com&g

Re: [edk2] [Patch v3 2/7] UefiCpuPkg/CpuMpPei/Ia32: Use CodeSegment and DataSegment fields

c: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Mudusuru, Giri P > <giri.p.mudus...@intel.com> > Subject: [Patch v3 2/7] UefiCpuPkg/CpuMpPei/Ia32: Use CodeSegment and > DataSegment fields > > Using CodeSegment and DataSegment

Re: [edk2] [Patch v3 1/7] UefiCpuPkg/CpuMpPei: Add CodeSegment and DataSegment fields

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Tuesday, July 12, 2016 4:44 AM > To: edk2-de...@ml01.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com&g

Re: [edk2] [PATCH] IntelFsp2Pkg-BaseFspPlatformLib: Remove Boot Loader tempram Migration

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> Fix typo during submitting patch in description: fucntion to function. > -Original Message- > From: Yarlagadda, Satya P > Sent: Wednesday, July 13, 2016 6:03 AM > To: edk2-devel@lists.01.org > Cc: Mudusuru,

Re: [edk2] [Patch 2/5] IntelFsp2WrapperPkg SecFspWrapperPlatformSecLibSample: Remove MASM/GAS files

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Friday, July 8, 2016 7:49 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Mudusuru, Giri P > <giri.p.mudus...

Re: [edk2] [Patch 1/5] IntelFsp2WrapperPkg BaseFspWrapperApiLib: Remove MASM/GAS files

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Friday, July 8, 2016 7:49 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Mudusuru, Giri P > <giri.p.mudus...

Re: [edk2] [Patch 3/5] IntelFsp2Pkg BaseFspDebugLibSerialPort: Remove MASM/GAS files

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Friday, July 8, 2016 7:49 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Mudusuru, Giri P > <giri.p.mudus...

Re: [edk2] [Patch 4/5] IntelFsp2Pkg BaseFspSwitchStackLib: Remove MASM/GAS files

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Friday, July 8, 2016 7:49 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Mudusuru, Giri P > <giri.p.mudus...

Re: [edk2] [Patch 5/5] IntelFsp2Pkg SecFspSecPlatformLibNull: Remove MASM/GAS files

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Gao, Liming > Sent: Friday, July 8, 2016 7:49 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Mudusuru, Giri P > <giri.p.mudus...

Re: [edk2] Intel FSP Firmware Volume content

Hi Marvin, Rafael, Thank you for your studies on FSP. FSP is a self-contained binary. Since the silicon code implementation is based on edk2, some modules are redundant like PeiCore, DxeIpl as Rafael explained below (Thanks Rafael). While it is redundant, it is a small price to make FSP

Re: [edk2] [PATCH 07/16] SecurityPkg: Series of patches to fix typos - availabe to available

Sure, will send updated V2 patch with copyrights updated Thanks, -Giri > -Original Message- > From: Zhang, Chao B > Sent: Thursday, July 7, 2016 1:34 AM > To: Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 07/16

Re: [edk2] [PATCH 14/16] OvmfPkg: Series of patches to fix typos - accessibla to accessible - exeuction to execution - iff to if

Thanks Laszlo for your comments. Will send updated patch addressing your comments. Thanks, -Giri > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, July 7, 2016 2:00 AM > To: Mudusuru, Giri P <giri.p.mudus...@intel.com> > Cc: e

Re: [edk2] [PATCH 06/16] StdLib: Series of patches to fix typos - availabe to available

ar...@intel.com>; Mudusuru, Giri P > <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 06/16] StdLib: Series of patches to fix typos - > availabe to available > > Someone should also check the UEFI file where these return values are defined > a

Re: [edk2] [Patch 3/3] UefiCpuPkg/CpuMpPei: Remove unnecessary variable

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Friday, July 1, 2016 12:02 AM > To: edk2-de...@ml01.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com

Re: [edk2] [Patch 2/3] UefiCpuPkg/CpuMpPei: Dump message if microcode signature not matched

.@intel.com>; Tian, Feng > <feng.t...@intel.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com> > Subject: [Patch 2/3] UefiCpuPkg/CpuMpPei: Dump message if microcode > signature not matched > > Verification microcode signature is one enhancement and not one > requi

Re: [edk2] [Patch 1/3] UefiCpuPkg/CpuMpPei: Skip microcode check/load if it has been loaded

Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Fan, Jeff > Sent: Friday, July 1, 2016 12:02 AM > To: edk2-de...@ml01.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Tian, Feng > <feng.t...@intel.com

Re: [edk2] [PATCH 1/6] EdkCompatibilityPkg: fix ASSERT_EFI_ERROR() typos

Thanks Laszlo for notifying. Sorry, it was by accident and didn't mean to send multiple R-b's :) Thanks, -Giri > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, June 30, 2016 3:23 AM > To: Mudusuru, Giri P <giri.p.mudus...@intel

Re: [edk2] [PATCH 2/6] NetworkPkg: fix ASSERT_EFI_ERROR() typos

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Wu, Jiaxin > Sent: Wednesday, June 29, 2016 2:35 AM > To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org> > Cc: Fu,

Re: [edk2] [PATCH 5/6] UefiCpuPkg: fix ASSERT_EFI_ERROR() typos

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Kinney, Michael D > Sent: Wednesday, June 29, 2016 2:26 PM > To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org>;

Re: [edk2] [PATCH 3/6] QuarkPlatformPkg: fix ASSERT_EFI_ERROR() typos

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Kinney, Michael D > Sent: Wednesday, June 29, 2016 2:27 PM > To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org>;

Re: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Add error handling for possible NULL ptr dereference

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Hao Wu > Sent: Wednesday, June 29, 2016 6:57 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add NULL pointer check by using ASSERT()

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Hao Wu > Sent: Wednesday, June 29, 2016 6:22 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen

Re: [edk2] [Patch] IntelFrameworkModulePkg StatusCode RuntimeDxe: Remove duplicated structure.

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Fan, Jeff > Sent: Wednesday, June 29, 2016 8:21 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Subject: Re:

Re: [edk2] [PATCH 1/6] EdkCompatibilityPkg: fix ASSERT_EFI_ERROR() typos

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gao, Liming > Sent: Tuesday, June 28, 2016 11:37 PM > To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org> >

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: Replace BASE_4GB with MAX_ADDRESS check.

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiewen Yao > Sent: Tuesday, June 28, 2016 7:30 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ;

Re: [edk2] [PATCH] MdeModulePkg VariableInfo: Fix GCC build failure

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Wednesday, June 29, 2016 7:24 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject:

Re: [edk2] [PATCH 5/6] UefiCpuPkg: fix ASSERT_EFI_ERROR() typos

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan, > Jeff > Sent: Tuesday, June 28, 2016 7:02 PM > To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org> > Subject:

Re: [edk2] [PATCH 3/6] QuarkPlatformPkg: fix ASSERT_EFI_ERROR() typos

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, June 28, 2016 6:26 AM > To: edk2-devel-01 > Cc: Kinney, Michael D

Re: [edk2] [PATCH 6/6] Vlv2TbltDevicePkg: fix ASSERT_EFI_ERROR() typos

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, June 28, 2016 6:26 AM > To: edk2-devel-01 > Cc: He, Tim ; Wei,

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, June 28, 2016 6:26 AM > To: edk2-devel-01 > Cc: Carsey, Jaben

Re: [edk2] [PATCH 1/6] EdkCompatibilityPkg: fix ASSERT_EFI_ERROR() typos

Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, June 28, 2016 6:26 AM > To: edk2-devel-01 > Cc: Gao, Liming

Re: [edk2] [Patch 2/2] PcAtChipsetPkg: Update ResetSystemLib with PCDs

Thanks for clarification Liming. Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com<mailto:giri.p.mudus...@intel.com>> From: Gao, Liming Sent: Thursday, June 23, 2016 9:11 PM To: Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org Subject: RE:

Re: [edk2] [PATCH] IntelFsp2Pkg-BaseFspCommonLib: Add funtion to return the reset required status

Looks good to me. Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Yao, Jiewen > Sent: Thursday, June 23, 2016 8:21 PM > To: Yarlagadda, Satya P <satya.p.yarlaga...@intel.com>; edk2- > de...@lists.01.org > Cc:

Re: [edk2] [Patch 2/2] PcAtChipsetPkg: Update ResetSystemLib with PCDs

Looks good to me. Can you also use the PCD control for Warm and add new PCD for warm reset value in separate patch? Reviewed-by: Giri P Mudusuru Thanks, -Giri > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >

Re: [edk2] [Patch 1/2] SecurityPkg: Add PcdUserPhysicalPresence to indicate use physical presence.

Looks good to me. Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, June 23, 2016 2:50 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 1/2]

Re: [edk2] [Patch 1/2] PcAtChipsetPkg: Add two PCDs for Reset Control Register and Value

Looks good to me. Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, June 23, 2016 2:54 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 1/2]

Re: [edk2] [Patch 2/2] SecurityPkg: Update PlatformSecureLibNull with PCD to get physical presence.

Looks good to me. Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, June 23, 2016 2:53 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 2/2]

Re: [edk2] [Patch] Vlv2TbltDevicePkg:Use PiSmmCpu of UefiCpuPkg replace IA32FamilyCpuPkg.

Looks good to me. Thanks for eliminating the binaries and using the UefiCpuPkg. One feedback is to remove the commented lines like comment is to remove DigitalThermalSensor Reviewed-by: Giri P Mudusuru Thanks, -Giri > -Original Message- > From: edk2-devel

Re: [edk2] [RFC V2] Proposal to organize packages into directories

Thanks Mike. My preference is Silicon as it is generic and represents broadly CPU/Memory/Chipset/SoC etc... Thanks, -Giri > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Kinney, Michael D > Sent: Friday, June 17, 2016 10:50 AM > To:

Re: [edk2] [PATCH] IntelFsp2Pkg: rename GetFspVpdDataPointer() to GetFspCfgRegionDataPointer()

Thanks for aligning to the FSP spec. Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> > -Original Message- > From: Chan, Amy > Sent: Friday, June 17, 2016 2:40 AM > To: Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org > Cc: Mudusuru, Giri P

Re: [edk2] [PATCH] IntelFsp2WrapperPkg: Add support to handle ResetRequired return Status from FSP.

Thanks Jiewen. Looks good to me. Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com> -Original Message- From: Yao, Jiewen Sent: Thursday, June 16, 2016 7:40 PM To: edk2-devel@lists.01.org Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Chan, Amy <amy.c...@intel.c

  1   2   >