URL:
http://gna.org/bugs/?20911
Summary: Cannot set research goal into the future
Project: Freeciv
Submitted by: englabenny
Submitted on: mån 17 jun 2013 10.38.57
Category: None
Severity: 3 - Normal
URL:
http://gna.org/bugs/?20912
Summary: Unit selection dialog is very cluttered
Project: Freeciv
Submitted by: englabenny
Submitted on: mån 17 jun 2013 10.46.33
Category: client
Severity: 3 - Normal
Follow-up Comment #2, patch #3937 (project freeciv):
Are const.TRUE and const.FALSE needed anywhere? I think our bindings should
handle the translation from lua's `true` and `false`.
Further confusion comes from 0 and thus const.FALSE being having boolean value
`true` in lua context, the only
Update of patch #3936 (project freeciv):
Status:None = Ready For Test
___
Follow-up Comment #2:
Third patch version!
User interface is now unchanged in windowed mode. I hope this makes it
Update of bug #20892 (project freeciv):
Status:None = Duplicate
___
Follow-up Comment #1:
Hi, this bug is already tracked as bug #14775
URL:
http://gna.org/patch/?3937
Summary: Remove const.TRUE and const.FALSE from Lua API
before the stable release.
Project: Freeciv
Submitted by: englabenny
Submitted on: sön 9 jun 2013 01.40.00
Category: None
URL:
http://gna.org/patch/?3936
Summary: In GTK2, fullscreen mode, menu bar is not clickable
at the very top
Project: Freeciv
Submitted by: englabenny
Submitted on: fre 7 jun 2013 13.11.25
Category: client-gtk-2.0
Follow-up Comment #1, patch #3936 (project freeciv):
Second patch version, with changes to ./data/freeciv.rc-2.0 to make sure it
works the same way with any freeciv gtk theme.
We could attempt to only disable the shadows (borders) around the
GtkScrolledWindow when in fullscreen. Is it worth it
2010/8/11 Marko Lindqvist cazf...@gmail.com:
On 10 August 2010 20:46, Egor Vyscrebentsov evy...@gmail.com wrote:
Good day!
Are there any thoughts on to support or not to support XDG Base
Directory Specification[1]?
I agree with the idea that one program (Freeciv is considered one
program
Follow-up Comment #1, bug #16100 (project freeciv):
Given the crash site, the passed pbase must be NULL. If you compile with
debug assertions turned on, do you instead hit the following assertion?
assert(punit-activity_base != BASE_NONE);
server/unittools.c : 719
Follow-up Comment #1, bug #16092 (project freeciv):
The experimental ruleset is not part of the 2.2.1, it belongs to trunk. I
think this bug is invalid (we already have a bug about rulesets that can't be
parsed will shut down the server rather than doing something else).
Update of bug #16092 (project freeciv):
Open/Closed:Open = Closed
___
Reply to this item at:
http://gna.org/bugs/?16092
___
Meddelandet
Update of bug #16092 (project freeciv):
Status:None = Invalid
___
Reply to this item at:
http://gna.org/bugs/?16092
___
Meddelandet
2010/5/26 David Lowe doctorjl...@verizon.net:
On 23 May, 2010, at 10:15 PM, Goswin von Brederlow wrote:
An argument for seperate AI clients would also be that it makes
developing the AI more fun.
I like this idea. Battle For Wesnoth has an API so that people can
try their hand at
Update of bug #16053 (project freeciv):
Status:None = Invalid
Open/Closed:Open = Closed
___
Follow-up Comment #2:
My fault, this is
Update of bug #15876 (project freeciv):
Status: In Progress = None
___
Reply to this item at:
http://gna.org/bugs/?15876
___
Meddelandet
URL:
http://gna.org/bugs/?16053
Summary: Warning in common/city.c: O_LAST is not of type
enum output_type_id
Project: Freeciv
Submitted by: englabenny
Submitted on: onsdag 2010-05-19 den 20:33
Category: general
Update of bug #16046 (project freeciv):
Summary: Process /usr/bin/freeciv-server was killed by
signal 6 (SIGABRT) = The server couldn't allocate starting positions
___
Follow-up Comment #1:
Freeciv fails to allocate
Follow-up Comment #5, bug #16008 (project freeciv):
Maybe it's better to make system lua and/or system tolua options when
configuring Freeciv?
the use of tolua_getmetatable is because of a dependence on tolua's
implementation that I have written in. Specifically,
script_remove_exported_object
Follow-up Comment #1, bug #16008 (project freeciv):
Hi. Can you please attach a patch without the removed directories, that
should make the patch much easier to review?
I have tried system tolua before, if we use it, we must compile api_gen.c
without -Werror (so use -Wno-error?), since tolua
Follow-up Comment #1, patch #1656 (project freeciv):
This patch does not depend on patch #1646 and not the other way around
either. However, we could surely convert the API to use enums for effects
instead of effect names (after this patch + patch #1646 both have gone in).
Since the effects API
Follow-up Comment #1, patch #1659 (project freeciv):
Notice here that the code before and after don't do the same thing; TC_LAST
is a valid value since it is defined in the enumeration like the others. The
new code will consider 'TC_LAST' to be the name of a valid terrain class.
I have not
Follow-up Comment #6, patch #1652 (project freeciv):
This patch is a bit (hah! bonus pun) confusing, since _bv_to_str will not
work together with SPECENUM_BITWISE. (A max value of 128 needs is only a
7-bit bitfield, not 128 bits).
___
Follow-up Comment #2, patch #1641 (project freeciv):
Sorry for commenting only now later.
When fc_assert_exit_msg replaces die() then in those instances freeciv will
exit without any message at all if NDEBUG (--enable-debug=no) is defined.
fc_assert_exit is used very seldomly,
Follow-up Comment #1, bug #15884 (project freeciv):
I'm going to check this in. Build system changes, are they normally done to
trunk only or all branches?
___
Reply to this item at:
http://gna.org/bugs/?15884
Update of bug #15908 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #15696 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #15884 (project freeciv):
Status:None = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #1555 (project freeciv):
Status: Postponed = Ready For Test
Assigned to:None = englabenny
Planned Release: = 2.3.0
Follow-up Comment #9, bug #15896 (project freeciv):
Do you use a localized version? It might depend on that just because the
strings are different. So you can try 'LANG=C ./civ'?
In any case, this bug does not look so serious.
___
Reply
Follow-up Comment #8, patch #1616 (project freeciv):
Before committing, please add to api_actions_create_player after variable
declarations:
SCRIPT_CHECK_ARG_NIL(username, 1, string, NULL)
the Script API must all check their assumptions and make sure (the best they
can) that wrong arguments
Update of patch #1561 (project freeciv):
Status: Postponed = Invalid
___
Follow-up Comment #2:
Superceded, updating bug #15696
___
Update of patch #1561 (project freeciv):
Open/Closed:Open = Closed
___
Reply to this item at:
http://gna.org/patch/?1561
___
Meddelandet
Update of bug #15696 (project freeciv):
Priority: 1 - Later = 5 - Normal
Status:None = Ready For Test
Planned Release: = 2.2.1, 2.3.0
Summary:
Update of bug #15725 (project freeciv):
Depends on: = bugs #15696
___
Reply to this item at:
http://gna.org/bugs/?15725
___
Meddelandet
Update of bug #15725 (project freeciv):
Status: Need Info = In Progress
Assigned to:None = englabenny
___
Reply to this item at:
Follow-up Comment #5, bug #15725 (project freeciv):
The way this is developing, no further changes are planned for the 2.1
branch. 2.1 branch has only had the directly unsafe/unwanted functions
removed (read/write/execute programs etc).
Update of bug #15696 (project freeciv):
Category:None = general
___
Follow-up Comment #2:
These patches basically touch exactly the same code that was just modified in
bug #15586. I
Update of patch #1561 (project freeciv):
Status: Invalid = Duplicate
___
Reply to this item at:
http://gna.org/patch/?1561
___
Meddelandet
Update of bug #15624 (project freeciv):
Summary: [RFC] scripting: Sandbox Lua scripts = [RFC]
scripting: Sandbox Lua scripts [Remove unsafe functionality]
___
Reply to this item at:
http://gna.org/bugs/?15624
URL:
http://gna.org/bugs/?15908
Summary: Warning in ai/advdiplomacy.c (case label value is
less than minimum value for type)
Project: Freeciv
Submitted by: englabenny
Submitted on: söndag 2010-04-18 den 22:57
Category:
Follow-up Comment #2, bug #15908 (project freeciv):
The warning is likely correct, and this means we have a bug on powerpc
platforms. I compile on a powerpc. Look here:
The C and C++ standards allows the character type char to be signed or
unsigned, depending on the platform and compiler. Most
Update of bug #15908 (project freeciv):
Planned Release: = 2.2.1, 2.3.0
___
Follow-up Comment #3:
Patch for trunk and 2.2 attached. Changing all char fields of the struct to
'signed char'.
Update of bug #15908 (project freeciv):
Priority: 1 - Later = 5 - Normal
Status:None = Ready For Test
Assigned to:None = englabenny
Follow-up Comment #4, patch #1616 (project freeciv):
Sorry, I think the API function must return the player object. There is no
reliable way to find the player otherwise in all cases (username vs name
etc?). Also player vs. nil is tells the success information as well.
Follow-up Comment #7, patch #1616 (project freeciv):
Thanks great. everything should be in place in the API to implement Sea
Land newcomers now. I'll test this now.
___
Reply to this item at:
http://gna.org/patch/?1616
Follow-up Comment #17, patch #1574 (project freeciv):
What kind of hint do you mean for debugging? A simple message when a bad
terrain tile is tried?
___
Reply to this item at:
http://gna.org/patch/?1574
Update of bug #15586 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Follow-up Comment #9:
I'm happy with the
Update of patch #1626 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #1628 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #1627 (project freeciv):
Category:None = general
Status: Ready For Test = Done
Open/Closed:Open = Closed
URL:
http://gna.org/bugs/?15884
Summary: Use AM_SILENT_RULES for easier to read build output
Project: Freeciv
Submitted by: englabenny
Submitted on: torsdag 2010-04-15 den 11:07
Category: None
Severity: 3
Update of bug #15884 (project freeciv):
Category:None = bootstrap
___
Reply to this item at:
http://gna.org/bugs/?15884
___
Meddelandet
Update of bug #15586 (project freeciv):
Priority: 1 - Later = 5 - Normal
Status: In Progress = Ready For Test
___
Follow-up Comment #6:
Updated patches:
Update of patch #1617 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #1555 (project freeciv):
Status:None = Postponed
___
Reply to this item at:
http://gna.org/patch/?1555
___
Meddelandet
Follow-up Comment #1, bug #15725 (project freeciv):
Here is a plan:
No unsafe functions (should be done)
No NULL pointers and no wild pointers (in progress):
1. We check arguments everywhere. Script functions should try to assure
success or raise a script error.
2. Debug module hidden to
Follow-up Comment #2, bug #15725 (project freeciv):
To clarify the last comment:
We hide '.get', but the tolua runtime will use it to look up object fields.
This will be type safe, unlike direct access to the .get table.
We remove '.set', so the tolua runtime will not allow writing back object
URL:
http://gna.org/bugs/?15876
Summary: API: Lua part of runtime to be shipped in Freeciv
data directory
Project: Freeciv
Submitted by: englabenny
Submitted on: onsdag 2010-04-14 den 13:23
Category: general
Follow-up Comment #6, patch #1617 (project freeciv):
Yet another version. To be consistent across save/load we have to restore
even 'Nonexistent' values.
Also removing the script_is_exported_object_valid function. It is mostly for
debugging.
Patches for trunk and 2.2
(file #8956, file #8957)
Update of patch #1611 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #15860 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #15857 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Follow-up Comment #3:
This fixes some
Follow-up Comment #2, patch #1611 (project freeciv):
Committed to SVN revs r17341 (trunk) and r17342 (S2_2)
___
Reply to this item at:
http://gna.org/patch/?1611
___
Meddelandet skickades
URL:
http://gna.org/bugs/?15878
Summary: freeciv-server.desktop freeciv.desktop
Project: Freeciv
Submitted by: englabenny
Submitted on: onsdag 2010-04-14 den 16:07
Category: None
Severity: 3 - Normal
Update of bug #15586 (project freeciv):
Status: Fixed = In Progress
Open/Closed: Closed = Open
___
Follow-up Comment #5:
A month wiser, I
Update of patch #1601 (project freeciv):
Summary: [Metaticket] Scripting/API extension towards
iteration and querying = [Metaticket] Scripting/API extension towards
iteration and querying for newcomers
___
Reply to this
URL:
http://gna.org/patch/?1626
Summary: API: Player:knows_tech(..) and
Unit_Type:can_exists_at_tile(..)
Project: Freeciv
Submitted by: englabenny
Submitted on: onsdag 2010-04-14 den 21:00
Category: None
Update of patch #1601 (project freeciv):
Depends on: = patch #1626
___
Reply to this item at:
http://gna.org/patch/?1601
___
Meddelandet
Follow-up Comment #14, patch #1574 (project freeciv):
create_player returns NULL, because the player-creating commands (newcomer
and pregame) only take struct player *, not struct player ** arguments that
are needed to be able to write the pointer back to the caller.
Follow-up Comment #2, patch #1616 (project freeciv):
It works well on testing (except not returning the player, but you can get
the player variable back from other places of course).
A comment on a very small thing: in the api_actions.[ch] files, all type
names use the API typedefs, Nation_Type
Follow-up Comment #15, patch #1574 (project freeciv):
This version of newcomers.sav works anyway. This version tries to create
settlers and attack units to match the currently alive nations.. something
similar to the newcomers code.
(file #8974)
Update of patch #1617 (project freeciv):
Planned Release: 2.3.0 = 2.2.1, 2.3.0
___
Follow-up Comment #5:
Patch for 2.2 branch attached, adding same object removal and new API for
:exists() methods.
Update of patch #1618 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #20, bug #15738 (project freeciv):
The latest pepeto patch works well for me.
___
Reply to this item at:
http://gna.org/bugs/?15738
___
Meddelandet skickades via/av Gna!
Update of bug #15860 (project freeciv):
Assigned to:None = englabenny
___
Reply to this item at:
http://gna.org/bugs/?15860
___
Meddelandet
Follow-up Comment #1, bug #15841 (project freeciv):
Updated patch, this way it's even better/easier. Will commit soon.
(file #8928)
___
Additional Item Attachment:
File name: 2010041201-API-Do-not-use-tolua_outside.patch Size:6 KB
Follow-up Comment #2, patch #1617 (project freeciv):
Ah ok. I'll look at player in a followup patch. It seems players are never
released, but they are put into an unusable state after being removed so it's
similar.
Attached patch has minor update for change in tolua_outside patch.
(file #8929)
URL:
http://gna.org/bugs/?15857
Summary: Fix buggy find_transport_from_tile
Project: Freeciv
Submitted by: englabenny
Submitted on: måndag 2010-04-12 den 14:05
Category: general
Severity: 3 - Normal
Update of bug #15841 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #13709 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Follow-up Comment #10:
Switched to
Update of bug #13709 (project freeciv):
Status: Fixed = In Progress
Planned Release: 2.3.0 = 2.2.1, 2.3.0
___
Follow-up Comment #14:
The trunk error
URL:
http://gna.org/bugs/?15860
Summary: Fix compiler warning in tolua-5.1
Project: Freeciv
Submitted by: englabenny
Submitted on: måndag 2010-04-12 den 20:48
Category: general
Severity: 3 - Normal
Update of bug #13709 (project freeciv):
Status: In Progress = Fixed
___
Follow-up Comment #17:
The compilation error is tracked in a separate bug #15860
Update of patch #1611 (project freeciv):
Planned Release: 2.3.0 = 2.2.1, 2.3.0
___
Follow-up Comment #1:
This should go into both 2.2 and trunk, since the change is easily available
to make in 2.2 as
Update of patch #1605 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #1606 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #4, patch #1617 (project freeciv):
Updating the patch. This makes the mechanism much better.
New summary:
We change the type of the userdata to a marker class called
'Nonexistent' [when a freeciv object such as city or unit is free'd].
Nonexistent has one single method
Follow-up Comment #7, bug #13709 (project freeciv):
That's a good idea. I think we can be without the first patch for
tolua_outside, see bug #15841.
The second patch for tolua_notnil is still interesting since there is a lot
less duplicate code/duplicate checks needed with it. But we don't need
Follow-up Comment #1, patch #1614 (project freeciv):
I guess if caller is handled the same way as for other commands so that
access controls still apply, it will be safe. What happens if caller is
NULL?
*This particular* instance of lua scripting in freeciv is about the game; not
the server,
Follow-up Comment #3, bug #15844 (project freeciv):
Thanks. I saw consistent crashes every time a city was destroyed (trunk)
(either real city destruction in the game or when the client quits). I
didn't have time yet to make a clean checkout to testreport it yet. This
seems to be it, the patch
URL:
http://gna.org/patch/?1617
Summary: Release script objects for removed units and cities
Project: Freeciv
Submitted by: englabenny
Submitted on: söndag 2010-04-11 den 22:10
Category: general
Priority:
Update of patch #1617 (project freeciv):
Depends on: = bugs #13709
___
Reply to this item at:
http://gna.org/patch/?1617
___
Meddelandet
Update of bug #15725 (project freeciv):
Depends on: = patch #1617
___
Reply to this item at:
http://gna.org/bugs/?15725
___
Meddelandet
Follow-up Comment #9, patch #1574 (project freeciv):
I wonder if it should be possible to choose the nation for the player to be
created. It would make sense for scenario scripts. nil/NULL would be random
nation (that part works very well by the way, seems to pick nations of the
same category as
URL:
http://gna.org/patch/?1618
Summary: Scripting/API: Use specific argument error
messages
Project: Freeciv
Submitted by: englabenny
Submitted on: söndag 2010-04-11 den 23:55
Category: None
Priority: 5
Update of patch #1618 (project freeciv):
Depends on: = patch #1601
___
Reply to this item at:
http://gna.org/patch/?1618
___
Meddelandet
Follow-up Comment #7, patch #1574 (project freeciv):
Here is how to add a function to the API. It's called 'create_player' in the
API (rhymes well with create_unit, create_base, etc).
All is needs is that the wrapper function api_actions_create_player in
server/scripting/api_actions.h can find
Follow-up Comment #4, bug #13709 (project freeciv):
Thanks for your thoughts. I've been missing more discussion about script/api
changes.
Given how little that happened with scripting before, and how much that is
possible now given the momentum we have (right now), I think we should just
go
Update of bug #15738 (project freeciv):
Status: Ready For Test = Need Info
Assigned to: englabenny = None
___
Follow-up Comment #17:
I don't think I
1 - 100 of 350 matches
Mail list logo
