[Freeciv-Dev] [patch #4309] Editor extra initialization with dynamically found value
Update of patch #4309 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4309 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4317] Define bv_extras based on MAX_EXTRA_TYPES
URL: http://gna.org/patch/?4317 Summary: Define bv_extras based on MAX_EXTRA_TYPES Project: Freeciv Submitted by: cazfi Submitted on: Sun 01 Dec 2013 12:03:46 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Use MAX_EXTRA_TYPES as length of bv_extras, and define it at the same place with other related bitvectors. Since S_LAST is not available at the time bv_extras is now defined, use value '16' instead when calculating MAX_EXTRA_TYPES. This could be avoided for the time being by moving special_types (including S_LAST) up, but as they are to be completely removed soon, having MAX_EXTRA_TYPES not to depend on it is correct future-wise. That's also why the value used is already '16' and not just '6' (= current value of S_LAST). ___ File Attachments: --- Date: Sun 01 Dec 2013 12:03:47 PM EET Name: BvExtrasByMaxExtras.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=19400 ___ Reply to this item at: http://gna.org/patch/?4317 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4318] is_extra_caused_by()
URL: http://gna.org/patch/?4318 Summary: is_extra_caused_by() Project: Freeciv Submitted by: cazfi Submitted on: Sun 01 Dec 2013 12:27:50 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Add function is_extra_caused_by() and use it where appropriate. Hindsight: maybe we should make it a macro if not inline function. ___ File Attachments: --- Date: Sun 01 Dec 2013 12:27:50 PM EET Name: IsExtraCausedBy.patch Size: 6kB By: cazfi http://gna.org/patch/download.php?file_id=19401 ___ Reply to this item at: http://gna.org/patch/?4318 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21272] freeciv-gtk2.exe caused an Access Violation while looking inside city
Follow-up Comment #12, bug #21272 (project freeciv): Hmm, thanks. From the tip of the stack, the common suffix of those backtraces starts at gdk_window_new() (from the base, there's not much -- in particular the main()-y bits are exactly the same as my previous decode so I won't post them again, and it never hits Freeciv code once it dives off into Gtk event loop stuff). One could read the common section of the call stack as handling an expose event on a window that's in the process of being created and fluffing that up, or something like that, maybe...? (Googling the top of the call stack in both cases, gdk_win32_drawable_get_handle(), I idly wonder about Gtk bug 658841 https://bugzilla.gnome.org/show_bug.cgi?id=658841, fixed in 2.24.7, not that there's enough detail there of why they made this change.) Keep 'em coming... (I realise this may be harder without the LT32 server :) ___ Reply to this item at: http://gna.org/bugs/?21272 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20939] freeciv-gtk2.exe caused an Access Violation
Follow-up Comment #2, bug #20939 (project freeciv): A guesswork decode of the top of the stack from nm -n: 00425EBB _finish_city 00498BFD _input_dialog_response 63A43B7A C:\MyGames\Freeciv\libgobject-2.0-0.dll:63A43B7A g_closure_invoke 63A52A50 C:\MyGames\Freeciv\libgobject-2.0-0.dll:63A52A50 g_signal_handler_disconnect ... Looks plausible if we assume name_new_city_popup_callback() in between the top two. But, this stack should only occur when you're founding a new city (after it's prompted you for the name), which I'd expect you'd remember and presumably shouldn't happen every other turn? (My guess at explaining this stack trace from examining the assembler at 425EBB is that finish_city() has been called with ptile==NULL, but I can't immediately see how that might have happened.) ___ Reply to this item at: http://gna.org/bugs/?20939 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20940] freeciv-gtk2.exe causes a Stack Overflow
Follow-up Comment #3, bug #20940 (project freeciv): Now I know how to do a guesswork decode of Windows stack traces, here's one: 0056C0A6 ___chkstk? or __alloca? 00471779 _remove_and_return_a_call 004717EE _call_handle_methods 0042D92E _input_from_server 6C3463D2 C:\MyGames\Freeciv\libgdk-win32-2.0-0.dll:6C3463D2 gdk_drawable_get_visible_region 685ED10B C:\MyGames\Freeciv\libglib-2.0-0.dll:685ED10B g_main_context_dispatch 685ED925 C:\MyGames\Freeciv\libglib-2.0-0.dll:685ED925 g_main_context_dispatch 685EDE61 C:\MyGames\Freeciv\libglib-2.0-0.dll:685EDE61 g_main_loop_run 00E94A80 C:\MyGames\Freeciv\libgtk-win32-2.0-0.dll:00E94A80 gtk_main 00405DD7 _ui_main 004072ED _client_main 0040235B _console_main 00402418 _WinMain@16 00401AD6 _main 004010DB ___mingw_CRTStartup 00401158 _WinMainCRTStartup 77E6F1EB C:\WINDOWS\system32\kernel32.dll:77E6F1EB ProcessIdToSessionId It's a bit of a leap from input_from_server() to call_handle_methods() in agents.c, but not completely implausible -- the agents do respond to packets coming from the network, and there's plenty of scope for call_handle_methods() at least to be tail called (don't know about its callers). Looking at assembler for 471779, I think we just called genlist_sort(). That allocates a temporary array of the size of its list on the stack, so certainly has capacity to blow the stack if passed a huge list (or invalid, although NULL should be trapped). Given that this is a huge game, I'm going to guess that the list is huge rather than an invalid pointer -- it seems plausible that a large number of unit movements could cause a large number of calls to agents (CMA?) to be queued, especially if the client isn't keeping up with the server due to spending all its time on animation. And Windows' stack limit is usually smaller than Unix. The obvious quick fix would be to malloc in genlist_sort(), but there are wider questions: * Doing a full list sort every time we look for the highest priority thing to dequeue is pretty gross, when we could just keep the list sorted by inserting the call at the right place in enqueue_call(), especially as that already does a linear search over the list to look for duplicates. * Maybe we also need some way to stop the agents queue growing huge in this situation, if that's what's happening? ___ Reply to this item at: http://gna.org/bugs/?20940 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21318] Segfault when leaving game with editor base/road tools selected
URL: http://gna.org/bugs/?21318 Summary: Segfault when leaving game with editor base/road tools selected Project: Freeciv Submitted by: jtn Submitted on: Sun Dec 1 12:29:19 2013 Category: editor Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: trunk r23804 Discussion Lock: Any Operating System: GNU/Linux Planned Release: 2.6.0 ___ Details: When leaving a local game having enabled edit mode and selected either the road or base tools, the client segfaults repeatably. Doesn't affect S2_5 or S2_4, only trunk. Base: #0 extra_base_get (pextra=0x0) at extras.c:239 __FUNCTION__ = extra_base_get #1 0x004e5b50 in get_tool_value_pixbuf (value=0, ett=ETT_MILITARY_BASE) at editgui.c:1445 pixbuf = 0x0 pbase = optimised out special = optimised out sprite = 0x0 pterrain = optimised out presource = optimised out putype = optimised out proad = optimised out sprites = optimised out #2 editinfobox_refresh (ei=0x20db880) at editgui.c:1576 pixbuf = optimised out label = optimised out ett = ETT_MILITARY_BASE etm = ETM_PAINT value = 0 buf = span weight=\bold\Military Base/span\000\024\021\263L\177\000\000\220\020\327\005\000\000\000\000\001\000\000\000\000\000\000\000(\000\000\000\000\000\000\000y)\t\264L\177\000\000\250\020\327\005\000\000\000\000\354\002\a\264L\177\000\000\220\020\327\005\000\000\000\000\220\020\327\005\000\000\000\000\200\364\366\001\000\000\000\000`\234\326\005\000\000\000\000\200\364\366\001\000\000\000\000\200\235\326\005\000\000\000\000С\021\263L\177\000\000\000\337\334\b, '\000' repeats 12 times\200, \306\021\263L\177\000\000\001\000\000\000\000\000\000\000y)\t\264L\177\000\000\000\337\334\b\000\000\000\000\001\000\000\000\000\000\000\000(\000\000\000\000\000\000\000y)\t\264L\177\000\000\320H.\177\377\177\000\000\354\002\a\264L\177\000\000\240... #3 0x004e6adb in editgui_refresh () at editgui.c:1811 pe = optimised out eb = 0x2a4e280 ei = 0x0 #4 0x0045a0ee in real_menus_update () at menu.c:2062 safe_group = 0x8cc26d0 edit_group = 0x1e53630 unit_group = 0x1e53680 playing_group = 0x1e536d0 punits = 0x0 units_all_same_tile = true units_all_same_type = true menu = optimised out acttext = \320\066\345\001\000\000\000\000\020\213\225\004, '\000' repeats 12 times\341, %\t\264L\177\000\000\300\246L\000\000\000\000\000Ԟ\245\262L\177\000\000\000\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\320\066\345\001\000\000\000\000\020\213\225\004\000\000\000\000\320\066\345\001\000\000\000\000e\275\243\262L\177\000\000P,^\003\000\000\000\000\320\066\345\001\000\000\000\000\020\213\225\004, '\000' repeats 11 times irrtext = \220N.\177\377\177\000\000\220N.\177\377\177\000\000\300\246L\000\000\000\000\000\033\217@\263L\177\000\000\060\066\345\001\000\000\000\000pN.\177\377\177\000\000\320\314\b\000\000\000\000\066\271E\000\000\000\000\000\020N.\177\377\177\000\000P,^\003\000\000\000\000\320\066\345\001\000\000\000\000\200\066\345\001\000\000\000\000\067, '\000' repeats 15 times, \020N.\177\377\177\000\000\200\001Y\004\000\000\000 mintext = \360\\\004\000\000\000\000ۓɲL\177, '\000' repeats 11 times, (\005\000\000\064\000\000\300M.\177\377\177\000\000\000(\005\000\000(\005\000\300M.\177\377\177\000\000\340\274\001\002\000\000\000\000\240r\333\005, '\000' repeats 12 times\340, N.\177\377\177\000\000 \a\242\262L\177\000\000\355\232c\000\000\000\000\000\240\003\000\000\000\000\000\000\231\062i\000\000\000\000\000\240\003\000\000\000\000\000 transtext = \035\000\000\000\000\000\000\000\225\237n\262L\177\000\000\231\062i\000\000\000\000\000\240\003\000\000\000\000\000\000\355\232c\000\000\000\000\000\022\001\000\000\000\000\000\000\231\062i\000\000\000\000\000\022\332_\000\000\000\000\000\240\003, '\000' repeats 30 times\240, \250L\000\000\000\000\000\065\333_, '\000' repeats 14 times\337, \346\347\266b\030 pterrain = optimised out conn_possible = optimised out proad = optimised out extras = optimised out __FUNCTION__ = real_menus_update #5 0x004caa33 in update_unqueue (data=optimised out) at update_queue.c:317 callback = 0x4ca6c0 menus_update_callback uq_data = optimised out MY_mem_MY_iter = optimised out MY_it_MY_iter = 0x7fff7f2e4e90 MY_iter = 0x7fff7f2e4e90 hash = 0x5d58e20 #6 0x0044adea in idle_callback_wrapper (data=optimised out) at gui_main.c:2038 cb = 0x9b558d0 #7
[Freeciv-Dev] [bug #21318] Segfault when leaving game with editor base/road tools selected
Update of bug #21318 (project freeciv): Status:None = In Progress Assigned to:None = cazfi ___ Follow-up Comment #1: I assume your line numbers are from gtk2-client. ___ Reply to this item at: http://gna.org/bugs/?21318 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21318] Segfault when leaving game with editor base/road tools selected
Update of bug #21318 (project freeciv): Category: editor = client-gtk-2.0 ___ Follow-up Comment #2: I assume your line numbers are from gtk2-client. Oops, yes. ___ Reply to this item at: http://gna.org/bugs/?21318 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20939] freeciv-gtk2.exe caused an Access Violation
Follow-up Comment #3, bug #20939 (project freeciv): OK I have a lot more of these crash reports - they are not identical. But I think they were all related to the same error which went away after recycling centers were built. Here are two more. C:MyGamesFreecivfreeciv-gtk2.exe caused an Access Violation at location 004111ae in module C:MyGamesFreecivfreeciv-gtk2.exe Reading from location 86e9ec14. Registers: eax=f0a236a9 ebx=0022f310 ecx=0001 edx=01d81008 esi=0ddbc068 edi=0e608528 eip=004111ae esp=0022f170 ebp=0022f1d8 iopl=0 nv up ei ng nz na po nc cs=001b ss=0023 ds=0023 es=0023 fs=003b gs= efl=00210286 Call stack: 004111AE C:MyGamesFreecivfreeciv-gtk2.exe:004111AE WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0041C9D4 C:MyGamesFreecivfreeciv-gtk2.exe:0041C9D4 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 004335F0 C:MyGamesFreecivfreeciv-gtk2.exe:004335F0 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00436CA5 C:MyGamesFreecivfreeciv-gtk2.exe:00436CA5 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00437896 C:MyGamesFreecivfreeciv-gtk2.exe:00437896 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 004025FE C:MyGamesFreecivfreeciv-gtk2.exe:004025FE WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 685ED10B C:MyGamesFreecivlibglib-2.0-0.dll:685ED10B g_main_context_dispatch 685ED925 C:MyGamesFreecivlibglib-2.0-0.dll:685ED925 g_main_context_dispatch 685EDE61 C:MyGamesFreecivlibglib-2.0-0.dll:685EDE61 g_main_loop_run 00E94A80 C:MyGamesFreecivlibgtk-win32-2.0-0.dll:00E94A80 gtk_main 00405DD7 C:MyGamesFreecivfreeciv-gtk2.exe:00405DD7 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 004072ED C:MyGamesFreecivfreeciv-gtk2.exe:004072ED WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0040235B C:MyGamesFreecivfreeciv-gtk2.exe:0040235B console_main /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:318 00402418 C:MyGamesFreecivfreeciv-gtk2.exe:00402418 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00401AD6 C:MyGamesFreecivfreeciv-gtk2.exe:00401AD6 004010DB C:MyGamesFreecivfreeciv-gtk2.exe:004010DB 00401158 C:MyGamesFreecivfreeciv-gtk2.exe:00401158 77E6F1EB C:WINDOWSsystem32kernel32.dll:77E6F1EB ProcessIdToSessionId and C:MyGamesFreecivfreeciv-gtk2.exe caused an Access Violation at location 0053bef2 in module C:MyGamesFreecivfreeciv-gtk2.exe Reading from location 2352df34. Registers: eax=005bcba4 ebx=2352df30 ecx=77bbcefb edx=2352df30 esi=00c0 edi=00c0 eip=0053bef2 esp=0022f7e0 ebp=0022f828 iopl=0 nv up ei pl nz na po nc cs=001b ss=0023 ds=0023 es=0023 fs=003b gs= efl=00010206 Call stack: 0053BEF2 C:MyGamesFreecivfreeciv-gtk2.exe:0053BEF2 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 004720DB C:MyGamesFreecivfreeciv-gtk2.exe:004720DB WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0047EAC2 C:MyGamesFreecivfreeciv-gtk2.exe:0047EAC2 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0047ED27 C:MyGamesFreecivfreeciv-gtk2.exe:0047ED27 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00471833 C:MyGamesFreecivfreeciv-gtk2.exe:00471833 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0042D92E C:MyGamesFreecivfreeciv-gtk2.exe:0042D92E WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 6C3463D2 C:MyGamesFreecivlibgdk-win32-2.0-0.dll:6C3463D2 gdk_drawable_get_visible_region 685ED10B C:MyGamesFreecivlibglib-2.0-0.dll:685ED10B g_main_context_dispatch 685ED925 C:MyGamesFreecivlibglib-2.0-0.dll:685ED925 g_main_context_dispatch 685EDE61 C:MyGamesFreecivlibglib-2.0-0.dll:685EDE61 g_main_loop_run 00E94A80 C:MyGamesFreecivlibgtk-win32-2.0-0.dll:00E94A80 gtk_main 00405DD7 C:MyGamesFreecivfreeciv-gtk2.exe:00405DD7 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 004072ED C:MyGamesFreecivfreeciv-gtk2.exe:004072ED WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0040235B C:MyGamesFreecivfreeciv-gtk2.exe:0040235B console_main /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:318 00402418 C:MyGamesFreecivfreeciv-gtk2.exe:00402418 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00401AD6 C:MyGamesFreecivfreeciv-gtk2.exe:00401AD6 004010DB C:MyGamesFreecivfreeciv-gtk2.exe:004010DB 00401158 C:MyGamesFreecivfreeciv-gtk2.exe:00401158 77E6F1EB C:WINDOWSsystem32kernel32.dll:77E6F1EB ProcessIdToSessionId ___ Reply to this item at: http://gna.org/bugs/?20939 ___
[Freeciv-Dev] [bug #21272] freeciv-gtk2.exe caused an Access Violation while looking inside city
Follow-up Comment #14, bug #21272 (project freeciv): Here is a 3rd version of this bug. Thanks. And yes the top of the call stack is again gdk_win32_drawable_get_handle. ...and again, common suffix starts at gdk_window_new() and what's below that is different. Here's the decode for the bit of Freeciv code in the middle: ... 0FB01DC C:\MyGames\Freeciv\libgtk-win32-2.0-0.dll:00FB01DC gtk_widget_show 00FBE2F1 C:\MyGames\Freeciv\libgtk-win32-2.0-0.dll:00FBE2F1 gtk_window_present 00430383 _popup_unit_select_dialog 00424AD6 _do_map_click 0042E993 _butt_down_mapcanvas 00E9733A C:\MyGames\Freeciv\libgtk-win32-2.0-0.dll:00E9733A gtk_marshal_VOID__UINT_STRING 63A43B7A C:\MyGames\Freeciv\libgobject-2.0-0.dll:63A43B7A g_closure_invoke ... (Since this is the unit select dialog, this might have been clicking on a team-mate's city?) I'm reasonably willing to believe that this is a random Gtk failure with a chance of occurring whenever a window is popped up. A question: if this is an old gtk bug why did it not happen before, for instance in LT30 which also used freeciv version 2.3 Good question. From Google, I think LT30 ran from about Jan-Aug 2012, right? The latest clients available in that period were 2.3.1 and 2.3.2; the Windows builds might well have been using an even older version of Gtk which didn't have the bug (but I haven't checked). I guess it doesn't matter if it goes away with the new version of gtk We've got no evidence that it will yet, it's just a guess. On the other hand, I have no better ideas. ___ Reply to this item at: http://gna.org/bugs/?21272 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20939] freeciv-gtk2.exe caused an Access Violation
Follow-up Comment #4, bug #20939 (project freeciv): Here are two more crash reports from a different Access Violation. I didn't post them earlier because I didn't want to spam the bug system with faults. These two are from a different bug - but I can't remember the circumstances of this crash now. C:MyGamesFreecivfreeciv-gtk2.exe caused an Access Violation at location 0041120d in module C:MyGamesFreecivfreeciv-gtk2.exe Reading from location e87dce90. Registers: eax=fcd4b2f8 ebx=0022f270 ecx=0001 edx=01d81008 esi=0de6a240 edi=0de68948 eip=0041120d esp=0022f0c0 ebp=0022f128 iopl=0 nv up ei ng nz na pe nc cs=001b ss=0023 ds=0023 es=0023 fs=003b gs= efl=00010282 Call stack: 0041120D C:MyGamesFreecivfreeciv-gtk2.exe:0041120D WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0041C9D4 C:MyGamesFreecivfreeciv-gtk2.exe:0041C9D4 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 004335F0 C:MyGamesFreecivfreeciv-gtk2.exe:004335F0 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00436CA5 C:MyGamesFreecivfreeciv-gtk2.exe:00436CA5 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00437896 C:MyGamesFreecivfreeciv-gtk2.exe:00437896 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0042219F C:MyGamesFreecivfreeciv-gtk2.exe:0042219F WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00407D2C C:MyGamesFreecivfreeciv-gtk2.exe:00407D2C WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0040270B C:MyGamesFreecivfreeciv-gtk2.exe:0040270B WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 685EE4FE C:MyGamesFreecivlibglib-2.0-0.dll:685EE4FE g_source_get_current_time 685ED10B C:MyGamesFreecivlibglib-2.0-0.dll:685ED10B g_main_context_dispatch 685ED925 C:MyGamesFreecivlibglib-2.0-0.dll:685ED925 g_main_context_dispatch 685EDE61 C:MyGamesFreecivlibglib-2.0-0.dll:685EDE61 g_main_loop_run 00E94A80 C:MyGamesFreecivlibgtk-win32-2.0-0.dll:00E94A80 gtk_main 00405DD7 C:MyGamesFreecivfreeciv-gtk2.exe:00405DD7 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 004072ED C:MyGamesFreecivfreeciv-gtk2.exe:004072ED WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0040235B C:MyGamesFreecivfreeciv-gtk2.exe:0040235B console_main /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:318 00402418 C:MyGamesFreecivfreeciv-gtk2.exe:00402418 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00401AD6 C:MyGamesFreecivfreeciv-gtk2.exe:00401AD6 004010DB C:MyGamesFreecivfreeciv-gtk2.exe:004010DB 00401158 C:MyGamesFreecivfreeciv-gtk2.exe:00401158 77E6F1EB C:WINDOWSsystem32kernel32.dll:77E6F1EB ProcessIdToSessionId C:MyGamesFreecivfreeciv-gtk2.exe caused an Access Violation at location 0041120d in module C:MyGamesFreecivfreeciv-gtk2.exe Reading from location 83969250. Registers: eax=1037cb70 ebx=0022f270 ecx=0001 edx=01d81008 esi=0e009008 edi=0e00c888 eip=0041120d esp=0022f0c0 ebp=0022f128 iopl=0 nv up ei pl nz na pe nc cs=001b ss=0023 ds=0023 es=0023 fs=003b gs= efl=00210202 Call stack: 0041120D C:MyGamesFreecivfreeciv-gtk2.exe:0041120D WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0041C9D4 C:MyGamesFreecivfreeciv-gtk2.exe:0041C9D4 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 004335F0 C:MyGamesFreecivfreeciv-gtk2.exe:004335F0 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00436CA5 C:MyGamesFreecivfreeciv-gtk2.exe:00436CA5 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00437896 C:MyGamesFreecivfreeciv-gtk2.exe:00437896 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0042219F C:MyGamesFreecivfreeciv-gtk2.exe:0042219F WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 00407D2C C:MyGamesFreecivfreeciv-gtk2.exe:00407D2C WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0040270B C:MyGamesFreecivfreeciv-gtk2.exe:0040270B WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 685EE4FE C:MyGamesFreecivlibglib-2.0-0.dll:685EE4FE g_source_get_current_time 685ED10B C:MyGamesFreecivlibglib-2.0-0.dll:685ED10B g_main_context_dispatch 685ED925 C:MyGamesFreecivlibglib-2.0-0.dll:685ED925 g_main_context_dispatch 685EDE61 C:MyGamesFreecivlibglib-2.0-0.dll:685EDE61 g_main_loop_run 00E94A80 C:MyGamesFreecivlibgtk-win32-2.0-0.dll:00E94A80 gtk_main 00405DD7 C:MyGamesFreecivfreeciv-gtk2.exe:00405DD7 WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 004072ED C:MyGamesFreecivfreeciv-gtk2.exe:004072ED WinMain /Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402 0040235B
[Freeciv-Dev] [bug #20939] freeciv-gtk2.exe caused an Access Violation
Follow-up Comment #5, bug #20939 (project freeciv): Decode of interesting bits of comment #3 traces: 004111AE _fill_grid_sprite_array.clone.13 0041C9D4 _fill_sprite_array 004335F0 _put_one_element 00436CA5 _update_map_canvas 00437896 _unqueue_mapview_updates 004025FE _idle_callback_wrapper 685ED10B C:\MyGames\Freeciv\libglib-2.0-0.dll:685ED10B g_main_context_dispatch ... 0053BEF2 _stop_timer 004720DB _wait_for_requests 0047EAC2 _apply_result_on_server 0047ED27 _city_changed 00471833 _call_handle_methods 0042D92E _input_from_server 6C3463D2 C:\MyGames\Freeciv\libgdk-win32-2.0-0.dll:6C3463D2 gdk_drawable_get_visible_region ... These all look quite different, although I guess they might all somehow have the same root cause in pollution somehow. ___ Reply to this item at: http://gna.org/bugs/?20939 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20939] freeciv-gtk2.exe caused an Access Violation
Follow-up Comment #6, bug #20939 (project freeciv): The two call traces in comment #4 are the same as each other (although registers are different): 0041120D _fill_grid_sprite_array.clone.13 0041C9D4 _fill_sprite_array 004335F0 _put_one_element 00436CA5 _update_map_canvas 00437896 _unqueue_mapview_updates 0042219F _blink_active_unit 00407D2C _real_timer_callback 0040270B _timer_callback 685EE4FE C:\MyGames\Freeciv\libglib-2.0-0.dll:685EE4FE g_source_get_current_time ... ...which is similar to the first one from comment #3, albeit in a slightly different place. I didn't post them earlier because I didn't want to spam the bug system with faults. These two are from a different bug - but I can't remember the circumstances of this crash now. I think this ticket's going to have to become a metaticket for Access Violations encountered by one unfortunate Windows user. I realise it is hard for you to know when to raise separate tickets if you can't figure out what's different between causes. ___ Reply to this item at: http://gna.org/bugs/?20939 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18850] Mid-turn CMA changes not saved when game is saved manually
Update of bug #18850 (project freeciv): Operating System: Microsoft Windows = Any Summary: changing only cma will not be saved = Mid-turn CMA changes not saved when game is saved manually ___ Follow-up Comment #4: Could we add a way for the server to request that all clients send updated attribute blocks (containing CMA settings), to be called when a manual save is invoked? It will be fiddly, as the server would need to defer enacting the /save operation until it's got responses from all connected clients (or given up waiting). Which I think means it'll need to process more network packets in the middle of responding to the chat msg containing /save, which means we need to figure out what to do with subsequent chat messages that come in. Adding asynchrony like this is bound to introduce bugs. Still, might be worth it -- it's a bit rubbish that important user state gets lost in this situation. ___ Reply to this item at: http://gna.org/bugs/?18850 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17156] Governor settings saved only upon end of turn
Update of bug #17156 (project freeciv): Status:None = Duplicate Open/Closed:Open = Closed ___ Follow-up Comment #2: See also bug #18850. Closing this one as duplicate, since the other one has more information. ___ Reply to this item at: http://gna.org/bugs/?17156 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21319] get_tool_value_pixbuf() NULL base or road
URL: http://gna.org/bugs/?21319 Summary: get_tool_value_pixbuf() NULL base or road Project: Freeciv Submitted by: cazfi Submitted on: Sun 01 Dec 2013 03:59:49 PM EET Category: client Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: Noticed when investigating bug #21318: get_tool_value_pixbuf() is not prepared to the case that [base|road]_by_number(value) returns NULL, which it sometimes should (bug #21318 being that it itself crashes instead of returning NULL) Fix attached. ___ File Attachments: --- Date: Sun 01 Dec 2013 03:59:49 PM EET Name: BaseRoadEditLeave.patch Size: 2kB By: cazfi http://gna.org/bugs/download.php?file_id=19402 ___ Reply to this item at: http://gna.org/bugs/?21319 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Changes to Gna ticket categories
I've just disallowed creation of new bugs in the client-win32 and client-ftwl categories, since those clients are no longer supported, and Windows users (understandably) keep picking the former by mistake. (Existing bugs in these categories will remain -- what I've done is forbidden transitions into these categories.) I'm inclined to do the same to the editor category, since it's no longer really a separate project, and bugs are probably better reported against client-gtk-2.0 etc. I'm also minded to create a new nations category, since there are a lot of nation tickets, which have their own maintainer (Jos) and workflow. (Currently they go into rulesets.) What do people think? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21318] Segfault when leaving game with editor base/road tools selected
Update of bug #21318 (project freeciv): Category: client-gtk-2.0 = general Status: In Progress = Ready For Test ___ Follow-up Comment #3: Though bases and roads were freed, pointer to the their cause lists was not NULLified, so garbage structures were being used. Fix attached. Requires also fix to bug #21319. (file #19403) ___ Additional Item Attachment: File name: NullDestroyedCauseLists.patch Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?21318 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Changes to Gna ticket categories
On 1 December 2013 16:17, Jacob Nevins 0jacobnk.fc...@chiark.greenend.org.uk wrote: I've just disallowed creation of new bugs in the client-win32 and client-ftwl categories, since those clients are no longer supported, and Windows users (understandably) keep picking the former by mistake. (Existing bugs in these categories will remain -- what I've done is forbidden transitions into these categories.) All that sounds good. I'm inclined to do the same to the editor category, since it's no longer really a separate project, and bugs are probably better reported against client-gtk-2.0 etc. Currently Editor covers both client and server side of the editor functionality, and specific part of them in that (bugs targeted against Editor are not as critical as ones targeted against playing the game). The new development is that there's two clients (gtk2 and gtk3) that have editor functionality, so sometimes it would make sense to report which one of them is affected. So I'm not sure about this one (Disclaimer: having separate Editor category was my idea originally) I'm also minded to create a new nations category, since there are a lot of nation tickets, which have their own maintainer (Jos) and workflow. (Currently they go into rulesets.) Ok Also, I'm about to create freeciv-ruledit category. Not done that yet in the fear that project dies to cradle and then we would have useless category polluting our lists. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4311] Include stdarg.h to tilespec.c
Update of patch #4311 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4311 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4312] Remove handling of intl directory from src-tests
Update of patch #4312 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4312 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21279] Freeciv 2.4 client gtk2 crashes when detached
Follow-up Comment #3, bug #21279 (project freeciv): I observed the same problem and it indifferently affects Windows or Linux clients version 2.4.0. This did not affect 2.3.4. I don't know for 2.4.1. I suspect the probability of hitting the bug depends on the activity of the server, especially regarding private chatting between users. This does not affect the server itself, which just reports a client disconnected, but only segfaults the client. If more clients are detached at the same time inside an actively running server, when one client crashes the others don't do immediately, but may crash after a few seconds. Attached or observing clients are not affected. I spotted this defect on other servers beside freeciv-debian.ns0.it. ___ Reply to this item at: http://gna.org/bugs/?21279 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18850] Mid-turn CMA changes not saved when game is saved manually
Follow-up Comment #5, bug #18850 (project freeciv): It occurs to me that there's a simple change that would help for single-player users, which is for the client to volunteer its attribute block when the user selects save game from the client menu, as it does (I believe) when it leaves a running game. This is a bit of a bodge -- it won't help with server-initiated save, or even with '/save' from chatline -- and the inconsistency is bound to confuse and infuriate someone, but on the other hand it's a simple change that can be made to stable branches (I suggest under a new ticket, keeping this one for the hard problem). ___ Reply to this item at: http://gna.org/bugs/?18850 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4319] Add missing win32 installer creation files to distribution
URL: http://gna.org/patch/?4319 Summary: Add missing win32 installer creation files to distribution Project: Freeciv Submitted by: cproc Submitted on: So 01 Dez 2013 19:14:11 CET Category: None Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: cproc Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Unfortunately, I forgot to add the new installer creation files from task #7681 to Makefile.am and now they are missing in the 2.4.1 tarballs. Patch attached. ___ File Attachments: --- Date: So 01 Dez 2013 19:14:11 CET Name: win32_makefile_am-20131201.patch Size: 583B By: cproc http://gna.org/patch/download.php?file_id=19404 ___ Reply to this item at: http://gna.org/patch/?4319 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7740] Windows packages for 2.4.1
Update of task #7740 (project freeciv): Status:None = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/task/?7740 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20031] Amplio2 missing Maglev gfx
Follow-up Comment #3, bug #20031 (project freeciv): Fixed placement of grid (was off by one pixel) (file #19405) ___ Additional Item Attachment: File name: maglev.png Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?20031 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4320] Update docs for po - translations directory hierarche change
URL: http://gna.org/patch/?4320 Summary: Update docs for po - translations directory hierarche change Project: Freeciv Submitted by: cazfi Submitted on: Sun 01 Dec 2013 08:54:32 PM EET Category: docs Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: Update documentation references to po -directory to references to translations -hierarchy. ___ File Attachments: --- Date: Sun 01 Dec 2013 08:54:32 PM EET Name: DocTranslationHierarchy.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=19406 ___ Reply to this item at: http://gna.org/patch/?4320 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4321] Support for writing include -statements to section file.
URL: http://gna.org/patch/?4321 Summary: Support for writing include -statements to section file. Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Dec 2013 12:07:57 AM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Motive: We don't want to write single nations.ruleset file with hundreds of nations in it from freeciv-ruledit. This patch adds a way to get *include statements written to file. This works by adding special include-section (one for each include statement) with just one entry file to keep filename to include. Unfortunately this cannot be simplified so that filename would be in section name as some necessary characters are not allowed there. When section file is written to disk, these include sections are converted to include statements. As an example and test-case, freeciv-ruledit adds *include default/nationlist.ruleset to nations.ruleset (other parts of that ruleset are not yet written) ___ File Attachments: --- Date: Mon 02 Dec 2013 12:07:58 AM EET Name: SecfileInclude.patch Size: 20kB By: cazfi http://gna.org/patch/download.php?file_id=19407 ___ Reply to this item at: http://gna.org/patch/?4321 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21272] freeciv-gtk2.exe caused an Access Violation while looking inside city
Follow-up Comment #15, bug #21272 (project freeciv): A question: if this is an old gtk bug why did it not happen before, for instance in LT30 which also used freeciv version 2.3 The answer is: I didn't use vanilla freeciv 2.3.0 in LT30 because it was broken. I used a modified freeciv 2.3.0 with the adam smith patch see http://gna.org/bugs/?19219 I had downloaded gtk+-bundle_2.24.8-2022_win32 to compile the client, which according to your previous post, already contains the gtk patch. ___ Reply to this item at: http://gna.org/bugs/?21272 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4322] freeciv-ruledit save button
URL: http://gna.org/patch/?4322 Summary: freeciv-ruledit save button Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Dec 2013 02:27:03 AM EET Category: freeciv-ruledit Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Add real save-button to freeciv-ruledit to make accidental save (potentially overwriting old ruleset) less likely. ___ File Attachments: --- Date: Mon 02 Dec 2013 02:27:03 AM EET Name: RulesaveButton.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=19408 ___ Reply to this item at: http://gna.org/patch/?4322 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4319] Add missing win32 installer creation files to distribution
Update of patch #4319 (project freeciv): Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Reply to this item at: http://gna.org/patch/?4319 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] 2.3.5 schedule (was: 2.4.1 schedule)
Marko Lindqvist writes: On 17 November 2013 11:34, Jacob Nevins 0jacobnk.fc...@chiark.greenend.org.uk wrote: (I've also written a NEWS file for S2_3, with a view to an eventual 2.3.5 release: http://www.freeciv.org/wiki/NEWS-2.3.5. I'm not currently proposing to do this soon, although it probably wouldn't be much overhead to do two releases at once.) Well, I think we either release it relatively soon (well before 2.4.2) or not at all - no point in releasing from old stable series once current series is mature enough for everybody (unless some distribution out there runs a policy to accept bugfix releases of the upstream projects as updates to their releases) So, as you'll have seen, I didn't do a 2.3.5 this weekend. This was mainly because I was hoping to get to the bottom of http://gna.org/bugs/?21272, a Windows crash which is causing pain to at least one LT32 player. However, it's now looking likely that this might just be a Gtk version thing, so in fact the mere act of making a new release (presumably with a new Windows Gtk library) might make it go away. On the other hand, there are a whole pile of other Windows crashes in 2.3.4 that have come to light recently which don't look Gtk-shaped or like things we've already fixed. So we might want to hold out for fixes for some of those, possibly. If we're to have a 2.3.5 release this year, I think it'll have to be next weekend or the weekend after. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
