http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
Pepeto _ wrote:
> http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
>
>> [EMAIL PROTECTED] - Lun. Déc. 03 18:45:11 2007]:
>>
>> William Allen Simpson wrote:
>>
>>> (2) One of them has not worked for about two years, and certainly
> was
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
William Allen Simpson wrote:
> http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
>
> Jason Dorje Short wrote:
>> William Allen Simpson wrote:
>>> (2) One of them has not worked for about two years, and certainly was not
>>> tested at th
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
> [EMAIL PROTECTED] - Lun. Déc. 03 18:45:11 2007]:
>
> William Allen Simpson wrote:
>
> > (2) One of them has not worked for about two years, and certainly
was not
> > tested at the time it was committed.
>
> I'm quite sure it worked when
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
Jason Dorje Short wrote:
> William Allen Simpson wrote:
>> (2) One of them has not worked for about two years, and certainly was not
>> tested at the time it was committed.
>
> I'm quite sure it worked when it was committed.
>
Here's the pa
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
William Allen Simpson wrote:
> (1) You have two ways of doing the same thing.
Should be fixed.
> (2) One of them has not worked for about two years, and certainly was not
> tested at the time it was committed.
I'm quite sure it worked whe
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
Daniel Markstedt wrote:
> I agree that this was done in too hasty a fashion. William, if you
> wanted this code gone so badly, you could at least have presented some
> kind of roadmap for reimplementation.
>
There is no *need* for reimplemen
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
William Allen Simpson wrote:
> http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
>
> Jason Dorje Short wrote:
>> Also, it makes no technical sense to delete an existing keyboard command
>> that duplicates a mouse command. We still h
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
On 12/3/07, Jason Dorje Short <[EMAIL PROTECTED]> wrote:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
>
> William Allen Simpson wrote:
>
> > Since this was broken (by you in PR#14365) circa Dec 2005, and has had only
> > one rep
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
Jason Dorje Short wrote:
> Also, it makes no technical sense to delete an existing keyboard command
> that duplicates a mouse command. We still have exactly the same
> problem we had before but without the keyboard shortcut for it. Inst
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
William Allen Simpson wrote:
> Since this was broken (by you in PR#14365) circa Dec 2005, and has had only
> one report (Aug 2007) in two (2) years, it is clearly not a commonly used
> command. It has never worked. It was never documented.
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
> [jdorje - Dim. Déc. 02 01:59:36 2007]:
>
> Your last patch looks like it does what it says it does. And I agree
> the current code is broken (modifying a unit list inside the list
> iterator is a no-no, that's what iterate_safe is for, bu
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
Committed S2_1 revision 14112.
Committed S2_2 revision 14113.
Committed trunk revision 14114.
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
Jason Dorje Short wrote:
> No need to read the code, just ask anyone who plays multiplayer.
>
The code itself is canonical.
> The quickselect is intended to pick a quick unit from the current stack
> to do a quick action.
>
Wrong. The c
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
William Allen Simpson wrote:
> Reading the code to try to divine the original intent, it makes no sense to
> have a special purpose key to filter land or sea units from an existing
> selected group. The only time that could possibly be used
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
Yet another of the myriad bugs introduced by PR#14365. I'm so sick and
tired of cleaning up this battlegroup mess!
These keys are undocumented intercepts (just as ESC) that appear only in the
gui-gtk2 client. They are not in any menu. App
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
Your last patch looks like it does what it says it does. And I agree
the current code is broken (modifying a unit list inside the list
iterator is a no-no, that's what iterate_safe is for, but even with
iterate_safe the behavior is broken as
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
> [pepeto - Tue Aug 21 21:40:57 2007]:
>
> I got a crash. I selected many units with 'y', and then I typed on a
> quickselect key '*' or '/':
>
Can reproduce like this on 2.1.1 win32-gtk2: select at least three of the same
kind of unit an
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
New patch: It selects new units on the tiles of the current units in
focus. It selects only 1 unit by tile, to avoid unit selection duplication .
Index: client/control.c
===
---
http://bugs.freeciv.org/Ticket/Display.html?id=39602 >
I got a crash. I selected many units with 'y', and then I typed on a
quickselect key '*' or '/':
#0 quickselect (ptile=0x101, qtype=SELECT_LAND) at
../utility/speclist.h:110
listsize =
panytransporter =
panymovesea
19 matches
Mail list logo
