Re: [Freeipa-devel] [PATCH] Multicolumn enrollment dialog

2010-12-02 Thread Adam Young
On 12/01/2010 08:56 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/112/ The enrollment dialog has been modified to use scrollable tables that supports multiple columns to display the search results and selected entries. The col

Re: [Freeipa-devel] [PATCH] 018 Normalize and convert default params, too

2010-12-02 Thread Adam Young
This seems to make sense. Can you provide some context before I ACK? On 12/02/2010 09:21 AM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 https://fedorahosted.org/freeipa/ticket/555 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with

Re: [Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-12-01 Thread Adam Young
On 11/24/2010 02:28 PM, Pavel Zůna wrote: On 2010-11-24 16:21, Adam Young wrote: On 11/24/2010 03:46 AM, Pavel Zuna wrote: On 11/24/2010 03:26 AM, Adam Young wrote: On 11/23/2010 09:37 AM, Pavel Zuna wrote: Finally managed to rewrite the DNS plugin again. Sorry, it took so long, we had

Re: [Freeipa-devel] [PATCH] 612 re-implimit permissions

2010-12-01 Thread Adam Young
On 12/01/2010 05:51 PM, Rob Crittenden wrote: Adam Young wrote: On 12/01/2010 05:07 PM, Adam Young wrote: The attached patch is required on top of the changes, as the admin user no longer has any rolegroup, and thus would see the self service api. It should be pushed with this patch. posted

Re: [Freeipa-devel] [PATCH] 612 re-implimit permissions

2010-12-01 Thread Adam Young
On 12/01/2010 05:07 PM, Adam Young wrote: The attached patch is required on top of the changes, as the admin user no longer has any rolegroup, and thus would see the self service api. It should be pushed with this patch. posted the wrong version. THis one checks for presence of the group

Re: [Freeipa-devel] [PATCH] 612 re-implimit permissions

2010-12-01 Thread Adam Young
ep 17 00:00:00 2001 From: Adam Young Date: Wed, 1 Dec 2010 16:44:44 -0500 Subject: [PATCH] admin determination extends the logic for showing the admin or self service ui to admins by checking for membership in the group admins --- install/static/webui.js | 15 +-- 1 files change

Re: [Freeipa-devel] [PATCH] Refactoring of baseldap callback invokation

2010-11-30 Thread Adam Young
On 11/29/2010 05:28 AM, Jan Zelený wrote: This patch modifies how PRE, POST and EXC callbacks are invoked in baseldap module. It provides method invoke_callbacks which can be used in all classes derived from baseldap classes as well. Pavel, since you originally wrote the baseldap module, I'd be

[Freeipa-devel] [PATCH] admiyo-0105-action-panel-sibling

2010-11-30 Thread Adam Young
hat the QW team isn't writing tests for SUDO yet that makes use of the Label field. From 0ed90c1174c03db1cbe8301cff1f6ced435e240e Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 29 Nov 2010 14:26:55 -0500 Subject: [PATCH] action panel sibling added function to get sibling entities f

Re: [Freeipa-devel] [PATCH] Multicolumn association facet

2010-11-30 Thread Adam Young
On 11/30/2010 02:21 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/111/ The association facet has been modified to support multiple columns. By default the facet will have one column which is the primary key of the associated o

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-25 Thread Adam Young
Updated version that doesn't break SUDO or HBAC. The third level nesting in the tabs set is only used for this kind of navigation now, but should be used for Action panel shortly. From 2371a5b82d7f3184445bcbba32ca516747bb9c6e Mon Sep 17 00:00:00 2001 From: Adam Young Date: Fri, 19 Nov 20

[Freeipa-devel] PATCH for whoami

2010-11-24 Thread Adam Young
Pushed under the 1 liner rule From 16b935169c556135dcab2908d102a884f803fda4 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Wed, 24 Nov 2010 16:36:36 -0500 Subject: [PATCH] whoami fix recent changes to the scope mechanism weren't propigated to the whoami call --- ipalib/plugins/user.py |

Re: [Freeipa-devel] [PATCH]admiyo-0094-xhtml-to-html

2010-11-24 Thread Adam Young
On 11/17/2010 08:58 PM, Adam Young wrote: On 11/17/2010 05:20 PM, Endi Sukma Dewata wrote: On 11/17/2010 2:06 PM, Adam Young wrote: This patch doesn't apply, the index.html is already created in patch #92. OK. Didn't realize I had done that, though it was in another bra

[Freeipa-devel] [PATCH]admiyo-0103-navigation-format

2010-11-24 Thread Adam Young
From d0dd106cbc247fb451cdb8f6c4c3d454d914dd38 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Tue, 23 Nov 2010 16:32:17 -0500 Subject: [PATCH] navigation format UXD guidance to cleanup navigation. adjusts the tab font --- install/static/Mainnav-background.png | Bin 233 -> 180 by

[Freeipa-devel] [PATCH] admiyo-0103-navigation-format

2010-11-24 Thread Adam Young
From d0dd106cbc247fb451cdb8f6c4c3d454d914dd38 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Tue, 23 Nov 2010 16:32:17 -0500 Subject: [PATCH] navigation format UXD guidance to cleanup navigation. adjusts the tab font --- install/static/Mainnav-background.png | Bin 233 -> 180 by

[Freeipa-devel] [PATCH] admiyo-0102-action-panel-formatting

2010-11-24 Thread Adam Young
From 9bc3cc9897741ac720747ecd4a3b4d4f31de7232 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Tue, 23 Nov 2010 22:24:50 -0500 Subject: [PATCH] action panel formatting Cleans up the indentation of the action panel Puts the sudo and HBAC entries in a consistent order --- install/static

Re: [Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-11-24 Thread Adam Young
On 11/24/2010 10:21 AM, Adam Young wrote: On 11/24/2010 03:46 AM, Pavel Zuna wrote: On 11/24/2010 03:26 AM, Adam Young wrote: On 11/23/2010 09:37 AM, Pavel Zuna wrote: Finally managed to rewrite the DNS plugin again. Sorry, it took so long, we had training in the office and I also had a nasty

Re: [Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-11-24 Thread Adam Young
On 11/24/2010 03:46 AM, Pavel Zuna wrote: On 11/24/2010 03:26 AM, Adam Young wrote: On 11/23/2010 09:37 AM, Pavel Zuna wrote: Finally managed to rewrite the DNS plugin again. Sorry, it took so long, we had training in the office and I also had a nasty bug in baseldap.py I couldn't

Re: [Freeipa-devel] [PATCH] Rename parent LDAPObject pkeys in child LDAPObject methods.

2010-11-24 Thread Adam Young
On 11/24/2010 03:48 AM, Pavel Zuna wrote: On 11/19/2010 04:23 PM, Jakub Hrozek wrote: On Tue, Nov 09, 2010 at 04:55:50AM +0100, Pavel Zůna wrote: If the parent and child entries have the same attribute as primary key (such as in the DNS schema), we need to rename the parent key to prevent a par

[Freeipa-devel] Patches and Thunderbird

2010-11-24 Thread Adam Young
Thunderbird formatting of patches: Thunderbird has a nasty habit of prepending a '>' character to the patch, messing up the format. While it is trivial to edit the patch by hand to remove it, the patch sender can help out by configuring Thurnderbird this way: * In Thunderbird Pref

Re: [Freeipa-devel] [PATCH] Generate better DuplicateEntry error message in LDAPCreate.

2010-11-23 Thread Adam Young
On 11/23/2010 09:39 AM, Pavel Zuna wrote: DuplicateEntry error messages generated by LDAPCreate are now detailed like this: ipa: ERROR: user with name "testuser" already exists Solves ticket #530. It works for everything, not just the objects described in this ticket. Pavel

Re: [Freeipa-devel] [PATCH] Change signature of LDAPSearch.pre_callback.

2010-11-23 Thread Adam Young
On 11/23/2010 09:41 AM, Pavel Zuna wrote: On 11/23/2010 03:29 PM, Pavel Zuna wrote: Add the opportunity to change base DN and scope in the callback. This makes the callback a lot more powerful, because it enables the plugin author to broaden or completely change the search location. Pavel

Re: [Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-11-23 Thread Adam Young
On 11/23/2010 09:37 AM, Pavel Zuna wrote: Finally managed to rewrite the DNS plugin again. Sorry, it took so long, we had training in the office and I also had a nasty bug in baseldap.py I couldn't find. Anyway, this version has it all: - changes we agreed on meeting, the "resource" abstractio

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-23 Thread Adam Young
On 11/23/2010 02:15 PM, Endi Sukma Dewata wrote: On 11/22/2010 10:41 AM, Adam Young wrote: Without reordering things now, I propose we allow for a three level structure in the tab_set. Top level will not be an entity. Second level will be an entity. third level will be a nested entity

Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages

2010-11-22 Thread Adam Young
On 11/19/2010 12:21 PM, Endi Sukma Dewata wrote: On 11/19/2010 11:18 AM, Dmitri Pal wrote: Endi Sukma Dewata wrote: On 11/19/2010 10:22 AM, Adam Young wrote: ACK. However, you will need to rebase, as Rob already made the index.html addition to ipa.spec.in Thanks. Rebased and pushed to

Re: [Freeipa-devel] [PATCH] Fixed action panel queries

2010-11-22 Thread Adam Young
On 11/19/2010 04:33 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! Previously the queries for action panel were done globally. Since each entity container has its own action panel, the queries will return multiple results. This is fixed by qualifying the query to r

Re: [Freeipa-devel] [PATCH] SUDO Commands and Command Groups

2010-11-22 Thread Adam Young
On 11/19/2010 07:10 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. It requires patch #37 (Fixed action panel queries). Thanks! The SUDO Commands and Command Groups pages have been added under SUDO Rules tab. Similar to HBAC navigation issue, these entities do not have the

Re: [Freeipa-devel] [PATCH] 0011 Change DNA configuration to use shared configuration

2010-11-22 Thread Adam Young
On 11/19/2010 03:08 PM, Simo Sorce wrote: On Thu, 11 Nov 2010 19:51:23 -0500 Simo Sorce wrote: With this patch 2 changes are introduced. 1. idranges are unified, the --uidstart and --gistart options are removed and instead --idtsrat and --idmax are provided at install time. This is a prer

Re: [Freeipa-devel] [PATCH] 0016 Tune directory server

2010-11-22 Thread Adam Young
On 11/18/2010 08:40 PM, Adam Young wrote: On 11/17/2010 04:26 PM, Simo Sorce wrote: On Tue, 16 Nov 2010 14:09:58 -0500 Simo Sorce wrote: This patch bumps up the default number of files allowed by default for directory server. This allows more clients and also reserves a bigger number of

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-22 Thread Adam Young
On 11/22/2010 12:27 PM, Dmitri Pal wrote: Adam Young wrote: On 11/19/2010 06:53 PM, Endi Sukma Dewata wrote: On 11/19/2010 4:09 PM, Adam Young wrote: This will not work with entities that do not have associated tabs, e.g. hbacsvc, hbacsvcgroups, sudocmd

Re: [Freeipa-devel] [PATCH] 0001 Ensure that Apache is running in Prefork mode

2010-11-22 Thread Adam Young
On 11/15/2010 05:21 AM, Jan Zelený wrote: Jan Zeleny wrote: Rob Crittenden wrote: Jan Zelený wrote: Rob Crittenden wrote: Jan Zelený wrote: I tried one other solution, but this approach was recommended to me by Pavel. It seems to be working fine. I

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-22 Thread Adam Young
On 11/19/2010 06:53 PM, Endi Sukma Dewata wrote: On 11/19/2010 4:09 PM, Adam Young wrote: This will not work with entities that do not have associated tabs, e.g. hbacsvc, hbacsvcgroups, sudocmd, sudocmdgroups. For these entities the IPA.tab_state() will return undefined, so the

Re: [Freeipa-devel] [PATCH] 011 Use sys.exit to quit scripts

2010-11-22 Thread Adam Young
On 11/22/2010 07:01 AM, Jakub Hrozek wrote: On Thu, Nov 11, 2010 at 07:36:22AM +0100, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/09/2010 08:01 PM, Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Instead of

Re: [Freeipa-devel] [PATCH] 616 handle client-install wget failure

2010-11-22 Thread Adam Young
On 11/22/2010 08:27 AM, Jakub Hrozek wrote: On Fri, Nov 19, 2010 at 11:20:23PM -0500, Rob Crittenden wrote: In the client installer we fetch the CA from the IPA server. Wrap this to catch any failures that might occur (like there is an iptables rule denying access to the IPA server). I test

Re: [Freeipa-devel] [PATCH] Added some fields to user object

2010-11-22 Thread Adam Young
On 11/22/2010 09:25 AM, Jan Zelený wrote: Some fields were missing from user object, this change adds them along with their l10n https://fedorahosted.org/freeipa/ticket/305 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.red

[Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-19 Thread Adam Young
From 2371a5b82d7f3184445bcbba32ca516747bb9c6e Mon Sep 17 00:00:00 2001 From: Adam Young Date: Fri, 19 Nov 2010 15:57:40 -0500 Subject: [PATCH] top nav index allows links between differnt top level tabs by calculating the index of the top level tab for the target tab. --- install/static

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-19 Thread Adam Young
On 11/19/2010 06:33 AM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2010 06:16 PM, Dmitri Pal wrote: Adam Young wrote: On 11/18/2010 05:27 PM, Dmitri Pal wrote: Adam Young wrote: On 11/18/2010 04:02 PM, Stephen Gallagher wrote

Re: [Freeipa-devel] [PATCH] Use radio buttons for HBAC rule type

2010-11-19 Thread Adam Young
On 11/19/2010 01:00 AM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! To be consistent with the details page, the rule type in the HBAC add dialog box has been converted into radio buttons. ___ Freeipa-devel mailing list Fre

Re: [Freeipa-devel] [PATCH] Host Enrollment via OTP

2010-11-19 Thread Adam Young
On 11/18/2010 11:50 PM, Endi Sukma Dewata wrote: Hi, Please revie the attached patch. Thanks! The support for host enrollment via one-time-password has been added. When submitted, the OTP will be used to set the host's userpassword. Previously each IPA command can only have one JSON test data

Re: [Freeipa-devel] [PATCH] 608 Fix returning effective rights for password policy

2010-11-19 Thread Adam Young
On 11/19/2010 09:15 AM, Adam Young wrote: On 11/18/2010 10:04 PM, Rob Crittenden wrote: Adam Young wrote: On 11/18/2010 11:22 AM, Rob Crittenden wrote: Password policy needs to update the class of service priority in another entry. Include the CoS attribute when reporting rights. rob

Re: [Freeipa-devel] [PATCH] Sample data for service provisioning

2010-11-19 Thread Adam Young
On 11/19/2010 12:35 AM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK and pushed to master ___

[Freeipa-devel] [PATCH] admiyo-0099-tab-width

2010-11-19 Thread Adam Young
From e588474b389e4eab171f750fc850868099d490e0 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Fri, 19 Nov 2010 11:40:44 -0500 Subject: [PATCH] tab width fixes the spacing and width for the top and second row of tabs --- install/static/ipa.css | 13 + 1 files changed, 5

Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages

2010-11-19 Thread Adam Young
On 11/18/2010 09:33 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! The search and details pages for SUDO Rule have been added. Codes that are shared with HBAC have been moved to rule.js. The following methods were renamed for consistency: - ipa_details_load() -> ip

Re: [Freeipa-devel] [PATCH] 604 revoke certs when disabling and deleting hosts

2010-11-19 Thread Adam Young
On 11/18/2010 05:04 PM, Rob Crittenden wrote: Simo Sorce wrote: On Fri, 05 Nov 2010 15:20:27 -0400 Rob Crittenden wrote: When a host is deleted we revoke its certificate, if any. When a host keytab is disabled we disable all the keytabs and revoke the certificates of its services. I've also

Re: [Freeipa-devel] [PATCH] 607 add managedby to hosts

2010-11-19 Thread Adam Young
On 11/18/2010 10:06 PM, Rob Crittenden wrote: Adam Young wrote: On 11/18/2010 05:05 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Tue, 09 Nov 2010 14:00:00 -0500 Rob Crittenden wrote: + + Add a host that can manage this host's keytab and certificate: + ipa hos

Re: [Freeipa-devel] [PATCH] 607 add managedby to hosts

2010-11-19 Thread Adam Young
On 11/18/2010 10:06 PM, Rob Crittenden wrote: Adam Young wrote: On 11/18/2010 05:05 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Tue, 09 Nov 2010 14:00:00 -0500 Rob Crittenden wrote: + + Add a host that can manage this host's keytab and certificate: + ipa hos

Re: [Freeipa-devel] [PATCH] 608 Fix returning effective rights for password policy

2010-11-19 Thread Adam Young
On 11/18/2010 10:04 PM, Rob Crittenden wrote: Adam Young wrote: On 11/18/2010 11:22 AM, Rob Crittenden wrote: Password policy needs to update the class of service priority in another entry. Include the CoS attribute when reporting rights. rob

Re: [Freeipa-devel] [PATCH] 607 add managedby to hosts

2010-11-18 Thread Adam Young
On 11/18/2010 05:05 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Tue, 09 Nov 2010 14:00:00 -0500 Rob Crittenden wrote: + + Add a host that can manage this host's keytab and certificate: + ipa host-add-host --hosts=test2 test """ I do not want to nack, but looking at

Re: [Freeipa-devel] [PATCH] 0018 filter lockout attributes from replication

2010-11-18 Thread Adam Young
On 11/17/2010 04:27 PM, Simo Sorce wrote: Fixes #440 Simo. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK and pushed to master ___

Re: [Freeipa-devel] [PATCH] 0016 Tune directory server

2010-11-18 Thread Adam Young
On 11/17/2010 04:26 PM, Simo Sorce wrote: On Tue, 16 Nov 2010 14:09:58 -0500 Simo Sorce wrote: This patch bumps up the default number of files allowed by default for directory server. This allows more clients and also reserves a bigger number of FDs (at least according to doc) for replicat

Re: [Freeipa-devel] [PATCH] 608 Fix returning effective rights for password policy

2010-11-18 Thread Adam Young
On 11/18/2010 11:22 AM, Rob Crittenden wrote: Password policy needs to update the class of service priority in another entry. Include the CoS attribute when reporting rights. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.re

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-18 Thread Adam Young
On 11/18/2010 05:27 PM, Dmitri Pal wrote: Adam Young wrote: On 11/18/2010 04:02 PM, Stephen Gallagher wrote: On 11/18/2010 09:55 AM, Dmitri Pal wrote: Steve can you summarize where we are and what we agreed to, please, and identify the questions that we need to

[Freeipa-devel] [PATCH] admiyo-0098-env-init

2010-11-18 Thread Adam Young
From 80b651cdf18270d778c141af1fdcb1d86dccd250 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Thu, 18 Nov 2010 16:48:23 -0500 Subject: [PATCH] env init call the json rpc 'env' during ipa init and cache the result --- install/static/ipa.js |6 ++- install/static

Re: [Freeipa-devel] [PATCH] admiyo-0092-action-select

2010-11-18 Thread Adam Young
On 11/17/2010 01:37 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACKed and pushed to master by edewata ___ Freeipa

[Freeipa-devel] admiyo-0098-env-init

2010-11-18 Thread Adam Young
Example: to find the cert server used, you would do: IPA.env.ra_plugin From 61aaef3542c5f4db0674ffcd591425902ace7367 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Thu, 18 Nov 2010 16:48:23 -0500 Subject: [PATCH] env init call the json rpc 'env' during ipa init and cache

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-18 Thread Adam Young
On 11/18/2010 04:02 PM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/18/2010 09:55 AM, Dmitri Pal wrote: Steve can you summarize where we are and what we agreed to, please, and identify the questions that we need to answer. Simo, Adam and I had a long

Re: [Freeipa-devel] [PATCH] admiyo-0082-more-css-cleanup

2010-11-18 Thread Adam Young
On 11/13/2010 09:02 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACKed and pushed by edewata ___ Freeipa-devel mailing

Re: [Freeipa-devel] admiyo-0083-super-to-superior

2010-11-18 Thread Adam Young
On 11/13/2010 09:03 PM, Adam Young wrote: super is a keyword in Javascript. This removeds a syntax error that shows up on some browsers. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] WebUI status

2010-11-18 Thread Adam Young
To sum up where we are overall, and the dependencies. We have three Entities not yet implemented: Permissions (ACIs) - Spec'ed, but waiting on Backend implementation. SUDO - Not spec'ed, but we can get started based on the HBAC work. Joint effort between edewata and JR Aquino Automount --

Re: [Freeipa-devel] [PATCH] Service and Host Provisioning

2010-11-18 Thread Adam Young
On 11/16/2010 11:52 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/109/ The service and host details pages have been modified to display Kerberos key provisioning status and to provide a way to unprovision. The host enrollmen

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-18 Thread Adam Young
On 11/18/2010 07:09 AM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/17/2010 04:51 PM, Adam Young wrote: On 11/17/2010 04:31 PM, Simo Sorce wrote: On Wed, 17 Nov 2010 16:07:24 -0500 Stephen Gallagher wrote: This will require two changes

[Freeipa-devel] admiyo-0096-add-button

2010-11-18 Thread Adam Young
https://fedorahosted.org/freeipa/ticket/471 From 16a64eaabe4041a63ccfb2473b1c75c9dbe0a3e0 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Wed, 17 Nov 2010 21:12:55 -0500 Subject: [PATCH] add button the spec had three add buttons: this one is the basic, 'add and then close&#x

[Freeipa-devel] Plugin to list plugins?

2010-11-17 Thread Adam Young
Is there a server side plugin I can call to list the plugins, or is this login completely contained on the client side now? ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH]admiyo-0094-xhtml-to-html

2010-11-17 Thread Adam Young
On 11/17/2010 05:20 PM, Endi Sukma Dewata wrote: On 11/17/2010 2:06 PM, Adam Young wrote: This patch doesn't apply, the index.html is already created in patch #92. OK. Didn't realize I had done that, though it was in another branch. The index.html file is in the right form,

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-17 Thread Adam Young
On 11/17/2010 04:31 PM, Simo Sorce wrote: On Wed, 17 Nov 2010 16:07:24 -0500 Stephen Gallagher wrote: This will require two changes to the HBAC schema. First of all, we plan to drop the week-of-the-month concept entirely and replace it with septet-of-the-month. This is being done to elimin

Re: [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-17 Thread Adam Young
On 11/17/2010 04:31 PM, Simo Sorce wrote: On Wed, 17 Nov 2010 16:07:24 -0500 Stephen Gallagher wrote: This will require two changes to the HBAC schema. First of all, we plan to drop the week-of-the-month concept entirely and replace it with septet-of-the-month. This is being done to elimin

[Freeipa-devel] [PATCH] admiyo-0093-CSS-cleanup

2010-11-17 Thread Adam Young
Depends on 0092. From 58a8b432ff1f921d820a348ff5cdb12fb034c545 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Wed, 17 Nov 2010 14:13:33 -0500 Subject: [PATCH] CSS cleanup post UXD discussion --- install/static/Mainnav-background.png | Bin 225 -> 233 bytes install/static/header.

[Freeipa-devel] [PATCH] admiyo-0092-action-select

2010-11-17 Thread Adam Young
From c31e4187d00975ff871f1e32249638f899a3ce8e Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 15 Nov 2010 16:41:21 -0500 Subject: [PATCH] action select if exactly one entity is selected, it enables the entity-facet links in the action panel, and sets the pkey in bbq to the pkey of the

[Freeipa-devel] Moving index page from xhtml to html

2010-11-16 Thread Adam Young
Although we currently don't have an requirement to support IE, it seems that IE has a trouble with xhtml. I guess there is no good reason to stay on xhtml: HTML5 will give us validation, and a file in valid html5 format will render in IR. So, in the not-to-distant future, I'll be moving the

[Freeipa-devel] [PATCH] admiyo-0091-buttons-to-action-panel

2010-11-15 Thread Adam Young
From a975881d4c326a06317a22bd21217938440c20c3 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 15 Nov 2010 11:32:28 -0500 Subject: [PATCH] buttons to action panel puts the buttons as the top li in the action panel --- install/static/details.js |4 ++-- install/static/search.js

Re: [Freeipa-devel] [PATCH] admiyo-0088-HBAC-css-cleanup.

2010-11-15 Thread Adam Young
On 11/15/2010 01:44 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Rebased on top of 0877-2 From 16cc1e8a9558a9070e40277a08ad6de3cb1e6569 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] admiyo-0087-demo-deploy

2010-11-15 Thread Adam Young
On 11/15/2010 01:22 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Rebased ontop of current stack, to include my patch 0090. From

[Freeipa-devel] admiyo-0090-px-to-em

2010-11-15 Thread Adam Young
From 37dffd4d0ac22738215319141b04791a79ea1725 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 15 Nov 2010 15:06:43 -0500 Subject: [PATCH] px to em Making all of the page elements based on the font size. Also, set the font to the defauklt for the browser. By default, most brosers have Font

[Freeipa-devel] [PATCH] dmiyo-0088-HBAC-css-cleanup.

2010-11-15 Thread Adam Young
From e36f0a47317a3b4c185e78e695c35750a3f218cf Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 15 Nov 2010 13:43:10 -0500 Subject: [PATCH] HBAC css cleanup The additions to the search widget have to go one level deeper, as 'container' has both the action panel and the c

[Freeipa-devel] [PATCH] admiyo-0087-demo-deploy

2010-11-15 Thread Adam Young
From 5a32034076d439e5fa12bcfb544d1a805f553069 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 15 Nov 2010 13:20:07 -0500 Subject: [PATCH] demo deploy Makes it easier to deploy demos. This version will demo cleanly from html providing you just set that.use_static_files = true; in the

Re: [Freeipa-devel] [PATCH] HBAC details page enhancement

2010-11-15 Thread Adam Young
On 11/15/2010 11:00 AM, Adam Young wrote: On 11/15/2010 10:58 AM, Adam Young wrote: On 11/13/2010 11:14 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/107/ The HBAC details page has been enhanced to support Undo and Reset

Re: [Freeipa-devel] [PATCH] HBAC details page enhancement

2010-11-15 Thread Adam Young
On 11/13/2010 11:14 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/107/ The HBAC details page has been enhanced to support Undo and Reset operations. The functionality is implemented in the base widget class so the behavior w

[Freeipa-devel] [PATCH] association buttons to action panel

2010-11-15 Thread Adam Young
Pushed under the one line rule: From dbd823c8d874fc54a3ad8a7061a784a39cea2488 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 15 Nov 2010 10:03:27 -0500 Subject: [PATCH] Push associate buttons to the action-panel --- install/static/associate.js |4 ++-- 1 files changed, 2 insertions

Re: [Freeipa-devel] admiyo-0084-buttons-to-action-panel

2010-11-13 Thread Adam Young
On 11/13/2010 09:35 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel As soon as I posted this, I saw an error. This version fixes the broken 'add' bu

[Freeipa-devel] admiyo-0084-buttons-to-action-panel

2010-11-13 Thread Adam Young
From 646b16b92ed2aa9fadca6fc6b850e81bbea056ed Mon Sep 17 00:00:00 2001 From: Adam Young Date: Sat, 13 Nov 2010 21:34:31 -0500 Subject: [PATCH] buttons to action panel --- install/static/hbac.js |4 ++-- install/static/hbacsvc.js |4 ++-- install/static/hbacsvcgroup.js

[Freeipa-devel] admiyo-0083-super-to-superior

2010-11-13 Thread Adam Young
super is a keyword in Javascript. This removeds a syntax error that shows up on some browsers. From a47c3bca9e7b9bb088a48d457fb6100b57abdffc Mon Sep 17 00:00:00 2001 From: Adam Young Date: Fri, 12 Nov 2010 20:51:15 -0500 Subject: [PATCH 83/83] super to superior --- install/static/add.js

[Freeipa-devel] [PATCH] admiyo-0082-more-css-cleanup

2010-11-13 Thread Adam Young
From 36c067844fafad482bfe5b59af67f49b2b77174e Mon Sep 17 00:00:00 2001 From: Adam Young Date: Fri, 12 Nov 2010 15:23:58 -0500 Subject: [PATCH 82/83] more css cleanup remove quick links css very close to specs --- install/static/entity.js | 73

[Freeipa-devel] [PATCH] admiyo-0081-layout

2010-11-11 Thread Adam Young
Incremental stylesheet and layout changes. From 3b012bda65c4ca342e068e5c34f9bf3affd5631a Mon Sep 17 00:00:00 2001 From: Adam Young Date: Tue, 9 Nov 2010 20:04:49 -0500 Subject: [PATCH] layout Closer to the layout from the spec The facets have been moved to the action panel, to the left of the

Re: [Freeipa-devel] HBAC Service & Service Group test data

2010-11-11 Thread Adam Young
On 11/11/2010 12:22 PM, Endi Sukma Dewata wrote: On 11/10/2010 7:18 PM, Adam Young wrote: Please review the attached patch. This can be installed independently from my patch #28 (HBAC Services). Thanks! https://fedorahosted.org/reviewboard/r/105/ You want to make sure the hbac_show.json was

Re: [Freeipa-devel] [PATCH] HBAC Services

2010-11-11 Thread Adam Young
On 11/10/2010 06:20 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/104/ The HBAC Service search and details pages have been added under the HBAC tab. This requires some changes to the framework. Currently the navigation fram

Re: [Freeipa-devel] [PATCH] HBAC Service Groups

2010-11-11 Thread Adam Young
On 11/10/2010 08:46 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. This patch requires my patch #28 (HBAC Services). Thanks! The HBAC Service Groups search, details, and association pages have been added under the HBAC tab. New test data files for HBAC Service Groups have

Re: [Freeipa-devel] [PATCH] Set CACERTDIR during install to work around openldap bug

2010-11-11 Thread Adam Young
On 11/11/2010 08:43 AM, Simo Sorce wrote: On Thu, 11 Nov 2010 14:37:35 +0100 Jakub Hrozek wrote: On Thu, Nov 11, 2010 at 08:10:33AM -0500, Simo Sorce wrote: On Wed, 10 Nov 2010 19:11:46 +0100 Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/10/2010

Re: [Freeipa-devel] HBAC Service & Service Group test data

2010-11-10 Thread Adam Young
On 11/10/2010 06:23 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. This can be installed independently from my patch #28 (HBAC Services). Thanks! https://fedorahosted.org/reviewboard/r/105/ ___ Freeipa-devel mailing list Freeip

Re: [Freeipa-devel] [PATCH] Add new version of DNS plugin: complete rework with baseldap + unit tests.

2010-11-09 Thread Adam Young
On 11/08/2010 11:07 PM, Pavel Zůna wrote: Finally, there it is. :) I redesigned the whole thing to fit the baseldap model. Here's some example on how it's used: # create zone 'example.com' # ipa dnszone-add example.com --name=ns.example.com --admin=ad...@example.com # create a resource in z

[Freeipa-devel] [PATCH] admiyo-0080-Label-cleanup

2010-11-09 Thread Adam Young
From 011b2db628a8239bf5a8da9989c6c026b6f017a6 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Tue, 9 Nov 2010 14:13:39 -0500 Subject: [PATCH] Label cleanup Also, addeed in the default shell field. --- install/static/user.js | 26 +- 1 files changed, 13 insertions

Re: [Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Adam Young
On 11/08/2010 09:04 PM, Endi Sukma Dewata wrote: On 11/8/2010 5:44 PM, Endi Sukma Dewata wrote: The functionality works, but there are some issues: 1. The JSON files contain some trailing whitespaces. 2. The server seems to be using "true" and "False" for nsaccountlock value. So it might be s

Re: [Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Adam Young
On 11/08/2010 06:44 PM, Endi Sukma Dewata wrote: On 11/8/2010 12:01 PM, Adam Young wrote: The functionality works, but there are some issues: 1. The JSON files contain some trailing whitespaces. 2. The server seems to be using "true" and "False" for nsaccountlock v

[Freeipa-devel] [PATCH] admiyo-0079-delete-to-remove

2010-11-08 Thread Adam Young
From 02d23a3b66f3daa3c531080528a8c97d466a4ec6 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 8 Nov 2010 20:39:40 -0500 Subject: [PATCH] delete to remove THe keyword delete is reserved in Javascript Using it breaks the WebUI on Chrome. This fixes replaces the word with delete

Re: [Freeipa-devel] [PATCH] HBAC Access Time

2010-11-08 Thread Adam Young
On 11/08/2010 05:01 PM, Endi Sukma Dewata wrote: On 11/7/2010 7:13 PM, Adam Young wrote: The Time Dialog needs a format. I couldn't guess a value that it would accept. The retry/cancel message is really confusing, too. Tried 1200, 12:00 and 1200-1300. 1. Put in text showing the form

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0075-Ticket-Expiration.patch

2010-11-08 Thread Adam Young
On 11/06/2010 12:45 AM, Endi Sukma Dewata wrote: On 11/5/2010 6:52 PM, Adam Young wrote: Here it is. ACK-ish.. :) The error handling on ticket expiration works, but there are some minor issues: 1. The IPA variable is declared twice. +var IPA; var IPA = ( function () { 2

[Freeipa-devel] [PATCH] admiyo-0078-link-indications

2010-11-08 Thread Adam Young
From bad3ec4564d8890ad675c005d306a07209e6c622 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 8 Nov 2010 13:28:43 -0500 Subject: [PATCH] link indications we had removed the decorations from links for previous ui approaches It is not long relevant, and hides the hyperlink underline in

[Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Adam Young
From 321c0afc7d0998ce120c9c68bb20e4f3672c0c68 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 8 Nov 2010 12:57:16 -0500 Subject: [PATCH] Disable Enable user UI updated to use the enable and disable methods, and to correctly report them Implementation has a few shortcomings: 1. Status is

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0073-Clear-fields-after-add.patch

2010-11-08 Thread Adam Young
On 11/05/2010 05:25 PM, Endi Sukma Dewata wrote: On 11/3/2010 12:03 PM, Endi Sukma Dewata wrote: On 11/3/2010 8:55 AM, Adam Young wrote: I suspect then that the service add dialog is wrong. This behaviour has been spec'ed and working for a long time. What does it break? The field.

Re: [Freeipa-devel] [PATCH] HBAC Access Time

2010-11-07 Thread Adam Young
On 11/06/2010 08:23 PM, Adam Young wrote: On 11/06/2010 12:53 AM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/102/ IPA commands now can be defined in these classes: - ipa_command: a single IPA command - ipa_batch_command: a

Re: [Freeipa-devel] [PATCH] HBAC Access Time

2010-11-06 Thread Adam Young
On 11/06/2010 12:53 AM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/102/ IPA commands now can be defined in these classes: - ipa_command: a single IPA command - ipa_batch_command: a batch command for executing multiple command

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0075-Ticket-Expiration.patch

2010-11-05 Thread Adam Young
On 11/05/2010 05:26 PM, Endi Sukma Dewata wrote: On 11/5/2010 4:03 PM, Adam Young wrote: Ticket Expiration This patch handles Kerberos ticket expiration in the UI. Additionally it removes the mod_auth_kerb authorization for elements in the static directory, cutting down on the number of round

<    5   6   7   8   9   10   11   12   13   14   >