Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12705 )
Change subject: Drop unused parameter
..
Drop unused parameter
value_node_add() ignores it's first argument - let's drop it to make
code
Max has posted comments on this change. ( https://gerrit.osmocom.org/12707 )
Change subject: ttcn3-sip-test/jenkins.sh: remove invalid -M arg
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12707
Max has posted comments on this change. ( https://gerrit.osmocom.org/12698 )
Change subject: libmsc/osmo_msc.c: move connection ref-counting code to
'ran_conn.c'
..
Patch Set 1: Code-Review-1
(1 comment)
https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12707 )
Change subject: ttcn3-sip-test/jenkins.sh: remove invalid -M arg
..
Patch Set 1:
This -M probably was here for a reason - to use particular path
Max has posted comments on this change. ( https://gerrit.osmocom.org/12708 )
Change subject: ttcn3-bsc-test-sccplite-latest: enable job
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12708
Max has posted comments on this change. ( https://gerrit.osmocom.org/12709 )
Change subject: ttcn3: block latest jobs while master is running
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12709
Max has posted comments on this change. ( https://gerrit.osmocom.org/12706 )
Change subject: Support International Caller ID
..
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/12706/2/src/mncc.c
File src/mncc.c
Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12682
To unsubscribe
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12710
Change subject: Add ping probe support
..
Add ping probe support
If liboping is available during ./configure than 'ping XXX' entries will
be supported
Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling
..
Patch Set 6: Code-Review-1
(2 comments)
It kinda feels like you're "cheating" compiler in he
Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling
..
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c
File src/mncc.c:
https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12705 )
Change subject: Drop unused parameter
..
Patch Set 1:
> don't you think the bug is rather that the talloc inside value_node_add is
> using '
Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling
..
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c
File src/mncc.c:
https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling
..
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/12682/4/src/mncc.c
File src/mncc.c:
https
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12705
Change subject: Drop unused parameter
..
Drop unused parameter
value_node_add() ignores it's first argument - let's drop it to make
code more compact
, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I82ad7d2f53c123ad656e8f23432f770ab1d5937e
Gerrit-Change-Number: 12579
Gerrit-PatchSet: 3
Gerrit-Owner: Max
Gerrit-Reviewer
Max has posted comments on this change. ( https://gerrit.osmocom.org/12579 )
Change subject: Use transaction-specific debug macro
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/12579/2/src/libmsc/transaction.c
Max has posted comments on this change. ( https://gerrit.osmocom.org/12654 )
Change subject: Log peer's port in accept callback
..
Patch Set 2:
I've double-checked and it doesn't seem like we're loosing any information
Max has posted comments on this change. ( https://gerrit.osmocom.org/12579 )
Change subject: Use transaction-specific debug macro
..
Patch Set 2:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12615 )
Change subject: Various logging fixes
..
Various logging fixes
Log transaction allocation errors as such. While at it, use proper
subsystem
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12655 )
Change subject: Remove meas_* utils
..
Remove meas_* utils
The counterparts in OsmoBSC repo are actively maintained and (partially
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12657 )
Change subject: Remove osmocom-ipaccess-utils-dbg package
..
Remove osmocom-ipaccess-utils-dbg package
The rest was dropped
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12656 )
Change subject: Remove openbsc-dev package
..
Remove openbsc-dev package
There're no external utilities which rely on it anymore so we can
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I617be8793b9416ccd49022c72f7d93df7f4fb4d9
Gerrit-Change-Number: 12615
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12608 )
Change subject: Handle LCLS-NOTIFICATION message from BSS
..
Handle LCLS-NOTIFICATION message from BSS
Change-Id
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12653 )
Change subject: Set local IP in ipa_server_link properly
..
Set local IP in ipa_server_link properly
When creating IPA link for server we
Max has posted comments on this change. ( https://gerrit.osmocom.org/12625 )
Change subject: assignment_fsm: fix channel allocator preferences
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/12625/4
Max has posted comments on this change. ( https://gerrit.osmocom.org/12628 )
Change subject: libmsc/gsm_04_11.c: introduce and use gsm411_assign_sm_rp_mr()
..
Patch Set 3: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c
File src/mncc.c:
https
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12691
Change subject: Add config for git-review
..
Add config for git-review
Change-Id: I29617f080af81921e4ee0f7a53eaae5ba2e3c30b
---
A .gitreview
1 file
Max has posted comments on this change. ( https://gerrit.osmocom.org/11423 )
Change subject: VTY: add extended (11-bit) RACH detection toggle
..
Patch Set 5:
Note: test failure doesn't seem to be related to the code change
Max has posted comments on this change. ( https://gerrit.osmocom.org/12690 )
Change subject: jenkins-common.sh: exit if image fails to build
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12690
Max has posted comments on this change. ( https://gerrit.osmocom.org/11423 )
Change subject: VTY: add extended (11-bit) RACH detection toggle
..
Patch Set 5: Code-Review+1
I've dropped changes from .cfg - after all, it's
Max has uploaded a new patch set (#5) to the change originally created by Vadim
Yanitskiy. ( https://gerrit.osmocom.org/11423 )
Change subject: VTY: add extended (11-bit) RACH detection toggle
..
VTY: add extended (11-bit) RACH
Max has uploaded a new patch set (#4) to the change originally created by Vadim
Yanitskiy. ( https://gerrit.osmocom.org/11423 )
Change subject: VTY: add extended (11-bit) RACH detection toggle
..
VTY: add extended (11-bit) RACH
Max has posted comments on this change. ( https://gerrit.osmocom.org/11746 )
Change subject: Store subscriber's cell identity in ran_conn
..
Patch Set 6:
(1 comment)
> Meta: AFAIK we already store the entire
Max has posted comments on this change. ( https://gerrit.osmocom.org/12679 )
Change subject: bsc_vty: add vty command to display all lchans
..
Patch Set 1: Code-Review+1
> I still don't like this. I could copy all the previ
Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c
File src/mncc.c:
https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12401 )
Change subject: fix lchan modifications: switch off re-using lchan during
assignment
..
Patch Set 3:
> The code it disables is broken.
Than
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6916928391667cd9c345becf00e7c8561846c295
Gerrit-Change-Number: 12486
Gerrit-PatchSet: 5
Gerrit-Owner: Max
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3520e14ca6e1b8e270dbd4b1bf2378fe486991ce
Gerrit-Change-Number: 12316
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-CC: Pau Espin Pedrol
Gerrit-CC: Stefan
Max has posted comments on this change. ( https://gerrit.osmocom.org/12486 )
Change subject: LCLS: use libosmocore function to add status
..
Patch Set 4:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12661 )
Change subject: Bump version: 1.2.0.199-45df98-dirty → 1.3.0
..
Patch Set 1:
It might make sense to wait for https://gerrit.osmocom.org/c/osmo-msc
Max has posted comments on this change. ( https://gerrit.osmocom.org/12666 )
Change subject: gsm_23_003.h: add GSM23003_IMEI_NUM_NO_CHK_DIGITS
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12666
Max has posted comments on this change. ( https://gerrit.osmocom.org/12492 )
Change subject: LCLS: add string dump helpers
..
Patch Set 10:
(4 comments)
Hopefully latest revision clarifies the rest. Don't hesitate to get
Max has posted comments on this change. ( https://gerrit.osmocom.org/12664 )
Change subject: Sync with libosmocore function rename
..
Patch Set 1:
> Patch Set 1: Code-Review-2
>
> this change is completely bogus as
Max has posted comments on this change. ( https://gerrit.osmocom.org/12662 )
Change subject: Rename msgb_wrap_with_TL() to all lowercase
..
Patch Set 2:
Once this is merged I've got to re-trigger jenkins on related patches
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12664
Change subject: Sync with libosmocore function rename
..
Sync with libosmocore function rename
Change-Id: I6fece7bbbea84962daff885e54f0bc0108c8d0a5
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12663
Change subject: Sync with libosmocore function rename
..
Sync with libosmocore function rename
Change-Id: I1d4675e0c907b2f92f2ec79b02356391a6d72aa8
: If1e851ac605c8d2fde3da565b0bd674ea6350c2e
Gerrit-Change-Number: 12662
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12662
Change subject: Rename msgb_wrap_with_TL() to all lowercase
..
Rename msgb_wrap_with_TL() to all lowercase
This resolves the build issue with old
Max has posted comments on this change. ( https://gerrit.osmocom.org/12642 )
Change subject: gsm0408_test: Fix IMEI-SV related tests to use no more than 16
digits
..
Patch Set 1: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12641 )
Change subject: constrain gsm48_generate_mid() output array bounds
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12641
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12485 )
Change subject: LCLS: constify helper parameters
..
LCLS: constify helper parameters
Related: OS#2487
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12655
Change subject: Remove meas_* utils
..
Remove meas_* utils
The counterparts in OsmoBSC repo are actively maintained and (partially)
packaged
for .deb
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12656
Change subject: Remove openbsc-dev package
..
Remove openbsc-dev package
There're no external utilities which rely on it anymore so we can
simplify
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12657
Change subject: Remove osmocom-ipaccess-utils-dbg package
..
Remove osmocom-ipaccess-utils-dbg package
The rest was dropped
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12654
Change subject: Log peer's port in accept callback
..
Log peer's port in accept callback
* log port from which we accept() the connection in addition
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12653
Change subject: Set local IP in ipa_server_link properly
..
Set local IP in ipa_server_link properly
When creating IPA link for server we might
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12626 )
Change subject: vty: make 'sh connect/transact' readable again
..
vty: make 'sh connect/transact' readable again
After recent changes
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12626
Change subject: vty: make 'sh connect/transact' readable again
..
vty: make 'sh connect/transact' readable again
After recent changes
Max has abandoned this change. ( https://gerrit.osmocom.org/12573 )
Change subject: Add function to combine nibbles into byte
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/12573
To unsubscribe, or for help writing
Max has posted comments on this change. ( https://gerrit.osmocom.org/12485 )
Change subject: LCLS: constify helper parameters
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/12485/1/src/osmo-bsc/osmo_bsc_lcls.c
Max has posted comments on this change. ( https://gerrit.osmocom.org/12483 )
Change subject: LCLS: add status parameter to Assignment Completed message
..
Patch Set 4:
(2 comments)
This change is ready for review.
https
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr
Max has posted comments on this change. ( https://gerrit.osmocom.org/12616 )
Change subject: Update libosmocore to work with newer oc2g osmo-bts
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12616
Max has posted comments on this change. ( https://gerrit.osmocom.org/12591 )
Change subject: ranap_msg_factory.h: fix enum def within function signature
..
Patch Set 1: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12401 )
Change subject: fix lchan modifications: switch off re-using lchan during
assignment
..
Patch Set 3: Code-Review-1
(2 comments)
It seems like
Max has posted comments on this change. ( https://gerrit.osmocom.org/12608 )
Change subject: Handle LCLS-NOTIFICATION message from BSS
..
Patch Set 4:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12571 )
Change subject: VLR: use msgb_eq_data_print() for comparison
..
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG
Commit
-MessageType: newpatchset
Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Stefan Sperling
Gerrit-Reviewer
Max has posted comments on this change. ( https://gerrit.osmocom.org/12615 )
Change subject: Log transaction allocation errors as such
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12615/1/src/libmsc
Max has posted comments on this change. ( https://gerrit.osmocom.org/12608 )
Change subject: Handle LCLS-NOTIFICATION message from BSS
..
Patch Set 2:
This change is ready for review.
--
To view, visit https
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12615
Change subject: Log transaction allocation errors as such
..
Log transaction allocation errors as such
While at it, use proper subsystem to log
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12608
Change subject: Handle LCLS-NOTIFICATION message from BSS
..
Handle LCLS-NOTIFICATION message from BSS
Change-Id
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12578 )
Change subject: SMS: remove code duplication in transaction init
..
SMS: remove code duplication in transaction init
Move code which
Max has posted comments on this change. ( https://gerrit.osmocom.org/12603 )
Change subject: Cosmetic: Fix spelling in smpp vty
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12603
To unsubscribe
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12596
Change subject: Log MDCX ACK for established lchan
..
Log MDCX ACK for established lchan
Previously LCHAN_RTP_EV_IPACC_MDCX_ACK was not permitted
Max has posted comments on this change. ( https://gerrit.osmocom.org/12562 )
Change subject: MSC_Tests: change default for mp_vlr_name
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12562
Max has posted comments on this change. ( https://gerrit.osmocom.org/12554 )
Change subject: socket: add define for socket name length
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/12554/2/src
Max has posted comments on this change. ( https://gerrit.osmocom.org/12527 )
Change subject: VTY: integrate IMEI
..
Patch Set 6:
(3 comments)
https://gerrit.osmocom.org/#/c/12527/6/src/hlr_vty_subscr.c
File src
Max has posted comments on this change. ( https://gerrit.osmocom.org/12565 )
Change subject: gitignore: add tests/hlr_vty_test.db*
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12565
Max has posted comments on this change. ( https://gerrit.osmocom.org/12571 )
Change subject: VLR: use msgb_eq_data_print() for comparison
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG
Commit
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12563 )
Change subject: MNCC: use explicit struct type in gsm_call
..
MNCC: use explicit struct type in gsm_call
There's no need to use 'void
Max has posted comments on this change. ( https://gerrit.osmocom.org/12577 )
Change subject: Enable SMS-related log in VLR tests
..
Patch Set 1: Code-Review+2
(1 comment)
Since the comments were about cosmetic changes (which
Max has posted comments on this change. ( https://gerrit.osmocom.org/12579 )
Change subject: Use transaction-specific debug macro
..
Patch Set 1:
(1 comment)
> - would prefer a LOG_TRANS(trans, LOGL_*, ...)
I thought ab
Max has posted comments on this change. ( https://gerrit.osmocom.org/12577 )
Change subject: Enable SMS-related log in VLR tests
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12577/1//COMMIT_MSG
Commit Message
Max has posted comments on this change. ( https://gerrit.osmocom.org/11504 )
Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/11504/7/src/gsm
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12579
Change subject: Use transaction-specific debug macro
..
Use transaction-specific debug macro
Move logging outside of trans_alloc() so the caller can
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12578
Change subject: SMS: remove code duplication in transaction init
..
SMS: remove code duplication in transaction init
Move code which allocates
Max has posted comments on this change. ( https://gerrit.osmocom.org/12572 )
Change subject: Change GSM48_PDISC_* to enum type
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/12572/1/include/osmocom/gsm/protocol
Gerrit-Change-Id: Icbbe8786a776081d7643193f154e6270224399e6
Gerrit-Change-Number: 12572
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-CC: Vadim Yanitskiy
Max has posted comments on this change. ( https://gerrit.osmocom.org/12573 )
Change subject: Add function to combine nibbles into byte
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/12573/1/include/osmocom/core
-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12573
Change subject: Add function to combine nibbles into byte
..
Add function to combine nibbles into byte
It's a very common patter throughout GSM 04.08
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12572
Change subject: Change GSM48_PDISC_* to enum type
..
Change GSM48_PDISC_* to enum type
Prepare for transaction handling revamp in OsmoMSC: an enum
Max has posted comments on this change. ( https://gerrit.osmocom.org/12519 )
Change subject: Clarify transaction ID assignment
..
Patch Set 3:
> Patch Set 3:
> So, I think we should roll-back to the initial v
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12571
Change subject: VLR: use msgb_eq_data_print() for comparison
..
VLR: use msgb_eq_data_print() for comparison
This simplifies tests refactoring
, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icae21a44c7d4010145bcb570187ce9b58092e5a9
Gerrit-Change-Number: 12570
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12570
Change subject: Log: don't print CallRef prefix
..
Log: don't print CallRef prefix
In a preparation for upcoming CallRef fixes, let's update test
601 - 700 of 3542 matches
Mail list logo
