Change in osmo-msc[master]: Add SGs Interface

2019-01-20 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 30: (1 comment) vty_dump_one_conn() in msc_vty.c: https://gerrit.osmocom.org/#/c/11642/30

Change in osmo-bsc[master]: LCLS: constify helper parameters

2019-01-20 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12485 ) Change subject: LCLS: constify helper parameters .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12485

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2019-01-20 Thread Neels Hofmeyr
: I5535f0d149c2173294538df75764dd181b023312 Gerrit-Change-Number: 11504 Gerrit-PatchSet: 9 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Stefan Sperling

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2019-01-20 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11504 ) Change subject: gsm0808: add BSSMAP Cell Identifier matching API .. Patch Set 9: (1 comment) https://gerrit.osmocom.org/#/c/11504/7/src

Change in libosmocore[master]: add osmo_hexdump_b(), osmo_hexdump_nospc_b(), osmo_hexdump_buf()

2019-01-20 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12658 Change subject: add osmo_hexdump_b(), osmo_hexdump_nospc_b(), osmo_hexdump_buf() .. add osmo_hexdump_b(), osmo_hexdump_nospc_b

Change in libosmocore[master]: add osmo_classmark_* API

2019-01-20 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12659 Change subject: add osmo_classmark_* API .. add osmo_classmark_* API osmo-bsc and osmo-msc implement identical Classmark structures

Change in osmo-msc[master]: Add SGs Interface

2019-01-17 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 30: > Also I think we don't have any TTCN3 test that verifies the periodic LU for &

Change in osmo-hlr[master]: docs: running: same argument order as osmo-hlr -h

2019-01-17 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12605 ) Change subject: docs: running: same argument order as osmo-hlr -h .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org

Change in osmo-hlr[master]: docs: running: document --db-upgrade

2019-01-17 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12606 ) Change subject: docs: running: document --db-upgrade .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12606

Change in osmo-iuh[master]: ranap_msg_factory.h: fix enum def within function signature

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12591 Change subject: ranap_msg_factory.h: fix enum def within function signature .. ranap_msg_factory.h: fix enum def within function signature

Change in osmo-msc[master]: VLR: use msgb_eq_data_print() for comparison

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12571 ) Change subject: VLR: use msgb_eq_data_print() for comparison .. Patch Set 1: Code-Review-1 (4 comments) https://gerrit.osmocom.org/#/c

Change in libosmocore[master]: LCLS: add string dump helpers

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12492 ) Change subject: LCLS: add string dump helpers .. Patch Set 8: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12492/8/src/gsm

Change in osmo-msc[master]: MNCC: use explicit struct type in gsm_call

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12563 ) Change subject: MNCC: use explicit struct type in gsm_call .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in libosmocore[master]: MNCC: move messages into public header and convert to enum

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12564 ) Change subject: MNCC: move messages into public header and convert to enum .. Patch Set 1: Code-Review-2 (5 comments) I don't understand

Change in libosmocore[master]: Add function to combine nibbles into byte

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12573 ) Change subject: Add function to combine nibbles into byte .. Patch Set 2: Code-Review-1 I think this is API bloat. We do a lot of custom

Change in osmo-msc[master]: Use transaction-specific debug macro

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12579 ) Change subject: Use transaction-specific debug macro .. Patch Set 1: (1 comment) Generally a good idea; - would prefer a LOG_TRANS(trans

Change in osmo-bsc[master]: LCLS: use Status for HO-COMPLETE message

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12379 ) Change subject: LCLS: use Status for HO-COMPLETE message .. Patch Set 2: Code-Review-2 reason: see libosmocore patch mentioned in the log

Change in osmo-hlr[master]: Add IMEI column to subscriber table

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12525 ) Change subject: Add IMEI column to subscriber table .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/12525/3//COMMIT_MSG Commit

Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12567 ) Change subject: common: extend glossary.adoc .. Patch Set 1: Code-Review+1 (8 comments) potential additions... https

Change in osmo-msc[master]: SMS: remove code duplication in transaction init

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12578 ) Change subject: SMS: remove code duplication in transaction init .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-msc[master]: Enable SMS-related log in VLR tests

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12577 ) Change subject: Enable SMS-related log in VLR tests .. Patch Set 1: Code-Review+1 nice! -- To view, visit https://gerrit.osmocom.org

Change in libosmocore[master]: Change GSM48_PDISC_* to enum type

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12572 ) Change subject: Change GSM48_PDISC_* to enum type .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12572/2

Change in libosmocore[master]: Change GSM48_PDISC_* to enum type

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12572 ) Change subject: Change GSM48_PDISC_* to enum type .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12572/2//COMMIT_MSG Commit

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

2019-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12478 ) Change subject: VLR: send CHECK-IMEI to EIR/HLR .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12478

Change in osmo-hlr[master]: VTY: integrate IMEI

2019-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12527 ) Change subject: VTY: integrate IMEI .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12527/5/tests

Change in osmo-hlr[master]: Optionally store IMEI in subscriber table

2019-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12526 ) Change subject: Optionally store IMEI in subscriber table .. Patch Set 5: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/12526

Change in osmo-hlr[master]: Add IMEI column to subscriber table

2019-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12525 ) Change subject: Add IMEI column to subscriber table .. Patch Set 4: (1 comment) -1 https://gerrit.osmocom.org/#/c/12525/4/src/db_hlr.c

Change in osmo-hlr[master]: Add IMEI column to subscriber table

2019-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12525 ) Change subject: Add IMEI column to subscriber table .. Patch Set 4: Code-Review-1 (1 comment) -0.0001 https://gerrit.osmocom.org/#/c

Change in osmo-hlr[master]: Cosmetic: fix arg desc of db_subscr_update_msisdn_by_imsi()

2019-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12566 ) Change subject: Cosmetic: fix arg desc of db_subscr_update_msisdn_by_imsi() .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-hlr[master]: gitignore: add tests/hlr_vty_test.db*

2019-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12565 ) Change subject: gitignore: add tests/hlr_vty_test.db* .. Patch Set 1: Code-Review+1 actually the tests should also remove them right away

Change in libosmocore[master]: comments: update/fix three 3GPP spec references

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12559 ) Change subject: comments: update/fix three 3GPP spec references .. comments: update/fix three 3GPP spec references Change-Id

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11504 ) Change subject: gsm0808: add BSSMAP Cell Identifier matching API .. Patch Set 7: pfsh, jenkins' gcc complains that a const struct isn't

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2019-01-14 Thread Neels Hofmeyr
: I5535f0d149c2173294538df75764dd181b023312 Gerrit-Change-Number: 11504 Gerrit-PatchSet: 7 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Stefan Sperling

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2019-01-14 Thread Neels Hofmeyr
: I5535f0d149c2173294538df75764dd181b023312 Gerrit-Change-Number: 11504 Gerrit-PatchSet: 6 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Stefan Sperling

Change in libosmocore[master]: LCLS: add GCR comparison helper

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12493 ) Change subject: LCLS: add GCR comparison helper .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12493

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

2019-01-14 Thread Neels Hofmeyr
: I5535f0d149c2173294538df75764dd181b023312 Gerrit-Change-Number: 11504 Gerrit-PatchSet: 5 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Stefan Sperling

Change in osmo-msc[master]: add BSC/MSC neighbor VTY commands for inter-MSC HO

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12446 ) Change subject: add BSC/MSC neighbor VTY commands for inter-MSC HO .. Patch Set 2: Code-Review-1 (13 comments) meta: Thanks for preparing

Change in libosmocore[master]: comments: update/fix three 3GPP spec references

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12559 Change subject: comments: update/fix three 3GPP spec references .. comments: update/fix three 3GPP spec references Change-Id

Change in osmo-msc[master]: Add SGs Interface

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 29: (2 comments) https://gerrit.osmocom.org/#/c/11642/29/src/libvlr/vlr_sgs.c File src

Change in libosmocore[master]: change GSM48_CMSERV_* to enum type, add names

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12521 ) Change subject: change GSM48_CMSERV_* to enum type, add names .. change GSM48_CMSERV_* to enum type, add names Prepare handling

Change in libosmocore[master]: ipa_ccm_idtag_parse*: Fix reported length value

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10216 ) Change subject: ipa_ccm_idtag_parse*: Fix reported length value .. Patch Set 3: Code-Review+1 first time I come across this patch

Change in osmo-msc[master]: Store subscriber's cell identity in ran_conn

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11746 ) Change subject: Store subscriber's cell identity in ran_conn .. Patch Set 6: (1 comment) Meta: AFAIK we already store the entire CGI

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12478 ) Change subject: VLR: send CHECK-IMEI to EIR/HLR .. Patch Set 10: Code-Review+1 (2 comments) just cosmetics... https://gerrit.osmocom.org

Change in osmo-hlr[master]: VTY: integrate IMEI

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12527 ) Change subject: VTY: integrate IMEI .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12527 To unsubscribe

Change in osmo-hlr[master]: Optionally store IMEI in subscriber table

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12526 ) Change subject: Optionally store IMEI in subscriber table .. Patch Set 4: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/12526

Change in osmo-hlr[master]: Add IMEI column to subscriber table

2019-01-14 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12525 ) Change subject: Add IMEI column to subscriber table .. Patch Set 3: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/12525/3

Change in osmo-msc[master]: Add SGs Interface

2019-01-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 29: feedback on some of my initial concerns, which we talked about in person: TLDR: all

Change in osmo-msc[master]: rx CM Service Req: reject double use sooner

2019-01-11 Thread Neels Hofmeyr
: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Vadim Yanitskiy

Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

2019-01-11 Thread Neels Hofmeyr
Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0a7809840428b1e028df6eb683bc5ffcc8df474a Gerrit-Change-Number: 12470 Gerrit-PatchSet: 5 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Max

Change in osmo-msc[master]: mm_rx_id_resp(): use osmo_mi_name()

2019-01-11 Thread Neels Hofmeyr
-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6bb053def223ed698351ad9f52c1e36293df5d59 Gerrit-Change-Number: 12522 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-msc[master]: refactor log ctx for vlr_subscr and ran_conn

2019-01-11 Thread Neels Hofmeyr
rit-Change-Id: I66a68ce2eb8957a35855a3743d91a86299900834 Gerrit-Change-Number: 12402 Gerrit-PatchSet: 12 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Ger

Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

2019-01-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12470 ) Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context .. Patch Set 4: > Patch Set 4: > > was there any fee

Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

2019-01-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12470 ) Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/1

Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

2019-01-10 Thread Neels Hofmeyr
Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0a7809840428b1e028df6eb683bc5ffcc8df474a Gerrit-Change-Number: 12470 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Max

Change in osmo-msc[master]: refactor log ctx for vlr_subscr and ran_conn

2019-01-10 Thread Neels Hofmeyr
rit-Change-Id: I66a68ce2eb8957a35855a3743d91a86299900834 Gerrit-Change-Number: 12402 Gerrit-PatchSet: 11 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Ger

Change in osmo-msc[master]: use osmo_lu_type_name() from libosmocore

2019-01-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12523 Change subject: use osmo_lu_type_name() from libosmocore .. use osmo_lu_type_name() from libosmocore Change-Id

Change in osmo-msc[master]: mm_rx_id_resp(): use osmo_mi_name()

2019-01-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12522 Change subject: mm_rx_id_resp(): use osmo_mi_name() .. mm_rx_id_resp(): use osmo_mi_name() Change-Id

Change in osmo-msc[master]: refactor log ctx for vlr_subscr and ran_conn

2019-01-10 Thread Neels Hofmeyr
rit-Change-Id: I66a68ce2eb8957a35855a3743d91a86299900834 Gerrit-Change-Number: 12402 Gerrit-PatchSet: 10 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Ger

Change in osmo-msc[master]: refactor log ctx for vlr_subscr and ran_conn

2019-01-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12402 ) Change subject: refactor log ctx for vlr_subscr and ran_conn .. Patch Set 9: (10 comments) https://gerrit.osmocom.org/#/c/12402/9/src

Change in libosmocore[master]: change GSM48_CMSERV_* to enum type, add names

2019-01-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12521 Change subject: change GSM48_CMSERV_* to enum type, add names .. change GSM48_CMSERV_* to enum type, add names Prepare handling multiple CM

Change in libosmocore[master]: LCLS: add GCR comparison helper

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12493 ) Change subject: LCLS: add GCR comparison helper .. Patch Set 1: Code-Review-1 (1 comment) good except https://gerrit.osmocom.org/#/c

Change in libosmocore[master]: LCLS: add string dump helper

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12492 ) Change subject: LCLS: add string dump helper .. Patch Set 7: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/12492/7/src/gsm

Change in osmo-msc[master]: Log MI type on request failure

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12365 ) Change subject: Log MI type on request failure .. Patch Set 5: see https://gerrit.osmocom.org/c/osmo-msc/+/12470/2/src/libmsc/gsm_04_08.c

Change in osmo-msc[master]: Log MI type on request failure

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12365 ) Change subject: Log MI type on request failure .. Patch Set 5: it's good, but will soon be replaced by LOG_RAN_CONN() (if the patch

Change in libosmocore[master]: LCLS: add allocator function

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12491 ) Change subject: LCLS: add allocator function .. Patch Set 1: ok, but why? -- To view, visit https://gerrit.osmocom.org/12491

Change in python/osmo-python-tests[master]: deb: fix wrong changelog date

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12487 ) Change subject: deb: fix wrong changelog date .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12487/1/debian

Change in python/osmo-python-tests[master]: Add initial version of asyncio trap2cgi script

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12476 ) Change subject: Add initial version of asyncio trap2cgi script .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in osmo-bsc[master]: LCLS: constify helper parameters

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12485 ) Change subject: LCLS: constify helper parameters .. Patch Set 1: Code-Review-1 (1 comment) looks good except that one const there https

Change in libosmocore[master]: LCLS: add status parameter to Assignment Completed message

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12483 ) Change subject: LCLS: add status parameter to Assignment Completed message .. Patch Set 2: Code-Review-1 (3 comments) looks good except

Change in libosmocore[master]: LCLS: don't encode incorrect values

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12375 ) Change subject: LCLS: don't encode incorrect values .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12375/3/src

Change in libosmocore[master]: LCLS: use proper types for value_string wrappers

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12367 ) Change subject: LCLS: use proper types for value_string wrappers .. Patch Set 3: Code-Review+2 -- To view, visit https

Change in osmo-bsc[master]: LCLS: use Status for HO-COMPLETE message

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12379 ) Change subject: LCLS: use Status for HO-COMPLETE message .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12379/1//COMMIT_MSG

Change in osmo-msc[master]: Add SGs Interface

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 29: (10 comments) https://gerrit.osmocom.org/#/c/11642/29/src/libmsc/sgs_iface.c File src

Change in osmo-bsc[master]: paging: fix nullpointer deref

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12482 ) Change subject: paging: fix nullpointer deref .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12482

Change in libosmocore[master]: Cosmetic: GSUP: note "on wire" for imei_result

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12488 ) Change subject: Cosmetic: GSUP: note "on wire" for imei_result .. Patch Set 1: Code-Review+2 what would it be for wireless

Change in osmo-hlr[master]: Cosmetic: hlr.c: remove confusing indent below if

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12490 ) Change subject: Cosmetic: hlr.c: remove confusing indent below if .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-msc[master]: VLR: send CHECK-IMEI to EIR/HLR

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12478 ) Change subject: VLR: send CHECK-IMEI to EIR/HLR .. Patch Set 6: Code-Review-1 (6 comments) very nice so far. Also add an msc_vlr_test

Change in osmo-msc[master]: VLR: vlr_subscr_{, msisdn_or_}name: const vsub arg

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12480 ) Change subject: VLR: vlr_subscr_{,msisdn_or_}name: const vsub arg .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-msc[master]: vlr_core.h: remove duplicate declarations

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12479 ) Change subject: vlr_core.h: remove duplicate declarations .. Patch Set 1: Code-Review+2 what, we have a vlr_core.h? :P -- To view, visit

Change in osmo-msc[master]: msc_vty.c: make check-imei-rqd configurable

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12302 ) Change subject: msc_vty.c: make check-imei-rqd configurable .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in osmo-msc[master]: Cosmetic: msc_vty: remove redundant "0 =", "1 ="

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12489 ) Change subject: Cosmetic: msc_vty: remove redundant "0 =", "1 =" .. Patch Set 1: Code-Review+2 --

Change in osmo-bsc[master]: fix lchan modifications: switch off re-using lchan during assignment

2019-01-09 Thread Neels Hofmeyr
ngs Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c00ec2c120e5008281755adcd4944a3ce4d8355 Gerrit-Change-Number: 12401 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit

Change in osmo-bsc[master]: fix call-during-call: switch off re-using lchan during assignment

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12401 ) Change subject: fix call-during-call: switch off re-using lchan during assignment .. Patch Set 2: > I'm not really buying the argum

Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12470 ) Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/1

Change in osmo-msc[master]: err log: fully log MS supported A5 algos on mismatch

2019-01-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12404 ) Change subject: err log: fully log MS supported A5 algos on mismatch .. Patch Set 10: Code-Review+2 I trivially moved a whitespace out

Change in osmo-msc[master]: err log: fully log MS supported A5 algos on mismatch

2019-01-09 Thread Neels Hofmeyr
Gerrit-PatchSet: 10 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-msc[master]: refactor log ctx for vlr_subscr and ran_conn

2019-01-08 Thread Neels Hofmeyr
ype: newpatchset Gerrit-Change-Id: I66a68ce2eb8957a35855a3743d91a86299900834 Gerrit-Change-Number: 12402 Gerrit-PatchSet: 9 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr

Change in osmo-msc[master]: Add SGs Interface

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 29: Code-Review-1 (35 comments) Haven't managed to read everything yet. so far... https

Change in osmo-msc[master]: use mgcp-client configured endpoint domain name

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12361 ) Change subject: use mgcp-client configured endpoint domain name .. use mgcp-client configured endpoint domain name Rationale

Change in osmo-bsc[master]: use mgcp-client configured endpoint domain name

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12358 ) Change subject: use mgcp-client configured endpoint domain name .. use mgcp-client configured endpoint domain name Rationale

Change in osmo-msc[master]: add LOG_RAN_CONN() to use the conn->fi->id for context

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12470 ) Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/1

Change in libosmocore[master]: add osmo_mi_name(), for MI-to-string like "IMSI-123456"

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12468 ) Change subject: add osmo_mi_name(), for MI-to-string like "IMSI-123456" .. add osmo_mi_name(), for MI-to-string like &q

Change in libosmocore[master]: add osmo_lu_type_names[], osmo_lu_type_name()

2019-01-08 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12469 ) Change subject: add osmo_lu_type_names[], osmo_lu_type_name() .. add osmo_lu_type_names[], osmo_lu_type_name() Move lupd_names

Change in libosmocore[master]: add osmo_lu_type_names[], osmo_lu_type_name()

2019-01-06 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12469 ) Change subject: add osmo_lu_type_names[], osmo_lu_type_name() .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12469/2/src/gsm

Change in libosmocore[master]: add osmo_mi_name(), for MI-to-string like "IMSI-123456"

2019-01-06 Thread Neels Hofmeyr
Gerrit-Change-Number: 12468 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy

Change in libosmocore[master]: add osmo_lu_type_names[], osmo_lu_type_name()

2019-01-06 Thread Neels Hofmeyr
Gerrit-Change-Id: Ica25919758ef6cba8348da199b0ae7e0ba628798 Gerrit-Change-Number: 12469 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy

Change in libosmocore[master]: add osmo_mi_name(), for MI-to-string like "IMSI-123456"

2019-01-06 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12468 ) Change subject: add osmo_mi_name(), for MI-to-string like "IMSI-123456" .. Patch Set 2: (2 comments) https://gerrit.osmocom.org

Change in osmo-msc[master]: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP

2019-01-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11920 ) Change subject: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP .. Patch Set 11: Code-Review-1 (8 comments) (in general, I think you

Change in libosmocore[master]: tests/gsup_test.c: drop session IEs from MO-ForwardSM Error

2019-01-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12382 ) Change subject: tests/gsup_test.c: drop session IEs from MO-ForwardSM Error .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in osmo-sgsn[master]: Store GSN address in libosmocore struct

2019-01-04 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12352 ) Change subject: Store GSN address in libosmocore struct .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12352/2/src/gprs

<    2   3   4   5   6   7   8   9   10   11   >