Re: [Potential Spoof] [PATCH] BUG/MAJOR: fd/threads, task/threads: ensure all spin locks are unlocked

2019-02-25 Thread Olivier Houchard
Hi Richard, On Wed, Feb 20, 2019 at 11:58:42PM +, Richard Russo wrote: > While continuing to test this, I ended up with a crash in > listener.c:listener_accept on a closed/closing listen socket where > fdtab[fd].owner is NULL by the time the thread gets there. This is possible > because

Re: Compilation fails on OS-X

2019-02-14 Thread Olivier Houchard
Hi Patrick, On Thu, Feb 14, 2019 at 09:12:18AM -0500, Patrick Hemmer wrote: > > > On 2019/2/14 08:20, Frederic Lecaille wrote: > > On 2/14/19 1:32 PM, Frederic Lecaille wrote: > >> On 2/13/19 7:30 PM, Patrick Hemmer wrote: > >>> > >>> > >&g

Re: Compilation fails on OS-X

2019-02-13 Thread Olivier Houchard
_INITCALL' > >> __DECLARE_INITCALL(__VA_ARGS__) > >> ^ > >> include/common/initcall.h:65:42: note: expanded from macro > >> '__DECLARE_INITCALL' > >> > >> __att

Re: Segfault in assign_tproxy_address with h2 and source address .[1.9.2]

2019-01-17 Thread Olivier Houchard
eb48 Mon Sep 17 00:00:00 2001 From: Olivier Houchard Date: Thu, 17 Jan 2019 15:59:13 +0100 Subject: [PATCH] BUG/MEDIUM: servers: Make assign_tproxy_address work when ALPN is set. If an ALPN is set on the server line, then when we reach assign_tproxy_address, the stream_interface's endpo

Re: Segfault in assign_tproxy_address with h2 and source address .[1.9.2]

2019-01-17 Thread Olivier Houchard
isable h2 on the backend, it works correctly. If I disable the source > in defaults, it works correctly. I've attached the backtrace below. > > Best, > Luke > I think I understand what's going on. Does the attached patch fix it for you ? Thanks a lot ! Olivier >From 585bcc7f8ec84573

Re: Lots of mail from email alert on 1.9.x

2019-01-13 Thread Olivier Houchard
r_check_status() is call, and the check's status and result may be updated. Not sure it is really needed, but I'd rather not offend the Check Gods. The attached patches are updated to od just that. Regards, Olivier >From 7e7b41cac480029c5fd93338dd86a875fee0b5a7 Mon Sep 17 00:00:00 2001 From: Ol

Re: Lots of mail from email alert on 1.9.x

2019-01-11 Thread Olivier Houchard
On Fri, Jan 11, 2019 at 06:53:11PM +0100, Olivier Houchard wrote: > Hi, > > On Fri, Jan 11, 2019 at 10:36:04AM +0100, Johan Hendriks wrote: > > Thanks all. > > No rush on my side as it is a test machine, at least we do know when a > > backend server fails. > > W

Re: Lots of mail from email alert on 1.9.x

2019-01-11 Thread Olivier Houchard
ing if I claimed I enjoy working on the check code, or that I understand it fully. However, after talking with Willy and Christopher, I think I may have comed with an acceptable solution, and the attached patch should fix it (at least by getting haproxy to segfault, but it shouldn't mailbomb you anymore). Pie

Re: State of 0-RTT TLS resumption with OpenSSL

2019-01-09 Thread Olivier Houchard
Hi Willy, On Tue, Jan 08, 2019 at 03:44:07PM +0100, Willy Tarreau wrote: > On Tue, Jan 08, 2019 at 03:27:58PM +0100, Olivier Houchard wrote: > > On Tue, Jan 08, 2019 at 03:00:32PM +0100, Janusz Dziemidowicz wrote: > > > pt., 4 sty 2019 o 11:59 Olivier Houchard > > >

Re: [PATCH] BUG/MEDIUM: init: Initialize idle_orphan_conns for first server in server-template

2019-01-09 Thread Olivier Houchard
Hi, On Wed, Jan 09, 2019 at 01:44:08AM -0500, cripy wrote: > Hi, > > I found a segfault when using server-template within 1.9.x and 2.0-dev. > This seems to be related to "http-reuse" as when I set to "never" it does > not crash anymore. > > It appears that idle_orphan_conns is not being

Re: State of 0-RTT TLS resumption with OpenSSL

2019-01-08 Thread Olivier Houchard
On Tue, Jan 08, 2019 at 03:00:32PM +0100, Janusz Dziemidowicz wrote: > pt., 4 sty 2019 o 11:59 Olivier Houchard napisa??(a): > > I understand the concern. > > I checked and both nghttp2 and nginx disable the replay protection. The idea > > is you're supposed to allow early

Re: State of 0-RTT TLS resumption with OpenSSL

2019-01-04 Thread Olivier Houchard
Hi Janusz, On Fri, Jan 04, 2019 at 10:53:51AM +0100, Janusz Dziemidowicz wrote: > czw., 3 sty 2019 o 17:52 Olivier Houchard napisa??(a): > > Ah I think I figured it out. > > OpenSSL added anti-replay protection when using early data, and it messes up > > with

Re: State of 0-RTT TLS resumption with OpenSSL

2019-01-03 Thread Olivier Houchard
Hi Janusz, On Thu, Jan 03, 2019 at 11:49:35AM +0100, Janusz Dziemidowicz wrote: > ??r., 2 sty 2019 o 19:04 Olivier Houchard napisa??(a): > > You're right indeed. 0RTT was added with a development version of OpenSSL > > 1.1.1, > > which had a default value for ma

Re: State of 0-RTT TLS resumption with OpenSSL

2019-01-02 Thread Olivier Houchard
Olivier >From cdb864da7cebb97800aef2e114bae6f0d0f96814 Mon Sep 17 00:00:00 2001 From: Olivier Houchard Date: Wed, 2 Jan 2019 18:46:41 +0100 Subject: [PATCH] MEDIUM: ssl: Call SSL_CTX_set_max_early_data() to enable 0RTT. When we want to enable early data on a listener, explicitely call SSL_CT

Re: 1.9 BUG: redispatch broken

2018-12-24 Thread Olivier Houchard
> cheers, Ooops you're right indeed. The attached patch should fix it. Thanks a lot for reporting ! Regards, Olivier >From 2276c53dac820d0079525730e9bd7abfd3ea408c Mon Sep 17 00:00:00 2001 From: Olivier Houchard Date: Mon, 24 Dec 2018 13:32:13 +0100 Subject: [PATCH] BUG/MEDIUM: servers: Don't try to reuse con

Re: [PATCH] BUG/CRITICAL: SIGBUS crash on aarch64

2018-11-15 Thread Olivier Houchard
On Thu, Nov 15, 2018 at 02:26:59PM +0100, Willy Tarreau wrote: > On Thu, Nov 15, 2018 at 11:58:36AM +0100, Olivier Houchard wrote: > > Willy, can you push the attached patch ? > > Applied, thanks. I've just slightly edited it to put parenthesis around > "i" below : &g

Re: [PATCH] BUG/CRITICAL: SIGBUS crash on aarch64

2018-11-15 Thread Olivier Houchard
On Thu, Nov 15, 2018 at 09:48:20AM +, Paul Martin wrote: > On Wed, Nov 14, 2018 at 06:05:00PM +0100, Olivier Houchard wrote: > > > Oops, you're right indeed. > > I'm not sure I'm a big fan of special-casing STD_T_UINT. For example, > > STD_T_FRQP is probably 12bytes t

Re: [PATCH] BUG/CRITICAL: SIGBUS crash on aarch64

2018-11-14 Thread Olivier Houchard
probably 12bytes too, so it'd be a problem. Can you test the (untested, but hopefully right) patch attached ? Thanks a lot ! Olivier >From 50027352049d64b874e1116758400580541ea49f Mon Sep 17 00:00:00 2001 From: Olivier Houchard Date: Wed, 14 Nov 2018 17:54:36 +0100 Subject: [PATCH] BUG/MEDIUM:

Re: High CPU Usage followed by segfault error

2018-10-16 Thread Olivier Houchard
On Tue, Oct 16, 2018 at 05:02:30PM +0200, Willy Tarreau wrote: > On Tue, Oct 16, 2018 at 04:11:20PM +0200, Willy Tarreau wrote: > > Could you please apply the attached patch ? I'm going to merge it into 1.9 > > and we'll backport it to 1.8 later. > > And please add the attached one as well, which

Re: High CPU Usage followed by segfault error

2018-10-16 Thread Olivier Houchard
Hi Soji, On Mon, Oct 15, 2018 at 11:10:09PM +0530, Soji Antony wrote: > Hi Olivier, > > Many thanks for your reply. > Please find the gdb output given below. > > # gdb /usr/sbin/haproxy core.dump3.13871 > GNU gdb (Ubuntu 7.7.1-0ubuntu5~14.04.3) 7.7.1 > Copyright (C) 2014 Free Software

Re: High CPU Usage followed by segfault error

2018-10-15 Thread Olivier Houchard
/0x40 > > Oct 10 19:16:28 int16 kernel: [193201.152509] [] > > xfs_setattr_size+0x168/0x3d0 [xfs] > > Oct 10 19:16:28 int16 kernel: [193201.152522] [] > > xfs_vn_setattr+0x9f/0xb0 [xfs] > > Oct 10 19:16:28 int16 kernel: [193201.152524] [] > > notify_change+0x25

Re: High CPU Usage followed by segfault error

2018-10-02 Thread Olivier Houchard
Hi, On Tue, Oct 02, 2018 at 08:26:12PM +0530, Soji Antony wrote: > Hello, > > We are currently using haproxy 1.8.3 with single process multithreaded > configuration. > We have 1 process and 10 threads each mapped to a separate core [0-9]. We > are running our haproxy instances on a c4.4xlarge

Re: Crash reposrt

2018-09-26 Thread Olivier Houchard
Hi Anton, On Wed, Sep 26, 2018 at 12:09:07PM +0300, prog 76 wrote: > > Hi > First of all Thank you for this great product. We are very happy to use it > for years. > Unfortunately from version 1.8.12 we have an issue. Sometimes haproxy crash. > We tried  to upgrade to 1.8.13 and it also

Re: Hang in haproxy 1.8.13

2018-09-11 Thread Olivier Houchard
ond one for 1.8, as the master patch didn't apply cleanly on 1.8. Regards, Olivier >From d950da31340528c37173fc74d1c0f635c977cd03 Mon Sep 17 00:00:00 2001 From: Olivier Houchard Date: Tue, 11 Sep 2018 14:44:51 +0200 Subject: [PATCH] BUG/MAJOR: kqueue: Don't reset the changes number by accident. In

Re: Hang in haproxy 1.8.13

2018-09-11 Thread Olivier Houchard
Hi, On Tue, Sep 11, 2018 at 12:36:08PM +0200, Lukas Tribus wrote: > On Tue, 11 Sep 2018 at 11:55, David King wrote: > > > > Apologies, i forgot to mention this is running on FreeBSD 11.1 > > > > I've just run the same tests on Centos and there is no issue > > Could you retry with the current

Re: Help you generate more revenue for your haproxy.com.

2018-09-05 Thread Olivier Houchard
On Wed, Sep 05, 2018 at 10:14:55PM +1000, Rob Thomas wrote: > You gotta wonder how this guy got this mailing list. He must have actually > LOOKED at the website, right? > > Sigh. Spammers. > > For anyone who cares, I don't think it's possible for haproxy to get MORE > exposure on google. > >

Re: How to verify HAProxy build on Solaris/SPARC ?

2018-08-31 Thread Olivier Houchard
Hi Lukas, On Fri, Aug 31, 2018 at 02:03:47PM +0200, Lukas Tribus wrote: > Hello, > > > On Fri, 31 Aug 2018 at 04:30, Willy Tarreau wrote: > > I'd like to ask you to test something just in case it helps. Could > > you please modify your makefile to add "-pthread" to "-DUSE_THREAD" > > like this

Re: [PATCH] BUG/MAJOR: thread: lua: Wrong SSL context initialization.

2018-08-29 Thread Olivier Houchard
On Wed, Aug 29, 2018 at 02:11:45PM +0200, Frederic Lecaille wrote: > This patch is in relation with one bug reproduced by the reg testing file > sent by Pieter in this thread: > https://www.mail-archive.com/haproxy@formilux.org/msg31079.html > > Must be checked by Thierry. > Must be backported to

Re: lua script, 200% cpu usage with nbthread 3 - haproxy hangs - __spin_lock - HA-Proxy version 1.9-dev1-e3faf02 2018/08/25

2018-08-28 Thread Olivier Houchard
> Ok you're right, I have a patch for that problem, which should definitively be different from Pieter's problem :) Willy, I think it's safe to be applied, and should probably be backported (albeit it should be adapted, given the API differences with buffers/channels) to 1.8 and 1.7, I've been abl

Re: lua script, 200% cpu usage with nbthread 3 - haproxy hangs - __spin_lock - HA-Proxy version 1.9-dev1-e3faf02 2018/08/25

2018-08-27 Thread Olivier Houchard
On Mon, Aug 27, 2018 at 02:29:42PM +0200, Frederic Lecaille wrote: > On 08/27/2018 01:33 PM, Olivier Houchard wrote: > > Hi Pieter, > > > > On Sat, Aug 25, 2018 at 10:00:04PM +0200, PiBa-NL wrote: > > > Hi List, Thierry, Olivier, > > > > > >

Re: lua script, 200% cpu usage with nbthread 3 - haproxy hangs - __spin_lock - HA-Proxy version 1.9-dev1-e3faf02 2018/08/25

2018-08-27 Thread Olivier Houchard
t; #8  0x0051a6b2 in run_poll_loop () at src/haproxy.c:2386 >     next = 1923608730 >     exp = 1923608070 > #9  0x00517672 in run_thread_poll_loop (data=0x8024849f8) at > src/haproxy.c:2451 >     start_lock = {lock = 0, info = {owner = 0, waiters = 0, > last

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Olivier Houchard
igured those out, well at least I don't have hangs anymore, and I think I understood those segfaults. The attached patchset should do the trick. Willy, those should be mergeable. Thanks ! Olivier >From 159f4653cffdd26fb62a26d047ac3f87f7506e59 Mon Sep 17 00:00:00 2001 From: Olivier Houchard D

Re: 100% cpu usage 1.9-dev0-48d92ee 2018/07/30, task.?. but keeps working.. (nbthread 1)

2018-08-21 Thread Olivier Houchard
Hi Pieter, On Mon, Aug 20, 2018 at 09:33:49PM +0200, PiBa-NL wrote: > Hi Olivier, > > Op 17-8-2018 om 14:51 schreef Willy Tarreau: > > On Fri, Aug 17, 2018 at 01:41:54PM +0200, Olivier Houchard wrote: > > > That is true, this one is not a bug, but a pessimization, by

Re: 100% cpu usage 1.9-dev0-48d92ee 2018/07/30, task.?. but keeps working.. (nbthread 1)

2018-08-17 Thread Olivier Houchard
On Thu, Aug 16, 2018 at 07:31:17PM +0200, Willy Tarreau wrote: > Both patches applied, thanks guys! > > Olivier, I have a suggestion for this one : > On Thu, Aug 16, 2018 at 07:17:07PM +0200, Olivier Houchard wrote: > > From 90fc92f72c6b47d88769bb73680702d7b8e6 Mon Se

Re: 100% cpu usage 1.9-dev0-48d92ee 2018/07/30, task.?. but keeps working.. (nbthread 1)

2018-08-16 Thread Olivier Houchard
Hi again, On Thu, Aug 16, 2018 at 05:50:27PM +0200, Olivier Houchard wrote: > Hi Pieter, > > On Thu, Aug 16, 2018 at 12:24:04AM +0200, PiBa-NL wrote: > > Hi List, > > > > Anyone got a idea how to debug this further? > > Currently its running at 100% again,

Re: 100% cpu usage 1.9-dev0-48d92ee 2018/07/30, task.?. but keeps working.. (nbthread 1)

2018-08-16 Thread Olivier Houchard
Hi Pieter, On Thu, Aug 16, 2018 at 12:24:04AM +0200, PiBa-NL wrote: > Hi List, > > Anyone got a idea how to debug this further? > Currently its running at 100% again, any pointers to debug the process as > its running would be appreciated. > > Or should i compile again from current master and

Re: Issue with TCP splicing

2018-07-25 Thread Olivier Houchard
On Wed, Jul 25, 2018 at 09:02:24AM -0400, Julien Semaan wrote: > Hi Olivier, > > Thanks for the time you're taking to check the issue. > > I'll get an environment back with TCP splicing enabled and I'll run it in > GDB and provide you a core dump > That would be great, thank you ! Olivier

Re: Issue with TCP splicing

2018-07-25 Thread Olivier Houchard
Hi Julien, On Tue, Jul 24, 2018 at 01:29:49PM -0400, Julien Semaan wrote: > > Sorry, that was a "can" that really meant "can't" :) I can't reproduce it. >     Aw well, I was surprised it was so easy :) > yea, that would be too easy :) > > Can you try to upgrade to 1.8.12 ? A number of bugs

Re: Issue with TCP splicing

2018-07-24 Thread Olivier Houchard
Hi Julian, On Tue, Jul 24, 2018 at 12:58:27PM -0400, Julien Semaan wrote: > Hi Olivier, > > Glad you're able to replicate it because I can't get it to happen > consistently! > I'd be happy if you could share the details of how it could be replicated if > that's not too complex or hard to explain

Re: Issue with TCP splicing

2018-07-24 Thread Olivier Houchard
Hi Julian, On Mon, Jul 23, 2018 at 09:07:32AM -0400, Julien Semaan wrote: > Hi all, > > We're currently using haproxy in our project PacketFence > (https://packetfence.org) and are currently experiencing an issue with > haproxy segfaulting when TCP splicing is enabled. > > We're currently

[PATCH] MINOR: server: Don't make "server" in frontend fatal.

2018-07-24 Thread Olivier Houchard
4d14bce82923cb9b35bb74ac642bb Mon Sep 17 00:00:00 2001 From: Olivier Houchard Date: Tue, 24 Jul 2018 16:48:59 +0200 Subject: [PATCH] BUG/MINOR: servers: Don't make "server" in a frontend fatal. When parsing the configuration, if "server", "default-server&qu

Re: Building HAProxy 1.8 fails on Solaris

2018-07-20 Thread Olivier Houchard
Hi, On Sat, Jul 21, 2018 at 12:51:53AM +0200, Lukas Tribus wrote: > Hello, > > On Fri, 20 Jul 2018 at 15:58, Olivier Houchard wrote: > > > > Hi LuKas, > > > > On Fri, Jul 20, 2018 at 01:53:35PM +0200, Lukas Tribus wrote: > > > Hello Oliver, > &g

Re: Building HAProxy 1.8 fails on Solaris

2018-07-20 Thread Olivier Houchard
Hi LuKas, On Fri, Jul 20, 2018 at 01:53:35PM +0200, Lukas Tribus wrote: > Hello Oliver, > > On Fri, 20 Jul 2018 at 11:55, Olivier Houchard > wrote: > > > > Hi, > > > > On Fri, Jul 20, 2018 at 12:22:20AM +, Thrawn wrote: > > > So...is there a way

Re: Building HAProxy 1.8 fails on Solaris

2018-07-20 Thread Olivier Houchard
ust using USE_PTHREAD_PSHARED=yes should be enough. Regards, Olivier > On Wednesday, 18 July 2018, 10:45:38 pm AEST, Olivier Houchard > wrote: > > Hi, > > On Wed, Jul 18, 2018 at 02:17:59AM +, Thrawn wrote: > > Mea culpa, I applied the patch incorrectly. After fix

Re: Building HAProxy 1.8 fails on Solaris

2018-07-18 Thread Olivier Houchard
Hi, On Wed, Jul 18, 2018 at 02:17:59AM +, Thrawn wrote: > Mea culpa, I applied the patch incorrectly. After fixing that, I can > successfully build with 'USE_THREAD=' but without 'USE_PTHREAD_PSHARED=yes' > (although from what Olivier said, I probably shouldn't do that). On > Wednesday,

Re: Building HAProxy 1.8 fails on Solaris

2018-07-17 Thread Olivier Houchard
Hi again, On Tue, Jul 17, 2018 at 01:55:33PM +0200, Olivier Houchard wrote: > Hi Lukas, > > On Tue, Jul 17, 2018 at 01:08:39PM +0200, Lukas Tribus wrote: > > On Tue, 17 Jul 2018 at 01:09, Thrawn > > wrote: > > > > > > Ah, indeed, the GCC

Re: Building HAProxy 1.8 fails on Solaris

2018-07-17 Thread Olivier Houchard
hreading will > not work with gcc 3, we did not drop support for gcc3 altogether. > > Unfortunately it is not true. __sync_* was used in include/proto/shctx.h. The attached patch uses the haproxy macroes instead, and so should get it to compile again with older gcc. Thrawn, can you please test it ? T

Re: Building HAProxy 1.8 fails on Solaris

2018-07-16 Thread Olivier Houchard
Hi, On Mon, Jul 16, 2018 at 01:12:18AM +, Thrawn wrote: > Update: If I disable threading with > USE_THREAD= > then the build gets much further, but still fails eventually with: > gcc  -g -o haproxy src/ev_poll.o ebtree/ebtree.o ebtree/eb32sctree.o > ebtree/eb32tree.o ebtree/eb64tree.o

[PATCHES] Fix a few shortcomings in the tasklet code

2018-06-14 Thread Olivier Houchard
Hi, Attached are 2 patches that fix a few bugs in the tasklet code. It should have little incidence right now because tasklets are unused, but will be useful for later work. Regards, Olivier >From fd2838a8b4eae2d9801592889285ae221fc3a7cb Mon Sep 17 00:00:00 2001 From: Olivier Houchard D

Re: haproxy-1.8.8 seamless reloads failing with abns@ sockets

2018-06-07 Thread Olivier Houchard
Hi Willy, On Thu, Jun 07, 2018 at 11:45:39AM +0200, Willy Tarreau wrote: > Hi Olivier, > > On Wed, Jun 06, 2018 at 06:40:05PM +0200, Olivier Houchard wrote: > > You're right indeed, that code was not written with abns sockets in mind. > > The attached patch should fix it

Re: haproxy-1.8.8 seamless reloads failing with abns@ sockets

2018-06-06 Thread Olivier Houchard
and ignoring abns sockets where path starts with \0 ? > > Using unix socket instead of abns socket makes the reload work. > Sorry for the late answer. You're right indeed, that code was not written with abns sockets in mind. The attached patch should fix it. It was created from mas

Re: haproxy requests hanging since b0bdae7

2018-06-06 Thread Olivier Houchard
On Wed, Jun 06, 2018 at 10:06:30AM -0400, Patrick Hemmer wrote: > > > On 2018/6/6 08:24, Olivier Houchard wrote: > > Hi Willy, > > > > On Wed, Jun 06, 2018 at 02:09:01PM +0200, Willy Tarreau wrote: > >> On Wed, Jun 06, 2018 at 02:04:35PM +0200, Olivier Houchar

Re: haproxy requests hanging since b0bdae7

2018-06-06 Thread Olivier Houchard
Hi Willy, On Wed, Jun 06, 2018 at 02:09:01PM +0200, Willy Tarreau wrote: > On Wed, Jun 06, 2018 at 02:04:35PM +0200, Olivier Houchard wrote: > > When building without threads enabled, instead of just using the global > > runqueue, just use the local runqueue associated with

Re: haproxy requests hanging since b0bdae7

2018-06-06 Thread Olivier Houchard
g with debug enabled I see just a single line: > :f1.accept(0004)=0005 from [127.0.0.1:63663] ALPN= > > commit b0bdae7b88d53cf8f18af0deab6d4c29ac25b7f9 (refs/bisect/bad) > Author: Olivier Houchard > Date: Fri May 18 18:45:28 2018 +0200 > > MAJOR: tasks: Introduc

Re: [PATCH]: MINOR :task another explicit cast

2018-06-05 Thread Olivier Houchard
Hi, On Tue, Jun 05, 2018 at 10:46:34AM +, David CARLIER wrote: > Hi, > > Did a full rebuild and caught it only. > > Regards. Oops, thanks a lot David, I hope it'll be the last one :) Willy, can you please push it ? Thanks ! Olivier

Re: error: 'all_threads_mask' undeclared (first use in this function)

2018-06-04 Thread Olivier Houchard
Hi Igor, On Mon, Jun 04, 2018 at 03:18:02PM +0300, Igor Batkanov wrote: > Hello! > I've tried to create haproxy 1.8.9 RPM package using rpmbuild and got the > folowing error: error: 'all_threads_mask' undeclared (first use in this > function) > This is a problem when building haproxy without

Re: [PATCH]: silencing compilation warning

2018-06-01 Thread Olivier Houchard
, but clang certainly does. Instead of using a static variable, I think merely adding a cast is better, as attached. What do you think ? Regards, Olivier >From 08bdd8e3b27afdd5101843f23edd337166c87159 Mon Sep 17 00:00:00 2001 From: Olivier Houchard Date: Fri, 1 Jun 2018 14:32:39 +0200 Subject:

Re: 100% cpu using resolvers with haproxy v1.8.9

2018-05-29 Thread Olivier Houchard
. > Oops you're right indeed. There's a bug in the pollers revamp that has been done recently. The attached patch should fix it. Thanks for reporting ! Olivier >From 837f376310b3077740289bc2ced1a0a97a1f964f Mon Sep 17 00:00:00 2001 From: Olivier Houchard Date: Tue, 29 May 2018 14:42:2

[PATCHES] Fix bugs in the new scheduler

2018-05-28 Thread Olivier Houchard
>From f47ca20747c1cfc7b9e6413afe9c8819a84e485a Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@haproxy.com> Date: Mon, 28 May 2018 13:51:06 +0200 Subject: [PATCH 1/3] BUG/MEDIUM: tasks: Don't forget to increase/decrease tasks_run_queue. Don't forget to increase tasks_run_queue w

Re: DNS resolver + threads, 100% cpu usage / hang 1.9dev

2018-05-23 Thread Olivier Houchard
Hi Pieter, On Tue, May 22, 2018 at 09:00:24PM +0200, PiBa-NL wrote: > Hi Olivier, > > Op 22-5-2018 om 18:46 schreef Olivier Houchard: > > Hi Pieter, > > > > Does the attached patch fix it for you ? It's been generated from master, > > but will probably apply aga

Re: DNS resolver + threads, 100% cpu usage / hang 1.9dev

2018-05-22 Thread Olivier Houchard
, you did most of the work :) I think I understand what is going on, and it's ugly as hell. Does the attached patch fix it for you ? It's been generated from master, but will probably apply against 1.8 as well. Thanks ! Olivier >From b938f86e1fe51e95adc73f9e583dd225f5ecf88d Mon Sep 17 00:0

Re: [PATCH] Make sure all the pollers get fd updates

2018-05-17 Thread Olivier Houchard
Hi, On Fri, May 04, 2018 at 05:32:24PM +0200, Olivier Houchard wrote: > Hi, > > When the code was changed to use one poller per thread, we overlooked the > fact that some fds can be shared between multiple threads, and when one > event occured, that required the fd to be added

Re: [PATCH] BUG/MEDIUM: pollers/kqueue: use incremented position in event list

2018-05-11 Thread Olivier Houchard
On Fri, May 11, 2018 at 02:09:43PM +0200, Willy Tarreau wrote: > Hi guys, > > On Fri, May 11, 2018 at 01:57:10PM +0200, Olivier Houchard wrote: > > Hi Pieter, > > > > On Thu, May 10, 2018 at 01:12:40AM +0200, PiBa-NL wrote: > > > Hi Olivier, > > >

Re: [PATCH] BUG/MEDIUM: pollers/kqueue: use incremented position in event list

2018-05-11 Thread Olivier Houchard
Hi Pieter, On Thu, May 10, 2018 at 01:12:40AM +0200, PiBa-NL wrote: > Hi Olivier, > > Please take a look at attached patch. When adding 2 fd's the second > overwrote the first one. > Tagged it medium as haproxy just didn't work at all. (with kqueue.). Though > it could perhaps also be minor, as

[PATCH] Make sure all the pollers get fd updates

2018-05-04 Thread Olivier Houchard
be, backported, so a different patch, similar in spirit, will be developed. Regards, Olivier >From 7ae6ae7215984deb4487391201e3b0f99a072c4b Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@haproxy.com> Date: Wed, 25 Apr 2018 15:10:30 +0200 Subject: [PATCH 1/4] MINOR: fd: Make the lo

Re: 1.9dev LUA shows partial results from print_r(core.get_info()) after adding headers ?

2018-05-04 Thread Olivier Houchard
crash anymore with that change. But i'm not sure > if now its leaking memory instead for some cases.. Is there a easy way to > check? > > Regards, > PiBa-NL (Pieter) > Thanks a lot for the detailed analysis. That seems spot on. We decided to do something a bit different than your proposed f

Re: Considering adding support for TCP Zero Copy

2018-05-03 Thread Olivier Houchard
Hi Pavlos, On Thu, May 03, 2018 at 12:45:42PM +0200, Pavlos Parissis wrote: > Hi, > > Linux kernel version 4.14 adds support for zero-copy from user memory to TCP > sockets by setting > MSG_ZEROCOPY flag. This is for the sending side of the socket, for the > receiving side of the socket > we

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-17 Thread Olivier Houchard
Hi again, On Tue, Apr 17, 2018 at 01:07:49PM +0200, Olivier Houchard wrote: [...] > We only need one to prevent kevent() from trying to scanning the kqueue, so > only setting kev[0] should be enough. It's inside an #ifdef because > EV_RECEIPT was only implemented recently in OpenBSD, so

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-17 Thread Olivier Houchard
Hi Pieter, On Mon, Apr 16, 2018 at 10:41:48PM +0200, PiBa-NL wrote: > Hi Olivier, > > Op 16-4-2018 om 17:09 schreef Olivier Houchard: > > After some discussion with Willy, we came with a solution that may fix your > > problem with kqueue. > > Can you test the att

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-16 Thread Olivier Houchard
Hi, On Mon, Apr 16, 2018 at 03:37:34PM +0200, Olivier Houchard wrote: > Hi Pieter, > > On Fri, Apr 13, 2018 at 06:50:50AM +, Pi Ba wrote: > > Using poll (startup with -dk) the request works properly. > > After some discussion with Willy, we came with a solution that m

Re: 1.8.7 http-tunnel doesn't seem to work? (but default http-keep-alive does)

2018-04-16 Thread Olivier Houchard
you ? Thanks ! Olivier >From 3c0a505e5f163989239ffb5267ddf7c1ed549fb9 Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@haproxy.com> Date: Mon, 16 Apr 2018 13:24:48 +0200 Subject: [PATCH] BUG/MEDIUM: When adding new events, provide an output to get errors. When adding new events

Re: HAProxy 1.8.X crashing

2018-04-13 Thread Olivier Houchard
Hi Praveen, On Fri, Apr 13, 2018 at 02:03:47PM +, UPPALAPATI, PRAVEEN wrote: > Hi Oliver, > > The crash got fixed with the patch you provided before. > > Do you thing the latest patch will be the right solution? > > Thanks, > Praveen. > It should be fine. Regards, Olivier

Re: HAProxy 1.8.X crashing

2018-04-13 Thread Olivier Houchard
the point of currently preventing us from using H2 on the backend, and > that's exactly why we're currently working on it. Ok, here is a patch that does exactly what you suggest. I'm not entirely happy with it, but it'll do the job, as a stopgap. I want this crash fixed :) Olivier >From

Re: HAProxy 1.8.X crashing

2018-04-12 Thread Olivier Houchard
Hi Willy, On Thu, Apr 12, 2018 at 08:53:51AM +0200, Willy Tarreau wrote: > Hi Olivier, > > On Wed, Apr 11, 2018 at 05:29:15PM +0200, Olivier Houchard wrote: > > From 7c9f06727cf60acf873353ac71283ff9c562aeee Mon Sep 17 00:00:00 2001 > > From: Olivier Houchard <ohouch...@ha

Re: HAProxy 1.8.X crashing

2018-04-11 Thread Olivier Houchard
ne with 1.7.x > version. > It's related to changes we made in the architecture in 1.8. The attached patch should fix it. It was made for master, but should apply to 1.8 as well. Thanks for reporting ! Olivier >From 7c9f06727cf60acf873353ac71283ff9c562aeee Mon Sep 17 00:00:00 2001 From:

[BUG][PATCH] fd: fix handling of poller updates

2018-04-03 Thread Olivier Houchard
rom 348ce4601eb92b01c098b54e7fadb9822fd8d15f Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@haproxy.com> Date: Tue, 3 Apr 2018 19:06:18 +0200 Subject: [PATCH] BUG/MINOR: fd: Don't clear the update_mask in fd_insert. Clearing the update_mask bit in fd_insert may lead to duplicate insertion of fd i

[MINOR][PATCH] Fix segfault when trying to use seemless reload with at least an interface bound

2018-03-15 Thread Olivier Houchard
uld fix it. Regards, Olivier >From b249119e571a1b5c597819701e5ec6f7d4525cf8 Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@haproxy.com> Date: Thu, 15 Mar 2018 17:48:49 +0100 Subject: [PATCH] MINOR: seemless reload: Fix crash when an interface is specified. When doing a see

Re: cppcheck finding

2018-03-08 Thread Olivier Houchard
elf. > > > > is it in purpose ? > > I suspect it's a mistake and that it was meant to be xfer_sock->prev instead. > CCing Olivier to double-check. > Oops, you're right, good catch ! The attached patch should fix it. Regards, Olivier >From 32b505d6093bad96eb4a65272bd

Re: haproxy 1.8 ssl backend server leads to server session aborts

2018-02-14 Thread Olivier Houchard
all error handling. > I'm not sure I get that part. I don't mind one way or another, but I don't understand how it would remove gotos. > BTW this makes me realize that your inverted condition above seems wrong > (|| instead of &&). > Oops, that is true, those things are too compl

Re: haproxy 1.8 ssl backend server leads to server session aborts

2018-02-13 Thread Olivier Houchard
Hi Emmanuel, On Tue, Feb 13, 2018 at 05:40:00PM +0100, Emmanuel Hocdet wrote: > Hi Olivier > > > Le 13 févr. 2018 à 15:27, Olivier Houchard <ohouch...@haproxy.com> a écrit : > > > > Thanks a lot for the detailed analyze, and sorry for the late ans

Re: haproxy 1.8 ssl backend server leads to server session aborts

2018-02-13 Thread Olivier Houchard
for the detailed analyze, and sorry for the late answer. You're probably right, SSL_ERROR_SYSCALL shouldn't be treated as an unrecoverable error. So, what you basically did was something equivalent to the patch attached ? Thanks a lot ! Olivier >From b423f94273be2c7040ce0861bd4a21617b4c5c2b Mon

[PATCH] Fix build when compiling without threads traffic

2018-01-24 Thread Olivier Houchard
Hi, Commit 1605c7ae6154d8c2cfcf3b325872b1a7266c5bc2 broke building haproxy without threads support. The attached patch should fix it. Regards, Olivier >From 17e4494874b4a75da039f06f00f668d413038283 Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@haproxy.com> Date: Wed, 24 Ja

Re: Warnings when using dynamic cookies and server-template

2018-01-23 Thread Olivier Houchard
Hi William, On Mon, Jan 22, 2018 at 08:03:55PM +0100, William Dauchy wrote: > Hello Olivier, > > On Wed, Jan 17, 2018 at 05:43:02PM +0100, Olivier Houchard wrote: > > Ok you got me convinced, the attached patch don't check for duplicate > > cookies for disabled server,

Re: Warnings when using dynamic cookies and server-template

2018-01-17 Thread Olivier Houchard
On Wed, Jan 17, 2018 at 04:42:01PM +0100, Pierre Cheynier wrote: > On 17/01/2018 15:56, Olivier Houchard wrote: > > > >> So, as a conclusion, I'm just not sure that producing this warning is > >> relevant in case the IP is duplicated for several servers *if they are >

Re: Warnings when using dynamic cookies and server-template

2018-01-17 Thread Olivier Houchard
On Wed, Jan 17, 2018 at 02:25:59PM +0100, Pierre Cheynier wrote: > Hi, > > On 16/01/2018 18:48, Olivier Houchard wrote: > > > > Not really :) That's not a case I thought of. > > The attached patch disables the generation of the dynamic cookie if the IP > > is 0.

Re: Warnings when using dynamic cookies and server-template

2018-01-16 Thread Olivier Houchard
Hi Pierre, On Tue, Jan 16, 2018 at 06:08:40PM +0100, Pierre Cheynier wrote: > Hi Olivier, > > > On 16/01/2018 15:43, Olivier Houchard wrote: > > I'm not so sure about this. > > It won't be checked again when server are enabled, so you won't get the > > warning i

Re: Warnings when using dynamic cookies and server-template

2018-01-16 Thread Olivier Houchard
Hi Pierre, On Mon, Jan 15, 2018 at 06:45:52PM +0100, Pierre Cheynier wrote: > Hello, > > We started to use the server-template approach in which you basically > provision servers in backends using a "check disabled" state, then > re-enabling them using the Runtime API. > > I recently noticed

Re: [PATCH] dns: Handle SRV record weights correctly

2018-01-09 Thread Olivier Houchard
Hi, On Tue, Jan 09, 2018 at 03:28:22PM +0100, Olivier Houchard wrote: > Hi Willy, > > On Tue, Jan 09, 2018 at 03:17:24PM +0100, Willy Tarreau wrote: > > Hi Olivier, > > > > On Mon, Jan 08, 2018 at 04:35:35PM +0100, Olivier Houchard wrote: > > > Hi, >

Re: [PATCH] dns: Handle SRV record weights correctly

2018-01-09 Thread Olivier Houchard
Hi Willy, On Tue, Jan 09, 2018 at 03:17:24PM +0100, Willy Tarreau wrote: > Hi Olivier, > > On Mon, Jan 08, 2018 at 04:35:35PM +0100, Olivier Houchard wrote: > > Hi, > > > > The attached patch attempts to map SRV record weight to haproxy weight > > correctly, &g

[PATCH] dns: Handle SRV record weights correctly

2018-01-08 Thread Olivier Houchard
>From 8e8ab23223274ac75fdf1cfe2847337133fd59d2 Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@haproxy.com> Date: Mon, 8 Jan 2018 16:28:57 +0100 Subject: [PATCH] MINOR: Handle SRV record weight correctly. A SRV record weight can range from 0 to 65535, while haproxy weight go

[PATCH] Remove rbtree.[ch]

2018-01-04 Thread Olivier Houchard
Hi guys, The rbtree implementation as found in haproxy, is currently unused, and has been for quite some time. I don't think we will need it again, so the attached patch just removes it. Regards, Olivier >From 4ce3bce732fd816a835e4896646f260f0b7e6e7c Mon Sep 17 00:00:00 2001 From: Oliv

Re: Segfault with 1.8.0 build (RHEL5, old gcc).

2017-12-07 Thread Olivier Houchard
Hi Christopher, On Wed, Dec 06, 2017 at 05:34:15PM -0800, Christopher Lane wrote: > On Mon, Dec 4, 2017 at 11:56 AM, Christopher Lane > wrote: > > > > > > > > On Mon, Dec 4, 2017 at 4:22 AM Lukas Tribus wrote: > > > >>Hello Christopher, > > > > >

Re: Segfault with 1.8.0 build (RHEL5, old gcc).

2017-12-01 Thread Olivier Houchard
lot ! Olivier >From 5236a1a4ac19cc27c6f06d328b2df0c4cdfe220c Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@haproxy.com> Date: Fri, 1 Dec 2017 22:04:05 +0100 Subject: [PATCH] MINOR: checks: Be sure we have a mux if we created a cs. In connect_conn_chk(), there were one case w

[PATCH] Make thread affinity work on FreeBSD

2017-12-01 Thread Olivier Houchard
Hi, The attached patch makes the call to pthread_setaffinity_np() work on FreeBSD. Regards, Olivier >From fc204ac3d7f9323b6583465ff5b42a0cfa46b8b1 Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@haproxy.com> Date: Fri, 1 Dec 2017 18:19:43 +0100 Subject: [PATCH] MINOR: thr

Re: [PATCH] BUG/MINOR: ssl: fix CO_FL_EARLY_DATA removal with http mode

2017-11-30 Thread Olivier Houchard
On Thu, Nov 30, 2017 at 03:32:20PM +0100, Emmanuel Hocdet wrote: > > > Le 30 nov. 2017 à 13:34, Olivier Houchard <ohouch...@haproxy.com> a écrit : > > > > Hi Emmanuel, > > > > On Thu, Nov 30, 2017 at 12:15:37PM +0100, Emmanuel Hocdet wrote: > >>

Re: [PATCH] BUG/MINOR: ssl: fix CO_FL_EARLY_DATA removal with http mode

2017-11-30 Thread Olivier Houchard
Hi Emmanuel, On Thu, Nov 30, 2017 at 12:15:37PM +0100, Emmanuel Hocdet wrote: > Hi Olivier, > > > Le 29 nov. 2017 à 19:57, Olivier Houchard <ohouch...@haproxy.com> a écrit : > > > > On Mon, Nov 27, 2017 at 06:19:41PM +0100, Emmanuel Hocdet wrote: > >>&g

Re: [PATCH] BUG/MINOR: ssl: fix CO_FL_EARLY_DATA removal with http mode

2017-11-29 Thread Olivier Houchard
a need a sample fetch to know there were early data, even after the handshake, maybe we can introduce a new sample fetch, ssl_fc_has_insecure_early, or something ? Regards, Olivier >From bda3b7800677184ea19fb81f75f9a9b44c79efeb Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@ha

Re: [PATCH] BUG/MINOR: ssl: fix CO_FL_EARLY_DATA removal with http mode

2017-11-27 Thread Olivier Houchard
Hi Emmanuel, On Mon, Nov 27, 2017 at 05:17:54PM +0100, Emmanuel Hocdet wrote: > > Hi, > > This patch fix CO_FL_EARLY_DATA removal to have correct ssl_fc_has_early > reporting. It work for 'mode http'. > > It does not fix ssl_fc_has_early for 'mode tcp'. In this mode CO_FL_EARLY_DATA > should

[PATCH] Rename the global variable "proxy" to "proxies_list" replace-header

2017-11-24 Thread Olivier Houchard
ainly come back to bite us at some point. Regards, Olivier >From da26886c44f7bd9dff656c43498664fb3518775d Mon Sep 17 00:00:00 2001 From: Olivier Houchard <ohouch...@haproxy.com> Date: Fri, 24 Nov 2017 16:54:05 +0100 Subject: [PATCH] MINOR/CLEANUP: proxy: rename "proxy" to "pr

Re: [PATCH] MINOR: ssl: Handle early data with BoringSSL

2017-11-24 Thread Olivier Houchard
Hi Willy, On Thu, Nov 23, 2017 at 07:44:13PM +0100, Willy Tarreau wrote: > On Thu, Nov 23, 2017 at 04:16:39PM +0100, Emmanuel Hocdet wrote: > > > > simplify patch: > > no need to bypass post SSL_do_handshake process, only remove > > CO_FL_EARLY_SSL_HS > > when handshake can't support early

  1   2   >