Re: [Ipmitool-devel] Sensor display logic issues

2012-02-21 Thread Jim Mankovich
Discrete, all other values Analog -- Jim Mankovich | jm...@hp.com -- On 2/21/2012 3:23 PM, Albert Chu wrote: > Hey Jim, > >> I don't see why ipmtool shouldn't rely on the "analog data format" >> being set correctly instead of making assumptions. > Generall

Re: [Ipmitool-devel] Sensor display logic issues

2012-02-22 Thread Jim Mankovich
cases where you saw 00b in the Analog (numeric) Data Format field, was the value of the entire "Sensor Unit 1" field zero? An entire 8 bit field of zero would seem to make sense for a Discrete sensor. -- Jim Mankovich |jm...@hp.com -- On 2/21/2012 4:26 PM, Albert Chu wrote: >

Re: [Ipmitool-devel] Sensor display logic issues

2012-02-23 Thread Jim Mankovich
? Thanks for you help on this, -- Jim Mankovich | jm...@hp.com -- On 2/22/2012 11:01 AM, Albert Chu wrote: > Hey Jim, > > On Wed, 2012-02-22 at 04:58 -0800, Jim Mankovich wrote: >> Al, >> >> I interpreted the ** statement as meaning the 8 bit "Sensor Units 1&qu

Re: [Ipmitool-devel] Sensor display logic issues

2012-02-23 Thread Jim Mankovich
Thanks for the info Al, much appreciated :) See my inline comments below. On 2/23/2012 12:51 PM, Albert Chu wrote: > Hey Jim, > > On Thu, 2012-02-23 at 11:01 -0800, Jim Mankovich wrote: >> Hi Al, >> >> I understand what you are saying, and your thoughts about using se

[Ipmitool-devel] ipmi_sdr_get_sensor_reading_ipmb

2012-02-24 Thread Jim Mankovich
why this change was made. struct ipmi_rs * ipmi_sdr_get_sensor_reading_ipmb(struct ipmi_intf *intf, uint8_t sensor, uint8_t target, uint8_t lun, uint8_t channel) { .. if ((strncmp(intf->name, "ipmb", 4)) != 0) return ipmi_sdr_get_sensor_reading(intf, sens

Re: [Ipmitool-devel] ipmi_sdr_get_sensor_reading_ipmb

2012-03-02 Thread Jim Mankovich
since this is the only code that calls the function. -- Jim Mankovich | jm...@hp.com -- On 2/24/2012 7:42 AM, Jim Mankovich wrote: > Hello again, > > Can someone explain why the ipmi_sdr_get_sensor_reading_ipmb routine doesn't > to set > the target_addr when not on the "

Re: [Ipmitool-devel] Correct Threshold/Discrete/Analog Display

2012-04-10 Thread Jim Mankovich
Hank, Sound like a plan, but if you can get the review done sooner that would be appreciated. Are you going to be able to do any testing in this time frame or just a code review? -- Jim Mankovich | jm...@hp.com -- On 4/9/2012 6:36 PM, Hank Bruning wrote: Please wait for three weeks while

Re: [Ipmitool-devel] unit testing in ipmitool

2012-04-10 Thread Jim Mankovich
Duncan, I can't commit to being able to submit changes for you, but I'll help out if I can. Do you have any thoughts on specific functions you think there would be value in testing? -- Jim Mankovich | jm...@hp.com -- On 4/9/2012 8:59 AM, Duncan Idaho wrote: > Hello all, > &

Re: [Ipmitool-devel] Correct Threshold/Discrete/Analog Display

2012-04-10 Thread Jim Mankovich
Hank, You can just check out the current TOB CVS version of ipmitool, apply the patch I attached to my earlier email (which has all the changes I plan on submitting to CVS), and build it on whatever system you plan on running your test from. -- Jim Mankovich | jm...@hp.com -- On 4/10/2012

Re: [Ipmitool-devel] Correct Threshold/Discrete/Analog Display

2012-04-10 Thread Jim Mankovich
Andy, Thanks for taking the time to test it out and report what you found, it is very much appreciated :) -- Jim Mankovich | jm...@hp.com -- On 4/10/2012 1:40 PM, Andy Cress wrote: Jim, I tested your patch on Intel S5520UR and S2600CO systems and it worked ok. It didn't mess any

Re: [Ipmitool-devel] Shared to Dedicated using HP IPMI

2012-04-11 Thread Jim Mankovich
Danny, I finally got a chance to look into this and I found that there not any IPMI raw commands available to change the LOM from shared to dedicated on an HP Proliant system. -- Jim Mankovich | jm...@hp.com -- On 3/20/2012 10:06 AM, i3D.net - Danny Nieuwenhuis wrote: > Hello All, > &

Re: [Ipmitool-devel] [PATCH 1/10]: Dell: Ipmitool: Base code update

2012-04-13 Thread Jim Mankovich
G, Would it be possible for you to provide some more detailed information about what these patches are implementing? -- Jim Mankovich | jm...@hp.com -- On 4/12/2012 11:38 PM, srinivas_g_go...@dell.com wrote: On 03/26/2012 10:05 PM, Gowda, Srinivas G wrote: Hi, Here is the 1st of the 10

Re: [Ipmitool-devel] [PATCH 1/10]: Dell: Ipmitool: Base code update

2012-04-13 Thread Jim Mankovich
Srinivas, These patches will not apply to 1.8.11 since lib/ipmi_delloem.c is not in the 1.8.11 release. What source bundle can these patches be applied to? -- Jim Mankovich | jm...@hp.com -- On 4/12/2012 11:38 PM, srinivas_g_go...@dell.com wrote: On 03/26/2012 10:05 PM, Gowda, Srinivas G

[Ipmitool-devel] Bug Tracker Cleanup help

2012-04-18 Thread Jim Mankovich
repository. If you know of bugs in the bug tracker that have been fixed, feel free to send me an email with bug id or bug URL and any comments you might want to add about why it is being closed. Thanks in Advance, -- -- Jim Mankovich | jm...@hp.com

Re: [Ipmitool-devel] further limitations of User ID in 'lib/ipmi_user.c'

2012-04-19 Thread Jim Mankovich
being enforced instead of just saying "Invalid user ID: %s" -- Jim Mankovich | jm...@hp.com -- On 4/18/2012 11:02 PM, Duncan Idaho wrote: On Wed, Apr 18, 2012 at 8:47 PM, Duncan Idaho mailto:dune.id...@gmail.com>> wrote: Hello all, I gave it some thought, and since IP

Re: [Ipmitool-devel] further limitations of User ID in 'lib/ipmi_user.c'

2012-04-19 Thread Jim Mankovich
) return -1; You might use user_id instead of uid to be more explicit as to the meaning. -- Jim Mankovich | jm...@hp.com -- On 4/19/2012 1:45 PM, Duncan Idaho wrote: Jim, see attached diff v2. --Duncan On Thu, Apr 19, 2012 at 7:49 PM, Jim Mankovich mailto:jm...@hp.com>> wrote: Dunca

[Ipmitool-devel] ipmitool Bugs/Patches/Enhancements Update

2012-04-23 Thread Jim Mankovich
be done, please resubmit it. Thanks in Advance, Jim -- -- Jim Mankovich | jm...@hp.com -- -- For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in

Re: [Ipmitool-devel] ipmitool Bugs/Patches/Enhancements Update

2012-04-23 Thread Jim Mankovich
he 16 character username limit sometime this week. Do you what you can with the resources you have a hand. Any/All help is much appreciated. -- Jim Mankovich | jm...@hp.com -- On 4/23/2012 12:22 PM, Duncan Idaho wrote: On Mon, Apr 23, 2012 at 6:26 PM, Jim Mankovich mailto:jm...@hp.com>

Re: [Ipmitool-devel] ipmitool Bugs/Patches/Enhancements Update

2012-04-24 Thread Jim Mankovich
regard to supported password length. This is why the submitter was able to specify a 20 character password for ipmi 1.5. Duncan, can you put together a fix for 3184687 - IPMITool allows user with more than 16 bytes password in lan? ** -- Jim Mankovich | jm...@hp.com -- On 4/24/2012 10:52 AM

Re: [Ipmitool-devel] Changes to 'lib/ipmi_lanp.c'

2012-04-24 Thread Jim Mankovich
Duncan, I reviewed these changes and they look good. Did you test all these changes? -- Jim Mankovich | jm...@hp.com -- On 4/22/2012 4:01 AM, Duncan Idaho wrote: On Fri, Apr 20, 2012 at 9:55 PM, Duncan Idaho mailto:dune.id...@gmail.com>> wrote: Hello, here is set of pr

[Ipmitool-devel] Constrain username to 16 characters

2012-04-24 Thread Jim Mankovich
&group_id=95200&atid=610550 Any/All comments appreciate Jim -- -- Jim Mankovich | jm...@hp.com -- >From d5afa560309dadd4a20e97144b38262dbe72478d Mon Sep 17 00:00:00 2001 From: Jim Mankovich Date: Tue, 24 Apr 2012 12:35:28 -0600 Subject: [PATCH] Constrain username to 16 characters

Re: [Ipmitool-devel] ipmitool Bugs/Patches/Enhancements Update

2012-04-25 Thread Jim Mankovich
tes for lanplus. The code needs to enforce this. Does this help? Jim -- Jim Mankovich | jm...@hp.com -- On 4/25/2012 2:21 PM, Duncan Idaho wrote: > On Tue, Apr 24, 2012 at 5:42 PM, Albert Chu wrote: >> On Tue, 2012-04-24 at 10:18 -0700, Duncan Idaho wrote: >>> >>> O

Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID: 3184687]

2012-04-30 Thread Jim Mankovich
using the interface is not sufficient to cover all the cases. I believe doing this correctly will require password length verification based on the current IPMI version. This patch will ca -- Jim Mankovich | jm...@hp.com -- On 4/28/2012 5:41 AM, Duncan Idaho wrote: > Jim, > > at

Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID:3184687]

2012-04-30 Thread Jim Mankovich
characters independent of the interface or IPMI version. When I looked at your changes I was thinking about password "set" verification which is why I my comments didn't make sense with regard to your changes. Sorry for the all the confusion. -- Jim Mankovich | jm...@hp.com -- On

Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID:3184687]

2012-05-01 Thread Jim Mankovich
Hank, I wasn't working on IPMI 5 years ago when this was all settled so I'm having to piece it together from bug reports on code someone else wrote and an industry standard specification.I'm just trying to help out the best I can. -- Jim Mankovich | jm...@hp.com -- On 5

Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID:3184687]

2012-05-01 Thread Jim Mankovich
Duncan, This patch looks good to me. Thanks, -- Jim Mankovich | jm...@hp.com -- On 5/1/2012 5:12 AM, Duncan Idaho wrote: > Jim, > > it is all right. Attached is v2 which covers user name longer than 16 > bytes. I've also checked the code, again, and password length res

Re: [Ipmitool-devel] Reg issue with password having 16 bytes [ID:3184687]

2012-05-01 Thread Jim Mankovich
Duncan, I attached the patch to the defect and also committed the change to TOB. I'm going to close the bug out as fixed. Thanks again, :) -- Jim Mankovich | jm...@hp.com -- On 5/1/2012 12:43 PM, Duncan Idaho wrote: > Jim, > > as it turns out, I can't attach anything t

Re: [Ipmitool-devel] Retrieving NIC information for iLO 3-based HP ProLiant DL360 G7

2012-05-11 Thread Jim Mankovich
Thilo, You can only retrieve the iLO MAC address via IPMI on Proliant platforms. The overloading of the fru Serial Number field with Host MAC address is not something that Proliant platforms implement. -- Jim Mankovich | jm...@hp.com -- On 5/11/2012 4:59 AM, Thilo-Alexander Ginkel wrote: >

Re: [Ipmitool-devel] SEL output for sensor number when zero

2012-05-18 Thread Jim Mankovich
Jon, I can't see any real reason for the special case to avoid printing zero and I don't have any problem with removing it. Does anyone have any objection to making this change? -- Jim Mankovich | jm...@hp.com -- On 5/11/2012 4:16 AM, Jon Bamber wrote: Hi There is code in

[Ipmitool-devel] ipmitool not setting the clear cmos bit

2012-05-18 Thread Jim Mankovich
patch which fixes this. I took a very simplistic approach for a fix and simply or'ed in the flags bits instead of setting them. Feel free to review and send comments. Thanks in advance, Jim -- -- Jim Mankovich | jm...@hp.com -- >From 23f48ead1af204445d86c36b691e7e8fc07e2dbc Mon Sep 17

Re: [Ipmitool-devel] [PATCH] Computation of manufacturing date in FRU display is incorrect

2012-05-30 Thread Jim Mankovich
Renzo, This change looks good to me. I'll apply the change to CVS repository unless someone has an issue with it. -- Jim Mankovich | jm...@hp.com -- On 5/29/2012 1:12 PM, Hayashi, Renzo wrote: I have identified a bug in IPMI Tool and have subsequently created a patch for it. I would

Re: [Ipmitool-devel] [PATCH 1/3] Fix delloem powermonitor on big-endian platforms.

2012-05-31 Thread Jim Mankovich
Jan, What version of ipmitool source were all these patches created from, (TOB cvs or 1.8.11 or ...)? Have you completed all your testing of these changes? Has anyone code reviewed your changes? -- Jim Mankovich | jm...@hp.com -- On 5/31/2012 4:35 AM, Jan Safranek wrote: > 'ipmitoo

Re: [Ipmitool-devel] [PATCH 1/3] Fix delloem powermonitor on big-endian platforms.

2012-06-04 Thread Jim Mankovich
1.8.11 . Thanks, -- Jim Mankovich | jm...@hp.com -- On 5/31/2012 12:48 PM, Jan Safranek wrote: > On 05/31/2012 06:07 PM, Jim Mankovich wrote: >> Jan, >> >> What version of ipmitool source were all these patches created from, (TOB >> cvs or 1.8.11 or ...)? > It

[Ipmitool-devel] Support for analog values in discrete sensors

2012-06-07 Thread Jim Mankovich
on their platforms.This patch is the final step in cleaning up the ipmitool sensor reading logic and I think this patch has value even without the code which permits reading analog values in discrete sensors on HP platforms. -- -- Jim Mankovich |jm...@hp.com -- >From 0e1ef4157f946cd27cf2db4b7

[Ipmitool-devel] Support for analog values in discrete sensors

2012-06-21 Thread Jim Mankovich
ode which permits reading analog values in discrete sensors on HP platforms. -- Jim Mankovich | jm...@hp.com -- >From 0e1ef4157f946cd27cf2db4b7993977f1c0947bd Mon Sep 17 00:00:00 2001 From: Jim Mankovich Date: Thu, 7 Jun 2012 11:35:35 -0600 Subject: [PATCH] support for analog values in di

[Ipmitool-devel] ipmitool sel list output missing event direction for Generic/OEM Eveent Types

2012-07-06 Thread Jim Mankovich
eted as an Assertion or Deassertion. I think this a bug in the sel command listing code. -- -- Jim Mankovich | jm...@hp.com -- -- Live Security Virtual Conference Exclusive live event will cover all the ways today&

[Ipmitool-devel] When to release a new version of ipmitool?

2012-07-06 Thread Jim Mankovich
nks for your Support, Jim -- -- Jim Mankovich | jm...@hp.com -- -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers

Re: [Ipmitool-devel] ipmitool sel list output missing event direction for Generic/OEM Eveent Types

2012-07-09 Thread Jim Mankovich
Hank, I'm taking about display of byte 13 in the SEL Event Record. -- Jim Mankovich | jm...@hp.com -- On 7/9/2012 8:22 AM, Hank Bruning wrote: Are to talking about bits [1:0] byte 29 in the Full sensor record and bits [7:6] in byte 24 in the Compact Sensor record ? If so it shou

[Ipmitool-devel] Resolve ipmitool compiler warnings

2012-07-30 Thread Jim Mankovich
hear that someone can take the time to review it for me. Thanks in Advance, Jim -- -- Jim Mankovich | jm...@hp.com -- >From cd463c9bd0b9bd01d210882619a68b581ca3ecc9 Mon Sep 17 00:00:00 2001 From: Jim Mankovich Date: Mon, 30 Jul 2012 12:27:49 -0600 Subject: [PATCH] Cleanup all compiler warnings E

[Ipmitool-devel] ipmitool 1.8.12 release this week

2012-08-07 Thread Jim Mankovich
ipmitool out of the cvs repository by tag and let me know if I missed anything. Please take the time to file Tracker Bugs as you find problems. Thanks in advance, Jim -- -- Jim Mankovich | jm...@hp.com -- -- Live S

Re: [Ipmitool-devel] ipmitool 1.8.12 release this week

2012-08-07 Thread Jim Mankovich
Carson, It should compile as it did before if the -W options on the CFLAGS are removed. I will remove the gcc dependent -W arguments from CFLAGS in configure.in Is there a way to get better compiler warning messages across all the compilers used to build ipmitool? Jim -- Jim Mankovich | jm

Re: [Ipmitool-devel] ipmitool 1.8.12 release this week

2012-08-07 Thread Jim Mankovich
Carson, Does 1.8.11 compile without issue on Studio compilers on Sol 11? -- Jim Mankovich | jm...@hp.com -- On 8/7/2012 2:32 PM, Carson Gaspar wrote: > The code is full of gcc-isms: > > From configure.in: > > CFLAGS="$CFLAGS -fno-strict-aliasing -Wreturn-type -Wno-unused-

Re: [Ipmitool-devel] [PATCH] add support for delloem getsysinfo/setsysinfo (store OS information to BMC)

2012-08-08 Thread Jim Mankovich
"mc" command would just have less capabilities on on non Dell platforms. Note: The interface manufacturer_id is valid as soon as the interface is successfully opened. -- Jim Mankovich | jm...@hp.com -- On 8/7/2012 10:14 PM, jordan_hargr...@dell.com wrote: > Some of the strin

Re: [Ipmitool-devel] Ipmitool-devel Digest, Vol 74, Issue 6

2012-08-08 Thread Jim Mankovich
is failing the IPMI BMC_GET_DEVICE_ID command? There are also LOG_DEBUG and LOG_ERR messages output in ipmi_get_oem() so you could turn on ipmitool output verbosity to see what is going on. -- Jim Mankovich | jm...@hp.com -- On 8/8/2012 8:50 AM, jordan_hargr...@dell.com wrote: > >> M

Re: [Ipmitool-devel] ipmitool 1.8.12 release this week

2012-08-08 Thread Jim Mankovich
s, #pragma pack could be used. -- Jim Mankovich | jm...@hp.com -- On 8/7/2012 7:19 PM, Carson Gaspar wrote: > On 8/7/12 2:54 PM, Jim Mankovich wrote: >> Carson, >> >> Does 1.8.11 compile without issue on Studio compilers on Sol 11? > No - it looks like lib/ipmi_mc.c has

Re: [Ipmitool-devel] [PATCH v2] add support for delloem getsysinfo/setsysinfo (store OS information to BMC)

2012-08-08 Thread Jim Mankovich
umber to access, 0 based. Two data blocks (32-bytes) for string data required, at least three recommended. Number of effective characters will be dependent on the encoding selected in string data byte 1." I ran into this issue when I tested your code out on an HP Proliant p

[Ipmitool-devel] ipmitool 1.8.12 is available for download

2012-08-09 Thread Jim Mankovich
he release processes and could likely have gotten something wrong. Thanks to all those who helped make this release possible Jim -- -- Jim Mankovich | jm...@hp.com -- -- Live Security Virtual Conference Exclusive live

Re: [Ipmitool-devel] [PATCH v2] Added system support to ipmievd

2012-08-13 Thread Jim Mankovich
eir init script to use "expect fork". Otherwise, init won't be monitoring the correct process and the current init script won't work correctly. -- Jim Mankovich | jm...@hp.com -- On 8/13/2012 6:44 AM, Jan Safranek wrote: Hi, instead of adding systemd code to ipmitool, I tri

Re: [Ipmitool-devel] [PATCH v2] Added system support to ipmievd

2012-08-13 Thread Jim Mankovich
Jan, I was reporting what read in the man pages for init on my Ubuntu 11.10 installation. I don't know that anyone would have a good reason for starting ipmievd directly from init (via a script in /etc/init). -- Jim Mankovich | jm...@hp.com -- On 8/13/2012 9:27 AM, Jan Safranek wrote: &g

Re: [Ipmitool-devel] [PATCH v2] Added system support to ipmievd

2012-09-04 Thread Jim Mankovich
Jan, I don't see any reason this patch should not be accepted. -- Jim Mankovich | jm...@hp.com (MST) -- On 9/4/2012 4:40 AM, Hank Bruning wrote: Guys, Zdenek asked to explain. I'm trying to understand the impact of this when scaling to 10,000+ servers. Currently a state of the

Re: [Ipmitool-devel] [BMR #80175] IPMITool PPS patches

2012-09-07 Thread Jim Mankovich
second if, intf->target_addr won't equal intf->my_addr anymore so the intf restore of target_addr/target_channel won't happen. -- Jim Mankovich | jm...@hp.com (MST) -- On 9/7/2012 6:31 AM, Dmitry Bazhenov wrote: Hello, IPMITool maintainers, On behalf of Pigeon Point Systems c

Re: [Ipmitool-devel] [BMR #80175] IPMITool PPS patches

2012-09-12 Thread Jim Mankovich
Advance, Jim -- Jim Mankovich | jm...@hp.com (MST) -- On 9/10/2012 1:48 AM, Dmitry Bazhenov wrote: > Hello, Jim, > > Thanks for you comments. > > The thing is that when doing "sdr" and "sensor" command against PICMG > systems, IPMITool tries to bridge senso

Re: [Ipmitool-devel] Add an instance to the ipmitool SOL command

2012-09-21 Thread Jim Mankovich
and instance of one when activating an SOL session. -- Jim Mankovich | jm...@hp.com -- On 9/12/2012 1:09 PM, Corey Minyard wrote: The activate payload takes and instance, and there may be times when the instance is not one. Is this patch acceptable for setting the instance for SOL sessio

Re: [Ipmitool-devel] 'Sel set time' off by an hour if executed from an exec file.

2012-09-24 Thread Jim Mankovich
All, I've attached a fix for this based on what was reported in Bug #3568976 and I verified this fix resolved the reported problem. If no one has an problem with this fix, I'll commit the change to TOB at the end of this week. Thanks in Advance, Jim -- Jim Mankovich | jm...@h

Re: [Ipmitool-devel] 'Sel set time' off by an hour if executed from an exec file.

2012-09-25 Thread Jim Mankovich
Z, Your changes cover the cases where missing initialization would result in the use of random values, so this patch is preferable to mine. Let me know if you need me to submit the changes for you or if you will be able to do it yourself. Thanks, Jim -- Jim Mankovich | jm...@hp.com (MST

Re: [Ipmitool-devel] [BMR #80175] IPMITool PPS patches

2012-10-10 Thread Jim Mankovich
Dmitry, I'll take a look at these changes and get you feedback by the end of this week, or early next week. Could someone else please take a look at these changes as well? -- Jim Mankovich | jm...@hp.com (MST) -- On 10/10/2012 12:45 AM, Dmitry Bazhenov wrote: > Hello, Jim, > >

Re: [Ipmitool-devel] [BMR #80175] IPMITool PPS patches

2012-10-11 Thread Jim Mankovich
e text, but not as a Copyright and why does serial_terminal.c have a 2003 Sun Copyright? Where these files derived from Sun source code in some way? Neither hpm2.c nor hpm2.h references Sun Copyrights. Thanks for the contributions, Jim -- Jim Mankovich |jm...@hp.com (MST) -- On 10/1/2

Re: [Ipmitool-devel] code analysis

2013-01-04 Thread Jim Mankovich
8.13? What do you mean when you say you are going to release the report to the "public" with "the patch"? -- Jim Mankovich | jm...@hp.com (MST) -- On 1/4/2013 8:06 AM, Ales Ledvinka wrote: > Hello, > > I just joined the team. I have here the ipmitool Fedora 19 rawhid

Re: [Ipmitool-devel] code analysis

2013-01-04 Thread Jim Mankovich
o be fixed. -- Jim Mankovich | jm...@hp.com (MST) -- On 1/4/2013 10:17 AM, Zdenek Styblik wrote: > On Fri, Jan 4, 2013 at 5:48 PM, Ales Ledvinka wrote: >>> I don't know how much I can help with the >>> fixing, but if I have >>> time I'll do what I can. >&

[Ipmitool-devel] ipmitool OpenIPMI Interface and bridging

2013-02-19 Thread Jim Mankovich
? Thanks in Advance, Jim -- -- Jim Mankovich | jm...@hp.com -- -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb

Re: [Ipmitool-devel] ipmitool OpenIPMI Interface and bridging

2013-02-20 Thread Jim Mankovich
a default of 0x20 instead of zero. This bridging to 0x20 from 0x54 when you only specify -m 0x54 on the command line has caused confusion for more than one person. -- Jim Mankovich | jm...@hp.com -- On 2/19/2013 5:59 PM, Corey Minyard wrote: > So you are saying that if you set the local addr

Re: [Ipmitool-devel] Cannot read the SDR list for ATCA boards

2013-02-21 Thread Jim Mankovich
Didier, Definitely use 1.8.12 and also add -vv to the command line to get some debugging output as to how the sensors are being addressed. -- Jim Mankovich | jm...@hp.com -- On 2/21/2013 5:44 AM, Zdenek Styblik wrote: > On Thu, Feb 21, 2013 at 1:35 PM, JOONEKINDT Didier > wrote: >

Re: [Ipmitool-devel] Cannot read the SDR list for ATCA boards

2013-02-25 Thread Jim Mankovich
Daniel, Glad to hear it is working with 1.8.12. If you run into any other issues please let us know. Thanks, Jim -- Jim Mankovich | jm...@hp.com -- On 2/25/2013 9:27 AM, Daniel.Ertel wrote: > FYR: > Working fine with 1.8.12 and PPS ShM 2.8.2 ( I do not have 2.7.0.2 to double &

Re: [Ipmitool-devel] I confuse one thing about "boot info acknowledge" of System Boot Options Command

2013-02-25 Thread Jim Mankovich
lan, It looks correct to me. Why do you believe it does not match the IPMI spec. The spec states bit 0 is BIOS/POST has handled boot info and the code look at bit 0 by using a mask of 0x1 == 0x1 -- Jim Mankovich | jm...@hp.com -- On 2/25/2013 2:03 AM, 國剛 曾 wrote: Dear all, I confuse one

Re: [Ipmitool-devel] I confuse one thing about "boot info acknowledge" of System Boot Options Command

2013-02-26 Thread Jim Mankovich
All, You guys are right, it should be checking the bits for zero and not one. I had only verified that it was looking at the right bits. -- Jim Mankovich | jm...@hp.com (MST) -- On 2/26/2013 6:56 AM, Zdenek Styblik wrote: > And actually if you convert 0x10, 0x08 etc. into binary you can

Re: [Ipmitool-devel] ipmitool OpenIPMI Interface and bridging

2013-02-26 Thread Jim Mankovich
same IPMB address to actually accomplish setting only the local IPMB address. Thanks, Jim -- Jim Mankovich | jm...@hp.com -- On 2/20/2013 7:41 AM, Jim Mankovich wrote: > Corey, > > When you specify -m 0x54 and -t 0x54 on the ipmitool command line, the > message will > be corr

Re: [Ipmitool-devel] ipmitool OpenIPMI Interface and bridging

2013-02-27 Thread Jim Mankovich
IPMB using address 0x34 (no bridging). This is what the man page says it should do. From f8f354de4c4e1910acafc697915ecf2731c41af8 Mon Sep 17 00:00:00 2001 From: Jim Mankovich Date: Wed, 27 Feb 2013 07:31:41 -0700 Subject: [PATCH] only bridge when -t specified --- ipmitool/src/plugins/open

Re: [Ipmitool-devel] Code Review - ID: 3600911 - 'lib/ipmi_fru.c' - re-work of ipmi_fru_get_multirec_from_file()

2013-03-08 Thread Jim Mankovich
Z, You don't need to make sure pFile is not NULL prior to the fclose() in the if (fseek(pFile,offset...) block since you already checked this above. This is on line 44 in your patch file. -- Jim Mankovich | jm...@hp.com -- On 3/8/2013 12:08 AM, Zdenek Styblik wrote: Hi all, attached

Re: [Ipmitool-devel] Code Review - ID: 3600926 - 'lib/ipmi_lanp.c' - check LAN param

2013-03-12 Thread Jim Mankovich
Z, The patch looks good to me. It certainly fixes the reported problem. -- Jim Mankovich | jm...@hp.com (MST) -- On 3/8/2013 1:45 PM, Zdenek Styblik wrote: > Hello all, > > attached is a diff of proposed change to 'lib/ipmi_lanp.c'. This bug > has been reported by Ales

Re: [Ipmitool-devel] Contributing patches back to ipmitool

2013-03-18 Thread Jim Mankovich
simply reference the tracker request. This is generally what I have done in the past for fairly straight forward changes. Any one else want to chime in on this? Thanks for you interest in helping, Jim -- Jim Mankovich | jm...@hp.com -- On 3/18/2013 1:34 PM, Dan Gora wrote: > Hi All, >

Re: [Ipmitool-devel] [PATCH 3/3] Remove -Wno-unused-result flag from CFLAGS.

2013-04-01 Thread Jim Mankovich
;, declared with attribute warn_unused_result [-Wunused-result] ipmi_ekanalyzer.c:2742:16: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result] ipmi_ekanalyzer.c:2745:19: warning: ignoring return value of 'fread', declared with a

Re: [Ipmitool-devel] [PATCH 3/3] Remove -Wno-unused-result flag from CFLAGS.

2013-04-01 Thread Jim Mankovich
Fom my perspective, cleaning up the errors to remove the need for -Wno-unused-return would be best. But, I wouldn't spend a lot of time writing code and tests to deal with handling all possible errors from the system calls. -- Jim Mankovich | jm...@hp.com (MST) -- On 4/1/2013 1:20 PM

Re: [Ipmitool-devel] [PATCH] Fixed bug where PICMG Get Device Locator was never run.

2013-04-04 Thread Jim Mankovich
Z, I've been working on ipmitool bridging issues and ran across the same issue as Dan, so his fix to always run the PICMG discovery code whenever -m is not specified is just fine with me. -- Jim Mankovich | jm...@hp.com (MST) -- On 4/4/2013 7:35 AM, Zdenek Styblik wrote: > On Fri

Re: [Ipmitool-devel] [PATCH] Fixed bug where PICMG Get Device Locator was never run.

2013-04-04 Thread Jim Mankovich
I would advocate always using tab for indentation. Then you can change it to be any number of spaces in your editor. This is what I generally do, and for many of the files in ipmitool I set my editor to have a tab stop of 4 so that the lines don't wrap. -- Jim Mankovich | jm...@hp.com

Re: [Ipmitool-devel] [PATCH] Fixed bug where PICMG Get Device Locator was never run.

2013-04-04 Thread Jim Mankovich
I don't have any problem with the code formatting. I personally leave code formatting alone in ipmitool for any code I don't explicitly need to make a functional change to. -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/4/2013 2:40 PM, Dan Gora wrote: > On Thu, Apr 4,

Re: [Ipmitool-devel] [PATCH] Fixed bug where PICMG Get Device Locator was never run.

2013-04-04 Thread Jim Mankovich
Dan, My intent was to say that I did not have any problem with the change you made to re-format the code. I think following the linux kernel coding style is the right way to go. -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/4/2013 3:09 PM, Dan Gora wrote: > On Thu, Apr 4, 2013

[Ipmitool-devel] ipmitool bridging on PICMG systems

2013-04-15 Thread Jim Mankovich
itory. I have some ipmitool changes in the works which resolve the sensor bridging issue I've described, but I need some insight from someone more familiar with PICMG and sensor bridging to make sure my analysis of the problem I'm seeing is correct. Thanks in advance, Jim -- -- Jim Mank

Re: [Ipmitool-devel] ipmitool bridging on PICMG systems

2013-04-15 Thread Jim Mankovich
and store that away to determine when bridging is necessary for sensors identified in the SDR repository accessed via the bridging command line arguments. Thanks, Jim -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/15/2013 9:05 AM, Dmitry Bazhenov wrote: Hello, Jim, Your understan

Re: [Ipmitool-devel] ipmitool bridging on PICMG systems

2013-04-16 Thread Jim Mankovich
Dmitry, See my comments below. Thanks, Jim -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/15/2013 11:01 PM, Dmitry Bazhenov wrote: > Hello, Jim, > > Your approach has technical and logical flaws. > > In technical part, all interface drivers shall be ensured to u

Re: [Ipmitool-devel] ipmitool bridging on PICMG systems

2013-04-17 Thread Jim Mankovich
change how sensors are addressed via bridging on non PICMG platforms. Thanks in Advance, Jim -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/16/2013 11:58 PM, Dmitry Bazhenov wrote: Hello, Jim, Please, see my comments mixed in. 17.04.2013 2:21, Jim Mankovich пишет: Dmitry, See

Re: [Ipmitool-devel] [BMR #80175] IPMITool PPS patches

2013-04-17 Thread Jim Mankovich
with reviews and submissions as I find the time to do so. Thanks for helping out, Jim -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/17/2013 11:24 AM, Dmitry Bazhenov wrote: > Hello, Jim, > > I would like to revive our conversation from the last year and submit a > coupl

Re: [Ipmitool-devel] 1.8.13?

2013-04-22 Thread Jim Mankovich
Ales, I think it would be good to get a 1.8.13 released sometime soon. My only interest at this point is to get my bridging change committed prior to releasing 1.8.13. Any thoughts from others on changes they would want in the next release? -- Jim Mankovich | jm...@hp.com (US Mountain Time

Re: [Ipmitool-devel] [PATCH] Update ipmitool to fix fru output.

2013-04-22 Thread Jim Mankovich
I fully agree with Dan in that there is no good reason to change existing indentation for code. It simply obfuscates real changes and makes application of patches problematic. -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/22/2013 11:11 AM, Dan Gora wrote: > On Mon, Apr 22, 2

Re: [Ipmitool-devel] ipmitool bridging on PICMG systems

2013-04-24 Thread Jim Mankovich
ions, but I'm sure I missed something. Let me know if you need more clarification or details. Thanks for help testing this out, Jim -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/23/2013 7:47 PM, Dan Gora wrote: > Hi guys, > > I'm working on coming up with a set of

Re: [Ipmitool-devel] ipmitool bridging on PICMG systems

2013-04-24 Thread Jim Mankovich
Dmitry, See below, -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/19/2013 12:47 AM, Dmitry Bazhenov wrote: > Hello, Jim, > > Unfortunately, we can not change my_addr after discovering that the IPMC > address on the primary IPMB is different from what was used to connect

Re: [Ipmitool-devel] ipmitool bridging on PICMG systems

2013-04-25 Thread Jim Mankovich
eally think I have the time to do this for every test case. Thanks, Jim -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/24/2013 12:27 PM, Dan Gora wrote: > On Wed, Apr 24, 2013 at 12:52 PM, Jim Mankovich wrote: > >> The first major difference between TOB (What you call CVS R

Re: [Ipmitool-devel] ipmitool bridging on PICMG systems

2013-04-25 Thread Jim Mankovich
didn't make any difference in success or failure when used in conjunction with a target address (-t). This is not the case when not doing bridging. -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/25/2013 7:24 AM, Dmitry Bazhenov wrote: > Hello, Jim, > > I need to thi

[Ipmitool-devel] Completed ipmitool bridging changes

2013-05-01 Thread Jim Mankovich
The bug report and associated patch are available at the following URL: http://sourceforge.net/tracker/?func=detail&aid=3611226&group_id=95200&atid=610550 -- -- Jim Mankovich | jm...@hp.com

[Ipmitool-devel] ipmitool 1.8.13 release proposal

2013-07-17 Thread Jim Mankovich
, Jim -- -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks

[Ipmitool-devel] ipmitool 1.8.13 release

2013-08-06 Thread Jim Mankovich
All, I would like to start the 1.8.13 release process this week.Are there any pending changes that you feel I should wait for before creating the first release candidate tar bundle? Thanks in Advance, Jim -- --- Jim Mankovich | jm...@hp.com (US Mountain Time

[Ipmitool-devel] ipmitool 1.8.13rc0 release is available

2013-08-15 Thread Jim Mankovich
1.8.13rc0. I've attached the ipmitool ChangeLog file for 1.8.13rc0 so you get see what we have been working on since the 1.8.12 release. Thanks for all your help, Jim -- --- Jim Mankovich | jm...@hp.com (US Mountain Time) ---All version 1.8.13rc0 2013-08-15 * ID: 3611905 - Direct S

[Ipmitool-devel] ipmitool 1.8.13rc1 release is available

2013-08-26 Thread Jim Mankovich
if there are no defects filed against 1.8.13rc0 or 1.8.13rc1, what is in rc1 will become the released bits for 1.8.13 in early September. Thanks, Jim -- --- Jim Mankovich | jm...@hp.com (US Mountain Time

[Ipmitool-devel] ipmitool 1.8.13 is available

2013-09-09 Thread Jim Mankovich
m the following sourceforge.net repository. https://sourceforge.net/projects/ipmitool/files/ipmitool/1.8.13/ Please file Bug, Patches, or Feature requests as the need to do so arises. Thanks to everyone for their help with ipmitool, Jim -- --- Jim Mankovich | jm...@hp.com (US Mountain

Re: [Ipmitool-devel] Bridged sensor read doesn't work in 1.8.13, works ok in 1.8.11

2013-09-20 Thread Jim Mankovich
e not the intended recipient, you are hereby notified that any disclosure, >> copying, distribution and / or the taking of any action based upon reliance >> on the contents of this transmission is strictly forbidden. If you have >> received this message in error please notify the

Re: [Ipmitool-devel] I need information .

2013-12-02 Thread Jim Mankovich
/gampad/clk?id=84349351&iu=/4140/ostg.clktrk ___ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel -- --- Jim Mankovich | jm...@hp.com (US Mountain Time) --- ---

Re: [Ipmitool-devel] ipmiutil error message

2013-12-04 Thread Jim Mankovich
d/clk?id=111408631&iu=/4140/ostg.clktrk ___ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel -- --- Jim Mankovich | jm...@hp.com (US M

Re: [Ipmitool-devel] Checking ipmitool using Coverity?

2014-01-08 Thread Jim Mankovich
gt; Is the Coverity scanning something that should be done regularly? > Anyone interested in spending time tracking down the issues detected by > it? > > > -- > --- Jim Mankovich | jm...@hp.com (US Mountain Time) --- --

Re: [Ipmitool-devel] Checking ipmitool using Coverity?

2014-01-08 Thread Jim Mankovich
; Sebastien Bouchard, me and jman have access to the scan result, and > Sebastien Bouchard and me can submit new builds. > > > -- > --- Jim Mankovich | jm...@hp.com (US Mountain Time) --- -- Rapidly troubleshoot prob

Re: [Ipmitool-devel] Convert CVS to Git - lets get started

2014-01-15 Thread Jim Mankovich
d to sourceforge and > the CVS repo is thrown away. I plan to drop the github repo when > sourceforge become the authorative source. Any objections? > > > -- > --- Jim Mankovich | jm...@hp.com (US Mountain Time) --- ---

Re: [Ipmitool-devel] Convert CVS to Git - lets get started

2014-01-31 Thread Jim Mankovich
from the subdirectory ipmitool/ in git to the > root of the repository? > > > -- > --- Jim Mankovich | jm...@hp.com (US Mountain Time) --- -- WatchGuard Dimension instantly turns raw network data into acti

  1   2   >