Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2441
LGTM
---
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2441
retest sdv please
---
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2441
LGTM
---
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2511
LGTM
---
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2529
LGTM
---
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2513
LGTM
Build failed due to CI server problem
---
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2529#discussion_r203754026
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java
---
@@ -355,16 +361,33 @@ public BigDecimal
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2529#discussion_r203753043
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java
---
@@ -201,12 +201,18 @@ public void putDouble
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2529#discussion_r203750816
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeFixLengthColumnPage.java
---
@@ -431,6 +439,15 @@ private void
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2487
LGTM
---
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2513#discussion_r203414767
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -253,15 +257,39
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2513#discussion_r203414480
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -355,6 +383,14
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r203061344
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonRDD.scala
---
@@ -79,14 +66,11 @@ abstract class CarbonRDD[T
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r203057588
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonConfiguration.java ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r203050151
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -43,11 +45,19 @@
*/
private static
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2513#discussion_r202983275
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -253,14 +253,16
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2513#discussion_r202973884
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataGeneral.scala
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2496#discussion_r202971224
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonComplexTypeRule.scala
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2472
LGTM
---
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2487#discussion_r202321022
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -201,31 +209,32 @@ private static
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2487#discussion_r202320940
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -175,24 +182,25 @@ private static
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2487#discussion_r202319613
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeVarLengthColumnPage.java
---
@@ -40,6 +40,7 @@
@Override
GitHub user gvramana opened a pull request:
https://github.com/apache/carbondata/pull/2496
[CARBONDATA-2737][WIP] Complex type filter as projection push down
select a.c from table1 where a.b = 10;
select a.c from table1 order by a.b;
These cases a.b needs to be pushed
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2354
LGTM
---
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r201614265
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonRDD.scala
---
@@ -46,18 +46,12 @@ abstract class CarbonRDD[T
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2484#discussion_r201612604
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala
---
@@ -262,9 +223,9 @@ class
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2472#discussion_r201610274
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/CarbonLockUtil.java ---
@@ -121,8 +124,11 @@ public static void
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2366
Merged to "carbonstore" branch.
---
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2366
LGTM
---
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2417
LGTM
---
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200992646
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200991672
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200989973
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java
---
@@ -870,4 +873,23 @@ private static void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200989677
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java
---
@@ -93,9 +93,9 @@ public PrimitiveQueryType
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200986348
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -147,10 +160,48 @@ protected void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200985673
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -147,10 +160,48 @@ protected void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200985232
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -147,10 +160,48 @@ protected void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200984983
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -147,10 +160,48 @@ protected void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200967561
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ComplexColumnPage.java
---
@@ -63,25 +66,42 @@ public ComplexColumnPage(List
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200964076
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -141,7 +141,7 @@ private static ColumnPage
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200962872
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200938152
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200935214
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200932526
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200931266
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -53,11 +60,75 @@ public int fillVector
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r200927005
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -17,32 +17,39 @@
package
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2420
LGTM
---
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2406
LGTM
---
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2354#discussion_r200345615
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonDataMergerUtil.java
---
@@ -1218,11 +1217,8 @@ public static boolean
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2354#discussion_r200331203
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -261,8 +261,6 @@ public static ColumnGroupModel getColGroupModel
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r200321640
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/StreamHandoffRDD.scala
---
@@ -163,10 +164,13 @@ class
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200246477
--- Diff:
processing/src/test/java/org/apache/carbondata/lcm/locks/LocalFileLockTest.java
---
@@ -68,4 +80,18 @@
Assert.assertTrue
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200245816
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -386,7 +386,8 @@ class CarbonFileMetastore
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2406#discussion_r200239066
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/S3CarbonFile.java
---
@@ -0,0 +1,146 @@
+/*
+ * Licensed
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200234399
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/BadRecordsLoggerProvider.java
---
@@ -92,13 +90,7 @@ public static String
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200234454
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonHiveMetaStore.scala
---
@@ -158,13 +158,11 @@ class CarbonHiveMetaStore
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200234535
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala ---
@@ -107,19 +107,10 @@ object AlterTableUtil
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200237355
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java
---
@@ -378,8 +377,14 @@ private static void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200155277
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModelBuilder.java
---
@@ -72,6 +72,28 @@ public
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200151855
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala
---
@@ -255,6 +256,29 @@ object
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2420#discussion_r200150569
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
---
@@ -345,14 +346,18 @@ public static CarbonLoadModel
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2391#discussion_r200024653
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
---
@@ -81,8 +83,16 @@ public
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2391#discussion_r200014323
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/SDKDetailQueryExecutor.java
---
@@ -0,0 +1,87 @@
+/*
+ * Licensed
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2434#discussion_r200014195
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -121,6 +122,7 @@ public static CarbonReaderBuilder builder
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2391#discussion_r199848776
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/SDKDetailQueryExecutor.java
---
@@ -0,0 +1,87 @@
+/*
+ * Licensed
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2391#discussion_r199847207
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
---
@@ -81,8 +83,16 @@ public
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r199482930
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java
---
@@ -161,14 +174,16 @@ private static
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r199481217
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -77,14 +127,70 @@ public boolean
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2417#discussion_r199481192
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java
---
@@ -30,32 +40,72 @@ public ColumnPageWrapper
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195980220
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/streaming/CarbonStreamRecordReader.java
---
@@ -71,15 +72,10 @@
import
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195976603
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
---
@@ -126,9 +126,9 @@ object
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195975666
--- Diff: pom.xml ---
@@ -582,6 +582,59 @@
+
--- End diff --
Check if any method to make
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195972758
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
---
@@ -1787,20 +1839,23 @@ case class
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195971582
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/sql/commands/StoredAsCarbondataSuite.scala
---
@@ -87,7 +87,7 @@ class
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195971259
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/bigdecimal/TestBigDecimal.scala
---
@@ -149,8 +149,9
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195970266
--- Diff: examples/spark2/pom.xml ---
@@ -204,5 +204,35 @@
true
+
+ spark-2.3
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195969282
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -355,18 +362,19 @@ private
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195968598
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
---
@@ -140,6 +142,13 @@ object
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195968507
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
---
@@ -65,7 +66,7 @@ object
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2366#discussion_r195968291
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/streaming/CarbonStreamRecordReader.java
---
@@ -115,7 +109,7
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2319
LGTM
---
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2328#discussion_r189778004
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/stream/CarbonCreateStreamSourceCommand.scala
---
@@ -0,0 +1,50
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2328#discussion_r189615740
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/stream/CarbonShowStreamsCommand.scala
---
@@ -0,0 +1,74
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2328#discussion_r189606530
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/stream/StreamJobManager.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2319#discussion_r189547319
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/datatype/ArrayType.java
---
@@ -52,11 +56,12 @@ public boolean equals(Object obj
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2319#discussion_r189549116
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/datatype/StructField.java
---
@@ -54,4 +54,41 @@ public String getFieldName
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/2313
LGTM
---
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189239307
--- Diff:
store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java
---
@@ -100,8 +100,9 @@ public ShutdownResponse
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189239156
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/store/LocalCarbonStore.java ---
@@ -102,6 +107,11 @@
while (reader.nextKeyValue
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189180538
--- Diff:
integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java
---
@@ -144,14 +145,10
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189175211
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonLocalInputSplit.java
---
@@ -115,23 +115,26 @@ public void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189174422
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
@@ -77,13 +77,15 @@ private static void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189166315
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
---
@@ -348,32 +348,37 @@ public boolean
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r189165438
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/AbstractDataFileFooterConverter.java
---
@@ -60,7 +60,11 @@
*/
private
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188992675
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java
---
@@ -98,9 +98,11
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188972300
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/CarbonDictionaryMetadataReaderImpl.java
---
@@ -128,6 +131,9 @@ public
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188969041
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalType.java
---
@@ -44,4 +44,35 @@ public int getScale
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188965798
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/datatype/ArrayType.java
---
@@ -31,6 +31,31 @@ public boolean isComplexType
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188960024
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -152,14 +152,15 @@ public synchronized boolean
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2313#discussion_r188906834
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -282,12 +282,15 @@ private void
1 - 100 of 385 matches
Mail list logo
