[GitHub] [flink] lirui-apache commented on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog

lirui-apache commented on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog URL: https://github.com/apache/flink/pull/8616#issuecomment-498946674 LGTM, thanks.

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290584736 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290584058 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290582852 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290579108 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module.

KurtYoung commented on a change in pull request #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module. URL: https://github.com/apache/flink/pull/8294#discussion_r290578406 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290577508 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290576941 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290576205 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290565250 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290575834 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290575554 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290569286 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290567350 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568068 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568801 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568259 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568669 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568945 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575983 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290567916 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568761 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

KurtYoung commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r290568189 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575541 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575541 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575250 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575205 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290575052 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290574817 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290574645 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290574532 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290574315 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290573784 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290573391 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290573231 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290572726 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290572426 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290572212 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290572080 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290572037 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290571983 ## File path:

[jira] [Commented] (FLINK-9465) Separate timeout for savepoint and checkpoint

[ https://issues.apache.org/jira/browse/FLINK-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856306#comment-16856306 ] vinoyang commented on FLINK-9465: - [~kien_truong] About the savepoint timeout config option, I think it

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290571947 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290571622 ## File path:

[jira] [Updated] (FLINK-12734) remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment

[ https://issues.apache.org/jira/browse/FLINK-12734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-12734: --- Description: there are two improvements: 1. remove {{getVolcanoPlanner}} method from

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290571356 ## File path:

[GitHub] [flink] flinkbot commented on issue #8619: [FLINK-12734] [table-planner-blink] remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment

flinkbot commented on issue #8619: [FLINK-12734] [table-planner-blink] remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment URL: https://github.com/apache/flink/pull/8619#issuecomment-498926318 Thanks a lot for your contribution to

[jira] [Updated] (FLINK-12734) remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment

[ https://issues.apache.org/jira/browse/FLINK-12734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12734: --- Labels: pull-request-available (was: ) > remove getVolcanoPlanner method from

[GitHub] [flink] godfreyhe opened a new pull request #8619: [FLINK-12734] [table-planner-blink] remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvir

godfreyhe opened a new pull request #8619: [FLINK-12734] [table-planner-blink] remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment URL: https://github.com/apache/flink/pull/8619 ## What is the purpose of the change

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290570744 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290570600 ## File path:

[jira] [Commented] (FLINK-12733) Expose Rest API for TERMINATE/SUSPEND Job with Checkpoint

[ https://issues.apache.org/jira/browse/FLINK-12733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856296#comment-16856296 ] vinoyang commented on FLINK-12733: -- [~klion26] I think it would be better to discuss and agree on the

[jira] [Created] (FLINK-12734) remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment

godfrey he created FLINK-12734: -- Summary: remove getVolcanoPlanner method from FlinkOptimizeContext and RelNodeBlock does not depend on TableEnvironment Key: FLINK-12734 URL:

[GitHub] [flink] carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint

carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint URL: https://github.com/apache/flink/pull/8617#discussion_r290561763 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint

carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint URL: https://github.com/apache/flink/pull/8617#discussion_r290567794 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint

carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint URL: https://github.com/apache/flink/pull/8617#discussion_r290563567 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint

carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint URL: https://github.com/apache/flink/pull/8617#discussion_r290567687 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290568555 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290568168 ## File path:

[jira] [Assigned] (FLINK-12662) show jobs failover in history server as well

[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12662: Assignee: vinoyang > show jobs failover in history server as well >

[jira] [Commented] (FLINK-12662) show jobs failover in history server as well

[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856289#comment-16856289 ] vinoyang commented on FLINK-12662: -- Thanks [~till.rohrmann] for approving this issue. and thanks

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290567675 ## File path:

[GitHub] [flink] lirui-apache commented on issue #8610: [FLINK-12715][hive] Hive-1.2.1 build is broken

lirui-apache commented on issue #8610: [FLINK-12715][hive] Hive-1.2.1 build is broken URL: https://github.com/apache/flink/pull/8610#issuecomment-498921767 I also prefer to keep HiveShim generic. Actually APIs in HiveShim like `getViews` and `getFunction` take a `IMetaStoreClient` as

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290567322 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290567072 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface

zhijiangW commented on a change in pull request #8608: [FLINK-11392][network] Introduce ShuffleEnvironment interface URL: https://github.com/apache/flink/pull/8608#discussion_r290566895 ## File path:

[GitHub] [flink] Aitozi commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

Aitozi commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8280#issuecomment-498920811 One way to my mind: set the scattered `clean()` method with the `TOP_LEVEL` to keep the old way, And set

[GitHub] [flink] Aitozi edited a comment on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

Aitozi edited a comment on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8280#issuecomment-498756627 I know you mean, and I think it's hard to config the scattered `clean()` used in functions like `connector`,

[GitHub] [flink] JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#discussion_r290563675 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#discussion_r290565276 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#discussion_r290564818 ## File path:

[GitHub] [flink] Aitozi removed a comment on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

Aitozi removed a comment on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8280#issuecomment-498759646 I think it over again, it can be removed directly. And after this the clean method should not be directly used,

[GitHub] [flink] JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#discussion_r290564411 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner

JingsongLi commented on a change in pull request #8578: [FLINK-12685] [table-planner-blink] Supports UNNEST query in blink planner URL: https://github.com/apache/flink/pull/8578#discussion_r290563400 ## File path:

[jira] [Commented] (FLINK-12662) show jobs failover in history server as well

[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856278#comment-16856278 ] Su Ralph commented on FLINK-12662: -- Thanks [~till.rohrmann]. That's good as well, and probably better.

[jira] [Commented] (FLINK-9465) Separate timeout for savepoint and checkpoint

[ https://issues.apache.org/jira/browse/FLINK-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856276#comment-16856276 ] vinoyang commented on FLINK-9465: - [~till.rohrmann] thanks for approving this issue, I am going to start

[GitHub] [flink] sunjincheng121 commented on issue #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API

sunjincheng121 commented on issue #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API URL: https://github.com/apache/flink/pull/8550#issuecomment-498913495 Since the execution mode of the Stream operator has two

[GitHub] [flink] tzulitai commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state

tzulitai commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state URL: https://github.com/apache/flink/pull/8618#issuecomment-498912234 @flinkbot approve description @flinkbot approve consensus

[GitHub] [flink] tzulitai commented on issue #8615: [FLINK-12729][state-processor-api] Add state reader for consuming non-partitioned operator state

tzulitai commented on issue #8615: [FLINK-12729][state-processor-api] Add state reader for consuming non-partitioned operator state URL: https://github.com/apache/flink/pull/8615#issuecomment-498911292 @flinkbot approve description @flinkbot approve consensus

[jira] [Commented] (FLINK-12709) Implement RestartBackoffTimeStrategyFactoryLoader

[ https://issues.apache.org/jira/browse/FLINK-12709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856258#comment-16856258 ] Zhu Zhu commented on FLINK-12709: - Thanks [~rmetzger]. Sorry for missing setting the related

[GitHub] [flink] carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint

carp84 commented on a change in pull request #8617: [FLINK-12619][StateBackend]Support TERMINATE/SUSPEND Job with Checkpoint URL: https://github.com/apache/flink/pull/8617#discussion_r290559979 ## File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java

[jira] [Commented] (FLINK-12608) Add getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultPartitionID) to SchedulingTopology

[ https://issues.apache.org/jira/browse/FLINK-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856241#comment-16856241 ] BoWang commented on FLINK-12608: OK, thanks [~rmetzger]. > Add >

[jira] [Updated] (FLINK-12608) Add getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultPartitionID) to SchedulingTopology

[ https://issues.apache.org/jira/browse/FLINK-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BoWang updated FLINK-12608: --- Affects Version/s: 1.9.0 > Add >

[jira] [Updated] (FLINK-12608) Add getVertex/ResultPartitionOrThrow(ExecutionVertexID/IntermediateResultPartitionID) to SchedulingTopology

[ https://issues.apache.org/jira/browse/FLINK-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BoWang updated FLINK-12608: --- Fix Version/s: 1.9.0 > Add >

[jira] [Created] (FLINK-12733) Expose Rest API for TERMINATE/SUSPEND Job with Checkpoint

Congxian Qiu(klion26) created FLINK-12733: - Summary: Expose Rest API for TERMINATE/SUSPEND Job with Checkpoint Key: FLINK-12733 URL: https://issues.apache.org/jira/browse/FLINK-12733 Project:

[GitHub] [flink] xuefuz commented on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog

xuefuz commented on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog URL: https://github.com/apache/flink/pull/8616#issuecomment-498877524 Thanks for the contribution. I have a couple of high-level comments:

[jira] [Comment Edited] (FLINK-12383) "Log file environment variable 'log.file' is not set" despite web.log.path being set

[ https://issues.apache.org/jira/browse/FLINK-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856145#comment-16856145 ] Cesar Alvernaz edited comment on FLINK-12383 at 6/4/19 9:56 PM: I could

[jira] [Comment Edited] (FLINK-12383) "Log file environment variable 'log.file' is not set" despite web.log.path being set

[ https://issues.apache.org/jira/browse/FLINK-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856145#comment-16856145 ] Cesar Alvernaz edited comment on FLINK-12383 at 6/4/19 9:56 PM: {quote}I

[jira] [Commented] (FLINK-12383) "Log file environment variable 'log.file' is not set" despite web.log.path being set

[ https://issues.apache.org/jira/browse/FLINK-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856145#comment-16856145 ] Cesar Alvernaz commented on FLINK-12383: I could reproduce this issue following the instruction

[GitHub] [flink] bowenli86 commented on issue #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

bowenli86 commented on issue #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#issuecomment-498849277 Rebased this PR to https://github.com/apache/flink/pull/8616

[GitHub] [flink] bowenli86 commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog

bowenli86 commented on a change in pull request #8589: [FLINK-12677][hive][sql-client] Add descriptor, validator, and factory for HiveCatalog URL: https://github.com/apache/flink/pull/8589#discussion_r289981359 ## File path:

[GitHub] [flink] bowenli86 commented on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog

bowenli86 commented on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog URL: https://github.com/apache/flink/pull/8616#issuecomment-498847563 cc @xuefuz @lirui-apache @zjuwangg

[GitHub] [flink] xuefuz commented on issue #8610: [FLINK-12715][hive] Hive-1.2.1 build is broken

xuefuz commented on issue #8610: [FLINK-12715][hive] Hive-1.2.1 build is broken URL: https://github.com/apache/flink/pull/8610#issuecomment-498782835 > I wonder that, since`moveToTrash()` is mainly a util, should we move it to a separate util shim class like `HiveUtilShim`? The current

[GitHub] [flink] sjwiesman commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state

sjwiesman commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state URL: https://github.com/apache/flink/pull/8618#issuecomment-498778322 @flinkbot attention @tzulitai

[GitHub] [flink] flinkbot commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state

flinkbot commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state URL: https://github.com/apache/flink/pull/8618#issuecomment-498777998 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I

[jira] [Updated] (FLINK-12732) Add savepoint reader for consuming partitioned operator state

[ https://issues.apache.org/jira/browse/FLINK-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12732: --- Labels: pull-request-available (was: ) > Add savepoint reader for consuming partitioned

[GitHub] [flink] bowenli86 removed a comment on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog

bowenli86 removed a comment on issue #8616: [FLINK-12718][hive] allow users to specify hive-site.xml location to configure hive metastore client in HiveCatalog URL: https://github.com/apache/flink/pull/8616#issuecomment-498773580 cc @xuefuz @lirui-apache @zjuwangg

[GitHub] [flink] sjwiesman opened a new pull request #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state

sjwiesman opened a new pull request #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state URL: https://github.com/apache/flink/pull/8618 ## What is the purpose of the change This is the second PR for FLIP-43 adding the functionality

[GitHub] [flink] asfgit closed pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables

asfgit closed pull request #8522: [FLINK-12572][hive]Implement HiveInputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522 This is an automated message from the Apache Git Service. To respond to the

[jira] [Closed] (FLINK-12572) Implement HiveInputFormat to read Hive tables

[ https://issues.apache.org/jira/browse/FLINK-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12572. Resolution: Fixed merged in 1.9.0: 38557bf8a6f8bebef8733f3f4f3b3950e9678fca > Implement HiveInputFormat

  1   2   3   4   5   >