GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43
MINIFI-183 Implemented ListenHTTP
Implemented ListenHTTP. Supports the following features:
- Connection keepalive (to be friendly with clients using connection
pooling
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@apiri Sure thing. These cmds might help for part of your testing:
```sh
dd if=/dev/urandom of=./testdat bs=1M count=1
```
```sh
curl -vvv -X POST --data-binary
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@apiri Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r102511352
--- Diff: libminifi/CMakeLists.txt ---
@@ -48,6 +49,19 @@ file(GLOB SPD_SOURCES "../include/spdlog/*")
add_library(spd
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@apiri Will do. Expecting to get an updated PR out here in a couple minutes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@phrocker Sounds good. I'll take a look at the rest and also fix this new
merge conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@phrocker @apiri Thanks for the feedback. All makes sense, but had one
question re: civet as an ExternalProject. I did it as a thirdparty/ dir mainly
to be consistent with how
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r101502981
--- Diff: libminifi/CMakeLists.txt ---
@@ -48,6 +49,19 @@ file(GLOB SPD_SOURCES "../include/spdlog/*")
add_library(spd
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r101504515
--- Diff: libminifi/include/ProcessSessionFactory.h ---
@@ -0,0 +1,52 @@
+/**
+ * @file ProcessSessionFactory.h
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r101504064
--- Diff: libminifi/include/ProcessSessionFactory.h ---
@@ -0,0 +1,52 @@
+/**
+ * @file ProcessSessionFactory.h
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r101507876
--- Diff: libminifi/src/ThreadedSchedulingAgent.cpp ---
@@ -64,11 +68,18 @@ void ThreadedSchedulingAgent::schedule(Processor
*processor
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@apiri @phrocker Addressed the comments, updated the code, and rebased. The
biggest thing is cleanly setting up an ExternalProject system, but I think
that's best addressed under
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/40
@benqiu2016 Good point. Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/40
Implemented event-driven scheduler
Implemented the event-driven scheduler. Refactored the thread-related code
into a base class as most of it is reused between the event-driven
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/39
MINIFI-181 Created initial implementation of PutFile
Wrote an initial implementation of PutFile. Not all features of NiFi's
PutFile are supported at this point, but this is tested
Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/1372
As a counterpoint to the idea of putting it in a separate repo, would it be
possible to produce the official image as part of a maven build stage? To
reference an internet URL somewhat breaks
Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/1372
@jdye64 If we do end up going the route of injecting the build #,
Dockerfile ARG statements might be the way to go. The docker-maven-plugin would
be the place to set the arg, if that plugin
Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/1372
@jdye64 Interesting, wasn't aware of the restrictions with the official
docker hub. When I go look at some other projects for comparison, it looks
roughly like the directory is used
Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/1372
@jdye64 Looks like there are two in central; one by fabric8 and one by
spotify:
https://search.maven.org/#artifactdetails|io.fabric8|docker-maven-plugin|0.19.0|maven-plugin
https
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/128
MINIFI-376 removed defunct references to curlbuild.h
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/118
MINIFI-311 Move to alpine base for docker image.
This change takes the 1.5G ubuntu minifi image and reduces it to a 39MB
image by using a multi-stage alpine build.
MINIFI
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/118
Thanks for the feedback. I will make the required changes and update the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/118
@apiri removed those dirs & rebased. Should be good to go now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/123
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/122
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/124
MINIFI-367 port tests to use boost::filesystem vs. stat.h for better
portability
This closes MINIFI-367.
You can merge this pull request into a Git repository by running:
$ git
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/125
MINIFI-368 exclude hidden files when scanning for src files
Updated regex matching when scanning for source files so that we don't pick
up hidden files such as vim swap files.
You
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/126
MINIFI-350 added pytest-based system integration test framework and initial
test cases
Added a test framework which enables automated tests suits for the docker
image as well
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/131
Looks like we have an issue now with civet/TLS in travis. Looking into it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/137
Good work!
After a precursory glance at the code, nothing major sticks out. Will
attempt to build and test as soon as I can get to it.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
One more thing that struck me during testing: it seems broken that we
attempt to periodically send heartbeats when c2 has not been configured. Would
it be possible to not attempt
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/136
MINIFI-398 Added test framework support for s2s and added s2s integraâ¦
â¦tion test between minifi-cpp and nifi.
Thank you for submitting a contribution to Apache NiFi
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/135
This PR depends on the phrocker/MINIFI-339 branch. Once that's merged,
everything will pass. In the meantime, this commit can be applied on top of
that branch to test.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
Mac & docker builds work for me, but building on CentOS7 results in this
error:
```
[ 44%] Linking CXX executable SiteToSiteRestTest
CMakeFiles/SiteToSiteRestTest
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
@phrocker That sounds reasonable re: documentation. I would put some docs
embedded in the code that point out what you just said (that this is using the
Garcon protocol, with a link
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
Note that Travis is failing/segfaulting on a test. We're green on travis
right now, so would hate to see it turn back red.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
Also getting a test failure on CentOS 7.3:
```
The following tests FAILED:
19 - SocketTests (Failed)
```
---
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137885309
--- Diff: CMakeLists.txt ---
@@ -35,6 +35,8 @@ ENDIF(POLICY CMP0048)
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
I noted this in the review above, but I think this would also generally be
a good time to run a clang format/clang tidy as this change spans a large
amount of code. Would put us
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137866433
--- Diff: libminifi/include/core/state/UpdateController.h ---
@@ -0,0 +1,255 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137585243
--- Diff: libminifi/include/core/state/metrics/MetricsListener.h ---
@@ -0,0 +1,131 @@
+/**
+ *
+ * Licensed to the Apache
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137864284
--- Diff: libminifi/include/core/Processor.h ---
@@ -212,19 +217,35 @@ class Processor : public Connectable, public
ConfigurableComponent
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137861024
--- Diff: libminifi/include/c2/C2Protocol.h ---
@@ -0,0 +1,119 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137879427
--- Diff: libminifi/include/processors/InvokeHTTP.h ---
@@ -101,9 +105,9 @@ class InvokeHTTP : public core::Processor {
static core
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137570255
--- Diff: libminifi/include/core/state/StateManager.h ---
@@ -0,0 +1,127 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137824349
--- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
@@ -43,14 +44,15 @@ class RemoteProcessorGroupPort : public core::Processor
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137841080
--- Diff: libminifi/include/c2/C2Agent.h ---
@@ -0,0 +1,203 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137863123
--- Diff: libminifi/include/c2/protocols/RESTSender.h ---
@@ -0,0 +1,81 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137880036
--- Diff: libminifi/include/utils/HTTPClient.h ---
@@ -0,0 +1,270 @@
+/**
+ * HTTPUtils class declaration
+ *
+ * Licensed
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137863977
--- Diff: libminifi/include/core/Processor.h ---
@@ -153,7 +154,8 @@ class Processor : public Connectable, public
ConfigurableComponent
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137587733
--- Diff: libminifi/include/core/state/metrics/SystemMetrics.h ---
@@ -0,0 +1,111 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137835890
--- Diff: libminifi/include/ResourceClaim.h ---
@@ -83,13 +83,19 @@ class ResourceClaim : public
std::enable_shared_from_this
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137877541
--- Diff: libminifi/include/core/state/metrics/MetricsBase.h ---
@@ -0,0 +1,167 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137817535
--- Diff: libminifi/include/FlowController.h ---
@@ -158,7 +176,7 @@ class FlowController : public
core::controller
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137865638
--- Diff: libminifi/include/core/state/UpdateController.h ---
@@ -0,0 +1,255 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137881468
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -202,14 +205,13 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137881667
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -221,51 +223,28 @@ void
RemoteProcessorGroupPort::refreshRemoteSite2SiteInfo
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137881550
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -221,51 +223,28 @@ void
RemoteProcessorGroupPort::refreshRemoteSite2SiteInfo
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137865874
--- Diff: libminifi/include/core/state/UpdateController.h ---
@@ -0,0 +1,255 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137861356
--- Diff: libminifi/include/c2/HeartBeatReporter.h ---
@@ -0,0 +1,99 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137812730
--- Diff: libminifi/include/FlowController.h ---
@@ -124,14 +123,33 @@ class FlowController : public
core::controller
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137821983
--- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
@@ -23,13 +23,14 @@
#include
#include
#include
-#include
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137861761
--- Diff: libminifi/include/c2/protocols/RESTProtocol.h ---
@@ -0,0 +1,74 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137587193
--- Diff: libminifi/include/core/state/metrics/RepositoryMetrics.h ---
@@ -0,0 +1,101 @@
+/**
+ *
+ * Licensed to the Apache
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137866970
--- Diff: libminifi/include/core/state/metrics/MetricsBase.h ---
@@ -0,0 +1,167 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137860497
--- Diff: libminifi/include/c2/C2Payload.h ---
@@ -0,0 +1,187 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137811526
--- Diff: libminifi/include/FlowController.h ---
@@ -124,14 +123,33 @@ class FlowController : public
core::controller
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137557066
--- Diff: CMakeLists.txt ---
@@ -35,6 +35,8 @@ ENDIF(POLICY CMP0048)
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/134
Taking a look...
---
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137886296
--- Diff: libminifi/include/core/state/UpdateController.h ---
@@ -0,0 +1,255 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137886437
--- Diff: libminifi/include/core/state/metrics/MetricsBase.h ---
@@ -0,0 +1,167 @@
+/**
+ *
+ * Licensed to the Apache Software
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/135
MINIFI-374 Created automated tests for HTTPS integration cases
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/126
The rope files should not have been committed at all.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/137
I see that now, thanks. What I was looking for originally was references to
DatabaseContentRepository, which I didn't see.
I think we're good on FlowFileRepository coverage
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/138
lgtm
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/131
Issue was addressed by an upstream commit in civetweb:
https://github.com/civetweb/civetweb/commit/e849ce4b54c09d5b4441e371f17cf13368ac2234.
Backported that commit which should fix
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r134803404
--- Diff: thirdparty/civetweb-1.9.1/src/civetweb.c ---
@@ -11856,7 +11859,24 @@ ssl_get_client_cert_info(struct mg_connection
*conn
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r134803190
--- Diff: thirdparty/civetweb-1.9.1/src/civetweb.c ---
@@ -11856,7 +11859,24 @@ ssl_get_client_cert_info(struct mg_connection
*conn
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/131
Updated to disable dynamic loading of TLS libs in civet, install libressl
instead of openssl to resolve conflict with libcurl deps, and backport fix for
civetweb which fixes
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/132
MINIFI-389 Added support for one-way TLS to SSLContextService
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/126#discussion_r135424099
--- Diff: docker/test/integration/test_http.py ---
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/126
Thanks for the feedback. Adding more documentation is a good idea. I'll get
on that and update the PR.
---
If your project is set up for it, you can reply to this email and have
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/130
MINIFI-388 symlink versioned libcrypto/libssl to non-versioned path so that
civet can find them when TLS is used
Added symlink cmds to dockerfile to allow civet to find the libraries
Github user achristianson closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/131
MINIFI-388 symlink versioned libcrypto/libssl to non-versioned path sâ¦
â¦o that civet can find them when TLS is used
### For all changes:
- [x] Is there a JIRA ticket
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/131#discussion_r134278520
--- Diff: docker/Dockerfile ---
@@ -100,6 +100,10 @@ RUN mkdir -p $MINIFI_BASE_DIR
COPY --from=builder ${MINIFI_HOME} ${MINIFI_HOME
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/130
Disregard this one. Was based on MINIFI-374 instead of master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/126#discussion_r136992525
--- Diff: README.md ---
@@ -124,6 +133,8 @@ $ brew install cmake \
doxygen
$ brew install curl
$ brew link curl --force
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/126
Added docs to docker/test/integration/README.md.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/182
@minifirocks This looks great! Thanks for the contribution.
Initially when I tried it, it was failing, but it was a config error on my
part, and the processor was correctly
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/185
Looks good.
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/188
MINIFICPP-49 Added initial implementation of NiFi expression language
This implementation covers core language syntax such as embedding
${expressions}, referencing attributes
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/185
I can build & make test this on CentOS 7.4 with devtoolset-6 (GCC 6.3.1),
but it fails when using devtoolset-7 (GCC 7.1.1).
```
In file included from
/home/achristia
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/211#discussion_r153915241
--- Diff: libminifi/src/processors/PutFile.cpp ---
@@ -125,6 +135,29 @@ void PutFile::onTrigger(core::ProcessContext *context,
core
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/188#discussion_r153920487
--- Diff: extensions/expression-language/ProcessContextExpr.cpp ---
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/188#discussion_r153914128
--- Diff: libminifi/CMakeLists.txt ---
@@ -74,6 +74,7 @@ target_link_libraries(core-minifi ${UUID_LIBRARIES}
${JSONCPP_LIB} yaml-cpp
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/188#discussion_r153914305
--- Diff: extensions/expression-language/ProcessContextExpr.cpp ---
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/211#discussion_r153914751
--- Diff: libminifi/include/processors/PutFile.h ---
@@ -109,6 +110,7 @@ class PutFile : public core::Processor {
std::string
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/188#discussion_r153913747
--- Diff: extensions/expression-language/Expression.cpp ---
@@ -0,0 +1,164 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/188
Addressed review notes.
---
1 - 100 of 402 matches
Mail list logo
