Re: CentOS7 and systemd ordering when shutting down results in unclean unmount

On Tue, Dec 09, 2014 at 09:22:41AM -0800, awiddersh...@hotmail.com wrote: > Sorry, I didn't post the fstab entry in my original post when I should > have. The "_netdev" entry is being applied to the disk and it seems like > systemd generator is seeing that option properly and creating the mount

iscsi_tcp bound to network interface issues after "iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND"

Hi all, It looks to me that the changes in "iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND" have broken interface binding for iscsi_tcp (and iser, assuming interface binding makes sense for iser). Session login no longer moves forward if a matching host cannot be found, but with the software tr

Re: iscsi_tcp bound to network interface issues after "iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND"

On Thu, Jan 08, 2015 at 10:36:59AM -0600, Michael Christie wrote: > > On Jan 6, 2015, at 6:40 PM, Chris Leech wrote: > > > Hi all, > > > > It looks to me that the changes in "iscsid: retry login for > > ISCSI_ERR_HOST_NOT_FOUND" have broken in

[PATCH] fix regression in iscsi_tcp iface binding

a hardware offload device with "bind_ep_required" and only requires a host lookup before starting the connection if this flag is set. Signed-off-by: Chris Leech --- usr/initiator.c | 30 -- usr/transport.c | 6 ++ usr/transport.h | 1 + 3 files changed,

Re: iscsi_tcp bound to network interface issues after "iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND"

On Thu, Jan 08, 2015 at 08:40:17PM -0600, Mike Christie wrote: > On 01/08/2015 11:11 AM, Chris Leech wrote: > > On Thu, Jan 08, 2015 at 10:36:59AM -0600, Michael Christie wrote: > >> > >> On Jan 6, 2015, at 6:40 PM, Chris Leech wrote: > >> > >>> Hi

[PATCH 2/5] add discovery as a valid mode in iscsiadm.8

--- doc/iscsiadm.8 | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/iscsiadm.8 b/doc/iscsiadm.8 index 9a945d1..05793b2 100644 --- a/doc/iscsiadm.8 +++ b/doc/iscsiadm.8 @@ -174,13 +174,13 @@ for session mode). .TP \fB\-m, \-\-mode \fIop\fR specify the mode. \f

[PATCH 4/5] iscsiuio CFLAGS fixes

try and keep existing CFLAGS from environment for packagers --- iscsiuio/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iscsiuio/configure.ac b/iscsiuio/configure.ac index d619598..7ee1e73 100644 --- a/iscsiuio/configure.ac +++ b/iscsiuio/configure.ac @@ -53,7 +53

[PATCH 1/5] guard against NULL ptr during discovery from unexpected event

dereference. Signed-off-by: Chris Leech --- usr/netlink.c | 4 1 file changed, 4 insertions(+) diff --git a/usr/netlink.c b/usr/netlink.c index 328f21c..3984727 100644 --- a/usr/netlink.c +++ b/usr/netlink.c @@ -1038,6 +1038,10 @@ static int krecv_conn_state(struct iscsi_conn *conn, uint32_t

small set of minor fixes

Clearing out the backlog of a few minor issues, and the iscsiuio socket activation support. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@

[PATCH 3/5] iscsid: fix order of setting uid/gid and drop supplementary groups

id is started as root it should drop any inherited supplementary group permissions. And if anyone is actually using this to try and isolate capabilities, they probably care enough to want to known that it is failing. Make iscsid startup fail instead of just calling perror. Signed-off-by: Chris

[PATCH 5/5] iscsiuio systemd socket activation support

Signed-off-by: Chris Leech --- iscsiuio/src/unix/iscsid_ipc.c | 28 1 file changed, 28 insertions(+) diff --git a/iscsiuio/src/unix/iscsid_ipc.c b/iscsiuio/src/unix/iscsid_ipc.c index 4a89ec2..3e92d90 100644 --- a/iscsiuio/src/unix/iscsid_ipc.c +++ b/iscsiuio/src

Re: iscsi_tcp bound to network interface issues after "iscsid: retry login for ISCSI_ERR_HOST_NOT_FOUND"

On Mon, Jan 12, 2015 at 01:33:23PM -0600, Mike Christie wrote: > >I'm not sure we can remove bind_ep if we still want to support the > >cxgb3i and bnx2i general iface names. > > I am not sure what you mean here. Are saying you can use cxgbi and bnx2i but > not specify a iface name that is associat

Re: CentOS7 and systemd ordering when shutting down results in unclean unmount

On Fri, Jan 16, 2015 at 04:10:19PM -0800, br...@brentrjones.com wrote: > Posting here since I am running into the same exact issue, however I am > running the MariaDB included with RHEL 7. Thanks for sharing this. I'll respond briefly, as much of what you bring up isn't really on topic for Open-

[PATCH] iscsid safe session logout

of EBUSY to the ipc request. I've made it a configuration option (iscsid.safe_logout) that defaults to "No" to preserve the existing behavior as the default, while making it available for users that prefer a safety check. This does add a new dependency on libmount. Signed-off-

Re: iscsid stop using system not working correctly

On Fri, Jan 30, 2015 at 02:09:54PM -0800, The Lee-Man wrote: > Hi Mike: > > Just a heads up that stopping the open-iscsi iscsid daemon using systemd > doesn't seem to be working correctly, at least not on SUSE SLE 12. > > When I have one or more sessions present, and their startup value is set t

Re: iscsid stop using system not working correctly

On Wed, Feb 04, 2015 at 12:51:08PM -0800, The Lee-Man wrote: > > > > I'm wondering if it has something to do with the ExecStop command > > returning before iscsid actually terminates, although I'm not sure > > what's triggering the service restart. > > > > I think you're onto the meat of the pr

Re: 2 NICs, 2 targets : discover OK but no login. Same subnet impossible?

On Fri, Feb 06, 2015 at 05:22:40PM +0100, InterNetX - Juergen Gotteswinter wrote: > it is possible, look at rp filter systctl > > -- snip -- (borrowed from EQL, this arrays need to have all ifaces on > the same subnet > net.ipv4.conf.all.arp_ignore=1 > net.ipv4.conf.all.arp_announce=2 > net.ipv4.

Re: [PATCHv2 0/3] Fix issues resulting from actor rewrite

On Fri, Feb 06, 2015 at 04:36:25PM -0800, Andy Grover wrote: > I think I got a handle on the original issue you were seeing Mike, > please take a look at #2 patch. I reproduced this issue and verified that these patches resolve it. Is changing to a 1 second initial delay and then checking poll ev

[PATCH] honor all requested delays in iscsi_sched_ev_context

honored (even if most of them are passed as 0). Signed-off-by: Chris Leech --- usr/initiator.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/usr/initiator.c b/usr/initiator.c index 83bbdbf..40c7b63 100644 --- a/usr/initiator.c +++ b/usr/initiator.c

[PATCH] iscsid: don't re-read config file for every session logout

Follow up to the safe_logout feature patch. Cache the safe_logout setting when iscsid is started. Signed-off-by: Chris Leech --- usr/initiator.c | 6 +- usr/iscsid.c| 6 ++ usr/iscsid.h| 1 + 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/usr/initiator.c b/usr

Re: iscsid stop using system not working correctly

On Thu, Feb 05, 2015 at 04:58:37PM -0800, The Lee-Man wrote: > Thanks, Chris, for tracking down the systemd problem and reporting it. In case anyone else was following this thread, Lennart has commited a change to systemd to fix this case. It will be in systemd 219. commit: d54ddab8cbad46290306f

Re: [PATCHv2 0/3] Fix issues resulting from actor rewrite

On Thu, Feb 12, 2015 at 11:30:10PM -0600, Mike Christie wrote: > On 02/12/2015 06:33 PM, Chris Leech wrote: > > It looks like the communication with iscsiuio has a similar case where > > a polling function reschedules itself, following up with a patch to fix > > the delay ther

Re: [PATCHv2 0/3] Fix issues resulting from actor rewrite

On Wed, Feb 25, 2015 at 01:38:52PM -0800, Chris Leech wrote: > On Thu, Feb 12, 2015 at 11:30:10PM -0600, Mike Christie wrote: > > On 02/12/2015 06:33 PM, Chris Leech wrote: > > > It looks like the communication with iscsiuio has a similar case where > > > a polling

[PATCH] iscsi_ibft: filter null v4-mapped v6 addresses

tianocore iSCSI driver as it's already in the wild in a large number of servers. Tested under qemu using an OVMF build of tianocore EDK2. Signed-off-by: Chris Leech --- drivers/firmware/iscsi_ibft.c | 36 +--- 1 file changed, 21 insertions(+), 15 deleti

[RFC PATCH 3/4] iscsi: make all netlink multicast namespace aware

Make use of the per-net netlink sockets. Responses are sent back on the same socket/namespace the request was received on. Async events are reported on the socket/namespace stored in the iscsi_cls_host associated with the event. --- drivers/scsi/scsi_transport_iscsi.c | 92 +++

[RFC PATCH 0/4] Make iSCSI network namespace aware

etwork namespaces. These patches are functional, but not complete. There's no isolation enforced in the kernel just yet, so it relies on well behaved userspace. I plan on fixing that, but wanted some feedback on the idea and approach so far. Thanks, Chris Chris Leech (4): iscsi:

[RFC PATCH 1/4] iscsi: create per-net iscsi nl kernel sockets

Prepare iSCSI netlink to operate in multiple namespaces. --- drivers/scsi/scsi_transport_iscsi.c | 67 +++-- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index 67d43e3..88a

[RFC PATCH 2/4] iscsi: sysfs filtering by network namespace

This makes the iscsi_host, iscsi_session, iscsi_connection, and iscsi_endpoint transport class devices only visible in sysfs under a matching network namespace. The network namespace for all of these objects is tracked in the iscsi_cls_host structure. --- drivers/scsi/scsi_transport_iscsi.c | 114

[RFC PATCH 4/4] iscsi: set netns for iscsi_tcp hosts

This lets iscsi_tcp operate in multiple namespaces. It uses current during session creation to find the net namespace, but it might be better to manage to pass it along from the iscsi netlink socket. --- drivers/scsi/iscsi_tcp.c| 7 +++ drivers/scsi/scsi_transport_iscsi.c | 7

Re: [RFC PATCH 0/4] Make iSCSI network namespace aware

On Wed, May 20, 2015 at 11:45:43AM -0700, Andy Grover wrote: > On 05/13/2015 03:12 PM, Chris Leech wrote: > >This is only about the structures and functionality involved in maintaining > >the > >iSCSI session, the SCSI host along with it's discovered targets and devices

iscsi flashnode bus? Re: [RFC PATCH 2/4] iscsi: sysfs filtering by network namespace

On Wed, May 13, 2015 at 03:12:45PM -0700, Chris Leech wrote: > This makes the iscsi_host, iscsi_session, iscsi_connection, and > iscsi_endpoint transport class devices only visible in sysfs under a > matching network namespace. The network namespace for all of these > objects is tr

Re: [RFC PATCH 0/4] Make iSCSI network namespace aware

On Thu, May 21, 2015 at 11:04:46AM +0200, Hannes Reinecke wrote: > On 05/20/2015 08:45 PM, Andy Grover wrote: > > On 05/13/2015 03:12 PM, Chris Leech wrote: > >> This is only about the structures and functionality involved in > >> maintaining the > >> iSCSI se

[PATCH] iSCSI: let session recovery_tmo sysfs writes persist across recovery

tting once it's been modified via the sysfs interface. My thinking here is that the sysfs interface is much simpler for external tools to influence the session timeout, but if we're going to allow it to be modified directly we should ensure that setting is maintained. Signed-off-

Re: [PATCH] iSCSI: let session recovery_tmo sysfs writes persist across recovery

On Wed, Jun 17, 2015 at 09:33:04AM -0500, Mike Christie wrote: > On 06/16/2015 06:07 PM, Chris Leech wrote: > > The iSCSI session recovery_tmo setting is writeable in sysfs, but it's > > also set every time a connection is established when parameters are set > > from

[PATCH] iscsi: make mutex for target scanning and unbinding per-session

allel, speeding up connecting to a large number of targets. Note that as iscsi_tcp creates a virtual host for each session, software iSCSI is effectively doing this already. Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 19 ++- include/scsi/scsi_transport_is

Re: NIC-packet errors when iSER done on RAM

On Fri, Oct 09, 2015 at 04:51:48AM -0700, dinesh...@vvdntech.in wrote: > Hi, > > We are using > *Soft-RoCE* > *Branch :* Master-Next > *Kernel :* 4.0.0 > > *Target :* targetcli-2.0rc1 > > *Soft-RoCE *is successfully implemented and its functionality is tested > using "*rping*". > > Currentl

Re: Possible issue in commit 659743b02c41 ("libiscsi: Reduce locking contention in fast path")

On Thu, Nov 05, 2015 at 02:33:44PM -0200, Guilherme G. Piccoli wrote: > Hello Shlomo and Or, > > I'm Guilherme Piccoli from LTC/IBM - firstly, sorry to bother you. > > > We are running some tests with iSCSI and we found an issue caused possibly > by commit 659743b02c41 ("libiscsi: Reduce locking

Re: Possible issue in commit 659743b02c41 ("libiscsi: Reduce locking contention in fast path")

On Fri, Nov 06, 2015 at 09:52:57AM -0600, Michael Christie wrote: > Or and Shlomo, I am going to just revert the patch for now until I can > do some performance testing with a patch to add back correct locking > and also re-rerview the patch. Maybe instead of locks I can just use > some kfifos too.

Re: CentOS7 and systemd ordering when shutting down results in unclean unmount

On Tue, Jan 19, 2016 at 02:12:39PM -0600, Mike Christie wrote: > On 01/11/2016 08:52 AM, garpe...@gmail.com wrote: > > > > > Second problem is the same as stated above, at shutdown, system > > would tear > > > down network interfaces and try to stop iSCSI before unmounting > > the

Re: iscsiadm is not able to login in any port except 3260

On Mon, Jan 25, 2016 at 01:54:09PM -0600, Mike Christie wrote: > ccing Chris Leech. He handles iSCSI in RHEL. This looks to be an SELinux policy setting in RHEL. You could use the audit2allow tool from the policycoreutils-python package to create a custom policy module, extending the sys

[PATCH] make use of all 24 bits of ISID qualifier space

#x27;m not sure where the issue was yet. CC: shiva krishna merla Signed-off-by: Chris Leech --- usr/discovery.c | 4 +++- usr/initiator.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/usr/discovery.c b/usr/discovery.c index 43c2359..593d226 100644 --- a/usr/discovery.c

Re: ISID uniqueness

On Thu, Jan 28, 2016 at 06:11:28PM -0800, shiva krishna merla wrote: > Thanks Mike, Yes, we have one LUN per target and testing with large > number of LUN's. 100 - 1024. With this each LUN will have a volume > level target. I think the reason other vendors have not seen this > issue till now may be

login times when scaling out targets (Re: ISID uniqueness)

So increasing the ISID space gets this working, but the described setup here (4 sessions x 256 targets) takes a _long_ time to connect to all the targets. In a virtual setup I'm seeing up to 10 minutes, and with higher network latencies and busy targets I can imagine it being worse. Just an FYI

Re: login times when scaling out targets (Re: ISID uniqueness)

On Fri, Feb 05, 2016 at 12:47:54PM -0600, Michael Christie wrote: > > For the session_is_running checks, we do not really need to check > sysfs. I originally did this because I was worried other tools would > be creating sessions using some other tools or accessing netlink. This > never happened -

Re: login times when scaling out targets (Re: ISID uniqueness)

On Tue, Feb 09, 2016 at 03:24:04PM -0800, Chris Leech wrote: > But there may be more straightforward gains to be had in cleaning up the > sysfs code. Every attribute read ends up in sysfs_lookup_devpath_by_subsys_id > which does a bunch of string ops and stats trying to find the devi

Re: login times when scaling out targets (Re: ISID uniqueness)

On Wed, Feb 10, 2016 at 04:07:25AM -0600, Michael Christie wrote: > > > On Feb 9, 2016, at 8:53 PM, Chris Leech wrote: > > > > On Tue, Feb 09, 2016 at 03:24:04PM -0800, Chris Leech wrote: > >> But there may be more straightforward gains to be had in cleaning

Re: [PATCH] make use of all 24 bits of ISID qualifier space

On Wed, Feb 10, 2016 at 11:32:17AM -0800, Lee Duncan wrote: > On 02/01/2016 09:41 AM, Mike Christie wrote: > > On 01/29/2016 04:43 PM, Chris Leech wrote: > >> For some reason, our ISID has only ever had 8-bits of uniqueness. We > >> use the OUI format, which leaves 24-b

Re: [PATCH] Build system: sort object file lists

On Sat, Feb 13, 2016 at 05:30:03PM -0600, Mike Christie wrote: > On 02/12/2016 06:05 PM, Christian Seiler wrote: > > Hi, > > > > Debian is currently working on making the entire archive build > > reproducibly. is a good > > resource describing the motivation behi

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On Fri, Feb 12, 2016 at 09:54:51AM -0800, James Bottomley wrote: > On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: > > The scsi_transport_iscsi module already uses the ida_simple > > routines for managing the target ID, if requested to do > > so. This change replaces an ever-increasing atomic

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On Tue, Feb 16, 2016 at 12:40:12PM -0600, Mike Christie wrote: > On 02/15/2016 12:26 PM, Chris Leech wrote: > > On Fri, Feb 12, 2016 at 09:54:51AM -0800, James Bottomley wrote: > >> On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: > >>> The scsi_transport

sysfs handling improvements for large number of sessions

This is in response to the previous discussions about login times when scaling out to thousands of sessions. I'm still looking at converting to libudev, but it's going to be a big enough change that I thought it might make sense to just remove the attr_list on it's own first. Sysfs paths are rarel

[PATCH] remove sysfs attr_list

The global cache is not well designed, it quickly can grow to the point where lookups take much longer than just doing the sysfs read in the first place. --- usr/host.c | 1 + usr/session_info.c | 1 + usr/sysfs.c| 62 -- 3 file

Re: sysfs handling improvements for large number of sessions

On Fri, Feb 19, 2016 at 07:56:02PM +0100, Hannes Reinecke wrote: > On 02/18/2016 12:01 AM, Chris Leech wrote: > >This is in response to the previous discussions about login times when > >scaling > >out to thousands of sessions. > > > >I'm still looking at co

Re: [PATCH] remove sysfs attr_list

On Thu, Feb 18, 2016 at 06:18:07PM -0600, Mike Christie wrote: > On 02/17/2016 05:01 PM, Chris Leech wrote: > > The global cache is not well designed, it quickly can grow to the point > > where lookups take much longer than just doing the sysfs read in the > > first place.

persistant record layout and long DNS names

I was asked an interesting question recently, and thought I'd share it here. I don't think it's critical to address right away, but surprising and something to think about. Someone asked me about targets configured to return DNS names rather than IP addresses in a SendTargets response, and what th

Re: [PATCH] remove sysfs attr_list

On Wed, Feb 17, 2016 at 03:01:36PM -0800, Chris Leech wrote: > The global cache is not well designed, it quickly can grow to the point > where lookups take much longer than just doing the sysfs read in the > first place. This patch has problems, the sysfs_attr_get_value changes are w

[PATCH v2] remove sysfs attr_list

The global cache is not well designed, it quickly can grow to the point where lookups take much longer than just doing the sysfs read in the first place. Signed-off-by: Chris Leech v2: initialized 'value' array in sysfs_attr_get_value to fix issue when checking for an attr that doe

Re: [PATCH] iscsi tools: Add support for some host statistics

On Wed, Mar 02, 2016 at 03:04:46AM -0500, adheer.chandravan...@qlogic.com wrote: > From: Adheer Chandravanshi > > Add support to maintain and show some host statistics in iscsid. > This provides following host specific stats: > iscsi_login_accept_rsps > iscsi_login_other_fail_rsps >

Re: iSCSI disconnections after running iscsistart

On Thu, Mar 03, 2016 at 10:16:45PM +0200, Erez Zilber wrote: > Hi, > > I'm running iSCSI boot for RHEL & SUSE nodes. Sometimes, after > iscsistart is called, errors on the iSCSI target side occur (e.g. temp > network disconnection) and the iSCSI connection is disconnected. In > the boot log, it lo

possible data corruption with iscsi_tcp and dm-multipath

;t have a solid trace of this, but I'm working with a report of data corruption in a controlled test setup that fits this. I had the reporter try an early version of this patch, that always set a 0 SO_LINGER time without the IN_LOGOUT check, and they no longer could reproduce the prob

[PATCH] iscsi_tcp set SO_LINGER to abort connection for error handling

a FIN. Signed-off-by: Chris Leech --- usr/io.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/usr/io.c b/usr/io.c index f552e1e..48b233c 100644 --- a/usr/io.c +++ b/usr/io.c @@ -391,9 +391,24 @@ iscsi_io_tcp_poll(iscsi_conn_t *conn, int timeout_ms) void iscsi_io_tcp_disco

Re: [PATCH] iscsi_tcp set SO_LINGER to abort connection for error handling

On Thu, Mar 03, 2016 at 07:09:14PM -0600, Mike Christie wrote: > On 03/03/2016 06:09 PM, Chris Leech wrote: > > When requests are being failed it's important to abort the TCP > > connection rather than let TCP wait and attempt a graceful shutdown. > > > > That ca

Re: Antw: Re: [PATCH] iscsi_tcp set SO_LINGER to abort connection for error handling

, the (re)transmit queue is purged, rather than being retried in the background. - Chris > > >>> Chris Leech schrieb am 04.03.2016 um 06:00 in > >>> Nachricht > <20160304050001.cohjmdvxyopzd...@straylight.hirudinean.org>: > > On Thu, Mar 03, 2016 at 07:0

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

his in user space, though, > than to limit the value range for the session ID here. > > Signed-off-by: Lee Duncan Acked-by: Chris Leech -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop re

Re: iscsi daemon in docker container

On Tue, Mar 08, 2016 at 02:54:29AM +, Serguei Bezverkhi (sbezverk) wrote: > Hello, > > As per Michael Christie suggestion, I am reaching out to a wider > audience. I am trying to run iscsid inside of a Docker container but > without using systemd. When I start iscsid -d 8 -f, it fails with >

[PATCH 2/5] iscsistart: support booting over a VLAN

Adds code to check for VLAN devices if the boot configuration specifies a VLAN ID. Does not create VLANs, they need to already be in place. Signed-off-by: Chris Leech --- include/iscsi_net_util.h | 3 +- usr/iscsi_net_util.c | 78

[PATCH 1/5] iscsiadm: fix parallel rescan handling of exit codes

Fix this by making use of the wait.h macros for checking the exit code. Signed-off-by: Chris Leech --- include/iscsi_err.h | 2 ++ usr/iscsi_err.c | 1 + usr/iscsi_sysfs.c | 20 +--- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/include/iscsi_err.h b/in

[PATCH 3/5] iscsid: safe_logout fix device path canonicalization by using libmount cache

Fix for the safe_logout options use of libmount. If the cache API isn't used then device name canonicalization doesn't happen, and proper detection of devices mounted by a label doesn't work. Signed-off-by: Chris Leech --- usr/initiator.c | 9 +++-- 1 file changed, 7 i

[PATCH 4/5] iscsid: make safe_logut session checks apply for flashnode session

Make the safe_logout option work with flashnode sessions as well. Moves the code into a new file shared between iscsid and iscsiadm. Signed-off-by: Chris Leech --- usr/Makefile | 8 +- usr/initiator.c| 195 - usr/initiator.h

[PATCH 5/5] remove sysfs attr_list

nother behavior change when checking ofr non-existent attrs, make sure we return NULL and not an empty string Signed-off-by: Chris Leech --- usr/host.c | 1 + usr/session_info.c | 1 + usr/sysfs.c| 65 ++ 3 files changed

github repo, picking up patches from this list

know and I'll add it. Chris Leech (6): iscsi_tcp set SO_LINGER to abort connection for error handling iscsiadm: fix parallel rescan handling of exit codes iscsistart: support booting over a VLAN iscsid: safe_logout fix device path canonicalization by using libmount

Re: Question: Where are scsi commands encapsulated?

On Mon, May 09, 2016 at 08:32:54AM -0700, whls.j...@gmail.com wrote: > Hi, > > I am recently looking into the process of iSCSI initiator. I wonder where > the source codes are that receive the scsi commands and encapsulate them > into iscsi format. I have walked through the interaction between i

Re: Question: Where are scsi commands encapsulated?

ls down from there, but that's the interface where SCSI transports take commands. - Chris > 2016-05-20 18:18 GMT-05:00 Chris Leech : > > > On Mon, May 09, 2016 at 08:32:54AM -0700, whls.j...@gmail.com wrote: > > > Hi, > > > > > > I am recently looking i

Re: Performance issues when logging into a large number of targets

rovement. And yes the gmon output is for iscsiadm and > > >> not iscsid. > > >> > > >> > > >> -Syed > > >> > > >> On Wed, Jun 8, 2016 at 1:36 PM, Mike Christie > >> <mailto:micha...@cs.wisc.edu>> wrote: > > >>

Re: login fail

On Wed, Jun 22, 2016 at 01:07:14AM -0700, 陳德安 wrote: > > Hi, > > I have the question at login of iSCSI > > console: > > iscsiadm: initiator reported error (13 - daemon access denied) > iscsiadm: Could not log into all portals > > Could anyone tell me the reason? > > Thanks for your help. It

Re: login fail

On Wed, Jun 22, 2016 at 08:04:24PM -0700, Kevin Chen wrote: > I modify the permissions, but output is same... Are you running iscsiadm as root? There's an additional check in iscsid (which may not be the best choice, it's been there a long time) for the peer user name on the IPC socket which is c

Re: CentOS7 and systemd ordering when shutting down results in unclean unmount

t will dump the full details of the node record. In particular I'd like to check the setting of node.startup. If node.startup is set to manual, then the systemd units for managing automatic session startup and shutdown will ignore this target. The default node.startup setting that will be a

Re: CentOS7 and systemd ordering when shutting down results in unclean unmount

On Tue, Jun 28, 2016 at 04:01:37AM +, David wrote: > > I've just installed a Centos7 box, fully updated to: > > CentOS Linux release 7.2.1511 (Core) > > I have installed and set up an iSCSI volume. Done a mkfs on it. Mounted > it. No problem. > > I am having the same problem when shutti

Re: How to setup optimal routing with multiple NICs

On Thu, Jun 30, 2016 at 02:49:37PM -0700, chandler s. wrote: > Dear group, > > We have an iSCSI device which has two controllers, and each controller has > two host ports. We also have two networks available. Thus: > - controller1-port1 is plugged into network1 and has ip1-1, > - controller1-po

Re: reset socket when session recovery

On Wed, Jul 20, 2016 at 01:50:59AM -0700, Guangliang Zhao wrote: > Hi folks， > > I send merge request “iscsid: reset socket when session recovery”，any > comments are appreciated > > There are serveral independent target servers in our system，initiator could > connect anyone at random, > so pack

Re: Does iscsiadm support discovery through iSCSI interface using iSNS

On Tue, Jul 26, 2016 at 01:59:38PM -0700, Vimol Kshetrimayum wrote: > > > Hi, > > > I am trying to discover targets using iSNS but through iSCSI interface. We don't have any sort of iSNS offload support, so you can't really do iSNS through an offload iface. But I think this should work to do

Re: Can't discover more than 1 iSER device

On Thu, Jul 28, 2016 at 02:45:20AM -0700, james harvey wrote: > Sorry for cross-posting to github, just saw several messages saying to use > the mailing list instead. > > I made a similar bug report to the linux-rdma mailing list about a year > ago, and never followed up here. I got a response

Re: /etc .startup = automatic settings don't appear to make iscsid automatically log in, what do they do?

On Thu, Jul 28, 2016 at 02:50:54AM -0700, james harvey wrote: > Am I doing something wrong to get iscsid to automatically login to certain > nodes, or am I not understanding what the .startup = automatic settings do? > > I was about to post about having trouble getting automatic login to work, >

Re: /etc .startup = automatic settings don't appear to make iscsid automatically log in, what do they do?

On Thu, Jul 28, 2016 at 03:00:28AM -0700, darli...@gmail.com wrote: > Arch. Kernel 4.6.4. open-iscsi 2.0_873. > > Oh boy, that might be my problem right there for one or both of my posts. > Is the latest open-iscsi release really from 2012? > > Are there plans to tag another release, or is it

Re: [PATCHv2] MAINTAINERS: Update open-iscsi maintainers

On Mon, Sep 26, 2016 at 06:50:19PM -0700, The Lee-Man wrote: > Christoph Hellwig suggested we do away with the open-iscsi google group > (this group) and use linux-scsi. > > Any thoughts on this? (removed others on the cc list). I'm OK with moving to linux-scsi if they don't mind userspace stuff

version 2.0.874 tagged

Hi all, There's been a lot of requests for an overdue tagged release with a new version. I've gone ahead and done that on github, creating version 2.0.874. I merged a few typo fixes, updated URLs and version numbers, but there shouldn't be any surprises from what's been on the development head f

Re: Thanks for merging + other things (was: Re: Patches carried in Debian)

On Sun, Oct 02, 2016 at 12:34:31PM +0200, Christian Seiler wrote: > Hi again, > > Many thanks for merging PR #29 and adding them to 2.0.874. > > I'd still like to hear your thoughts on the two other things I > mentioned here: > > On 09/18/2016 06:42 PM, Christian Seiler wrote: > > We carry an ad

Re: Does iSCSI protocol have an integrated cache scheme?

On Tue, Oct 11, 2016 at 10:36:00AM +0800, 孟祥辉 wrote: > Hi Ulrich, > > you maybe misunderstood my purpose, i am not going to do caching on > iSCSI transport layer. you are right that iSCSI devices can be > cached just as normal block devices are. indeed a normal block device > can be cached using

Re: [PATCH] iscsi_ibft,iscsi_boot: remove CAP_SYS_ADMIN restriction for reading entries

On Wed, Oct 05, 2016 at 11:00:57PM +0200, Christian Seiler wrote: > On 10/05/2016 08:28 PM, Dan Williams wrote: > > This is more about root processes dropping unnecessary privileges after > > starting. But at least for the network stuff, there doesn't seem to be > > a good reason to restrict stuff

Re: [RFC 1/3] iscsid: Changes to support the new qedi transport

On Wed, Oct 19, 2016 at 01:02:18AM -0400, nilesh.jav...@cavium.com wrote: > From: Nilesh Javali > > qedi is not attached to netdev hence avoid suppressing warnings. > > Signed-off-by: Manish Rangankar > Signed-off-by: Adheer Chandravanshi > Signed-off-by: Nilesh Javali > --- > usr/initiator_

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

n at unexpected times that would hit it. I don't like having known list locking violations hanging around, based on an expectation that we'll never hit that path with well behaved targets. If we can get a fix worked up for the list locking here, can we get any testing on it from the origina

iscsi: make mutex for target scanning and unbinding per-session

allel, speeding up connecting to a large number of targets. Note that as iscsi_tcp creates a virtual host for each session, software iSCSI is effectively doing this already. Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 19 ++- include/scsi/scsi_transport_is

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote: > > Sure! Count on us to test any patches. I guess the first step is to > reproduce on upstream right? We haven't tested specifically this > scenario for long time. Will try to reproduce on 4.9-rc4 and update here. Great, I'm lo

Re: iscsi: make mutex for target scanning and unbinding per-session

On Thu, Nov 10, 2016 at 10:00:54AM -0800, The Lee-Man wrote: > On Monday, November 7, 2016 at 11:22:23 AM UTC-7, Chris Leech wrote: > > > > Currently the iSCSI transport class synchronises target scanning and > > unbinding with a host level mutex. For multi-session hosts (

Re: iscsi: make mutex for target scanning and unbinding per-session

On Thu, Nov 10, 2016 at 05:22:44PM -0600, Mike Christie wrote: > On 11/07/2016 12:22 PM, Chris Leech wrote: > > Currently the iSCSI transport class synchronises target scanning and > > unbinding with a host level mutex. For multi-session hosts (offloading > > iSCSI HBAs)

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

Thanks Dave, I'm hitting a bug at scatterlist.h:140 before I even get any iSCSI modules loaded (virtio block) so there's something else going on in the current merge window. I'll keep an eye on it and make sure there's nothing iSCSI needs fixing for. Chris On Thu, Dec 15, 2016 at 09:29:53AM +11

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Wed, Dec 21, 2016 at 03:19:15PM -0800, Linus Torvalds wrote: > Hi, > > On Wed, Dec 21, 2016 at 2:16 PM, Dave Chinner wrote: > > On Fri, Dec 16, 2016 at 10:59:06AM -0800, Chris Leech wrote: > >> Thanks Dave, > >> > >> I'm hitting a bug a

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Thu, Dec 22, 2016 at 05:50:12PM +1100, Dave Chinner wrote: > On Wed, Dec 21, 2016 at 09:46:37PM -0800, Linus Torvalds wrote: > > On Wed, Dec 21, 2016 at 9:13 PM, Dave Chinner wrote: > > > > > > There may be deeper issues. I just started running scalability tests > > > (e.g. 16-way fsmark create

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Fri, Dec 23, 2016 at 07:53:50AM +0800, Ming Lei wrote: > On Fri, Dec 23, 2016 at 2:50 AM, Chris Leech wrote: > > I'm not reproducing any problems with xfstests running over iscsi_tcp > > right now. Two 10G luns exported from an LIO target, attached directly > > t

Re: iscsiadm and lots of sessions

Hi, We'd need to know what version of the iSCSI tools you're using, distro vendor and package version or built from upstream sources. This should have been fixed about a year ago in the upstream source. Thanks, Chris - Original Message - > Hi, > I am running iscsiadm on CentOS 6.6. > I

  1   2   3   >