[PATCH 1/2] Do not run discovery on portals that open-iscsi is logged-in to

2008-01-16 Thread Erez Zilber
Running a discovery on a portal that open-iscsi is logged in to may result in changes to a logged-in node (like changing the node's transport type). Changing these properties shouldn't be done while logged in. Signed-off-by: Erez Zilber [EMAIL PROTECTED] --- utils/iscsi_discovery |6

Re: setting up initiator-target pair

2008-01-16 Thread Erez Zilber
__mango wrote: I am trying to set up an iscsi communication. I use open- iscsi-2.0-865.15 for initiator and iscsitarget-0.4.0 as target. 1. Is this target compatible with the initiator. It should be. I think that many people use that target (although I don't). 2. There is no issue

Re: Error inserting scsi_transport_iscsi

2008-02-05 Thread Erez Zilber
Sethih Nang wrote: Here's what I got by doing that. scsi_transport_iscsi: version magic '2.6.18-rc3DH4 mod_unload K7 REGPARM gcc-4.0' should be '2.6.18-rc3DH4 SMP mod_unload PENTIUM4 gcc-4.0' libiscsi: version magic '2.6.18-rc3DH4 mod_unload K7 REGPARM gcc-4.0' should be '2.6.18-rc3DH4 SMP

Re: slow failover with multipath and open-iscsi

2008-02-17 Thread Erez Zilber
Mike Christie wrote: Erez Zilber wrote: Mike, We're testing open-iscsi + multipath. In order to make failover faster, we changed the following defaults: node.session.timeo.replacement_timeout = 30 node.conn[0].timeo.noop_out_timeout = 5 Is .timeo.noop_out_interval 10

Removing the transport module before iscsid

2008-04-07 Thread Erez Zilber
Mike, We're trying to solve a problem, but first the motivation: a user may want to stop the InfiniBand modules (/etc/init.d/openibd stop) while open-iscsi is running. In order to do that, we must remove ib_iser. Now, the question: is it ok to modprobe -r ib_iser (or iscsi_tcp) before stopping

[PATCH] IB/iSER: Release connection resources when receiving a RDMA_CM_EVENT_DEVICE_REMOVAL event

2008-04-08 Thread Erez Zilber
() call. Signed-off-by: Erez Zilber [EMAIL PROTECTED] --- drivers/infiniband/ulp/iser/iscsi_iser.h |2 ++ drivers/infiniband/ulp/iser/iser_verbs.c | 18 ++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers

Re: Removing the transport module before iscsid

2008-04-08 Thread Erez Zilber
Mike Christie wrote: Erez Zilber wrote: Mike, We're trying to solve a problem, but first the motivation: a user may want to stop the InfiniBand modules (/etc/init.d/openibd stop) while open-iscsi is running. In order to do that, we must remove ib_iser. Now, the question: is it ok

[PATCH 1/2] Release transport entry when the transport is unloaded

2008-04-10 Thread Erez Zilber
-off-by: Erez Zilber [EMAIL PROTECTED] --- usr/iscsi_sysfs.c | 16 usr/iscsi_sysfs.h |1 + usr/netlink.c | 10 ++ 3 files changed, 27 insertions(+), 0 deletions(-) diff --git a/usr/iscsi_sysfs.c b/usr/iscsi_sysfs.c index dd38379..39c8e9c 100644 --- a/usr

[PATCH 2/2] Notify when transport is unloaded

2008-04-10 Thread Erez Zilber
When a transport (e.g. iscsi_tcp, ib_iser) is unloaded, a notification must be sent to userspace. This will allow the userspace code to release all transport related resources. Signed-off-by: Erez Zilber [EMAIL PROTECTED] --- drivers/scsi/scsi_transport_iscsi.c | 31

[PATCH 0/2] Release userspace transport entry when a transport is unloaded

2008-04-10 Thread Erez Zilber
The following series of patches fixes a bug in iscsid: if a transport is unloaded and then reloaded, the transport entry in iscsid is still the old one. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi

[PATCH 1/2] IB/iser: Logout from open-iscsi over iSER sessions before stopping openibd

2008-04-10 Thread Erez Zilber
Some users may try to stop openibd while open-iscsi over iSER is running. When stopping openibd, the script should check if there are open-iscsi sessions that use the iSER transport and ask the user to logout from these sessions before shutting down openibd. Signed-off-by: Erez Zilber [EMAIL

[PATCH 2/2] IB/iser: Ask the user to stop open-iscsi before stopping openibd on RH4

2008-04-10 Thread Erez Zilber
openibd. The user must be prompted to stop open-iscsi before stopping openibd. Signed-off-by: Erez Zilber [EMAIL PROTECTED] --- ofed_scripts/ofa_kernel.spec |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/ofed_scripts/ofa_kernel.spec b/ofed_scripts/ofa_kernel.spec index

[PATCH 1/2 v2] Release transport entry when the transport is unloaded

2008-04-14 Thread Erez Zilber
-off-by: Erez Zilber [EMAIL PROTECTED] --- usr/iscsi_sysfs.c | 15 +++ usr/iscsi_sysfs.h |1 + usr/netlink.c | 10 ++ 3 files changed, 26 insertions(+), 0 deletions(-) diff --git a/usr/iscsi_sysfs.c b/usr/iscsi_sysfs.c index dd38379..6efb8a9 100644 --- a/usr

[PATCH 2/2 v2] Notify when transport is unloaded

2008-04-14 Thread Erez Zilber
When a transport (e.g. iscsi_tcp, ib_iser) is unloaded, a notification must be sent to userspace. This will allow the userspace code to release all transport related resources. Signed-off-by: Erez Zilber [EMAIL PROTECTED] --- drivers/scsi/scsi_transport_iscsi.c | 30

RE: [ofa-general] [PATCH 2/2] IB/iSER: Use offset from r2t header forrdma

2008-04-27 Thread Erez Zilber
usr/iscsi/iscsi_rdma.c | 16 +--- I have no idea what tree this file lives in so I'll just ignore this patch, right? As Eli mentioned in PATCH 0/2, the patch set contains a fix for the initiator side and another fix for the iSER code in stgt. That's why Fujita Tomonori (who

Re: Publishing iSER limitations

2008-04-28 Thread Erez Zilber
* Host per session or host per IB device: I agree with Or about the need to have a host per session. I understand that the main problem that commit 7e8e8af6511afafff33ef7eb0f519bf8702b78ed tries to solve is what happens if we failover from one IB device to

Re: help: Read-only file system

2008-04-29 Thread Erez Zilber
Sean, hello. I tried to reproduce what you described. This what I installed: Initiator: (Redhat 5) OFED 2.1.5.1 with iscsi-initiator-utils-2.0-865 You meant to say 1.2.5.1. Mention that this is the open-iscsi version that is shipped with 1.2.5.1. I suggest that you fix this error.

RE: [PATCH] Fix indentation

2008-04-30 Thread Erez Zilber
Fix indentation and remove trailing spaces. Signed-off-by: Erez Zilber [EMAIL PROTECTED] Mike? Are you ok with this patch? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post

Re: [PATCH] Fix indentation

2008-05-04 Thread Erez Zilber
Erez Zilber wrote: Mike Christie wrote: Erez Zilber wrote: Fix indentation and remove trailing spaces. Signed-off-by: Erez Zilber [EMAIL PROTECTED] Mike? Are you ok with this patch? It is already broken. Did you run a script

[PATCH] Add compat patch for RHEL 5.2

2008-07-09 Thread Erez Zilber
RHEL 5.2 is based on kernel version 2.6.18, but contains code that wasn't included in 2.6.18 vanilla. The kernel Makefile uses 2.6.14-19_compat.patch for it, and this creates compilation errors of symbol redefinition. We should have a separate compat patch for RHEL 5.2. Signed-off-by: Erez Zilber

Re: [PATCH] Add compat patch for RHEL 5.2

2008-07-13 Thread Erez Zilber
On Wed, Jul 9, 2008 at 11:22 AM, Erez Zilber [EMAIL PROTECTED] wrote: RHEL 5.2 is based on kernel version 2.6.18, but contains code that wasn't included in 2.6.18 vanilla. The kernel Makefile uses 2.6.14-19_compat.patch for it, and this creates compilation errors of symbol redefinition. We

Re: [PATCH] Add compat patch for RHEL 5.2

2008-07-15 Thread Erez Zilber
On Tue, Jul 15, 2008 at 3:42 AM, Mike Christie [EMAIL PROTECTED] wrote: Erez Zilber wrote: On Wed, Jul 9, 2008 at 11:22 AM, Erez Zilber [EMAIL PROTECTED] wrote: RHEL 5.2 is based on kernel version 2.6.18, but contains code that wasn't included in 2.6.18 vanilla. The kernel Makefile uses

Re: iSER login process

2008-08-20 Thread Erez Zilber
On Wed, Aug 20, 2008 at 12:04 AM, Jesse Butler [EMAIL PROTECTED] wrote: Ok, I've tried the configuration and login now whilst specifying the TPGT. I don't hit the same error now, but I do see this: # iscsiadm -m node -T iqn.1986-03.com.sun:02:aff22998-3466-4bf4-ee3c-958fd4b5d346 -p

Re: Build problems with 869.2

2008-08-26 Thread Erez Zilber
On Tue, Aug 26, 2008 at 11:20 AM, v42bis [EMAIL PROTECTED] wrote: Just saw the thread about rhel5 symbol problems, which seems to be my issue. Tried to apply the patch from Erez to 869.2 source, but it failed :( Try the attached patch. Erez

open-iscsi looks broken on 2.6.27-rc4

2008-08-31 Thread Erez Zilber
I'm trying to run with the open-iscsi kernel tree (2.6.27-rc4). I wasn't able to build the open-iscsi tree, so I added the following patch: diff --git a/kernel/Makefile b/kernel/Makefile index 139fd7b..7c5b5ac 100644 --- a/kernel/Makefile +++ b/kernel/Makefile @@ -101,6 +101,8 @@ linux_2_6_25:

[PATCH] Add .gitignore files

2008-09-10 Thread Erez Zilber
Some files should not be tracked by git. Signed-off-by: Erez Zilber [EMAIL PROTECTED] --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi

Re: git-describe doesn't show the most recent tag

2008-09-28 Thread Erez Zilber
On Sun, Sep 28, 2008 at 5:39 PM, Pierre Habouzit [EMAIL PROTECTED] wrote: On Sun, Sep 28, 2008 at 02:29:21PM +, Erez Zilber wrote: On Sun, Sep 28, 2008 at 4:55 PM, Pierre Habouzit [EMAIL PROTECTED] wrote: On Sun, Sep 28, 2008 at 01:48:42PM +, Erez Zilber wrote: Why is this happening

Future tags in the open-iscsi git tree

2008-10-02 Thread Erez Zilber
Mike, I don't know if you read the whole discussion about light-weight annotated tags. Anyway, it looks like it would be better to use only annotated tags in the future because many automatic tools (e.g. git-describe) ignore light-weight tags. Thanks, Erez

Is MaxOutstandingR2T hardcoded?

2009-01-07 Thread Erez Zilber
I noticed that if I change the value of node.session.iscsi.MaxOutstandingR2T to some value 1 (and the target also supports a value higher than 1), it is still negotiated to '1'. I saw that the login PDU itself contains 'MaxOutstandingR2T = 1'. I took a look at the code and found this in

Re: Is MaxOutstandingR2T hardcoded?

2009-01-08 Thread Erez Zilber
On Wed, Jan 7, 2009 at 8:34 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: I noticed that if I change the value of node.session.iscsi.MaxOutstandingR2T to some value 1 (and the target also supports a value higher than 1), it is still negotiated to '1'. I saw

Re: iSER error, please help

2009-01-21 Thread Erez Zilber
On Wed, Jan 21, 2009 at 3:31 PM, Rumburak bota.flo...@gmail.com wrote: Hello, I am trying to configure iSCSI over iSER on two server (one acting as target - with tgtd, and the other acting as initiator with open- iscsi). Already installe OFED and have RDMA working (tested with rping).

Re: Disable aggregation of requests

2009-02-17 Thread Erez Zilber
On Tue, Feb 17, 2009 at 11:35 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: Hi, I'm running a setup of open-iscsi connected to a target. When I run I/O from the initiator (e.g using dd) with transaction size of 128kB, I sometimes see that 2 128kB requests are aggregated

Re: Disable aggregation of requests

2009-02-18 Thread Erez Zilber
On Wed, Feb 18, 2009 at 10:36 AM, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: On 18 Feb 2009 at 8:44, Erez Zilber wrote: On Tue, Feb 17, 2009 at 11:35 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: Hi, I'm running a setup of open-iscsi connected

Re: Disable aggregation of requests

2009-02-19 Thread Erez Zilber
On Wed, Feb 18, 2009 at 10:09 PM, Boaz Harrosh bharr...@panasas.com wrote: Mike Christie wrote: Erez Zilber wrote: On Tue, Feb 17, 2009 at 11:35 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: Hi, I'm running a setup of open-iscsi connected to a target. When I run I/O

Improving kernel logs in open-iscsi

2009-03-09 Thread Erez Zilber
Currently, open-iscsi uses debug_scsi debug_tcp for logging. This is controlled by DEBUG_SCSI DEBUG_TCP. The current method is problematic because you can't enable/disable these logs without recompiling. Before I start working on it, I'd like to discuss it and decide how to do that. If we have

corruption in session list

2009-04-27 Thread Erez Zilber
From time to time, I see errors like the following when I run 'iscsiadm -m session': tcp: [2] []:-1,1 ��A�¹V��� Is it a known bug? I don't know how to reproduce it. It just happens. Thanks, Erez --~--~-~--~~~---~--~~ You received this message because you

No abort is sent for a WRITE command that takes too long

2009-05-14 Thread Erez Zilber
Hi, I'm running a setup of open-iscsi SCST. In order to test error scenarios during a WRITE command, I've added a delay in SCST, so after it receives the command, it doesn't send an R2T for 20 seconds. I also modified the device timeout on the initiator side to 5 seconds. However, I don't see

Re: No abort is sent for a WRITE command that takes too long

2009-05-14 Thread Erez Zilber
On Thu, May 14, 2009 at 2:54 PM, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: On 14 May 2009 at 13:12, Erez Zilber wrote: Hi, I'm running a setup of open-iscsi SCST. In order to test error scenarios during a WRITE command, I've added a delay in SCST, so after it receives

Re: No abort is sent for a WRITE command that takes too long

2009-05-14 Thread Erez Zilber
On Thu, May 14, 2009 at 5:55 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: Hi, I'm running a setup of open-iscsi SCST. In order to test error scenarios during a WRITE command, I've added a delay in SCST, so after it receives the command, it doesn't send an R2T for 20

Re: No abort is sent for a WRITE command that takes too long

2009-05-18 Thread Erez Zilber
On Mon, May 18, 2009 at 4:36 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: I enabled open-iscsi logging + added some printk calls when the abort handler returns. Here's the log. I see that iscsi_eh_cmd_timed_out gets called, but there's no abort. May 17 11:00:06 kpc36

Re: No abort is sent for a WRITE command that takes too long

2009-05-18 Thread Erez Zilber
On Mon, May 18, 2009 at 6:01 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: On Mon, May 18, 2009 at 4:36 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: I enabled open-iscsi logging + added some printk calls when the abort handler returns. Here's the log

Re: Improving kernel logs in open-iscsi

2009-05-20 Thread Erez Zilber
On Mon, Mar 9, 2009 at 7:16 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: Currently, open-iscsi uses debug_scsi debug_tcp for logging. This is controlled by DEBUG_SCSI DEBUG_TCP. The current method is problematic because you can't enable/disable these logs without

Re: Improving kernel logs in open-iscsi

2009-06-04 Thread Erez Zilber
, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~--- From 93034f7bbc0a6c9d6fb5b84984cbef831d15ac55 Mon Sep 17 00:00:00 2001 From: Erez Zilber erezzi.l...@gmail.com

[PATCH] Add Module.markers to .gitignore

2009-06-04 Thread Erez Zilber
...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~--- From 509f8c8eecf4992e84eb1fe7467bdecdd0b3463a Mon Sep 17 00:00:00 2001 From: Erez Zilber erezzi.l...@gmail.com Date: Thu, 4 Jun 2009 19:06:20 +0300 Subject

Re: Improving kernel logs in open-iscsi

2009-06-07 Thread Erez Zilber
On Thu, Jun 4, 2009 at 7:59 PM, Mike Christiemicha...@cs.wisc.edu wrote: Erez Zilber wrote: With that patch you can do both. module_params are exposed in sysfs and if you set IWUSR then you can write to it. echo 1 /sys/module/libiscsi/debug_libiscsi to turn on echo 0 /sys/module

Re: Improving kernel logs in open-iscsi

2009-06-10 Thread Erez Zilber
On Mon, Jun 8, 2009 at 7:38 PM, Mike Christiemicha...@cs.wisc.edu wrote: Erez Zilber wrote: With that patch you can do both. module_params are exposed in sysfs and if you set IWUSR then you can write to it. echo 1 /sys/module/libiscsi/debug_libiscsi to turn on echo 0 /sys/module

Re: RFC: do we need a new list for kernel patches

2009-06-14 Thread Erez Zilber
Having everything in a single list sounds like a better idea to me. If we have 2 lists, many people will have to monitor both. Erez --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this

logout call doesn't return

2009-06-23 Thread Erez Zilber
Mike, I'm trying to debug a problem that we have with iscsiadm: I'm running open-iscsi against multiple targets. At some point, I'm closing the connection from one of the targets (i.e. on the target side). Then, I try to logout from the initiator side, but something goes wrong. The last thing

Race during logout

2009-07-22 Thread Erez Zilber
Mike, I'm seeing from time to time the following scenario (although currently I'm not able to reproduce it): 1. A logout from a node is initiated by the user. 2. Before the logout completes, the user runs /etc/init.d/iscsi stop. The 'stop' method logs out from all nodes. When it tries to logout

logout takes ~50 seconds while running heavy IO

2009-07-30 Thread Erez Zilber
Mike, I'm seeing some strange behavior that I don't completely understand: during heavy IO, I disconnect the cable on the target machine and after a few seconds, I'm trying to logout from that target on the initiator side. Here's what I see: t = 0: iscsi_eh_cmd_timed_out gets called for all

Re: logout takes ~50 seconds while running heavy IO

2009-07-31 Thread Erez Zilber
On Thu, Jul 30, 2009 at 8:25 PM, Mike Christiemicha...@cs.wisc.edu wrote: Mike Christie wrote: Erez Zilber wrote: Mike, I'm seeing some strange behavior that I don't completely understand: during heavy IO, I disconnect the cable on the target machine and after a few seconds, I'm trying

Re: logout takes ~50 seconds while running heavy IO

2009-07-31 Thread Erez Zilber
On Fri, Jul 31, 2009 at 9:43 AM, Ulrich Windlulrich.wi...@rz.uni-regensburg.de wrote: On 30 Jul 2009 at 19:25, Erez Zilber wrote: Mike, I'm seeing some strange behavior that I don't completely understand: during heavy IO, I disconnect the cable on the target machine and after a few

Re: logout takes ~50 seconds while running heavy IO

2009-08-03 Thread Erez Zilber
On Sat, Aug 1, 2009 at 6:31 AM, Mike Christiemicha...@cs.wisc.edu wrote: Mike Christie wrote: Mike Christie wrote: Mike Christie wrote: Mike Christie wrote: On 07/31/2009 07:43 AM, Erez Zilber wrote: I thought that this patch just reduces the timeout from 15 to 3. Does it also fix the 3

Re: [PATCH] decrease sndtmo

2009-08-04 Thread Erez Zilber
On Sat, Aug 1, 2009 at 6:34 AM, Mike Christiemicha...@cs.wisc.edu wrote: Mike Christie wrote: On 07/31/2009 04:03 AM, Hannes Reinecke wrote: Mike Christie wrote: tcp_sendpages/tcp_sendmsg can wait sndtmo seconds if a connection goes bad. This then delays session recovery, because that code

Re: [PATCH] decrease sndtmo

2009-08-04 Thread Erez Zilber
On Tue, Aug 4, 2009 at 8:17 PM, Mike Christiemicha...@cs.wisc.edu wrote: Erez Zilber wrote: I'm running with open-iscsi.git HEAD + the check suspend bit patch + the wake xmit on error patch. If I disconnect the cable on the initiator side (even while not running IO), I see that after

Re: [PATCH] decrease sndtmo

2009-08-05 Thread Erez Zilber
On Wed, Aug 5, 2009 at 7:45 PM, Mike Christiemicha...@cs.wisc.edu wrote: On 08/05/2009 11:33 AM, Mike Christie wrote: On 08/05/2009 11:26 AM, Mike Christie wrote: On 08/05/2009 11:01 AM, Erez Zilber wrote: On Wed, Aug 5, 2009 at 6:19 PM, Mike Christiemicha...@cs.wisc.edu     wrote: On 08

Re: [PATCH] decrease sndtmo

2009-08-06 Thread Erez Zilber
On Wed, Aug 5, 2009 at 10:22 PM, Mike Christiemicha...@cs.wisc.edu wrote: On 08/05/2009 12:34 PM, Erez Zilber wrote: I found it. The problem is that we will send the signal if the xmit thread is running or not. If it is not running the workqueue code will keep getting woken up to handle

[PATCH] Fix compilation warnings in usr/kernel code

2009-09-03 Thread Erez Zilber
Fix compilation warnings and modify the Makefiles to treat warnings as errors. Signed-off-by: Erez Zilber erezzi.l...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group

Re: [PATCH] Fix compilation warnings in usr/kernel code

2009-09-03 Thread Erez Zilber
On Thu, Sep 3, 2009 at 7:21 PM, Erez Zilbererezzi.l...@gmail.com wrote: Fix compilation warnings and modify the Makefiles to treat warnings as errors. Signed-off-by: Erez Zilber erezzi.l...@gmail.com 2 comments about this patch: 1. I'm not familiar enough with the fwparam_ibft code, so I

Re: [PATCH] Fix compilation warnings in usr/kernel code

2009-09-09 Thread Erez Zilber
On Tue, Sep 8, 2009 at 9:01 PM, Mike Christiemicha...@cs.wisc.edu wrote: On 09/06/2009 02:11 AM, Erez Zilber wrote: On Thu, Sep 3, 2009 at 8:02 PM, Mike Christiemicha...@cs.wisc.edu  wrote: On 09/03/2009 11:21 AM, Erez Zilber wrote: Fix compilation warnings and modify the Makefiles to treat

open-iscsi and multiqueue

2009-11-04 Thread Erez Zilber
Mike, Can open-iscsi utilize the multiqueue feature (http://lwn.net/Articles/289137/) in order to improve performance? If yes, does it require any change in open-iscsi? Did you try to measure the performance improvement? Thanks, Erez --~--~-~--~~~---~--~~ You

Information about iSCSI pings that almost timed out

2009-11-18 Thread Erez Zilber
open-iscsi sends nop-outs to the target. If the target responds quick enough, we don't get a timeout. I'd like to know (for internal debug purposes) how many times the ping timer almost expired. This sounds like a useful feature also for other open-iscsi developers/users. I was thinking about

Re: Information about iSCSI pings that almost timed out

2009-11-18 Thread Erez Zilber
On Thu, Nov 19, 2009 at 2:49 AM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: open-iscsi sends nop-outs to the target. If the target responds quick enough, we don't get a timeout. I'd like to know (for internal debug purposes) how many times the ping timer almost expired

Re: Information about iSCSI pings that almost timed out

2009-11-19 Thread Erez Zilber
On Thu, Nov 19, 2009 at 9:38 AM, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: Hi! Wouldn't it be more obvious to calculate the average delay to a ping request? (Possibly exponential average as for the system loads) (min and Max would be good as well, but standard deviation probably

Re: Information about iSCSI pings that almost timed out

2009-11-22 Thread Erez Zilber
On Thu, Nov 19, 2009 at 10:02 PM, Mike Christie micha...@cs.wisc.edu wrote: Ulrich Windl wrote: On 19 Nov 2009 at 11:07, Erez Zilber wrote: On Thu, Nov 19, 2009 at 9:38 AM, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: Hi! Wouldn't it be more obvious to calculate the average delay

Re: Information about iSCSI pings that almost timed out

2009-11-22 Thread Erez Zilber
On Sun, Nov 22, 2009 at 10:44 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: On Thu, Nov 19, 2009 at 10:02 PM, Mike Christie micha...@cs.wisc.edu wrote: Ulrich Windl wrote: On 19 Nov 2009 at 11:07, Erez Zilber wrote: On Thu, Nov 19, 2009 at 9:38 AM, Ulrich Windl ulrich.wi

Re: Information about iSCSI pings that almost timed out

2009-12-01 Thread Erez Zilber
On Sun, Nov 22, 2009 at 10:44 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: On Thu, Nov 19, 2009 at 10:02 PM, Mike Christie micha...@cs.wisc.edu wrote: Ulrich Windl wrote: On 19 Nov 2009 at 11:07, Erez Zilber wrote: On Thu, Nov 19, 2009 at 9:38 AM, Ulrich Windl ulrich.wi

Re: [PATCH] Maintain a list of nop-out PDUs that almost timed out

2009-12-01 Thread Erez Zilber
On Tue, Dec 1, 2009 at 2:57 PM, Erez Zilber erezzi.l...@gmail.com wrote: On Sun, Nov 22, 2009 at 11:24 PM, Erez Zilber erezzi.l...@gmail.com wrote: On Sun, Nov 22, 2009 at 10:44 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: On Thu, Nov 19, 2009 at 10:02 PM, Mike Christie

Re: [PATCH] Maintain a list of nop-out PDUs that almost timed out

2009-12-01 Thread Erez Zilber
On Tue, Dec 1, 2009 at 3:16 PM, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: On 1 Dec 2009 at 14:57, Erez Zilber wrote: Maintain a list of nop-out PDUs that almost timed out. With this information, you can understand and debug the whole system: you can check your target and see what

Suggestion for new logging mechanism in open-iscsi

2009-12-02 Thread Erez Zilber
I'd like to make some changes in the logging in open-iscsi. The current status is as follows: kernel modules: * We use iscsi_cls_session_printk iscsi_cls_conn_printk in scsi_transport_iscsi.c. They are sometimes wrapped by macros (e.g. ISCSI_DBG_TRANS_SESSION). These macros use KERN_INFO and

Re: Suggestion for new logging mechanism in open-iscsi

2009-12-02 Thread Erez Zilber
On Wed, Dec 2, 2009 at 3:02 PM, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: On 2 Dec 2009 at 10:55, Erez Zilber wrote: I'd like to make some changes in the logging in open-iscsi. The current status is as follows: kernel modules: * We use iscsi_cls_session_printk

Re: Suggestion for new logging mechanism in open-iscsi

2009-12-07 Thread Erez Zilber
On Mon, Dec 7, 2009 at 7:24 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: I'd like to make some changes in the logging in open-iscsi. The current status is as follows: kernel modules: * We use iscsi_cls_session_printk iscsi_cls_conn_printk in scsi_transport_iscsi.c

Re: Information about iSCSI pings that almost timed out

2009-12-08 Thread Erez Zilber
Regrading the average delay of a ping request task - we need to have the average delay, but we're interested only in the average delay of pings that were sent lately (i.e. not pings that were sent a year ago). Am I right? I thought about having a cyclic array of delays in the kernel. It can

Re: How to make a 2.6..*_compat.patch without sub-directory?

2009-12-14 Thread Erez Zilber
Use git diff --relative (when you're in the open-iscsi/kernel dir). Erez On Mon, Dec 14, 2009 at 8:25 PM, Yangkook Kim yangkook...@gmail.com wrote: I posted similar message on other thread, but let me ask the same question with diffrent tittle. I want to make a kernel compat patch without

Re: [PATCH] Maintain a list of nop-out PDUs that almost timed out

2009-12-15 Thread Erez Zilber
On Tue, Dec 15, 2009 at 10:34 AM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: Maintain a list of nop-out PDUs that almost timed out. With this information, you can understand and debug the whole system: you can check your target and see what caused it to be so slow

Re: Help:insmod: error inserting ib_iser.ko

2009-12-15 Thread Erez Zilber
On Tue, Dec 15, 2009 at 12:26 PM, DeepBlue zhangxintaofi...@gmail.com wrote: There is a error with I inserting the ib_iser.ko module as following: [r...@localhost init.d]# insmod /lib/modules/2.6.18-8.el5/kernel/

Re: Help:insmod: error inserting ib_iser.ko

2009-12-16 Thread Erez Zilber
want the open-iscsi run normally run,can you  help me? 2009/12/16 Erez Zilber erezzi.l...@gmail.com On Tue, Dec 15, 2009 at 12:26 PM, DeepBlue zhangxintaofi...@gmail.com wrote: There is a error with I inserting the ib_iser.ko module as following

Re: Suggestion for new logging mechanism in open-iscsi

2009-12-16 Thread Erez Zilber
On Wed, Dec 2, 2009 at 10:55 AM, Erez Zilber erezzi.l...@gmail.com wrote: I'd like to make some changes in the logging in open-iscsi. The current status is as follows: kernel modules: * We use iscsi_cls_session_printk iscsi_cls_conn_printk in scsi_transport_iscsi.c. They are sometimes

Re: Help:insmod: error inserting ib_iser.ko

2009-12-20 Thread Erez Zilber
zhangxintaofi...@gmail.com Thanks Erez 2009/12/16 Erez Zilber erezzi.l...@gmail.com I guess that you want to run open-iscsi over iscsi_tcp which is the default open-iscsi transport. Assuming that all other modules were loaded successfully (libiscsi, iscsi_tcp, scsi_transport_iscsi and libiscsi_tcp

Re: Help:insmod: error inserting ib_iser.ko

2009-12-21 Thread Erez Zilber
the target disk. I want know what tools I can use if I use the ib_iSER module or I don't want see the error prompt in the screen. Do you have good idae ? 2009/12/20 Erez Zilber erezzi.l...@gmail.com Please do the following: 1. Stop open-iscsi: make sure that 'lsmod | grep iscsi' 'ps aux

Re: Help:insmod: error inserting ib_iser.ko

2009-12-21 Thread Erez Zilber
if I use the ib_iSER module or I don't want see the error prompt in the screen. Do you have good idae ? 2009/12/20 Erez Zilber erezzi.l...@gmail.com Please do the following: 1. Stop open-iscsi: make sure that 'lsmod | grep iscsi' 'ps aux | grep iscsi' return nothing. 2. Make sure

Re: [PATCH] Maintain a list of nop-out PDUs that almost timed out

2009-12-28 Thread Erez Zilber
On Sun, Dec 20, 2009 at 3:57 PM, Erez Zilber erezzi.l...@gmail.com wrote: On Thu, Dec 17, 2009 at 5:01 AM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: On Tue, Dec 15, 2009 at 10:34 AM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: Maintain a list of nop-out

kernel oops in resched_task

2010-01-06 Thread Erez Zilber
Hi, I got this oops while running open-iscsi on a CentOS 5.3 machine (don't know how to recreate it). it crashes while trying to wake up the work queue after queuecommand was called. Has anyone seen something similar? Jan 2 22:24:27 172.16.9.55 RIP: 0010:[8008cccf] Jan 2 22:24:27

Re: Suggestion for new logging mechanism in open-iscsi

2010-01-13 Thread Erez Zilber
On Wed, Dec 16, 2009 at 5:31 PM, Erez Zilber erezzi.l...@gmail.com wrote: On Wed, Dec 2, 2009 at 10:55 AM, Erez Zilber erezzi.l...@gmail.com wrote: I'd like to make some changes in the logging in open-iscsi. The current status is as follows: kernel modules: * We use iscsi_cls_session_printk

Re: Suggestion for new logging mechanism in open-iscsi

2010-01-14 Thread Erez Zilber
On Thu, Jan 14, 2010 at 10:44 AM, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: On 13 Jan 2010 at 18:56, Erez Zilber wrote: Hi! I wonder whether the #define could be replaced with an inline function. The readability would be much better, and the code should be more or less the same

Re: Suggestion for new logging mechanism in open-iscsi

2010-01-14 Thread Erez Zilber
On Thu, Jan 14, 2010 at 1:04 PM, Erez Zilber erezzi.l...@gmail.com wrote: On Thu, Jan 14, 2010 at 10:44 AM, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: On 13 Jan 2010 at 18:56, Erez Zilber wrote: Hi! I wonder whether the #define could be replaced with an inline function

2.6.14-23_compat.patch CentOS 5.4

2010-01-31 Thread Erez Zilber
Hi, When I build open-iscsi on CentOS 5.4, I get the following errors: In file included from /home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.h:30, from /home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.c:30:

Re: [PATCH] Maintain a list of nop-out PDUs that almost timed out

2010-01-31 Thread Erez Zilber
On Fri, Jan 29, 2010 at 8:59 PM, Mike Christie micha...@cs.wisc.edu wrote: On 01/28/2010 09:25 AM, Erez Zilber wrote: +struct iscsi_noop_info { +       struct timeval tv; Can you pass this between userspace and the kernel safely? The fields in there are longs, and I thought those could

Re: 2.6.14-23_compat.patch CentOS 5.4

2010-01-31 Thread Erez Zilber
On Sun, Jan 31, 2010 at 8:24 PM, Rakesh Ranjan rak...@chelsio.com wrote: On 01/31/2010 08:04 PM, Erez Zilber wrote: Hi, When I build open-iscsi on CentOS 5.4, I get the following errors: In file included from /home1/erez.zilber/work/open-source/open-iscsi/kernel/scsi_transport_iscsi.h:30

Reset eh timer if cmd is really making progress

2010-02-01 Thread Erez Zilber
When iscsi_eh_cmd_timed_out gets called, we can ask scsi-ml to give us more time if the cmd is making progress (i.e. if there was some data transfer since the last timeout). The problem is that task-last_xfer task-last_timeout are set to the value of 'jiffies' when allocating the task. If the

Re: 2.6.14-23_compat.patch CentOS 5.4

2010-02-01 Thread Erez Zilber
On Mon, Feb 1, 2010 at 9:29 PM, Mike Christie micha...@cs.wisc.edu wrote: On 02/01/2010 12:42 AM, Erez Zilber wrote: On Sun, Jan 31, 2010 at 8:24 PM, Rakesh Ranjanrak...@chelsio.com  wrote: On 01/31/2010 08:04 PM, Erez Zilber wrote: Hi, When I build open-iscsi on CentOS 5.4, I get

Re: Reset eh timer if cmd is really making progress

2010-02-01 Thread Erez Zilber
On Tue, Feb 2, 2010 at 6:47 AM, Mike Christie micha...@cs.wisc.edu wrote: On 02/01/2010 01:21 PM, Mike Christie wrote: On 02/01/2010 11:52 AM, Mike Christie wrote: On 02/01/2010 05:14 AM, Erez Zilber wrote: When iscsi_eh_cmd_timed_out gets called, we can ask scsi-ml to give us more time

Re: 2.6.14-23_compat.patch CentOS 5.4

2010-02-02 Thread Erez Zilber
On Tue, Feb 2, 2010 at 6:28 AM, Mike Christie micha...@cs.wisc.edu wrote: On 02/01/2010 01:45 PM, Erez Zilber wrote: On Mon, Feb 1, 2010 at 9:29 PM, Mike Christiemicha...@cs.wisc.edu  wrote: On 02/01/2010 12:42 AM, Erez Zilber wrote: On Sun, Jan 31, 2010 at 8:24 PM, Rakesh Ranjanrak

Re: [PATCH] decrease sndtmo

2010-02-02 Thread Erez Zilber
On Thu, Aug 6, 2009 at 5:32 PM, Mike Christie micha...@cs.wisc.edu wrote: On 08/06/2009 05:26 AM, Erez Zilber wrote: On Wed, Aug 5, 2009 at 10:22 PM, Mike Christiemicha...@cs.wisc.edu  wrote: On 08/05/2009 12:34 PM, Erez Zilber wrote: I found it. The problem is that we will send the signal

Re: [PATCH] decrease sndtmo

2010-02-03 Thread Erez Zilber
On Wed, Feb 3, 2010 at 11:30 AM, Mike Christie micha...@cs.wisc.edu wrote: On 02/03/2010 01:50 AM, Erez Zilber wrote: It looks like I posted it at Red Hat and never got a response, and I probably then forgot about it and never asked upstream. Will send mail upstream now. Which list are you

Re: iSCSI disconnections after running iscsistart

2016-03-06 Thread Erez Zilber
Thanks Chris and Mike for clarifying this iscsistart/iscsid issue. Erez On Fri, Mar 4, 2016 at 2:47 AM, Mike Christie <micha...@cs.wisc.edu> wrote: > On 03/03/2016 03:17 PM, Chris Leech wrote: >> On Thu, Mar 03, 2016 at 10:16:45PM +0200, Erez Zilber wrote: >>> Hi, >&g

iSCSI disconnections after running iscsistart

2016-03-03 Thread Erez Zilber
Hi, I'm running iSCSI boot for RHEL & SUSE nodes. Sometimes, after iscsistart is called, errors on the iSCSI target side occur (e.g. temp network disconnection) and the iSCSI connection is disconnected. In the boot log, it looks like this (on a RHEL node): connection1:0: detected conn error