Corrections for Javadoc

2017-05-10 Thread Nir Lisker
I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. I can't submit issues to the JIRA so I'll list them here. A similar issue was https://bugs.openjdk.java.net/browse/JDK-8177341. - The following use "a Observable..." instead of "an Observable...". - javafx.beans.prop

Will there be an API for creating materials?

2017-05-10 Thread Nir Lisker
It seems that currently developers can't create their own material because the abstract class Material is not designed to be subclassed, and so PhongMaterial is the only one available. Are there any plans to allow developers to subclass Material and crate their own materials? Phong is somewhat old

Re: Corrections for Javadoc

2017-05-11 Thread Nir Lisker
ew JBS bug. > > Thank you. > > -- Kevin > > > > > Nir Lisker wrote: > >> I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. >> I can't submit issues to the JIRA so I'll list them here. A similar issue >>

Re: Corrections for Javadoc

2017-05-16 Thread Nir Lisker
gt; > Thanks. > > -- Kevin > > > Nir Lisker wrote: > > Add this to the list as well please: > > javafx.scene.image.Image's constructors: > > - Image(String url) > - Image(String url, boolean backgroundLoading) > - Image(String url, double requestedWidth, doub

Default PointLight for Scene

2017-05-23 Thread Nir Lisker
A Scene supplies a default PointLight if it contains a 3D object. However, adding a Light to any group in the scene removes the default light. Is it possible to retain the light, or get a reference to it from the scene?

Re: Corrections for Javadoc

2017-05-23 Thread Nir Lisker
k.java.net/browse/JDK-8180070 > > I'll add your note to this new JBS bug. > > Thank you. > > -- Kevin > > > > > Nir Lisker wrote: > >> I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. >> I can't submit issues to

Re: Corrections for Javadoc

2017-05-23 Thread Nir Lisker
Yes, I saw that the due date on the report is the 24th. I don't know if it's worth anyone's time, but there are simple scripts that catch all sorts of spelling and grammar mistakes. Pretty sure it won't be that hard to integrate one.

Re: Corrections for Javadoc

2017-05-23 Thread Nir Lisker
method has no doc. On Wed, May 10, 2017 at 7:25 PM, Kevin Rushforth wrote: > I just filed a new issue to catch any last minute typos: > > https://bugs.openjdk.java.net/browse/JDK-8180070 > > I'll add your note to this new JBS bug. > > Thank you. > > -- Kevin >

Re: Default PointLight for Scene

2017-05-23 Thread Nir Lisker
a Color.WHITE > PointLight placed at the camera position. > > > - Chien > > > > > On 05/23/2017 09:11 AM, Nir Lisker wrote: > >> A Scene supplies a default PointLight if it contains a 3D object. However, >> adding a Light to any group in the scene removes the default light. Is it >> possible to retain the light, or get a reference to it from the scene? >> > >

Re: Corrections for Javadoc

2017-05-26 Thread Nir Lisker
Looks like the above didn't make it in time. Can it be fixed in the next batch? On Tue, May 23, 2017 at 9:26 PM, Nir Lisker wrote: > Hopefully this makes it in time: > > javafx.scene.control.TreeView has wrong javadoc for the > queryAccessibleAttribute method. The source

Small javadoc corrections

2017-06-14 Thread Nir Lisker
A few more corrections for the Javadoc: - ListChangeListener.Change, in the code example, "" should be "". In this class refer to the following methods (I'm looking at http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#styleguide ): - getAddedSubList: is phrased unconv

Re: WebView and WebGL

2017-08-25 Thread Nir Lisker
It has been suggested already in https://bugs.openjdk.java.net/browse/JDK-8091035.

Re: WebView and WebGL

2017-09-10 Thread Nir Lisker
I don't want to hijack the WebGL discussion but since it rolled into the 3D library territory anyway I'll give my 2 cents. 3D enhancement are indeed not planned for Java10 (at the minimum) and indeed you can't bring your own shader (asked already at https://stackoverflow.com/questions/43622856/can

Re: Innovation (Was: WebView and WebGL)

2017-09-10 Thread Nir Lisker
vated > community members can pool our resources and skills and "Just do it" (with > or without Oracle's help). > > I like what you are suggesting and what Sverre is requesting and what > numerous others are wanting, and I for one *want* them to become realities. > >

OpenJFX initiative

2017-09-22 Thread Nir Lisker
I didn't see any update on the idea for our initiative. Are we still waiting for a reply from Oracle or do we go with Johan Vos's experience? I think that the least we can do without putting any work into this is have a semi-formal list of people who would like to work on this and a list of what

Re: OpenJFX initiative

2017-09-22 Thread Nir Lisker
and also what it *should be* (where we coalesce > everyone’s own ideas) so we can move forward. > > That is of course *if* JavaFX is actually going to “move forward” rather > than “sideways”. > > Honestly though, if you’re not moving forward, you are really going > backward as

Re: OpenJFX initiative

2017-09-22 Thread Nir Lisker
ke > OpenJFX better" or be integrated? > > ​​ > Graciously, > > John-Val Rose > Chief Scientist/Architect > Rosethorn Technology > Australia > > On 23 September 2017 at 09:08, Nir Lisker wrote: > >> > What do you mean by “go with Johan Vos’s experience

Re: openjfx-dev Digest, Vol 71, Issue 15

2017-10-13 Thread Nir Lisker
Hi, Thanks for the slides Laurent. Was the talk not recorded? Would like to get in on the community effort discussion. If possible, include me in it. Thanks, Nir On Fri, Oct 13, 2017 at 3:00 PM, wrote: > Send openjfx-dev mailing list submissions to > [email protected] > > T

TabPane bug: removing and adding a tab

2017-12-08 Thread Nir Lisker
Looks like there's a bug with TabPane which happens when a tab is removed and quickly added back, before the layout is updated. This causes incorrect positioning of the headers. It was posted on SO: https://stackoverflow.com/ questions/47616221/javafx-tabpane-tabs-dont-update-position/ and apparent

Re: openjfx-dev Digest, Vol 73, Issue 20

2017-12-13 Thread Nir Lisker
John, As as I said in the past I'm all for it. Just didn't see anything going on. My personal preference is in the area of the 3D API. Iv'e already built on top of it for my own use and I (personally) think that some of what Iv'e done could be useful for the API. I also looked into the Prism HLSL

Re: openjfx-dev Digest, Vol 73, Issue 25

2017-12-15 Thread Nir Lisker
Kevin, I wouldn't mind pushing javadoc changes into 10, but don't have OpenJFX built yet as I'm waiting for updated instructions on that. Can you tell when is RDP1 ending and when is it planned to update the build instructions so I'll know what my time window is? Thanks, Nir On Fri, Dec 15, 2017

Re: javadoc changes [was: openjfx-dev Digest, Vol 73, Issue 25]

2017-12-16 Thread Nir Lisker
you are of a > mind to to do it. > > -- Kevin > > [1] http://openjdk.java.net/projects/jdk/10/ > > [2] https://bugs.openjdk.java.net/browse/JDK-8188314 > > > Nir Lisker wrote: > >> Kevin, >> >> I wouldn't mind pushing javadoc changes into 10, bu

Re: Updated OpenJFX build instructions

2017-12-22 Thread Nir Lisker
Thanks Kevin, I'm going through the process now on Win 10. A few things to note: - In the Platform Prerequisites/cygwin it says to make sure mercurial package is installed. Later, under Common Prerequisites/Mercurial it says "you can also install Mercurial as a cygwin package". It's not clear the

Re: Updated OpenJFX build instructions

2017-12-22 Thread Nir Lisker
t; As for the build failure, did you install Visual Studio 2017 and set the > two env variables (VS150COMNTOOLS and MSVC_VER) to point to it? If so, then > it should determine WINSDK_DIR without anything else needed. > > -- Kevin > > > > Nir Lisker wrote: > > Thanks Kevin

Re: Updated OpenJFX build instructions

2017-12-24 Thread Nir Lisker
whether that file > exists somewhere else. If it does, then point VS150COMNTOOLS to the > directory containing that bat file. > > I won't have any more time to look at it this until after the new > year...maybe someone else on the list can help? > > > -- Kevin > > &

JDK build fails on missing javah

2017-12-31 Thread Nir Lisker
After successfully building OpenJFX (11) Iv'e went on to build OpenJDK (11) as instructed under "Integration with OpenJDK" ( http://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/building.html). When executing `bash configure --with-import-modules=jfx_path\rt\build\modular-sdk` the build fails: che

Re: JDK build fails on missing javah

2018-01-03 Thread Nir Lisker
1, 2017 at 2:43 PM, Nir Lisker wrote: > After successfully building OpenJFX (11) Iv'e went on to build OpenJDK > (11) as instructed under "Integration with OpenJDK" ( > http://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/building.html). > > When executing `bash configur

Instructions for working on OpenJFX

2018-01-08 Thread Nir Lisker
Hello, I have OpenJFX and OpenJDK built. I have also set up TortoiseHg and am working with Eclipse. I have several questions: 1. Are the instructions at https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE still valid from JDK 8? There are old TODOs there. If not, can I get a quick update?

Error while pushing changeset

2018-01-09 Thread Nir Lisker
Iv'e created a small documentation fix and tried to push it to http://hg.openjdk.java.net/openjfx/jfx-dev/rt. I got an error: abort: push creates new remote head 2152a80ee902! hint: pull and merge or see 'hg help push' for details about pushing new heads [command returned code 255 Tue Jan 09 19:40

Re: Error while pushing changeset

2018-01-09 Thread Nir Lisker
://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report > [4] https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews > [5] https://wiki.openjdk.java.net/display/OpenJFX/Committing+the+Code > > > > Nir Lisker wrote: > >> Iv'e created a small documentation f

Re: Error while pushing changeset

2018-01-09 Thread Nir Lisker
wrote: > > I also note that tith simple javadoc changes... > > "with" simple ... > > -- Kevin > > > > Kevin Rushforth wrote: > >> >> >> Nir Lisker wrote: >> >>> > This shows a lack of understanding about our processes >&

Re: Error while pushing changeset

2018-01-09 Thread Nir Lisker
Submitted a new bug with ID: 9052190. On Tue, Jan 9, 2018 at 10:51 PM, Kevin Rushforth wrote: > > > Nir Lisker wrote: > > If there isn't an existing JBS issue, then please file one > > > I thought I would point to "8188314: Fix typos in FX API docs" even t

Review request: 8194871: Fix mistakes in FX API docs

2018-01-10 Thread Nir Lisker
Hi Kevin, Please review the attached webrev. I addressed a few fixes I found as I was working, so they are not listed in the JIRA report. About Transition#getParentTargetNode: The current behavior of parent-child relationship is that an animation can be added to multiple parent transitions. Each

Re: Review request: 8194871: Fix mistakes in FX API docs

2018-01-10 Thread Nir Lisker
ne/control/TableView.java:209: > Trailing whitespace > modules/javafx.graphics/src/main/java/javafx/animation/Transition.java:161: > Trailing whitespace > > I can fix this before I push. > > -- Kevin > > > Nir Lisker wrote: > > Hi Kevin, > > Please review the attached web

Re: Review request: 8194871: Fix mistakes in FX API docs

2018-01-10 Thread Nir Lisker
lations. > > > -- Kevin > > > Kevin Rushforth wrote: > > I just removed the trailing whitespace (using the handy > tools/scripts/checkWhiteSpace script with the '-F' option). > > -- Kevin > > > Nir Lisker wrote: > > Thanks, > > >>

fx 1.x issues in JBS

2018-01-15 Thread Nir Lisker
Hello, JBS still has open issues for JavaFX 1 versions and they appear in searches even though there's nothing to do about them since that version is not supported anymore. Is it appropriate to close them all? There are also a lot in Resolved. - Nir

Re: fx 1.x issues in JBS

2018-01-15 Thread Nir Lisker
closed out as a bulk close operation without > looking at them. > > Also, you say "a lot in resolved" my response would be that I hope so. An > issue that is resolved needs no more action and won't show up in searches > for open bugs. So I guess I'm not sure what

Re: Instructions for working on OpenJFX

2018-01-18 Thread Nir Lisker
Hi Kevin, Can you answer the questions I had in a previous mail please (question 4 is mostly answered)? http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-January/021232.html Thanks, Nir

Re: Instructions for working on OpenJFX

2018-01-24 Thread Nir Lisker
ld of JDK 9 or later with FX bits in it, then you can use the > build/run.args script to run with the just-built FX bits without rebuilding > the JDK. > > java @build/run.args ... > > > #3. I don't know since I don't use Eclipse; maybe someone on the list who >

Re: Instructions for working on OpenJFX

2018-01-24 Thread Nir Lisker
t; > > -- Kevin > > > Nir Lisker wrote: > > If you're still catching up, I would like to verify that I should ignore > project-level errors from the IDE. For example, Eclipse complains about the > graphics project: > > Project 'graphics' is missing r

JDK-8196130: Eclipse configuration files need to be updated

2018-01-25 Thread Nir Lisker
Iv'e removed all the classpath dependencies that were causing errors. I don't mind sorting out the rest of the files while at it, though for that there are a few things I'm not sure about: 1. Some dependencies are marked as optional and as such they don't cause errors, but they are still missing.

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-01-25 Thread Nir Lisker
cific path you mentioned as not being there. > > > > > These are still being created by 'gradle sdk', but the path is wrong (the > files moved in JDK 9) and should be: > > build/gensrc/jsl-decora > build/gensrc/jsl-prism > > You might want to take that

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-01-25 Thread Nir Lisker
r the larger question, unless there are dependencies on apps, you can > assume that the only ones you care about are the ones created by "gradle > sdk". > > -- Kevin > > > > Nir Lisker wrote: > > So this is why I was asking about the optional stuff: 'graphics&#

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-01-27 Thread Nir Lisker
On Fri, Jan 26, 2018 at 9:20 PM, Kevin Rushforth wrote: > inline > > Nir Lisker wrote: > > Alright, cleaned that part. fxpackager build fails with an internal NPE in > Eclipse, so I'm going to leave that alone and all of the projects that > depends on it. > > Now

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-01-29 Thread Nir Lisker
hat you are using? The FX build puts the > class files in: > > rt/build/modular_sdk/modules/javafx.base/... > > > -- Kevin > > > Nir Lisker wrote: > > Another question: do imports of javafx.* packages point to the javafx > source or to the jdk compilation?

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-01-30 Thread Nir Lisker
he order and also add > in the location of the built class files. So the following order seems best: > > rt/modules/javafx.base/build/classes/main/javafx.base/ > rt/modules/javafx.base/src/main/java/ > jdk/modules/javafx.base > > > -- Kevin > > > Nir Lisker wrote: &g

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-02-01 Thread Nir Lisker
e is local and would be excluded from webrevs. At this point I can either submit the partially fixed Eclipse files, which work with main code fully and with test code only if the above fix is used; or wait until Eclipse sorts it out. On Wed, Jan 31, 2018 at 4:21 PM, Kevin Rushforth wrote: > &

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-02-02 Thread Nir Lisker
gradle) without a module-info so that they run in the unnamed module. This > allows them to access JUnit, etc., as well as any public package of any > module in the system. As such we need to explicitly list any internal > packages that they use from the module they are testing. These are li

Re: More community participation in JavaFX

2018-02-04 Thread Nir Lisker
Hello, As someone who has recently made the climb and managed to build OpenJFX with OpenJDK on Win 10 I might have some relevant input. --- Building OpenJFX --- * With the recently updated instructions on the Wiki, building OpenJFX is not that hard. Having to build OpenJDK for that was a real h

Re: More community participation in JavaFX

2018-02-04 Thread Nir Lisker
R > on the public GitHub repository means, in my opinion, that it is ready to > be opened as > an upstream bug/feature request. Automating the process with patch sets, > webrevs, formatting/lint > results, etc. would be the most ideal situation and I would be happy to > contribute

Updating class javafx.beans.binding.When

2018-02-05 Thread Nir Lisker
Hi, I was looking at https://bugs.openjdk.java.net/browse/JDK-8089579, which prompted me to have a look at When. There are a few points I would like to address: * StringConditionBuilder#otherwise(ObservableStringValue) does not check for null as other condition builders do. This results in a deep

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-02-06 Thread Nir Lisker
e > following directory: > > modules/javafx.web/src/main/native/Source/WebCore/bindings/java/dom3/java/ > > > -- Kevin > > > Nir Lisker wrote: > > Attached webrev for .classpath changes for all javafx.xxx projects under > /modules (though 2 of them are not modules). >

Re: JDK-8196130: Eclipse configuration files need to be updated

2018-02-06 Thread Nir Lisker
The swt project has external org.eclipse.swt imports which weren't addressed. Let's call this round 1. Next rounds will be when Eclipse fixes some bugs and when the source repo is cleaned from unused projects. - Nir On Fri, Feb 2, 2018 at 6:52 PM, Nir Lisker wrote: > Alright, got m

Re: More community participation in JavaFX

2018-02-06 Thread Nir Lisker
the staging repo after it has been reviewed >>> by >>> the "wider audience" >>> which includes people without commit rights (people like us). Then, as >>> this >>> thing evolves, >>> based on the pool of people who are contributing both pu

Re: Updating class javafx.beans.binding.When

2018-02-08 Thread Nir Lisker
Iv'e managed to refactor a large portion of the class. About a 1/3 of the (repetitious) code was removed. On Tue, Feb 6, 2018 at 1:08 AM, Nir Lisker wrote: > Hi, > > I was looking at https://bugs.openjdk.java.net/browse/JDK-8089579, which > prompted me to have a look at When

Additional info on JDK-8197536: TableView, ListView: unexpected scrolling behaviour on up/down keys

2018-02-14 Thread Nir Lisker
I tested the issue. It is not present in 1.8.0_152-b16, but it is present in 9+181 and 10-ea+37. - Nir

Re: Repositories, AdoptOpenJDK and github

2018-02-14 Thread Nir Lisker
Thank you! My concerns (not complaints) and questions: 1. Developer forks the github repo, enhances it, and creates a PR. 2. He discusses it with a committer, and eventually the PR is accepted. As I said before, we need to be careful where the discussion is made. PRs on GitHub have their own t

Re: Updating class javafx.beans.binding.When

2018-02-16 Thread Nir Lisker
opose is probably best done as a separate bug fix, > so that we don't mix behavioral changes with refactoring, unless you think > that the refactoring is intertwined with the fix. > > If you would like to work on a fix, that would be good. It will need to > include new unit tes

Re: Updating class javafx.beans.binding.When

2018-02-20 Thread Nir Lisker
an show that the tests are testing an implementation > detail that would not affect an application that just uses public API. > > > -- Kevin > > > Nir Lisker wrote: > > Let's start with the refactoring then. Before I submit a bug let's check > that this plan makes s

Re: Repositories, AdoptOpenJDK and github

2018-02-27 Thread Nir Lisker
Iv'e given the pipeline some thought. I'm purposely ignoring current role names (Author, Contributor...). My suggestions: Potential contributor wants to contribute... 1. Formal process a. If the issue is not in the JBS, they submit it via bugreport. b. They send an email on the mailing list r

Re: Repositories, AdoptOpenJDK and github

2018-02-27 Thread Nir Lisker
r anyway (along with > changes from reviews happening in JBS that don't first go through the > sandbox), so maybe it doesn't matter? On the other hand there might be > advantages to getting it into the mainline of the sandbox early? Hard to > say. > > -- Kevin >

Re: Repositories, AdoptOpenJDK and github

2018-03-03 Thread Nir Lisker
n in OpenJFX. >> But >> this should not be a problem, as long as the following scenario is the >> main >> flow: >> >> The github master branch is always synced with OpenJFX, and never gets >> modified by other commits. >> The github "developmen

JDK-8130379: Enhance the Bounds class with getCenter method

2018-03-12 Thread Nir Lisker
Hello, I would like to work on https://bugs.openjdk.java.net/browse/JDK-8130379, which adds convenience API to the Bounds class. Any comments? - Nir

Re: Updating class javafx.beans.binding.When

2018-03-13 Thread Nir Lisker
l, or should it be retrofitted? - Nir On Tue, Feb 20, 2018 at 12:45 PM, Nir Lisker wrote: > OK, let's wait with this until I figure out if there's a problem with the > test suit. > > On Fri, Feb 16, 2018 at 11:46 PM, Kevin Rushforth < > [email protected]>

Review Request: JDK-8199514: Refactor binding.When

2018-03-13 Thread Nir Lisker
Hi, Please review preliminary fix for: https://bugs.openjdk.java.net/browse/JDK-8199514 http://cr.openjdk.java.net/~nlisker/8199514/webrev.00/ Thanks, Nir

Re: Review Request: JDK-8199514: Refactor binding.When

2018-03-13 Thread Nir Lisker
nstitute a public API change, I don't think it should be > done as part of this RFE. Otherwise, it becomes more than just a > behavior-neutral implementation refactoring, and would need to be looked at > as an API change, with all that entails. > > It will be a couple days be

JDK-8199560: Dynamic evaluation for binding.When

2018-03-13 Thread Nir Lisker
Hello, I've proposed to work on a public API for binding.When that adds capabilities for dynamic evaluation of the 'then' and 'otherwise' arguments. Any comments? https://bugs.openjdk.java.net/browse/JDK-8199560 - Nir

Review Request: JDK-8180151: JavaFX incorrectly renders scenegraph with two 3D boxes with certain dimensions

2018-03-17 Thread Nir Lisker
Hi Kevin, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8180151 http://cr.openjdk.java.net/~nlisker/8180151/webrev.00/ Thanks, Nir

Re: JDK-8130379: Enhance the Bounds class with getCenter method

2018-03-19 Thread Nir Lisker
net/display/csr/CSR+FAQs > [2] http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-Febr > uary/021335.html > > > > > Nir Lisker wrote: > >> Hello, >> >> I would like to work on https://bugs.openjdk.java.net/browse/JDK-8130379, >> which adds convenience API to the Bounds class. Any comments? >> >> - Nir >> >> >

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

2018-03-22 Thread Nir Lisker
Hi Michael, About the public API, I agree with Kevin that the following methods are redundant: - mousePress(MouseButton button) - mouseRelease(MouseButton button); - mouseWheel(int wheelAmt, VerticalDirection direction) About the implementation of getScreenCapture, isn't that conflicting with th

Re: JDK-8199560: Dynamic evaluation for binding.When

2018-03-25 Thread Nir Lisker
PI. I took a (very quick) look and > didn't see anything that would preclude fixing this using the existing API, > nor does the specification (javadoc-generated API docs) mandate the current > behavior of eagerly evaluating both the "then" and "otherwise" conditi

OpenJFX GitHub mirror

2018-03-26 Thread Nir Lisker
Hi All, A few comments about the mirror and JBS: 1. In PRs and issues on GitHub, I strongly suggest that the link to JBS be included in the top comment. If the JBS issue was created after a discussion, edit it in. 2. In JBS, I suggest to link to the GitHub mirror via More > Link > Web Link and i

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

2018-03-26 Thread Nir Lisker
I'm thinking about the addition of a public method for mouse click, which is mouse press and then mouse release - the parallel for key typed. Is it worth? - Nir On Mon, Mar 26, 2018 at 5:54 PM, Kevin Rushforth wrote: > Seems good to me, too. > > -- Kevin > > > Michael Ennen wrote: > >> Sounds l

Re: OpenJFX GitHub mirror

2018-03-27 Thread Nir Lisker
> > - Johan > > On Mon, Mar 26, 2018 at 12:03 PM Nir Lisker wrote: > >> Hi All, >> >> A few comments about the mirror and JBS: >> >> 1. In PRs and issues on GitHub, I strongly suggest that the link to JBS be >> included in the top comment. If the J

Re: OpenJFX GitHub mirror

2018-03-29 Thread Nir Lisker
ct > >> with anything else and wasn't confusing. Possible choices: > >> > >> github-link > >> github-bug > >> gitbug-issue > >> > >> Any preferences? > >> > >> -- Kevin > >> > >> > >> Nir L

JEP 286: Local-Variable Type Inference: Usage

2018-03-29 Thread Nir Lisker
Hello, A style guide for usage of 'var' has been published at http://openjdk.java.net/projects/amber/LVTIstyle.html. Can we start using this feature in contributions to OpenJFX? - Nir

JDK-8200206: Adding an animation to more than one parent results in inconsistent state

2018-03-29 Thread Nir Lisker
Hello, Iv'e created bug https://bugs.openjdk.java.net/browse/JDK-8200206. The behavior was noticed back when writing missing documentation for Transition [1]. Please evaluate. Thanks, Nir [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-January/021249.html

Prism documentation

2018-04-02 Thread Nir Lisker
Hi Kevin, Since Prism is only used internally it has no publicly available documentation (none that I could fine). I was wondering if there are any design materials or writeups that exist internally and can be released for development purpose. Specifically, I was looking at the d3d pipeline was w

JDK-8200587: Fix mistakes in FX API docs

2018-04-02 Thread Nir Lisker
Hi all, Iv'e created another issue for collecting JavaDoc corrections: https://bugs.openjdk.java.net/browse/JDK-8200587. If you found any, please add them to this issue and I'll fix them along with what's there already. Kevin, * Different items on the list affect different versions, but they are

Re: JDK-8200587: Fix mistakes in FX API docs

2018-04-02 Thread Nir Lisker
Mon, Apr 2, 2018 at 10:11 PM, Kevin Rushforth wrote: > > > Nir Lisker wrote: > >> Hi all, >> >> Iv'e created another issue for collecting JavaDoc corrections: >> https://bugs.openjdk.java.net/browse/JDK-8200587. If you found any, >> please

Re: OpenJFX GitHub mirror

2018-04-04 Thread Nir Lisker
sing the >> JBS label: >> >> github-bug >> >> To identify JBS issues that are linked to guthub issues and/or PRs >> >> -- Kevin >> >> >> Nir Lisker wrote: >> > I think that the labels should be succinct, so one label should suffice.

gradle :web:test fails

2018-04-04 Thread Nir Lisker
I'm running :web:test in revision 10889 and getting the following failing test: test.javafx.scene.web.MiscellaneousTest > testUserAgentString FAILED java.lang.AssertionError: UserAgentString does not contain JavaFX/11 at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert

Re: JDK-8199560: Dynamic evaluation for binding.When

2018-04-04 Thread Nir Lisker
might be the way to go. It would be good to get some opinions about > this from other developers. > > -- Kevin > > > Nir Lisker wrote: > > Iv'e given the idea of using existing API some thought. > > When using primitives, the evaluation is always eager. A method

Re: gradle :web:test fails

2018-04-05 Thread Nir Lisker
; :web:test" and in this case webkit dll will be picked up from your source > code repo (not from JDK). > > > > Thanks, > > Murali > > > > -Original Message- > > From: Murali Billa > > Sent: Thursday, April 05, 2018 10:19 AM > > To: Nir L

Review Request: JDK-8200587: Fix mistakes in FX API docs

2018-04-05 Thread Nir Lisker
Hi Kevin, After JDK-8200749 is committed, please review the fixes for documentation mistakes: https://bugs.openjdk.java.net/browse/JDK-8200587 http://cr.openjdk.java.net/~nlisker/8200587/webrev.00/ Thanks, Nir

Re: OpenJFX GitHub mirror

2018-04-06 Thread Nir Lisker
quot; already, so there should be no confusion if we just use the URL. > > > -- Kevin > > > Nir Lisker wrote: > > github-bug is fine by me. What about external links, name them or leave > them as URLs? > > On Wed, Apr 4, 2018, 16:43 Johan Vos wrote: > >

Re: Monocle Headless BufferOverflowException (Issue + Fix)

2018-04-16 Thread Nir Lisker
It was moved to https://bugs.openjdk.java.net/browse/JDK-8201567. On Mon, Apr 16, 2018, 20:26 John Neffenger wrote: > On 02/23/2018 03:12 PM, Michael Ennen wrote: > > Good point about the OCA, I have sent an email just now to > > John Neffenger. Hopefully he is still interested in this topic :).

JDK-8198795: Remove IDE specific files from the source code repository

2018-04-18 Thread Nir Lisker
Hi all, There were several discussion in GitHub about removing IDE files (they are linked from the JBS issue [1]). At the end, I didn't see any decision or any change. I would like to update the Eclipse files soon since the cleanup [2] is almost done. These files allow anyone who checks out OpenJ

Re: JDK-8198795: Remove IDE specific files from the source code repository

2018-04-18 Thread Nir Lisker
PM, Tom Schindl wrote: > Hi, > > I've also worked on the Eclipse specific files. We should compare yours > and mine (I've been doing this on Photon-builds against JDK-10). > > Tom > > On 18.04.18 12:29, Nir Lisker wrote: > > Hi all, > > > > The

Re: EM Font Size Performance

2018-04-19 Thread Nir Lisker
I think this is the issue: https://bugs.openjdk.java.net/browse/JDK-8088615. There's also https://bugs.openjdk.java.net/browse/JDK-8193445. - Nir On Thu, Apr 19, 2018 at 1:42 PM, David Grieve wrote: > Resolving the relative size involves a lot of lookup. You have to go up > the scene-graph from

Re: JDK-8198795: Remove IDE specific files from the source code repository

2018-04-19 Thread Nir Lisker
" to compile Junit > > * web: > - adding "requires static java.management;" to compile > > Tom > > [1]https://github.com/javafxports/openjdk-jfx/ > compare/master...BestSolution-at:eclipse-setup?expand=1 > > On 18.04.18 15:39, Nir Lisker wrote: > >

JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-04-27 Thread Nir Lisker
Hi Murali, Can you have a look at https://bugs.openjdk.java.net/browse/JDK-8195974 please? There are some usages of j.u.l in the web module I'd like your opinion on. I'm not familiar with the intent of these pieces of code and would like to know what the options are for advancing with this issue

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-02 Thread Nir Lisker
fx.webkit.drt.DumpRenderTree”, I need to > check few more things (since we use “addHandler” in drt) and will get back > to you. > > > > Please let me know, if you have any queries for 1. > > Thanks, > > Murali > > *From:* Nir Lisker > *Sent:* Sat

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-02 Thread Nir Lisker
its usage of the logger (that it requires its own property)? - Nir On Thu, May 3, 2018 at 3:31 AM, Kevin Rushforth wrote: > inline > > > On 5/2/2018 4:52 PM, Nir Lisker wrote: > >> Thanks Murali, >> >> I won’t suggest reading level value from log/config file. &

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-03 Thread Nir Lisker
ise me that some of the WARNING log messages are things > that the user shouldn't necessarily be warned about. > >From my point of view, if the warning messages are of no interest to the user, maybe they shouldn't be warning level. - Nir On Thu, May 3, 2018 at 2:42 PM, K

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-04 Thread Nir Lisker
Hi Prasanta, In SwingNode, lines 870 -883, is there a reason that only the first method uncommented @Override? I don't understand the comment that wants to skip @Override. Some minor code comments: * LightweightFrameWrapper#isCompEqual: you can skip the 'if' and just 'return c != lwFrame.getLigh

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-05 Thread Nir Lisker
Hi Prasanta, If @override is not added, then it will cause recursion between > LightweightContent.java:130 and LightweightContent.java:187 I don't understand how the existence or lack thereof of an @Override can cause or prevent recursion (bar reflection). Since all the methods of the interface

Re: Paint Phase Debugging / Performance

2018-05-07 Thread Nir Lisker
Hi, I'm having a performance issue myself. I'm using animations on 3D models (in a 3D subscene) and when there are "too many" models the QuantumRenderer thread is running 100% of the time and utilizing 20-25% of the CPU, though the OS reports that overall all cores are at ~40%. The application is

Re: Announcing EA builds of standalone JavaFX SDK

2018-05-08 Thread Nir Lisker
Thanks Kevin, that's good to hear. Michael, adding the external jars as single entries is the simplest and most granular way, but you can also define a library from those jars and then add that single library to any project: 1. Add Library... 2. User Library 3. User Libraries... 4. New... (give i

Re: Paint Phase Debugging / Performance

2018-05-08 Thread Nir Lisker
rror with the prism flags here to try narrow it down - > Just open PrismSettings.java in your IDE or web browser. > > Code explains them better than most posts I’ve seen. > > Good luck. > Matt > > Sent from my phone. > > On 7/05/2018, at 2:36 PM, Nir Lisker wrote: > >

  1   2   3   4   5   6   7   8   9   >