[Openocd-development] [PATCH] add TAP_SCAN_BYTES macro (1 of 2)

2009-04-24 Thread Zach Welch
Hi all, The attached patch adds a literate macro for the calculation of the number of bytes required to store a TAP scan chain given its bit count. This macro ensures this calculation will be done correctly in all locations that it is required, though this patch simply changes the line of code

[Openocd-development] [PATCH] bootstrap: add --enable-maintainer-mode reminder

2009-04-24 Thread Zach Welch
Hi all, Following up on my previous post on this subject, the attached patch adds a reminder to the bootstrap script for the user to use the --enable-maintainer-mode option when running the configure script. Cheers, Zach Index: bootstrap

Re: [Openocd-development] Some notes about JTAG and TAP

2009-04-24 Thread Zach Welch
On Fri, 2009-04-24 at 18:39 +0200, Magnus Lundin wrote: [snip] static tap_state_t exception_path[] = { TAP_DREXIT2, TAP_DRSHIFT, TAP_DREXIT1, TAP_DRUPDATE,

Re: [Openocd-development] Some notes about JTAG and TAP

2009-04-24 Thread Zach Welch
On Fri, 2009-04-24 at 09:56 -0700, Zach Welch wrote: On Fri, 2009-04-24 at 18:39 +0200, Magnus Lundin wrote: [snip] static tap_state_t exception_path[] = { TAP_DREXIT2, TAP_DRSHIFT

Re: [Openocd-development] Lost JTAG Communications. Bringing up AT91SAM9260

2009-04-24 Thread Zach Welch
On Fri, 2009-04-24 at 12:50 -0400, Brian Hutchinson wrote: Thanks guys! I recovered ... board is booting u-boot normal now. I'll clean up my scripts for this board how to I submit them? Do I need to make a patch against the /board /target directories or what? Create patches from the

Re: [Openocd-development] [PATCH] add jtag_debug_state_machine (2 of 2)

2009-04-24 Thread Zach Welch
On Fri, 2009-04-24 at 21:03 -0400, Duane Ellis wrote: Zach Welch wrote: Hi all, The attached patch adds the jtag_debug_state_machine routine, which is based off of Jeff Williams' patch from Mar 30. To include this output, the --enable-verbose-jtag-io (or --enable-verbose) configuration

Re: [Openocd-development] Lost JTAG Communications. Bringing up AT91SAM9260

2009-04-23 Thread Zach Welch
On Thu, 2009-04-23 at 17:41 +0200, R.Doss wrote: Edgar Grimberg schrieb: Hi, Anyone got experience with bringing up the AT91SAM9260 based boards and know what the min init is? Can I use the working u-boot to probe these registers and figure out the settings that way? The

Re: [Openocd-development] The problem with testing target hardware

2009-04-23 Thread Zach Welch
On Thu, 2009-04-23 at 09:54 +0200, Nico Coesel wrote: [snip] Another item for the list: With some imagination it would be possible to simulate a UART or an SPI interface using the JTAG dongle. Maybe even bit I/O using the RST en TRST pins. This would allow extending OpenOCD into a universal

Re: [Openocd-development] [PATCH] factor jlink_execute_queue

2009-04-22 Thread Zach Welch
On Tue, 2009-04-21 at 21:27 -0700, Zach Welch wrote: Hi all, This patch factors the massive switch in jlink_execute_queue into a much more manageable set of static functions. I have a few others small cleanups left in mind, but this should be the last really big one. Yes, I did forget

[Openocd-development] [PATCH] fix jtag run/idle state name

2009-04-22 Thread Zach Welch
Hi all, This patch was the first piece that I found easy to tear out of Jeff's patches that were posted on Mar 30th[1]. It fixes the name printed for the JTAG Run/Idle state. Cheers, Zach [1] https://lists.berlios.de/pipermail/openocd-development/2009-March/005144.html Index:

Re: [Openocd-development] [PATCH] factor jlink_execute_queue

2009-04-22 Thread Zach Welch
On Tue, 2009-04-21 at 23:30 -0700, Zach Welch wrote: On Tue, 2009-04-21 at 21:27 -0700, Zach Welch wrote: Hi all, This patch factors the massive switch in jlink_execute_queue into a much more manageable set of static functions. I have a few others small cleanups left in mind

Re: [Openocd-development] [PATCH] jlink comment rulers

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 00:05 -0700, Rick Altherr wrote: [snip] I'm going to hold off on this one. We don't have an established standard for comment-based navigational aids. I've used a few different styles over the years and each project seems to have a different preferred form. I'm a

[Openocd-development] [PATCH] reorder enum tap_state

2009-04-22 Thread Zach Welch
Hi all, This patch -- also derived from Jeff Williams' work -- reorders the enum tap_state symbols to reflect the states used by most/all ARM parts. I verified that these states match the documentation that I have here, and I tested that nothing appears immediately broken. If I am right in say

[Openocd-development] [PATCH] jlink: set speed in init

2009-04-22 Thread Zach Welch
Hi all, This one-liner comes from Jeff Williams' patch. It simply calls jlink_speed at the end of jlink_init. Please apply. Cheers, Zach Index: src/jtag/jlink.c === --- src/jtag/jlink.c (revision 1504) +++ src/jtag/jlink.c

Re: [Openocd-development] my tech proposal

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 17:43 +0800, Xiaofan Chen wrote: On Wed, Apr 22, 2009 at 5:33 PM, Zach Welch z...@superlucidity.net wrote: These will appear in the next revision of my list. I have been thinking about what I want my next hobby board to be, and the Cortex A8 has been one possible

[Openocd-development] [PATCH] fix jlink reset

2009-04-22 Thread Zach Welch
Hi all, The attached patch (part of Jeff Williams' work) improves the reset functionality. It appears to do no harm when combined with the speed init and state reordering patches; it does not get us out of the woods. Please apply. Cheers, Zach Index: src/jtag/jlink.c

Re: [Openocd-development] my tech proposal

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 08:04 +0200, Øyvind Harboe wrote: Great posting! Can I suggest that you create this as a patch against svn so we can match up the todo.txt list against an actual version of the OpenOCD svn history? Can't I simply claim that it's on The List? ;) I definitely agree that I

Re: [Openocd-development] my tech proposal

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 12:59 +0200, Nico Coesel wrote: [snip] I looked at the BDM project Xiaofan posted. It seems like a good starting point. It also has routines for external flash. Maybe its worth to look into it to get some fresh ideas on the cfi implementation as well. I used to have a

Re: [Openocd-development] JLink OEM (SAM-ICE)

2009-04-22 Thread Zach Welch
stay tuned. So the short answer is probably not today, but Real Soon Now. Give it a whirl and post your feedback here; I heard a rumor once upon a time that all bugs are shallow, given enough eyeballs. ;) Cheers, Zach Welch Corvallis, OR ___ Openocd

Re: [Openocd-development] my tech proposal

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 13:00 +0200, Øyvind Harboe wrote: - New targets? Any that you have in mind? Coldfire and Cortex are on thanks to Nico. MC1322x from Jeff. I have added an insert your target here item. arm11 has a lot of support already, but could need more love... Can you

Re: [Openocd-development] The problem with testing target hardware

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 19:52 +0200, Øyvind Harboe wrote: One annoying problem is that all target hardware is not available to all OpenOCD developers. For development purposes, this could perhaps be addressed by creating a JTAG over TCP/IP protocol. The idea is that OpenOCD adds a TCP/IP

Re: [Openocd-development] The problem with testing target hardware

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 11:07 -0700, Rick Altherr wrote: [snip] This is an interesting idea, but I think it skips an important step. There seem to be a number of problems solely within the JTAG and interface layers. It would be great if someone constructed some infrastructure for a

[Openocd-development] [PATCH] experimental jtag+jlink patches

2009-04-22 Thread Zach Welch
Hi all, Unless I accidentally missed something, the attached patches provide the last _functional_ changes in Jeff Williams' J-Link patch; my final task will be to extract and apply the debugging improvements that he made, as it looks like they will then need to be immediately put into use.

[Openocd-development] [PATCH] re-based MC1322x patch

2009-04-22 Thread Zach Welch
Hi all, This is the second of the two patches provided by Jeff Williams, re-based against r1509. I have barely glanced through it for now, as the old patch simply had some fuzz in it. I thought I should try to re-post it to see if the community will start to do something with it (e.g. review it

Re: [Openocd-development] [PATCH] re-based MC1322x patch

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 11:50 -0700, Zach Welch wrote: Hi all, This is the second of the two patches provided by Jeff Williams, re-based against r1509. I have barely glanced through it for now, as the old patch simply had some fuzz in it. I thought I should try to re-post it to see

Re: [Openocd-development] The List (of OpenOCD Tasks) for r1509

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 14:51 -0500, Dick Hollenbeck wrote: Nice work Zach. Thanks Dick. But nothing else for me to add? :) Yes, I would ask that folks *try* out the CMake support. I think they have the potential to help some Windows folks who might get roadblocked

Re: [Openocd-development] [BUG] doc/version.texi is not being generated

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 20:08 +0200, Piotr Esden-Tempski wrote: [snip] In earlier versions of the tree this file was generated automatically. Using the ./configure option --enable-maintainer-mode one can force the generation of doc/version.texi. I am not sure what the right fix here should be so

Re: [Openocd-development] The List (of OpenOCD Tasks) for r1509

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 22:40 +0200, Øyvind Harboe wrote: On Wed, Apr 22, 2009 at 10:34 PM, Zach Welch z...@superlucidity.net wrote: On Wed, 2009-04-22 at 14:51 -0500, Dick Hollenbeck wrote: Nice work Zach. Thanks Dick. But nothing else for me to add? :) Yes, I would ask

Re: [Openocd-development] The List (of OpenOCD Tasks) for r1509

2009-04-22 Thread Zach Welch
On Wed, 2009-04-22 at 16:04 -0500, Dick Hollenbeck wrote: Zach Welch wrote: On Wed, 2009-04-22 at 14:51 -0500, Dick Hollenbeck wrote: Nice work Zach. Thanks Dick. But nothing else for me to add? :) Yes, I would ask that folks *try* out the CMake

Re: [Openocd-development] [PATCH] improve Linux ftd2xx configure-timesupport

2009-04-21 Thread Zach Welch
...@lists.berlios.de [mailto:openocd-development-boun...@lists.berlios.de] Namens Zach Welch Verzonden: dinsdag 21 april 2009 9:59 Aan: openocd-development Onderwerp: [Openocd-development] [PATCH] improve Linux ftd2xx configure-timesupport Hi all, The attached patch rewrites

[Openocd-development] [PATCH] add --enable-verbose* options

2009-04-21 Thread Zach Welch
Hi all, This patch adds several new configuration options to control verbose debugging output intended only for developers: This Option defines This Symbol --enable-verbose-jtag-io - _DEBUG_JTAG_IO_ --enable-verbose-usb-io - _DEBUG_USB_IO_

Re: [Openocd-development] r1492: jlink build error

2009-04-21 Thread Zach Welch
On Tue, 2009-04-21 at 11:36 +0100, Ben Dooks wrote: The JLink driver is failing to build because of a warning that is now being treated as an error. The warning is being generated by usb_bulk_with_retries() being passed both usb_bulk_read() and usb_bulk_write() function pointers, where

Re: [Openocd-development] [PATCH] jim.c: fix unused return value warnings (2 of 4)

2009-04-21 Thread Zach Welch
On Tue, 2009-04-21 at 04:33 -0400, Chris Zimman wrote: zw @@ -8953,7 +8954,8 @@ zw const int cwd_len=2048; zw char *cwd=malloc(cwd_len); zw Jim_SetResult(interp, Jim_NewEmptyStringObj(interp)); zw - getcwd( cwd, cwd_len ); zw + cwd = getcwd(

[Openocd-development] [PATCH] fix jlink format warning

2009-04-21 Thread Zach Welch
Hi all, The attached patch fixes a format-security warning in the J-Link driver when _DEBUG_USB_COMMS_ is defined. Cheers, Zach Index: src/jtag/jlink.c === --- src/jtag/jlink.c (revision 1492) +++ src/jtag/jlink.c (working copy) @@

[Openocd-development] [PATCH] fix ft2232 usb io format warning

2009-04-21 Thread Zach Welch
Hi all, The attached patch fixes newly exposed warnings in the ft2232 driver. Please apply. Cheers, Zach Index: src/jtag/ft2232.c === --- src/jtag/ft2232.c (revision 1495) +++ src/jtag/ft2232.c (working copy) @@ -472,9 +472,10 @@

Re: [Openocd-development] [PATCH] add --enable-verbose* options

2009-04-21 Thread Zach Welch
On Tue, 2009-04-21 at 04:13 -0700, Zach Welch wrote: Hi all, This patch adds several new configuration options to control verbose debugging output intended only for developers: [snip] Most of this patch is now in the repository, but one file was missed. New patch attached. Please apply

[Openocd-development] [PATCH] jlink (4 of 6): unwind jlink_tap_append_*

2009-04-21 Thread Zach Welch
Hi all, This patch unwinds the logic in jlink_tap_append_{step,scan}. Cheers, Zach Index: src/jtag/jlink.c === --- src/jtag/jlink.c (revision 1497) +++ src/jtag/jlink.c (working copy) @@ -593,40 +589,32 @@ last_tms = tms; int

[Openocd-development] [PATCH] jlink (5 of 6): unwind jlink_tap_execute

2009-04-21 Thread Zach Welch
Hi all, This patch unwinds the logic in jlink_tap_execute. Cheers, Zach Index: src/jtag/jlink.c === --- src/jtag/jlink.c (revision 1497) +++ src/jtag/jlink.c (working copy) @@ -651,82 +641,79 @@ int i; int result; - if

[Openocd-development] [PATCH] jlink (3 of 6): fix jlink tap_length type

2009-04-21 Thread Zach Welch
Hi all, This patch fixes the type of the jlink driver's tap_length variable. Cheers, Zach Index: src/jtag/jlink.c === --- src/jtag/jlink.c (revision 1497) +++ src/jtag/jlink.c (working copy) @@ -551,7 +547,7 @@ /* 2048 is the max

Re: [Openocd-development] Recent JLink churn

2009-04-21 Thread Zach Welch
On Tue, 2009-04-21 at 09:13 -0700, Jeff Williams wrote: Hey guys, The recent jtag.[h,c] and jlink.c churn has totally hosed all of my pending patches. BTW: these changes included a lot more than just fixes to the TAP handling for significant improvement in efficiency and increased

Re: [Openocd-development] Some thoughts about JLink

2009-04-21 Thread Zach Welch
On Tue, 2009-04-21 at 22:51 +0200, Magnus Lundin wrote: [snip] Does the removal adding transitions up to mulktiples of 8 break more than it helps? If that means does removing that block hurt more than help, then the answer is yes; my target does not pass its initial TAP ID scan w/o it. Or did

[Openocd-development] [PATCH] factor jlink_execute_queue

2009-04-21 Thread Zach Welch
Hi all, This patch factors the massive switch in jlink_execute_queue into a much more manageable set of static functions. I have a few others small cleanups left in mind, but this should be the last really big one. Cheers, Zach ___

[Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Zach Welch
Hi all, Since I have been following these threads carefully for the past weeks, I thought I would try to help organize the immediately apparent list of tasks in a hypothetical series of patches that appear to be outstanding: * TAP changes: - use tap_set_state everywhere to allow logging TAP

Re: [Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 18:56 +0200, Michael Fischer wrote: Hello Zach, * J-Link driver (w/ yellow hardware): - cure buggy madness (this is my own poorly qualified TODO item) Does it works on your side? Here I have a jlink too and want to get it working under Mac OS X. And old version, I

Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 22:48 +0100, Spencer Oliver wrote: [snip] This breaks my build on cygwin, native win32 and ubuntu (intrepid). I will try and find some time later this week to look into. I will look at Ubuntu shortly and potentially post a patch, but I can also take a stab at cygwin if you

[Openocd-development] [PATCH] jim.c: fix unused return value warnings (2 of 4)

2009-04-20 Thread Zach Welch
Hi all, Ubuntu 8.10 has a newer version of the standard library that causes the compiler to issue warnings for unchecked return values for some calls. The attached patch fixes two such issues. Cheers, Zach Index: src/helper/jim.c

[Openocd-development] [PATCH] target.c: fix unused return value warnings (3 of 4)

2009-04-20 Thread Zach Welch
Hi all, Ubuntu 8.10 has a newer version of the standard library that causes the compiler to issue warnings for unchecked return values for fwrite. The attached patch fixes related warnings when writing gmon output. I have not tested this, but it's a fairly trivial patch. Cheers, Zach Index:

[Openocd-development] [PATCH] configure.in: add -Wformat-security (4 of 4)

2009-04-20 Thread Zach Welch
Hi all, This patch adds -Wformat-security to the build CFLAGS. This appears to be enabled by default with Ubuntu 8.10, beyond the standard -Wformat. It would be nice to get to -Wformat=2, but that will take more work. Cheers, Zach Index: configure.in

[Openocd-development] [PATCH] fix mingw32 fd_set macro warnings

2009-04-20 Thread Zach Welch
Hi all, The attached patch is required to work around bugs in the MinGW32 build. For context, the fd_set macros appear to be poorly defined on MinGW32, causing superfluous sign-compare warnings. The patch turns it off only when building a) that platform and b) those files that use those macros.

[Openocd-development] [PATCH] fix mingw32 prototype warning

2009-04-20 Thread Zach Welch
Spencer, The attached patch includes an attempt at fixing the following warning: jim.c: In function `Jim_EnvCoreCommand': jim.c:11977: warning: function declaration isn't a prototype If this doesn't do it, you might explore this one; my patch is a wild stab in the dark, but who knows. Cheers,

[Openocd-development] [PATCH] fix at91sam7 uninitialized variable warnings

2009-04-20 Thread Zach Welch
Hi all, The attached patch fixes several uninitialized variable warnings for the CygWin and Win32 builds by assigning values. These warnings seem to indicate that 'gcc -O2' does not work as well for those targets, but this will also solve problems when using less optimization (as indicated by my

Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 23:31 +0100, Spencer Oliver wrote: Zach, This breaks my build on cygwin, native win32 and ubuntu (intrepid). I will try and find some time later this week to look into. I will look at Ubuntu shortly and potentially post a patch, but I can also take a stab at

Re: [Openocd-development] FT2232H/FT4232H support in trunk.

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 15:01 +0100, Ben Dooks wrote: On Mon, Apr 20, 2009 at 08:00:19AM +0200, Joern Kaipf wrote: Hi Ben, Ben Dooks write: I looked at src/jtag/ft2232.c and didn't notice anything there specific to the extra features in the H parts, such as the new speed selections.

Re: [Openocd-development] [PATCH] jim.c: fix unused return value warnings (2 of 4)

2009-04-20 Thread Zach Welch
On Tue, 2009-04-21 at 13:53 +0900, Hiroshi Ito wrote: zw Index: src/helper/jim.c zw === zw --- src/helper/jim.c (revision 1478) zw +++ src/helper/jim.c (working copy) zw @@ -133,7 +133,8 @@ zw buf[sizeof(buf)-1] = 0;

Re: [Openocd-development] unstable USB J-Link in OpenOCD (revised patch provided)

2009-04-19 Thread Zach Welch
I have attached a new version of the patch against r1473; the original version posted by Nikolay does not apply cleanly. FWIW, this patch has no apparently deleterious effect on the J-Link driver (yellow), though it does not resolve my setup's problems. [[I am working my way down to debugging

Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-19 Thread Zach Welch
On Sun, 2009-04-19 at 23:06 +0200, Øyvind Harboe wrote: Committed. Note that treating warnings as errors may well have to stay non-default. Be prepared for a bit of flak... Did you mean on as default? I hope that to be the case, as I think most developers do not report warnings - only

Re: [Openocd-development] [PATCH] fix ft2232/presto warnings

2009-04-19 Thread Zach Welch
On Sun, 2009-04-19 at 17:18 -0700, Zach Welch wrote: Hi all, Since my patch to enable -Werror got in a little faster than I expected, I decided to try and save myself some pain by installing and testing the libftdi and libftd2xx libraries and tested the associated OpenOCD driver builds

Re: [Openocd-development] JTAG/TAP changes?

2009-04-19 Thread Zach Welch
On Sat, 2009-04-18 at 06:31 -0500, Dick Hollenbeck wrote: 1) I would like to see tap_set_state() called for ALL state changes, not just the end points of of a multi-state path move. This way when logging is compiled ON, we can see what each driver is doing (more exactly, what it thinks

Re: [Openocd-development] sorry have to bail

2009-04-19 Thread Zach Welch
On Sun, 2009-04-19 at 21:23 -0400, Duane Ellis wrote: [snip] Some things have come up and I'm not going to be able to finish this for some period of time :-( I need some block of quality time to deal with this, not a few hours here or there. I have lots of those short time periods just not

[Openocd-development] [PATCH] automake maintainer mode

2009-04-18 Thread Zach Welch
Hi all, The attached patch adds the AM_MAINTAINER_MODE macro to configure.ac, which provides the --enable-maintainer-mode option. When provided, the autotools generate additional Makefile rules that allow the build system (configure, Makefile.in and Makefile outputs) to be rebuilt when their

[Openocd-development] [PATCH] fix warnings in usbprog

2009-04-18 Thread Zach Welch
Hi all, The attached patch fixes pointer-sign warnings in the usbprog module. In the process, I could not help but simplify the code to be a little more compact/readable (maintaining functional equivalence). Cheers, Zach Index: src/jtag/usbprog.c

Re: [Openocd-development] [PATCH] fix warnings in usbprog

2009-04-18 Thread Zach Welch
On Sat, 2009-04-18 at 15:35 -0700, Zach Welch wrote: Hi all, The attached patch fixes pointer-sign warnings in the usbprog module. In the process, I could not help but simplify the code to be a little more compact/readable (maintaining functional equivalence). Oops. I made a last second

Re: [Openocd-development] [PATCH] fix warnings in usbprog

2009-04-18 Thread Zach Welch
at 12:35 AM, Zach Welch z...@superlucidity.net wrote: Hi all, The attached patch fixes pointer-sign warnings in the usbprog module. In the process, I could not help but simplify the code to be a little more compact/readable (maintaining

[Openocd-development] [PATCH] fix signed/unsigned comparisons

2009-04-18 Thread Zach Welch
Hi all, The attached patch fixes a number of signed/unsigned comparison warnings that appear with -Wextra. This handles the flash directory first. I will submit more patches to fix the remaining warnings. This patch serves as a temporary measure. Many structures use 'int' instead of unsigned

[Openocd-development] [PATCH] trim logic in tms470.c

2009-04-18 Thread Zach Welch
Hi all, The attached patch removes two comparisons that are always true and generate warnings with -Wextra. Cheers, Zach Index: src/flash/tms470.c === --- src/flash/tms470.c (revision 1462) +++ src/flash/tms470.c (working copy) @@

[Openocd-development] [PATCH] add missing initializers in nand.c

2009-04-18 Thread Zach Welch
Hi all, The attached patch fixes a missing initializer warning with -Wextra. Cheers, Zach diff -u src/flash/nand.c src/flash/nand.c --- src/flash/nand.c (working copy) +++ src/flash/nand.c (working copy) @@ -165,7 +165,7 @@ {NAND 2GiB 1,8V 16-bit, 0xB5, 0, 2048, 0, LP_OPTIONS16}, {NAND

Re: [Openocd-development] PATCH: flash driver cleanup

2009-04-17 Thread Zach Welch
On Thu, 2009-04-16 at 22:16 -0700, Zach Welch wrote: Hi all, I have attached two patches to help clean up OpenOCD's flash drivers. The first patch changes most of the driver routines to static where possible, removing unused data and functions from the build with preprocessor #if 0 blocks

[Openocd-development] PATCH: fix jlink warnings

2009-04-17 Thread Zach Welch
Hi all, I have attached a patch to fix four pointer-sign warnings (GCC 4.3.2) in the J-Link driver. Please apply. Cheers, Zach Index: src/jtag/jlink.c === --- src/jtag/jlink.c (revision 1461) +++ src/jtag/jlink.c (working copy)

[Openocd-development] [PATCH] fix two -Werror warnings

2009-04-17 Thread Zach Welch
Hi all, I like to use -Wall -Wextra -Werror when building, so I have attached two patches that fix warnings when using -Wextra. The patch for etm.c removes a condition that is always true, and the patch for jtag.c fixes the order of C keywords. Apply either or both. There will be more, but

[Openocd-development] [PATCH] add TAP_INVALID and TAP_NUM_STATES

2009-04-17 Thread Zach Welch
Hi all, The attached patch adds the TAP_INVALID (got a better name?) and TAP_NUM_STATES symbols, replacing the relevant hard-coded constants. This fixes a signed/unsigned comparison in jtag.h and helps eliminate a few other warnings produced when using -Wextra. It also makes the code a little

[Openocd-development] PATCH: openocd jlink.c cleanup

2009-03-26 Thread Zach Welch
. Cheers, Zach Welch Corvallis, OR Index: src/jtag/jlink.c === --- src/jtag/jlink.c(revision 1433) +++ src/jtag/jlink.c(working copy) @@ -85,14 +85,16 @@ int jlink_quit(void); /* CLI command handler functions */ -int

Re: [Openocd-development] PATCH: openocd jlink.c cleanup

2009-03-26 Thread Zach Welch
. Is there any way to coordinate these two efforts, so that we don't end up with a mess of wasted work? For instance refactoring for taste and style could potentially cause me a lot of headache in getting the MC1322x work committed. Jeff El Mar 26, 2009, a las 16:26 , Zach Welch escribió

[Openocd-development] [PATCH] fix/enhance 'make maintainer-clean'

2009-01-19 Thread Zach Welch
Howdy, The attached patch allows 'make maintainer-clean' to remove all of the files created by the bootstrap script, allowing them to be regenerated. It was created with r1341 and tested on Linux. Cheers, Zach Welch Corvallis, OR Index: src/helper/Makefile.am

<    4   5   6   7   8   9