parse callback allows inserting cursorpos when hide_stmt.

2018-03-07 Thread Kyotaro HORIGUCHI
Hello. Parse error callback sets cursor position even if hide_stmt is true. So I see a strange message with meaningless 'at character %d' notation. 2018-03-07 11:11:43.489 JST [10304] DEBUG: removed 223/2049, age(-2s:121, -3s:121, *-30s:1584, -60s:223, -90s:0) naccessed(0:223, 1:0, 2:0) at char

RE: Temporary tables prevent autovacuum, leading to XID wraparound

2018-03-07 Thread Tsunakawa, Takayuki
From: Tom Lane [mailto:t...@sss.pgh.pa.us] > I just read through this thread for the first time; sorry for not paying > attention sooner. Don't mind, please. It's very happy that you gave attention now. > I'm uncomfortable with all the discussion of changing the autovacuum > launcher's algorith

Re: Protect syscache from bloating with negative cache entries

2018-03-07 Thread Kyotaro HORIGUCHI
Oops! The previous ptach contained garbage printing in debugging output. The attached is the new version without the garbage. Addition to it, I changed my mind to use DEBUG1 for the debug message since the frequency is quite low. No changes in the following cited previous mail. At Wed, 07 Mar 20

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-07 Thread Arthur Zakirov
Hello Andres, On Thu, Mar 01, 2018 at 08:31:49PM -0800, Andres Freund wrote: > Is there any chance we can instead can convert dictionaries into a form > we can just mmap() into memory? That'd scale a lot higher and more > dynamicallly? To avoid misunderstanding can you please elaborate on using

Re: 2018-03 Commitfest Summary (Andres #1)

2018-03-07 Thread Fabien COELHO
because pgbench isn't overflow safe. I reported that, but you didn't follow up with fixes. Indeed. AFAICR you did it before, I think that I reviewed it, it was not a period for which I had a lot of available time, and I did not feel it was something that urgent to fix because there was no prac

Re: WIP Patch: Pgbench Serialization and deadlock errors

2018-03-07 Thread Marina Polyakova
On 06-03-2018 18:02, David Steele wrote: Hi Marina, On 3/6/18 4:45 AM, Marina Polyakova wrote: On 05-03-2018 18:21, David Steele wrote: Hello Marina, Hello, David! On 1/12/18 12:01 PM, Marina Polyakova wrote: ... This patch was marked Waiting on Author on Jan 8 and no new patch was subm

Re: csv format for psql

2018-03-07 Thread Fabien COELHO
Hello Daniel, Attached is a v2 fixing the bugs you mentioned, and adding ---csv/-C as discussed upthread. I'll add some regression tests shortly. Basically I'm waiting for the version with regression tests before reviewing. It is unclear whether committer will like it. From my point of vi

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-07 Thread Tomas Vondra
On 03/07/2018 09:55 AM, Arthur Zakirov wrote: > Hello Andres, > > On Thu, Mar 01, 2018 at 08:31:49PM -0800, Andres Freund wrote: >> Is there any chance we can instead can convert dictionaries into a form >> we can just mmap() into memory? That'd scale a lot higher and more >> dynamicallly? > >

Re: csv format for psql

2018-03-07 Thread Pavel Stehule
2018-03-07 10:45 GMT+01:00 Fabien COELHO : > > Hello Daniel, > > Attached is a v2 fixing the bugs you mentioned, and adding ---csv/-C >> as discussed upthread. I'll add some regression tests shortly. >> > > Basically I'm waiting for the version with regression tests before > reviewing. > > It is u

Re: Some message fixes

2018-03-07 Thread Alvaro Herrera
Kyotaro HORIGUCHI wrote: > 1. some messages are missing partitioned table/index > > The first attached. I'm not sure how the orering ought to be > but I arranged them in mainly in the appearance order in if() > conditions, or the order of case label in switch() > construct. One exception

Re: parallel append vs. simple UNION ALL

2018-03-07 Thread Rajkumar Raghuwanshi
Hi, With 0001 applied on PG-head, I got reference leak warning and later a server crash. this crash is reproducible with enable_parallel_append=off also. below is the test case to reproduce this. SET enable_parallel_append=off; SET parallel_setup_cost=0; SET parallel_tuple_cost=0; SET min_paralle

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

2018-03-07 Thread Alvaro Herrera
Andreas Karlsson wrote: > On 02/06/2018 11:15 AM, Mark Rofail wrote: > > A new patch including all the fixes is ready. > > > > Can you give the docs another look. I re-wrapped, re-indented  and > > changed all `Foreign Key Arrays` to `Array Element Foreign Keys` for > > consistency. > > Looks goo

Re: Protect syscache from bloating with negative cache entries

2018-03-07 Thread Alvaro Herrera
The thing that comes to mind when reading this patch is that some time ago we made fun of other database software, "they are so complicated to configure, they have some magical settings that few people understand how to set". Postgres was so much better because it was simple to set up, no magic cr

Re: using index or check in ALTER TABLE SET NOT NULL

2018-03-07 Thread Ildar Musin
Hello Sergei, Alvaro, Tom, On 06.03.2018 20:25, Alvaro Herrera wrote: You should be able to use an event trigger that raises a message when table_rewrite is hit, to notify the test driver that a rewrite happens. (If any DDL that causes a table rewrite fails to trigger the table_rewrite event co

Re: [HACKERS] Partition-wise aggregation/grouping

2018-03-07 Thread Ashutosh Bapat
On Wed, Mar 7, 2018 at 10:04 AM, Ashutosh Bapat wrote: > On Tue, Mar 6, 2018 at 7:52 PM, Jeevan Chalke > wrote: > >> >> >> Changes look good to me and refactoring will be useful for partitionwise >> patches. >> >> However, will it be good if we add agg_costs into the GroupPathExtraData >> too? >>

Re: public schema default ACL

2018-03-07 Thread Petr Jelinek
On 07/03/18 08:23, Noah Misch wrote: > On Tue, Mar 06, 2018 at 09:28:21PM -0500, Stephen Frost wrote: >> * Tom Lane (t...@sss.pgh.pa.us) wrote: >>> Robert Haas writes: On Sat, Mar 3, 2018 at 4:56 AM, Noah Misch wrote: > I propose, for v11, switching to "GRANT USAGE ON SCHEMA > public

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-07 Thread Arthur Zakirov
On Wed, Mar 07, 2018 at 10:55:29AM +0100, Tomas Vondra wrote: > On 03/07/2018 09:55 AM, Arthur Zakirov wrote: > > Hello Andres, > > > > On Thu, Mar 01, 2018 at 08:31:49PM -0800, Andres Freund wrote: > >> Is there any chance we can instead can convert dictionaries into a form > >> we can just mmap(

Re: [HACKERS] path toward faster partition pruning

2018-03-07 Thread Amit Langote
Hi. On 2018/03/05 17:38, Amit Langote wrote: > I'll > post an update in a couple of days to report on how that works out. I'm still working on this and getting most of the tests to pass with the new code, but not all of them yet. Thanks, Amit

Re: Add default role 'pg_access_server_files'

2018-03-07 Thread Stephen Frost
Greetings Michael, * Michael Paquier (mich...@paquier.xyz) wrote: > On Tue, Mar 06, 2018 at 10:00:54AM -0500, Stephen Frost wrote: > > Attached is an updated patch which splits up the permissions as > > suggested up-thread by Magnus: > > > > The default roles added are: > > > > * pg_read_server_

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-07 Thread Pavel Stehule
2018-03-07 12:55 GMT+01:00 Arthur Zakirov : > On Wed, Mar 07, 2018 at 10:55:29AM +0100, Tomas Vondra wrote: > > On 03/07/2018 09:55 AM, Arthur Zakirov wrote: > > > Hello Andres, > > > > > > On Thu, Mar 01, 2018 at 08:31:49PM -0800, Andres Freund wrote: > > >> Is there any chance we can instead can

Re: Rewrite of pg_dump TAP tests

2018-03-07 Thread Stephen Frost
Michael, * Michael Paquier (mich...@paquier.xyz) wrote: > On Tue, Mar 06, 2018 at 11:53:41AM -0500, Stephen Frost wrote: > > * Stephen Frost (sfr...@snowman.net) wrote: > >> Attached is a patch (which applies cleaning against a2a2205, but not so > >> much anymore, obviously, but I will fix after t

Re: public schema default ACL

2018-03-07 Thread Stephen Frost
Greetings, * Noah Misch (n...@leadboat.com) wrote: > On Tue, Mar 06, 2018 at 09:28:21PM -0500, Stephen Frost wrote: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > > I wonder whether it'd be sensible for CREATE USER --- or at least the > > > createuser script --- to automatically make a matching sc

Re: public schema default ACL

2018-03-07 Thread Stephen Frost
Greetings, * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > Certain "market leader" database behaves this way as well. I just hope > we won't go as far as them and also create users for schemas (so that > the analogy of user=schema would be complete and working both ways). > Because that's o

Re: User defined data types in Logical Replication

2018-03-07 Thread Masahiko Sawada
On Wed, Mar 7, 2018 at 2:52 AM, Alvaro Herrera wrote: > Masahiko Sawada wrote: >> On Tue, Mar 6, 2018 at 8:35 AM, Alvaro Herrera >> wrote: > >> > Therefore, I'm inclined to make this function raise a warning, then >> > return a substitute value (something like "unrecognized type XYZ"). >> > [...

Typo in objectaccess.h prototype

2018-03-07 Thread Daniel Gustafsson
s/ereport_on_volation/ereport_on_violation/ as per the attached patch. cheers ./daniel typo-objectaccess.patch Description: Binary data

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2018-03-07 Thread Andrey Borodin
Hi! > 28 февр. 2018 г., в 22:19, Shubham Barai > написал(а): > > Sure. I have attached a rebased version I've looked into the code closely again. The patch is heavily reworked since GSoC state :) Tests are looking fine and locking is fine-grained. But there is one thing I could not understand

Re: Re: [HACKERS] Subscription code improvements

2018-03-07 Thread Masahiko Sawada
On Tue, Mar 6, 2018 at 11:17 PM, David Steele wrote: > Hi Masahiko, > > On 1/30/18 5:00 AM, Masahiko Sawada wrote: >> On Fri, Jan 26, 2018 at 11:41 AM, Peter Eisentraut >> wrote: >>> On 1/24/18 02:33, Masahiko Sawada wrote: Thank you for notification. Since it seems to me that no one is

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-07 Thread Arthur Zakirov
On Wed, Mar 07, 2018 at 01:02:07PM +0100, Pavel Stehule wrote: > > Understand. I'm not againts the mmap() approach, just I have lack of > > understanding mmap() benefits... Current shared Ispell approach requires > > preprocessing after server restarting, and the main advantage of mmap() > > here >

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-07 Thread Pavel Stehule
2018-03-07 13:43 GMT+01:00 Arthur Zakirov : > On Wed, Mar 07, 2018 at 01:02:07PM +0100, Pavel Stehule wrote: > > > Understand. I'm not againts the mmap() approach, just I have lack of > > > understanding mmap() benefits... Current shared Ispell approach > requires > > > preprocessing after server

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-07 Thread Arthur Zakirov
On Wed, Mar 07, 2018 at 01:47:25PM +0100, Pavel Stehule wrote: > > Do you mean that a shared dictionary should be reloaded if its .affix > > and .dict files was changed? IMHO we can store last modification > > timestamp of them in a preprocessed file, and then we can rebuild the > > dictionary if f

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-07 Thread Pavel Stehule
2018-03-07 13:58 GMT+01:00 Arthur Zakirov : > On Wed, Mar 07, 2018 at 01:47:25PM +0100, Pavel Stehule wrote: > > > Do you mean that a shared dictionary should be reloaded if its .affix > > > and .dict files was changed? IMHO we can store last modification > > > timestamp of them in a preprocessed

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-07 Thread Pavel Stehule
2018-03-07 14:10 GMT+01:00 Pavel Stehule : > > > 2018-03-07 13:58 GMT+01:00 Arthur Zakirov : > >> On Wed, Mar 07, 2018 at 01:47:25PM +0100, Pavel Stehule wrote: >> > > Do you mean that a shared dictionary should be reloaded if its .affix >> > > and .dict files was changed? IMHO we can store last m

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2018-03-07 Thread Prabhat Sahu
Hi all, While testing this feature I found a crash on PG head with parallel create index using pgbanch tables. -- GUCs under postgres.conf max_parallel_maintenance_workers = 16 max_parallel_workers = 16 max_parallel_workers_per_gather = 8 maintenance_work_mem = 8GB max_wal_size = 4GB ./pgbench -

Re: [PROPOSAL] Shared Ispell dictionaries

2018-03-07 Thread Arthur Zakirov
On Wed, Mar 07, 2018 at 02:12:32PM +0100, Pavel Stehule wrote: > 2018-03-07 14:10 GMT+01:00 Pavel Stehule : > > 2018-03-07 13:58 GMT+01:00 Arthur Zakirov : > >> Oh understood. Tomas suggested those commands too earlier. I'll > >> implement them. But I think it is better to track files modification

Re: General purpose hashing func in pgbench

2018-03-07 Thread Ildar Musin
Hello Teodor, 1) Seems, it's good idea to add credits to Austin Appleby to comments. Done. Also rebased to the latest master. I think that both points refer to the fact that original algorithm accepts a byte string as an input, slices it up by 8 bytes and form unsigned int values from it.

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2018-03-07 Thread Robert Haas
On Wed, Mar 7, 2018 at 8:13 AM, Prabhat Sahu wrote: > Hi all, > > While testing this feature I found a crash on PG head with parallel create > index using pgbanch tables. > > -- GUCs under postgres.conf > max_parallel_maintenance_workers = 16 > max_parallel_workers = 16 > max_parallel_workers_per

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2018-03-07 Thread Prabhat Sahu
On Wed, Mar 7, 2018 at 7:16 PM, Robert Haas wrote: > On Wed, Mar 7, 2018 at 8:13 AM, Prabhat Sahu < > prabhat.s...@enterprisedb.com> wrote: > >> Hi all, >> >> While testing this feature I found a crash on PG head with parallel >> create index using pgbanch tables. >> >> -- GUCs under postgres.con

Re: Typo in objectaccess.h prototype

2018-03-07 Thread Peter Eisentraut
On 3/7/18 07:23, Daniel Gustafsson wrote: > s/ereport_on_volation/ereport_on_violation/ as per the attached patch. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] Subscription code improvements

2018-03-07 Thread Alvaro Herrera
0001: there are a bunch of other messages of the same ilk in the file. I don't like how the current messages are worded; maybe Peter or Petr had some reason why they're like that, but I would have split out the reason for not starting or stopping into errdetail. Something like errmsg("logical r

Re: [HACKERS] Subscription code improvements

2018-03-07 Thread Alvaro Herrera
0002 looks like a good improvement to me. The existing routine is messy, and apparently it's so just to save one LockSharedObject plus cache lookup; IMO it's not worth it. Patched code looks simpler. If there are cases where having the combined behavior is useful, it's not clear what they are.

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2018-03-07 Thread Robert Haas
On Wed, Mar 7, 2018 at 8:59 AM, Prabhat Sahu wrote: > > 2018-03-07 19:24:44.263 IST [54400] LOG: background worker "parallel > worker" (PID 54482) was terminated by signal 9: Killed > That looks like the background worker got killed by the OOM killer. How much memory do you have in the machine

Re: public schema default ACL

2018-03-07 Thread Peter Eisentraut
On 3/6/18 15:20, Robert Haas wrote: > On Sat, Mar 3, 2018 at 4:56 AM, Noah Misch wrote: >> I propose, for v11, switching to "GRANT USAGE ON SCHEMA >> public TO PUBLIC" (omit CREATE). Concerns? An alternative is to change the >> default search_path to "$user"; that would be break more application

Re: [HACKERS] Subscription code improvements

2018-03-07 Thread David Steele
On 3/7/18 7:41 AM, Masahiko Sawada wrote: > On Tue, Mar 6, 2018 at 11:17 PM, David Steele wrote: >> Hi Masahiko, >> >> On 1/30/18 5:00 AM, Masahiko Sawada wrote: >>> On Fri, Jan 26, 2018 at 11:41 AM, Peter Eisentraut >>> wrote: On 1/24/18 02:33, Masahiko Sawada wrote: > Thank you for not

Re: [HACKERS] Partition-wise aggregation/grouping

2018-03-07 Thread Jeevan Chalke
On Tue, Mar 6, 2018 at 4:59 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > Hi Jeevan, > I am back reviewing this. Here are some comments. > > @@ -1415,7 +1413,8 @@ add_paths_to_append_rel(PlannerInfo *root, > RelOptInfo *rel, > * the unparameterized Append path we are con

Re: jsonpath

2018-03-07 Thread Nikita Glukhov
On 02.03.2018 00:57, Alexander Korotkov wrote: On Fri, Mar 2, 2018 at 12:40 AM, Nikita Glukhov mailto:n.glu...@postgrespro.ru>> wrote: On 28.02.2018 06:55, Robert Haas wrote: On Mon, Feb 26, 2018 at 10:34 AM, Nikita Glukhov mailto:n.glu...@postgrespro.ru>> wrote:

Re: Re: PATCH: pgbench - break out timing data for initialization phases

2018-03-07 Thread David Steele
Hi Doug, On 3/1/18 3:57 AM, Andres Freund wrote: > Hi, > > On 2018-02-21 17:58:49 +, Rady, Doug wrote: >> - move the time measure in the initialization loop, instead of doing it >> in each function, so that it is done just in one place. >> >> I will do this. > > Given the last v11

Re: public schema default ACL

2018-03-07 Thread Alvaro Herrera
Stephen Frost wrote: > * Noah Misch (n...@leadboat.com) wrote: > > I like the idea of getting more SQL-compatible, if this presents a distinct > > opportunity to do so. I do think it would be too weird to create the schema > > in one database only. Creating it on demand might work. What would

Re: Re: WIP Patch: Precalculate stable functions, infrastructure v1

2018-03-07 Thread David Steele
On 3/3/18 2:42 AM, Marina Polyakova wrote: > Ok! > > On 02-03-2018 22:56, Andres Freund wrote: >> Hi, >> >> On 2018-03-02 11:22:01 +0300, Marina Polyakova wrote: >>> I fixed the failure that Thomas pointed out to me, and I'm finishing >>> work on >>> it, but it took me a while to study this part o

Re: [HACKERS] Subscription code improvements

2018-03-07 Thread Alvaro Herrera
David Steele wrote: > I'm marking this submission Returned with Feedback. Not yet please. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] Partition-wise aggregation/grouping

2018-03-07 Thread Jeevan Chalke
On Wed, Mar 7, 2018 at 1:45 AM, Robert Haas wrote: > On Tue, Mar 6, 2018 at 5:31 AM, Jeevan Chalke > wrote: > > This is in-lined with enable_hashagg GUC. Do you think > > enable_partitionwise_aggregate seems better? But it will be not > consistent > > with other GUC names like enable_hashagg the

Re: [HACKERS] Subscription code improvements

2018-03-07 Thread David Steele
On 3/7/18 9:37 AM, Alvaro Herrera wrote: > David Steele wrote: > >> I'm marking this submission Returned with Feedback. > > Not yet please. Back to Waiting on Author state. Regards, -- -David da...@pgmasters.net

Re: public schema default ACL

2018-03-07 Thread Tom Lane
Alvaro Herrera writes: > Now, maybe the idea of creating it as soon as a connection is > established is not great. What about creating it only when the first > object creation is attempted and there is no other schema to create in? > This avoid pointless proliferation of empty user schemas, as we

Re: Re: [PATCH] GET DIAGNOSTICS FUNCTION_NAME

2018-03-07 Thread David Steele
On 3/5/18 10:09 PM, Yugo Nagata wrote: > On Thu, 1 Mar 2018 14:29:58 -0800 > Andres Freund wrote: > >> Hi, >> >> On 2018-01-11 11:03:26 +0900, Yugo Nagata wrote: >>> However, I don't inisist on this patch, so If anyone other don't need this >>> feature, I'll withdraw this. >> >> Given this is whe

Re: GSoC 2017: weekly progress reports (week 6)

2018-03-07 Thread Alvaro Herrera
Andres Freund wrote: > This appears to be a duplicate of https://commitfest.postgresql.org/17/1466/ > - as the other one is older, I'm closing this one. This comment makes no sense from the POV of the mail archives. I had to look at the User-Agent in your email to realize that you wrote it in t

Re: public schema default ACL

2018-03-07 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > Stephen Frost wrote: > > > * Noah Misch (n...@leadboat.com) wrote: > > > > I like the idea of getting more SQL-compatible, if this presents a > > > distinct > > > opportunity to do so. I do think it would be too weird to create the

Re: [PATCH][PROPOSAL] Add enum releation option type

2018-03-07 Thread Nikolay Shaplov
В письме от 1 марта 2018 19:11:05 пользователь Nikita Glukhov написал: > Hi. > > I have refactored patch by introducing new struct relop_enum_element to make > it possible to use existing C-enum values in option's definition. So, > additional enum GIST_OPTION_BUFFERING_XXX was removed. Hi! I've i

Re: Implementing SQL ASSERTION

2018-03-07 Thread David Fetter
On Mon, Jan 15, 2018 at 09:14:02PM +, Joe Wildish wrote: > Hi David, > > > On 15 Jan 2018, at 16:35, David Fetter wrote: > > > > It sounds reasonable enough that I'd like to make a couple of Modest > > Proposals™, to wit: > > > > - We follow the SQL standard and make SERIALIZABLE the defaul

Re: [PATCH][PROPOSAL] Add enum releation option type

2018-03-07 Thread Nikolay Shaplov
В письме от 1 марта 2018 14:47:35 пользователь Alvaro Herrera написал: > I see you lost the Oxford comma: > > -DETAIL: Valid values are "on", "off", and "auto". > +DETAIL: Valid values are "auto", "on" and "off". > > Please put these back. Actually that's me who have lost it. The code with ox

Re: public schema default ACL

2018-03-07 Thread Petr Jelinek
On 07/03/18 13:18, Stephen Frost wrote: > Greetings, > > * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: >> Certain "market leader" database behaves this way as well. I just hope >> we won't go as far as them and also create users for schemas (so that >> the analogy of user=schema would be co

Re: public schema default ACL

2018-03-07 Thread Stephen Frost
Greeting Petr, all, * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > On 07/03/18 13:18, Stephen Frost wrote: > > Greetings, > > > > * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > >> Certain "market leader" database behaves this way as well. I just hope > >> we won't go as far as the

Limit global default function execution privileges

2018-03-07 Thread David G. Johnston
Since we are discussing locking down our defaults is revoking the global function execution privilege granted to PUBLIC - instead limiting it to just the pg_catalog schema - on the table? I'm not sure how strongly I feel toward the proposal but it does come up on these lists; and the fact that it

Re: BUG #14941: Vacuum crashes

2018-03-07 Thread Bossart, Nathan
On 3/6/18, 11:04 PM, "Michael Paquier" wrote: > + if (!(options & VACOPT_SKIP_LOCKED)) > + relid = RangeVarGetRelid(vrel->relation, AccessShareLock, > false); > + else > + { > + relid = RangeVarGetRelid(vrel->relation, NoLock, false); > Yeah, I agree with Andr

Re: Limit global default function execution privileges

2018-03-07 Thread Stephen Frost
Greetings, * David G. Johnston (david.g.johns...@gmail.com) wrote: > Since we are discussing locking down our defaults is revoking the global > function execution privilege granted to PUBLIC - instead limiting it to > just the pg_catalog schema - on the table? > > I'm not sure how strongly I feel

Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead

2018-03-07 Thread Nikolay Shaplov
В письме от 2 марта 2018 11:27:49 пользователь Andres Freund написал: > > Since I get a really big patch as a result, it was decided to commit it in > > parts. > > I get that, but I strongly suggest not creating 10 loosely related > threads, but keeping it as a patch series in one thread. It's re

Re: [PATCH][PROPOSAL] Add enum releation option type

2018-03-07 Thread Alvaro Herrera
Nikolay Shaplov wrote: > Actually that's me who have lost it. Yeah, I realized today when I saw your reply to Nikita. I didn't realize it was him submitting a new version of the patch. > The code with oxford comma would be a > bit more complicated. We should put such coma when we have 3+ item

Re: PATCH: Configurable file mode mask

2018-03-07 Thread David Steele
On 3/6/18 10:04 PM, Michael Paquier wrote: > On Tue, Mar 06, 2018 at 01:32:49PM -0500, David Steele wrote: >> On 3/5/18 10:46 PM, Michael Paquier wrote: > >>> Those two are separate issues. Could you begin a new thread on the >>> matter? This will attract more attention. >> >> OK, I'll move it b

Re: [GSOC 18] Discussion on the datatable

2018-03-07 Thread Mark Wong
Hi Hongyuan, On Tue, Mar 06, 2018 at 01:36:23AM +0800, Hongyuan Ma wrote: > Hi Mark, > In the past few days I have read some code in pgperffarm.git repository.I > look forward to discussing the project in detail with you and gradually > defining the datasheet structure and refining the requireme

Re: public schema default ACL

2018-03-07 Thread Petr Jelinek
On 07/03/18 16:26, Stephen Frost wrote: > Greeting Petr, all, > > * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: >> On 07/03/18 13:18, Stephen Frost wrote: >>> Greetings, >>> >>> * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: Certain "market leader" database behaves this way as we

Re: public schema default ACL

2018-03-07 Thread Petr Jelinek
On 07/03/18 13:14, Stephen Frost wrote: > Greetings, > > * Noah Misch (n...@leadboat.com) wrote: >> On Tue, Mar 06, 2018 at 09:28:21PM -0500, Stephen Frost wrote: >>> * Tom Lane (t...@sss.pgh.pa.us) wrote: I wonder whether it'd be sensible for CREATE USER --- or at least the createuser s

Re: Change RangeVarGetRelidExtended() to take flags argument?

2018-03-07 Thread Bossart, Nathan
On 3/5/18, 7:08 PM, "Andres Freund" wrote: > On 2018-03-05 19:57:44 -0500, Tom Lane wrote: >> Andres Freund writes: >>> One wrinkle in that plan is that it'd not be trivial to discern whether >>> a lock couldn't be acquired or whether the object vanished. I don't >>> really have good idea how to

Re: public schema default ACL

2018-03-07 Thread Stephen Frost
Greetings Petr, all, * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > On 07/03/18 16:26, Stephen Frost wrote: > > Greeting Petr, all, > > > > * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > >> On 07/03/18 13:18, Stephen Frost wrote: > >>> Greetings, > >>> > >>> * Petr Jelinek (petr.j

Re: public schema default ACL

2018-03-07 Thread Stephen Frost
Greetings Petr, all, * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > On 07/03/18 13:14, Stephen Frost wrote: > > * Noah Misch (n...@leadboat.com) wrote: > >> On Tue, Mar 06, 2018 at 09:28:21PM -0500, Stephen Frost wrote: > >>> * Tom Lane (t...@sss.pgh.pa.us) wrote: > I wonder whether i

Re: public schema default ACL

2018-03-07 Thread Petr Jelinek
On 07/03/18 17:55, Stephen Frost wrote: > Greetings Petr, all, > > * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: >> On 07/03/18 13:14, Stephen Frost wrote: >>> * Noah Misch (n...@leadboat.com) wrote: On Tue, Mar 06, 2018 at 09:28:21PM -0500, Stephen Frost wrote: > * Tom Lane (t...@

Re: public schema default ACL

2018-03-07 Thread Stephen Frost
Greetings Petr, * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > On 07/03/18 17:55, Stephen Frost wrote: > > Greetings Petr, all, > > > > * Petr Jelinek (petr.jeli...@2ndquadrant.com) wrote: > >> On 07/03/18 13:14, Stephen Frost wrote: > >>> * Noah Misch (n...@leadboat.com) wrote: > On

Re: FOR EACH ROW triggers on partitioned tables

2018-03-07 Thread Alvaro Herrera
Here's another version of this patch. It is virtually identical to the previous one, except for a small doc update and whitespace changes. To recap: when a row-level trigger is created on a partitioned table, it is marked tginherits; partitions all have their pg_class row modified with relhastrig

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2018-03-07 Thread Alvaro Herrera
I suggest to create a new function GinPredicateLockPage() that checks whether fast update is enabled for the index. The current arrangement looks too repetitive and it seems easy to make a mistake. Stylistically, please keep #include lines ordered alphabetically, and cut long lines to below 80 ch

Re: GSoC 2017: weekly progress reports (week 6)

2018-03-07 Thread Andres Freund
Hi, On 2018-03-07 11:58:51 -0300, Alvaro Herrera wrote: > > This appears to be a duplicate of > > https://commitfest.postgresql.org/17/1466/ - as the other one is older, I'm > > closing this one. > > This comment makes no sense from the POV of the mail archives. I had to > look at the User-Age

Re: Protect syscache from bloating with negative cache entries

2018-03-07 Thread Andres Freund
Hi, On 2018-03-07 08:01:38 -0300, Alvaro Herrera wrote: > I wonder if this is just because we refuse to acknowledge the notion of > a connection pooler. If we did, and the pooler told us "here, this > session is being given back to us by the application, we'll keep it > around until the next app

Re: Protect syscache from bloating with negative cache entries

2018-03-07 Thread Alvaro Herrera
Hello, Andres Freund wrote: > On 2018-03-07 08:01:38 -0300, Alvaro Herrera wrote: > > I wonder if this is just because we refuse to acknowledge the notion of > > a connection pooler. If we did, and the pooler told us "here, this > > session is being given back to us by the application, we'll kee

Re: Protect syscache from bloating with negative cache entries

2018-03-07 Thread Andres Freund
On 2018-03-07 14:48:48 -0300, Alvaro Herrera wrote: > Oh, I wasn't suggesting to throw away the whole cache at that point; > only that that is a convenient to do whatever cleanup we want to do. But why is that better than doing so continuously? > What I'm not clear about is exactly what is the c

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

2018-03-07 Thread Matheus de Oliveira
Em 2 de mar de 2018 08:15, "Andres Freund" escreveu: Hi, On 2018-02-20 12:10:22 -0300, Matheus de Oliveira wrote: > I attached a patch to add support for changing ON UPDATE/DELETE actions of > a constraint using ALTER TABLE ... ALTER CONSTRAINT. This patch has been submitted to the last commit

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

2018-03-07 Thread Matheus de Oliveira
Em 3 de mar de 2018 19:32, "Peter Eisentraut" < peter.eisentr...@2ndquadrant.com> escreveu: On 2/20/18 10:10, Matheus de Oliveira wrote: > Besides that, there is a another change in this patch on current ALTER > CONSTRAINT about deferrability options. Previously, if the user did > ALTER CONSTRAINT

Re: csv format for psql

2018-03-07 Thread Fabien COELHO
Hello Pavel, psql --csv 'TABLE Stuff;' > stuff.csv There is commad -c and it should be used. The --csv options should not to have a parameter. I don't like a idea to have more options for query execution. Yes, I agree and that is indeed what I meant, sorry for the typo. The cleaner

Re: csv format for psql

2018-03-07 Thread Pavel Stehule
2018-03-07 19:40 GMT+01:00 Fabien COELHO : > > Hello Pavel, > > psql --csv 'TABLE Stuff;' > stuff.csv >>> >> >> There is commad -c and it should be used. The --csv options should not to >> have a parameter. I don't like a idea to have more options for query >> execution. >> > > Yes, I agre

Re: csv format for psql

2018-03-07 Thread David Fetter
On Wed, Mar 07, 2018 at 07:40:49PM +0100, Fabien COELHO wrote: > > Hello Pavel, > > >>psql --csv 'TABLE Stuff;' > stuff.csv > > > >There is commad -c and it should be used. The --csv options should not to > >have a parameter. I don't like a idea to have more options for query > >execution

Re: pgbench's expression parsing & negative numbers

2018-03-07 Thread Fabien COELHO
Hello Andres, working on overflow correctness in pg I noticed that pgbench isn't quite there. Indeed. I assume it won't matter terribly often, but the way it parses integers makes it incorrect for, at least, the negativemost number. [...] but that unfortunately means that the sign is no in

Re: parallel append vs. simple UNION ALL

2018-03-07 Thread Robert Haas
On Wed, Mar 7, 2018 at 5:36 AM, Rajkumar Raghuwanshi wrote: > With 0001 applied on PG-head, I got reference leak warning and later a > server crash. > this crash is reproducible with enable_parallel_append=off also. > below is the test case to reproduce this. New patches attached, fixing all 3 of

Re: csv format for psql

2018-03-07 Thread Fabien COELHO
psql --csv -c 'TABLE foo' > foo.csv With a -c to introduce the command. This seems pretty specialized. If we're adding something new, how about psql --format=csv -o foo.csv -c 'TABLE foo' Or we could stick with: psql -P format=csv -o foo.csv -c 'TABLE foo' Currently "-P format=c

Fix missing spaces in docs

2018-03-07 Thread Fabrízio de Royes Mello
Hi all, The attached patch just fix missing spaces in documentation of CREATE SERVER and CREATE USER MAPPING. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/

Re: csv format for psql

2018-03-07 Thread David Fetter
On Wed, Mar 07, 2018 at 08:04:05PM +0100, Fabien COELHO wrote: > > >> psql --csv -c 'TABLE foo' > foo.csv > >> > >>With a -c to introduce the command. > > > >This seems pretty specialized. If we're adding something new, how about > > > > psql --format=csv -o foo.csv -c 'TABLE foo' > > > >Or we

Re: csv format for psql

2018-03-07 Thread Pavel Stehule
2018-03-07 20:25 GMT+01:00 David Fetter : > On Wed, Mar 07, 2018 at 08:04:05PM +0100, Fabien COELHO wrote: > > > > >> psql --csv -c 'TABLE foo' > foo.csv > > >> > > >>With a -c to introduce the command. > > > > > >This seems pretty specialized. If we're adding something new, how about > > > > >

Re: csv format for psql

2018-03-07 Thread Daniel Verite
I wrote: > a better idea would to have a new \pset fieldsep_csv PFA a v3 patch that implements that, along with regression tests this time. Best regards, -- Daniel Vérité PostgreSQL-powered mailer: http://www.manitou-mail.org Twitter: @DanielVerite diff --git a/doc/src/sgml/ref/psql-ref.sgml b

Re: csv format for psql

2018-03-07 Thread Daniel Verite
David Fetter wrote: > This seems pretty specialized. If we're adding something new, how about > >psql --format=csv -o foo.csv -c 'TABLE foo' It's a bit easier to memorize than -P format=csv, but psql doesn't have any long option that does not a have a short form with a single lette

Re: planner failure with ProjectSet + aggregation + parallel query

2018-03-07 Thread Robert Haas
On Mon, Mar 5, 2018 at 10:38 AM, Robert Haas wrote: > While trying to track down a bug today, I found a different bug. > > As of 6946280cded903b6f5269fcce105f8ab1d455d33: > > rhaas=# create table foo (a int); > CREATE TABLE > rhaas=# set min_parallel_table_scan_size = 0; > SET > rhaas=# set parall

Re: Protect syscache from bloating with negative cache entries

2018-03-07 Thread Robert Haas
On Wed, Mar 7, 2018 at 6:01 AM, Alvaro Herrera wrote: > The thing that comes to mind when reading this patch is that some time > ago we made fun of other database software, "they are so complicated to > configure, they have some magical settings that few people understand > how to set". Postgres

Re: csv format for psql

2018-03-07 Thread Daniel Verite
David Fetter wrote: > We have some inconsistency here in that fewer table formats are > supported, but I think asciidoc, etc., do this correctly via > invocations like: > >psql -P format=asciidoc -o foo.adoc -AtXc 'TABLE foo' -A is equivalent to -P format=unaligned, so in the above i

Re: FOR EACH ROW triggers on partitioned tables

2018-03-07 Thread Thomas Munro
On Thu, Mar 8, 2018 at 6:17 AM, Alvaro Herrera wrote: > Here's another version of this patch. It is virtually identical to the > previous one, except for a small doc update and whitespace changes. What is this test for? +create trigger failed after update on parted_trig + referencing old table

Re: csv format for psql

2018-03-07 Thread Pavel Stehule
2018-03-07 21:31 GMT+01:00 Daniel Verite : > David Fetter wrote: > > > We have some inconsistency here in that fewer table formats are > > supported, but I think asciidoc, etc., do this correctly via > > invocations like: > > > >psql -P format=asciidoc -o foo.adoc -AtXc 'TABLE foo' > >

Re: Server won't start with fallback setting by initdb.

2018-03-07 Thread Robert Haas
On Tue, Mar 6, 2018 at 10:51 PM, Stephen Frost wrote: > Changing the defaults to go back down strikes me as an entirely wrong > approach after we've had a release with the higher defaults without > seriously compelling arguments against, and I don't agree that we've had > such a case made here. I

Re: RFC: Add 'taint' field to pg_control.

2018-03-07 Thread Robert Haas
On Wed, Feb 28, 2018 at 8:03 PM, Craig Ringer wrote: > A huge +1 from me for the idea. I can't even count the number of black box > "WTF did you DO?!?" servers I've looked at, where bizarre behaviour has > turned out to be down to the user doing something very silly and not saying > anything about

  1   2   >